From e0f3f4ae19da5e14636c128b9f8a896730c0b343 Mon Sep 17 00:00:00 2001 From: Gregory Nutt Date: Mon, 26 Dec 2016 16:12:27 -0600 Subject: [PATCH] Update some coments --- sched/sched/sched_unlock.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/sched/sched/sched_unlock.c b/sched/sched/sched_unlock.c index 0ad26242a7..661c4d9679 100644 --- a/sched/sched/sched_unlock.c +++ b/sched/sched/sched_unlock.c @@ -125,7 +125,13 @@ int sched_unlock(void) * in a critical section, i.e., g_cpu_irqlock is locked , or (2) * other CPUs still have pre-emption disabled, i.e., * g_cpu_schedlock is locked. In those cases, the release of the - * pending tasks must be deferred until those conditions are met.ing + * pending tasks must be deferred until those conditions are met. + * + * REVISIT: This seems incomplete. Apparently there is some + * condition that we must prevent releasing the pending tasks + * when in a critical section. This logic does that, but there + * no corresponding logic to prohibit a new task from being + * started on the g_assignedtasks list. Something is amiss. */ if (!spin_islocked(&g_cpu_schedlock) &&