sergiotarxz/nuttx
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

fs/mount: fix compiler warning found out by GCC-12.2

Browse Source 
mount/fs_foreachmountpoint.c: In function 'mountpoint_filter':
mount/fs_foreachmountpoint.c:99:38: warning: 'sprintf' may write a terminating nul past the end of the destination [-Wformat-overflow=]
   99 |       sprintf(&dirpath[pathlen], "/%s", node->i_name);
      |                                      ^
In function 'mountpoint_filter',
    inlined from 'mountpoint_filter' at mount/fs_foreachmountpoint.c:64:12:
mount/fs_foreachmountpoint.c:99:7: note: 'sprintf' output between 2 and 257 bytes into a destination of size 256
   99 |       sprintf(&dirpath[pathlen], "/%s", node->i_name);
      |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Signed-off-by: chao an <anchao@xiaomi.com>
This commit is contained in:
chao an 2023-02-21 00:13:19 +08:00 committed by Xiang Xiao
parent 60a0c2ed87
commit e28958fe5c
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
fs/mount/fs_foreachmountpoint.c
View File

@ -84,8 +84,8 @@ static int mountpoint_filter(FAR struct inode *node,
* name and the path to the directory containing the inode.
*/
pathlen = strlen(dirpath);
namlen = strlen(node->i_name) + 1;
pathlen = strnlen(dirpath, PATH_MAX);
namlen = strnlen(node->i_name, PATH_MAX) + 1;
/* Make sure that this would not exceed the maximum path length */