sergiotarxz/nuttx
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

net/udp: Fixed the issue of sending ICMP error when the destination address is broadcast/multicast.

Browse Source 
According to rfc1112, section 7.2:
"An ICMP error message (Destination Unreachable, Time Exceeded, Parameter Problem, Source Quench, or Redirect) is
never generated in response to a datagram destined to an IP host group."

Signed-off-by: zhangshuai39 <zhangshuai39@xiaomi.com>
This commit is contained in:
zhangshuai39 2024-09-03 14:25:38 +08:00 committed by Xiang Xiao
parent e49f4b2124
commit e7ec9d7fe5
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
net/udp/udp_input.c
View File

@ -77,7 +77,7 @@
*
****************************************************************************/
#if defined(CONFIG_NET_SOCKOPTS) && defined(CONFIG_NET_BROADCAST)
#ifdef CONFIG_NET_BROADCAST
static bool udp_is_broadcast(FAR struct net_driver_s *dev)
{
/* Check if the destination address is a broadcast/multicast address */
@ -329,6 +329,16 @@ static int udp_input(FAR struct net_driver_s *dev, unsigned int iplen)
ret = udp_input_conn(dev, conn, udpiplen);
}
#ifdef CONFIG_NET_BROADCAST
else if (udp_is_broadcast(dev))
{
/* Due to RFC 1112, Section 7.2, we don't reply ICMP error
* message when the destination address is broadcast/multicast.
*/
dev->d_len = 0;
}
#endif
else
{
nwarn("WARNING: No listener on UDP port\n");