sergiotarxz/nuttx
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

sched/task/task_spawn.c: initialize variables explicitly

Browse Source 
'pid' cannot really be used uninitialized, but Clang analyzer does not
see it.  Add initializer to silence it and also make debugging slightly
easier.

Explicitly set pid's address to NULL to fix this complaint:

  "Address of stack memory associated with local variable 'pid' is still
   referred to by the global variable 'g_spawn_parms' upon returning to
   the caller."

No functional change.

Signed-off-by: Juha Niskanen <juha.niskanen@haltian.com>
This commit is contained in:
Juha Niskanen 2021-06-07 15:21:19 +03:00 committed by Xiang Xiao
parent a4289c4f84
commit ea1144630d
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sched/task/task_spawn.c
View File

@ -312,7 +312,7 @@ int task_spawn(FAR const char *name, main_t entry,
{
struct sched_param param;
pid_t proxy;
pid_t pid;
pid_t pid = INVALID_PROCESS_ID;
#ifdef CONFIG_SCHED_WAITPID
int status;
#endif
@ -374,6 +374,7 @@ int task_spawn(FAR const char *name, main_t entry,
if (ret < 0)
{
serr("ERROR: nxsched_get_param failed: %d\n", ret);
g_spawn_parms.pid = NULL;
spawn_semgive(&g_spawn_parmsem);
return ret;
}
@ -442,6 +443,7 @@ errout_with_lock:
#ifdef CONFIG_SCHED_WAITPID
sched_unlock();
#endif
g_spawn_parms.pid = NULL;
spawn_semgive(&g_spawn_parmsem);
return ret;
}