sergiotarxz/nuttx
sergiotarxz/nuttx
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

arch assertions: Correct duplicated logic from commit dbf01d12b7321d1b48b68d3b69842a853b049376. Checking for PID == zero is not a valid way to test for the IDLE task in all configurations! This is only true in the single CPU configuration. In multiple CPU configurations, there will be a separate IDLE task for each CPU with a different PID.

Browse Source
This commit is contained in:
Gregory Nutt 2018-12-18 17:35:42 -06:00
parent a9626f3ad3
commit ec9265aa95
16 changed files with 16 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
arch/arm/src/arm/up_assert.c
View File

@ -310,7 +310,7 @@ static void _up_assert(int errorcode)
/* Are we in an interrupt handler or the idle task? */
if (CURRENT_REGS || running_task()->pid == 0)
if (CURRENT_REGS || running_task()->flink == NULL)
{
(void)up_irq_save();
for (; ; )

2
arch/arm/src/armv6-m/up_assert.c
View File

@ -367,7 +367,7 @@ static void _up_assert(int errorcode)
/* Are we in an interrupt handler or the idle task? */
if (CURRENT_REGS || running_task()->pid == 0)
if (CURRENT_REGS || running_task()->flink == NULL)
{
(void)up_irq_save();
for (; ; )

2
arch/arm/src/armv7-a/arm_assert.c
View File

@ -395,7 +395,7 @@ static void _up_assert(int errorcode)
/* Are we in an interrupt handler or the idle task? */
if (CURRENT_REGS || running_task()->pid == 0)
if (CURRENT_REGS || running_task()->flink == NULL)
{
/* Disable interrupts on this CPU */

2
arch/arm/src/armv7-m/up_assert.c
View File

@ -389,7 +389,7 @@ static void _up_assert(int errorcode)
/* Are we in an interrupt handler or the idle task? */
if (CURRENT_REGS || (running_task())->pid == 0)
if (CURRENT_REGS || (running_task())->flink == NULL)
{
(void)up_irq_save();
for (; ; )

2
arch/arm/src/armv7-r/arm_assert.c
View File

@ -374,7 +374,7 @@ static void _up_assert(int errorcode)
/* Are we in an interrupt handler or the idle task? */
if (CURRENT_REGS || (running_task())->pid == 0)
if (CURRENT_REGS || (running_task())->flink == NULL)
{
(void)up_irq_save();
for (; ; )

2
arch/avr/src/common/up_assert.c
View File

@ -87,7 +87,7 @@ static void _up_assert(int errorcode)
/* Are we in an interrupt handler or the idle task? */
if (g_current_regs || running_task()->pid == 0)
if (g_current_regs || running_task()->flink == NULL)
{
(void)up_irq_save();
for (; ; )

2
arch/hc/src/m9s12/m9s12_assert.c
View File

@ -294,7 +294,7 @@ static void _up_assert(int errorcode)
/* Are we in an interrupt handler or the idle task? */
if (g_current_regs || (running_task())->pid == 0)
if (g_current_regs || (running_task())->flink == NULL)
{
(void)up_irq_save();
for (;;)

2
arch/mips/src/mips32/up_assert.c
View File

@ -86,7 +86,7 @@ static void _up_assert(int errorcode)
/* Are we in an interrupt handler or the idle task? */
if (g_current_regs || running_task()->pid == 0)
if (g_current_regs || running_task()->flink == NULL)
{
(void)up_irq_save();
for (; ; )

2
arch/misoc/src/lm32/lm32_assert.c
View File

@ -87,7 +87,7 @@ static void _up_assert(int errorcode)
/* Are we in an interrupt handler or the idle task? */
if (g_current_regs || running_task()->pid == 0)
if (g_current_regs || running_task()->flink == NULL)
{
(void)up_irq_save();
for (; ; )

2
arch/or1k/src/common/up_assert.c
View File

@ -372,7 +372,7 @@ static void _up_assert(int errorcode)
/* Are we in an interrupt handler or the idle task? */
if (CURRENT_REGS || running_task()->pid == 0)
if (CURRENT_REGS || running_task()->flink == NULL)
{
(void)up_irq_save();
for (; ; )

2
arch/renesas/src/common/up_assert.c
View File

@ -88,7 +88,7 @@ static void _up_assert(int errorcode)
/* Are we in an interrupt handler or the idle task? */
if (g_current_regs || running_task()->pid == 0)
if (g_current_regs || running_task()->flink == NULL)
{
(void)up_irq_save();
for (;;)

2
arch/risc-v/src/rv32im/up_assert.c
View File

@ -87,7 +87,7 @@ static void _up_assert(int errorcode)
/* Are we in an interrupt handler or the idle task? */
if (g_current_regs || running_task()->pid == 0)
if (g_current_regs || running_task()->flink == NULL)
{
(void)up_irq_save();
for (; ; )

2
arch/x86/src/common/up_assert.c
View File

@ -255,7 +255,7 @@ static void _up_assert(int errorcode)
/* Are we in an interrupt handler or the idle task? */
if (g_current_regs || (running_task())->pid == 0)
if (g_current_regs || (running_task())->flink == NULL)
{
(void)up_irq_save();
for (;;)

2
arch/xtensa/src/common/xtensa_assert.c
View File

@ -126,7 +126,7 @@ static void xtensa_assert(int errorcode)
/* Are we in an interrupt handler or the idle task? */
if (CURRENT_REGS || running_task()->pid == 0)
if (CURRENT_REGS || running_task()->flink == NULL)
{
/* Blink the LEDs forever */

2
arch/z16/src/common/up_assert.c
View File

@ -87,7 +87,7 @@ static void _up_assert(int errorcode) /* noreturn_function */
/* Are we in an interrupt handler or the idle task? */
if (up_interrupt_context() || running_task()->pid == 0)
if (up_interrupt_context() || running_task()->flink == NULL)
{
(void)up_irq_save();
for (;;)

2
arch/z80/src/common/up_assert.c
View File

@ -86,7 +86,7 @@ static void _up_assert(int errorcode) /* noreturn_function */
/* Are we in an interrupt handler or the idle task? */
if (up_interrupt_context() || running_task()->pid == 0)
if (up_interrupt_context() || running_task()->flink == NULL)
{
(void)up_irq_save();
for (;;)