sergiotarxz/nuttx
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

gethostbyname_r: Fix check for space in buffer.

Browse Source
This commit is contained in:
Gregory Nutt 2017-06-12 06:47:43 -06:00
parent 85645284b3
commit ee7217be63
1 changed files with 8 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
libc/netdb/lib_gethostbynamer.c
View File

@ -196,12 +196,10 @@ static int lib_numeric_address(FAR const char *name, FAR struct hostent *host,
ptr += addrlen;
buflen -= addrlen;
/* And copy name
* REVISIT: Should the check not be (namelen + 1 > buflen)?
*/
/* And copy name */
namelen = strlen(name);
if (addrlen + namelen + 1 > buflen)
if ((namelen + 1) > buflen)
{
return -ERANGE;
}
@ -286,12 +284,10 @@ static int lib_localhost(FAR const char *name, FAR struct hostent *host,
dest += addrlen;
buflen -= addrlen;
/* And copy name
* REVISIT: Should the check not be (namelen + 1 > buflen)?
*/
/* And copy name */
namelen = strlen(name);
if (addrlen + namelen + 1 > buflen)
if ((namelen + 1) > buflen)
{
return -ERANGE;
}
@ -404,12 +400,10 @@ static int lib_find_answer(FAR const char *name, FAR struct hostent *host,
ptr += addrlen;
buflen -= addrlen;
/* And copy name
* REVISIT: Should the check not be (namelen + 1 > buflen)?
*/
/* And copy name */
namelen = strlen(name);
if (addrlen + namelen + 1 > buflen)
if ((namelen + 1) > buflen)
{
return -ERANGE;
}
@ -552,12 +546,10 @@ static int lib_dns_lookup(FAR const char *name, FAR struct hostent *host,
ptr += addrlen;
buflen -= addrlen;
/* And copy name
* REVISIT: Should the check not be (namelen + 1 > buflen)?
*/
/* And copy name */
namelen = strlen(name);
if (addrlen + namelen + 1 > buflen)
if ((namelen + 1) > buflen)
{
return -ERANGE;
}