From ef72e7e3be79f287d9a75b8b49f8e3e8aafa160c Mon Sep 17 00:00:00 2001 From: patacongo Date: Mon, 27 Aug 2012 14:07:17 +0000 Subject: [PATCH] Dequote Kconfig strings that may be used as components of a path git-svn-id: svn://svn.code.sf.net/p/nuttx/code/trunk@5057 42af7a65-404d-4744-a932-0658087f49c3 --- arch/arm/src/lpc17xx/lpc17_ethernet.c | 21 ++++----------------- 1 file changed, 4 insertions(+), 17 deletions(-) diff --git a/arch/arm/src/lpc17xx/lpc17_ethernet.c b/arch/arm/src/lpc17xx/lpc17_ethernet.c index 6d927892bb..47a22ec2ed 100644 --- a/arch/arm/src/lpc17xx/lpc17_ethernet.c +++ b/arch/arm/src/lpc17xx/lpc17_ethernet.c @@ -2101,23 +2101,10 @@ static inline int lpc17_phyinit(struct lpc17_driver_s *priv) /* Disable auto-configuration. Set the fixed speed/duplex mode. * (probably more than little redundant). * - * REVISIT: Revisit the following CONFIG_PHY_CEMENT_DISABLE work-around: - * - * "... I found this using a LPC1768 dev board with a DP83848I PHY. I'm - * using CONFIG_PHY_DP83848C for that ... I found that a static - * configuration for the PHY gave errors. I didn't investigate why. - * - * "My problem however was that autonegotiation seemingly failed - - * however on debugging I saw the calls for autonegotation were actually - * successful. I tracked the code down to [the following logic] and - * I saw that after the negotation completes, those negotiated - * parameters are then used to set a fixed speed and duplex, "just - * in case". It was that setting of a static configuration which - * failed for me." - * - * "I'm not sure if that's required for other situations or not, so I - * added a #define to optionally elide the call to cement the - * configuration. My PHY appears to be happy with this for the moment." + * REVISIT: Revisit the following CONFIG_PHY_CEMENT_DISABLE work-around. + * It is should not needed if CONFIG_PHY_AUTONEG is defined and is known + * cause a problem for at least one PHY (DP83848I PHY). It might be + * safe just to remove this elided coded for all PHYs. */ #ifndef CONFIG_PHY_CEMENT_DISABLE