sergiotarxz/nuttx
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

net/icmpv6: icmpv6_input() needs to set d_len to 0 after consuming echo reply, otherwise, garbage will get sent out.

Browse Source
This commit is contained in:
Anthony Merlino 2017-11-20 12:15:01 -06:00 committed by Gregory Nutt
parent 92a9a9b678
commit f954345dbe
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
net/icmpv6/icmpv6_input.c
View File

@ -304,7 +304,7 @@ void icmpv6_input(FAR struct net_driver_s *dev)
* response.
*/
goto icmpv_send_nothing;
goto icmpv6_send_nothing;
}
}
@ -384,7 +384,7 @@ void icmpv6_input(FAR struct net_driver_s *dev)
/* Yes.. Notify any waiting threads */
icmpv6_rnotify(dev, ipicmp->srcipaddr, opt->prefix, opt->preflen);
goto icmpv_send_nothing;
goto icmpv6_send_nothing;
}
/* Skip to the next option (units of octets) */
@ -429,7 +429,7 @@ void icmpv6_input(FAR struct net_driver_s *dev)
flags = devif_conn_event(dev, ipicmp, flags, dev->d_conncb);
/* Wwas the ECHO reply consumed by any waiting thread? */
/* Was the ECHO reply consumed by any waiting thread? */
if ((flags & ICMPv6_ECHOREPLY) != 0)
{
@ -465,6 +465,8 @@ void icmpv6_input(FAR struct net_driver_s *dev)
goto icmpv6_drop_packet;
}
}
goto icmpv6_send_nothing;
}
break;
#endif
@ -495,7 +497,7 @@ icmpv6_drop_packet:
g_netstats.icmpv6.drop++;
#endif
icmpv_send_nothing:
icmpv6_send_nothing:
dev->d_len = 0;
}