Commit Graph

51 Commits

Author SHA1 Message Date
YAMAMOTO Takashi
a9d006b0a5 arch/arm/src/sam34/sam_serial.c: Fix a type mismatch 2020-11-16 08:29:00 -08:00
Brennan Ashton
5e8bcaa360 serial: nxstyle fixes
Signed-off-by: Brennan Ashton <bashton@brennanashton.com>
2020-10-20 14:43:19 +08:00
Juha Niskanen
94f0f55911 arch: serial: fix all TCGETS retrieving zero baud rate
cfsetispeed() now stores baud rate to c_cflag member of
struct termios, so it must not be overridden later on.

Signed-off-by: Juha Niskanen <juha.niskanen@haltian.com>
2020-10-20 14:43:19 +08:00
Gregory Nutt
2aa85fd17e arch/arm, board/arm: Rename all up_* functions to arm_*
Summary

The naming standard at https://cwiki.apache.org/confluence/display/NUTTX/Naming+FAQ requires that all MCU-private functions begin with the name of the architecture, not up_.

This PR addresses only these name changes for the ARM-private functions prototyped in arm_internal.h

This change to the files only modifies the name of called functions.  nxstyle fixes were made for all core architecture files.  However, there are well over 5000 additional complaints from MCU drivers and board logic that are unrelated to to this change but were affected by the name change.  It is not humanly possible to fix all of these.   I ask that this change be treated like other cosmetic changes that we have done which do not require full nxstyle compliance.

Impact

There should be not impact of this change (other that one step toward more consistent naming).
Testing

stm32f4discovery:netnsh
2020-05-01 18:28:13 +01:00
Gregory Nutt
037c9ea0a4 arch/arm: Rename all up_*.h files to arm_*.h
Summary

The naming standard at https://cwiki.apache.org/confluence/display/NUTTX/Naming+FAQ requires that all MCU-private files begin with the name of the architecture, not up_.

This PR addresses only these name changes for the up_*.h files.  There are only three, but almost 1680 files that include them:

    up_arch.h
    up_internal.h
    up_vfork.h

The only change to the files is from including up_arch.h to arm_arch.h (for example).

The entire job required to be compatible with that Naming Convention will also require changing the naming of the up_() functions that are used only within arch/arm and board/arm.

Impact

There should be not impact of this change (other that one step toward more consistent naming).

Testing

stm32f4discovery:netnsh
2020-05-01 03:43:44 +01:00
Xiang Xiao
cde88cabcc Run codespell -w with the latest dictonary again
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
2020-02-23 22:27:46 +01:00
Xiang Xiao
5c80b94820 Replace #include <semaphore.h> to #include <nuttx/semaphore.h>
Since the kernel side should call nxsem_xxx instead and remove the unused inclusion
2020-02-01 08:27:30 -06:00
Xiang Xiao
6a3c2aded6 Fix wait loop and void cast (#24)
* Simplify EINTR/ECANCEL error handling

1. Add semaphore uninterruptible wait function
2 .Replace semaphore wait loop with a single uninterruptible wait
3. Replace all sem_xxx to nxsem_xxx

* Unify the void cast usage

1. Remove void cast for function because many place ignore the returned value witout cast
2. Replace void cast for variable with UNUSED macro
2020-01-02 10:54:43 -06:00
Gregory Nutt
f4c2449c30 Rename arch/arm/src/sam34/chip to arch/arm/src/sam34/hardware. 2019-05-25 07:37:39 -06:00
Gregory Nutt
4b9abfa3c2 Every file that uses serial IOCTLs (TIOC*) must explicity include nuttx/fs/ioctl.h. This was included previously via sneak path in the now deleted arch/serial.h. 2019-01-27 13:41:44 -06:00
Xiang Xiao
818d8dda1e Remove empty seria.h and all references 2019-01-26 15:08:14 -06:00
Gregory Nutt
a581e9206d Convert remaining serial drivers to use use irq_attach. 2017-02-27 10:27:14 -06:00
Mark Schulte
b3222bbc8a irq_dispatch: Add argument pointer to irq_dispatch
Provide a user defined callback context for irq's, such that when
registering a callback users can provide a pointer that will get
passed back when the isr is called.
2017-02-27 06:27:56 -06:00
Wolfgang Reissnegger
f3a6a40f62 SAM3/4 Serial: Fix warning when CONFIG_SUPPRESS_UART_CONFIG is set. 2016-07-23 16:23:49 -07:00
Gregory Nutt
9ec104834a Remove CONFIG_USARTn_ISUART 2016-05-25 11:21:48 -06:00
Gregory Nutt
9c63736c98 Standard some naming if code sectino comments 2016-02-21 18:06:09 -06:00
Gregory Nutt
70e502adb0 Replace irqsave() with enter_critical_section(); replace irqrestore() with leave_critical_section() 2016-02-13 19:11:09 -06:00
Gregory Nutt
b6638315a4 Correct some spacing issues 2015-10-07 11:39:06 -06:00
Gregory Nutt
6fc6d17760 Fix some spacing problems 2015-10-04 14:59:08 -06:00
Gregory Nutt
d1aae43e2a SAM4CM: Add support for optical mode for UART1. From Max Neklyudov. 2015-05-23 06:48:36 -06:00
Gregory Nutt
790d53bb06 SAM3/4 Serial: In NONBLOCKING mode serial does not receive bytes from UART. This happens because RX interrupt was disabled in the setup routine. To fix this I save interrupt configuration before uart shutdown and restore it after. From Max Neklyudov. 2015-05-21 07:06:47 -06:00
Gregory Nutt
a93913c0f4 SAMA5 Serial: Reading IMR and disabling interrupt must be atomic 2015-04-08 15:27:31 -06:00
Gregory Nutt
35312b31f9 SAM3/4 and SAMV7 UART: The IMR register is read-only. This means that sam_restoreints() does not actually re-enable UART interrupts. 2015-04-08 15:04:10 -06:00
Gregory Nutt
27bb133294 SAM3/4 and SAMV7 Serial: Serial interrupts left disabled.
A side-effect of changing serial settings via TERMIOS (such as tcsetattr) is that serial interrupts were being left disabled.  This is not a problem if the serial configuration is changed when there are no open references to the serial device.  In that case, serial interrupts are disabled and will not be enabled enabled until the serial device is first opened.  But it is fatal if the serial device is already opened and if there is a task waiting to receive data.  In that case, the side-effect of disabling interrupts is fatal:  That task is then left hanging with interrupts disabled.
2015-04-08 14:14:01 -06:00
Gregory Nutt
8d31651a1b Bringing PPPD yet closer to the NuttX coding style 2015-03-11 18:47:04 -06:00
Gregory Nutt
0eaa74962c Costmetic changes -- spacing, comments. 2014-10-30 16:33:40 -06:00
Gregory Nutt
05c1d9707d SAM3/4: Fix error serial TERMIOS ioctl handling 2014-10-30 12:23:15 -06:00
Gregory Nutt
11ab9c908e Add support for SAM3/4 basic TERMIOS and flow control. There are issues with IFLOW control: PDC or DMAC support is required 2014-10-29 15:47:15 -06:00
Gregory Nutt
4098d8c4a2 SAM4: Fix a usbnsh build problem that has crept into all serial drivers 2014-10-28 15:44:47 -06:00
Gregory Nutt
6455f60c60 Remove os_internal.h it has been replace by several new header files under sched/. There have been some sneak inclusion paths via os_internal.h, so expect a few compilation errors for some architectures 2014-08-08 18:39:28 -06:00
Gregory Nutt
fae790a6dc Add support for the SAM4CM. From Max Neklyudov 2014-06-25 08:25:52 -06:00
Gregory Nutt
af2bb81ac2 Add serial method so that lower half driver can provide RX flow control information. From Jussi Kivilinna 2014-05-08 09:00:33 -06:00
Gregory Nutt
f52ff8cf7b SAM3/4: Add watchdog timer support. From Bob Doisin 2014-04-21 19:10:06 -06:00
Gregory Nutt
8f7d58c011 Eliminate some warnings 2014-03-26 16:31:26 -06:00
Gregory Nutt
99f9239a00 SAM3/4 Serial: Fix a mysterious multi-tasking bug that can lock up the serial port 2014-03-25 12:44:03 -06:00
Gregory Nutt
8e6bfea5aa SAM4E: Various bring-up fixes. NSH now works 2014-03-12 10:59:19 -06:00
Gregory Nutt
3d12bc9830 SAM3/4: Fix some build errors that crept in with the SAM4E support 2014-02-25 12:41:38 -06:00
Gregory Nutt
07ae9d60e0 SAM4E: USART/USART header files and drivers updated to support the SAM4E 2014-02-22 13:46:23 -06:00
Gregory Nutt
4bbe259082 SAM3/4 serial: Same supersitituous change as for SAMA5 2013-10-26 16:17:07 -06:00
Gregory Nutt
3910edbf90 Review and update of SAM3/4 header files and conditional logic for SAM3X/A support 2013-06-27 11:06:13 -06:00
Gregory Nutt
2bce348e0f SAM3/4: Some minor design improvements to the SAM3/4 serial driver 2013-06-13 15:16:52 -06:00
Gregory Nutt
e6a3078b77 Add support for a generic windows-based EABI toolchain; Add NX configuration to force default NXTK border colors 2013-06-13 11:04:18 -06:00
Gregory Nutt
ea776434ba Changes for a clean build of configs/sam4s-xplained 2013-06-11 17:33:43 -06:00
Gregory Nutt
1b57fdd7dd SAM4S: Add macros to manage peripheral clocks 2013-06-11 15:42:30 -06:00
Gregory Nutt
93ee6cb291 SAM4S: Add pin multiplexing definitions 2013-06-11 14:32:07 -06:00
Gregory Nutt
6576156731 SAM4S: Add memory map and interrupt logic 2013-06-10 16:18:47 -06:00
Gregory Nutt
617a0225cc SAM4L: Extend interrupt support for the larger number of NVIC interrupts of the SAM4L 2013-06-09 13:00:38 -06:00
Gregory Nutt
bae87a0ea1 SAM4L: Mic fixes to get the SAM4L Xplained running. The ostest now passes. 2013-06-09 10:57:42 -06:00
Gregory Nutt
91d6ebfa0e SAM3U/4L changes to hide differences by clocking in those MCUs 2013-06-08 13:50:42 -06:00
Gregory Nutt
04d573e3a8 SAM4L: Add USART/UART register definition header files 2013-06-08 11:39:06 -06:00