Commit Graph

1023 Commits

Author SHA1 Message Date
Gregory Nutt
7b7ca87941 fs/vfs: file_write() and file_pwrite() are internal OS interfaces and should not report errors via the errno 2017-09-28 14:49:05 -06:00
Gregory Nutt
e761b80ea7 fs/vfs: file_read() is an internal OS interface and should not errors via the errno 2017-09-28 14:14:32 -06:00
Gregory Nutt
9043b9cb6a fs/vfs: file_seek() is an internal OS interface and should not errors via the errno 2017-09-28 13:55:36 -06:00
DL
9145fe0c10 Fixed directory unlocking in tmpfs_opendir 2017-09-27 06:55:37 +03:00
Gregory Nutt
12c4c4c8a6 In some cases, packets are still not sent behind the router. I found that NuttX sends the ARP requests not to the router but to the target. Mistake in file net/route/netdev_router.c. From Aleksandr Kazantsev 2017-09-20 13:19:05 -06:00
Gregory Nutt
e7ce9c4a79 sem_open() should return SEM_FAILED on any failures. This is change change in the POSIX specification since the original sem_open() was written so many years ago. 2017-09-08 10:14:51 -06:00
Nickolay Semyonov (RPI)
620e2f4ce3 FS_AUTOMOUNTER should depend on SCHED_LPWORK 2017-08-26 11:54:03 -06:00
Gregory Nutt
d209e0e238 Add file missed in last commit. Fix naming in some configuration items. 2017-08-12 07:26:20 -06:00
Gregory Nutt
ee9e4fa8be procfs: Corret the type of a couple of procfs file entries. 2017-08-11 16:06:53 -06:00
Gregory Nutt
65698da12d procfs: Add support for routing tables. 2017-08-11 15:33:58 -06:00
Gregory Nutt
aeb59383cf Remove CONFIG_NET_MULTILINK. This increases code size by a little, but greatly reduces the complexity of the network code. 2017-08-08 15:26:09 -06:00
Jussi Kivilinna
027a446158 poll: fix poll for regular files and block devices. Open Group documentation tells that poll (and select) support regular files and that 'Regular files shall always poll TRUE for reading and writing'. 2017-08-03 09:58:20 -06:00
Simon Piriou
643f5782aa epoll: fix epoll_wait function 2017-07-22 09:01:24 -06:00
Masayuki Ishikawa
5efd942396 FS: Remove DEBUGASSERT() in block_proxy() because the flags are cleared later. 2017-07-04 10:56:54 +09:00
Gregory Nutt
1ed9793751 fs/: Remove dangling space at the end of lines. 2017-06-28 13:17:55 -06:00
Julien Lecoeur
f26e83d0a1 Fix -Werror=implicit-fallthrough on gcc7 2017-06-28 17:48:04 +02:00
Jussi Kivilinna
4eaa136850 smart: fix wrong freeing of device structure and use-after-free issues on error paths 2017-06-28 07:20:07 -06:00
Jim Paris
db80696d21 vfs/poll: fix timeout calculation 2017-06-09 11:37:30 -06:00
Harri Luhtala
b8b9309d2b vfs: fdopen: add missing file stream flags clearing. Clear file stream structure regardless of config options. Structure clearing is needed as previous use of stream list entry might leave fs_flags set. 2017-05-31 06:20:18 -06:00
Masayuki Ishikawa
99bdab3ac3 FAT: Fix 'Missing unlock' in fs_fat32.c
Jira: PDFW15IS-265
Coverity-ID: 10590 10589
Signed-off-by: Masayuki Ishikawa <Masayuki.Ishikawa@jp.sony.com>
2017-05-22 14:44:24 +09:00
Gregory Nutt
41680d376d Replace 'the the' with 'the' 2017-05-11 13:15:13 -06:00
Gregory Nutt
e3d865f6c2 In last changed to poll(),cConverted timeout to unsigned to eliminate the possibility of overflow of signed overflow. 2017-04-28 11:02:54 -06:00
Jussi Kivilinna
37ca797d1c vfs/poll: round timeout up to next full tick. Calling poll() with timeout less than half tick (thus MSEC2TICK(timeout) => 0) caused returning error with EAGAIN. Instead of rounding timeout down, value should be rounded up. Open Group spec for poll says: "Implementations may place limitations on the granularity of timeout intervals. If the requested timeout interval requires a finer granularity than the implementation supports, the actual timeout interval will be rounded up to the next supported value." 2017-04-28 08:42:37 -06:00
Masatoshi Tateishi
ae8d5821e0 procfs: Fix incorrect uptime with CONFIG_SYSTEM_TIME64
Jira: PDFW15IS-45
Signed-off-by: Masayuki Ishikawa <Masayuki.Ishikawa@jp.sony.com>
2017-04-25 10:58:38 +09:00
Gregory Nutt
d5207efb5a Be consistent... Use Name: consistent in function headers vs Function: 2017-04-21 16:33:14 -06:00
Gregory Nutt
7457875447 VFS poll(): Add some error handling logic 2017-04-20 19:15:17 -06:00
Nobutaka.Toyoshima
e971083449 procfs: Fix wrong member IDs are displayed when 'cat /proc/<pid>/group/stasus'.
Jira: PDFW15IS-259
Signed-off-by: Masayuki Ishikawa <Masayuki.Ishikawa@jp.sony.com>
2017-04-20 16:12:20 +09:00
Gregory Nutt
2bcb8b7b07 If whence is SEEK_END, the file offset shall be set to the size of the file plus offset. Noted by eunb.song@samsung.com 2017-03-13 07:31:47 -06:00
Gregory Nutt
d3408809e4 sendfile(): Fix error introduced with commit ff73be870e. Noted by Maciej Wójcik 2017-03-05 11:50:34 -06:00
Gregory Nutt
ee8abb8160 FS: Don't build block driver proxy if PSEUDOFS_OPERATIONS are disabled. 2017-03-04 08:25:20 -06:00
Gregory Nutt
0a192361de Revert "FS: Fix backward conditional logic that prevent unlink() from building in some configurations."
Oops.  It was not backward.  Enable == !Disable.  Negative logic is confusing.

This reverts commit 1fcf353e89.
2017-03-04 08:16:46 -06:00
Gregory Nutt
1fcf353e89 FS: Fix backward conditional logic that prevent unlink() from building in some configurations. 2017-03-04 07:48:56 -06:00
Masayuki Ishikawa
e239961be8 Fix open() a block device with CONFIG_DISABLE_PSEUDOFS_OPERATIONS=y 2017-03-01 13:43:12 +09:00
Gregory Nutt
4fa389898a Fix a warning when STDIO buffering is disabled 2017-02-27 11:06:13 -06:00
Gregory Nutt
a78593d66d fstatfs: Rethink last commit. Add verification that the file descriptor refers to an open file. This also should eliminate the warning while doing something useful. 2017-02-22 14:17:14 -06:00
Gregory Nutt
8c7ec7419a Eliminate a warning 2017-02-22 14:04:06 -06:00
Gregory Nutt
656935ed7e C library: Add fstatfs(); fix a reference counting error in fstat(). 2017-02-17 08:35:59 -06:00
Gregory Nutt
b4d378adb8 Don't build libc/pthread if pthreasa are disable. Fix a warning in dirent logic if mountpoints are disabled. 2017-02-16 09:53:13 -06:00
Gregory Nutt
be7a904d1b procfs skeleton: Some additional, purely cosmetic updates. 2017-02-15 12:47:51 -06:00
Gregory Nutt
504f677c20 procfs skeleton file should include an example write method. 2017-02-15 12:40:30 -06:00
Gregory Nutt
c67943ed1d procfs: Most stat() implementations were not initializating the st_atime, st_ctime, and st_mtime fields. 2017-02-15 09:59:09 -06:00
Gregory Nutt
bae367c7c4 fstat(): Rethink procfs fstat(). If write method is supported, then should report file s writeable. 2017-02-15 09:32:42 -06:00
Gregory Nutt
ef8d207118 smartfs: Add support for fstat(). 2017-02-14 10:30:11 -06:00
Gregory Nutt
c5df283822 procfs: Add support for fstat(). 2017-02-14 10:00:15 -06:00
Gregory Nutt
b4695c5ee9 hostfs: Add support for fstat(). 2017-02-14 09:54:08 -06:00
Gregory Nutt
e8d6676e18 procfs: When addition of memset from previous commit, it is no longer necessary to set individual fields to zero. 2017-02-14 09:03:48 -06:00
Gregory Nutt
74d30a0dbc procfs: stat() left several fields in uninitialized state. 2017-02-14 09:00:48 -06:00
Gregory Nutt
191fb658d0 nfs: Simplify parameters saved for fstat() 2017-02-14 08:16:03 -06:00
Gregory Nutt
2325ea4a45 statfs() should not fail on path '/' 2017-02-14 06:30:35 -06:00
Gregory Nutt
a2e74f2583 fs/inode/inode.h: Fix a warning 'inode/inode.h:264:45: error: 'struct stat' declared inside parameter list' by adding a forward reference to struct stat. Noted by David Sidrane. 2017-02-13 17:19:49 -06:00
Gregory Nutt
78fa87c7db ROMFS: stat() and fstat() should always indicate that directories are executable. 2017-02-13 16:56:55 -06:00
Gregory Nutt
d677e63008 ROMFS: Back out 29028bcd5a. A cool idea, but loses the EXECUTABLE bit in the file type. 2017-02-13 15:33:52 -06:00
Gregory Nutt
40f8e8b41f Fix some backward DEBUGASSERT tests in ROMFS and FAT. 2017-02-13 14:06:39 -06:00
Gregory Nutt
34f1b333b1 FAT: Fix some errors that I introduced in my review of Alan's patch. My screw-up, not Alan's. Sorry. 2017-02-13 12:43:35 -06:00
Alan Carvalho de Assis
a73651c8ca fstat: Add fstat() support to FAT. 2017-02-13 12:21:06 -06:00
Gregory Nutt
d0f0dd222e NFS: Use clock_gettime() instead of deprecated gettimeofday() 2017-02-13 10:39:49 -06:00
Gregory Nutt
10378bb10b fstat: Add fstat() support to nfs. 2017-02-13 10:07:43 -06:00
Gregory Nutt
181eb79616 fstat: Add fstat() support to nxffs. 2017-02-13 08:22:05 -06:00
Gregory Nutt
a482a4603f fstat: Add fstat() support to tmpfs. 2017-02-13 07:20:39 -06:00
Gregory Nutt
29028bcd5a romfs: Simplify fstat() implementation. It is not necessary to save the file type at open, We know in this context that the file is a regular file. 2017-02-13 06:55:06 -06:00
Gregory Nutt
2cb402080a fstat: Add fstat() support to unionfs 2017-02-12 17:05:47 -06:00
Gregory Nutt
4748e9352d fstat: Add fstat() support to romfs 2017-02-12 16:25:12 -06:00
Gregory Nutt
d06b346b5c Add fstat support to binfs 2017-02-12 14:47:05 -06:00
Gregory Nutt
7d91fabf01 fstat: Add skeleton implmentations of fstat() in all file systems. 2017-02-12 13:42:27 -06:00
Gregory Nutt
c5a8e96dbc Add basic fstat() support. Now all that is needed is to modify ALL of the file systems. 2017-02-12 12:48:24 -06:00
Gregory Nutt
3055025e00 rename(): Correct more issues. (1) Move to the root directory in the pseudo file system, (2) Fix path naming calculation when the path is the root directory of a mounted file system, and (3) dont't do the rename if the source and destination of the rename are the same. 2017-02-12 08:37:28 -06:00
Gregory Nutt
e20e9f0fe4 Update a comment 2017-02-11 18:55:13 -06:00
Gregory Nutt
2d11d8f1a4 rename: An inode with no operations should be treated like a directory for the purposes of rename 2017-02-11 12:02:50 -06:00
Gregory Nutt
bd7d3a92f5 Add logic to VFS rename: If target of rename exists and is a directory, then the source file should be moved 'under' the target directory. POSIX also requires that if the target is a file, then that old file must be deleted. 2017-02-11 11:18:30 -06:00
Gregory Nutt
af5a8e73d3 VFS rename: Fix issues with rename to subdirectories and some softlink issues. 2017-02-11 10:08:23 -06:00
Gregory Nutt
abcbb24cf2 sem_open(): Fix a compiler error introduced with the setvbuf() changes. 2017-02-09 10:56:12 -06:00
Gregory Nutt
1d290c2b37 setvbuf: Add support for disabling I/O buffering. Initially cut; untested. 2017-02-09 09:24:44 -06:00
Gregory Nutt
a92887c63d setvbuf: Correct some errors detected by code review. 2017-02-08 14:06:29 -06:00
Gregory Nutt
9f859774a1 setvbuf: Add support for configuration of line buffering. 2017-02-08 11:28:24 -06:00
Gregory Nutt
51a14c9b2f C Library: Add a very limited, first step implementation of setvbuf(). This is a collaborative effort. Alan Carvalho de Assis did the initial prototype. 2017-02-08 10:33:18 -06:00
Gregory Nutt
2d2fe301cb Update some comments; link counter can be uint8_t; Add a debug assertion. 2017-02-07 15:50:54 -06:00
David Sidrane
d9044058b5 There is a return path with node not set
inode/fs_inoderemove.c: In function 'inode_unlink':
inode/fs_inoderemove.c:74:17: warning: 'node' may be used uninitialized in this function [-Wmaybe-uninitialized]
   FAR struct inode *node;
2017-02-07 21:41:02 +00:00
Gregory Nutt
b758176963 stat(): Add logic to avoid infinite recursive in circular paths containing soft links. 2017-02-07 12:32:45 -06:00
Gregory Nutt
1b32cb67cb Soft link: Change how a value is returned so that _inode_linktarget will function in all of its use contexts. 2017-02-06 10:06:46 -06:00
Gregory Nutt
94e4d58fd2 Soft links: Fix a error in follow a link to a link to a mountpoint. 2017-02-06 08:46:43 -06:00
Gregory Nutt
aefe32d33f soft links: Fix a memory leak by correcting a reference counting problem. 2017-02-05 15:14:16 -06:00
Gregory Nutt
47ddfa346d Soft links: Eliminate in-stack allocation of path working buffer needed for traversal fo paths with soft links. 2017-02-05 14:57:38 -06:00
Gregory Nutt
45fd98da88 Add macros support that will eventually allow dynamic allocation of strings need to support soft links. 2017-02-05 14:25:45 -06:00
Gregory Nutt
8f2c7198ed inode_find: Now takes struct inode_desc_s type as input. This was necessary before that structure includes some data storage. It was used within inode_find(), but that means that the life of the data was the life of inode_find(). That data must persist longer. It is now provided by the caller so that the life of the data persists for the entire life of the caller. 2017-02-05 09:51:42 -06:00
Gregory Nutt
990bed903e Soft link: First cut fix for some soft link issues. The fix still has some issues of its own. 2017-02-04 16:35:49 -06:00
Gregory Nutt
4c68324d82 FS: Remove inode_search_nofollow(). That logic is no handled with a new field in the input argument structure. 2017-02-04 12:51:14 -06:00
Gregory Nutt
0c9935f8ac FS: Remove inode_find_nofollow. Instead provide a bool nofollow argument to inode_find. 2017-02-04 11:46:54 -06:00
Gregory Nutt
36704b7d9c FS: Argument is now a structure describing the search. 2017-02-04 11:21:44 -06:00
Gregory Nutt
8437650fc2 Soft links: Another fix to tree traveral logic 2017-02-03 16:34:50 -06:00
Gregory Nutt
982cfea490 Remove some unnecessary (and inappropriate) soft link logic 2017-02-03 15:50:41 -06:00
Gregory Nutt
70dcec7df7 readlink: Fix bugs from initial testing 2017-02-03 14:12:24 -06:00
Gregory Nutt
4417e74977 Soft links: Add an (untested) implementation of readlink() 2017-02-03 13:57:12 -06:00
Gregory Nutt
60ba5a5261 Soft links: Fix logic and remove kludge of last commit. Rename inode_dereference() as inode_linktarget() and make global. 2017-02-03 13:22:33 -06:00
Gregory Nutt
7c59e05305 FS: Separate inode_search() and inode_free() from fs_inode.c and put in separate files. Flesh out symbolic link logic in stat() and readdir(). There are still some issues with stat(). 2017-02-03 11:23:57 -06:00
Gregory Nutt
741a221fdb Soft link: make SOFTLINK configuration EXPERIMENTAL. There are still issues. 2017-02-03 09:24:43 -06:00
Gregory Nutt
372e399bbc Fix a typo 2017-02-03 07:36:25 -06:00
Gregory Nutt
d833144869 Soft Links: Fix several issues in initial testing 2017-02-02 19:37:58 -06:00
Gregory Nutt
b39d962021 Soft links: Update Documentation, rename file, add system calls 2017-02-02 17:11:08 -06:00
Gregory Nutt
35d738d85f Soft links: Fix compile problems on first build with soft links enabled. 2017-02-02 15:24:39 -06:00
Gregory Nutt
bdc002fadc Finish implementation of soft links. 2017-02-02 13:01:21 -06:00
Gregory Nutt
92305e400a Soft links: Initial, incompete implementation 2017-02-02 10:39:41 -06:00
Gregory Nutt
8b5af8bf50 FS: Fix typo. Latent bug but innocuous in its current usage 2017-01-27 08:50:01 -06:00
Gregory Nutt
a6fd776b1d mq_open: Fix wrong type of slash used in quoated character constant. 2017-01-10 07:07:17 -06:00
Gregory Nutt
7035d232f8 NX server: Correct message queue names. Should not be at /dev, but rather relative to /var/mqueue. 2017-01-08 09:14:11 -06:00
Gregory Nutt
feacfeae25 procfs: Correct to snprintf-related errors in fs_procfsproc.c. Resolves issue #24 2017-01-07 07:13:04 -06:00
Gregory Nutt
57d8a437ef Fix procfs status for SMP case. 2016-12-20 11:51:39 -06:00
Gregory Nutt
b52e4e5ecd Move cancellation point definitions to their own header file. 2016-12-10 09:08:26 -06:00
Gregory Nutt
bc3ca25cc7 Cancellation points: Close up some logic to eliminte some race conditions. 2016-12-10 08:36:58 -06:00
Gregory Nutt
a0f567f4a3 Update TODO, cosmetic changes, spelling -- US English spells it canceled and canceling vs cancelled and cancelling. No idea why. 2016-12-09 18:39:40 -06:00
Gregory Nutt
03a58b2ebc write(): Fix a misplaced #endif 2016-12-09 18:12:42 -06:00
Gregory Nutt
05f61def6a Fix warning and link error due to missing header file. 2016-12-09 17:02:27 -06:00
Gregory Nutt
3eba0acb1c More cancellation points. 2016-12-09 13:49:36 -06:00
Gregory Nutt
c9ca97b4b5 cancellation points are basically function. More tested is needed and additional cancellation points must be implemented before this can be merged back to master. 2016-12-09 12:01:18 -06:00
Gregory Nutt
b0dffdc2ca Fix a number of header files with mismatched 'extern C {' and '}' 2016-11-05 07:25:05 -06:00
Gregory Nutt
dbbe46a2bc fs: Disable priority inheritance on all semaphores used for signaling 2016-11-03 12:23:31 -06:00
Gregory Nutt
0908a6c6b9 Fix calculations using MSEC_PER_TICK. If USEC_PER_TICK is less than 1000, then MSEC_PER_TICK will be zero. It will be inaccurate in any case. 2016-09-25 08:17:33 -06:00
Petteri Aimonen
69577eb0b7 libnx/nxglib: Fix handling of near-horizontal lines of width 1 in nxgl_splitline(). Missing handling for degenerate condition caused width 1 lines such as (0, 0) - (100, 10) to have gaps in the drawing. 2016-09-22 11:09:06 -06:00
Gregory Nutt
93b48ea70f Fix a logic error introduced with last commit 2016-09-22 08:50:47 -06:00
Gregory Nutt
8221c2da64 Corrects a bad assertion noted by Pierre-noel Bouteville. Also fixes a reference counting problem in an error condition: When the mountpoint inode is found but is not an appropriate mountpoint, the reference count on the inode was not being decremented. 2016-09-22 08:22:28 -06:00
Sagitta Li
9fa1024eef vector table should have dimension NR_IRQS, not NR_IRQS+1 2016-09-22 07:56:12 -06:00
Mateusz Szafoni
0bc154863e sched/: Define 'group' even if HAVE_GROUPID is not set 2016-09-22 10:44:06 +02:00
Gregory Nutt
05aa586aa6 sched/: Move fields related to parent/child task relationship out of TCB into group structure. 2016-09-06 08:28:31 -06:00
Gregory Nutt
986c568d34 Correct file header comments 2016-08-07 10:04:02 -06:00
Gregory Nutt
610afe9cd9 FAT performance improvement. In large files, seeking to a position fromt he beginning of the file can be very time consuming. ftell does lssek(fd, 0, SET_CURR). In that case, that is wasted time since we are going to seek to the same position. This fix short-circutes fat_seek() in all cases where we attempt to seek to curren position. Suggested by Nate Weibley 2016-08-03 13:32:52 -06:00
Gregory Nutt
72a45c82b7 Move include/nuttx/regex.h to include/nuttx/lib/regex.h 2016-07-21 13:42:18 -06:00
Gregory Nutt
4b4dbc79a2 Move driver related prototypes out of include/nuttx/fs/fs.h and into new include/drivers/drivers.h 2016-07-20 13:15:37 -06:00
Gregory Nutt
006f4a5818 HOSTFS: Fix some errors in first cut at repartitioning 2016-07-17 16:31:14 -06:00
Gregory Nutt
2b28a1f3e5 SIM HOSTFS: First cut at changes to get it working on Cygwin. 2016-07-17 15:59:45 -06:00
Gregory Nutt
69637bf825 Costmetic changes to better match coding style 2016-07-17 13:39:21 -06:00
Alan Carvalho de Assis
8fa14b8fed Fix poll-related compile issues introduced with recent PTY changes 2016-07-16 07:03:38 -06:00
Gregory Nutt
11fe9378df Fix some warnings 2016-07-16 07:02:06 -06:00
Gregory Nutt
bcb6095f1f Add an assertion 2016-07-15 17:47:00 -06:00
Gregory Nutt
6a75f2df89 PTY: Add some encode to reduce the likely of misinterpreting the return value of the file open() method 2016-07-15 17:13:21 -06:00
Gregory Nutt
4b1553d3ad PTY: Fix some tricky issues. Now seems to be working. A lot more testing is needed 2016-07-15 14:29:32 -06:00
Gregory Nutt
9ecd558002 Add the correct implementation of the file_poll() function 2016-07-15 11:34:08 -06:00
Gregory Nutt
6e6c04f778 Rename file_poll as fdesc_poll. The file_ namespace is used for other things. 2016-07-15 11:21:11 -06:00
Ken Pettit
b616918e0f SmartFS: Fix a 32-byte memory leak 2016-07-12 17:28:06 -06:00
Gregory Nutt
67a9549355 TMPFS: Eliminate some warnings 2016-07-11 11:19:58 -06:00
Gregory Nutt
2689645b97 VFS ioctl() again. Per comments from David Sidrane, file_ioctl() should not return success if the ioctl method is not supported. It probably should return ENOTTY in that case. 2016-07-09 07:23:12 -06:00
Sagitta Li
1925df8faa Fix some recently introduced errors 2016-07-09 06:51:07 -06:00
Gregory Nutt
02b91d9880 Add a SYSLOG character device that can be used to re-direct output to the SYSLOG 2016-07-05 12:58:18 -06:00
Gregory Nutt
a39ce80add SYSLOG logic should use existing file interfaces, not re-invent them. 2016-07-05 12:12:44 -06:00
Gregory Nutt
82c890db23 syslog_dev_flush() needs to check if the inode is a mountpoint before calling the flush() method. Noted by David Sidrane. 2016-06-22 05:58:33 -06:00
Gregory Nutt
485aa6b231 SIM: Comment out skip scheduler debug output that can hang the simulation. 2016-06-21 08:59:01 -06:00
Gregory Nutt
43eb04bb8f Without lowsyslog() *llinfo() is not useful. Eliminate and replace with *info(). 2016-06-20 11:59:15 -06:00
Gregory Nutt
e27491f5be Move fs/drivers/fs_devsyslog.c to drivers/syslog/syslog_device.c 2016-06-19 08:46:46 -06:00
Gregory Nutt
d5275e48d0 Eliminate some warnings 2016-06-13 13:16:03 -06:00
Gregory Nutt
eac916c907 Fix some warnings 2016-06-13 11:48:20 -06:00
Gregory Nutt
c0142b618d Missing left parenthesis on one of the modified debug statements. 2016-06-11 17:31:11 -06:00
Gregory Nutt
1acafa813b Missing open quotation mark on one of the modified debug statements. 2016-06-11 17:29:32 -06:00