nuttx/sched/pthread/pthread_join.c
Yanfeng Liu 7ec304e6a8 pthread/join: catch null pexit_value case
This adds handling for null pointer in errout route as it crashes my
ostest sometimes.

Signed-off-by: Yanfeng Liu <yfliu2008@qq.com>
2024-05-10 19:42:13 +08:00

172 lines
4.7 KiB
C

/****************************************************************************
* sched/pthread/pthread_join.c
*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership. The
* ASF licenses this file to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance with the
* License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
* License for the specific language governing permissions and limitations
* under the License.
*
****************************************************************************/
/****************************************************************************
* Included Files
****************************************************************************/
#include <nuttx/config.h>
#include <sys/types.h>
#include <unistd.h>
#include <pthread.h>
#include <assert.h>
#include <errno.h>
#include <debug.h>
#include <nuttx/cancelpt.h>
#include "sched/sched.h"
#include "pthread/pthread.h"
/****************************************************************************
* Public Functions
****************************************************************************/
/****************************************************************************
* Name: pthread_join
*
* Description:
* A thread can await termination of another thread and retrieve the
* return value of the thread.
*
* The caller's task/thread must belong to the same "task group" as the
* pthread is (or was) a member of. The thread may or may not still
* be running.
*
* Input Parameters:
* thread
* pexit_value
*
* Returned Value:
* 0 if successful. Otherwise, one of the following error codes:
*
* EINVAL The value specified by thread does not refer to joinable
* thread.
* ESRCH No thread could be found corresponding to that specified by the
* given thread ID.
* EDEADLK A deadlock was detected or the value of thread specifies the
* calling thread.
*
* Assumptions:
*
****************************************************************************/
int pthread_join(pthread_t thread, FAR pthread_addr_t *pexit_value)
{
FAR struct tcb_s *rtcb = this_task();
FAR struct task_group_s *group = rtcb->group;
FAR struct task_join_s *join;
FAR struct tcb_s *tcb;
int ret = OK;
/* pthread_join() is a cancellation point */
enter_cancellation_point();
nxrmutex_lock(&group->tg_joinlock);
tcb = nxsched_get_tcb((pid_t)thread);
if (tcb == NULL || (tcb->flags & TCB_FLAG_JOIN_COMPLETED) != 0)
{
ret = pthread_findjoininfo(group, (pid_t)thread, &join, false);
if (ret == OK)
{
/* Destroy the join information after obtain the exit value */
if (pexit_value != NULL)
{
*pexit_value = join->exit_value;
}
pthread_destroyjoin(group, join);
}
else
{
ret = ESRCH;
}
goto errout;
}
/* First make sure that this is not an attempt to join to
* ourself.
*/
if (tcb == rtcb)
{
ret = EDEADLK;
goto errout;
}
/* Task was detached or not a pthread, return EINVAL */
if ((tcb->group != group) ||
(tcb->flags & TCB_FLAG_DETACHED) != 0)
{
ret = EINVAL;
goto errout;
}
/* Relinquish the data set semaphore. Since pre-emption is
* disabled, we can be certain that no task has the
* opportunity to run between the time we relinquish the
* join semaphore and the time that we wait on the thread exit
* semaphore.
*/
sq_addfirst(&rtcb->join_entry, &tcb->join_queue);
nxrmutex_unlock(&group->tg_joinlock);
/* Take the thread's thread exit semaphore. We will sleep here
* until the thread exits. We need to exercise caution because
* there could be multiple threads waiting here for the same
* pthread to exit.
*/
nxsem_wait_uninterruptible(&rtcb->join_sem);
nxrmutex_lock(&group->tg_joinlock);
/* The thread has exited! Get the thread exit value */
if (pexit_value != NULL)
{
*pexit_value = rtcb->join_val;
}
errout:
nxrmutex_unlock(&group->tg_joinlock);
leave_cancellation_point();
if (pexit_value)
{
sinfo("Returning %d, exit_value %p\n", ret, *pexit_value);
}
else
{
sinfo("Returning %d\n", ret);
}
return ret;
}