nuttx/fs/vfs/fs_dup2.c
anjiahao 5952bc7392 fs_dup2:fix inode->i_crefs counting error
file_ioctl failed, but close success, inode need release

Signed-off-by: anjiahao <anjiahao@xiaomi.com>
2024-09-19 02:55:13 +08:00

202 lines
5.3 KiB
C

/****************************************************************************
* fs/vfs/fs_dup2.c
*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership. The
* ASF licenses this file to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance with the
* License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
* License for the specific language governing permissions and limitations
* under the License.
*
****************************************************************************/
/****************************************************************************
* Included Files
****************************************************************************/
#include <nuttx/config.h>
#include <nuttx/fs/fs.h>
#include <nuttx/fs/ioctl.h>
#include <unistd.h>
#include <sched.h>
#include <assert.h>
#include <errno.h>
#include <fcntl.h>
#include "inode/inode.h"
/****************************************************************************
* Public Functions
****************************************************************************/
/****************************************************************************
* Name: file_dup3
*
* Description:
* Assign an inode to a specific files structure. This is the heart of
* dup3.
*
* Equivalent to the non-standard dup3() function except that it
* accepts struct file instances instead of file descriptors and it does
* not set the errno variable.
*
* Returned Value:
* Zero (OK) is returned on success; a negated errno value is return on
* any failure.
*
****************************************************************************/
int file_dup3(FAR struct file *filep1, FAR struct file *filep2, int flags)
{
FAR struct inode *inode;
int ret;
if (filep1 == NULL || filep1->f_inode == NULL || filep2 == NULL)
{
return -EBADF;
}
if (flags != 0 && flags != O_CLOEXEC)
{
return -EINVAL;
}
if (filep1 == filep2)
{
return OK;
}
/* Increment the reference count on the contained inode */
inode = filep1->f_inode;
ret = inode_addref(inode);
if (ret < 0)
{
return ret;
}
/* If there is already an inode contained in the new file structure,
* close the file and release the inode.
* But we need keep the filep2->f_inode, incase of realloced by others.
*/
ret = file_close_without_clear(filep2);
if (ret < 0)
{
inode_release(inode);
return ret;
}
/* The two filep don't share flags (the close-on-exec flag). */
if (flags == O_CLOEXEC)
{
filep2->f_oflags = filep1->f_oflags | O_CLOEXEC;
}
else
{
filep2->f_oflags = filep1->f_oflags & ~O_CLOEXEC;
}
filep2->f_priv = NULL;
filep2->f_pos = filep1->f_pos;
filep2->f_inode = inode;
/* Call the open method on the file, driver, mountpoint so that it
* can maintain the correct open counts.
*/
if (inode->u.i_ops)
{
#ifndef CONFIG_DISABLE_MOUNTPOINT
if (INODE_IS_MOUNTPT(inode))
{
/* Dup the open file on the in the new file structure */
if (inode->u.i_mops->dup)
{
ret = inode->u.i_mops->dup(filep1, filep2);
}
}
else
#endif
{
/* (Re-)open the pseudo file or device driver */
filep2->f_priv = filep1->f_priv;
/* Add nonblock flags to avoid happening block when
* calling open()
*/
filep2->f_oflags |= O_NONBLOCK;
if (inode->u.i_ops->open)
{
ret = inode->u.i_ops->open(filep2);
}
if (ret >= 0 && (filep1->f_oflags & O_NONBLOCK) == 0)
{
ret = file_ioctl(filep2, FIONBIO, 0);
if (ret < 0 && inode->u.i_ops->close)
{
inode->u.i_ops->close(filep2);
}
}
}
/* Handle open failures */
if (ret < 0)
{
inode_release(inode);
return ret;
}
}
/* Copy tag */
#ifdef CONFIG_FDSAN
filep2->f_tag_fdsan = filep1->f_tag_fdsan;
#endif
#ifdef CONFIG_FDCHECK
filep2->f_tag_fdcheck = filep1->f_tag_fdcheck;
#endif
FS_ADD_BACKTRACE(filep2);
return OK;
}
/****************************************************************************
* Name: file_dup2
*
* Description:
* Assign an inode to a specific files structure. This is the heart of
* dup2.
*
* Equivalent to the non-standard dup2() function except that it
* accepts struct file instances instead of file descriptors and it does
* not set the errno variable.
*
* Returned Value:
* Zero (OK) is returned on success; a negated errno value is return on
* any failure.
*
****************************************************************************/
int file_dup2(FAR struct file *filep1, FAR struct file *filep2)
{
return file_dup3(filep1, filep2, 0);
}