67ec3d7926
This commit resolves issue #620: Remove CONFIG_CAN_PASS_STRUCTS #620 The configuration option CONFIG_CAN_PASS_STRUCTS was added many years ago to support an old version of the SDCC compiler. That compiler is currently used only with the Z80 and Z180 targets. The limitation of that old compiler was that it could not pass structures or unions as either inputs or outputs. For example: #ifdef CONFIG_CAN_PASS_STRUCTS struct mallinfo mallinfo(void); #else int mallinfo(FAR struct mallinfo *info); #endif And even leads to violation of a few POSIX interfaces like: #ifdef CONFIG_CAN_PASS_STRUCTS int sigqueue(int pid, int signo, union sigval value); #else int sigqueue(int pid, int signo, FAR void *sival_ptr); #endif This breaks the 1st INVIOLABLES rule: Strict POSIX compliance ----------------------- o Strict conformance to the portable standard OS interface as defined at OpenGroup.org. o A deeply embedded system requires some special support. Special support must be minimized. o The portable interface must never be compromised only for the sake of expediency. o Expediency or even improved performance are not justifications for violation of the strict POSIX interface Also, it appears that the current SDCC compilers have resolve this issue and so, perhaps, this is no longer a problem: z88dk/z88dk#1132 NOTE: This commit cannot pass the PR checks because it depends on matching changes to the apps/ directory.
199 lines
6.4 KiB
C
199 lines
6.4 KiB
C
/****************************************************************************
|
|
* sched/signal/sig_notification.c
|
|
*
|
|
* Copyright (C) 2018 Pinecone Inc. All rights reserved.
|
|
* Author: Xiang Xiao <xiaoxiang@pinecone.net>
|
|
*
|
|
* Derives from code originally written by:
|
|
*
|
|
* Copyright (C) 2018 Gregory Nutt. All rights reserved.
|
|
* Author: Gregory Nutt <gnutt@nuttx.org>
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions
|
|
* are met:
|
|
*
|
|
* 1. Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
* 2. Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in
|
|
* the documentation and/or other materials provided with the
|
|
* distribution.
|
|
* 3. Neither the name NuttX nor the names of its contributors may be
|
|
* used to endorse or promote products derived from this software
|
|
* without specific prior written permission.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
|
|
* FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
|
|
* COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
|
|
* INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
|
|
* BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS
|
|
* OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED
|
|
* AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
|
|
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
|
|
* ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
|
|
* POSSIBILITY OF SUCH DAMAGE.
|
|
*
|
|
****************************************************************************/
|
|
|
|
/****************************************************************************
|
|
* Included Files
|
|
****************************************************************************/
|
|
|
|
#include <nuttx/config.h>
|
|
|
|
#include <string.h>
|
|
#include <signal.h>
|
|
#include <debug.h>
|
|
|
|
#include <nuttx/signal.h>
|
|
|
|
#include "sched/sched.h"
|
|
#include "signal/signal.h"
|
|
|
|
/****************************************************************************
|
|
* Pre-processor Definitions
|
|
****************************************************************************/
|
|
|
|
#ifdef CONFIG_SIG_EVTHREAD_HPWORK
|
|
# define SIG_EVTHREAD_WORK HPWORK
|
|
#else
|
|
# define SIG_EVTHREAD_WORK LPWORK
|
|
#endif
|
|
|
|
/****************************************************************************
|
|
* Name: nxsig_notification_worker
|
|
*
|
|
* Description:
|
|
* Perform the callback from the context of the worker thread.
|
|
*
|
|
* Input Parameters:
|
|
* arg - Work argument.
|
|
*
|
|
* Returned Value:
|
|
* None.
|
|
*
|
|
****************************************************************************/
|
|
|
|
#ifdef CONFIG_SIG_EVTHREAD
|
|
static void nxsig_notification_worker(FAR void *arg)
|
|
{
|
|
FAR struct sigwork_s *work = (FAR struct sigwork_s *)arg;
|
|
|
|
DEBUGASSERT(work != NULL);
|
|
|
|
/* Perform the callback */
|
|
|
|
work->func(work->value);
|
|
}
|
|
|
|
#endif /* CONFIG_SIG_EVTHREAD */
|
|
|
|
/****************************************************************************
|
|
* Public Functions
|
|
****************************************************************************/
|
|
|
|
/****************************************************************************
|
|
* Name: nxsig_notification
|
|
*
|
|
* Description:
|
|
* Notify a client an event via either a signal or function call
|
|
* base on the sigev_notify field.
|
|
*
|
|
* Input Parameters:
|
|
* pid - The task/thread ID a the client thread to be signaled.
|
|
* event - The instance of struct sigevent that describes how to signal
|
|
* the client.
|
|
* code - Source: SI_USER, SI_QUEUE, SI_TIMER, SI_ASYNCIO, or SI_MESGQ
|
|
* work - The work structure to queue. Must be non-NULL if
|
|
* event->sigev_notify == SIGEV_THREAD. Ignored if
|
|
* CONFIG_SIG_EVTHREAD is not defined.
|
|
*
|
|
* Returned Value:
|
|
* This is an internal OS interface and should not be used by applications.
|
|
* It follows the NuttX internal error return policy: Zero (OK) is
|
|
* returned on success. A negated errno value is returned on failure.
|
|
*
|
|
****************************************************************************/
|
|
|
|
int nxsig_notification(pid_t pid, FAR struct sigevent *event,
|
|
int code, FAR struct sigwork_s *work)
|
|
{
|
|
sinfo("pid=%p signo=%d code=%d sival_ptr=%p\n",
|
|
pid, event->sigev_signo, code, event->sigev_value.sival_ptr);
|
|
|
|
/* Notify client via a signal? */
|
|
|
|
if (event->sigev_notify == SIGEV_SIGNAL)
|
|
{
|
|
#ifdef CONFIG_SCHED_HAVE_PARENT
|
|
FAR struct tcb_s *rtcb = this_task();
|
|
#endif
|
|
siginfo_t info;
|
|
|
|
/* Yes.. Create the siginfo structure */
|
|
|
|
info.si_signo = event->sigev_signo;
|
|
info.si_code = code;
|
|
info.si_errno = OK;
|
|
#ifdef CONFIG_SCHED_HAVE_PARENT
|
|
info.si_pid = rtcb->pid;
|
|
info.si_status = OK;
|
|
#endif
|
|
|
|
/* Some compilers (e.g., SDCC), do not permit assignment of aggregates.
|
|
* Use of memcpy() is overkill; We could just copy the larger of the
|
|
* nt and FAR void * members in the union. memcpy(), however, does
|
|
* not require that we know which is larger.
|
|
*/
|
|
|
|
memcpy(&info.si_value, &event->sigev_value, sizeof(union sigval));
|
|
|
|
/* Send the signal */
|
|
|
|
return nxsig_dispatch(pid, &info);
|
|
}
|
|
|
|
#ifdef CONFIG_SIG_EVTHREAD
|
|
/* Notify the client via a function call */
|
|
|
|
else if (event->sigev_notify == SIGEV_THREAD)
|
|
{
|
|
/* Initialize the work information */
|
|
|
|
work->value = event->sigev_value;
|
|
work->func = event->sigev_notify_function;
|
|
|
|
/* Then queue the work */
|
|
|
|
return work_queue(SIG_EVTHREAD_WORK, &work->work,
|
|
nxsig_notification_worker, work, 0);
|
|
}
|
|
#endif
|
|
|
|
return event->sigev_notify == SIGEV_NONE ? OK : -ENOSYS;
|
|
}
|
|
|
|
/****************************************************************************
|
|
* Name: nxsig_cancel_notification
|
|
*
|
|
* Description:
|
|
* Cancel the notification if it doesn't send yet.
|
|
*
|
|
* Input Parameters:
|
|
* work - The work structure to cancel
|
|
*
|
|
* Returned Value:
|
|
* None
|
|
*
|
|
****************************************************************************/
|
|
|
|
#ifdef CONFIG_SIG_EVTHREAD
|
|
void nxsig_cancel_notification(FAR struct sigwork_s *work)
|
|
{
|
|
work_cancel(SIG_EVTHREAD_WORK, &work->work);
|
|
}
|
|
#endif
|