nuttx/drivers/syslog/syslog_rpmsg.c
ligd 0d24582fe0 syslog_rpmsg: fix system crash when open CONFIG_SCHED_HAVE_PARENT
Reason:
nx_start use syslog at every early time event the idle thread not
full setup, then syslog_rpmsg -> work_queue -> work_signal ->
nxsig_kill -> rtcb is NULL -> crash

Fix:
sched work_queue after is_rpmsg_ept_ready() is true

Change-Id: I225469ff2526e4b810bf3e23473b55d57e64a1ff
Signed-off-by: ligd <liguiding1@xiaomi.com>
2021-03-03 19:08:15 -08:00

392 lines
11 KiB
C

/****************************************************************************
* drivers/syslog/syslog_rpmsg.c
*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership. The
* ASF licenses this file to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance with the
* License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
* License for the specific language governing permissions and limitations
* under the License.
*
****************************************************************************/
/****************************************************************************
* Included Files
****************************************************************************/
#include <nuttx/config.h>
#include <ctype.h>
#include <errno.h>
#include <string.h>
#include <nuttx/irq.h>
#include <nuttx/rptun/openamp.h>
#include <nuttx/syslog/syslog.h>
#include <nuttx/syslog/syslog_rpmsg.h>
#include <nuttx/wqueue.h>
#include "syslog.h"
#include "syslog_rpmsg.h"
/****************************************************************************
* Pre-processor definitions
****************************************************************************/
#define SYSLOG_RPMSG_WORK_DELAY MSEC2TICK(CONFIG_SYSLOG_RPMSG_WORK_DELAY)
#define SYSLOG_RPMSG_COUNT(h, t, size) ((B2C_OFF(h)>=(t)) ? \
B2C_OFF(h)-(t) : \
(size)-((t)-B2C_OFF(h)))
#define SYSLOG_RPMSG_SPACE(h, t, size) ((size) - 1 - SYSLOG_RPMSG_COUNT(h, t, size))
/****************************************************************************
* Private Types
****************************************************************************/
struct syslog_rpmsg_s
{
volatile size_t head; /* The head index (where data is added) */
volatile size_t tail; /* The tail index (where data is removed) */
size_t size; /* Size of the RAM buffer */
FAR char *buffer; /* Circular RAM buffer */
struct work_s work; /* Used for deferred callback work */
struct rpmsg_endpoint ept;
FAR const char *cpuname;
bool suspend;
bool transfer; /* The transfer flag */
ssize_t trans_len; /* The data length when transfer */
};
/****************************************************************************
* Private Function Prototypes
****************************************************************************/
static void syslog_rpmsg_work(FAR void *priv_);
static void syslog_rpmsg_putchar(FAR struct syslog_rpmsg_s *priv, int ch,
bool last);
static void syslog_rpmsg_device_created(FAR struct rpmsg_device *rdev,
FAR void *priv_);
static void syslog_rpmsg_device_destroy(FAR struct rpmsg_device *rdev,
FAR void *priv_);
static int syslog_rpmsg_ept_cb(FAR struct rpmsg_endpoint *ept,
FAR void *data, size_t len, uint32_t src,
FAR void *priv_);
/****************************************************************************
* Private Data
****************************************************************************/
static struct syslog_rpmsg_s g_syslog_rpmsg;
/****************************************************************************
* Private Functions
****************************************************************************/
static void syslog_rpmsg_work(FAR void *priv_)
{
FAR struct syslog_rpmsg_transfer_s *msg = NULL;
FAR struct syslog_rpmsg_s *priv = priv_;
irqstate_t flags;
uint32_t space;
size_t len;
size_t len_end;
if (is_rpmsg_ept_ready(&priv->ept))
{
msg = rpmsg_get_tx_payload_buffer(&priv->ept, &space, false);
}
if (!msg)
{
work_queue(HPWORK, &priv->work, syslog_rpmsg_work, priv,
SYSLOG_RPMSG_WORK_DELAY);
return;
}
memset(msg, 0, sizeof(*msg));
flags = enter_critical_section();
if (B2C_REM(priv->head))
{
priv->head += C2B(1) - B2C_REM(priv->head);
}
space -= sizeof(*msg);
len = SYSLOG_RPMSG_COUNT(priv->head, priv->tail, priv->size);
len_end = priv->size - priv->tail;
if (len > space)
{
len = space;
}
if (len > len_end)
{
memcpy(msg->data, &priv->buffer[priv->tail], len_end);
memcpy(msg->data + len_end, priv->buffer, len - len_end);
}
else
{
memcpy(msg->data, &priv->buffer[priv->tail], len);
}
priv->trans_len = len;
priv->transfer = true;
leave_critical_section(flags);
msg->header.command = SYSLOG_RPMSG_TRANSFER;
msg->count = C2B(len);
rpmsg_send_nocopy(&priv->ept, msg, sizeof(*msg) + len);
}
static void syslog_rpmsg_putchar(FAR struct syslog_rpmsg_s *priv, int ch,
bool last)
{
if (B2C_REM(priv->head) == 0)
{
priv->buffer[B2C_OFF(priv->head)] = 0;
}
priv->buffer[B2C_OFF(priv->head)] |= (ch & 0xff) <<
(8 * B2C_REM(priv->head));
priv->head += 1;
if (priv->head >= C2B(priv->size))
{
priv->head = 0;
}
/* Allow overwrite */
if (priv->head == C2B(priv->tail))
{
priv->buffer[priv->tail] = 0;
priv->tail += 1;
if (priv->tail >= priv->size)
{
priv->tail = 0;
}
if (priv->transfer)
{
priv->trans_len--;
}
}
if (last && !priv->suspend && !priv->transfer &&
is_rpmsg_ept_ready(&priv->ept))
{
clock_t delay = SYSLOG_RPMSG_WORK_DELAY;
size_t space = SYSLOG_RPMSG_SPACE(priv->head, priv->tail, priv->size);
/* Start work immediately when data more then 75% and meet '\n' */
if (space < priv->size / 4 && ch == '\n')
{
delay = 0;
}
work_queue(HPWORK, &priv->work, syslog_rpmsg_work, priv, delay);
}
}
static void syslog_rpmsg_device_created(FAR struct rpmsg_device *rdev,
FAR void *priv_)
{
FAR struct syslog_rpmsg_s *priv = priv_;
int ret;
if (priv->buffer && strcmp(priv->cpuname, rpmsg_get_cpuname(rdev)) == 0)
{
priv->ept.priv = priv;
ret = rpmsg_create_ept(&priv->ept, rdev, SYSLOG_RPMSG_EPT_NAME,
RPMSG_ADDR_ANY, RPMSG_ADDR_ANY,
syslog_rpmsg_ept_cb, NULL);
if (ret == 0)
{
work_queue(HPWORK, &priv->work,
syslog_rpmsg_work, priv, SYSLOG_RPMSG_WORK_DELAY);
}
}
}
static void syslog_rpmsg_device_destroy(FAR struct rpmsg_device *rdev,
FAR void *priv_)
{
FAR struct syslog_rpmsg_s *priv = priv_;
if (priv->buffer && strcmp(priv->cpuname, rpmsg_get_cpuname(rdev)) == 0)
{
rpmsg_destroy_ept(&priv->ept);
}
}
static int syslog_rpmsg_ept_cb(FAR struct rpmsg_endpoint *ept,
FAR void *data, size_t len, uint32_t src,
FAR void *priv_)
{
FAR struct syslog_rpmsg_s *priv = priv_;
FAR struct syslog_rpmsg_header_s *header = data;
if (header->command == SYSLOG_RPMSG_SUSPEND)
{
work_cancel(HPWORK, &priv->work);
priv->suspend = true;
}
else if (header->command == SYSLOG_RPMSG_RESUME)
{
priv->suspend = false;
work_queue(HPWORK, &priv->work,
syslog_rpmsg_work, priv, SYSLOG_RPMSG_WORK_DELAY);
}
else if (header->command == SYSLOG_RPMSG_TRANSFER_DONE)
{
irqstate_t flags;
ssize_t len_end;
flags = enter_critical_section();
if (priv->trans_len > 0)
{
len_end = priv->size - priv->tail;
if (priv->trans_len > len_end)
{
memset(&priv->buffer[priv->tail], 0, len_end);
memset(priv->buffer, 0, priv->trans_len - len_end);
}
else
{
memset(&priv->buffer[priv->tail], 0, priv->trans_len);
}
priv->tail += priv->trans_len;
if (priv->tail >= priv->size)
{
priv->tail -= priv->size;
}
}
priv->transfer = false;
if (SYSLOG_RPMSG_COUNT(priv->head, priv->tail, priv->size))
{
work_queue(HPWORK, &priv->work, syslog_rpmsg_work, priv, 0);
}
leave_critical_section(flags);
}
return 0;
}
/****************************************************************************
* Public Functions
****************************************************************************/
int syslog_rpmsg_putc(int ch)
{
FAR struct syslog_rpmsg_s *priv = &g_syslog_rpmsg;
irqstate_t flags;
flags = enter_critical_section();
syslog_rpmsg_putchar(priv, ch, true);
leave_critical_section(flags);
return ch;
}
int syslog_rpmsg_flush(void)
{
FAR struct syslog_rpmsg_s *priv = &g_syslog_rpmsg;
work_queue(HPWORK, &priv->work, syslog_rpmsg_work, priv, 0);
return OK;
}
ssize_t syslog_rpmsg_write(FAR const char *buffer, size_t buflen)
{
FAR struct syslog_rpmsg_s *priv = &g_syslog_rpmsg;
irqstate_t flags;
size_t nwritten;
flags = enter_critical_section();
for (nwritten = 1; nwritten <= buflen; nwritten++)
{
syslog_rpmsg_putchar(priv, *buffer++, nwritten == buflen);
}
leave_critical_section(flags);
return buflen;
}
void syslog_rpmsg_init_early(FAR const char *cpuname, FAR void *buffer,
size_t size)
{
FAR struct syslog_rpmsg_s *priv = &g_syslog_rpmsg;
char prev, cur;
size_t i;
size_t j;
priv->cpuname = cpuname;
priv->buffer = buffer;
priv->size = size;
prev = (priv->buffer[size - 1] >> (CHAR_BIT - 8)) & 0xff;
for (i = 0; i < size; i++)
{
for (j = 0; j * 8 < CHAR_BIT; j++)
{
cur = (priv->buffer[i] >> j * 8) & 0xff;
if (!isascii(cur))
{
goto out;
}
if (prev && !cur)
{
priv->head = C2B(i) + j;
}
if (!prev && cur)
{
priv->tail = i;
}
prev = cur;
}
}
out:
if (i != size)
{
priv->head = priv->tail = 0;
memset(priv->buffer, 0, size);
}
}
int syslog_rpmsg_init(void)
{
return rpmsg_register_callback(&g_syslog_rpmsg,
syslog_rpmsg_device_created,
syslog_rpmsg_device_destroy,
NULL);
}