nuttx/fs/driver/fs_blockproxy.c
Gregory Nutt ae401cecdd Check return from nxsem_wait_initialize()
Resolution of Issue 619 will require multiple steps, this part of the first step in that resolution:  Every call to nxsem_wait_uninterruptible() must handle the return value from nxsem_wait_uninterruptible properly.  This commit is only for those files under fs/driver, fs/aio, fs/nfs, crypto/, and boards/.

Please note:  The modified file under fs/nfs generates several " Mixed case identifier found" errors.  Please ignore these.  These cannot be fixed without changes to numerous other files.  They also follow a non-standard convention that is used many files:  Using lower case structure names in custom SIZEOF_ definitions.
2020-03-30 17:09:45 +01:00

222 lines
6.1 KiB
C

/****************************************************************************
* fs/driver/fs_blockproxy.c
*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership. The
* ASF licenses this file to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance with the
* License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
* License for the specific language governing permissions and limitations
* under the License.
*
****************************************************************************/
/****************************************************************************
* Included Files
****************************************************************************/
#include <nuttx/config.h>
#include <sys/types.h>
#include <sys/stat.h>
#include <stdlib.h>
#include <unistd.h>
#include <stdio.h>
#include <fcntl.h>
#include <string.h>
#include <errno.h>
#include <assert.h>
#include <debug.h>
#include <nuttx/kmalloc.h>
#include <nuttx/drivers/drivers.h>
#include <nuttx/fs/fs.h>
#include <nuttx/semaphore.h>
#if !defined(CONFIG_DISABLE_MOUNTPOINT) && \
!defined(CONFIG_DISABLE_PSEUDOFS_OPERATIONS)
/****************************************************************************
* Private Data
****************************************************************************/
static uint32_t g_devno;
static sem_t g_devno_sem = SEM_INITIALIZER(1);
/****************************************************************************
* Private Functions
****************************************************************************/
/****************************************************************************
* Name: unique_chardev
*
* Description:
* Create a unique temporary device name in the /dev/ directory of the
* pseudo-file system. We cannot use mktemp for this because it will
* attempt to open() the file.
*
* Input Parameters:
* None
*
* Returned Value:
* The allocated path to the device. This must be released by the caller
* to prevent memory links. NULL will be returned only the case where
* we fail to allocate memory.
*
****************************************************************************/
static FAR char *unique_chardev(void)
{
struct stat statbuf;
char devbuf[16];
uint32_t devno;
int ret;
/* Loop until we get a unique device name */
for (; ; )
{
/* Get the semaphore protecting the path number */
ret = nxsem_wait_uninterruptible(&g_devno_sem);
if (ret < 0)
{
ferr("ERROR: nxsem_wait_uninterruptible failed: %d\n", ret);
return NULL;
}
/* Get the next device number and release the semaphore */
devno = ++g_devno;
nxsem_post(&g_devno_sem);
/* Construct the full device number */
devno &= 0xffffff;
snprintf(devbuf, 16, "/dev/tmpc%06lx", (unsigned long)devno);
/* Make sure that file name is not in use */
ret = stat(devbuf, &statbuf);
if (ret < 0)
{
DEBUGASSERT(errno == ENOENT);
return strdup(devbuf);
}
/* It is in use, try again */
}
}
/****************************************************************************
* Public Functions
****************************************************************************/
/****************************************************************************
* Name: block_proxy
*
* Description:
* Create a temporary char driver using drivers/bch to mediate character
* oriented accessed to the block driver.
*
* Input Parameters:
* blkdev - The path to the block driver
* oflags - Character driver open flags
*
* Returned Value:
* If positive, non-zero file descriptor is returned on success. This
* is the file descriptor of the nameless character driver that mediates
* accesses to the block driver.
*
* Errors that may be returned:
*
* ENOMEM - Failed to create a temporary path name.
*
* Plus:
*
* - Errors reported from bchdev_register()
* - Errors reported from open() or unlink()
*
****************************************************************************/
int block_proxy(FAR const char *blkdev, int oflags)
{
FAR char *chardev;
bool readonly;
int ret;
int fd;
DEBUGASSERT(blkdev);
/* Create a unique temporary file name for the character device */
chardev = unique_chardev();
if (chardev == NULL)
{
ferr("ERROR: Failed to create temporary device name\n");
return -ENOMEM;
}
/* Should this character driver be read-only? */
readonly = ((oflags & O_WROK) == 0);
/* Wrap the block driver with an instance of the BCH driver */
ret = bchdev_register(blkdev, chardev, readonly);
if (ret < 0)
{
ferr("ERROR: bchdev_register(%s, %s) failed: %d\n",
blkdev, chardev, ret);
goto errout_with_chardev;
}
/* Open the newly created character driver */
oflags &= ~(O_CREAT | O_EXCL | O_APPEND | O_TRUNC);
fd = nx_open(chardev, oflags);
if (fd < 0)
{
ret = fd;
ferr("ERROR: Failed to open %s: %d\n", chardev, ret);
goto errout_with_bchdev;
}
/* Unlink the character device name. The driver instance will persist,
* provided that CONFIG_DISABLE_PSEUDOFS_OPERATIONS=y (otherwise, we have
* a problem here!)
*/
ret = unlink(chardev);
if (ret < 0)
{
ret = -errno;
ferr("ERROR: Failed to unlink %s: %d\n", chardev, ret);
}
/* Free the allocate character driver name and return the open file
* descriptor.
*/
kmm_free(chardev);
return fd;
errout_with_bchdev:
unlink(chardev);
errout_with_chardev:
kmm_free(chardev);
return ret;
}
#endif /* !CONFIG_DISABLE_MOUNTPOINT && !CONFIG_DISABLE_PSEUDOFS_OPERATIONS */