tilda: Fix OOB write in `start_default_shell()`

This commit is contained in:
Tee KOBAYASHI 2022-04-24 11:35:36 +09:00 committed by xtkoba
parent 10b4e9727a
commit 4a7b7a9afc
2 changed files with 25 additions and 1 deletions

View File

@ -3,7 +3,7 @@ TERMUX_PKG_DESCRIPTION="A Gtk based drop down terminal for Linux and Unix."
TERMUX_PKG_LICENSE="GPL-2.0"
TERMUX_PKG_MAINTAINER="@ELWAER-M"
TERMUX_PKG_VERSION="1.6-alpha"
TERMUX_PKG_REVISION=6
TERMUX_PKG_REVISION=7
TERMUX_PKG_SRCURL=https://github.com/lanoxx/tilda/archive/a8f70a8b9300992dc13185112a251b90850fd96e.tar.gz
TERMUX_PKG_SHA256=83c3bdccd9f41183cf656c11f925cf383f7cf0cbafbd56f51d8a1e2983bb7739
TERMUX_PKG_DEPENDS="glib, gtk3, libvte, libconfuse, libx11, gettext"

View File

@ -0,0 +1,24 @@
https://github.com/lanoxx/tilda/pull/481
From 4db8680584d3f7e14668e4105c710669338a2f0d Mon Sep 17 00:00:00 2001
From: xtkoba <69125751+xtkoba@users.noreply.github.com>
Date: Sun, 24 Apr 2022 11:32:41 +0900
Subject: [PATCH] Fix OOB write in `start_default_shell()`
---
src/tilda_terminal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/tilda_terminal.c b/src/tilda_terminal.c
index 84baab74..c9f613aa 100644
--- a/src/tilda_terminal.c
+++ b/src/tilda_terminal.c
@@ -573,7 +573,7 @@ start_default_shell (tilda_term *tt)
*/
flags |= G_SPAWN_FILE_AND_ARGV_ZERO;
} else {
- argv = malloc(1 * sizeof(void *));
+ argv = malloc(2 * sizeof(void *));
argv[0] = default_command;
argv[1] = NULL;
}