From 64c2ed40b0f5cabd0bf7a63871fca4071309a89d Mon Sep 17 00:00:00 2001
From: Aditya Alok <dev.aditya.alok@gmail.com>
Date: Wed, 30 Mar 2022 00:47:37 +0530
Subject: [PATCH] fix(termux_github_api_get_tag): addition of '|000' when
 `extra_curl_opts[1]` was empty

Signed-off-by: Aditya Alok <dev.aditya.alok@gmail.com>
---
 .../updates/api/termux_github_api_get_tag.sh  | 27 +++++++++----------
 1 file changed, 13 insertions(+), 14 deletions(-)

diff --git a/scripts/updates/api/termux_github_api_get_tag.sh b/scripts/updates/api/termux_github_api_get_tag.sh
index 1c4dc4c0c..9a36ea8fb 100644
--- a/scripts/updates/api/termux_github_api_get_tag.sh
+++ b/scripts/updates/api/termux_github_api_get_tag.sh
@@ -31,14 +31,22 @@ termux_github_api_get_tag() {
 
 	local jq_filter
 	local api_url="https://api.github.com"
-	local -a extra_curl_opts
+	local -a curl_opts=(
+		--silent
+		--location
+		--retry 10
+		--retry-delay 1
+		-H "Authorization: token ${GITHUB_TOKEN}"
+		-H "Accept: application/vnd.github.v3+json"
+		--write-out '|%{http_code}'
+	)
 
 	if [[ "${TAG_TYPE}" == "newest-tag" ]]; then
 		api_url="${api_url}/graphql"
 		jq_filter='.data.repository.refs.edges[0].node.name'
-		extra_curl_opts=(
-			"-X POST"
-			"-d $(
+		curl_opts+=(-X POST)
+		curl_opts+=(
+			-d "$(
 				cat <<-EOF | tr '\n' ' '
 					{
 						"query": "query {
@@ -71,16 +79,7 @@ termux_github_api_get_tag() {
 	fi
 
 	local response
-	# shellcheck disable=SC2086 # we need expansion of ${extra_curl_opts[0]}
-	response="$(
-		curl --silent --location --retry 10 --retry-delay 1 \
-			-H "Authorization: token ${GITHUB_TOKEN}" \
-			-H "Accept: application/vnd.github.v3+json" \
-			--write-out '|%{http_code}' \
-			${extra_curl_opts[0]:-} \
-			"${extra_curl_opts[1]:-}" \
-			"${api_url}"
-	)"
+	response="$(curl "${curl_opts[@]}" "${api_url}")"
 
 	local http_code
 	http_code="${response##*|}"