sergiotarxz/termux-packages
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Remove --with-coroutine=copy from configure args

Browse Source 
The configure argument `--with-coroutine=copy` was added because in the era of version 2.7 Ruby was defaulted to using `ucontext` for coroutine implementation on ARMv7, causing a build issue (https://github.com/termux/termux-packages/pull/5025). Now this configure argument is no longer necessary because Ruby version 3.0 (or later) by default uses "native" coroutine implementation for ARMv7 (and also for other three archs supported by Android).

Furthermore, `copy` coroutine implementation has its own deficiencies and is planned to be removed from Ruby 3.1 (https://bugs.ruby-lang.org/issues/18015). I see no reason to use `copy` coroutine where a working native implementation is available.
This commit is contained in:
xtkoba 2021-09-05 09:38:31 +09:00 committed by Henrik Grimler
parent 161cfe22b7
commit 87ca46cecd
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/ruby/build.sh
View File

@ -12,7 +12,7 @@ TERMUX_PKG_RECOMMENDS="clang, make, pkg-config"
TERMUX_PKG_BREAKS="ruby-dev"
TERMUX_PKG_REPLACES="ruby-dev"
# Needed to fix compilation on android:
TERMUX_PKG_EXTRA_CONFIGURE_ARGS="ac_cv_func_setgroups=no ac_cv_func_setresuid=no ac_cv_func_setreuid=no --enable-rubygems --with-coroutine=copy"
TERMUX_PKG_EXTRA_CONFIGURE_ARGS="ac_cv_func_setgroups=no ac_cv_func_setresuid=no ac_cv_func_setreuid=no --enable-rubygems"
# The gdbm module seems to be very little used:
TERMUX_PKG_EXTRA_CONFIGURE_ARGS+=" --without-gdbm"
# Do not link in libcrypt.so if available (now in disabled-packages):