Took me an annoyingly long time to find a mask that the ndk was happy
with. The original mask gives identical permissions as this one (and
several other variants I tried). printf("%d\n", ~(S_IRUSR | S_IWUSR));
returns a negative number, and I guess that is the reason the ndk is
unhappy.
Original error message:
restart.c:233:48: error: 'umask' called with invalid mode
mode_t oldmask = umask(~(S_IRUSR | S_IWUSR));
^
/home/builder/.termux-build/_cache/android-r21d-api-24-v3/bin/../sysroot/usr/include/bits/fortify/stat.h:47:5: note: from 'diagnose_if' attribute on 'umask':
__clang_error_if(mode & ~0777, "'umask' called with invalid mode") {
^ ~~~~~~~~~~~~
/home/builder/.termux-build/_cache/android-r21d-api-24-v3/bin/../sysroot/usr/include/sys/cdefs.h:134:52: note: expanded from macro '__clang_error_if'
^
1 error generated.
make[2]: *** [Makefile:1060: memcached-restart.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [Makefile:1699: all-recursive] Error 1
In issue https://github.com/termux/termux-packages/issues/6160 I have found
that community repo "its-pointless.github.io" specifies us as maintainer
for its packages. This is NOT TRUE and potentially misleads people using
these packages.
Now TERMUX_PKG_MAINTAINER will contain a default value which is neutral
and not specify maintainer. So all packages now have to override it to
the correct value.
[skip ci]
%ci:no-build
Variables
TERMUX_PKG_PLATFORM_INDEPENDENT
TERMUX_DEBUG
TERMUX_PKG_HAS_DEBUG
TERMUX_PKG_ESSENTIAL
TERMUX_SUBPKG_ESSENTIAL
TERMUX_PKG_NO_STATICSPLIT
TERMUX_PKG_BUILD_IN_SRC
TERMUX_PKG_FORCE_CMAKE
TERMUX_PKG_HOSTBUILD
should not accept arbitrary values for marking them "enabled". Instead
they should accept boolean values which makes them easier to handle and
also makes their meaning clear.
build-package.sh should make decision based on variable's value but not on
whether it is set or empty.
%ci:no-build
Oskar
Henrik Grimler
Leonid Pliushch
Butta
Fredrik Fornwall
David Martínez