Commit Graph

663 Commits

Author SHA1 Message Date
Drew Jaynes (DrewAPicture)
08fd193850 Inline documentation cleanup for 4.0 audit.
* Alignment for the 'term_search_min_chars' hook docs, added in [28892]
* Globals added for `wp_ajax_parse_embed()`, added [28580]

See #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29151 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-14 00:05:37 +00:00
Drew Jaynes (DrewAPicture)
1bf87b2c9e Fill out inline documentation for magic methods added to the WP_List_Table class in [28493], [28521], and [28524].
See #22234 and #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29148 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-13 23:54:15 +00:00
Drew Jaynes (DrewAPicture)
343c544f6b Fill out inline documentation for magic methods added to the WP_Filesystem_Base class in [28521].
See #22234 and #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29147 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-13 23:51:39 +00:00
Scott Taylor
510ad2e1e9 Fix mismatches in access modifiers for WP_List_Table + subclasses.
Fixes #28843, #28879.


git-svn-id: https://develop.svn.wordpress.org/trunk@29137 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-13 22:08:22 +00:00
Dominik Schilling (ocean90)
33db0d4ff2 Lists View Switcher: Replace blank image with screen reader text.
props davidakennedy.
fixes #28871.

git-svn-id: https://develop.svn.wordpress.org/trunk@29133 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-13 11:04:21 +00:00
Dominik Schilling (ocean90)
d198c0bdd5 Remove unused variable in wp_dashboard_plugins_output(). Unused since [26144].
props michalzuber.
see #28872.

git-svn-id: https://develop.svn.wordpress.org/trunk@29130 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-13 10:30:53 +00:00
Dominik Schilling (ocean90)
1285d1450b Improvements to the plugin information modal:
* Whitespace/braces cleanup for [29040].
* Reduce width of modal to 792px, which is the default banner size.
* Reduce banner height when screen height is smaller than 500px.
* Remove inline CSS.
* Re-use tab var in JS.
* Encode ampersands in links.

props avryl, michalzuber, ocean90.
see #27440.


git-svn-id: https://develop.svn.wordpress.org/trunk@29125 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-12 22:07:16 +00:00
Sergey Biryukov
c52f02cc3f Use correct ID for plugin search input label.
Make the search button name and ID consistent with the ones in WP_List_Table::search_box().

props joedolson.
fixes #28856.

git-svn-id: https://develop.svn.wordpress.org/trunk@29123 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-12 17:44:51 +00:00
Scott Taylor
63cb20cc5a Repent for our original OOP sins and doc blocks as pertains to access modifiers in List Table + subclasses.
Props SergeyBiryukov.
See #28843 and [28583].


git-svn-id: https://develop.svn.wordpress.org/trunk@29118 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-12 03:26:40 +00:00
Scott Taylor
d1f4b3a800 Media Grid, for audio files:
* Show `artist` and `album` fields in the Edit Attachment modal
* Sync their values on `change`

See #28839.


git-svn-id: https://develop.svn.wordpress.org/trunk@29104 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-11 20:54:13 +00:00
Sergey Biryukov
8a45aefe56 Escape taxonomy name when used in attributes in post_categories_meta_box().
props pbearne.
fixes #28836.

git-svn-id: https://develop.svn.wordpress.org/trunk@29099 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-11 18:55:48 +00:00
Scott Taylor
ee0e7ccbca Media Grid: make registering Screen Options for non-list tables more generic.
See #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@29079 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-10 21:43:49 +00:00
Scott Taylor
d5cbf00457 Media Grid: Screen Options for grid have to play nice with Screen Options for list. This was fun.
See #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@29078 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-10 21:25:49 +00:00
Scott Taylor
3ebde0c4d6 Media Grid: Move toggling of visible fields to Screen Options. This moves us in a better direction... but this will probably need to be massaged again.
See #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@29077 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-10 20:59:12 +00:00
Andrew Nacin
0838b61b1d Unload the current default textdomain in wp_install_load_language().
see #28577.


git-svn-id: https://develop.svn.wordpress.org/trunk@29059 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-10 09:54:06 +00:00
Helen Hou-Sandi
2a5fa0e4c5 Display plugin install results as "cards" rather than in a list table, first run.
props stephdau, ryelle, tellyworth, melchoyce. see #28785, #28646.



git-svn-id: https://develop.svn.wordpress.org/trunk@29047 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-09 20:01:35 +00:00
Helen Hou-Sandi
56706c324d Improvements to the plugin information modal:
* Show the banner image when available.
* Show contributors and ratings breakdown in the FYI box.
* Show reviews in a tab.

props stephdau, tellyworth, paulwilde, michalzuber. see #27440. fixes #19784, #22599, #26202.


git-svn-id: https://develop.svn.wordpress.org/trunk@29040 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-09 17:27:22 +00:00
Drew Jaynes (DrewAPicture)
854fa2b5d6 Add @see reference for set_post_thumbnail() in the phpDoc for wp_ajax_set_attachment_thumbnail().
See #27891.


git-svn-id: https://develop.svn.wordpress.org/trunk@29037 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-08 20:35:53 +00:00
Scott Taylor
c6428ff1ba When setting the poster image for a video shortcode, set that image as the featured image for that attachment (if found) in the background. This AJAX functionality could be used for audio as well.
Introduces `attachment_url_to_postid()` to attempt to turn URLs into post IDs.

Fixes #27891.


git-svn-id: https://develop.svn.wordpress.org/trunk@29029 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-08 17:47:53 +00:00
John Blackbourn
b72068ba06 Narrower layout and loading spinner for the install screen language selector. See #28577
git-svn-id: https://develop.svn.wordpress.org/trunk@29021 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-08 00:32:29 +00:00
John Blackbourn
02a22f7dd4 Focus and blur styling (via JS) for the install screen language selector. Props jorbin. See #28577
git-svn-id: https://develop.svn.wordpress.org/trunk@29020 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-08 00:29:47 +00:00
Andrew Nacin
8f15bef515 Language on install: Docs and naming cleanups. see #28577.
git-svn-id: https://develop.svn.wordpress.org/trunk@29018 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-07 21:48:50 +00:00
John Blackbourn
1f51b720f0 Correct the usage of the variable passed to wp_install_download_language_pack() and kill an unused local variable. Props michalzuber. Also avoid using the $_REQUEST superglobal in this function. See #28577.
git-svn-id: https://develop.svn.wordpress.org/trunk@29016 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-07 18:05:13 +00:00
Andrew Nacin
277ada83d8 Bring the language chooser to setup-config.php.
see #28577.


git-svn-id: https://develop.svn.wordpress.org/trunk@29006 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-05 05:13:05 +00:00
Sergey Biryukov
c1c0693cee Reinstate 'install_themes_tabs' filter.
props ghost1227.
fixes #28578.

git-svn-id: https://develop.svn.wordpress.org/trunk@29002 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-04 23:57:39 +00:00
Drew Jaynes (DrewAPicture)
79dd39c19c Note in the hook docs for preview_post_link that the $post parameter was added.
See #28729.


git-svn-id: https://develop.svn.wordpress.org/trunk@28979 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 20:04:56 +00:00
Drew Jaynes (DrewAPicture)
b1b454c7a0 Remove backticks on $post variables in some short parameter descriptions.
See [28653], [28654].
See #28388.


git-svn-id: https://develop.svn.wordpress.org/trunk@28976 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 19:27:54 +00:00
Drew Jaynes (DrewAPicture)
7ffc91fdd6 Fix an incomplete docblock for wp_create_categories() as part of $post/$post_id cleanup.
See #28388.


git-svn-id: https://develop.svn.wordpress.org/trunk@28975 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 19:21:34 +00:00
John Blackbourn
c18a28f792 Use the admin scheme for theme preview URLs when installing new themes. See #21919.
git-svn-id: https://develop.svn.wordpress.org/trunk@28974 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 18:47:33 +00:00
Helen Hou-Sandi
3adcda996b Improve oEmbed caching. Introduces the concept of a TTL for oEmbed caches and a filter for oembed_ttl.
We will no longer replace previously valid oEmbed responses with an `{{unknown}}` cache value. When this happens due to reaching a rate limit or a service going down, it is data loss, and is not acceptable. This means that oEmbed caches for a post are no longer deleted indiscriminately every time that post is saved.

oEmbed continues to be cached in post meta, with the addition of a separate meta key containing the timestamp of the last retrieval, which is used to avoid re-requesting a recently cached oEmbed response. By default, we consider a valued cached in the past day to be fresh. This can greatly reduce the number of outbound requests, especially in cases where a post containing multiple embeds is saved frequently.

The TTL used to determine whether or not to request a response can be filtered using `oembed_ttl`, thus allowing for the possibility of respecting the optional oEmbed response parameter `cache_age` or altering the period of time a cached value is considered to be fresh.

Now that oEmbeds are previewed in the visual editor as well as the media modal, oEmbed caches are often populated before a post is saved or published. By pre-populating and avoiding having to re-request that response, we also greatly reduce the chances of a stampede happening when a published post is visible before oEmbed caching is complete.

As it previously stood, a stampede was extremely likely to happen, as the AJAX caching was only triggered when `$_GET['message']` was 1. The published message is 6. We now trigger the caching every time `$_GET['message']` is present on the edit screen, as we are able to avoid triggering so many HTTP requests overall.

props markjaquith. fixes #14759. see #17210.


git-svn-id: https://develop.svn.wordpress.org/trunk@28972 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 16:44:15 +00:00
Sergey Biryukov
8bf7ed77f3 Pass $post object to 'preview_post_link' filter.
props danielbachhuber.
fixes #28729.

git-svn-id: https://develop.svn.wordpress.org/trunk@28969 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 14:41:06 +00:00
Sergey Biryukov
8ee9631bb4 Remove non-breaking spaces from auto update email text.
props trepmal.
fixes #28715.

git-svn-id: https://develop.svn.wordpress.org/trunk@28956 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-02 12:45:31 +00:00
Sergey Biryukov
0d2817bf9e Simplify a condition in get_sample_permalink_html().
see #28350.

git-svn-id: https://develop.svn.wordpress.org/trunk@28948 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-02 00:10:13 +00:00
Sergey Biryukov
3fe0336a63 Simplify logic in get_sample_permalink_html(), remove duplicated code.
see #28350.

git-svn-id: https://develop.svn.wordpress.org/trunk@28947 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-02 00:03:53 +00:00
Sergey Biryukov
7a8bedaf2a Display a correct preview link for drafts when permalinks are disabled.
see #28350.

git-svn-id: https://develop.svn.wordpress.org/trunk@28946 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-01 23:55:58 +00:00
Sergey Biryukov
913392b9a9 Display consistent preview links for drafts.
props mordauk.
fixes #28350.

git-svn-id: https://develop.svn.wordpress.org/trunk@28920 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-30 10:02:01 +00:00
Andrew Ozz
df6eb733eb Secure embeds in the editor (first run):
- When the user pastes an embeddable http URL, try to get the https embed.
- If an embed provider doesn't support ssl embeds, show a placeholder/error message.
- Revise the way we return error messages.
See #28195, #28507.

git-svn-id: https://develop.svn.wordpress.org/trunk@28919 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-30 05:48:16 +00:00
Sergey Biryukov
29aabd08a9 Prevent bulk actions from being performed when Filter button is clicked.
props jesin.
fixes #28555.

git-svn-id: https://develop.svn.wordpress.org/trunk@28916 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-30 01:09:25 +00:00
Scott Taylor
11da6abc57 Allow comments in the trash to marked as spam.
Props mordauk.
Fixes #19256.


git-svn-id: https://develop.svn.wordpress.org/trunk@28913 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-29 23:18:24 +00:00
Scott Taylor
48c145ee78 WP_Filesystem_Base->abspath() should use the WPINC constant
Props wojtek.szkutnik
See #14157.


git-svn-id: https://develop.svn.wordpress.org/trunk@28904 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-29 22:15:10 +00:00
Sergey Biryukov
1e7b12978c Set date format before going into the loop to avoid a PHP notice if 'lastupdated' column is filtered out.
props jeremyfelt.
fixes #27614.

git-svn-id: https://develop.svn.wordpress.org/trunk@28898 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-29 18:10:52 +00:00
Sergey Biryukov
107001213b Fix feature pointer positioning issues for both LTR and RTL.
fixes #28062.

git-svn-id: https://develop.svn.wordpress.org/trunk@28897 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-29 16:05:53 +00:00
John Blackbourn
3426416dac Normalise the schemes used in get_home_path() so it returns the correct path for sites using SSL in the admin area but not the front end. Fixes #25767. Props GregLone for the initial patch.
git-svn-id: https://develop.svn.wordpress.org/trunk@28893 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-29 10:28:52 +00:00
John Blackbourn
075be3e54b Introduce a filter to control the minimum characters required for an AJAX term search. Fixes #13580. Props iamfriendly, brianlayman
git-svn-id: https://develop.svn.wordpress.org/trunk@28892 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-29 10:04:05 +00:00
Helen Hou-Sandi
9becde117d Make the posts list table mode a sticky user setting. props garyc40, azaozz, ericmann. fixes #16774, #20335.
git-svn-id: https://develop.svn.wordpress.org/trunk@28876 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-28 02:16:59 +00:00
Scott Taylor
572e27c682 Remove remaining Heartbeat API experimental notices
Props DH-Shredder.
Fixes #28626.


git-svn-id: https://develop.svn.wordpress.org/trunk@28872 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-28 02:05:54 +00:00
Scott Taylor
2371f75688 In deprecated media iframe code, attachment_fields_to_save filter should not be called twice after initial image upload in post.
Props SergeyBiryukov.
Fixes #20720.


git-svn-id: https://develop.svn.wordpress.org/trunk@28871 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-27 21:31:28 +00:00
Andrew Ozz
38debafe60 Uploader: enable selecting multiple files on mobile devices (still doesn't work on Android). See #28640.
git-svn-id: https://develop.svn.wordpress.org/trunk@28847 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-26 04:14:59 +00:00
Scott Taylor
cf15c523d3 Only apply a subtle semi-transparent border to attachments that are images in the media list table.
See [28842], #15860.



git-svn-id: https://develop.svn.wordpress.org/trunk@28843 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-26 01:57:37 +00:00
Scott Taylor
95f3506532 In media_buttons(), add a static var $instance to increment the id attribute of insert-media-button-%d on each call.
Props ericlewis.
Fixes #28090.


git-svn-id: https://develop.svn.wordpress.org/trunk@28837 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-26 01:04:32 +00:00