Commit Graph

33695 Commits

Author SHA1 Message Date
Boone Gorges 0a1e0cd7d6 Tests: Make sure that `test_wp_mail_break_it()` makes an assertion.
Let's make what is possibly the oddest test in WordPress even a bit odder.

See https://core.trac.wordpress.org/ticket/28909#comment:47 for backstory on
the test.

See #36016.

git-svn-id: https://develop.svn.wordpress.org/trunk@36786 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-29 22:04:32 +00:00
Boone Gorges 7505593ab8 Tests: `setExpectedDeprecated` and `setExpectedIncorrectUsage` tests should make assertions.
Introduced in [31306].

See #36016.

git-svn-id: https://develop.svn.wordpress.org/trunk@36785 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-29 21:55:41 +00:00
Boone Gorges 603fee5749 More specific test for a bad callback in `WP_Customize_Partial` test.
The 'render_callback' passed to `WP_Customize_Partial` must either echo or
return a result - not both. When it's detected that the callback echoes and
returns a value, the return value takes precedence. This is now reflected in
the corresponding unit test.

Introduced in [36586].

See #27355. See #36016.

git-svn-id: https://develop.svn.wordpress.org/trunk@36784 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-29 21:53:18 +00:00
Dominik Schilling (ocean90) f35fa3e58d Media: JSHint for `wp-playlist.js`.
File was added to the watchlist in [36780].

See #35984.

git-svn-id: https://develop.svn.wordpress.org/trunk@36783 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-29 21:49:36 +00:00
Boone Gorges 8b7fdc982f Remove test related to deprecated Customizer `export_preview_data()` method.
The method was gutted and deprecated in [36586], so there's no reason to keep
the test.

See #36016.

git-svn-id: https://develop.svn.wordpress.org/trunk@36782 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-29 21:07:00 +00:00
Dominik Schilling (ocean90) f8af8cdc6c i18n tools: In `StringExtractor` don't strip slashes from URLs.
Props SergeyBiryukov, ocean90.
Fixes #36015.

git-svn-id: https://develop.svn.wordpress.org/trunk@36781 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-29 20:44:31 +00:00
Dominik Schilling (ocean90) 5f808bd8fc Media: Add support for minified versions of wp-playlist.js, wp-mediaelement.js and wp-mediaelement.css.
Fixes #35984.

git-svn-id: https://develop.svn.wordpress.org/trunk@36780 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-29 20:42:10 +00:00
Boone Gorges 070b8a6154 Put an assertion in `test_nonexistent_array()` test.
The point of the test is to demonstrate that PHP doesn't throw a notice when
calling `unset()` on an undefined array key. To placate PHPUnit's useless test
detection, we add a redundant assertion.

Introduced in [25240].

See #36016.

git-svn-id: https://develop.svn.wordpress.org/trunk@36779 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-29 20:34:48 +00:00
Boone Gorges 60b307b941 Make sure an assertion takes place in 'visited' test for `get_category_parents()`.
See #36016.

git-svn-id: https://develop.svn.wordpress.org/trunk@36778 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-29 20:30:04 +00:00
Andrew Ozz 259b343c36 TinyMCE, inline link:
- Fix running wpLink without tinymce.js and the TinyMCE plugin without wplink.js.
- Do not show the Advanced button in the inline link dialog when wpLink is not loaded.

See #33301.

git-svn-id: https://develop.svn.wordpress.org/trunk@36777 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-29 19:37:42 +00:00
Weston Ruter 8ce52f3926 Customize: Fix PHP notice when calling `WP_Customize_Control::json()` inside `content_template()` method.
A `temp` control is instantiated when `WP_Customize_Manager:: render_control_templates()` is called. This control needs to explicitly specify an empty settings array to avoid trying to use a `temp` setting which won't exist.

See #35926.
See #29572.


git-svn-id: https://develop.svn.wordpress.org/trunk@36776 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-29 07:02:24 +00:00
Sergey Biryukov 13e409ac15 Formatting: In `sanitize_title_with_dashes()`, convert `&nbsp`, `&ndash`, and `&mdash` HTML entities to hyphens on save.
Props polevaultweb for initial patch.
Fixes #31790.

git-svn-id: https://develop.svn.wordpress.org/trunk@36775 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-29 04:41:03 +00:00
Sergey Biryukov f188597025 Comments: Avoid extra AJAX requests when undoing Spam or Trash actions.
Props afercia.
Fixes #35904.

git-svn-id: https://develop.svn.wordpress.org/trunk@36774 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-29 03:19:48 +00:00
Sergey Biryukov ea2d437b6b I18N: Remove `<code>` tags from translatable string in `wp-admin/network/site-new.php`.
Props ramiy.
Fixes #35994.

git-svn-id: https://develop.svn.wordpress.org/trunk@36773 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-29 03:16:45 +00:00
Sergey Biryukov e3e6cd356a I18N: Remove `<a>` tag from translatable string in `wp-includes/class-wp-customize-manager.php`.
Props ramiy.
Fixes #35992.

git-svn-id: https://develop.svn.wordpress.org/trunk@36772 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-29 03:13:18 +00:00
Sergey Biryukov 0814a33464 I18N: Remove `<code>` tag from translatable string in `wp-admin/network/site-new.php`.
Props ramiy.
Fixes #35989.

git-svn-id: https://develop.svn.wordpress.org/trunk@36771 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-29 02:43:47 +00:00
Sergey Biryukov cc35c82c16 I18N: Remove HTML tags from translatable strings in `wp-admin/network/themes.php`.
Props ramiy.
Fixes #35988.

git-svn-id: https://develop.svn.wordpress.org/trunk@36770 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-29 02:37:22 +00:00
Weston Ruter f60e7fd99d Customize: Allow `button_labels` to be overridden in `$args` passed to `WP_Customize_Media_Control` and `WP_Customize_Image_Control`.
Props chetanchauhan, celloexpressions.
See #33755.
Fixes #35542.


git-svn-id: https://develop.svn.wordpress.org/trunk@36769 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-29 00:39:33 +00:00
Drew Jaynes 92dbe29078 Posts: Add tests for the cascading fallback behavior of several 'public'-related arguments in `register_post_type()`.
Covers the 'exclude_from_search', 'publicly_queryable', 'show_ui', 'show_in_menu', 'show_in_nav_menus', and 'show_in_admin_bar' arguments, all of which eventually inherit from 'public' if not set.

Fixes #35985.


git-svn-id: https://develop.svn.wordpress.org/trunk@36768 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-28 22:58:45 +00:00
Andrea Fercia a19426f36a Comments: Add missing placeholder for `printf()` after [36683].
Fixes #35392.

git-svn-id: https://develop.svn.wordpress.org/trunk@36767 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-28 21:38:33 +00:00
Sergey Biryukov 4f91aae382 L10n: Add unit tests for `_n_noop()` and `_nx_noop()`.
Props realloc.
Fixes #35961.

git-svn-id: https://develop.svn.wordpress.org/trunk@36766 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-28 20:48:58 +00:00
Sergey Biryukov 5108255d19 Docs: Correct `_n_noop()` and `_nx_noop()` descriptions to use third-person singular verbs.
Props realloc.
See #35961.

git-svn-id: https://develop.svn.wordpress.org/trunk@36765 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-28 20:42:40 +00:00
Sergey Biryukov a18e7ae7c3 Ad a unit test for `bool_from_yn()`.
Props borgesbruno.
Fixes #35972.

git-svn-id: https://develop.svn.wordpress.org/trunk@36764 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-28 19:55:48 +00:00
Drew Jaynes f344da1aa6 Docs: Improve a variety of DocBlocks in wp-includes/deprecated.php.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36763 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-28 19:31:31 +00:00
Andrew Ozz 3a43def820 TinyMCE textpattern: `Horizontal line` is translated, `Horizontal rule` is not.
See #33300.

git-svn-id: https://develop.svn.wordpress.org/trunk@36762 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-28 19:17:21 +00:00
Andrew Ozz 392942e603 TinyMCE textpattern:
- Add description of the new patterns to the Shortcuts help modal.
- Fix the layout a bit and make the patterns in two columns.
- Disable the `textpatterns` plugin in IE < 9.

See #33300.

git-svn-id: https://develop.svn.wordpress.org/trunk@36761 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-28 18:59:25 +00:00
Drew Jaynes 5ca05ea8c8 Docs: Add missing parameter and return descriptions to the DocBlock for the deprecated `default_topic_count_text()`.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36760 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-28 18:35:25 +00:00
Drew Jaynes c7ad9afc25 Docs: Add missing parameter and return documentation to the DocBlock for the deprecated `_search_terms_tidy()`.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36759 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-28 18:34:10 +00:00
Drew Jaynes 2ecf2c2b13 Docs: Add missing documentation for the `&$post` parameter in the DocBlock for the deprecated `_get_post_ancestors()`.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36758 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-28 18:32:41 +00:00
Drew Jaynes 28e63d3162 Docs: Add missing documentation for the `$fp` parameter to the DocBlock for the deprecated `debug_fclose()`.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36757 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-28 18:30:31 +00:00
Drew Jaynes fd3810c7b4 Docs: Add missing parameter documentation to the DocBlock for the deprecated `debug_fwrite()`.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36756 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-28 18:29:44 +00:00
Drew Jaynes 70b3ee52e4 Docs: Add missing parameter and return documentation to the DocBlock for the deprecated `debug_fopen()`.
Fixes #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36755 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-28 18:19:39 +00:00
Drew Jaynes bf937da2f6 Docs: Add missing documentation for the `$wp_admin_bar` parameter in the DocBlock for the deprecated `wp_admin_bar_dashboard_view_site_menu()`.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36754 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-28 18:17:16 +00:00
Drew Jaynes f1e7a42756 Docs: Add missing documentation for the `$title` parameter in the DocBlock for the deprecated `parent_post_rel_link()`.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36753 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-28 18:15:42 +00:00
Dominik Schilling (ocean90) 388d20fa50 i18n tools: Sync makepot.php with i18n.svn.
Changes: https://i18n.trac.wordpress.org/log/tools/trunk/makepot.php?rev=40331&stop_rev=24749

Fixes #34910, #34749.

git-svn-id: https://develop.svn.wordpress.org/trunk@36752 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-28 10:33:15 +00:00
John Blackbourn 0436a2c2c6 Editor: Remove an unused JavaScript variable so the JS lint tests pass.
See #33301


git-svn-id: https://develop.svn.wordpress.org/trunk@36751 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-28 02:18:22 +00:00
John Blackbourn 54adcce28d Rewrite Rules: Ensure `url_to_postid()` operates as expected when it's used in the context of another site within a Multisite network that uses mixed URL schemes.
Fixes #35531


git-svn-id: https://develop.svn.wordpress.org/trunk@36750 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-28 02:12:13 +00:00
John Blackbourn 717c1c4041 HTTP API: Add the missing `1xx` HTTP response codes as constants of the `WP_Http` class, and add tests to ensure all available response codes are covered.
Fixes #36294


git-svn-id: https://develop.svn.wordpress.org/trunk@36749 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-28 01:45:24 +00:00
Drew Jaynes c51647b0b2 Docs: Remove a duplicate parameter notation in the DocBlock for the deprecated `the_editor()` function.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36748 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-27 21:40:12 +00:00
azaozz 70b1601fc4 TinyMCE, inline link:
- Fix in IE (again). Remove setting/getting placeholders, pass the link node instead.
- In the inline dialog: when the selected text looks like URL or email, pre-fill the URL field with it (same as in the modal).
- Fix setting the name of the main button in the modal: Add Link or Update.
- In the modal when clicking Update remove the link if the URL field is empty. That matches the inline dialog behaviour. Otherwise the modal remains open, nothing happens when clicking the Update button there.

See #33301.

git-svn-id: https://develop.svn.wordpress.org/trunk@36747 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-27 21:32:02 +00:00
Drew Jaynes a7a822ec8e Docs: Update the `@deprecated` tag comment for wp-includes/embed-template.php to reference the correct file path following [36693].
See #34561.


git-svn-id: https://develop.svn.wordpress.org/trunk@36746 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-27 21:21:12 +00:00
Drew Jaynes 180fd6bad4 Docs: Add a missing summary, `@access` tag, and parameter documentation to the DocBlock for `WP_Customize_Filter_Setting::update()`.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36745 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-27 21:16:37 +00:00
Dominik Schilling (ocean90) 592da58d26 Docs: Improve inline docs for `WP_Dependencies`, `WP_Styles`, and `WP_Scripts`.
Also, make them and related files part of WordPress.

See #35964.

git-svn-id: https://develop.svn.wordpress.org/trunk@36744 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-27 20:33:57 +00:00
Andrew Ozz d8c52aba85 TinyMCE, inline link:
- Fix applying the changes when pressing the Enter key in Firefox. No longer inserts new paragraph in the editor.
- Fix empty check when getting text from the dialog.
- Always focus the URL field when opening the dialog.
- Add back the keydown events in the modal.

See #33301.

git-svn-id: https://develop.svn.wordpress.org/trunk@36743 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-27 00:51:41 +00:00
Mike Schroder be3ba15eec Media: Correct "Exception" typo in WP_Image_Editor_Imagick::strip_meta().
Exceptions are caught better if they're not excpeted.

Props joemcgill.
See #33642.

git-svn-id: https://develop.svn.wordpress.org/trunk@36742 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-26 21:57:26 +00:00
Boone Gorges 3d8cade8c8 Tests: Don't modify global state before checking whether to skip `get_locale()` tests.
Introduced in [36740].

Props ocean90.
See #35965.

git-svn-id: https://develop.svn.wordpress.org/trunk@36741 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-26 20:28:07 +00:00
Boone Gorges da128bc5e3 Add tests for `get_locale()`.
Props realloc.
Fixes #35965.

git-svn-id: https://develop.svn.wordpress.org/trunk@36740 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-26 20:21:11 +00:00
Drew Jaynes f9d01cc7de Docs: Fix two typos in return descriptions for `WP_Theme` private `usort()` methods.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36739 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-26 17:22:30 +00:00
Drew Jaynes 9c0f474a5b Docs: Add missing parameter and return notations in the DocBlock for `WP_Theme::_name_sort_i18n()`, a private `usort()` helper.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36738 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-26 17:20:59 +00:00
Drew Jaynes 135ec99ab5 Docs: Add missing parameter and return notations in the DocBlock for `WP_Theme::_name_sort()`, a private `usort()` helper.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36737 602fd350-edb4-49c9-b593-d223f7449a82
2016-02-26 17:18:52 +00:00