Commit Graph

33897 Commits

Author SHA1 Message Date
Boone Gorges 0fdf0d4566 Improve error handling in `get_categories()`.
When passed an invalid `'taxonomy'`, `get_terms()` will return a `WP_Error`
object. This object should not be blindly cast to an array. Instead, an empty
array should be returned, to indicate that no matching terms have been found.

Props virgodesign, sebastian.pisula.
Fixes #36227.

git-svn-id: https://develop.svn.wordpress.org/trunk@36988 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-14 13:52:14 +00:00
Sergey Biryukov f653932157 Media: Fix typo introduced in [36887].
Props claudiosanches.
Fixes #36230. See #36089.

git-svn-id: https://develop.svn.wordpress.org/trunk@36987 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-14 08:59:49 +00:00
Boone Gorges 8b564b6106 Fix test related to cap check in `get_edit_term_link()`.
The test was introduced in [36646] was intended to demonstrate that the cap
check in `get_edit_term_link()` uses the custom capability from the correct
taxonomy when `$taxonomy` is not specified but must be inferred from the
provided term. However, the test was wrongly written in pretty much every way.
Antiprops boonebgorges.

Props swissspidy.
See #35922.

git-svn-id: https://develop.svn.wordpress.org/trunk@36986 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-14 01:51:12 +00:00
Andrew Ozz 289e9473df TinyMCE, inline link:
- Remove unused user setting for wpLink.
- Remove redundant text and variable from wp_link_dialog().

Props afercia, azaozz.
See #33301.

git-svn-id: https://develop.svn.wordpress.org/trunk@36985 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-14 01:38:09 +00:00
Andrew Ozz bdbd792bfe TinyMCE, inline link:
- Add audible confirmation when a link has been selected or inserted in the editor for both the inline dialog and the modal.
- Do not auto-search when the URL field is empty or already contains an URL.
- Remove a few redundant `tabindex`.

Props afercia, azaozz.
See #33301.

git-svn-id: https://develop.svn.wordpress.org/trunk@36984 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-14 00:52:20 +00:00
Andrew Ozz 8f8b1001ad TinyMCE: when dragging, prevent error when a range cannot be created at the drop location.
Fixes #36229.

git-svn-id: https://develop.svn.wordpress.org/trunk@36983 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-13 22:55:01 +00:00
Andrew Ozz 4fcb429575 TinyMCE, inline link: when doing undo/redo with keyboard shortcut, do not focus the inline dialog. Cannot do consecutive undo/redo if the focus is moved away from the editor.
See #33301.

git-svn-id: https://develop.svn.wordpress.org/trunk@36982 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-13 22:43:10 +00:00
Andrew Ozz 98c197f09f Fix typo in wp-emoji.js.
See #35977.

git-svn-id: https://develop.svn.wordpress.org/trunk@36981 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-13 20:29:45 +00:00
Aaron Jorbin a637421857 Revert r36978
grunt-postcss Dropped nodejs 0.10 support and this is causing builds to fail.  Revert until we bump minimum node version. 

See #35104


git-svn-id: https://develop.svn.wordpress.org/trunk@36980 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-13 19:19:44 +00:00
Aaron Jorbin 76c2c7a982 Update grunt-browserify ~4.0.1 → ~5.0.0
Updates underlying broweserify library to 13.0.0

See #35104



git-svn-id: https://develop.svn.wordpress.org/trunk@36979 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-13 19:02:47 +00:00
Aaron Jorbin b06b9e5713 Update grunt-postcss ~0.7.1 → ~0.8.0
See #35104


git-svn-id: https://develop.svn.wordpress.org/trunk@36978 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-13 18:36:27 +00:00
Andrew Ozz 7a62a64686 TinyMCE, inline link: ensure the inline dialog is in preview mode after updating a link from the (advanced) modal.
Props afercia.
See #33301.

git-svn-id: https://develop.svn.wordpress.org/trunk@36977 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-13 17:46:59 +00:00
Andrew Ozz c60cf303dc TinyMCE: tweak the small animation shown while waiting for wpView data to make it sell CPU intensive.
Props programmin.
Fixes #33525.

git-svn-id: https://develop.svn.wordpress.org/trunk@36976 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-13 17:01:19 +00:00
Sergey Biryukov efeff26a67 Docs: Update default `$size` value for `get_custom_logo` filter after [36950].
Props wido.
See #33755.

git-svn-id: https://develop.svn.wordpress.org/trunk@36975 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-13 09:13:50 +00:00
Andrew Ozz 2a30146900 TinyMCE, inline link: when searching, do not empty the URL input field when using the arrow keys to highlight items.
Props afercia.
See #33301.

git-svn-id: https://develop.svn.wordpress.org/trunk@36974 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-12 19:41:00 +00:00
Eric Andrew Lewis 7552b192a8 Editor: Fix Mac keyboard shortcut for distraction free writing.
Fixes #36214.


git-svn-id: https://develop.svn.wordpress.org/trunk@36973 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-12 17:43:33 +00:00
Andrew Ozz b68a4e3da6 Editor: hide the Move to Trash link for auto-drafts until they are auto-saved.
Props iseulde.
Fixes #16116.

git-svn-id: https://develop.svn.wordpress.org/trunk@36972 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-12 17:21:52 +00:00
Andrew Ozz 9d753fbf5a Editor: correct and update the Visual and Text editors description in the screen help.
Props arush, adamsilverstein, azaozz.
Fixes #35479.

git-svn-id: https://develop.svn.wordpress.org/trunk@36971 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-12 16:42:14 +00:00
Dominik Schilling (ocean90) 39ddaa65cc Docs: Correct grammar when referring to "a URL" vs "an URL" in several places.
Fixes #36218.

git-svn-id: https://develop.svn.wordpress.org/trunk@36970 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-12 12:38:48 +00:00
Pascal Birchler 91d4bbd041 Taxonomy: After [36874], rename `$term_id` to `$tag_ID` in `wp-admin/edit-tag-form.php`.
This ensures that no variables changed in the process of introducing `wp-admin/term.php`, improving overall backward compatibility.

Props Chouby for initial patch.
Fixes #34988.

git-svn-id: https://develop.svn.wordpress.org/trunk@36969 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-11 08:51:13 +00:00
Dominik Schilling (ocean90) e20f75533e Media: Merge two error messages and use `sprintf()` for the method names.
See #33642.

git-svn-id: https://develop.svn.wordpress.org/trunk@36968 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-10 23:35:37 +00:00
Andrea Fercia f4ee598def Coding standards after [36510].
git-svn-id: https://develop.svn.wordpress.org/trunk@36967 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-10 23:17:46 +00:00
Drew Jaynes ad5b16cc09 Docs: Improve two 4.5.0 changelog entries added for the `plugins_update_check_locales` and `themes_update_check_locales` filters, introduced in [36630].
See #34937. See #35986.


git-svn-id: https://develop.svn.wordpress.org/trunk@36966 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-10 23:00:50 +00:00
Drew Jaynes deaabdcc28 Docs: Correct a typo in the DocBlock summary for `get_embed_template()`, introduced in [36963].
Props swissspidy.
See #34561, #34278. See #35986.


git-svn-id: https://develop.svn.wordpress.org/trunk@36965 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-10 22:44:15 +00:00
Andrea Fercia 2a2539402f Accessibility: Improve accessibility for the Plugin details modal.
The plugin details modal can be invoked from several screens. There's now a new
`.open-plugin-details-modal` CSS class to be used in combination with the
`.thickbox` CSS class that adds everything needed for accessibility.

- Adds an ARIA role `dialog` and an `aria-label` attribute to the modal
- Adds a `title` attribute to the iframe inside the modal
- Constrains tabbing within the modal
- Restores focus back in a proper place when closing the modal

Also, improves a bit the native Thickbox implementation: it should probably be
replaced with some more modern tool but at least keyboard focus should be moved
inside the modal.

Fixes #33305.

git-svn-id: https://develop.svn.wordpress.org/trunk@36964 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-10 22:36:25 +00:00
Drew Jaynes fd7c2fef96 Docs: Use a third-person singular verb in the summary for `get_embed_template()`, introduced in [36876].
See #34561, #34278. See #35986.


git-svn-id: https://develop.svn.wordpress.org/trunk@36963 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-10 22:08:16 +00:00
Drew Jaynes 32dc4c97e0 Docs: Improve changelog entries added for the `delete_term` and `delete_{$taxonomy}` actions in [36080] and a third entry added for the `clean_term_cache` action in [36399]
See #35213, #35611. See #35986.


git-svn-id: https://develop.svn.wordpress.org/trunk@36962 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-10 22:06:14 +00:00
Drew Jaynes b557ee2d1b Docs: Improve the summary and return description in the DocBlock for `unregister_taxonomy()`, introduced in [36243].
See #35227. See #35986.


git-svn-id: https://develop.svn.wordpress.org/trunk@36961 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-10 22:01:43 +00:00
Drew Jaynes 662a4c1fd8 Docs: Use a third-person singular verb for the DocBlock summary for `remove_permastruct()`, introduced in [36181].
See #35235. See #35986.


git-svn-id: https://develop.svn.wordpress.org/trunk@36960 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-10 21:59:51 +00:00
Andrea Fercia 474c7da237 Accessibility: Improve the color contrast ratio of the expandable panel "handles".
Fixes #35923.

git-svn-id: https://develop.svn.wordpress.org/trunk@36959 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-10 21:44:00 +00:00
Rachel Baker 55cda28b18 Comments: On the Edit Comment screen do not show the permalink for unapproved comments.
Fixes #36161.

git-svn-id: https://develop.svn.wordpress.org/trunk@36958 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-10 21:17:57 +00:00
Tammie 4b898888a6 Twenty Elevent: Captioned image fix for editor
Fixes #33153
Props: @iseulde


git-svn-id: https://develop.svn.wordpress.org/trunk@36957 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-10 21:12:25 +00:00
Tammie e62721d160 Twenty Thirteen: Removes title attribute from footer
Fixes #35843
Props: @davidakennedy


git-svn-id: https://develop.svn.wordpress.org/trunk@36956 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-10 21:06:07 +00:00
ocean90 72f82072d4 Build Tools: Rename the `precommit:core` task to `precommit:base` for clarification.
`precommit:base` runs only the `imagemin:core` task.

Fixes #35557.

git-svn-id: https://develop.svn.wordpress.org/trunk@36955 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-10 20:13:29 +00:00
Dominik Schilling (ocean90) 3046ac771c oEmbed: Extend the provider list to support moments and timelines from Twitter.
Fixes #36197.

git-svn-id: https://develop.svn.wordpress.org/trunk@36954 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-10 20:03:09 +00:00
John Blackbourn d9a7db711e Rewrite Rules: Allow rewrite rules to work in nested WordPress installations on IIS.
Props WiZZarD_
Fixes #35558


git-svn-id: https://develop.svn.wordpress.org/trunk@36953 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-10 20:00:05 +00:00
John Blackbourn 93942d330e Correct a unit test for custom icon functionality.
See #36086


git-svn-id: https://develop.svn.wordpress.org/trunk@36952 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-10 19:58:49 +00:00
John Blackbourn 4db068e862 Embeds: Add support for `dai.ly` embeds over HTTPS.
Fixes #36189


git-svn-id: https://develop.svn.wordpress.org/trunk@36951 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-10 19:48:15 +00:00
Konstantin Obenland cda0901425 Template: Explicitly set `full` as the default custom logo size.
See #33755.


git-svn-id: https://develop.svn.wordpress.org/trunk@36950 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-10 19:02:25 +00:00
Konstantin Obenland 6f69ca857e Tests: Introduce multisite unit tests.
Makes sure custom logo functions work for other sites within a network.
Fixes a bug in `get_custom_logo()` where the correct logo was returned, but
linked to the wrong site.

H/t ocean90.
See #33755, #36086.


git-svn-id: https://develop.svn.wordpress.org/trunk@36949 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-10 18:56:56 +00:00
Konstantin Obenland 827bcc32a8 Customize: Use full URL to image to prevent breakage if moved.
See https://core.trac.wordpress.org/ticket/33755#comment:103
See #33755.



git-svn-id: https://develop.svn.wordpress.org/trunk@36948 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-10 18:52:10 +00:00
Drew Jaynes 8ff9728013 Docs: Improve syntax in the DocBlock for `rest_get_server()`, introduced in [36529].
See #35329. See #35986.


git-svn-id: https://develop.svn.wordpress.org/trunk@36947 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-10 18:48:34 +00:00
Aaron Jorbin 6c3d9fe803 Update Twitter oEmbed URL.
Twitter moved its preferred oEmbed URL for single Tweets from api.twitter.com to publish.twitter.com. They also are deprecating XML responses. 

Props niallkennedy.
Fixes #36197.



git-svn-id: https://develop.svn.wordpress.org/trunk@36946 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-10 18:39:12 +00:00
Drew Jaynes 95a37a1e35 Docs: Improve the DocBlock summary for `wp_queue_posts_for_term_meta_lazyload()`, introduced in [36566].
See #35816. See #35986.


git-svn-id: https://develop.svn.wordpress.org/trunk@36945 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-10 18:28:33 +00:00
Drew Jaynes 2774bb1116 Docs: Improve the accuracy of the return description for `unregister_post_type()`, introduced in [36316].
See #14761. See #35986.


git-svn-id: https://develop.svn.wordpress.org/trunk@36944 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-10 18:24:45 +00:00
Konstantin Obenland 4c0c3f769f Twenty Fifteen: Simplify `twentyfifteen_the_custom_logo()`.
See b72e3d8059
See #35944.


git-svn-id: https://develop.svn.wordpress.org/trunk@36943 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-10 18:20:13 +00:00
Drew Jaynes 08ec976d15 Docs: Use a third-person singular verb for the `get_the_excerpt()` DocBlock summary.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36942 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-10 17:51:42 +00:00
Drew Jaynes cc4e2e3f64 Docs: Improve the DocBlock summary for `wp_metadata_lazyloader()`, introduced in [36566].
See #35816. See #35986.


git-svn-id: https://develop.svn.wordpress.org/trunk@36941 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-10 17:50:01 +00:00
Drew Jaynes 7c7a95cf9f Docs: Improve the usefulness of the DocBlock summary for `get_edit_term_link()`.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36940 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-10 17:47:58 +00:00
Drew Jaynes 606d131f52 Docs: Improve the 4.5.0 changelog entry in the hook doc for the `get_archives_link` filter, introduced in [36418].
See #35573. See #35986.


git-svn-id: https://develop.svn.wordpress.org/trunk@36939 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-10 17:46:44 +00:00