sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
31,737 Commits 2 Branches 473 Tags 137 MiB
106f0b7b7b
Commit Graph

1633 Commits

Author SHA1 Message Date
Scott Taylor
d2bb55ee92 wp-admin/includes/template.php is now a loader for 3 files made via svn cp: 
* `Walker_Category_Checklist` class
* `WP_Internal_Pointers` class
* `template-functions.php`

This is BC for plugins that are loading `wp-admin/includes/template.php` for fun.

See #33413.


git-svn-id: https://develop.svn.wordpress.org/trunk@34241 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 15:34:17 +00:00
Sergey Biryukov
1d4b8ffd1d Docs: Expand the DocBlock for the WP_Theme::get_edit_link() method, introduced in [34084]. 
Fixes #32376.

git-svn-id: https://develop.svn.wordpress.org/trunk@34238 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 15:00:04 +00:00
Drew Jaynes
7682e433fc Docs: Put "it's" in its place (again). 
Props kitchin.
Fixes #33894.


git-svn-id: https://develop.svn.wordpress.org/trunk@34234 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 12:45:51 +00:00
Sergey Biryukov
557d160ca1 Comments: Fix a fatal error in Comments meta box after [34223]. 
Props tyxla.
Fixes #33893. See #33413.

git-svn-id: https://develop.svn.wordpress.org/trunk@34231 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 11:36:35 +00:00
Drew Jaynes
3b3a034c11 Docs: Remove markdown from the DocBlock summary for WP_List_Table::get_primary_column(), introduced in [34166]. 
The PHP inline documentation standards for [https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/php/#summary-formerly-short-description summaries] call for not using an markup or markdown. Also, using the full Class::method() in this context allows for better clarity in what is being referenced.

See #33854. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34229 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 10:50:21 +00:00
Scott Taylor
05cd237d5e Move WP_Post_Comments_List_Table to its own file. 
See #33413.


git-svn-id: https://develop.svn.wordpress.org/trunk@34223 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 06:52:35 +00:00
John Blackbourn
1a352d56f9 Implement wp_login_url() and wp_registration_url() in places where wp-login.php is currently hard-coded. 
See #31495
Props GregLone


git-svn-id: https://develop.svn.wordpress.org/trunk@34213 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 17:10:24 +00:00
wonderboymusic
2a1ee1a235 Don't redirect to the Term list table after submitting the form on the Edit Term page. 
Props chiragswadia, UmeshSingla, rhyswynne, afercia.
Fixes #17455.


git-svn-id: https://develop.svn.wordpress.org/trunk@34202 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 15:58:04 +00:00
John Blackbourn
b8349f8222 Remove outdated references to the preview_post_link filter docs. 
See #24345
Props paulwilde


git-svn-id: https://develop.svn.wordpress.org/trunk@34178 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 10:31:40 +00:00
Scott Taylor
c95d6b3ec8 Use get_attached_file() in attachment_submitbox_metadata(). 
Props kitchin.
Fixes #33386.


git-svn-id: https://develop.svn.wordpress.org/trunk@34171 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 04:17:38 +00:00
Scott Taylor
c0d850878a Create a function, get_preview_post_link(), to DRY the logic for applying the 'preview_post_link' filter to a URL. 
Props TomHarrigan, wonderboymusic.
Fixes #24345.


git-svn-id: https://develop.svn.wordpress.org/trunk@34170 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 04:14:23 +00:00
Scott Taylor
ac610c191b Move WP_Screen to its own file. 
See #33413.


git-svn-id: https://develop.svn.wordpress.org/trunk@34169 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 04:07:14 +00:00
Scott Taylor
26ab36f909 Move the admin Nav Menu Walker subclasses into their own files. Load in nav-menu.php to remain BC. 
See #33413.


git-svn-id: https://develop.svn.wordpress.org/trunk@34168 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 04:01:30 +00:00
Scott Taylor
1a537a4f6d Add a doc block to WP_List_Table::get_primary_column(). 
Fixes #33854.


git-svn-id: https://develop.svn.wordpress.org/trunk@34166 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 03:34:44 +00:00
Scott Taylor
577fea566a Don't ever use the guid value when retrieving URLs for media, use wp_get_attachment_url(). Use get_attached_file() for path to file. 
Fixes #33386.


git-svn-id: https://develop.svn.wordpress.org/trunk@34163 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 02:49:12 +00:00
Scott Taylor
5c85369bb6 In _wp_ajax_delete_comment_response(), read the new 'all' prop returned by get_comment_count() via wp_count_comments() when setting $total. 'all' doesn't include spam in its count. 
Updates unit tests.

Props dipesh.kakadiya.
Fixes #32362.


git-svn-id: https://develop.svn.wordpress.org/trunk@34161 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 01:46:51 +00:00
Nikolay Bachiyski
1541d43033 List tables: escape user e-mails 
Better safe than sorry.


git-svn-id: https://develop.svn.wordpress.org/trunk@34133 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-14 22:32:52 +00:00
Scott Taylor
b42a906512 wp_unspam_comment() can accept a full object instead of comment_ID to reduce cache/db lookups.. 
See #33638.


git-svn-id: https://develop.svn.wordpress.org/trunk@34130 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-14 21:46:40 +00:00
Scott Taylor
166ee8674b More comment functions can accept a full object instead of comment_ID to reduce cache/db lookups. 
See ##33638.



git-svn-id: https://develop.svn.wordpress.org/trunk@34129 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-14 21:39:46 +00:00
Scott Taylor
ab7ca361dd In WP_List_Table, make a new public method, ->get_primary_column(), and revert [34101] due to BC issues. 
Fixes #33854.


git-svn-id: https://develop.svn.wordpress.org/trunk@34128 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-14 20:28:29 +00:00
Scott Taylor
ea610e66d4 In WP_Media_List_Table, fetch all pending comment counts at once, instead of for each row in the loop. 
See #11381.


git-svn-id: https://develop.svn.wordpress.org/trunk@34127 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-14 19:24:59 +00:00
Dominik Schilling (ocean90)
08098026ce Passwords: Deprecate second parameter of wp_new_user_notification(). 
The second parameter `$plaintext_pass` was removed in [33023] and restored as `$notify` in [33620] with a different behavior. If you have a plugin overriding `wp_new_user_notification()` which hasn't been updated you would get a notification with your username and the password "both".
To prevent this the second parameter is now deprecated and reintroduced as the third parameter.

Adds unit tests.

Props kraftbj, adamsilverstein, welcher, ocean90.
Fixes #33654.

(Don't ask for new pluggables kthxbye)

git-svn-id: https://develop.svn.wordpress.org/trunk@34116 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-14 12:42:34 +00:00
Scott Taylor
a6a03da7f5 Add an argument to parent_dropdown(), $post, to allow it to be called for an arbitrary post. 
Fixes #23162.


git-svn-id: https://develop.svn.wordpress.org/trunk@34111 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-14 03:19:59 +00:00
Scott Taylor
5a93988ca3 Make WP_List_Table::get_primary_column_name() public in list table classes that have it. 
Fixes #33854.


git-svn-id: https://develop.svn.wordpress.org/trunk@34101 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-14 01:11:44 +00:00
Helen Hou-Sandi
379dd889c1 Comments: Fix inline edit/reply on small screens. 
props ocean90, SergeyBiryukov.
fixes #33596.


git-svn-id: https://develop.svn.wordpress.org/trunk@34094 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-13 12:46:03 +00:00
Weston Ruter
fd1dbfe003 Customize: Remove redundant aria-label attributes. 
Adds an `$options` array argument to `WP_Screen::render_screen_options()` to allow the `div#screen-options-wrap` element to be omitted when `wrap` value is `false`.

Props afercia, westonruter.
Fixes #33182.


git-svn-id: https://develop.svn.wordpress.org/trunk@34093 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-13 06:15:42 +00:00
Scott Taylor
ad20c3db4a WP_Posts_List_Table: there are a cadre of edit.php URLs that are generated by string-building instead of using our handy functions. Create a helper method, ->get_edit_link() that standardizes the generation and escaping of these URLs. 
Props BdN3504 for the initial patch on the ticket.
Fixes #32376.


git-svn-id: https://develop.svn.wordpress.org/trunk@34084 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-12 17:12:25 +00:00
Scott Taylor
faf87c2ca6 After [34076], fix the logic for post_status in months dropdown. 
See #21015.


git-svn-id: https://develop.svn.wordpress.org/trunk@34077 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-12 08:18:18 +00:00
Scott Taylor
927ad00bab List Tables: don't render "extra tablenav" if there are no posts. This includes Bulk Actions, Dates Dropdown, Category Dropdowns, Pagination. 
Also ensure that the Months dropdown, when it is shown, shows months from the proper set of posts.

Props egower, CoenJacobs, MikeHansenMe, mehulkaklotar.
Fixes #33824, #21015, #21856.


git-svn-id: https://develop.svn.wordpress.org/trunk@34076 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-12 08:12:43 +00:00
Scott Taylor
9831fa216c AJAX Reply to Comment: check the edit_comment cap when parent comment will be auto-approved. 
Props rachelbaker.
Fixes #23939.


git-svn-id: https://develop.svn.wordpress.org/trunk@34074 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-12 07:18:36 +00:00
Scott Taylor
6a262bd6ce Quick Edit: fix an ID attribute name collision by renaming one of the author fields author-name. 
Props afercia.
Fixes #33770.


git-svn-id: https://develop.svn.wordpress.org/trunk@34070 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-12 02:34:52 +00:00
Scott Taylor
0f2078bc9e When clicking "Show More Comments" in the Comments meta box on the Edit Post screen, change the click behavior to call a new class method on commentsBox, ->load(), that resets st (cool name) to the number of visible <tr>s before calling ->get(). This will account for spam'd and trash'd comments when returning comments at the proper offset. 
Props utkarshpatel.
Fixes #33829.


git-svn-id: https://develop.svn.wordpress.org/trunk@34069 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-12 02:27:50 +00:00
Scott Taylor
33953cb392 Introduce wp_validate_action( $action = '' ), a helper function that checks $_REQUEST for action and returns it, or empty string if not present. If $action is passed, it checks to make sure they match before returning it, or an empty string. Strings are always returned to avoid returning multiple types. 
Implementing this removes 27 uses of direct superglobal access in the admin.

For more reading:
https://codeclimate.com/github/WordPress/WordPress/wp-admin/edit-comments.php

See #33837.


git-svn-id: https://develop.svn.wordpress.org/trunk@34059 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-11 21:07:45 +00:00
Scott Taylor
9ab431873c After [33961], pass $comment to comment_class() where possible to avoid extra cache/db lookups. 
See #33638.


git-svn-id: https://develop.svn.wordpress.org/trunk@34040 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-11 06:11:35 +00:00
Scott Taylor
4cd30ede79 After [34015], handle orphaned comments in the Dashboard comments widget. Pass full $comment versus just passing the comment ID when possible. 
See #33710.


git-svn-id: https://develop.svn.wordpress.org/trunk@34038 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-11 05:55:27 +00:00
Scott Taylor
3f557063be Create a new file, wp-admin/includes/noop.php, which loads all of the noop functions for load-script|styles.php and is only loaded by those files. DRYs in the process. 
See #33813.


git-svn-id: https://develop.svn.wordpress.org/trunk@34037 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-11 05:03:55 +00:00
Scott Taylor
da65ac0471 Move ad hoc functions from wp-admin/credits.php to wp-admin/includes/credits.php, which is only included by the former. 
See #33813.


git-svn-id: https://develop.svn.wordpress.org/trunk@34036 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-11 04:54:20 +00:00
Boone Gorges
5b9d9c7c07 Require numeric IDs in user deletion functions. 
`wp_delete_user()` and `wpmu_delete_user()` both require an `$id` parameter.
Previously, the functions did not verify that the value passed was, in fact,
a number. As such, passing an object or any other entity that would be cast
to int `1` would result in user 1 being deleted. We fix this by enforcing
the requirement that `$id` be numeric.

Props dipesh.kakadiya, utkarshpatel, juliobox.
Fixes #33800.

git-svn-id: https://develop.svn.wordpress.org/trunk@34034 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-11 02:24:03 +00:00
Gary Pendergast
32b8ff1b14 Schema: Increase the length of wp_options.option_name. 
It's pretty easy to run over the `option_name` length, which causes undefined behaviour when inserting and retrieving options. Increasing the length from `VARCHAR(64)` to `VARCHAR(191)` significantly reduces the risk of this occurring.

Because `option_name` has a `UNIQUE` index, we can only increase it to 191 characters, rather than 255. The index can only use a prefix of 191 characters, so will incorrectly restrict long different strings that have the same prefix, if we make the column longer.

Props scribu, OriginalEXE, khromov, MikeHansenMe, netweb, pento.

Fixes #13310.



git-svn-id: https://develop.svn.wordpress.org/trunk@34030 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-11 01:25:21 +00:00
Scott Taylor
b1a91e4a28 Move network_settings_add_js() from wp-admin/network/settings.php to wp-admin/includes/ms.php. 
See #33813.


git-svn-id: https://develop.svn.wordpress.org/trunk@34026 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 22:23:47 +00:00
Scott Taylor
2fe412793e Move confirm_delete_users() from wp-admin/network/users.php to wp-admin/includes/ms.php. 
See #33813.


git-svn-id: https://develop.svn.wordpress.org/trunk@34025 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 22:22:44 +00:00
Scott Taylor
ea07ff2e63 Create wp-admin/includes/network.php via svn cp and only load it in wp-admin/network.php. Move the functions there. 
See #33813.


git-svn-id: https://develop.svn.wordpress.org/trunk@34023 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 22:00:58 +00:00
Scott Taylor
ab4fcd20d0 Move ad hoc Options functions to wp-admin/includes/options.php: 
* Move `options_discussion_add_js()` from `wp-admin/options-discussion.php`
* Move `options_general_add_js()` from `wp-admin/options-general.php`
* Move `options_permalink_add_js()` from `wp-admin/options-permalink.php`
* Move `options_reading_add_js()` from `wp-admin/options-reading.php`
* Move `options_reading_blog_charset()` from `wp-admin/options-reading.php`

See #33813.


git-svn-id: https://develop.svn.wordpress.org/trunk@34022 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 21:44:29 +00:00
Scott Taylor
96a40d6102 Move 2 ad hoc user admin functions: 
* Move `use_ssl_preference()` from `wp-admin/user-edit.php` to `wp-admin/includes/user.php`.
* Move `admin_created_user_email()` from `wp-admin/user-new.php` to `wp-admin/includes/user.php`.

See #33813.


git-svn-id: https://develop.svn.wordpress.org/trunk@34021 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 21:32:46 +00:00
Scott Taylor
d7670b6a38 Move redirect_post() from wp-admin/post.php to wp-admin/includes/post.php. 
See #33813.


git-svn-id: https://develop.svn.wordpress.org/trunk@34020 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 21:30:24 +00:00
Scott Taylor
037cdcb412 Move comment_footer_die() from wp-admin/comment.php to wp-admin/includes/comment.php. 
See #33813.


git-svn-id: https://develop.svn.wordpress.org/trunk@34019 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 21:28:18 +00:00
Scott Taylor
706cdbc671 Move plugin_sandbox_scrape() from wp-admin/plugins.php to wp-admin/includes/plugin.php. 
See #33813.


git-svn-id: https://develop.svn.wordpress.org/trunk@34018 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 21:23:17 +00:00
Scott Taylor
8af9ff0e56 Move wp_widgets_access_body_class() (a hook callback) from wp-admin/widgets.php to wp-admin/includes/widgets.php. 
See #33813.


git-svn-id: https://develop.svn.wordpress.org/trunk@34017 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 21:21:27 +00:00
Scott Taylor
7bf64e0125 Comments/PHP Notices: check that a parent comment exists before displaying an orphan's link to it in the admin. 
Props rachelbaker.
Fixes #33710.


git-svn-id: https://develop.svn.wordpress.org/trunk@34015 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 20:50:12 +00:00
Scott Taylor
be9cd867df In wp_generate_attachment_metadata(), also pass $metadata to the intermediate_image_sizes_advanced filter. 
Props amereservant, wonderboymusic.
Fixes #23401.


git-svn-id: https://develop.svn.wordpress.org/trunk@34007 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 18:03:20 +00:00
Scott Taylor
09df5b81a1 Add a "View" row action for approved comments on the Dashboard screen, remove the link labeled #. 
Props rachelbaker, zeo.
Fixes #18885. 


git-svn-id: https://develop.svn.wordpress.org/trunk@34006 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 17:48:34 +00:00
Scott Taylor
532baa4c5f In WP_Posts_List_Table::column_date(), the order of status and time should be switched. It doesn't make sense for phrases like "Last Modified" to occur AFTER the date. Should be before. 
Props johnbillion, wonderboymusic.
Fixes #18641. 


git-svn-id: https://develop.svn.wordpress.org/trunk@34005 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 17:42:55 +00:00
Scott Taylor
0a7636cfa3 In wp_media_upload_handler(), replace a lingering instance of media_upload_gallery() with wp_iframe(...) 
Props jeffstieler, antpb.
Fixes #17812. 


git-svn-id: https://develop.svn.wordpress.org/trunk@34003 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 17:23:23 +00:00
Scott Taylor
2deb9565c0 When deleting via User List Table, don't prompt for re-attribution if the user(s) do(es) not have any posts. 
Props rajnikmit, wojtek.szkutnik, benjmay, wonderboymusic.
Fixes #6405. 


git-svn-id: https://develop.svn.wordpress.org/trunk@34000 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 16:46:38 +00:00
Sergey Biryukov
5d8eb77621 Merge two similar strings. 
Props dipesh.kakadiya.
Fixes #33777.

git-svn-id: https://develop.svn.wordpress.org/trunk@33998 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 10:58:58 +00:00
Scott Taylor
a025ce4f12 After the global churn in [33964], also set $post to null at the end of WP_Comments_List_Table::single_row() to ensure that an orphaned comment doesn't inherit the previous row's $post context. 
See #33638.


git-svn-id: https://develop.svn.wordpress.org/trunk@33986 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 03:11:09 +00:00
Scott Taylor
6bc498c0e6 Implement a priority system for Help Tabs to add them at specific positions. 
Adds unit tests.

Props swissspidy.
Fixes #19828.


git-svn-id: https://develop.svn.wordpress.org/trunk@33985 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 01:26:26 +00:00
Scott Taylor
89f4c471fa Add @access docs to class-wp-filesystem-* files. 
Props wenthemes.
Fixes #33725.


git-svn-id: https://develop.svn.wordpress.org/trunk@33984 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 01:20:58 +00:00
Drew Jaynes
81ec5c8e91 Docs: Add a changelog entry to the DocBlock for touch_time() to mention the shift from accessing the global $comment to using get_comment(). 
See #33638.


git-svn-id: https://develop.svn.wordpress.org/trunk@33979 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-09 15:47:43 +00:00
Scott Taylor
d6e73d47e4 Round 2 of: We should use ellipses &hellip; / … instead of three dots/periods ... e.g Loading… not Loading... 
Props yoavf.
Fixes #32875.


git-svn-id: https://develop.svn.wordpress.org/trunk@33970 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-09 04:38:31 +00:00
Scott Taylor
42e8258275 Use get_comment() instead of a global in touch_time(). 
See #33638.


git-svn-id: https://develop.svn.wordpress.org/trunk@33965 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-09 03:04:38 +00:00
Scott Taylor
df637648e2 In WP_Comments_List_Table, favor passing WP_Comment instances instead of $comment_ID to template functions. This allows us to bypass unnecessary cache lookups and simply pass the object through when it is set. 
See #33638.


git-svn-id: https://develop.svn.wordpress.org/trunk@33964 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-09 02:59:54 +00:00
Scott Taylor
38d374ab01 After [33891], get_comment() returns global $comment if no args are passed and the global is set (after setting the default to null here). This allows us to ditch global comment imports. 
See #33638.


git-svn-id: https://develop.svn.wordpress.org/trunk@33963 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-09 02:50:43 +00:00
Scott Taylor
5936394bb6 In WP_User, add @property docs for description, first_name, and last_name. user_firstname and user_lastname only exist for back-compat. 
See #33491.


git-svn-id: https://develop.svn.wordpress.org/trunk@33958 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-09 01:12:41 +00:00
Sergey Biryukov
8f2b90e299 Widgets: Don't display sidebar description container if it's empty. 
Props paulwilde.
Fixes #32448.

git-svn-id: https://develop.svn.wordpress.org/trunk@33934 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-06 07:59:01 +00:00
Sergey Biryukov
3853980a9a Merge two permission error strings. 
Props pavelevap.
Fixes #33745.

git-svn-id: https://develop.svn.wordpress.org/trunk@33933 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-06 06:41:58 +00:00
Sergey Biryukov
5d9dcf3d8a Correct description for version and current_version parameters in wp_check_browser_version() response. 
Props extendwings.
Fixes #33753.

git-svn-id: https://develop.svn.wordpress.org/trunk@33932 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-06 00:16:02 +00:00
Sergey Biryukov
8512ff08c0 Correct the docblock for wp_list_widget_controls(). 
Props swissspidy.
Fixes #33751.

git-svn-id: https://develop.svn.wordpress.org/trunk@33930 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-05 23:37:17 +00:00
Sergey Biryukov
36ed764d60 Fix closing div in wp_print_request_filesystem_credentials_modal(). 
Props trepmal.
Fixes #33737.

git-svn-id: https://develop.svn.wordpress.org/trunk@33908 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-05 15:16:15 +00:00
Boone Gorges
3fba46b557 Allow wp_terms_checklist() to return markup rather than echoing it. 
Props kevinlangleyjr.
Fixes #33720.

git-svn-id: https://develop.svn.wordpress.org/trunk@33904 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-04 21:24:04 +00:00
Scott Taylor
43c8ec5f32 Handle more cases (untrailingslashit, HTTPS urls) for sanitizing an author URL for display in the comments list table. 
Props afercia, mehulkaklotar, swissspidy, johnbillion.
Fixes #33291.


git-svn-id: https://develop.svn.wordpress.org/trunk@33894 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-03 23:22:32 +00:00
Scott Taylor
60ba8b05e4 Introduce WP_Comment class to model/strongly-type rows from the comments database table. Inclusion of this class is a pre-req for some more general comment cleanup and sanity. 
* Takes inspiration from `WP_Post` and adds sanity to comment caching. 
* Clarifies when the current global value for `$comment` is returned. The current implementation in `get_comment()` introduces side effects and an occasion stale global value for `$comment` when comment caches are cleaned.
* Strongly-types `@param` docs
* This class is marked `final` for now

Props wonderboymusic, nacin.

See #32619.


git-svn-id: https://develop.svn.wordpress.org/trunk@33891 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-03 18:16:35 +00:00
Sergey Biryukov
7c32770901 Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/includes/bookmark.php. 
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33682. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33887 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-03 08:58:34 +00:00
John Blackbourn
46c336e78a Introduce wp_removable_query_args(), which returns an array of single-use query variables which can be removed from a URL. 
Also applies the function to the return URL when the Customizer is closed.

Fixes #32692
Props swissspidy, Mte90


git-svn-id: https://develop.svn.wordpress.org/trunk@33849 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-02 11:28:11 +00:00
Jeremy Felt
4d2dbebb35 Multisite: Remove duplicate span element output from row actions 
Fixes #32961.


git-svn-id: https://develop.svn.wordpress.org/trunk@33848 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-01 21:50:33 +00:00
Sergey Biryukov
79907af59c Add 'dashboard_secondary_items' filter for the number of secondary link items in the 'WordPress News' dashboard widget. 
props MikeHansenMe, DrewAPicture.
fixes #31434.

git-svn-id: https://develop.svn.wordpress.org/trunk@33833 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-31 21:56:50 +00:00
SergeyBiryukov
f0ab8b5a06 Add 'update_right_now_text' filter for the text displayed in the 'At a Glance' dashboard widget. 
props obenland.
fixes #33355.

git-svn-id: https://develop.svn.wordpress.org/trunk@33832 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-31 21:44:02 +00:00
Drew Jaynes
f7507e511d Docs: Add a duplicate filter comment to the comment_email filter call in WP_Comments_List_Table, introduced in [33829]. 
See #11566.


git-svn-id: https://develop.svn.wordpress.org/trunk@33830 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-31 21:21:14 +00:00
Scott Taylor
e10c682b83 Remove the hamburger global'ing from [33828]: since no args are passed to comment_author_email_link(), the internals can be simplified and applied inline. 
See #11566. 


git-svn-id: https://develop.svn.wordpress.org/trunk@33829 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-31 21:08:17 +00:00
Scott Taylor
fef8794b2c Fix warnings after [33826]. Only only one function call needs a global $comment, we shall hamburger it. 
See #11566. 


git-svn-id: https://develop.svn.wordpress.org/trunk@33828 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-31 20:58:12 +00:00
Scott Taylor
0f59069a7f WP_Comments_List_Table::single_row() has no reason to set the $comment global. No other methods use it, and we are not in template/loop context. This can mess with the response of get_comment() elsewhere, since get_comment() internally bypasses the cache/db when a global is set. 
See #11566. 


git-svn-id: https://develop.svn.wordpress.org/trunk@33826 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-31 20:41:09 +00:00
Sergey Biryukov
20767f42aa Use wp_html_excerpt() to properly cut comment author URL for display on Comments screen. 
props brettz95, solarissmoke.
fixes #15659.

git-svn-id: https://develop.svn.wordpress.org/trunk@33825 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-31 20:40:28 +00:00
Sergey Biryukov
ff7e86d14c Bump H3 headings to H2 on Themes screen for better accessibility. 
props joehills.
fixes #33560.

git-svn-id: https://develop.svn.wordpress.org/trunk@33820 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-31 03:50:05 +00:00
Scott Taylor
413df72474 Favor using the consistent and agnostic string 'Attach' over 'Attach to a post' in the media list table. 
Props pavelevap.
Fixes #33515.


git-svn-id: https://develop.svn.wordpress.org/trunk@33810 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-30 03:09:25 +00:00
John Blackbourn
a4808224ff Bring network admin user searching to parity with single site user searching by wrapping search terms in asterisks. This means that searches don't require an exact match and therefore significantly reduces friction when searching for users on the network admin screens. 
Fixes #32913


git-svn-id: https://develop.svn.wordpress.org/trunk@33801 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-29 00:18:06 +00:00
Sergey Biryukov
d5dd61424d Network Admin: Hide the bulk actions checkbox for super admins. 
See [25125] for hiding the checkbox for the main site in Sites table.

props bordoni.
fixes #28529.

git-svn-id: https://develop.svn.wordpress.org/trunk@33777 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-28 03:48:47 +00:00
Helen Hou-Sandi
0c19c94561 Drop the hyphen from e-mail and standardize on email. 
The AP Stylebook changed this in 2011, and we're woefully inconsistent, so let's go with the standard.

props morganestes, voldemortensen, niallkennedy (for patching on the previous AP style).
fixes #26156.


git-svn-id: https://develop.svn.wordpress.org/trunk@33774 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-28 03:16:02 +00:00
John Blackbourn
d89398f945 Don't change the View Post button permalink in the sample permalink HTML when updating the slug on a published or future post. 
Fixes #32954
Props boonebgorges, johnbillion


git-svn-id: https://develop.svn.wordpress.org/trunk@33773 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-27 20:56:54 +00:00
Sergey Biryukov
65c07b81c0 Remove wp-includes/comment-functions.php from the $_old_files array. See [33750]. 
props rachelbaker.
fixes #33569.

git-svn-id: https://develop.svn.wordpress.org/trunk@33772 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-27 20:39:58 +00:00
John Blackbourn
0d0a8353f5 Remove error from the query variables when cleaning up a URL in wp_admin_canonical_url(). 
Fixes #32847


git-svn-id: https://develop.svn.wordpress.org/trunk@33770 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-27 17:25:15 +00:00
John Blackbourn
e95ce848f9 Correct the hook docs for the user_profile_update_errors action. 
Fixes #33537
Props yamchhetri


git-svn-id: https://develop.svn.wordpress.org/trunk@33769 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-27 17:15:54 +00:00
Sergey Biryukov
a69c9ff66f Make post meta box toggles accessible. 
props joedolson.
fixes #33544.

git-svn-id: https://develop.svn.wordpress.org/trunk@33762 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-26 15:22:57 +00:00
Scott Taylor
ff7fcf5f04 In WP_Users_List_Table::single_row(), $actions is not always set before being used. 
See #33491.


git-svn-id: https://develop.svn.wordpress.org/trunk@33735 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-25 20:37:50 +00:00
Scott Taylor
3b8c5529cb foreach is a statement, not a function. 
See #33491.


git-svn-id: https://develop.svn.wordpress.org/trunk@33734 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-25 20:27:56 +00:00
Scott Taylor
755d109d10 Instead of [33713], allow WP_Posts_List_Table::get_bulk_actions() to check edit_posts AND delete_posts. 
Props DeBAAT.
Fixes #29789.


git-svn-id: https://develop.svn.wordpress.org/trunk@33733 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-25 20:11:27 +00:00
Drew Jaynes
40ce8c68fe Docs: The type for the $t_time parameter in the post_date_column_time filter docs should be string, not array. 
Props jjeaton
Fixes #33540.


git-svn-id: https://develop.svn.wordpress.org/trunk@33731 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-25 17:14:28 +00:00
Scott Taylor
e1b1541932 Media: 
When inserting an image into a post, the values in `wp.media.controller.Library` should not default to linking the image when no user settings are present.

The default display setting value for `link` is now `none`. User settings persist and will override or confirm this value based on user actions.

Props liljimmi, janhenckens, eherman24, wonderboymusic.
Fixes #31467.


git-svn-id: https://develop.svn.wordpress.org/trunk@33729 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-25 12:12:59 +00:00
Dion Hulse
3b525395cc Term Splitting: Switch to a faster cron unschedule process to benefit sites with thousands of affected jobs. Fix the cron hook name in the failsafe rescheduler. 
Props Otto42, dd32, peterwilsoncc
See #33423


git-svn-id: https://develop.svn.wordpress.org/trunk@33727 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-25 04:31:52 +00:00
Scott Taylor
9596ae0993 Posts List Table: 
Don't show bulk actions if the user can't edit posts.

Props DrewAPicture.
Fixes #29789.


git-svn-id: https://develop.svn.wordpress.org/trunk@33713 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-23 16:27:44 +00:00
Scott Taylor
e4f8047716 In wp_ajax_add_meta(), do not juggle the value of $_POST and alter it directly. This was done so that edit_post() could pull $_POST out of the air by-reference and alter it (equally as bad). edit_post() accepts a $post_data array. Do that instead. 
See #33491.


git-svn-id: https://develop.svn.wordpress.org/trunk@33697 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-21 18:12:56 +00:00
Scott Taylor
ab71eb93b1 When createing "Sample Page" on install, comments should be closed. 
Props macmanx. 
Fixes #33490.


git-svn-id: https://develop.svn.wordpress.org/trunk@33693 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-21 17:41:16 +00:00
Scott Taylor
7dd261ce61 Comment List Tables: 
* Toggle visibility of pending bubble when a comment is dynamically moderated
* Add a CSS class to the pending bubble to hide it / remove to show it

See #11200.


git-svn-id: https://develop.svn.wordpress.org/trunk@33692 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-21 17:25:06 +00:00
Drew Jaynes
e6466911d7 Docs: Add a changelog entry for the $post_type parameter added to the restrict_manage_posts hook in [33644]. 
Props pavelevap
Fixes #17891.


git-svn-id: https://develop.svn.wordpress.org/trunk@33691 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-21 16:11:31 +00:00
Helen Hou-Sandi
961dd71cf3 List tables: Allow filtering of hidden and default hidden columns. 
Similar to `get_hidden_meta_boxes()`, there are now filters named `default_hidden_columns` and `hidden_columns`.

props Compute, MikeHansenMe, chriscct7.
fixes #32499.


git-svn-id: https://develop.svn.wordpress.org/trunk@33689 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-21 15:31:30 +00:00
Dion Hulse
466500743f WP_Filesystem: SSH2 handler: Remove support for is_writable() via SSH, it turns out PHP doesn't verify the writability via SFTP and instead uses a comparison based on the current php system process user instead of the ssh user. 
This fixes the 'The update cannot be installed because we will be unable to copy some files.' error encountered during updates by skipping the write test completely.

Props jobst.
Fixes #33480 for trunk


git-svn-id: https://develop.svn.wordpress.org/trunk@33688 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-21 11:42:04 +00:00
Drew Jaynes
e803952278 Docs: Fix some minor inline documentation syntax issues in the hook docs for the post_edit_category_parent_dropdown_args filter, introduced in [33682]. 
See #32246. See #33026.


git-svn-id: https://develop.svn.wordpress.org/trunk@33686 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-21 04:54:00 +00:00
Drew Jaynes
a65c2e068a Docs: Fix a variety of inline documentation syntax issues and add some strategic spacing. 
Fixes #29086.


git-svn-id: https://develop.svn.wordpress.org/trunk@33685 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-21 04:12:45 +00:00
Drew Jaynes
c53fe2779e Docs: Add missing @access tags to properties and methods in wp-admin/includes/class-wp-upgrader. 
See #29086.


git-svn-id: https://develop.svn.wordpress.org/trunk@33684 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-21 04:04:23 +00:00
Drew Jaynes
3721940e0f Docs: Correct a typo in the summary for the Theme_Upgrader->bulk property. 
Also adds a couple of missing `@access` tags.

Props kraftbj
See #29086.


git-svn-id: https://develop.svn.wordpress.org/trunk@33683 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-21 03:14:35 +00:00
Boone Gorges
57592ef976 Filter the arguments passed to wp_dropdown_categories() in the Categories post edit metabox. 
The new 'post_edit_category_parent_dropdown_args' provides parity with other
places in wp-admin where `wp_dropdown_categories()` args are filtered, such as
'taxonomy_parent_dropdown_args'.

Props theMikeD.
Fixes #33026.

git-svn-id: https://develop.svn.wordpress.org/trunk@33682 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-21 01:27:15 +00:00
Drew Jaynes
b09cedbd11 Docs: Standardize @deprecated tag formatting for deprecated functions in wp-admin/includes/ms-deprecated.php. 
Props Alphawolf for the initial patch
Props DrewAPicture

See #28806.


git-svn-id: https://develop.svn.wordpress.org/trunk@33675 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-20 22:25:41 +00:00
Drew Jaynes
8edff9c979 Docs: Standardize @deprecated tag formatting and add missing DocBlocks to deprecated functions in wp-admin/includes/deprecated.php. 
Opted not to use the multi-function DocBlock syntax in the name of not taking shortcuts in documentation for the sake of brevity.

Props Alphawolf for the initial patch.
See #28806


git-svn-id: https://develop.svn.wordpress.org/trunk@33671 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-20 21:22:26 +00:00
Drew Jaynes
5e6f651daf Docs: Add a missing summary to the DocBlock for wp_media_upload_handler(). 
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@33670 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-20 21:00:42 +00:00
Drew Jaynes
0af6d275b0 Docs: Clarify the different return conditions in the DocBlock for WP_List_Table->handle_row_actions(). 
This clarification follows the introduction of primary columns in 4.3. See #33313.

Props morganestes.
Fixes #33436.


git-svn-id: https://develop.svn.wordpress.org/trunk@33668 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-20 20:21:45 +00:00
Scott Taylor
695560bf58 In WP_Posts_List_Table::inline_edit(), check that $post_formats[0] is an array before traversing. 
Props DrewAPicture.
Fixes #33025.



git-svn-id: https://develop.svn.wordpress.org/trunk@33667 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-20 20:18:35 +00:00
Scott Taylor
98de66207f Custom Post Types: 
* Introduce `is_post_type_viewable( $post_type_object )`
* Separate the HTML bits from the translatable bits in the `post` messages array in `edit-form-advanced.php`
* Don't show certain UI pieces when a post is not viewable on the front end

When a custom post type item is not viewable on the front end, we don't want to show links to View it (on the front end) all over the admin. We also want to hide the Preview link, et al. We also want our admin messages to not contain said links.

Custom post types with `public_queryable` set to `false` are not viewable on the front end. 
`'page'` is viewable on the front end, but `'page'` is a `_builtin` type, and `public_queryable` is set to `false` when it is registered - see `WP::parse_request()` for when `public_queryable` gets used.

This is confusing, but also somewhat straightforward: to determine if a post type is viewable on the front end, we can check one way for `_builtin => true` and another way for `_builtin => false`:

`$post_type->publicly_queryable || ( $post_type->_builtin && $post_type->public )`

If a post type is `publicly_queryable`, it's viewable. If that value is `false`, it is viewable if it's a `_builtin` type that is also `public`.

I am in search of edge cases, so this shall land.

Props wonderboymusic, DrewAPicture.
See #17609.


git-svn-id: https://develop.svn.wordpress.org/trunk@33666 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-20 19:39:57 +00:00
Scott Taylor
28e0ad2de1 Comment List Tables: 
* Ensure that dynamic bubble counts are in sync by `comment_post_ID`
* Scope `:animated` to `#the-comment-list`

See #11200.



git-svn-id: https://develop.svn.wordpress.org/trunk@33662 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-20 16:35:21 +00:00
Scott Taylor
64944b7a87 Comments List Table: 
* In a view that initially has comments, but they get removed due to user actions: show the `No Items` row instead of bombing out and showing nothing (which looks broken)
* To accomplish this, in `WP_Comments_List_Table::display()`: call `->display_rows_or_placeholder()` instead of `->display()`
* Listen for the end of row `.fadeOut()`s if necessary using jQuery Promises

Fixes #11200.


git-svn-id: https://develop.svn.wordpress.org/trunk@33657 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-20 05:53:41 +00:00
Scott Taylor
9b6f5b6270 Comments List Table: 
* Show count next to "Approved"
* Properly increment/decrement counts when row actions are clicked
* In `_wp_ajax_delete_comment_response()`, return the comment's `status` with the `supplemental` data
* Handle counts properly on each scenario of `undo`

See #11200.


git-svn-id: https://develop.svn.wordpress.org/trunk@33655 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-20 02:50:20 +00:00
Dion Hulse
f0ec4d5a7b Upgrades: When upgrading via FTP, use LIST -a to detect if a file exists. 
`LIST` & `NLST` by default on some servers require the `-a` flag to view hidden files (ie. `.maintenance`)
Although we could simply pass the `-a` flag to `NLST`, opting to use `LIST` which we use elsewhere should mean less chance of server incompatibilities.

Props jcroucher.
Fixes #28013.


git-svn-id: https://develop.svn.wordpress.org/trunk@33648 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-19 12:37:56 +00:00
Dion Hulse
63fd3a32dd Term Splitting: Fix a reversal of parameters to wp_schedule_single_event() introduced in [33621]. 
The existing invalid cron entries will not be purged automatically (as the 'timestamp' is never matched) so we do this ourselves.

Props mechter for noticing!
See #30261.
Fixes #33423 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@33646 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-19 11:30:42 +00:00
Dion Hulse
26e7094951 Fix PHP notice after [33492] when updating themes. 
Props bobbingwide.
See #33208.
Fixes #33427.


git-svn-id: https://develop.svn.wordpress.org/trunk@33645 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-19 10:34:51 +00:00
Scott Taylor
5cbc7a706d The 'restrict_manage_posts' hook currently fires on the Post and Media list tables, but is passed zero arguments. Pass $post_type. 
Props sunnyratilal, scribu.
Fixes #17891.


git-svn-id: https://develop.svn.wordpress.org/trunk@33644 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-19 06:22:40 +00:00
Scott Taylor
69338b3fa7 Correct typo in doc block for WP_Filesystem_ftpsockets::rmdir 
Props Toro_Unit.
Fixes #33255.


git-svn-id: https://develop.svn.wordpress.org/trunk@33639 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-18 23:33:00 +00:00
Dominik Schilling (ocean90)
0ec540b946 Pinking shears. 
git-svn-id: https://develop.svn.wordpress.org/trunk@33627 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-17 21:38:24 +00:00
Dominik Schilling (ocean90)
f545d74256 Upgrade: Update $_old_files for 4.3. 
fixes #33394.

git-svn-id: https://develop.svn.wordpress.org/trunk@33626 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-17 20:23:06 +00:00
Helen Hou-Sandi
3b1e1f0376 List tables: Yet more primary column fallbacks. 
Some custom list tables override enough methods for the column definition fallback to never kick in, so let's ensure that toggling columns only applies when a primary column is defined in some way. We also need to show a toggle button when we can when there are no row actions.

props Chouby, obenland, ocean90.
fixes #33313.


git-svn-id: https://develop.svn.wordpress.org/trunk@33623 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-17 15:37:03 +00:00
Boone Gorges
e33ff607e6 Don't run term-splitting routine on new installations. 
Props pento.
Fixes #30261.

git-svn-id: https://develop.svn.wordpress.org/trunk@33621 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-17 14:28:03 +00:00
Konstantin Obenland
e7a203cdf2 Passwords: Restore second parameter for wp_new_user_notification(). 
After [33023] users would always be notified, this restores previous behavior.

Props markjaquith, ocean90.
Fixes #33358.



git-svn-id: https://develop.svn.wordpress.org/trunk@33620 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-17 14:24:43 +00:00
Boone Gorges
f18355e66e Term splitting routine should be run in a separate process, triggered via wp-cron. 
[32814] introduced a routine to split shared terms, which was run during the
regular WP database upgrade. This turned out to be problematic because plugins
are not loaded during the db upgrade (due to `WP_INSTALLING`), with the result
that plugins were not able to hook into the 'split_shared_term' action during
the bulk split. We work around this limitation by moving the term splitting
routine to a separate process, triggered by a wp-cron hook.

Props boonebgorges, Chouby, peterwilsoncc, pento, dd32.
Fixes #30261.

git-svn-id: https://develop.svn.wordpress.org/trunk@33615 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-14 03:58:41 +00:00
Dominik Schilling (ocean90)
23eaa36145 Capabilities: Fall back to the edit_posts capability for orphaned comments. 
Also avoid PHP notices because of orphaned comments in the comments list table.
Includes unit test.

props pento, dd32.
fixes #33154.

git-svn-id: https://develop.svn.wordpress.org/trunk@33614 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-13 22:30:26 +00:00
Andrew Ozz
e509984261 Fix paste typos in upgrade.php. 
Props tellyworth. Fixes #33206.

git-svn-id: https://develop.svn.wordpress.org/trunk@33609 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-11 23:43:29 +00:00
dd32
0c29101892 Function documentation: Fix a broken docbock introduced with [32642]. 
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@33601 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-10 10:49:02 +00:00
Dion Hulse
7ef82c235a Upgrade: Skip the sitecategories table when it doesn't exist (Global Terms is disabled). 
Props nofearinc, obenland, SergeyBiryukov, and pento.
Fixes #33206


git-svn-id: https://develop.svn.wordpress.org/trunk@33597 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-09 02:21:11 +00:00
John Blackbourn
1939742e32 Remove all existing internal feature pointers. 
Fixes #33289
Props obenland, ocean90, SergeyBiryukov


git-svn-id: https://develop.svn.wordpress.org/trunk@33593 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-07 00:58:10 +00:00
Mark Jaquith
3d15757198 Move media hooks out of admin-filters.php as sometimes editors are used on the front end. 
fixes #33257
props wonderboymusic

git-svn-id: https://develop.svn.wordpress.org/trunk@33590 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-06 20:39:35 +00:00
Dominik Schilling (ocean90)
9f3217c8eb Multisite mails: Initialize $current_user before accessing $current_user->user_login. 
props Toro_Unit.
see #31217.
fixes #33254.

git-svn-id: https://develop.svn.wordpress.org/trunk@33569 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-04 11:38:52 +00:00
Dominik Schilling (ocean90)
ad74207fa7 Heartbeat: Ensure post locks are released. 
git-svn-id: https://develop.svn.wordpress.org/trunk@33542 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-03 21:11:35 +00:00
Dominik Schilling (ocean90)
2ebc63579c Fix PHP notice after [33492]. 
props jesin.
see #33178.
fixes #33208.

git-svn-id: https://develop.svn.wordpress.org/trunk@33519 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-30 19:58:43 +00:00
Andrew Ozz
f0935052c2 Press This: properly add Open Sans to the editor, using the mce_css filter. 
See #26072. Fixes #33189.

git-svn-id: https://develop.svn.wordpress.org/trunk@33497 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-29 19:37:06 +00:00
Dominik Schilling (ocean90)
faac72a070 Themes: Remove legacy theme preview. 
The pre-3.4 theme previewer doesn't work when using a static front page.
We kept the old theme preview for no-JS and some browsers that were less capable. But since browsers are doing a better job today we don't need to continue fixing/shipping this legacy code. Bye!

fixes #33178.

git-svn-id: https://develop.svn.wordpress.org/trunk@33492 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-29 18:35:40 +00:00
Helen Hou-Sandi
00baf4adea Comments list table: Display that cute lil comment bubble. 
The comments list table suffers from "wall of text" problems, which the two plain text links compounded.

props obenland. fixes #33149.


git-svn-id: https://develop.svn.wordpress.org/trunk@33490 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-29 18:07:03 +00:00
Dominik Schilling (ocean90)
dec1b4da8b Upgrade: Lowercase the "s" in remove_all_filters(). 
props afragen.
fixes #33173.

git-svn-id: https://develop.svn.wordpress.org/trunk@33487 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-29 14:56:23 +00:00
Mark Jaquith
e43b4db995 Make the "using default password" nag more accurate. 
"Easy to remember" isn't necessarily what we want to encourage.

fixes #33168
props arjunskumar

git-svn-id: https://develop.svn.wordpress.org/trunk@33485 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-29 14:05:59 +00:00
Andrew Ozz
1558be9dfa Fix updating of nonces on the Edit Post screen after the log in expires and the user logs in again. 
Props iseulde, azaozz. Fixes #33098.

git-svn-id: https://develop.svn.wordpress.org/trunk@33468 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-28 22:06:52 +00:00
Mark Jaquith
3f2b0779f5 Don't blindly trust the output of glob() to be an array. 
props kitchin
fixes #33093

git-svn-id: https://develop.svn.wordpress.org/trunk@33447 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-27 18:04:19 +00:00
Konstantin Obenland
cd4811bf66 Site Icon: Minor cleanup for WP_Site_Icon after [33329]. 
git-svn-id: https://develop.svn.wordpress.org/trunk@33446 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-27 16:08:47 +00:00
Sergey Biryukov
0fe4782373 Comment string tweaks: 
* Merge two strings about an invalid comment ID.
* Add missing context to 'Mark as Spam' string.
* Merge two 'In Response To' strings, replace redundant context with a translator comment.

props pavelevap.
fixes #32334.

git-svn-id: https://develop.svn.wordpress.org/trunk@33436 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-26 23:35:47 +00:00
Sergey Biryukov
8e7c0148dc Merge two duplicate strings. 
props pavelevap.
fixes #31730.

git-svn-id: https://develop.svn.wordpress.org/trunk@33433 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-26 23:03:52 +00:00
Sergey Biryukov
b8a5123dc9 Merge similar strings for plugin update permissions. 
props pavelevap.
fixes #32388.

git-svn-id: https://develop.svn.wordpress.org/trunk@33432 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-26 23:00:11 +00:00