Commit Graph

24841 Commits

Author SHA1 Message Date
Scott Taylor
13c1dd0004 get_comment(), wp_get_post_revision(), and get_term() all used to return by reference. Because of this, $null was set to null so the return value would be a variable where applicable. This has not been necessary since [21792], so the $nulls have been removed.
Props toszcze.
Fixes #24768.



git-svn-id: https://develop.svn.wordpress.org/trunk@27057 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-29 06:45:54 +00:00
Scott Taylor
62b57d8899 In wpdb::db_connect(), allow the loading of a custom database error template - this is already allowed in dead_db().
In `dead_db()`, move the call to `wp_load_translations_early()` before the inclusion of the `db-error.php` file to allow translation in both locations before the template is loaded.

Props sbruner, kovshenin.
Fixes #25703.



git-svn-id: https://develop.svn.wordpress.org/trunk@27056 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-29 05:27:24 +00:00
Scott Taylor
99ef83d7aa Add Unit Tests for get_comment_pages_count(). Fix a notice caused when $wp_query->comments is not set in that function.
Props mdbitz, markjaquith.
Fixes #20633.



git-svn-id: https://develop.svn.wordpress.org/trunk@27055 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-29 05:16:58 +00:00
Scott Taylor
1805248438 Ignore .js files in wp-content when running jsvalidate during grunt build. See [26977].
Props TobiasBg.
Fixes #26615.



git-svn-id: https://develop.svn.wordpress.org/trunk@27054 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-29 04:44:31 +00:00
Scott Taylor
e8797a9b15 Update the versions of several devDependencies in package.json. grunt-cssjanus has been updated to 0.2.2, we no longer need the fork. Run npm install to receive updates for node_modules in the project root.
Props yoavf, TobiasBg.
Fixes #26073.



git-svn-id: https://develop.svn.wordpress.org/trunk@27053 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-29 04:42:02 +00:00
Andrew Ozz
5bb6b2ecec TinyMCE: fix Ctrl + s shortcut (trigger autosave), see #24067.
git-svn-id: https://develop.svn.wordpress.org/trunk@27052 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-28 23:28:36 +00:00
Scott Taylor
031414171e For starters, [27050] is rad. This just cleans up some extra new lines that were littered about, updates *some* of the inline docs (needs more), moves wp.media.controller.ImageDetails closer to its parent class, and de-dupes some code in media-template.php.
See #24409.



git-svn-id: https://develop.svn.wordpress.org/trunk@27051 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-28 23:20:04 +00:00
Andrew Ozz
20f89d7c4b Introduce Edit Image (single mode) in the media modal and use it to edit images inserted in the editor. Adds new feature: replace an image in the editor. Props gcorne, see #24409.
git-svn-id: https://develop.svn.wordpress.org/trunk@27050 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-28 21:16:42 +00:00
Drew Jaynes
c712a321ad Inline documentation for hooks in wp-includes/class-http.php.
Props kraftbj for the initial patches. Props kpdesign, DrewAPicture.
Fixes #26049.


git-svn-id: https://develop.svn.wordpress.org/trunk@27049 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-28 08:25:00 +00:00
Drew Jaynes
9224a141f3 Inline documentation for hooks in wp-admin/includes/export.php.
Props cmmarslender, kpdesign.
Fixes #26894.


git-svn-id: https://develop.svn.wordpress.org/trunk@27048 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-28 08:09:13 +00:00
Drew Jaynes
bbc58ef016 Inline documentation for hooks in wp-admin/includes/update-core.php.
Props JoshuaAbenazer, kpdesign.
Fixes #25998.


git-svn-id: https://develop.svn.wordpress.org/trunk@27047 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-28 08:01:36 +00:00
Helen Hou-Sandi
91b0e15ef8 Autocomplete for the new site admin email. Better than trying to remember which email address you used.
fixes #25348.


git-svn-id: https://develop.svn.wordpress.org/trunk@27046 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-27 23:09:08 +00:00
Andrew Nacin
bd9729c22d Add wp_install and wp_upgrade hooks to the respective functions.
props Denis-de-Bernardy.
fixes #25762.


git-svn-id: https://develop.svn.wordpress.org/trunk@27045 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-27 16:31:54 +00:00
Andrew Ozz
ad9f1f3258 TinyMCE: add dashicon for the "wp_page" button, see #24067.
git-svn-id: https://develop.svn.wordpress.org/trunk@27044 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-27 15:05:27 +00:00
Dominik Schilling (ocean90)
ddd5e7a57f Update help content for Dashboard. props kpdesign. fixes #26632.
git-svn-id: https://develop.svn.wordpress.org/trunk@27043 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-27 14:46:36 +00:00
Andrew Nacin
0406e11513 Basic unit tests and additional documentation for wp_strip_all_tags().
props joehoyle.
fixes #25507.


git-svn-id: https://develop.svn.wordpress.org/trunk@27042 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-27 03:15:29 +00:00
Andrew Nacin
c759a54b2c Test framework: Parse CREATE TABLE queries the same way we do DROP TABLE queries.
props soulseekah.
fixes #24800.


git-svn-id: https://develop.svn.wordpress.org/trunk@27041 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-27 03:09:13 +00:00
Andrew Nacin
9b414abc2d Remove duplicated and superceded balance tags unit tests.
props coffee2code.
fixes #26222.


git-svn-id: https://develop.svn.wordpress.org/trunk@27040 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-27 02:57:51 +00:00
Andrew Ozz
141aaa04c5 DFW: remove unused #wp-fullscreen-title-prompt-text selectors. See #24067.
git-svn-id: https://develop.svn.wordpress.org/trunk@27039 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-27 00:38:19 +00:00
Andrew Ozz
70ca581b67 Autosave:
- Move the 'Saving post' and 'Draft saved at...' strings from autosaveL10n to postL10n as they are used only there.
- Use the custom jQuery events 'before-autosave' and 'after-autosave' to show these messages.
- Separate autosave.suspend() for local and server so local autosaves can continue while server autosaves are suspended.
- Remove the recently added autosave.server.disable() and use autosave.server.suspend() instead.
- Bring back .button.disabled, button-primary.disabled and use .disabled to prevent multiple form submissions.
See #25272.


git-svn-id: https://develop.svn.wordpress.org/trunk@27038 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-27 00:27:42 +00:00
Andrew Ozz
fbd895949f Remove one more valign, props neoxx, fixes #22712.
git-svn-id: https://develop.svn.wordpress.org/trunk@27037 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-26 20:37:33 +00:00
Andrew Ozz
88fecbeff9 Remove table cellspacing attribute from the admin, part-props MattyRob, fixes #22086.
git-svn-id: https://develop.svn.wordpress.org/trunk@27036 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-26 20:27:21 +00:00
Andrew Ozz
01faa993ac Fix tabbing order when opening/closing post status and visibility in the Publish postbox and cache some of the jQuery selectors. Part-props atimmer, fixes #25460.
git-svn-id: https://develop.svn.wordpress.org/trunk@27035 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-26 03:06:52 +00:00
Andrew Ozz
2b80ac1778 TinyMCE: do not run preventDefault() on the tab key when Ctrl, Alt or Command key is also pressed. Ctrl + Tab is used to switch between browser tabs. See #24067, fixes #17261.
git-svn-id: https://develop.svn.wordpress.org/trunk@27034 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-26 00:28:49 +00:00
Dominik Schilling (ocean90)
88277b4dba Remove unused code. props nofearinc. fixes #26205.
git-svn-id: https://develop.svn.wordpress.org/trunk@27033 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-26 00:11:18 +00:00
Scott Taylor
a103600054 Add some inline docs to methods in media-models.js - particularly around @param and @returns.
See #26870.



git-svn-id: https://develop.svn.wordpress.org/trunk@27032 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-25 08:55:47 +00:00
Scott Taylor
a386be33d5 Add some JSDoc annotations to media-models.js to disambiguate instance properties and static class properties/methods in the base media Models.
See #26870.



git-svn-id: https://develop.svn.wordpress.org/trunk@27031 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-25 07:38:12 +00:00
Andrew Ozz
be31ef4b65 TinyMCE: fix the compat3x plugin appending 'en.' to button titles. Set charset to UTF-8 in html_entity_decode() for translated strings. See #24067, see #26875.
git-svn-id: https://develop.svn.wordpress.org/trunk@27030 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-25 01:20:04 +00:00
Andrew Ozz
48d24f6bf5 Remove all "valign" attributes from tables in wp-admin, props MikeHansenMe, Marventus. Fixes #22712.
git-svn-id: https://develop.svn.wordpress.org/trunk@27029 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-24 19:05:15 +00:00
Dominik Schilling (ocean90)
07bbb5cd1f Update to jQuery UI 1.10.4. fixes #26884.
git-svn-id: https://develop.svn.wordpress.org/trunk@27028 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-24 17:43:40 +00:00
Dominik Schilling (ocean90)
cad7870533 Update to jQuery 1.11.0. fixes #26926.
git-svn-id: https://develop.svn.wordpress.org/trunk@27027 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-24 17:39:35 +00:00
Andrew Nacin
7bb628ec3b Docs fix: edit_comment_link() doesn't actually return anything.
props Corphi.
fixes #26436.


git-svn-id: https://develop.svn.wordpress.org/trunk@27026 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-24 07:16:37 +00:00
Andrew Nacin
f70f020c54 Properly detect line height of Quick Draft textarea.
props batmoo.
fixes #26915 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@27021 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-23 18:02:06 +00:00
Sergey Biryukov
18da726943 Fix typo in CSS. props ciantic, MikeHansenMe. fixes #26898.
git-svn-id: https://develop.svn.wordpress.org/trunk@27020 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-23 12:21:11 +00:00
Sergey Biryukov
344bcddbf7 Remove byte order mark (BOM) from GetUrlInContent.php. see #26171.
git-svn-id: https://develop.svn.wordpress.org/trunk@27019 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-23 09:49:27 +00:00
Scott Taylor
956aa1c8ab Fix imperceptible whitespace cruff from [27017].
git-svn-id: https://develop.svn.wordpress.org/trunk@27018 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-22 22:34:49 +00:00
Scott Taylor
4725e85857 Fix a bit of whitespace from [27016].
git-svn-id: https://develop.svn.wordpress.org/trunk@27017 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-22 22:33:28 +00:00
Scott Taylor
300cb7451e Let is_attachment() accept an $attachment parameter, similar to is_page() and is_single(). Adds Unit Tests for all 3.
Props alex-ye for the initial patch.
Fixes #24257.



git-svn-id: https://develop.svn.wordpress.org/trunk@27016 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-22 22:30:36 +00:00
Andrew Ozz
b29b5b21e4 Autosave: don't set "submit" buttons to disabled right before submitting the form. They are not sent with the form data, see #25272.
git-svn-id: https://develop.svn.wordpress.org/trunk@27015 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-22 21:25:05 +00:00
Andrew Nacin
b663efb313 Themes screen: Add aria-describedby attributes to provide better information to screen readers.
props joedolson for initial patch.
fixes #26602 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@27012 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-22 20:59:29 +00:00
Andrew Ozz
92d2f34d4f Improve keyboard accessibility for the admin menu when in responsive mode, props SergeyBiryukov, fixes #26639 for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@27011 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-22 20:07:16 +00:00
Andrew Nacin
0b5a18c519 Themes screen: Various IE8 adjustments and fixes.
props morganestes, matveb.
fixes #26541.


git-svn-id: https://develop.svn.wordpress.org/trunk@27007 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-22 18:53:34 +00:00
Matt Thomas
eac3ccc29a Responsive improvements to submenus in the adminbar:
- Remove .ab-sub-wrapper rules in the 782px media query, as they're duplicates of the rules set on line 161.
- Reposition the arrows for submenus at responsive sizes where the menus are taller.
- Set the submenu position to static at smartphone sizes, so it's not positioned outside of its parent (and thus offscreen).

Fixes #26720, props undergroundnetwork, iammattthomas.




git-svn-id: https://develop.svn.wordpress.org/trunk@27006 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-22 18:37:42 +00:00
Scott Taylor
36346f9c51 Add inline docs to each method of the namespaced objects in media-editor.js, explaining what each does. Add inline docs to params as well.
See #26870.



git-svn-id: https://develop.svn.wordpress.org/trunk@27005 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-22 18:37:08 +00:00
Andrew Ozz
5aa4902c7d TinyMCE: fix initializing TinyMCE when the default editor in getUserSetting() is overridden from PHP by using the 'wp_default_editor' filter. See #24067.
git-svn-id: https://develop.svn.wordpress.org/trunk@27004 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-22 18:16:39 +00:00
azaozz
db64b3d951 Autosave: don't disable the buttons on previewing a post, see #25272.
git-svn-id: https://develop.svn.wordpress.org/trunk@27003 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-22 17:57:13 +00:00
wonderboymusic
ba1c9e0c22 Add the @namespace annotation where appropriate in media-editor.js. Also indicate the default value of a few params via the [options={}] syntax.
See #26870.



git-svn-id: https://develop.svn.wordpress.org/trunk@27000 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-22 17:16:56 +00:00
nacin
ce00f36ab7 Dashboard widgets: Don't link to Pages or Posts for Authors or Contributors respectively.
props mattheu.
see #26574 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@26999 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-22 16:51:07 +00:00
Nikolay Bachiyski
46bdc2c312 Excplitcly globalized call to $wp later in wp-settings.php
Props xknown, fixes #26867.


git-svn-id: https://develop.svn.wordpress.org/trunk@26997 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-22 14:47:58 +00:00
Nikolay Bachiyski
5eba2a13d8 Explicitly globalize some missing query globals in wp-settings.php
When WordPress is loaded in a function (e.g. unit tests) the variables initialized at the top level aren't globals, but we expect them to be.

Fixes #26867


git-svn-id: https://develop.svn.wordpress.org/trunk@26996 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-22 08:24:50 +00:00