Scott Taylor
143d248292
In gallery_shortcode()
, when the link
attribute is equal to file
, make sure to pass $attr
as the 6th (!) argument, not 5th, to wp_get_attachment_link()
.
...
Props bradyvercher.
Fixes #27402 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30161 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 21:46:51 +00:00
Scott Taylor
9817ecd92e
Remove failing unit test after [30090].
...
Fixes #30194 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30160 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 21:10:23 +00:00
Scott Taylor
4315c9c5c3
Allow get_pages()
, with child_of
passed to it, to work with interrupted hierarchies.
...
Adds unit test.
Fixes #18962 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30159 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 20:43:55 +00:00
Scott Taylor
59658c6547
All duplicate slugs across different post types.
...
Adds unit test.
Props mboynes, nacin.
Fixes #18962 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30158 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 20:36:23 +00:00
Scott Taylor
03b49d8f88
Check $_current_page
before using it in Walker_Page->start_el()
.
...
Props jeremyfelt.
Fixes #26901 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30157 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 20:28:40 +00:00
Scott Taylor
bdf71f89ad
Display error message when Media Library upload fails.
...
Props gcorne.
Fixes #29891 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30156 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 20:24:13 +00:00
Scott Taylor
c8acddfdc8
Improve some post_status
-related documentation.
...
Props ericlewis.
See #30230 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30155 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 20:19:26 +00:00
Scott Taylor
c171bb4aae
In WP_List_Table
, add a property, $modes
, to allow WP_Media_List_Table
to inherit ->view_switcher()
.
...
See #30224 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30154 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 19:55:26 +00:00
Scott Taylor
f759c23d31
In wp_xmlrpc_server
methods, for comprehensibility:
...
* initialize arrays in loops, instead of overriding an uninitialized array each time
* in `->blogger_getRecentPosts()` and `->mw_getRecentPosts()`, remove the extra loops by only setting one `array`
See #30224 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30153 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 19:44:07 +00:00
Jeremy Felt
db68b57c14
Split tests for is_main_site()
...
Break multiple assertions from one method into multiple methods with one assertion each.
See #30080
git-svn-id: https://develop.svn.wordpress.org/trunk@30152 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 05:17:17 +00:00
Jeremy Felt
d0fa387002
Expand and clarify tests for get_blog_post()
...
Remove unnecessary user factory use. Be explicit about test scenarios.
See #30080
git-svn-id: https://develop.svn.wordpress.org/trunk@30151 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 04:47:00 +00:00
Drew Jaynes (DrewAPicture)
ab0324a729
Fix a couple of spacing and wrapping indents in the WP_Date_Query::__construct()
hash notation.
...
See [30142]. See #28063 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30150 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 04:31:00 +00:00
Drew Jaynes (DrewAPicture)
43b3515501
Relocate hook docs so they directly precede the hook lines moved into foreach statements in [30140].
...
It's necessary for hook docs to directly precede hook lines so the parser can correctly match them up. This change relocates hook docs for `update_{$meta_type}_meta`, `update_postmeta`, `updated_{$meta_type}_meta`, and `updated_postmeta`.
Fixes #11683 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30149 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 04:17:28 +00:00
Boone Gorges
262150a91e
Clean up 'post-thumbnail' theme support unit tests.
...
* Separate into smaller test methods.
* Remove incorrect tests. A number of assertions in the existing test have always incorrectly described the behavior of `current_theme_supports( 'post-thumbnails' )`, but no one ever noticed because the tests had been designed to bail when `_wp_render_title_tag()` did not exist. The failures finally became visible when that function was introduced in [30074].
See #18548 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30148 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 04:00:59 +00:00
Lance Willett
2ade0b964a
Twenty Fourteen: update table styles in editor CSS file for new TinyMCE class names.
...
Props slobodanmanic, fixes #28703 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30147 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 03:46:08 +00:00
Lance Willett
7f5058ac80
Twenty Fourteen: fix keyboard focus on Appearance > Header view.
...
Props florianziegler, fixes #29787 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30146 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 03:43:25 +00:00
Lance Willett
9eb6f6f7fe
Twenty Ten and Eleven: don't display modified excerpt link in wp-admin.
...
Props kraftbj, fixes #30026 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30145 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 03:39:04 +00:00
Boone Gorges
09a1a6f5e6
Improve default argument formatting in WP_Date_Query::__construct()
.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@30144 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 03:28:11 +00:00
Lance Willett
cbe8e288d4
Twenty Fourteen: Make featured content in Customizer contextual to the front page.
...
Props celloexpressions, fixes #29578 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30143 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 03:25:43 +00:00
Boone Gorges
7c64b3b3dd
Introduced dayofweek_iso
time param for WP_Date_Query
.
...
The initial `dayofweek` param sets day 1 to Sunday. This is out of step with
ISO standards, which calls Monday day 1. To maintain backward compatibility
with the existing parameter, we introduce the new `dayofweek_iso` for the
new, more compliant param.
Props mboynes.
Fixes #28063 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30142 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 03:23:15 +00:00
Boone Gorges
d6b7b7aa41
Allow resource_type to be specified in get_ancestors()
.
...
Being explicit about resource type (taxonomy vs post_type) allows for the
proper resolution of conflicts when a taxonomy and post_type share a slug.
Props filosofo.
Fixes #15029 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30141 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 02:57:31 +00:00
Boone Gorges
8dbaaf9927
Pass all updated meta IDs to filters in update_metadata()
.
...
Props wonderboymusic.
Fixes #11683 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30140 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 02:38:19 +00:00
Scott Taylor
17e9c6f403
In wp_xmlrpc_server->pingback_ping()
, remove the internal variable $way
each time it is set and not used.
...
See #30224 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30139 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 01:49:26 +00:00
Scott Taylor
eb05767743
In wp_xmlrpc_server
methods, don't set $blog_id
internally if it is never used, which is almost always. Updates the docs.
...
See #30224 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30138 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 01:43:41 +00:00
Scott Taylor
842d9bc5cf
In wp_xmlrpc_server->_prepare_comment()
, $comment_date
is set internally but never used.
...
See #30224 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30137 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 01:28:18 +00:00
Scott Taylor
334fc5b9f2
In Custom_Image_Header->step_2()
, $type
is set internally but never used.
...
See #30224 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30136 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 01:23:50 +00:00
Scott Taylor
bdf61ef6a0
Fix failing unit tests after [30096]: use assertEqualSets()
.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@30135 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 01:10:39 +00:00
Boone Gorges
086f2b9dbd
Fix database schema update introduced in [30121].
...
The index must be manually dropped before `dbDelta()` can add the new index
without throwing a notice.
Fixes #22023 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30134 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 01:10:04 +00:00
Scott Taylor
ff4f545fc9
[28785] introduced a bug, where encoded query arguments were decoded by parse_str()
inside of wp_parse_str()
but never re-encoded later on.
...
This encodes them, adds unit test.
Props obenland.
Fixes #29636 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30133 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 00:53:26 +00:00
Scott Taylor
ef23aee2a6
Fix unit test for video shortcode after [30082].
...
Fixes #30078 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30132 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 00:48:32 +00:00
Scott Taylor
0ae3ac0c05
Revisions modules should not rely on global settings:
...
* Only pass in global settings on `init`, this allows the classes to be used agnostically elsewhere
* Clean up some erroneous/weird Backbone syntax
Props ericlewis, wonderboymusic.
Fixes #30219 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30131 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 00:38:21 +00:00
Scott Taylor
8d2595d7ff
Set revision.settings
via short-circuit check for window
property: window._wpRevisionsSettings || {}
...
Props ericlewis.
Fixes #30218 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30130 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 00:19:17 +00:00
Scott Taylor
ee56980498
Add a single responsibility function for outputting Revisions JS templates: wp_print_revision_templates()
.
...
Use it in `wp-admin/revision.php`.
Props ericlewis.
Fixes #30220 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30129 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 00:14:45 +00:00
Scott Taylor
c684779022
Allow revision Backbone classes to be used on pages other than revision.php
.
...
Props ericlewis.
Fixes #30221 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30128 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 00:07:34 +00:00
Scott Taylor
55613648fd
Add some JSDoc blocks to revisions.js
.
...
Props ericlewis.
See #30222 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30127 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-31 23:54:50 +00:00
Dominik Schilling (ocean90)
40adc7ae16
Customizer: Improve ColorControl
's wpColorPicker
to update UI based on setting changes.
...
Update Twenty Fifteen's `colorScheme` control to properly interact with the API, using `wp.customize.control()` instead of traversing DOM for other controls' container elements and stop manually updating color control UIs.
props westonruter.
fixes #30031 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30126 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-31 20:44:19 +00:00
Scott Taylor
3aa5dc35f1
JSHint after [30124].
...
git-svn-id: https://develop.svn.wordpress.org/trunk@30125 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-31 20:37:50 +00:00
Scott Taylor
04c3ee3045
JSHint after [30120].
...
git-svn-id: https://develop.svn.wordpress.org/trunk@30124 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-31 20:34:39 +00:00
Dominik Schilling (ocean90)
e871e28c5c
Fix JSHint errors introduced in [30120].
...
see #30193 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30123 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-31 20:27:41 +00:00
Drew Jaynes (DrewAPicture)
7cd15026bd
Correct references of @uses $wpdb
in core documentation to use @global
.
...
See #30191 , [30105].
Fixes #30217 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30122 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-31 17:55:39 +00:00
Boone Gorges
5073448de6
Bump db_version and add upgrade routine for schema change in [30056].
...
Fixes #22023 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30121 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-31 16:02:08 +00:00
Scott Taylor
7f5e8bd7e8
Add verbose docs to media-views.js
.
...
Props ericlewis.
See #30193 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30120 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-31 15:19:58 +00:00
Drew Jaynes (DrewAPicture)
c614b0f91a
Correct two parameter types in the wp_save_post_revision_check_for_changes
hook documentation.
...
Props johnbillion.
Fixes #30185 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30119 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-30 23:49:43 +00:00
Boone Gorges
be87d5daad
Move term_exists()
tests to their own file.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@30118 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-30 18:52:37 +00:00
Sergey Biryukov
f9dc501655
Use correct file name in a hook comment.
...
props wedi.
fixes #30200 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30117 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-30 18:34:03 +00:00
Sergey Biryukov
b2672f5772
Twenty Fifteen: Change version compare string to '4.1-alpha' to avoid an error for alpha and beta testers during development.
...
fixes #30137 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30116 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-30 11:56:03 +00:00
Boone Gorges
9a84da90c3
Unserialize get_metadata()
results when 'key' is omitted.
...
Props mattkeys, nacin.
Fixes #15030 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30115 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-30 10:24:22 +00:00
Jeremy Felt
cdc35000f9
Improve tests for domain_exists()
...
* Split existing tests for `domain_exists()` into many smaller tests.
* Make slightly fewer, more accurate assertions.
* Remove unnecessary site creation via factory.
See #30080
git-svn-id: https://develop.svn.wordpress.org/trunk@30114 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-30 05:43:31 +00:00
Boone Gorges
f59f32104a
Streamline some get_terms()
cache tests.
...
* Split large method into a number of smaller tests.
* Create fewer fixtures.
See #30017 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30113 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-30 04:15:03 +00:00
Boone Gorges
df5e0a00b8
Clean up cache invalidation suspension global in unit tests.
...
This fixes a test that was introduced in [30073] which was polluting later
tests.
See #21760 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30112 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-30 04:14:53 +00:00