The JS implementation had multiple issues and did not work as expected.
This change includes an accessibility enhancement by using `prefers-reduced-motion: reduce` media query property for users that don't want motion effects. For further explanation on this media query, see MDN documentation: https://developer.mozilla.org/en-US/docs/Web/CSS/scroll-behavior#Accessibility_concerns
Props audrasjb, melchoyce, joostdevalk, Anlino, mauteri, sergiomdgomes, littlebigthing, williampatton, netweb, andraganescu, joyously, acosmin, mukesh27, hareesh-pillai.
Merges [46824] to the 5.3 branch.
Fixes#48763, #48551, #48866.
git-svn-id: https://develop.svn.wordpress.org/branches/5.3@46825 602fd350-edb4-49c9-b593-d223f7449a82
This ensures that secondary buttons have an appropriate color contrast in the alternative color schemes.
Props melchoyce, ryelle, audrasjb, ate-up-with-motor, afercia, sabernhardt.
Merges [46815] to the 5.3 branch.
Fixes#48585.
git-svn-id: https://develop.svn.wordpress.org/branches/5.3@46816 602fd350-edb4-49c9-b593-d223f7449a82
The test reports a failure if the default timezone was changed with `date_default_timezone_set()` to anything other than `UTC`.
WordPress historically uses `UTC` as the default timezone for calculating date and time offsets, overriding it is not recommended and can cause widespread and obscure issues.
Props Rarst, Clorith, TimothyBlynJacobs.
Merges [46797] to the 5.3 branch.
Fixes#48692.
git-svn-id: https://develop.svn.wordpress.org/branches/5.3@46798 602fd350-edb4-49c9-b593-d223f7449a82
Overriding default PHP timezone with `date_default_timezone_set()`, while not recommended, should not inadvertently result in changing existing permalinks.
Add a unit test.
Props Rarst, steevithak, archon810, maciejmackowiak, Ov3rfly, Cybr, hometowntrailers, scvleon, miette49.
Merges [46795] to the 5.3 branch.
Fixes#48623.
git-svn-id: https://develop.svn.wordpress.org/branches/5.3@46796 602fd350-edb4-49c9-b593-d223f7449a82
On mobile devices using a webkit browser, the menu and search modals could not be opened due to a `TypeError: document.body is null`. This commit fixes that issue by adding a `touch-enabled` class to the body for browsers that do not support media queries.
Props quicoto, poena, Boga86, acosmin, macmanx, ianbelanger.
Fixes#48601.
git-svn-id: https://develop.svn.wordpress.org/branches/5.3@46787 602fd350-edb4-49c9-b593-d223f7449a82
Addresses a regression in [45926].
Props wpgurudev, aravindajith, anantajitjg, davidbaumwald.
Merges [46782] to the 5.3 branch.
Fixes#48725.
git-svn-id: https://develop.svn.wordpress.org/branches/5.3@46783 602fd350-edb4-49c9-b593-d223f7449a82
Fixes a bug after [45499], where the backbone view element isn't the input field any longer. Also, managing focus programmatically is often an assumption on a specific user flow and should generally be avoided, see #43169.
Props dufresnesteven, afercia.
Merges [46745] to the 5.3 branch.
See #43169.
Fixes#48588.
git-svn-id: https://develop.svn.wordpress.org/branches/5.3@46781 602fd350-edb4-49c9-b593-d223f7449a82
Every time an autoloaded option is updated or deleted, the `alloptions` cache is similarly updated. Due to the race condition, on any autoloaded option being updated, every other autoloaded option had its value set to the value at load time, causing a mismatch between the data in the persistent cache and the database.
This change introduces a `$force_cache` parameter for `wp_load_alloptions()` to force an update of the local `alloptions` cache from the persistent cache when an option is added, updated, or deleted, to minimize the chance of affecting other options.
Props fabifott, rmccue, tollmanz, johnjamesjacoby, spacedmonkey, dd32, jipmoors, tellyworth, jeremyclarke, joehoyle, boonebgorges, danielbachhuber, flixos90, jeichorn, mihdan, Grzegorz.Janoszka, SergeyBiryukov.
Merges [46753] and [46779] to the 5.3 branch.
Fixes#31245.
git-svn-id: https://develop.svn.wordpress.org/branches/5.3@46780 602fd350-edb4-49c9-b593-d223f7449a82
The `aria-pressed` attribute communicates semantically the "active" state of buttons that otherwise only look "active".
Props afercia.
Merges [46748] to the 5.3 branch.
Fixes#48355.
git-svn-id: https://develop.svn.wordpress.org/branches/5.3@46778 602fd350-edb4-49c9-b593-d223f7449a82
The `aria-current` attribute is a simple, effective, way to help assistive technology users orientate themselves within a set of items.
Props mayanksonawat, afercia.
Merges [46746] to the 5.3 branch.
Fixes#48271.
git-svn-id: https://develop.svn.wordpress.org/branches/5.3@46777 602fd350-edb4-49c9-b593-d223f7449a82
Switch descriptions for `wp_credits_section_title()` and `wp_credits_section_list()` to third-person singular verbs, per the documentation standards.
Props hareesh-pillai.
Merges [46738] to the 5.3 branch.
Fixes#48674.
git-svn-id: https://develop.svn.wordpress.org/branches/5.3@46776 602fd350-edb4-49c9-b593-d223f7449a82
With the changes in [45908], `mysql2date()` works correctly for all local time inputs, but should not be used for UTC time inputs.
Add a unit test.
Props Rarst, lisota.
Merges [46756] and [46757] to the 5.3 branch.
Fixes#48675.
git-svn-id: https://develop.svn.wordpress.org/branches/5.3@46774 602fd350-edb4-49c9-b593-d223f7449a82
Add a unit test to ensure the year stays up to date.
Props dkarfa, SergeyBiryukov.
Merges [46719] and [46720] to the 5.3 branch.
Fixes#48566.
git-svn-id: https://develop.svn.wordpress.org/branches/5.3@46721 602fd350-edb4-49c9-b593-d223f7449a82
* Add `.has-background` excluding condition to wide and full group-blocks.
This brings Twenty Twenty in sync with GitHub. For a full list of changes since [46714], see 162edc0...fa8c3fc.
Reviewed by azaozz, SergeyBiryukov.
Props allancole, karmatosed.
See #48110, #48386, #48450, #48505.
Merges [46715] to the 5.3 branch.
Fixes#48557.
git-svn-id: https://develop.svn.wordpress.org/branches/5.3@46716 602fd350-edb4-49c9-b593-d223f7449a82
* Add a11y-friendly default text-colors when selecting a background-color.
* Remove margins for the group block when a background-color is set.
* Excluding pullquote block from width resize rules.
This brings Twenty Twenty in sync with GitHub. For a full list of changes since [46711], see ab5fa23...162edc0.
Reviewed by azaozz, SergeyBiryukov.
Props allancole, karmatosed.
See #48110, #48386, #48450, #48505.
Merges [46713] to the 5.3 branch.
Fixes#48557.
git-svn-id: https://develop.svn.wordpress.org/branches/5.3@46714 602fd350-edb4-49c9-b593-d223f7449a82
This brings Twenty Twenty in sync with GitHub. For a full list of changes since 5.3 RC4, see c267289...ab5fa23.
Reviewed by SergeyBiryukov.
Props williampatton, poena, andersnoren, desrosj, schlessera, leprincenoir, alextran, aristath, b-07, allancole, karmatosed, pierlo, joen, ianbelanger.
See #48110, #48386, #48450, #48505.
Merges [46701], [46702], [46711] to the 5.3 branch.
Fixes#48557.
git-svn-id: https://develop.svn.wordpress.org/branches/5.3@46712 602fd350-edb4-49c9-b593-d223f7449a82
* Remove the SVG from the upper right corner.
* Make sure admin notices that should be hidden stay hidden.
* Address a11y issues with contrast.
* Fix an issue with the active nav tab hover.
* Prevent names on the credits from breaking out of the box.
* Update two strings with a more accurate information.
* Remove extra padding on the Credits tab.
Previously [46556], [46572], [46616].
Reviewed by SergeyBiryukov.
Props ryelle, afercia, audrasjb, francina, mapk, desrosj, YordanSoares, melchoyce, azaozz, johnbillion, davidbaumwald, luminuu, bwmarkle, la-geek, SergeyBiryukov.
Merges [46705] and [46709] to the 5.3 branch.
Fixes#47708.
git-svn-id: https://develop.svn.wordpress.org/branches/5.3@46710 602fd350-edb4-49c9-b593-d223f7449a82
This allows for requests to retry post-processing large images using the `post-process` REST API endpoint to work as expected.
Reviewed by johnbillion, youknowriad, SergeyBiryukov.
Props azaozz, mikeschroder, TimothyBlynJacobs, epiqueras, johnbillion, youknowriad.
Merges [46703] to the 5.3 branch.
Fixes#48542.
git-svn-id: https://develop.svn.wordpress.org/branches/5.3@46704 602fd350-edb4-49c9-b593-d223f7449a82
This change makes several changes to ensure consistency and accuracy for default theme headers:
- Removes `WordPress` from `Requires at least` headers.
- Ensures the `Requires at least` and `Requires PHP` headers are present in every default theme’s `style.css` file.
- Ensures `Tested up to` is present in every `readme.txt` file.
- Removes any headers not processed in both the `style.css` and `readme.txt` files for each theme.
Props Otto42, afragen.
Merges [46676] to the 5.3 branch.
Fixes#48517.
git-svn-id: https://develop.svn.wordpress.org/branches/5.3@46699 602fd350-edb4-49c9-b593-d223f7449a82
This point release does not add any images and only slightly modifies a few images without changing their meanings. Because of this, the same CDN location can be used and has been updated.
Merges [46665] to the 5.3 branch.
Reviewed by desrosj, SergeyBiryukov.
Props matstars, desrosj, Otto42, pento.
Fixes#48293.
git-svn-id: https://develop.svn.wordpress.org/branches/5.3@46667 602fd350-edb4-49c9-b593-d223f7449a82
- Run the `wp_generate_attachment_metadata` filter at the end in `wp_update_image_subsizes()` when new metadata was generated and additional image sub-sizes were created.
- Add another arg in the `wp_generate_attachment_metadata` filter for additional context.
- Fix inline docs and ensure the new image meta is always saved before starting image post-processing.
Props SergeyBiryukov, azaozz.
Merges [46621], [46622], and [46651] to the 5.3 branch.
Fixes#48472.
git-svn-id: https://develop.svn.wordpress.org/branches/5.3@46655 602fd350-edb4-49c9-b593-d223f7449a82
