Commit Graph

29675 Commits

Author SHA1 Message Date
Boone Gorges 1700d2b265 Improve performance of loop detection in `_get_term_children()`.
Using an array keyed by term_id allows us to use `isset()` rather than the
slower `in_array()`. In addition, it lets us avoid the use of `wp_list_pluck()`
on large arrays, and helps us to avoid arrays that are unnecessarily large due
to duplicate entries.

Fixes #32144 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@32326 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-29 12:55:29 +00:00
Sergey Biryukov 51b69b1f7f Fix typo in a comment in `wp_guess_url()`.
props ixkaito.
fixes #32179.

git-svn-id: https://develop.svn.wordpress.org/trunk@32325 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-29 07:18:35 +00:00
Andrew Ozz f31aeb97f1 Emoji: fix loop when replacement images fail to load.
Props iseulde. Fixes #32128 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@32323 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-29 03:19:01 +00:00
Dion Hulse 342989657f When creating a temporary file treat the `/` directory properly, to prevent it ending up in an endless self-calling loop.
Props hnle, taka2. Fixes #32135. See #31811


git-svn-id: https://develop.svn.wordpress.org/trunk@32322 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-29 03:16:06 +00:00
Sergey Biryukov af0315de16 Bundled themes: use SSL WordPress.org URL in `rtl.css`.
see #32083.

git-svn-id: https://develop.svn.wordpress.org/trunk@32315 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-27 18:11:01 +00:00
Lance Willett 0598065cdd Bundled themes: use SSL WordPress.org URLs.
Props SergeyBiryukov, fixes #32083.

git-svn-id: https://develop.svn.wordpress.org/trunk@32314 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-27 17:35:06 +00:00
Gary Pendergast 0b868edb8e When deleting suspicious comments, do so permanently.
git-svn-id: https://develop.svn.wordpress.org/trunk@32310 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-27 16:10:50 +00:00
Gary Pendergast ae1f6413c9 [32308] was for 4.3, not 4.2.1.
git-svn-id: https://develop.svn.wordpress.org/trunk@32309 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-27 16:07:20 +00:00
Gary Pendergast 0224286861 When upgrading to 4.2.1, delete suspicious comments.
git-svn-id: https://develop.svn.wordpress.org/trunk@32308 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-27 16:03:48 +00:00
Gary Pendergast 0152b8f49b In [32299], we should be using `mb_strlen()` for our string size checks.
git-svn-id: https://develop.svn.wordpress.org/trunk@32306 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-27 14:41:48 +00:00
Gary Pendergast 45b0abbef1 WPDB: Sanity check that any strings being stored in the DB are not too long to store correctly.
git-svn-id: https://develop.svn.wordpress.org/trunk@32299 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-27 14:02:45 +00:00
Andrew Nacin ca8d6fb60f Escape the $s global.
fixes #32142.


git-svn-id: https://develop.svn.wordpress.org/trunk@32298 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-27 05:09:24 +00:00
Sergey Biryukov fdd254b5d8 Add missing word to `wp_insert_term()` error strings.
props dipesh.kakadiya.
fixes #32031.

git-svn-id: https://develop.svn.wordpress.org/trunk@32297 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-26 11:49:36 +00:00
Sergey Biryukov 04ef03636e Check if `SCRIPT_DEBUG` is defined before using it in `print_emoji_detection_script()`.
props Craig Ralston.
fixes #32118 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@32296 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-26 10:35:53 +00:00
Andrew Nacin 29718f1c28 Fix keyboard shortcut for save from the visual editor.
props iseulde.
see #32122, for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@32295 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-26 04:50:41 +00:00
Boone Gorges c3ea088948 When priming the cache for taxonomy term nav items, don't fetch term descendants.
Descending the term tree causes unnecessary database queries when priming the
cache for a term with many descendants.

Fixes #31724.

git-svn-id: https://develop.svn.wordpress.org/trunk@32294 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-24 18:57:07 +00:00
Boone Gorges 7add279793 Allow rewrite endpoints to be registered without also registering query vars.
Passing `false` to `add_rewrite_endpoint()` will now allow you to take
advantage of the rewrite API without thereby modifying the way that WP sets up
the main query from the request URI.

This new functionality allows developers to work around certain edge-case bugs,
such as when a proper endpoint request (such as `/test/1/`) would short-
circuit `is_home()` calculation when a static front page is set.

Props mordauk, boonebgorges.
Fixes #25143.

git-svn-id: https://develop.svn.wordpress.org/trunk@32293 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-24 16:37:12 +00:00
Boone Gorges 000f4f98b4 In `wp_list_categories()`, 'All' link should point to post type archive if taxonomy is not registered for 'post' or 'page'.
Instead, we point to the post type archive of the first registered
object_type that supports archives.

Props stevegrunwell, hrishiv90, boonebgorges.
Fixes #21881.

git-svn-id: https://develop.svn.wordpress.org/trunk@32292 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-24 14:56:37 +00:00
Helen Hou-Sandi f8140ca961 Trunk is now 4.3-alpha.
git-svn-id: https://develop.svn.wordpress.org/trunk@32280 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-23 17:59:53 +00:00
Helen Hou-Sandi ffe23d2f93 About page: Finalize media for 4.2.
props ocean90, Nao.
fixes #31929.


git-svn-id: https://develop.svn.wordpress.org/trunk@32277 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-23 15:42:24 +00:00
Dominik Schilling (ocean90) 1ebc8a2867 Bundled Themes: Bump version numbers and update POT files.
fixes #32032.

git-svn-id: https://develop.svn.wordpress.org/trunk@32276 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-23 15:15:37 +00:00
Drew Jaynes 387b6a9087 Post 4.2-RC4 bump
git-svn-id: https://develop.svn.wordpress.org/trunk@32271 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-22 20:29:15 +00:00
Drew Jaynes 66b48f847a WordPress 4.2-RC4
git-svn-id: https://develop.svn.wordpress.org/trunk@32270 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-22 20:21:00 +00:00
Helen Hou-Sandi 09f830dca5 Customizer theme details modal: Repair the layout for IE8.
props obenland.
fixes #32066.


git-svn-id: https://develop.svn.wordpress.org/trunk@32269 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-22 18:56:01 +00:00
Helen Hou-Sandi eaba93ed33 Admin menu: prevent (most) lock outs caused by plugins or IE7.
fixes #30900.


git-svn-id: https://develop.svn.wordpress.org/trunk@32268 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-22 18:37:13 +00:00
Dominik Schilling (ocean90) 5e371ea458 Don't try to focus disabled input fields in the request filesystem credentials form.
fixes #32064.

git-svn-id: https://develop.svn.wordpress.org/trunk@32267 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-22 16:56:36 +00:00
Dominik Schilling (ocean90) 2abf4c39ef Don't focus input fields outside of the request filesystem credentials form.
props valendesigns.
fixes #32055.

git-svn-id: https://develop.svn.wordpress.org/trunk@32266 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-22 16:23:57 +00:00
Dominik Schilling (ocean90) f029572866 Theme Switcher: Provide an easier way to reset back to the current active theme.
* Add control for the active theme when doing a theme preview
* Highlight an active theme and move it to the top

props valendesigns, ocean90.
fixes #32002.

git-svn-id: https://develop.svn.wordpress.org/trunk@32265 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-22 16:15:01 +00:00
Dominik Schilling (ocean90) ca11d4c876 Don't return empty themes in `wp_prepare_themes_for_js()`.
see #32002.

git-svn-id: https://develop.svn.wordpress.org/trunk@32264 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-22 16:10:40 +00:00
Gary Pendergast cc8a9824c5 WPDB: When sanity checking a string by sending it to MySQL for conversion checks, the incorrect data structure was being returned from `wpdb::strip_invalid_text()`, causing all write queries to fail for some character sets when the query contained non-ASCII characters.
See #32051.



git-svn-id: https://develop.svn.wordpress.org/trunk@32261 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-22 15:01:25 +00:00
Sergey Biryukov 4e067b0354 About page design for 4.2.
props melchoyce, ryelle.
see #31929.

git-svn-id: https://develop.svn.wordpress.org/trunk@32260 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-22 06:03:03 +00:00
Helen Hou-Sandi 3fb766782d Don't add a class for comment authors who are members of the current site.
Reverts [32245] and [31518]. We'll keep the whitespace and comment clarification, though.

see #24054.


git-svn-id: https://develop.svn.wordpress.org/trunk@32259 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-21 23:35:55 +00:00
Andrew Ozz 925682e2d1 Revert editing of video embed parameters in the media modal, [31620] and [31626] for now. Plan on revisiting in 4.3.
Props iseulde. Fixes #31139, fixes #32006.

git-svn-id: https://develop.svn.wordpress.org/trunk@32258 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-21 22:40:23 +00:00
Andrew Ozz 312edcbc9d TinyMCE wpView: properly deselect views when hiding the editor. Do not remove `selected` on PreProcess.
Fixes #32045.

git-svn-id: https://develop.svn.wordpress.org/trunk@32257 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-21 21:31:26 +00:00
Helen Hou-Sandi 19c0b3f469 Shiny Updates: Prevent the post-update success message from jumping.
props pareshradadiya, afercia.
fixes #31984.


git-svn-id: https://develop.svn.wordpress.org/trunk@32256 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-21 20:40:55 +00:00
Andrew Ozz 89dee9f379 TinyMCE wpView: ensure `contentNode` is passed to all callbacks.
Props iseulde. Fixes #31669.

git-svn-id: https://develop.svn.wordpress.org/trunk@32255 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-21 18:35:50 +00:00
Gary Pendergast 7bfffc9b18 Bump version number for nightly builds.
git-svn-id: https://develop.svn.wordpress.org/trunk@32249 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-21 15:24:29 +00:00
Gary Pendergast 48a9127a87 Trunk is now 4.2-RC3.
git-svn-id: https://develop.svn.wordpress.org/trunk@32248 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-21 14:42:12 +00:00
Helen Hou-Sandi 345397aafb Avoid a PHP notice when adding an embed via Insert from URL.
props iseulde.
see #32006, #29476.


git-svn-id: https://develop.svn.wordpress.org/trunk@32247 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-21 14:35:40 +00:00
Helen Hou-Sandi b7d25c00e2 Rename the `pre_wp_prepare_themes_for_js` filter to `pre_prepare_themes_for_js`.
props DrewAPicture.
fixes #31789.


git-svn-id: https://develop.svn.wordpress.org/trunk@32246 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-21 14:22:15 +00:00
Helen Hou-Sandi 10640611f6 Comment: rename the `comment-author-is-site-member` class to `bysiteuser` for consistency.
Final decision on keeping the class yet to be made.

props DrewAPicture.
see #24054.


git-svn-id: https://develop.svn.wordpress.org/trunk@32245 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-21 14:19:58 +00:00
Helen Hou-Sandi 8ae79e3d33 Customizer: Better experience for widget filtering in desktop and iOS Safari.
Previously, the search field did not appear at all in desktop Safari, and the auto-focus keyboard fly-up in iOS rendered widget adding frustrating at best.

props dsmart, ocean90.
fixes #31987.


git-svn-id: https://develop.svn.wordpress.org/trunk@32243 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-21 14:14:27 +00:00
Helen Hou-Sandi 5ff0ea1fcf wpLink: Make the text editor experience the same as in the visual editor.
props azaozz.
fixes #31890.


git-svn-id: https://develop.svn.wordpress.org/trunk@32242 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-21 13:58:09 +00:00
Gary Pendergast afe046a84c WPDB: When deciding if a query needs extra sanity checking based on collation, we can quickly return if the query is entirely ASCII characters.
See #32029.



git-svn-id: https://develop.svn.wordpress.org/trunk@32233 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-21 05:23:44 +00:00
Gary Pendergast 0fe5a64e56 WPDB: When deciding if a query needs extra sanity checking based on collation, we can quickly return if it's a query that will never return user data.
Fixes #32029.



git-svn-id: https://develop.svn.wordpress.org/trunk@32232 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-21 05:10:11 +00:00
Andrew Ozz 9a4b6405bc Twenty Fifteen: remove `a img { display: block; }` from editor-style.css. Matches previous changes to style.css and fixes extra space when displaying captions in Firefox.
Fixes #32007.

git-svn-id: https://develop.svn.wordpress.org/trunk@32231 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-20 23:46:02 +00:00
Helen Hou-Sandi 38ee7ae7eb Press This: Prevent bottom buttons from wrapping on narrow screens.
props Michael Arestad.
fixes #32022.


git-svn-id: https://develop.svn.wordpress.org/trunk@32230 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-20 21:02:07 +00:00
Andrew Ozz 10bf8967d2 TinyMCE: fix creating a preview when pasting an embeddable URL in Firefox.
Part prop iseulde. Fixes #31988.

git-svn-id: https://develop.svn.wordpress.org/trunk@32229 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-20 20:56:10 +00:00
Helen Hou-Sandi f846003ea7 Media: Date filtering does not need to be on for all contexts.
Affected areas include customizer upload controls and video playlist editing.

props ocean90.
fixes #32004.


git-svn-id: https://develop.svn.wordpress.org/trunk@32228 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-20 19:48:08 +00:00
Drew Jaynes e1c4ed6e32 Post 4.2-RC2 bump.
git-svn-id: https://develop.svn.wordpress.org/trunk@32227 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-20 19:43:39 +00:00