Commit Graph

27217 Commits

Author SHA1 Message Date
Scott Taylor
45368dbfaa Video:
* Don't set height on responsive `<div>` when generating markup
* Move some CSS rules from the style tag to `.wp-video`
* Use Video Details view event delegation instead of click events delegated from `<body>`
* Fix some CSS rule collision in the grid modal

See #29110.


git-svn-id: https://develop.svn.wordpress.org/trunk@29456 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-09 19:38:40 +00:00
Drew Jaynes (DrewAPicture)
8feaba4ca2 Clean up some missing @access tags and other tweaks for 4.0.0-functionality docs.
See #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29455 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-09 19:31:35 +00:00
Drew Jaynes (DrewAPicture)
a84d50dfa3 Fix some words that aren't words.
See #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29454 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-09 19:29:37 +00:00
Dominik Schilling (ocean90)
e8e0880851 WP_Plugins_List_Table::bulk_actions() method declaration should match WP_List_Table, see [29440].
props imath.
fixes #29148.

git-svn-id: https://develop.svn.wordpress.org/trunk@29453 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-09 14:45:20 +00:00
Andrew Ozz
c4424ea546 Media at small screens:
- Show the image details/settings as an overlay.
- Better styling for the frame drop-down.
- Remove the multi-select by default on the Insert frame.
See #27423

git-svn-id: https://develop.svn.wordpress.org/trunk@29452 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-09 05:08:16 +00:00
Scott Taylor
af851b9bda Add some docs to Customizer JS.
Props ericlewis.
See #29157.


git-svn-id: https://develop.svn.wordpress.org/trunk@29451 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-08 23:30:30 +00:00
Scott Taylor
0a6221058f Add some docs to Customizer JS.
Props ericlewis.
See #29157.


git-svn-id: https://develop.svn.wordpress.org/trunk@29450 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-08 22:09:46 +00:00
Andrew Ozz
d6d00167a6 TinyMCE: don't access the parent window when opening the (iframe based) Help/Keyboard Shortcuts modal. Fixes #20094.
git-svn-id: https://develop.svn.wordpress.org/trunk@29449 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-08 21:17:15 +00:00
Andrew Ozz
78c928ad44 Editor: use the post_edit_form_tag action to add autocomplete="off" to the whole form on the Add/Edit Post screen in WebKit. Prevents editor problems when the browser's Back button is used. Fixes #28037.
git-svn-id: https://develop.svn.wordpress.org/trunk@29448 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-08 20:53:31 +00:00
Helen Hou-Sandi
d837ad9fa3 Revert [29287] based on design and core team feedback. see #29012.
git-svn-id: https://develop.svn.wordpress.org/trunk@29447 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-08 19:00:28 +00:00
Andrew Ozz
f4e7b2a6ad Media: improve the media modal at small screen sizes and make it usable on phones, first run. Part-props gcorne, see #27423.
git-svn-id: https://develop.svn.wordpress.org/trunk@29446 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-08 03:45:55 +00:00
Andrew Nacin
f1aceb1667 4.0-beta3-29445
git-svn-id: https://develop.svn.wordpress.org/trunk@29445 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-08 01:43:45 +00:00
Scott Taylor
8fad4c957c Media Grid: remove Router code that doesn't actually ever run.
See #29121.


git-svn-id: https://develop.svn.wordpress.org/trunk@29444 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-07 22:36:30 +00:00
Scott Taylor
86034ec04d Media Grid: remove Router code that doesn't actually ever run.
See #29121.


git-svn-id: https://develop.svn.wordpress.org/trunk@29443 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-07 22:32:58 +00:00
wonderboymusic
fa6508e234 wp_dashboard_cached_rss_widget() contained some func_get_args() code that was indescribably weird.
This keeps it weird, but makes sure that `$check_urls` gets passed to the callback.

Props michalzuber, ocean90.
Fixes #28872.


git-svn-id: https://develop.svn.wordpress.org/trunk@29442 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-07 21:46:02 +00:00
Scott Taylor
ec7895af29 After [29360], add rules for <input>s in the scope of .media-sidebar.
Props ocean90.
Fixes #28647.


git-svn-id: https://develop.svn.wordpress.org/trunk@29441 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-07 21:33:33 +00:00
Scott Taylor
9b9b4a82da Mark WP_List_Table::bulk_actions()'s argument $which as optional for BC.
Fixes #29026.


git-svn-id: https://develop.svn.wordpress.org/trunk@29440 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-07 21:30:01 +00:00
Scott Taylor
8a0953d88b JSHint after [29437].
git-svn-id: https://develop.svn.wordpress.org/trunk@29439 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-07 21:20:08 +00:00
Scott Taylor
dc74104c21 Media Grid:
* Use a `media.view.Label` instance in the toolbar for the screen reader text for the "all" dropdown.
* Adjust the spinner's priority.

Fixes #29026.


git-svn-id: https://develop.svn.wordpress.org/trunk@29438 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-07 21:00:45 +00:00
Scott Taylor
7b95dc861b Media Grid: use a media.view.Label instance in the toolbar for the screen reader text for Search.
See #29026.


git-svn-id: https://develop.svn.wordpress.org/trunk@29437 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-07 20:53:03 +00:00
Helen Hou-Sandi
3d4ebded2f Revert styling changes to the Attachment Details modal from [29289]. fixes #28844.
git-svn-id: https://develop.svn.wordpress.org/trunk@29436 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-07 20:31:21 +00:00
Scott Taylor
42c1f07705 Media Grid: add screen reader text in a subview on the toolbar, a media.view.Label instance before media.view.DateFilter.
See #29026.


git-svn-id: https://develop.svn.wordpress.org/trunk@29435 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-07 20:24:25 +00:00
Scott Taylor
b0d1b8b433 Create a new Backbone view, media.view.Label, which can be used as a subview in things like toolbars, which need screen reader text.
Make an initial instance of it for the label for Bulk Actions in Media Grid.

See #29026.


git-svn-id: https://develop.svn.wordpress.org/trunk@29434 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-07 20:08:18 +00:00
Scott Taylor
e0083f398b Add screen reader text to list table date dropdown.
See #29026.


git-svn-id: https://develop.svn.wordpress.org/trunk@29433 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-07 19:43:17 +00:00
Scott Taylor
0653e60a5d Revert [29428] to avoid errors with Add Media for now.
See #29026.


git-svn-id: https://develop.svn.wordpress.org/trunk@29432 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-07 19:39:10 +00:00
Scott Taylor
3aa94852b3 wptexturize: After [28727], leverage RegeEx possessives (++) to improve performance and avoid libpcre segfaults.
Props kovshenin.
Fixes #12690.


git-svn-id: https://develop.svn.wordpress.org/trunk@29431 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-07 19:10:13 +00:00
Scott Taylor
7f000f2fdd Video: use auto instead of actual height for the responsive wrapper in generated markup.
See #29110.


git-svn-id: https://develop.svn.wordpress.org/trunk@29430 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-07 06:19:29 +00:00
wonderboymusic
0b7342e906 MediaElement upgrade: cleanup for generated markup for videos.
See #29110.


git-svn-id: https://develop.svn.wordpress.org/trunk@29429 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-07 05:52:03 +00:00
Scott Taylor
adff7dfb8e Media Grid: add screen reader labels with more context to filters and bulk actions. Ditto for list view.
Props afercia.
Fixes #29026.


git-svn-id: https://develop.svn.wordpress.org/trunk@29428 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-07 05:19:14 +00:00
Scott Taylor
4f3462cc04 Media Grid: remove some unused Trash/Delete handler logic. Rendered useless since [29266] and made official by [29322].
See #28819.


git-svn-id: https://develop.svn.wordpress.org/trunk@29427 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-07 05:02:18 +00:00
Scott Taylor
6e3e7b374b In media.view.AttachmentFilters.All, make uploaded conditional upon media.view.settings.post.id and include a new filter: unattached.
Drop the `mime-types` filter and related class (which was added for Media Grid) and use `all` instead. 

Props ocean90, wonderboymusic.
Fixes #29065.


git-svn-id: https://develop.svn.wordpress.org/trunk@29426 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-07 04:43:36 +00:00
Scott Taylor
310a57d799 Media Grid: reduce the padding for .attachments.
Props ocean90, ryelle.
Fixes #29085.


git-svn-id: https://develop.svn.wordpress.org/trunk@29425 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-07 03:03:28 +00:00
Scott Taylor
277d5a633e After [29201], use aria-label instead of aria-labelledby in WP_Plugin_Install_List_Table::display_rows().
Props nvwd, DrewAPicture.
Fixes #28853.


git-svn-id: https://develop.svn.wordpress.org/trunk@29424 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-07 02:55:18 +00:00
Scott Taylor
67ef6c5e18 WP_List_Table::items should be public, not protected. It is accessed in a subclass directly via wp_ajax_get_comments().
See [28493].
Fixes #29072.


git-svn-id: https://develop.svn.wordpress.org/trunk@29423 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-07 02:50:40 +00:00
Scott Taylor
06eea1b33d After [28883], ensure that priorities have callbacks before returning true in has_filter().
Adds unit tests.

Props boonebgorges.
Fixes #29070.


git-svn-id: https://develop.svn.wordpress.org/trunk@29422 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-07 02:29:15 +00:00
Scott Taylor
e9ba499f23 After [29339] and [29341], add more unit tests and less ambiguous type-checking before bailing in meta-related functions that expect a numeric value for $object_id.
Props SergeyBiryukov.
Fixes #28315.


git-svn-id: https://develop.svn.wordpress.org/trunk@29421 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-06 22:07:42 +00:00
Scott Taylor
5f2fa44dee Media Grid: expose the $.Deffered() object in media.view.AttachmentsBrowser.updateContent() so the grid can call Backbone.history.start() when models actually exist.
This is a lot better then `_.delay( this.pray, 1000 )`, but needs continued study.

See #29052.


git-svn-id: https://develop.svn.wordpress.org/trunk@29420 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-06 21:43:26 +00:00
Scott Taylor
e25dc36c2b Media Grid: after [28996], use the same cover size for audio/video files that images use for thumbnails.
See #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@29416 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-06 19:32:51 +00:00
Scott Taylor
ccaf134b33 Media Grid: display upload errors in a dismissable sidebar.
See #29037.


git-svn-id: https://develop.svn.wordpress.org/trunk@29415 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-06 19:12:41 +00:00
Andrew Nacin
77e8616615 4.0-beta3
git-svn-id: https://develop.svn.wordpress.org/trunk@29414 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-06 18:27:59 +00:00
Andrew Nacin
996208160d Ignore entities in XML-RPC requests.
props mdawaffe, nacin.


git-svn-id: https://develop.svn.wordpress.org/trunk@29404 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-06 17:37:22 +00:00
Scott Taylor
1d1d95f4d5 In media.view.BulkSelectionActionButton.click(), do not assume that delete is the only possible bulk action.
Fixes #29101.


git-svn-id: https://develop.svn.wordpress.org/trunk@29403 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-06 17:23:49 +00:00
Scott Taylor
99a0a62442 Don't show the Featured Image metabox for users with the contributor role. Do enqueue media so that TinyMCE previews work for YouTube embeds, etc.
Props SergeyBiryukov.
Fixes #28327.


git-svn-id: https://develop.svn.wordpress.org/trunk@29402 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-06 17:16:45 +00:00
Scott Taylor
68a82b0932 Use proper non-capturing regex syntax for YouTube in wp_video_shortcode().
Props Fab1en.
See [27063].
Fixes #29119.


git-svn-id: https://develop.svn.wordpress.org/trunk@29401 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-06 17:00:13 +00:00
Andrew Nacin
4984b04b81 Escape late in get_avatar().
git-svn-id: https://develop.svn.wordpress.org/trunk@29397 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-06 07:49:30 +00:00
Andrew Ozz
d74b01a080 Media modal/grid: fix the position of attachment icons, restore the background, fix in ie8. See #27423.
git-svn-id: https://develop.svn.wordpress.org/trunk@29393 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-06 06:28:54 +00:00
Andrew Nacin
b2d8983dcc Constant time for wp_verify_nonce().
git-svn-id: https://develop.svn.wordpress.org/trunk@29382 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-06 05:25:03 +00:00
Sergey Biryukov
31105be6c7 Avoid PHP notices in wp-login.php if password reset cookie is not set.
props mdawaffe.
see #29060.

git-svn-id: https://develop.svn.wordpress.org/trunk@29381 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-06 02:16:51 +00:00
Andrew Ozz
0f01ebb037 TinyMCE: add support for class attribute on the caption shortcode. Part props knutsp, kadamwhite, fixes #28951.
git-svn-id: https://develop.svn.wordpress.org/trunk@29380 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-06 00:57:12 +00:00
Andrew Ozz
281bf20383 Media modal/grid: get the proper .attachment width in arrow navigation. Props avryl, see #27423.
git-svn-id: https://develop.svn.wordpress.org/trunk@29379 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-05 19:36:41 +00:00