Commit Graph

27217 Commits

Author SHA1 Message Date
Scott Taylor
18fb3e9015 Cleanup after [29220]:
* `media.view.Attachment` should not reach outside itself with global jQuery selectors
* `media.view.Attachment.Details` will re-render when `media.view.Attachment`'s single status changes. Add a `ready` callback to apply initial input focus

See #23560.


git-svn-id: https://develop.svn.wordpress.org/trunk@29556 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-20 19:28:11 +00:00
Scott Taylor
66acb3b298 Initial cleanup after [29220]:
* Alter/remove some jQuery global selectors, views should only manage themselves
* Trigger an event for attachments when arrow keys are pressed: `attachment:keydown:arrow`
* `media.view.Attachments` should listen for `attachment:keydown:arrow`
* Favor scoped selectors over globals

See #23560.


git-svn-id: https://develop.svn.wordpress.org/trunk@29555 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-20 19:13:50 +00:00
Scott Taylor
21a7e91fbd wpmu_activate_signup() returns an array or WP_Error. The array keys it returns can be different based on context of $signup. The return value was previously extract()'d, so the value of $blog_id was secretly undefined when being passed to get_blogaddress_by_id() in some cases.
If `$result['blog_id']` is not set, make sure `$url` is set to an empty string so that the proper "activated" message is shown to the user.

Props imath.
See [28373].
Fixes #29191.


git-svn-id: https://develop.svn.wordpress.org/trunk@29554 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-20 17:29:36 +00:00
Dominik Schilling (ocean90)
8e7c9b7d58 Insert Media: Don't select a model if it's already selected.
props avryl, adamsilverstein.
fixes #29152.


git-svn-id: https://develop.svn.wordpress.org/trunk@29553 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-20 17:19:02 +00:00
Scott Taylor
89ed2c4217 Ensure that $wpdb is imported in Tests_MS::_setup_host_request.
Props tellyworth.
Fixes #27884.


git-svn-id: https://develop.svn.wordpress.org/trunk@29552 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-20 17:13:04 +00:00
Scott Taylor
71d018ff0c Media Grid: Cleanup toggling of Next/Previous in Edit modal.
Fixes #29264.


git-svn-id: https://develop.svn.wordpress.org/trunk@29551 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-20 17:10:03 +00:00
Dominik Schilling (ocean90)
7d1d160251 Media: Remove scan for lost attachments.
This hasn't been worked for 4 years.

fixes #29169.


git-svn-id: https://develop.svn.wordpress.org/trunk@29550 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-20 17:08:41 +00:00
Scott Taylor
192cbe0644 wp_update_term() should mimic wp_insert_term() and set a value for $term_group before the alias_of logic runs. This ensures that $term_group exists when compact() is called.
See [28461].
Fixes #29278.


git-svn-id: https://develop.svn.wordpress.org/trunk@29549 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-20 17:03:07 +00:00
Dominik Schilling (ocean90)
523fbc1b21 Media Grid: Don't hide error messages behind the toolbar.
fixes #29141.

git-svn-id: https://develop.svn.wordpress.org/trunk@29548 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-20 16:47:28 +00:00
Dominik Schilling (ocean90)
e703e74b2c Media Library: Set max value of columns to 12.
fixes #29275.

git-svn-id: https://develop.svn.wordpress.org/trunk@29547 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-20 16:16:44 +00:00
Andrew Ozz
50ba21e179 TinyMCE wpView: show an error when no items are found while parsing a audio/video/playlist shortcode. Props avryl, fixes #29114.
git-svn-id: https://develop.svn.wordpress.org/trunk@29546 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-19 23:22:47 +00:00
Andrew Ozz
4c48ecf26d TinyMCE wpView: scale iframes to 100% width and ensure they have transparent background. See #29048.
git-svn-id: https://develop.svn.wordpress.org/trunk@29545 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-19 22:42:26 +00:00
Andrew Ozz
3a6ab09a19 TinyMCE wpView: add sandbox iframe body styling to get proper height when resizing the iframe, fixes #29270.
git-svn-id: https://develop.svn.wordpress.org/trunk@29544 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-19 22:19:32 +00:00
Andrew Ozz
d8fac44995 TinyMCE wpView sandbox iframes:
- Make them transparent.
- Don't load tons of unrelated styles that can break them. This could result in minimal styling mismatch to the front-end, but keeps the views working well and looking good.
Props avryl, fixes #29048.

git-svn-id: https://develop.svn.wordpress.org/trunk@29543 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-19 21:52:19 +00:00
Helen Hou-Sandi
9eaf6cda94 Align and unify (most) modal and customizer icons. fixes #29147.
git-svn-id: https://develop.svn.wordpress.org/trunk@29542 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-19 20:37:46 +00:00
Andrew Ozz
197b2c6cdc TinyMCE: fix the keycode check when removing the Edit/Delete toolbar from images on keydown, see #28705
git-svn-id: https://develop.svn.wordpress.org/trunk@29541 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-19 19:13:08 +00:00
Andrew Ozz
885a072da6 Fix typo in the 'wpeditimage' plugin, see #28705
git-svn-id: https://develop.svn.wordpress.org/trunk@29540 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-19 18:42:56 +00:00
Sergey Biryukov
2441202954 Prevent "Add" button in Tags meta box from wrapping to a new line in ru_RU.
fixes #29265. see #26510.

git-svn-id: https://develop.svn.wordpress.org/trunk@29539 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-19 08:56:58 +00:00
Sergey Biryukov
ace2e0ba1f Correct 'no_found_rows' parameter description.
see #25367.

git-svn-id: https://develop.svn.wordpress.org/trunk@29538 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-19 07:27:51 +00:00
Sergey Biryukov
1422cab58c Don't display an empty "Uploaded To" link in the media modal after [29436].
see #28844.

git-svn-id: https://develop.svn.wordpress.org/trunk@29537 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-19 07:23:46 +00:00
Andrew Ozz
8b1ee8e04b TinyMCE wpView: remove CSS transition for the fake caret. Can have very annoying side effect: the whole page shifts a bit. See #28595.
git-svn-id: https://develop.svn.wordpress.org/trunk@29536 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-19 03:56:53 +00:00
Andrew Ozz
cd048c0154 TinyMCE wpView: ignore more keys when the caret is around a view. Part props avryl, fixes #29115.
git-svn-id: https://develop.svn.wordpress.org/trunk@29535 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-19 03:26:14 +00:00
Dominik Schilling (ocean90)
c6e4597bbf Plugin details: Accessibility improvements
* Focus the close link to transfer focus into the plugin modal.
* Set title attribute on iframe for screereaders.

props jwenerd for initial patch and a11y team for testing.
fixes #28823.

git-svn-id: https://develop.svn.wordpress.org/trunk@29534 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-18 20:01:47 +00:00
Andrew Ozz
1e61bbb8f1 DFW: revert applying the Visual editor body color and background-color for now. Set the color to #333 and the background to transparent. Fixes #28330.
git-svn-id: https://develop.svn.wordpress.org/trunk@29533 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-18 18:22:54 +00:00
Dominik Schilling (ocean90)
7cbb35a84e Media Modal: Restore to the previous filter and search error message.
fixes #28963.

git-svn-id: https://develop.svn.wordpress.org/trunk@29532 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-18 16:27:33 +00:00
Scott Taylor
75f20c3e69 After [29507], move unreachable code from _requery() to Query.get().
git-svn-id: https://develop.svn.wordpress.org/trunk@29531 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-18 04:07:03 +00:00
Scott Taylor
36b5f034ab wpviews: whenever a view is updated or inserted, don't refresh ALL of the views.
Props avryl.
Fixes #28788.


git-svn-id: https://develop.svn.wordpress.org/trunk@29530 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-18 03:58:24 +00:00
Scott Taylor
8691d31bdc Media Modal: don't show the "Edit Image" button for attachments that don't have data.sizes set.
Fixes #28038.


git-svn-id: https://develop.svn.wordpress.org/trunk@29529 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-18 02:41:46 +00:00
Scott Taylor
e67f53149d Media Grid: don't try to display images that don't have data.sizes set. Also, don't show the "Edit Image" button.
Props ocean90.
Fixes #29245.


git-svn-id: https://develop.svn.wordpress.org/trunk@29528 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-18 02:34:03 +00:00
Scott Taylor
87fe6870e0 Media Grid: Don't show attachment details in the "sidebar" for errors.
Props ocean90.
Fixes #29037.


git-svn-id: https://develop.svn.wordpress.org/trunk@29527 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-18 02:25:43 +00:00
Scott Taylor
eaf912ec54 Media Grid: improve the design of upload errors.
Props celloexpressions.
See #29141.


git-svn-id: https://develop.svn.wordpress.org/trunk@29526 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-18 02:21:57 +00:00
Scott Taylor
48d83dcc66 Media Grid: on page load with ?item= in the URL, if the model is not in the library: fetch it. Defer the triggering of edit:attachment until the model has been fetched.
Fixes #29052.


git-svn-id: https://develop.svn.wordpress.org/trunk@29525 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-18 02:13:01 +00:00
Andrew Ozz
27cd1b4f92 Editor scrolling: set max-width: 100% for the text editor clone instead of always resizing it. See #29246.
git-svn-id: https://develop.svn.wordpress.org/trunk@29524 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-18 01:12:31 +00:00
Andrew Ozz
dcba23a58e Editor scrolling:
- Properly handle change of sidebar height when opening, closing or hiding postboxes.
- Add a flag when to start pinning. Set it to few pixels more than the initial editor height.
See #28328

git-svn-id: https://develop.svn.wordpress.org/trunk@29523 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-18 00:34:45 +00:00
Andrew Ozz
53488d1404 Editor scrolling: always resize the text editor clone so it doesn't "push" the parent's width over 100%, fixes #29246.
git-svn-id: https://develop.svn.wordpress.org/trunk@29522 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-17 21:32:10 +00:00
Andrew Ozz
ed01241d4b TinyMCE: fix the edit image and wpview buttons on touch screen PCs, fixes #29235.
git-svn-id: https://develop.svn.wordpress.org/trunk@29521 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-17 20:10:16 +00:00
Dominik Schilling (ocean90)
712b9d0897 Dashicons: Update to the latest dashicons files.
New icons:
* .dashicons-calendar-alt (f508)
* .dashicons-carrot (f511)
* .dashicons-grid-view (f509)
* .dashicons-index-card (f510)

props liljimmi, melchoyce, empireoflight.
see #27844.

git-svn-id: https://develop.svn.wordpress.org/trunk@29520 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-17 15:00:40 +00:00
Dominik Schilling (ocean90)
a6da7fd8f2 Restore focus styles for checkboxes and radio buttons. Broken since [29465].
fixes #28262.

git-svn-id: https://develop.svn.wordpress.org/trunk@29519 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-17 14:18:05 +00:00
Dominik Schilling (ocean90)
7de002f960 Admin Menu: Auto fold the menu at 960px.
This gives us some more room at the post edit screen.

props vinod dalvi for initial patch.
fixes #28592.

git-svn-id: https://develop.svn.wordpress.org/trunk@29518 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-17 14:14:09 +00:00
Dominik Schilling (ocean90)
a1aa297d82 Media Grid: Improve position of fixed toolbar at small-screen sizes.
see #28842.

git-svn-id: https://develop.svn.wordpress.org/trunk@29517 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-17 14:02:16 +00:00
John Blackbourn
6dfb2d6ec5 Avoid a PHP notice if you manually navigate to /wp-admin/install.php?step=2. See #28577.
git-svn-id: https://develop.svn.wordpress.org/trunk@29516 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-17 13:59:10 +00:00
Dominik Schilling (ocean90)
1ba2f5c853 Fix expected value in Tests_Media::test_video_shortcode_body().
Since [29457] the `.wp-video` wrapper for a video has a height set.

fixes #29110.

git-svn-id: https://develop.svn.wordpress.org/trunk@29515 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-17 11:48:03 +00:00
Dominik Schilling (ocean90)
663164eeca Add a label to site language setting.
see #15677.

git-svn-id: https://develop.svn.wordpress.org/trunk@29514 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-17 09:44:18 +00:00
azaozz
652e929bff TinyMCE wpView: add small delay before inserting wpview sandbox iframes into the DOM. Fixes a problem in Firefox that may prevent rendering them. Fixes #29241.
git-svn-id: https://develop.svn.wordpress.org/trunk@29513 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-17 03:42:03 +00:00
Dominik Schilling (ocean90)
3211b09ed4 Use correct form name for translation updates.
props netweb.
fixes #28198.

git-svn-id: https://develop.svn.wordpress.org/trunk@29512 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-16 10:00:00 +00:00
Sergey Biryukov
de313ebf30 * Add span to the list of allowed tags in plugin sections in plugin details modal.
* Don't strip class attribute from div/span tags in plugin sections.

props tellyworth.
see #28884.

git-svn-id: https://develop.svn.wordpress.org/trunk@29511 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-16 03:06:26 +00:00
Dominik Schilling (ocean90)
e22782e068 Plugin details: Use translation functions.
props jesin.
fixes #29220.

git-svn-id: https://develop.svn.wordpress.org/trunk@29510 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-15 20:50:51 +00:00
Dominik Schilling (ocean90)
c4f784ba8e Correct the documentation for the customize_save_* action.
props celloexpressions.
see #29165.

git-svn-id: https://develop.svn.wordpress.org/trunk@29509 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-15 19:48:16 +00:00
Dominik Schilling (ocean90)
4ec10e82c2 Customizer: Increase default priority for a section to 160.
props celloexpressions.
fixes #29172.

git-svn-id: https://develop.svn.wordpress.org/trunk@29508 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-15 19:35:52 +00:00
Scott Taylor
c26ea8e3e5 Media Grid: $.when expects a splat. Disambiguation: change cache to refresh as the arg name for _requery().
See [29490], #29145.


git-svn-id: https://develop.svn.wordpress.org/trunk@29507 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-15 18:59:25 +00:00