Commit Graph

32403 Commits

Author SHA1 Message Date
Drew Jaynes 1a7298861b Comments: Introduce two new filters, `notify_moderator` and `notify_post_author`, both of which make it possible to selectively override site notification email settings for new comments.
The `notify_moderator` filter makes it possible to override the value for the `moderation_notify` option, which controls whether to send new comment emails to "site moderators", that is to say, the owner of the admin email for the site and the post author if they have the ability to modify the comment.

The `notify_post_author` filter likewise makes it possible to override the value for the `comments_notify` option, which controls whether to send new comment emails to the post author. If the post author is the comment author, default behavior is not to send the notification. Note: enabling or disabling notifications via this hook could also affect other recipients added via the 'comment_notification_recipients' filter in `wp_notify_postauthor()`, if hooked.

Passing a falsey value to either of the new filters will prevent notifications from being sent, regardless of their corresponding option values.

Adds tests.

Props coffee2code, adamsilverstein, DrewAPicture.
Fixes #761.


git-svn-id: https://develop.svn.wordpress.org/trunk@35339 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 18:34:06 +00:00
Andrea Fercia ac3edc61fd Press This: Improve the "choose tags" button focus style.
Props adamholisky for the initial patch.

Fixes 34241.

git-svn-id: https://develop.svn.wordpress.org/trunk@35338 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 18:33:46 +00:00
Dominik Schilling (ocean90) 05356ff7dc Options: Hide the week starts on setting for installs that have the default setting already.
The default setting is the value of `$wp_locale->start_of_week` which holds the value per locale, see [35336].

Props swissspidy, ocean90.
Fixes #28344.

git-svn-id: https://develop.svn.wordpress.org/trunk@35337 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 17:38:44 +00:00
Dominik Schilling (ocean90) 597e3630f3 WP Locale: Add a `start_of_week` property to store the start of the week per locale.
Props swissspidy.
See #28344.

git-svn-id: https://develop.svn.wordpress.org/trunk@35336 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 17:27:47 +00:00
Aaron Jorbin 739fc4a8c7 Update grunt-browserify
upstream changes https://github.com/jmreidy/grunt-browserify/compare/v4.0.0...v4.0.1

See #34177


git-svn-id: https://develop.svn.wordpress.org/trunk@35335 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 16:58:37 +00:00
Konstantin Obenland 52204f7b27 Tests: Use most specific function for document titles.
Adds tests specific to `_wp_render_title_tag()`.

See #31078.



git-svn-id: https://develop.svn.wordpress.org/trunk@35334 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 16:54:53 +00:00
Boone Gorges f492a81d70 Prevent non-public taxonomies from registering aquery var.
[34247] made the 'public' paramater of `register_taxonomy()` work by blocking
requests for non-public taxonomy archives during `parse_request()`. Blocking
taxonomy archive requests this late means that it's impossible to register an
independent query var that matches the slug of a non-public taxonomy. By
moving the block to `register_taxonomy()` - not allowing these taxonomies to
register their query vars in the first place - we free up the slug for other
use. In addition, we free up a bit of processing (no need to look for the query
var in `parse_request()` and better parallel the way non-public post types
work. See `register_post_type()`.

Non-public taxonomy archives that are requested using `?taxonomy=tax_name` are
still blocked during `parse_request`. It's only custom query vars -
`?tax_name=term` - that are affected by this change.

Props mboynes.
Fixes #21949.

git-svn-id: https://develop.svn.wordpress.org/trunk@35333 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 16:53:51 +00:00
Aaron Jorbin 8f2e001efe Replace Autoprefixer Core with Autoprefixer
Autoprefixer Core 5.2.1 -> Autoprefixer 6.0.3 https://github.com/postcss/autoprefixer/releases/tag/6.0.0
Package autoprefixer-core is deprecated in favour of autoprefixer as part of the 6.0.0 release:
Packages autoprefixer and autoprefixer-core were merged in 6.0 release.
Autoprefixer 6.0.0 requires PostCSS 5.0.10 or greater
PostCSS 0.5.4 -> 0.6.0 https://github.com/nDmitry/grunt-postcss/compare/v0.5.4...v0.6.0

You will need to update your dev dependencies after this change.

Props netweb
See #34177



git-svn-id: https://develop.svn.wordpress.org/trunk@35332 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 16:47:21 +00:00
Boone Gorges e4b72ad5ca Don't force comment pagination.
[34561] instituted the policy of forcing pagination for comments. This strategy
was intended to avert problems when 'page_comments' is set to 0 - as it is by
default - and the number of comments on a given post rises into the hundreds or
thousands. By forcing pagination in all cases, we ensured that WordPress would
not time out by processing unwieldy numbers of comments on a given pageload.

The strategy proves problematic, however, because comment permalinks are
generated using the page of the comment. Forcing pagination for posts that
were not previously paginated would change the URL of all comments that do not
appear on the default comment page.

This changeset reintroduces the 'page_comments' setting and its corresponding
checkbox on Settings > Discussion. A number of tests, which were written after
[34561], are modified to work now that 'page_comments' will, once again, be
disabled by default.

See #8071.

git-svn-id: https://develop.svn.wordpress.org/trunk@35331 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 16:25:31 +00:00
Helen Hou-Sandi 11bd47beca Media: Update colors to match the times.
This bikeshed is a real nice blue.

props afercia.
fixes #34244. see #34388.


git-svn-id: https://develop.svn.wordpress.org/trunk@35330 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 16:17:58 +00:00
Boone Gorges 75887ec865 Document title tests should expect dynamic blogname.
Fixes #31078.

git-svn-id: https://develop.svn.wordpress.org/trunk@35329 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 16:14:06 +00:00
Drew Jaynes 6c178fd1ab Docs: Add documentation in the form of a hash notation for default arguments accepted by `wp_login_form()`.
Props ramiy for the initial patch.
Fixes #34364.


git-svn-id: https://develop.svn.wordpress.org/trunk@35328 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 15:37:23 +00:00
Helen Hou-Sandi 3d64414d5c `wp_die()`: Update colors and button styling.
see #34388, #31459.


git-svn-id: https://develop.svn.wordpress.org/trunk@35327 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 15:23:01 +00:00
Dominik Schilling (ocean90) 9a1b5f93cd List Tables: Replace the hyphen separator for titles and post/media states with a `—`.
Props McGuive7.
Fixes #23230.

git-svn-id: https://develop.svn.wordpress.org/trunk@35326 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 14:32:02 +00:00
Drew Jaynes a28e35e462 Filesystem: Following the introduction of the `KB|MB|GB|TB_IN_BYTES` constants in [35286], use them in various places in core.
Props sudar.
Fixes #22405.


git-svn-id: https://develop.svn.wordpress.org/trunk@35325 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 14:02:59 +00:00
Drew Jaynes 86794324c7 Docs: Improve the return description in the DocBlock for `rest_send_allow_header()`.
Props danielbachhuber.
Fixes #34374.


git-svn-id: https://develop.svn.wordpress.org/trunk@35324 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 13:47:12 +00:00
Sergey Biryukov bc2a538b1a REST API: Change nonce name to `_wpnonce`.
It's shorter and is compatible with the default name in `wp_nonce_field()`.

Props danielbachhuber.
Fixes #34375.

git-svn-id: https://develop.svn.wordpress.org/trunk@35323 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 08:13:18 +00:00
Sergey Biryukov 5bba750579 Add `get_terms_defaults` filter for the default arguments of `get_terms()`.
Fixes #33369.

git-svn-id: https://develop.svn.wordpress.org/trunk@35322 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 08:07:12 +00:00
Sergey Biryukov f3f2a222b9 Reorder default arguments in `get_terms()` for consistency with the hash notation added in [29128].
See #33369.

git-svn-id: https://develop.svn.wordpress.org/trunk@35321 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 08:00:56 +00:00
Sergey Biryukov 7b81e1e56c Docs: Correct function name in `get_terms_args` parameter description.
See #33369.

git-svn-id: https://develop.svn.wordpress.org/trunk@35320 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 07:41:38 +00:00
Sergey Biryukov 892cef6da5 Docs: Correct duplicate hook reference for `get_terms`.
See #33369.

git-svn-id: https://develop.svn.wordpress.org/trunk@35319 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 07:39:11 +00:00
Andrew Ozz 5bc6ae50ab Precommit cleanup, see r35313.
git-svn-id: https://develop.svn.wordpress.org/trunk@35318 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 05:32:54 +00:00
Andrew Ozz 7ba408c93e Widgets: add a button to delete all inactive widgets simultaneously for better UX.
Props cdog.
Fixes #19159.

git-svn-id: https://develop.svn.wordpress.org/trunk@35317 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 05:22:52 +00:00
Scott Taylor ba1177bf4c Export: add missing labels and improvement accessibility of the Export screen.
Props afercia.
Fixes #33046.


git-svn-id: https://develop.svn.wordpress.org/trunk@35316 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 03:56:22 +00:00
Scott Taylor 6f6c0ebb52 Plugins/Updates: in `request_filesystem_credentials()`, alter the heading HTML tag based on the current screen for improved semantics.
Props afercia.
Fixes #34267.


git-svn-id: https://develop.svn.wordpress.org/trunk@35315 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 03:50:19 +00:00
Scott Taylor 51637379a2 Formatting: move `url_shorten()` from `wp-admin/includes/misc.php` to `wp-includes/formatting.php` for more global access.
Adds unit tests.

Props mulvane, chriscct7.
Fixes #20166.


git-svn-id: https://develop.svn.wordpress.org/trunk@35314 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 03:47:23 +00:00
Scott Taylor be739bd6c0 Administration: the current admin menu item should have an `aria-haspopup` attribute when the menu is folded.
Unify the jQuery selector caching for `window`, `document`, and `body`.

Props afercia.
Fixes #32578.


git-svn-id: https://develop.svn.wordpress.org/trunk@35313 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 03:40:38 +00:00
Scott Taylor e4bcddecfb Site Icon: make the default value for the `site_icon` option `0` in `schema.php`.
Props swissspidy, sebastian.pisula.
Fixes #34339.


git-svn-id: https://develop.svn.wordpress.org/trunk@35312 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 03:27:54 +00:00
Scott Taylor 14893eb628 AJAX UNIT TESTS: Have you ever wondered why these take 600 forevers to run? They all eventually call `do_action( 'admin_init' )`, which has `_maybe_update_core`, `_maybe_update_plugins`, and `_maybe_update_themes` hooked to it. REMOVE THEM, and AJAX unit tests run like the wind. `Tests_Ajax_Response` is still slow.
See #30017, #33968.


git-svn-id: https://develop.svn.wordpress.org/trunk@35311 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 03:17:36 +00:00
Sergey Biryukov 5252cb7fe3 Autoprefixer for [35281].
See #33322.

git-svn-id: https://develop.svn.wordpress.org/trunk@35310 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 03:01:13 +00:00
Scott Taylor f5921a0c98 Unit Tests: consolidate the many separate implementations of `_make_attachment()` into a helper method on `WP_UnitTestCase`.
Fixes #34075.


git-svn-id: https://develop.svn.wordpress.org/trunk@35309 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 01:58:52 +00:00
Weston Ruter ede4050ace Customizer: Prevent `nav_menu_item` settings from becoming dirty when their controls are set up.
Since `wp_setup_nav_menu_item()` returns the `classes` property as an array but the Customizer manages the value as a string, the setting needs to initially export the value as a string. This prevents the `classes` property type change from causing the setting to get marked as dirty even though nothing changed. This is a regression from [34788].

See #34111.


git-svn-id: https://develop.svn.wordpress.org/trunk@35308 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-20 22:44:44 +00:00
Weston Ruter bde89adaf8 Customizer: Introduce `customize_loaded_components` filter to allow core components to be disabled.
Also move style rule from `customize-nav-menus.css` to `customize-controls.css` so that widgets button is properly styled when `nav_menus` component is excluded from loading. See [35304]. See #33327.

Props westonruter, DrewAPicture.
Fixes #33552.


git-svn-id: https://develop.svn.wordpress.org/trunk@35307 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-20 22:15:11 +00:00
Andrew Ozz 73d755b67a TinyMCE: update to 4.2.6. Changelog: http://www.tinymce.com/develop/changelog/?ctrl=version&act=view&pr_id=1&vr_id=887.
Fixes #34331.

git-svn-id: https://develop.svn.wordpress.org/trunk@35306 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-20 22:05:31 +00:00
Weston Ruter 261aa51182 Customizer: Allow new `option` settings to not be saved as autoloaded by passing an `autoload` arg value of `false`.
The `autoload` argument value is passed along to `update_option()` which has accepted an `$autoload` parameter since [31628].

Props westonruter, dlh.
See #26394.
Fixes #33499.


git-svn-id: https://develop.svn.wordpress.org/trunk@35305 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-20 21:18:04 +00:00
Andrea Fercia 8774b40dc8 Customizer: Make the widgets "Reorder" and "Add a Widget" buttons... buttons.
For accessibility, UI controls should preferably be native controls. Adds
ARIA attributes and labels to improve accessibility and pair these buttons
with the ones in the Menu Customizer.

Props obenland, TomHarrigan, sanket.parmar, metodiew, afercia.

Fixes #33327.

git-svn-id: https://develop.svn.wordpress.org/trunk@35304 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-20 20:14:51 +00:00
Drew Jaynes 11f4d7bb68 Docs: Add translator comments for two `_deprecated_argument()` calls added to `get_wp_title_rss()` and `wp_title_rss()` in [35294].
See #31078. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35303 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-20 19:19:37 +00:00
Weston Ruter 9724c7cdbd Customizer: Implement indicators for invalid nav menu items.
The same indicator on the nav menus admin page is now present for nav menu items in the Customizer. When a menu item is present for a post type that is no longer registered, the menu item will appear with the indicator.

Props kucrut, westonruter.
Fixes #33665.


git-svn-id: https://develop.svn.wordpress.org/trunk@35302 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-20 19:07:58 +00:00
Drew Jaynes 1871d57dc5 Docs: Adjust syntax in the hook doc summaries for the `document_title_separator` and `document_title_parts` filters, introduced in [35294].
See #31078. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35301 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-20 18:35:46 +00:00
Drew Jaynes b11b651d24 Docs: Fix indentation and improve usefulness of inline comments surrounding the if/elseif conditions for assigning document titles in `wp_get_document_title()`.
See #31078. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35300 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-20 18:30:59 +00:00
Konstantin Obenland e9579b3ed5 Site Icon: Get site icon ID only when needed.
Cuts down on unnecessary queries, especially in environments that rely on
post meta a lot. Reverts [32997].

Props ap.koponen, swissspidy.
Fixes #34368.



git-svn-id: https://develop.svn.wordpress.org/trunk@35299 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-20 18:22:41 +00:00
Drew Jaynes 8ec6153115 Docs: Update the hook doc for the `pre_get_document_title` filter to explain ''what'' value is filterable rather than ''why'' the value is filterable :-)
The hook was introduced in [35294].

See #31078. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35298 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-20 18:13:13 +00:00
Drew Jaynes e5ec034d8f Docs: Improve vague changelog entries for functions and hooks where arguments were deprecated in [35294].
See #31078. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35297 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-20 18:09:06 +00:00
Drew Jaynes 2f5c72fea8 Docs: Fix up DocBlock syntax for the now-deprecated `wp_title()`.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35296 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-20 17:52:21 +00:00
Konstantin Obenland c7a86be42c Tests: Use updated filter names and oembed title for UT sanity.
See [35294], #31078.


git-svn-id: https://develop.svn.wordpress.org/trunk@35295 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-20 17:04:29 +00:00
Konstantin Obenland d625bd2428 Themes: Improve document title output.
Introduces more flexibility in filtering all parts of the document title,the
separator, and a way to short-circuit title generation. Plugins can now also
check for theme support and reliably filter the entire output. See #18548.
Deprecates `wp_title()`.

Fixes #31078.



git-svn-id: https://develop.svn.wordpress.org/trunk@35294 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-20 16:20:04 +00:00
Sergey Biryukov 1940317385 In `wp_list_categories()`, rewrite a long condition for clarity.
See #34363.

git-svn-id: https://develop.svn.wordpress.org/trunk@35293 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-20 16:12:21 +00:00
Sergey Biryukov 0a614515ac Tags: Avoid a double trailing space after tags separator in auto-suggest.
Props afercia.
Fixes #33881.

git-svn-id: https://develop.svn.wordpress.org/trunk@35292 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-20 15:59:01 +00:00
Boone Gorges 2713768bb0 Correct inline comment in `wp_list_categories()`.
The fallback link for the 'All' option is 'page_for_posts', not
'page_on_front'. Introduced in [32292].

Props sudar, SergeyBiryukov.
Fixes #34363.

git-svn-id: https://develop.svn.wordpress.org/trunk@35291 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-20 12:54:55 +00:00
Drew Jaynes 5b8bd2209e Docs: Correction: `MONTH_IN_SECONDS` was added in 4.4.0.
Props swissspidy.
See [33698]. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35290 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-20 07:34:34 +00:00