sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
31,907 Commits 2 Branches 473 Tags 137 MiB
1aaa0aa607
Commit Graph

8340 Commits

Author SHA1 Message Date
Scott Taylor
3a8f42bfe0 Post Thumbnails: In get_the_post_thumbnail_url(), return false instead of empty string when no URL is available. 
Fixes #33070.


git-svn-id: https://develop.svn.wordpress.org/trunk@34480 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 04:37:48 +00:00
Gary Pendergast
e1fafc56d5 WPDB: When attempting to fall back to ext/mysql in db_connect(), return the result of the fall back. 
While it doesn't affect Core, we should also be passing the `$allow_bail` parameter, for anything that uses it differently.

Props markoheijnen, johnbillion.

Fixes #33105.



git-svn-id: https://develop.svn.wordpress.org/trunk@34478 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 04:29:40 +00:00
Scott Taylor
b9ad7136d7 WP: after [34443], calling get_queried_object() messes up unit tests. We can just clone the $post prop and call it a day. 
Fixes #20226.


git-svn-id: https://develop.svn.wordpress.org/trunk@34476 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 03:53:39 +00:00
Scott Taylor
6ad1c1c380 Plugins: on the plugins admin screen, the "has been deleted" string needs a plural. 
Props jmayhak.
Fixes #33239.


git-svn-id: https://develop.svn.wordpress.org/trunk@34475 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 03:41:52 +00:00
Scott Taylor
bab2316129 Date/Time: Add unit tests for the_date(). 
Props jubstuff.
Fixes #33750.


git-svn-id: https://develop.svn.wordpress.org/trunk@34474 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 03:33:21 +00:00
Scott Taylor
9d71ae4122 Edit Post: After [33666], separate the translation string for pages, avoiding HTML usage. 
Props ramiy.
Fixes #31858.


git-svn-id: https://develop.svn.wordpress.org/trunk@34473 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 03:27:26 +00:00
Scott Taylor
d98165d1c3 Media Modal: move the translation strings for insertIntoPost and uploadedToThisPost to the get_post_type_labels() array as insert_into_item and uploaded_to_this_item. 
Props flixos90.
Fixes #33616.


git-svn-id: https://develop.svn.wordpress.org/trunk@34472 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 03:21:11 +00:00
Scott Taylor
0e81ac08de Nav Menus: Add a 'nav_menu_item_args' filter to Walker_Nav_Menu::start_el(). 
Props bjornjohansen.
Fixes #29417.


git-svn-id: https://develop.svn.wordpress.org/trunk@34471 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 03:16:44 +00:00
Scott Taylor
000b9e2fb3 Include fourth array parameter in return value doc block for wp_get_attachment_image_src(). 
Props kadamwhite.
Fixes #33905.


git-svn-id: https://develop.svn.wordpress.org/trunk@34470 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 03:13:08 +00:00
Scott Taylor
c9c9e19260 After [34341], add translation strings. 
Props ramiy.
Fixes #31862.


git-svn-id: https://develop.svn.wordpress.org/trunk@34469 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 03:08:34 +00:00
Scott Taylor
21dad99c1b List Tables: add JS code to dynamically toggle the disabled attribute of the Bulk Actions dropdown and Apply button. 
Props wonderboymusic, pareshradadiya.
Fixes #31634.


git-svn-id: https://develop.svn.wordpress.org/trunk@34467 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 01:06:17 +00:00
Scott Taylor
d92723a33f Users: in WP_User::__unset(), don't reset the deprecated prop id to ID. Still throw the deprecated notice. 
Update unit test.

Fixes #20043.


git-svn-id: https://develop.svn.wordpress.org/trunk@34466 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 00:48:23 +00:00
Scott Taylor
c1c93f1e95 Widgets: when passing a string arg value to dynamic_sidebar(), don't reset $index when the arg's sanitized value matches the sanitized name of a sidebar. 
Adds unit test.

Props tyxla, fjarrett.
Fixes #23423.


git-svn-id: https://develop.svn.wordpress.org/trunk@34465 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 00:29:54 +00:00
Scott Taylor
9209546292 Recent Posts Widget: remove HTML fragment caching. The cache currently doesn't work cross-scheme and causes mixed content issues for links. The widget was written pre-$split_the_query, after which post objects can be served from the cache. 
Fixes #27565.


git-svn-id: https://develop.svn.wordpress.org/trunk@34464 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 00:16:16 +00:00
Scott Taylor
325a900519 Calendar Widget: remove the title attribute for days and replace with aria-label. Spruce up some of this nasty code. Delete unnecessary bits. 
Props wonderboymusic, elusiveunit, 5um17. 
Fixes #30297.


git-svn-id: https://develop.svn.wordpress.org/trunk@34463 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-23 23:56:05 +00:00
John Blackbourn
1ce18f6e95 Send a 500 HTTP response code when the server's PHP or MySQL checks fail. 
Fixes #33689
Props jeichorn


git-svn-id: https://develop.svn.wordpress.org/trunk@34462 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-23 21:56:32 +00:00
Scott Taylor
a87b30da21 Comments: allow meta boxes for Discussion and Comments in extenuating circumstances. 
* Discussion: Post Type stops supporting comments, but comments and/or pings are open on a post. 
* Comments: Post is published or private, the post type has stopped supporting comments, but comments and/or pings are open on a post.

Currently, there is no way to toggle those settings off.

Props couturefreak, wonderboymusic, rachelbaker.
Fixes #28080.


git-svn-id: https://develop.svn.wordpress.org/trunk@34461 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-23 19:48:41 +00:00
Boone Gorges
daadd27ed4 Allow comment_exists() to match based on GMT date. 
The `comment_date_gmt` field of the `wp_comments` table is indexed, which makes
`WHERE` matches against the field much faster than against the unindexed
`comment_date`. For bulk operations like data import, the speed difference can
be meaningful.

We continue to default to 'blog' for `$timezone`, to preserve compatibility
with existing uses.

Props apokalyptik.
Fixes #33871.

git-svn-id: https://develop.svn.wordpress.org/trunk@34460 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-23 18:15:39 +00:00
John Blackbourn
92748bb96e Add an entry for Cloudup to the list of oEmbed providers. 
See #26278


git-svn-id: https://develop.svn.wordpress.org/trunk@34459 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-23 15:59:42 +00:00
John Blackbourn
d8a59791f0 Avoid a PHP notice if the last_updated property isn't present in a plugin's data from the Plugins API. 
Fixes #33024
Props icetee


git-svn-id: https://develop.svn.wordpress.org/trunk@34458 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-23 15:09:42 +00:00
Boone Gorges
4cbd2fbc55 Multisite: Don't limit site titles to 50 chars. 
This restriction dates from ye olden times, ie https://mu.trac.wordpress.org/changeset/1140.
It is no longer relevant.

Props chriscct7, theode.
Fixes #33973.

git-svn-id: https://develop.svn.wordpress.org/trunk@34455 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-23 14:23:13 +00:00
Boone Gorges
e6b7c6b2d4 Bail early when invalid ID is passed to get_comment_class(). 
This helps to avoid PHP notices later in the function.

Props walterebert, dipesh.kakadiya, DrewAPicture.
Fixes #33947.

git-svn-id: https://develop.svn.wordpress.org/trunk@34454 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-23 14:08:47 +00:00
Scott Taylor
fc3b7b20cd Links: the esc_html() additions in [34444] aren't very nice to screen reader <span>s. Revert those specific calls. 
See #14900.


git-svn-id: https://develop.svn.wordpress.org/trunk@34452 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-23 04:25:18 +00:00
Sergey Biryukov
6c63977ec2 Make the 'register_post_type_args' filter introduced in [34242] available for built-in post types too. 
Props MikeSchinkel.
Fixes #17447.

git-svn-id: https://develop.svn.wordpress.org/trunk@34451 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 22:31:25 +00:00
Scott Taylor
d416922cbf Remove some unused globals and/or their docs. 
See ##33491.


git-svn-id: https://develop.svn.wordpress.org/trunk@34446 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 20:26:17 +00:00
Scott Taylor
e2ce2d90fd After [34444​], wp_get_shortlink() can call get_queried_object_id() instead of using the $wp_query global. 
See #14900.


git-svn-id: https://develop.svn.wordpress.org/trunk@34445 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 20:08:49 +00:00
Scott Taylor
e06ca91cd2 Links: use consistent late-escaping in some HTML link-generation functions: 
* `post_comments_feed_link()`
* `edit_post_link()`
* `edit_comment_link()`
* `edit_bookmark_link()`
* `rel_canonical()`

Props niallkennedy, wonderboymusic.
Fixes #14900.


git-svn-id: https://develop.svn.wordpress.org/trunk@34444 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 20:05:17 +00:00
Scott Taylor
23c82a270b PINGBACKS: After [34442], switch to is_singular() to check attachments and pages as well. 
See #20226.


git-svn-id: https://develop.svn.wordpress.org/trunk@34443 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 19:09:28 +00:00
Scott Taylor
e774c95266 PINGBACKS: rather than sending the X-Pingback HTTP header on every single request for fun, perhaps only send it on single posts with pings open. 
See #20226.


git-svn-id: https://develop.svn.wordpress.org/trunk@34442 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 18:46:43 +00:00
Drew Jaynes
44006ff6a2 Docs: Actually, the subpackage for Walker_Page should be Template. 
See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34441 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 15:08:10 +00:00
Drew Jaynes
1ea9111541 Docs: Add a file header to wp-includes/widgets/class-wp-widget-text.php, introduced in [33746]. 
Also clarifies the class DocBlock summary and tags for `WP_Widget_Text`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34440 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 15:03:03 +00:00
Drew Jaynes
fdc31fdf45 Docs: Add a file header to wp-includes/widgets/class-wp-widget-tag-cloud.php, introduced in [33746]. 
Also clarifies the class DocBlock summary and tags for `WP_Widget_Tag_Cloud`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34439 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 15:01:24 +00:00
DrewAPicture
7aedd83be1 Docs: Add a file header to wp-includes/widgets/class-wp-widget-search.php, introduced in [33746]. 
Also clarifies the class DocBlock summary and tags for `WP_Widget_Search`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34438 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 15:00:04 +00:00
Drew Jaynes
564fda0cf7 Docs: Add a file header to wp-includes/widgets/class-wp-widget-rss.php, introduced in [33746]. 
Also clarifies the class DocBlock summary and tags for `WP_Widget_RSS`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34437 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 14:56:14 +00:00
Drew Jaynes
6acc3944d3 Docs: Add a file header to wp-includes/widgets/class-wp-widget-recent-posts.php, introduced in [33746]. 
Also clarifies the class DocBlock summary and tags for `WP_Widget_Recent_Posts`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34436 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 14:53:44 +00:00
Drew Jaynes
c668d2295d Docs: Add a file header to wp-includes/widgets/class-wp-widget-recent-comments.php, introduced in [33746]. 
Also clarifies the class DocBlock summary and tags for `WP_Widget_Recent_Comments`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34435 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 14:50:31 +00:00
Drew Jaynes
645c11475d Docs: Add a file header to wp-includes/widgets/class-wp-widget-pages.php, introduced in [33746]. 
Also clarifies the class DocBlock summary and tags for `WP_Widget_Pages`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34434 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 14:48:54 +00:00
Drew Jaynes
f78a3692d1 Docs: Add a file header to wp-includes/widgets/class-wp-widget-meta.php, introduced in [33746]. 
Also clarifies the class DocBlock summary and tags for `WP_Widget_Meta`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34433 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 14:47:32 +00:00
Drew Jaynes
5697314993 Docs: Add a file header to wp-includes/widgets/class-wp-widget-links.php, introduced in [33746]. 
Also clarifies the class DocBlock summary and tags for `WP_Widget_Links`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34432 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 14:46:07 +00:00
Drew Jaynes
cd24102b98 Docs: Clarify the class DocBlock summary for WP_Widget_Categories. 
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34431 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 14:44:43 +00:00
Drew Jaynes
55d0267122 Docs: Add a file header to wp-includes/widgets/class-wp-widget-calendar.php, introduced in [33746]. 
Also clarifies the class DocBlock summary and tags for `WP_Widget_Calendar`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34430 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 14:43:32 +00:00
Drew Jaynes
eb53dd65c9 Docs: Add a missing file header to wp-includes/widgets/class-wp-widget-archives.php, introduced in [33746]. 
Also clarifies the class DocBlock summary and tags for `WP_Widget_Archives`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34429 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 14:42:06 +00:00
Drew Jaynes
e6f5ac781e Docs: Clarify the file header summary for wp-includes/widgets/class-wp-nav-menu-widget.php, introduced in [33746]. 
Also clarifies the class DocBlock summary and tags for `WP_Nav_Menu_Widget`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34428 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 14:40:27 +00:00
Drew Jaynes
b63257accc Docs: Clarify the file header summary for wp-admin/includes/template-functions.php, introduced in [34241]. 
See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34427 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 14:36:43 +00:00
Drew Jaynes
015fb31933 Docs: Clarify the file header summary for wp-admin/includes/class-wp-internal-pointers.php, introduced in [34241]. 
Also adds a missing class DocBlock to `WP_Internal_Pointers`. See [19388].

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34426 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 14:34:55 +00:00
Drew Jaynes
f05d86060b Docs: Clarify the file header summary for wp-admin/includes/class-walker-category-checklist.php, introduced in [34241]. 
Also clarifies the class DocBlock summary for `Walker_Category_Checklist`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34425 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 14:32:20 +00:00
Sergey Biryukov
b9199cbcf7 Remove extra HTML from translatable strings in WP_Comments_List_Table::get_views(). 
Add a context and translator comments.

Props Tmeister for initial patch.
Fixes #31859.

git-svn-id: https://develop.svn.wordpress.org/trunk@34424 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 14:32:08 +00:00
Drew Jaynes
1de376cd8b Docs: Clarify the file header summary for wp-admin/includes/class-wp-post-comments-list-table.php, introduced in [34223]. 
Also clarifies the class DocBlock summary and tags for `WP_Post_Comments_List_Table`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34423 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 14:30:07 +00:00
Drew Jaynes
b3b19607bd Docs: Clarify the class DocBlock summary for WP_Screen. 
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34422 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 14:27:38 +00:00
Drew Jaynes
6dfcbd07c2 Docs: Add a file header to wp-admin/includes/nav-menus.php. 
See [34168]. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34421 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 14:26:23 +00:00
Drew Jaynes
fa11dc9c5b Docs: Clarify the file header summary and version for wp-includes/category-template.php. 
See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34420 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 14:22:48 +00:00
Drew Jaynes
a29f058e69 Docs: Clarify the file header summary and subpackage for wp-includes/category-functions.php, introduced in [34110]. 
See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34419 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 14:20:49 +00:00
Drew Jaynes
647fa83cc9 Docs: Clarify the file header for wp-includes/category.php. 
See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34418 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 14:19:13 +00:00
Drew Jaynes
a1595c5e85 Docs: Clarify the file header for wp-includes/class-walker-category-dropdown.php, introduced in [34110]. 
Also clarifies the class DocBlock and tags for `Walker_CategoryDropdown`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34417 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 14:02:32 +00:00
Drew Jaynes
df9d6e6bcc Docs: Clarify the file header summary for wp-includes/class-walker-category.php, introduced in [34110]. 
Also clarifies the class DocBlock and tags for `Walker_Category`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34416 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 14:00:54 +00:00
Drew Jaynes
44c55211ce Docs: Clarify the file header subpackage for wp-includes/class-walker-page-dropdown.php, introduced in [34109]. 
Also clarifies the class DocBlock summary and tags for `Walker_PageDropdown`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34415 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 13:57:23 +00:00
Drew Jaynes
ac613406d7 Docs: Clarify the file header summary for wp-includes/class-walker-page.php, introduced in [34109]. 
Also clarifies the class DocBlock summary for `Walker_Page`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34414 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 13:53:44 +00:00
Drew Jaynes
5d84cf9acc Docs: The Widgets subpackage is plural. 
See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34413 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 13:47:09 +00:00
Drew Jaynes
a74e215ac4 Docs: The Users subpackage is plural. 
See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34412 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 13:45:48 +00:00
Drew Jaynes
00fe089f24 Docs: The Comments subpackage is plural. 
See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34411 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 13:44:35 +00:00
Drew Jaynes
4e0b71390f Docs: The Comment API is singular. 
See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34410 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 13:43:55 +00:00
Drew Jaynes
10278a11d3 Docs: The Comment API is singular. 
See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34409 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 13:42:15 +00:00
Drew Jaynes
c7dddad085 Docs: Clarify the file header summary for wp-includes/default-widgets.php, the top-level file for bringing in the core widget classes. 
Also adds inline DocBlocks for the widget classes now brought in via `require_once()` as of [33843].

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34408 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 13:35:41 +00:00
DrewAPicture
451534ad3b Docs: Clarify the file header summary for wp-includes/meta.php, the top-level file for the core Meta API. 
Also adds inline DocBlocks for files broken out in #33413 and now brought in via `require_once()`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34407 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 13:29:02 +00:00
Drew Jaynes
36885e252e Docs: Clarify the file header summary for wp-includes/meta-functions.php, introduced in [33761]. 
See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34406 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 13:26:47 +00:00
Drew Jaynes
55cffaf8df Docs: Add a file header to wp-includes/class-wp-meta-query.php, introduced in [33761]. 
Also clarifies the class DocBlock summary for `WP_Meta_Query`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34405 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 13:25:37 +00:00
Drew Jaynes
88b8113b8d Docs: Clarify the file header summary for wp-includes/taxonomy.php, the top-level file for the core Taxonomy API. 
See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34404 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 13:22:38 +00:00
Drew Jaynes
1651d2cdf6 Docs: Clarify the file header summary for wp-includes/taxonomy-functions.php, introduced in [33760]. 
See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34403 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 13:19:59 +00:00
Drew Jaynes
c8830724ce Docs: Add a file header to wp-includes/class-wp-tax-query.php, introduced in [33760]. 
Also clarifies the class DocBlock summary and description for `WP_Tax_Query`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34402 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 13:15:45 +00:00
Drew Jaynes
6e6e5cef2d Docs: Clarify the file header summary for wp-includes/post.php, the top-level file for the Post API. 
See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34401 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 13:12:55 +00:00
Drew Jaynes
5318055735 Docs: Clarify the file header summary for wp-includes/post-functions.php, introduced in [33759]. 
See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34400 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 13:11:03 +00:00
Drew Jaynes
70d8db9520 Docs: Add a file header to wp-includes/class-wp-post.php, introduced in [33759]. 
Also clarifies the class DocBlock for `WP_Post`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34399 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 13:09:17 +00:00
Drew Jaynes
8d033c32d3 Docs: Clarify the file header summary for wp-includes/capabilities.php, which was broken up into multiple files in [33752]. 
Also adds inline DocBlocks for files now brought in via `require_once()` from this file.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34398 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 13:05:38 +00:00
Drew Jaynes
88a5649234 Docs: The User API is singular. 
See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34397 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 13:02:25 +00:00
Drew Jaynes
7fbdd70bb0 Docs: Clarify the file header summary for wp-includes/capabilities-functions.php, introduced in [33752]. 
See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34396 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 13:00:48 +00:00
Drew Jaynes
76efb299c8 Docs: Add a file header to wp-includes/class-wp-role.php, introduced in [33752]. 
Also adjusts the class DocBlock for `WP_Role`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34395 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 12:58:11 +00:00
Drew Jaynes
9745959dc8 Docs: Add a file header to wp-includes/class-wp-roles.php, introduced in [33752]. 
Also adjusts the class DocBlock for `WP_Roles`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34394 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 12:53:15 +00:00
Drew Jaynes
aabead83e6 Docs: The User API is singular. 
See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34393 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 12:30:43 +00:00
Drew Jaynes
5e875e78f7 Docs: The Widget API is singular. 
See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34392 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 12:27:33 +00:00
Drew Jaynes
7193d1987e Docs: Update the file path in the duplicate hook comment for the admin_xml_ns hook in wp-admin/includes/template-functions.php. 
The hook was "moved" to the newly-created template-functions.php file via `svn cp` in [34241].

Props dimadin.
See #33413.


git-svn-id: https://develop.svn.wordpress.org/trunk@34391 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 10:31:24 +00:00
Drew Jaynes
16e2ecda05 Docs: Add a missing access modifier to the declaration for the WP_User::__unset() magic method, introduced in [34380]. 
Also adds missing documentation to the DocBlock.

Fixes #20043.


git-svn-id: https://develop.svn.wordpress.org/trunk@34390 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 10:06:56 +00:00
Drew Jaynes
4c8a45fe8c Docs: Fix some syntactical issues and add missing parameter and return descriptions to the DocBlock for the WP_User::__get() magic method. 
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34389 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 10:01:01 +00:00
Drew Jaynes
e0cef41f09 Docs: Fix some syntactical issues and add missing parameter and return descriptions to the DocBlock for the WP_User::__isset() magic method. 
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34388 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 09:58:05 +00:00
Drew Jaynes
adc24d967b Docs: Add a file header to wp-includes/class-wp-user.php, created in [33752]. 
See #33413.


git-svn-id: https://develop.svn.wordpress.org/trunk@34387 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 09:55:34 +00:00
Drew Jaynes
419bcab6d8 Docs: Add a changelog entry to WP_Widget_Categories for non-category support, added in [34376]. 
See #21165. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34386 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 09:49:39 +00:00
Drew Jaynes
7f2fe52e40 Docs: Add a file header to wp-includes/widgets/class-wp-widget-categories.php. 
See #33413.


git-svn-id: https://develop.svn.wordpress.org/trunk@34385 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 09:47:37 +00:00
Drew Jaynes
3696ffda21 Docs: Include 'wp-json' in the 4.4.0 changelog entry for the subdirectory_reserved_names filter. 
'wp-json' was appended to the reserved names list in [34375].

See #33789. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34384 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 09:43:40 +00:00
Scott Taylor
2ddc438111 List Tables: when comparing string literals (non-numeric in nature) against vars, strict comparison can/should be used. 
Props wonderboymusic, Viper007Bond.
Fixes #21249.


git-svn-id: https://develop.svn.wordpress.org/trunk@34383 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 06:05:39 +00:00
Scott Taylor
f543c65320 Dashboard: 2 submit buttons don't need names. 
Props garyc40, gizburdt.
Fixes #16345.


git-svn-id: https://develop.svn.wordpress.org/trunk@34382 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 05:44:45 +00:00
Scott Taylor
3a00b7c5f0 Widgets: add a static property to WP_Widget_Calendar to ensure that the id attribute is only output once. 
Props MikeHansenMe, wonderboymusic.
Fixes #24604.


git-svn-id: https://develop.svn.wordpress.org/trunk@34381 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 05:08:33 +00:00
Scott Taylor
0ad726ef4d Users: add __unset to WP_User. 
Adds unit tests.

Props johnjamesjacoby, MikeHansenMe, wonderboymusic.
Fixes #20043.


git-svn-id: https://develop.svn.wordpress.org/trunk@34380 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 04:59:35 +00:00
Scott Taylor
3f8f3ccff0 Users: clarify the docs for WP_User::__set to make it clear that it does save data in the database. 
Props johnpbloch.
Fixes #24255.


git-svn-id: https://develop.svn.wordpress.org/trunk@34379 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 04:55:50 +00:00
Scott Taylor
40b5ade751 After [34374], ensure that $iptc is defined. 
See #33772.


git-svn-id: https://develop.svn.wordpress.org/trunk@34378 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 04:48:25 +00:00
Scott Taylor
fc1980e369 Sanitization: when falling back to (wait for it...) $fallback in sanitize_html_class(), sanitize it as well. 
Props MikeHansenMe, wonderboymusic.
Fixes #30967.


git-svn-id: https://develop.svn.wordpress.org/trunk@34377 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 04:30:11 +00:00
Scott Taylor
90fb9480d1 Widgets: Make the categories widget work with custom taxonomies. 
Props fonglh, wonderboymusic, DrewAPicture, kucrut.
Fixes #21165.


git-svn-id: https://develop.svn.wordpress.org/trunk@34376 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 04:24:53 +00:00
Scott Taylor
5dd7bec848 Multisite: as a precaution, make wp-json a reserved subdirectory name. 
Props austinginder.
Fixes #33789.


git-svn-id: https://develop.svn.wordpress.org/trunk@34375 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 04:20:41 +00:00
wonderboymusic
70b90490fd Media: In wp_read_image_metadata(), include IPTC Keywords when available in $meta. 
Adds unit test.

Props swissspidy, dbru, SteveHoneyNZ.
Fixes #33772.


git-svn-id: https://develop.svn.wordpress.org/trunk@34374 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 04:18:02 +00:00
Scott Taylor
1352d3473a Media: Add new functions, get_the_post_thumbnail_url() and the_post_thumbnail_url(). 
Adds unit tests.

Props dipesh.kakadiya, swissspidy, atomicjack.
Fixes #33070.


git-svn-id: https://develop.svn.wordpress.org/trunk@34373 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 04:14:15 +00:00
Scott Taylor
3c0ecff16e Media: Add a new function, wp_get_attachment_image_url(), which is a shortcut for wp_get_attachment_image_src() - same function signature, but returns just the URL based on $size. 
Adds unit test.

Props dipesh.kakadiya, swissspidy, sebastian.pisula.
Fixes #33878.


git-svn-id: https://develop.svn.wordpress.org/trunk@34372 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 04:12:44 +00:00
Scott Taylor
8a33422bfc Passwords: fix the markup on the Reset Password Form for user-pass1 so the JavaScript operates properly. 
Props ldinclaux.
See #33892.
Fixes #33908.


git-svn-id: https://develop.svn.wordpress.org/trunk@34371 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 03:56:25 +00:00
Scott Taylor
f9d1856805 Help Tabs: when returning help tabs, return them in order of priority, but also return the items in each priority in the order that they were added. 
Fixes #33941.


git-svn-id: https://develop.svn.wordpress.org/trunk@34370 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 03:36:27 +00:00
Scott Taylor
e75c7651b2 HTTP: Add some new Cookie helper functions: 
* `wp_remote_retrieve_cookies( $response )`
* `wp_remote_retrieve_cookie( $response, $name )`
* `wp_remote_retrieve_cookie_value( $response, $name )`

Adds unit tests.

Props johnbillion.
Fixes #33711.


git-svn-id: https://develop.svn.wordpress.org/trunk@34369 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 03:13:13 +00:00
Drew Jaynes
782b9085c9 Docs: Move a duplicate hook comment accidentally left behind when its corresponding filter was relocated in [31765]. 
See #31443. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34368 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-21 23:12:35 +00:00
Konstantin Obenland
3cd12045d3 Introduce template functions for comment navigation: 
* `get_the_comments_navigation()` and `the_comments_navigation()` for navigation to the next and previous page of comments.
* `get_the_comments_pagination()` and `the_comments_pagination()` for paginated navigation between pages of comments. Uses `paginate_comments_links()`.

This reduces the need for themes to define their own sets of comment navigation
functions, like Twenty Fifteen and others.
Completes the navigation template tag API started in #29808 for posts.

Fixes #30589.



git-svn-id: https://develop.svn.wordpress.org/trunk@34367 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-21 16:31:19 +00:00
Scott Taylor
c34e94b693 Docs: is_main_query()'s _doing_it_wrong() notice suggests using WP_Query statically (WP_Query::is_main_query()). Use an alternate syntax: WP_Query->is_main_query(), to not confuse. 
Props DrewAPicture, micahwave.
Fixes #25680.


git-svn-id: https://develop.svn.wordpress.org/trunk@34366 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-21 15:30:49 +00:00
Helen Hou-Sandi
9aaa278e02 Notices: Add styles for use against white backgrounds. 
These colored backgrounds can be accessed by adding the `.notice-alt` class to a notice.

There is also now a large version when using the `.notice-large` class, and a `.notice-title` class that is appropriate for headline text within a large notice.

props paulwilde, hugobaeta, melchoyce.
fixes #32244.


git-svn-id: https://develop.svn.wordpress.org/trunk@34365 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-21 15:25:37 +00:00
Scott Taylor
2b3347332e Meta Boxes: In post_categories_meta_box(), convert some spaces to tabs. 
Props miyauchi.
Fixes #33945.


git-svn-id: https://develop.svn.wordpress.org/trunk@34364 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-21 15:17:29 +00:00
Drew Jaynes
81e235444a Docs: The $post parameter has been passed to the preview_post_link since 4.0.0. 
Fixes a version mixup introduced in [34170].

Props dimadin.
See #24345.


git-svn-id: https://develop.svn.wordpress.org/trunk@34363 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-21 13:16:36 +00:00
Drew Jaynes
f9e45047c1 Docs: Add a more complete return description for the array of data (or false) returned by image_downsize(). 
If not short-circuited via the `image_downsize` boolean filter, `image_downsize()` returns an array of data including the image URL, width, height, and whether the image size is intermediate, in that order. Otherwise, it returns false.

Fixes #30636.


git-svn-id: https://develop.svn.wordpress.org/trunk@34362 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-21 10:21:48 +00:00
Drew Jaynes
71ce9e812c Docs: Update the docs for WP_User_Query->prepare_query() for ordering by the value of the include argument, allowed since 4.1. 
Also adds a changelog entry for the additionally-accepted value.

Props danielbachhuber.
Fixes #33937.


git-svn-id: https://develop.svn.wordpress.org/trunk@34361 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-21 00:46:08 +00:00
John Blackbourn
f80add733c Implement a 'Mine' link on post listing screens in the admin area for all users who have authored posts. This feature was previously only available to users who cannot edit other users' posts (namely Authors and Contributors). 
Props linuxologos, wonderboymusic
Fixes #19609


git-svn-id: https://develop.svn.wordpress.org/trunk@34360 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 17:27:35 +00:00
John Blackbourn
ce126c10c0 Remove the ability to view the term editing screen for taxonomies with show_ui set to false. It is unexpected and unintended behaviour that this is allowed. 
If your plugin or site does rely on this behaviour, the arguments that are passed to `register_taxonomy()` should be altered so that `show_ui` is `true`, and arguments such as `show_in_menu` and `show_in_nav_menus` are false.

Fixes #33938


git-svn-id: https://develop.svn.wordpress.org/trunk@34359 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 17:10:55 +00:00
John Blackbourn
dc7d968b19 Implement some more uses of wp_login_url() in places where wp-login.php is hard-coded. 
See #31495


git-svn-id: https://develop.svn.wordpress.org/trunk@34358 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 16:53:32 +00:00
John Blackbourn
2894423f19 Revisions are an exception when it comes to the editing UI. The revision post type cannot have its show_ui argument set to true because this allows access to the post type listing, creation, and editing UI, but get_edit_post_link() needs to return a URL for the editing UI for revisions as that's how the revisions UI works. 
Fixes #33763


git-svn-id: https://develop.svn.wordpress.org/trunk@34357 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 16:37:41 +00:00
Konstantin Obenland
050def62a3 Multisite: Make site status classes available to other elements. 
Fixes a regression introduced in [31181], where links to user's site would not
have a colored background based on their status anymore.

Fixed during WordCamp Switzerland Contributor Day.

Props psoluch.
Fixes #33595.



git-svn-id: https://develop.svn.wordpress.org/trunk@34356 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 12:52:56 +00:00
Drew Jaynes
e3e91dbadc Docs: Add a description for the documented use of the $wpdb global in _prime_comment_caches(). 
See #8071. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34355 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 09:38:24 +00:00
Dominik Schilling (ocean90)
ce1832f49c Login: Move the "Lost your password?" link into a separate string to reduce HTML tags in translation strings. 
Props ramiy.
Fixes #31870.

git-svn-id: https://develop.svn.wordpress.org/trunk@34354 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 09:10:59 +00:00
John Blackbourn
fe80bec9ee Add @since docs for the show_ui argument in register_post_type(). 
See #33763


git-svn-id: https://develop.svn.wordpress.org/trunk@34353 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 09:04:21 +00:00
Dominik Schilling (ocean90)
d3031d522e Upgrader: Avoid using an HTML tag in a translation string, add translator comments. 
Props ramiy for initial patch. 
Fixes #31860.

git-svn-id: https://develop.svn.wordpress.org/trunk@34352 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 08:58:27 +00:00
Dominik Schilling (ocean90)
ed82c7fb75 Theme Compat: Remove two strings from comments-popup.php. 
`theme-compat/comments-popup.php` is a deprecated file. Instead of improving the strings in [34342] remove both superfluous paragraphs.

See #31867.

git-svn-id: https://develop.svn.wordpress.org/trunk@34351 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 08:48:28 +00:00
Sergey Biryukov
857be1862b Pass the current post object to 'page_attributes_meta_box_template' action added in [34340]. 
Props DrewAPicture.
Fixes #33625.

git-svn-id: https://develop.svn.wordpress.org/trunk@34350 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 08:14:40 +00:00
Drew Jaynes
44c256e8d1 Docs: Use standardized vernacular in the hook doc summary for the page_attributes_meta_box_template filter, introduced in [34340]. 
See #33625.


git-svn-id: https://develop.svn.wordpress.org/trunk@34349 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 06:37:18 +00:00
Scott Taylor
ed7d34cb13 Pass false as the 2nd argument to class_exists() to disable autoloading and to not cause problems for those who define __autoload(). 
Fixes #20523.


git-svn-id: https://develop.svn.wordpress.org/trunk@34348 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 03:51:55 +00:00
Scott Taylor
520a75f44e The 'get_sample_permalink_html' filter​'s second parameter can be a post ID or a post object. This is confusing. We should pass the post ID and post object separately, for consistency with 'get_sample_permalink' filter added in [34309]. 
Props SergeyBiryukov.	
Fixes #33927.


git-svn-id: https://develop.svn.wordpress.org/trunk@34347 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 03:25:45 +00:00
Scott Taylor
0082a438c5 MediaElement, update wp-mediaelement.js: 
* create a public `initialize` method on the `wp.mediaelement` namespace
* make it idempotent to prevent nasty side-effects caused by initializing media elements more than once

Props bradyvercher.	
Fixes #32423.


git-svn-id: https://develop.svn.wordpress.org/trunk@34346 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 03:16:23 +00:00
Scott Taylor
191233f2f9 WP Query: Avoid using HTML tags in translation strings, add translator strings. 
Props ramiy.	
Fixes #31868.


git-svn-id: https://develop.svn.wordpress.org/trunk@34345 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 03:03:28 +00:00
Scott Taylor
df8f10ceff Plugins Admin: Avoid using HTML tags in translation strings, add translator strings. 
Props swissspidy, voldemortensen.	
Fixes #32269.


git-svn-id: https://develop.svn.wordpress.org/trunk@34344 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 03:00:57 +00:00
Scott Taylor
2161a20a68 WP Mail: Avoid using HTML tags in translation strings, add translator strings. 
Props ramiy.	
Fixes #31871.


git-svn-id: https://develop.svn.wordpress.org/trunk@34343 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 02:52:49 +00:00
Scott Taylor
067af6b9aa Theme Compat: Avoid using HTML tags in translation strings. 
Props ramiy.	
Fixes #31867.


git-svn-id: https://develop.svn.wordpress.org/trunk@34342 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 02:46:42 +00:00
Scott Taylor
d624c118cb Plugin Editor: Avoid using HTML tags in translation strings and add context. 
Props ramiy.	
Fixes #31862.


git-svn-id: https://develop.svn.wordpress.org/trunk@34341 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 02:41:43 +00:00
Scott Taylor
2812cc9595 In page_attributes_meta_box(), add an action, 'page_attributes_meta_box_template' to allow callbacks to be performed and HTML to be inserted after the title of the Template section. 
Props sgrant.	
Fixes #33625.


git-svn-id: https://develop.svn.wordpress.org/trunk@34340 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 02:39:31 +00:00
Scott Taylor
a3cb19c52e MediaElement: apply monkey patch to include a PR which fixes a breaking change made upstream on a public interface: 
ccba8d0b6a

Props bradyvercher.
Fixes #33798.


git-svn-id: https://develop.svn.wordpress.org/trunk@34339 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 02:30:06 +00:00
Scott Taylor
2ccbc51d1e Login: apply the same margin to the top and bottom of the Back to {Blog} link. 
Props MikeHansenMe.
Fixes #29249.


git-svn-id: https://develop.svn.wordpress.org/trunk@34338 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 01:40:42 +00:00
Drew Jaynes
12ce04a95e Docs: Add descriptions for $wp_query global phpDoc references in wp-includes/query.php, partially documented in [32620]. 
Fixes #32139.


git-svn-id: https://develop.svn.wordpress.org/trunk@34337 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 00:04:48 +00:00
Scott Taylor
b55de4e5f8 Feeds/Links: fix feed links for unattached attachments. 
Adds unit tests.

Props wonderboymusic, iworks.
Fixes #33693.


git-svn-id: https://develop.svn.wordpress.org/trunk@34336 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-19 20:09:05 +00:00
Scott Taylor
633b119fd3 Site Icon: for consistency, make all 4 HTML tags in wp_site_icon() self-closing. 
Props Corphi.
Fixes #33930.


git-svn-id: https://develop.svn.wordpress.org/trunk@34334 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-19 19:06:03 +00:00
Scott Taylor
0fdbaecbc6 Export: Add late-escaping to the contents of several nodes to avoid creating invalid XML and XML parse errors. 
Props westonruter.
Fixes #33732.


git-svn-id: https://develop.svn.wordpress.org/trunk@34333 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-19 18:52:27 +00:00
Scott Taylor
f9c67159d4 Updates: in Theme list table, set white-space to normal for theme titles at appropriate breakpoint to avoid horizontal scrolling on small screens. 
Fixes #33831.


git-svn-id: https://develop.svn.wordpress.org/trunk@34332 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-19 18:42:45 +00:00
Scott Taylor
d075313f5b Post List Table: 'All' view should be selected when appropriate for paged responses. 
Props kraftbj, wonderboymusic.
Fixes #33923.


git-svn-id: https://develop.svn.wordpress.org/trunk@34331 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-19 18:16:31 +00:00
Scott Taylor
f4445d75c4 Add a 'menu_id' argument to wp_page_menu() so that fallback menus have the same attributes as wp_nav_menu(). 
Props lancewillett, ocean90, wonderboymusic.
Fixes #31656.


git-svn-id: https://develop.svn.wordpress.org/trunk@34330 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-19 18:06:49 +00:00
Scott Taylor
1b550d9fb2 Reinstate [34327]. minus the unit test deletion. 
git-svn-id: https://develop.svn.wordpress.org/trunk@34329 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-19 17:48:18 +00:00
Scott Taylor
1e7832cc3b Revert [34327] to fix the accidental deletion of some unit tests. 
git-svn-id: https://develop.svn.wordpress.org/trunk@34328 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-19 17:45:46 +00:00
Scott Taylor
750c22abf8 Export: Add a filer, 'export_wp_filename' to change the filename of the file to download when exporting. 
Props MikeHansenMe, wonderboymusic.
Fixes #29500.


git-svn-id: https://develop.svn.wordpress.org/trunk@34327 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-19 17:43:52 +00:00
Scott Taylor
3624366045 Export: allow Media to exported separately from other types. 
Props PhilipLakin.
Fixes #32230.


git-svn-id: https://develop.svn.wordpress.org/trunk@34326 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-19 16:46:17 +00:00
Scott Taylor
d9b58bd4ac Admin: when toggling select/deselect "all" via JS - :visible needs to be bound to not toggle disabled inputs. 
Props tywayne.
Fixes #32309.


git-svn-id: https://develop.svn.wordpress.org/trunk@34325 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-19 16:40:34 +00:00
Scott Taylor
6d51562d72 Edit Post: When a post is "Pending Review", the "View Post" link should behave like ot does for drafts and generate a preview link. 
Props wpdev101.
Fixes #33541.


git-svn-id: https://develop.svn.wordpress.org/trunk@34324 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-19 16:31:38 +00:00
Scott Taylor
1ca6eee748 List Tables: Ensure that sorting indicators have layout when cell widths are being calculated. 
See #27743.


git-svn-id: https://develop.svn.wordpress.org/trunk@34323 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-19 16:14:59 +00:00
Scott Taylor
3cf5d40b9d Update Core: In list_plugin_updates(), when listing plugin updates related to $core_update_version, don't skip the check for $info->tested. 
Props MikeHansenMe.
Fixes #27883.


git-svn-id: https://develop.svn.wordpress.org/trunk@34322 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-19 16:09:40 +00:00
Konstantin Obenland
bfc9fc4040 Menus: Remove whitespace between nav menu items. 
Avoids CSS hacks like floating menu items or setting the parent element's
font-size to 0 in order to display nav menus horizontally.

Props jjeaton.
Fixes #27762.



git-svn-id: https://develop.svn.wordpress.org/trunk@34321 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-19 11:39:39 +00:00
Weston Ruter
7bdfb4917f Customize: Flesh out phpdoc for WP_Customize_Manager. 
* Add missing phpdoc for class member variables.
* Supply missing `@return` descriptions from [34269].
* Add missing `@since` tags.
* Remove unused `$customized` protected class member variable.

Fixes #33898.


git-svn-id: https://develop.svn.wordpress.org/trunk@34320 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-19 06:39:09 +00:00
Scott Taylor
1c5f85e1a4 When applying the 'editable_slug' filter, add a second param that provides more context. 
Props MikeSchinkel, jesin.
Fixes #31568.


git-svn-id: https://develop.svn.wordpress.org/trunk@34319 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-19 05:48:30 +00:00
Scott Taylor
09e3149b7a Add a 'clean_user_cache' action at the end of clean_user_cache(). This is mighty similar to clean_post_cache(). 
Props elliott-stocks, wonderboymusic.
Fixes #31918.


git-svn-id: https://develop.svn.wordpress.org/trunk@34318 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-19 05:40:22 +00:00
Andrew Ozz
51078c32ec TinyMCE: remove word-break: break-word; from the default editor CSS to prevent irregular spaces when typing in RTL languages. 
Props iehsanir, alireza1375, ankit-k-gupta.
Fixes #33868.

git-svn-id: https://develop.svn.wordpress.org/trunk@34317 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 23:57:56 +00:00
Dominik Schilling (ocean90)
9b546efc1b Theme Compat: Remove commented out code. 
See #31867.

git-svn-id: https://develop.svn.wordpress.org/trunk@34316 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 21:37:09 +00:00
Dominik Schilling (ocean90)
7eb0317968 Don't use <code> in translation strings in wp-admin/options.php. 
Props ramiy, wonderboymusic.
Fixes #31861.

git-svn-id: https://develop.svn.wordpress.org/trunk@34315 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 20:42:20 +00:00
Dominik Schilling (ocean90)
f5eacb71d6 Don't use <code> in translation strings in wp-admin/includes/plugin.php. 
Props ramiy.
Fixes #31856.

git-svn-id: https://develop.svn.wordpress.org/trunk@34314 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 20:28:23 +00:00
Dominik Schilling (ocean90)
0c642e4730 Use correct @since tag for wp_ajax_generate_password(). 
See #33450.

git-svn-id: https://develop.svn.wordpress.org/trunk@34313 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 20:18:22 +00:00
Scott Taylor
1299974e7d Profile: when clicking "Cancel" after clicking "Generate Password", request and generate a new password to present to the user. 
Props adamsilverstein, wonderboymusic.
Fixes #33450.


git-svn-id: https://develop.svn.wordpress.org/trunk@34312 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 20:13:34 +00:00
Scott Taylor
a5f62a6cd5 Media: add a filter, 'mejs_settings', to allow devs to pass more config settings to MediaElement. 
Fixes #33506.


git-svn-id: https://develop.svn.wordpress.org/trunk@34311 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 19:59:43 +00:00
Boone Gorges
2fd81992bc Split the comment query. 
`WP_Comment_Query` now fetches comments in two stages: (1) a query to get the
IDs of comments matching the query vars, and (2) a query to populate the
objects corresponding to the matched IDs. The two queries are cached
separately, so that sites with persistent object caches will continue to have
complete cache coverage for normal comment queries.

Splitting the query allows our cache strategy to be more modest and precise, as
full comment data is only stored once per comment. It also makes it possible
to introduce logic for paginated threading, which is necessary to address
certain performance problems.

See #8071.
data is only stored once per comment, instead of along with

git-svn-id: https://develop.svn.wordpress.org/trunk@34310 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 19:27:39 +00:00
Scott Taylor
b0b36bc346 Add a 'get_sample_permalink' filter. 
Props SergeyBiryukov, wenthemes, JustinSainton.
Fixes #22338.


git-svn-id: https://develop.svn.wordpress.org/trunk@34309 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 19:27:24 +00:00
Scott Taylor
27eb1ac0da Add title_reply_before and title_reply_after args to comment_form() to allow the "Leave a Reply" heading level to be changed. 
Props tyxla.
Fixes #33775.


git-svn-id: https://develop.svn.wordpress.org/trunk@34308 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 19:17:19 +00:00
Scott Taylor
b862280404 After [34280], rename menu_tag arg to container, fix docs. 
Props DrewAPicture.
Fixes #10968.


git-svn-id: https://develop.svn.wordpress.org/trunk@34307 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 19:04:18 +00:00
Sergey Biryukov
c43a62bde7 Include placeholder in translator comment. 
See #31863.

git-svn-id: https://develop.svn.wordpress.org/trunk@34306 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 19:02:37 +00:00
Sergey Biryukov
039ce30818 Include placeholder in translator comment. 
See #31864.

git-svn-id: https://develop.svn.wordpress.org/trunk@34305 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 19:00:20 +00:00
Sergey Biryukov
21a41c100f Include placeholders in translator comments. 
See #31857.

git-svn-id: https://develop.svn.wordpress.org/trunk@34304 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 18:57:01 +00:00
Scott Taylor
394e9ac21a Don't use HTML tags in translation strings in edit-tags.php. 
Props ramiy.
Fixes #31863.


git-svn-id: https://develop.svn.wordpress.org/trunk@34303 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 18:52:48 +00:00
Scott Taylor
de077ac377 Don't use HTML tags in translation strings in wp_ajax_add_user(). 
Props ramiy.
Fixes #31864.


git-svn-id: https://develop.svn.wordpress.org/trunk@34302 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 18:50:04 +00:00
Sergey Biryukov
5cfdae8b2b Add missing translator comment after [34295]. 
See #31853.

git-svn-id: https://develop.svn.wordpress.org/trunk@34301 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 18:49:40 +00:00
Sergey Biryukov
bcc165791f Add missing translator comments after [34294]. 
See #31852.

git-svn-id: https://develop.svn.wordpress.org/trunk@34300 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 18:45:40 +00:00
Sergey Biryukov
48c6d925cd Add missing translator comment after [34292]. 
See #31840.

git-svn-id: https://develop.svn.wordpress.org/trunk@34299 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 18:39:20 +00:00
Sergey Biryukov
f90ee7b348 Add missing translator comments after [34293]. 
See #31851.

git-svn-id: https://develop.svn.wordpress.org/trunk@34298 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 18:38:54 +00:00
Scott Taylor
310dc18167 Don't use HTML tags in translation strings for "In Reply To" links for comments in the admin. 
Props ramiy.
Fixes #31857.


git-svn-id: https://develop.svn.wordpress.org/trunk@34297 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 18:35:16 +00:00
Scott Taylor
13889763af Don't use HTML tags in translation strings in wp-admin/includes/update.php. 
Props ramiy.
Fixes #31855.


git-svn-id: https://develop.svn.wordpress.org/trunk@34296 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 18:30:26 +00:00
Scott Taylor
c10019ec70 Don't use <code> in translation strings in edit-form-comment.php. 
Props ramiy.
Fixes #31853.


git-svn-id: https://develop.svn.wordpress.org/trunk@34295 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 18:27:29 +00:00
Scott Taylor
df149fddff Don't use <code> in translation strings in options-general.php. 
Props ramiy, SergeyBiryukov.
Fixes #31852.


git-svn-id: https://develop.svn.wordpress.org/trunk@34294 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 18:23:19 +00:00
Scott Taylor
d2b4e0c728 Don't use <code> in translation strings in wp-admin/includes/schema.php. 
Props ramiy.
Fixes #31851.


git-svn-id: https://develop.svn.wordpress.org/trunk@34293 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 18:20:46 +00:00
Scott Taylor
f6d2c30fa7 Network Setup: don't use <code> in translation strings in wp-admin/network files. 
Props ramiy.
Fixes #31840.


git-svn-id: https://develop.svn.wordpress.org/trunk@34292 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 18:17:26 +00:00
Aaron Jorbin
308179c232 Remove support for my-hacks.php 
For the last 10 years, my-hacks has been deprecated and has been throwing a deprecation notice. For the last six years, you haven't been able to enable my-hacks.php in the admin UI. That should be enough time to give developers notice. Plugins and themes seem like they might have staying power.

Fixes #33741
Props bobbingwide



git-svn-id: https://develop.svn.wordpress.org/trunk@34291 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 17:05:28 +00:00
Dominik Schilling (ocean90)
7f562dd69f Theme Editor: Change file descriptions of header.php and footer.php. 
`header.php` is now "Theme Header" and `footer.php` is "Theme Footer". This prevents a clash with other "Header" strings in the context of "Custom Header".

Props ramiy.
Fixes #32975.

git-svn-id: https://develop.svn.wordpress.org/trunk@34290 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 16:02:24 +00:00
Sergey Biryukov
7851406626 Network Admin: Include IDs for users and sites on their respective views. 
Props danielbachhuber, wonderboymusic.
Fixes #18661.

git-svn-id: https://develop.svn.wordpress.org/trunk@34289 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 15:57:47 +00:00
Drew Jaynes
a176e78b64 Docs: Clarify the significance of the $accepted_args parameter value in the documentation for add_filter(). 
Adds a couple of examples to illustrate callbacks accepting a variable number of arguments.

Fixes #33862.


git-svn-id: https://develop.svn.wordpress.org/trunk@34288 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 14:52:37 +00:00
Drew Jaynes
efc08d508e Docs: Fix some syntactical issues in the DocBlock for set_query_var(). 
Adds descriptions for the global `WP_Query` instance and the `$value` parameter.

See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34287 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 10:28:41 +00:00
Drew Jaynes
e889c2e647 Docs: Fix some syntactical issues in the documentation for get_queried_object_id(). 
Adds descriptions for the global `WP_Query` instance and the return.

See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34286 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 10:26:58 +00:00
Drew Jaynes
4706230535 Docs: Fix some syntactical isses in the DocBlock for get_queried_object(). 
Also add descriptions for the return and the `WP_Query` global.

See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34285 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 10:20:07 +00:00
Drew Jaynes
572e3ddafb Docs: Add documentation to get_query_var() and WP_Query::get() for the optional $default argument, introduced in 3.9 in [27304]. 
Props swissspidy.
Fixes #33856.


git-svn-id: https://develop.svn.wordpress.org/trunk@34284 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 09:40:51 +00:00
Dion Hulse
6e6d026524 HTTP: Update the Root Certificate bundle. 
See #30434


git-svn-id: https://develop.svn.wordpress.org/trunk@34283 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 08:42:24 +00:00
Dion Hulse
09f373d582 Updates: FTP: Add a missing PCRE modifer in [34281]. 
See #16026, #33432x


git-svn-id: https://develop.svn.wordpress.org/trunk@34282 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 08:22:17 +00:00
Dion Hulse
b114866bbf Updates: FTP/PemFTP Library: Remove the usage of deprecated regular expression functions (ereg replaced by PCRE). 
Props enshrined, aaroncampbell
Fixes #16026, #33432


git-svn-id: https://develop.svn.wordpress.org/trunk@34281 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 08:19:18 +00:00
Scott Taylor
30921dd396 Add an argument to wp_page_menu(), 'menu_tag', which defaults to div but can be overridden to allow HTML5 tags like nav. 
Props paulwilde, stebbiv, wonderboymusic.
Fixes #10968.


git-svn-id: https://develop.svn.wordpress.org/trunk@34280 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 06:06:17 +00:00
Weston Ruter
d81ca65d4c Customize: Fix live previewing of menu changes on subdirectory installs. 
Props adamsilverstein, westonruter.
Fixes #33916.


git-svn-id: https://develop.svn.wordpress.org/trunk@34278 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 05:46:53 +00:00
Scott Taylor
d5e5ca8e93 Comments: in wp_rel_nofollow_callback(), account for the fact that a link might already have a rel attribute. Currently, if a link already has a rel, it will result it duplicate attributes on the element with conflicting values. 
Adds unit tests.

Props junsuijin, wonderboymusic.
Fixes #9959.


git-svn-id: https://develop.svn.wordpress.org/trunk@34277 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 04:35:37 +00:00
Scott Taylor
50419ff08d List Tables: ensure that sortable list table column headers have the same padding/line-height as non-sortable headers. 
Props drozdz.
Fixes #27945.


git-svn-id: https://develop.svn.wordpress.org/trunk@34276 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 03:25:32 +00:00
Scott Taylor
ace6756081 Editor: add hide-if-no-js class to <td id="wp-word-count">. Word Count no worky with no JavaScript. 
Props chriscct7.
Fixes #33379.


git-svn-id: https://develop.svn.wordpress.org/trunk@34275 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 02:31:23 +00:00
Scott Taylor
c5963b8760 In wp-comments-post.php, sanity check a few of the comment inputs that are expected to be a string beford calling string-only functions on them. 
Props Kloon.
Fixes #23416.


git-svn-id: https://develop.svn.wordpress.org/trunk@34274 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-17 22:21:06 +00:00
Scott Taylor
bec1944e44 Widgets: don't show a dropdown if there is only 1 taxonomy or zero taxonomies available to the Tag Cloud widget form. Don't output the widget if there are no terms in the selected taxonomy. 
Props GautamGupta, wonderboymusic.
Fixes #16125.


git-svn-id: https://develop.svn.wordpress.org/trunk@34273 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-17 22:10:46 +00:00
Scott Taylor
2a4eba2eb8 Canonical: redirect URLs that match an attachment masked on the wrong URL to the attachment link for the matched attachment. 
Props solarissmoke.
Fixes #19918.


git-svn-id: https://develop.svn.wordpress.org/trunk@34272 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-17 21:31:21 +00:00
Scott Taylor
73c1ac8b26 Posts List Table: Use a more robust technique for calculating $total_items so that pagination still appears when items are removed on the last page of results and ->max_num_pages decreases. 
Props A5hleyRich.
Fixes #29870.


git-svn-id: https://develop.svn.wordpress.org/trunk@34271 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-17 21:17:16 +00:00
Boone Gorges
504deb52fc Lazy-load comment meta on single post pages. 
[34268] introduced cache priming for commentmeta, enabled by default. To
ensure performance on single post pages - where commentmeta is most likely
to cause performance issues - we disable up-front cache-priming. Instead, we
prime commentmeta caches for all comments in the loop the first time
`get_comment_meta()` is called on the page.

Props bradt, dd32, wonderboymusic, boonebgorges.
Fixes #16894.

git-svn-id: https://develop.svn.wordpress.org/trunk@34270 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-17 20:00:31 +00:00
Weston Ruter
5ea07785b3 Customize: Reduce peak memory usage by JSON-encoding settings and controls individually. 
When there are hundreds of settings and controls (e.g. nav menu items and widget instances) the resulting object that is JSON-encoded can become very large, and `wp_json_encode()` can consume a lot of memory to serialize it. By breaking down the serialization into multiple calls the peak memory usage can be kept in line.

Moves logic out of `wp-admin/customize.php` into the `WP_Customize_Manager` class with new methods:

 * `is_ios()`
 * `get_document_title_template()`
 * `get_preview_url()`/`set_preview_url()`
 * `get_return_url()`/`set_return_url()`
 * `get_autofocus()`/`set_autofocus()`
 * `customize_pane_settings()`

Includes unit tests for these methods, for which the logic was formerly untestable in `customize.php`.

Fixes #33898.


git-svn-id: https://develop.svn.wordpress.org/trunk@34269 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-17 19:41:35 +00:00
Boone Gorges
12329f5ef8 Prime comment meta caches in WP_Comment_Query. 
The new 'update_comment_meta_cache' parameter, which defaults to `true`, can
be used to disable this behavior.

`update_comment_cache()` has been updated to support an `$update_meta_cache`
parameter, which also updates to true; this matches the pattern we use for
priming post caches.

See #16894.

git-svn-id: https://develop.svn.wordpress.org/trunk@34268 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-17 19:29:46 +00:00
Boone Gorges
b08a176488 Tell the insert_user_meta filter whether user is being updated. 
`insert_user_meta` was introduced in [33708]. This changeset passes the
`$update` parameter to it.

Props tharsheblows, geminorum.
Fixes #31549.

git-svn-id: https://develop.svn.wordpress.org/trunk@34266 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-17 14:34:49 +00:00
Helen Hou-Sandi
3531c0bc10 Superglobals: Revert [34059] until further notice. 
see #33837.


git-svn-id: https://develop.svn.wordpress.org/trunk@34265 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-17 12:32:20 +00:00
Drew Jaynes
8c65cfc7f4 Docs: Add a reminder to the DocBlock description for add_query_arg() mentioning that the output is not escaped by default. 
Props brentvr for the initial patch. (first props!)
See #33912. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34264 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-17 09:38:56 +00:00
Sergey Biryukov
f9ff998d01 Revert unintended change from [34262]. 
See #33910.

git-svn-id: https://develop.svn.wordpress.org/trunk@34263 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-17 09:08:14 +00:00
Sergey Biryukov
45610f9464 Docs: Expand the DocBlock for get_default_post_to_edit(). 
Props rabmalin.
Fixes #33910.

git-svn-id: https://develop.svn.wordpress.org/trunk@34262 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-17 09:05:44 +00:00
Scott Taylor
8861e38966 Media: Ensure that HTML5 captions apply the 'img_caption_shortcode_width'. 
Props joemcgill.
Fixes #31053.


git-svn-id: https://develop.svn.wordpress.org/trunk@34261 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-17 06:03:11 +00:00
Scott Taylor
189bc9b5aa Media: In wp_ajax_send_attachment_to_editor(), the fallback logic for $html should be tucked into an else statement so it isn't run needlessly and overwritten. 
Props tychay.
Fixes #32072.


git-svn-id: https://develop.svn.wordpress.org/trunk@34260 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-17 05:54:56 +00:00
Scott Taylor
337c87e7c7 Media: In get_image_send_to_editor(), allow a custom value for $rel. 
Props tychay.
Fixes #32074.


git-svn-id: https://develop.svn.wordpress.org/trunk@34259 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-17 05:45:31 +00:00
Scott Taylor
2e7277b733 Media: In wp_prepare_attachment_for_js(), don't call file_exists() and filesize() to retrieve $bytes if the data is already present in $meta. This is how the same code in attachment_submitbox_metadata() already works. 
Props polevaultweb.
Fixes #33214.


git-svn-id: https://develop.svn.wordpress.org/trunk@34258 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-17 05:02:52 +00:00
Scott Taylor
79656b5fdd Uploader: Fire 'wp_handle_upload' in wp_upload_bits(). Thusly, the filter in wp_xmlrpc_server::mw_newMediaObject() is redundant. 
Props dllh.
Fixes #33539.


git-svn-id: https://develop.svn.wordpress.org/trunk@34257 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-17 04:46:00 +00:00
Scott Taylor
a1805ecada Media List Table: remove the counts from the "views" portion of the toolbar, which are inconsistent with grid view. Also reduces complexity and removes potentially expensive count query. 
Related to the toolbar view, remove the `wp_admin_canonical_url()` action in grid mode. Grid views that result from links from the list table view are lenses into the library and need to be indicated as such vs being a full attachment query.

Fixes #29744.


git-svn-id: https://develop.svn.wordpress.org/trunk@34256 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-17 02:29:22 +00:00
Scott Taylor
25710ecc67 In wp_mime_type_icon(), the length of the $wilds array varies depending on what is passed as $mime. Loop over $wilds instead of arbitrarily checking $wilds[0]. 
Adds unit tests.

Fixes #33012.



git-svn-id: https://develop.svn.wordpress.org/trunk@34255 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-17 00:36:12 +00:00
Scott Taylor
45c606576c Media JS: ensure that wp.media.frame (a static reference to the "current" Frame) is reset when a cached frame is opened. 
Fixes #33458.


git-svn-id: https://develop.svn.wordpress.org/trunk@34254 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-17 00:09:40 +00:00
Sergey Biryukov
54835433c5 Docs: Expand the $comment_approved argument description for 'comment_post' action. 
Props cfinke.
Fixes #33903.

git-svn-id: https://develop.svn.wordpress.org/trunk@34253 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 22:29:15 +00:00
Boone Gorges
03ec7cc107 Improve consistency of comment notification callback signatures. 
Both `wp_new_comment_notify_moderator()` and `wp_new_comment_notify_postauthor()`
now accept a single argument: `$comment_ID`.

Props SergeyBiryukov.
Fixes #33587.

git-svn-id: https://develop.svn.wordpress.org/trunk@34252 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 22:25:07 +00:00
Boone Gorges
de7c9b6015 Move new user notification emails to add_action() callbacks. 
When a new user is created in various places throughout the interface,
notifications are sent to the site admin and the new user. Previously, these
notifications were fired through direct calls to `wp_new_user_notification()`,
making it difficult to stop or modify the messages.

This changeset introduces a number of new action hooks in place of direct calls
to `wp_new_user_notification()`, and hooks the new wrapper function
`wp_send_new_user_notifications()` to these hooks.

Props dshanske, thomaswm, boonebgorges.
Fixes #33587.

git-svn-id: https://develop.svn.wordpress.org/trunk@34251 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 22:18:33 +00:00
Boone Gorges
d26b868870 Don't notify post authors about spam comments. 
[34106] moved post author notification to a hook, and in the process, missed
the 'spam' check. This changeset restores that check.

To make unit testing easier, the notification callbacks have been refactored
to return values: false when various conditions aren't met (eg, approved
comments should not trigger moderation emails), and the return value of the
`wp_notify_*()` function otherwise.

Props cfinke, kraftbj.
See #33587.

git-svn-id: https://develop.svn.wordpress.org/trunk@34250 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 21:59:16 +00:00
Sergey Biryukov
7c9c635a04 Add a missing Oxford comma on Export screen. 
Props juhise.
Fixes #33906.

git-svn-id: https://develop.svn.wordpress.org/trunk@34249 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 21:33:29 +00:00
Boone Gorges
c5f34cb4d0 Throw a notice when an invalid tax is passed to wp_insert_post(). 
Props jdgrimes.
Fixes #25477.

git-svn-id: https://develop.svn.wordpress.org/trunk@34248 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 19:24:51 +00:00
Boone Gorges
302e3d1116 Allow taxonomies to be non-public. 
[13216] introduced the 'public' argument for `register_taxonomy()`. This param
was used to set defaults for 'show_ui' and a number of other params, but it
never did anything itself.

With this changeset, taxonomies registered with `public=false` will no longer
be queryable on the front end, ie via taxonomy archive queries.

Props wpsmith, ocean90, nacin, ericlewis, boonebgorges.
Fixes #21949.

git-svn-id: https://develop.svn.wordpress.org/trunk@34247 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 19:04:57 +00:00
Boone Gorges
1b016b6dc6 Failed get_term_by() lookups should always return false. 
Previously, we sometimes returned `null`.

Props charlestonsw, tyxla.
Fixes #33281.

git-svn-id: https://develop.svn.wordpress.org/trunk@34246 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 18:49:28 +00:00
Scott Taylor
3ca5bbb585 Revert [33925], by-reference array manipulation is breaking comments in some themes. 
This implementation is losing its shine.

See #16894.


git-svn-id: https://develop.svn.wordpress.org/trunk@34245 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 18:13:19 +00:00
Scott Taylor
2d11d6cd90 After [34160], also upgrade objects passed to get_avatar(). 
See #32619.



git-svn-id: https://develop.svn.wordpress.org/trunk@34244 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 17:33:34 +00:00
Sergey Biryukov
45c6094dce Docs: Update the DocBlock for wp_page_menu() to include 'before', 'after', and 'walker' arguments added in [34200]. 
Align the `$defaults` array and include the default value for `'show_home'`.

Props stevegrunwell.
Fixes #11095.

git-svn-id: https://develop.svn.wordpress.org/trunk@34243 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 16:46:08 +00:00
Sergey Biryukov
10bc44d8fc Add register_post_type_args filter for changing register_post_type() arguments before further processing. 
Does not apply to built-in post types.

Props MikeSchinkel, nickciske, engelen, swissspidy.
Fixes #17447.

git-svn-id: https://develop.svn.wordpress.org/trunk@34242 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 15:46:14 +00:00
Scott Taylor
d2bb55ee92 wp-admin/includes/template.php is now a loader for 3 files made via svn cp: 
* `Walker_Category_Checklist` class
* `WP_Internal_Pointers` class
* `template-functions.php`

This is BC for plugins that are loading `wp-admin/includes/template.php` for fun.

See #33413.


git-svn-id: https://develop.svn.wordpress.org/trunk@34241 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 15:34:17 +00:00
Sergey Biryukov
d262ebca0a Docs: Synchronize the $timezone parameter description between get_lastpostdate(), get_lastpostmodified(), and _get_last_post_time(). 
See #17455.

git-svn-id: https://develop.svn.wordpress.org/trunk@34240 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 15:28:12 +00:00
Sergey Biryukov
9ab1dfd03e Docs: Fix some syntactical issues with the DocBlock for wp_mail_failed action, introduced in [34221]. 
Fixes #18926.

git-svn-id: https://develop.svn.wordpress.org/trunk@34239 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 15:12:42 +00:00
Sergey Biryukov
1d4b8ffd1d Docs: Expand the DocBlock for the WP_Theme::get_edit_link() method, introduced in [34084]. 
Fixes #32376.

git-svn-id: https://develop.svn.wordpress.org/trunk@34238 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 15:00:04 +00:00
Drew Jaynes
2b6dc75396 Docs: Add changelog entries for parameters where WP_Comment object support was added in [33961]. 
See #33638. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34237 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 13:51:13 +00:00
Drew Jaynes
c2d0a83330 Docs: Fix some syntactical issues with the DocBlock for the WP_Theme->update property, introduced in [33957]. 
Adds an `@since`.

See #33491. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34236 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 13:28:41 +00:00
Drew Jaynes
bb2fc0933d Docs: Add a changelog entry for the addition of 'wp-admin', 'wp-content', and 'wp-includes' as reserved names for the subdirectory_reserved_names filter docs. 
The new names were introduced in [33952].

See #33615. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34235 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 13:25:05 +00:00
Drew Jaynes
7682e433fc Docs: Put "it's" in its place (again). 
Props kitchin.
Fixes #33894.


git-svn-id: https://develop.svn.wordpress.org/trunk@34234 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 12:45:51 +00:00
Sergey Biryukov
c57efab4f4 Add a comment to strings where the ellipsis cannot be used due to json_encode(), placeholders, or external dependencies. 
Fixes #32875.

git-svn-id: https://develop.svn.wordpress.org/trunk@34233 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 11:58:41 +00:00
Sergey Biryukov
04c1c825e9 Reset Password: Move <div> out of <p> in wp-login.php. 
Props ldinclaux.
Fixes #33892.

git-svn-id: https://develop.svn.wordpress.org/trunk@34232 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 11:45:09 +00:00
Sergey Biryukov
557d160ca1 Comments: Fix a fatal error in Comments meta box after [34223]. 
Props tyxla.
Fixes #33893. See #33413.

git-svn-id: https://develop.svn.wordpress.org/trunk@34231 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 11:36:35 +00:00
Drew Jaynes
fea6142412 Docs: Make a minor adjustment to the description syntax for the optional $comment argument in the DocBlock for comment_link(), introduced in [34071]. 
See #33638. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34230 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 11:01:50 +00:00
Drew Jaynes
3b3a034c11 Docs: Remove markdown from the DocBlock summary for WP_List_Table::get_primary_column(), introduced in [34166]. 
The PHP inline documentation standards for [https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/php/#summary-formerly-short-description summaries] call for not using an markup or markdown. Also, using the full Class::method() in this context allows for better clarity in what is being referenced.

See #33854. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34229 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 10:50:21 +00:00
Drew Jaynes
f83abcbf3e Docs: Add a changelog entry for the switch to using wp_get_attachment_url() instead of the guid for determining the header image URL in Custom_Image_Header::step_3(). 
The change was introduced in [34188].

See #33319.


git-svn-id: https://develop.svn.wordpress.org/trunk@34228 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 10:42:08 +00:00
Drew Jaynes
ff35e34fad Docs: Improve documentation for the WP_Object_Cache class. 
Spaces out parameter documentation for readability, fixes some minor syntactical issues, and adds some missing `@access` tags or reorders tags according to the PHP docs standards.

Also, documents `&$found`, the fourth parameter for the `get()` method, and adds missing parameter and return descriptions for the `_exists()` utility method.

See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34227 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 10:02:20 +00:00
Drew Jaynes
1075ec80b8 Docs: Remove an errant change made to a _deprecated_function() call in wp_cache_reset() introduced in [34225]. 
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34226 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 09:41:51 +00:00
Drew Jaynes
741bd4440c Docs: Add more complete documentation for top-level object cache functionality. 
Adds some `@see` tags for corresponding `WP_Object_Cache` methods to DocBlocks for top-level functions. Also adds a standard description for the `@global` tags, spacing for parameter docs readability, and finally, properly marks optional parameters as such.

See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34225 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 09:39:33 +00:00
Drew Jaynes
f2eb739ea6 Docs: Add documentation for $object_id, the optional second parameter in current_user_can() and WP_User::has_cap(), and the optional third parameter in map_meta_cap(). 
This change introduces the vernacular of "meta" vs "primitive" capabilities to core docs, and providing examples for each inline and attempts to make it clear that `$object_id` is really only useful if the passed `$capability` is of the meta cap variety.

Props jliman for the initial patch.
Fixes #32694.


git-svn-id: https://develop.svn.wordpress.org/trunk@34224 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 07:35:37 +00:00
Scott Taylor
05cd237d5e Move WP_Post_Comments_List_Table to its own file. 
See #33413.


git-svn-id: https://develop.svn.wordpress.org/trunk@34223 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 06:52:35 +00:00
Sergey Biryukov
7e706c285b Fix a typo in wptexturize() and wp_replace_in_html_tags() comments. 
Props bobbingwide.
See #15694.

git-svn-id: https://develop.svn.wordpress.org/trunk@34222 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 05:53:09 +00:00
Aaron Jorbin
bf5f316668 Fire Action when mail exception is thrown. 
new action is wp_mail_failed which contains a WP_Error object with the phpmailerException code, message and an array with the mail information. Plugins can hook in and log when mails fail to send due to a phpmailer issue.

Props soulseekah
Fixes #18926



git-svn-id: https://develop.svn.wordpress.org/trunk@34221 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 23:50:30 +00:00
Weston Ruter
1975b0a084 Customizer: Smooth animation for closing accordions in the available nav menu items pane. 
Props tyxla.
Fixes #33360 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@34219 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 23:39:23 +00:00
Boone Gorges
0adb6877b2 Improve validation of user_login and user_nicename length. 
The `user_login` field only allows 60 characters, and `user_nicename` allows
50. However, there are no protections in the interface, and few in the code,
that prevent the creation of users with values in excess of these limits. Prior
to recent changes in `$wpdb`, users were generally created anyway, MySQL
having performed the necessary truncation. More recently, the `INSERT`s and
`UPDATE`s simply fail, with no real feedback on the nature of the failure.

This changeset addresses the issue in a number of ways:
* On the user-new.php and network/user-new.php panels, don't allow input in excess of the maximum field length.
* In `wp_insert_user()`, throw an error if the value provided for `'user_login'` or `'user_nicename'` exceeds the maximum field length.
* In `wp_insert_user()`, when using `'user_login'` to generate a default value for `'user_nicename'`, ensure that the nicename is properly truncated, even when suffixed for uniqueness (username-2, etc).

Props dipesh.kakadiya, utkarshpatel, tommarshall, boonebgorges.
Fixes #33793.

git-svn-id: https://develop.svn.wordpress.org/trunk@34218 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 22:13:51 +00:00
Boone Gorges
2d59d18e3a Omit the ORDER BY clause when updating object term cache. 
The `ORDER BY` clause was forcing filesorts on large tables, and is
unnecessary, since term order doesn't matter when updating the cache.

Props mbrandys, wonderboymusic.
Fixes #28922.

git-svn-id: https://develop.svn.wordpress.org/trunk@34217 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 20:52:40 +00:00
Scott Taylor
e05586646a Apply the new 'respond_link' filter in comments_popup_link() if $number is 0 before outputting the URL. 
Props joedolson.
Fixes #29454.


git-svn-id: https://develop.svn.wordpress.org/trunk@34216 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 20:45:32 +00:00
Scott Taylor
28426c041c In WP::parse_request(), don't add query vars of non-viewable post types to WP::public_query_vars. In register_post_type(), don't add query vars of non-viewable post types to WP::public_query_vars. 
In `_unregister_post_type()` (unit tests), don't add query vars of non-viewable post types to `WP::public_query_vars`.

Adds unit test.

Fixes #30018.


git-svn-id: https://develop.svn.wordpress.org/trunk@34215 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 18:53:12 +00:00
John Blackbourn
1a352d56f9 Implement wp_login_url() and wp_registration_url() in places where wp-login.php is currently hard-coded. 
See #31495
Props GregLone


git-svn-id: https://develop.svn.wordpress.org/trunk@34213 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 17:10:24 +00:00
Scott Taylor
7b93c40830 WP_Comment_Query: add comment__in to allowed values for $orderby. 
Adds unit tests.

Fixes #33883.


git-svn-id: https://develop.svn.wordpress.org/trunk@34212 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 16:34:14 +00:00
Scott Taylor
72bc9d3227 Add parent__in and parent__not_in query vars to WP_Comment_Query. 
Adds unit tests.

Fixes #33882.


git-svn-id: https://develop.svn.wordpress.org/trunk@34205 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 16:22:34 +00:00
Drew Jaynes
f48d395ffb Docs: Update the hook doc summary for the wp_http_ixr_client_headers filter, introduced in [34164]. 
The idea is to try to reflect what the filterable value is rather than why it's filterable.

Fixes #24598.


git-svn-id: https://develop.svn.wordpress.org/trunk@34203 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 16:15:39 +00:00
wonderboymusic
2a1ee1a235 Don't redirect to the Term list table after submitting the form on the Edit Term page. 
Props chiragswadia, UmeshSingla, rhyswynne, afercia.
Fixes #17455.


git-svn-id: https://develop.svn.wordpress.org/trunk@34202 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 15:58:04 +00:00
Scott Taylor
8fc44f8c39 Allow get_lastpostdate(), get_lastpostmodified(), and _get_last_post_time() to accept $post_type and cache separately. 
Props _duck, SergeyBiryukov.
See #17455.


git-svn-id: https://develop.svn.wordpress.org/trunk@34201 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 15:24:04 +00:00
Scott Taylor
b5b07ca329 Allow wp_page_menu() to accept 'walker', 'before', and 'after' to allow custom markup. 
Fixes #11095.


git-svn-id: https://develop.svn.wordpress.org/trunk@34200 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 15:05:34 +00:00
Scott Taylor
acbeef27b9 Similar to #33386, don't use guid when retrieving URL for a cropped header image in the Customizer. 
Props polevaultweb.
Fixes #33319.


git-svn-id: https://develop.svn.wordpress.org/trunk@34188 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 14:45:59 +00:00
Sergey Biryukov
87d6be5991 Comments: When setting the colspan value for inline edit/reply, make sure it's actually a table and the value is not empty. 
Props afercia.
Fixes #33596.

git-svn-id: https://develop.svn.wordpress.org/trunk@34179 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 13:43:28 +00:00
John Blackbourn
b8349f8222 Remove outdated references to the preview_post_link filter docs. 
See #24345
Props paulwilde


git-svn-id: https://develop.svn.wordpress.org/trunk@34178 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 10:31:40 +00:00
John Blackbourn
a923d36085 Remove the ability to view the post listing screen and post editing screen for post types with show_ui set to false. It is unexpected and unintended behaviour that this is allowed. 
If your plugin or site does rely on this behaviour, the arguments that are passed to `register_post_type()` should be altered so that `show_ui` is `true`, and arguments such as `show_in_menu`, `show_in_nav_menus`, and `show_in_admin_bar` are `false`.

Fixes #33763
Props swissspidy, johnbillion


git-svn-id: https://develop.svn.wordpress.org/trunk@34177 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 10:26:22 +00:00
John Blackbourn
9b836740c3 Improve the docblocks for the get_preview_post_link() function and the preview_post_link filter. 
See #24345


git-svn-id: https://develop.svn.wordpress.org/trunk@34176 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 08:24:54 +00:00
John Blackbourn
47a66713ae Correct the value of the preview query variable added by get_preview_post_link(). 
See #24345
Props kitchin


git-svn-id: https://develop.svn.wordpress.org/trunk@34175 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 08:15:22 +00:00
John Blackbourn
c0c2a76778 Place the filter docblock for http_api_transports immediately above the filter. 
See #33413
Props dd32


git-svn-id: https://develop.svn.wordpress.org/trunk@34174 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 08:11:11 +00:00
Scott Taylor
c95d6b3ec8 Use get_attached_file() in attachment_submitbox_metadata(). 
Props kitchin.
Fixes #33386.


git-svn-id: https://develop.svn.wordpress.org/trunk@34171 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 04:17:38 +00:00
Scott Taylor
c0d850878a Create a function, get_preview_post_link(), to DRY the logic for applying the 'preview_post_link' filter to a URL. 
Props TomHarrigan, wonderboymusic.
Fixes #24345.


git-svn-id: https://develop.svn.wordpress.org/trunk@34170 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 04:14:23 +00:00
Scott Taylor
ac610c191b Move WP_Screen to its own file. 
See #33413.


git-svn-id: https://develop.svn.wordpress.org/trunk@34169 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 04:07:14 +00:00
Scott Taylor
26ab36f909 Move the admin Nav Menu Walker subclasses into their own files. Load in nav-menu.php to remain BC. 
See #33413.


git-svn-id: https://develop.svn.wordpress.org/trunk@34168 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 04:01:30 +00:00
Scott Taylor
c702a71ad1 Update post thumbnail functions to allow a WP_Post to be passed. 
Adds unit tests.

Props swissspidy, Rahe.
Fixes #33723.


git-svn-id: https://develop.svn.wordpress.org/trunk@34167 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 03:45:23 +00:00
Scott Taylor
1a537a4f6d Add a doc block to WP_List_Table::get_primary_column(). 
Fixes #33854.


git-svn-id: https://develop.svn.wordpress.org/trunk@34166 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 03:34:44 +00:00
Scott Taylor
8df7bd75b6 Ensure that widget carets close when dragging an expanded widget. 
Props sdavis2702, mindctrl.
Fixes #33578.


git-svn-id: https://develop.svn.wordpress.org/trunk@34165 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 03:09:35 +00:00
Scott Taylor
030747e429 Add a filter to allow custom headers to be sent via the WP HTTP IXR client: 'wp_http_ixr_client_headers'. 
Props ericmann.
Fixes #24598.


git-svn-id: https://develop.svn.wordpress.org/trunk@34164 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 02:53:18 +00:00
Scott Taylor
577fea566a Don't ever use the guid value when retrieving URLs for media, use wp_get_attachment_url(). Use get_attached_file() for path to file. 
Fixes #33386.


git-svn-id: https://develop.svn.wordpress.org/trunk@34163 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 02:49:12 +00:00
Scott Taylor
337451b099 TwentyFifteen|Sixteen themes have a <div id="content"> in the header. Change the <div> IDs in wp-activate.php and wp-signup.php to be unique to each page. 
Props jfarthing84.
Fixes #33843.


git-svn-id: https://develop.svn.wordpress.org/trunk@34162 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 02:08:07 +00:00
Scott Taylor
5c85369bb6 In _wp_ajax_delete_comment_response(), read the new 'all' prop returned by get_comment_count() via wp_count_comments() when setting $total. 'all' doesn't include spam in its count. 
Updates unit tests.

Props dipesh.kakadiya.
Fixes #32362.


git-svn-id: https://develop.svn.wordpress.org/trunk@34161 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 01:46:51 +00:00
Scott Taylor
2817bb6557 In get_avatar_data(), promote stdClass objects to WP_Comment if passed. 
Props DrewAPicture, ocean90.
Fixes #32619.


git-svn-id: https://develop.svn.wordpress.org/trunk@34160 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 01:33:29 +00:00
Scott Taylor
5168b2e303 After [34070], account for the new ID in Quick Edit JS. 
Props afercia.
Fixes #33770.


git-svn-id: https://develop.svn.wordpress.org/trunk@34159 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 01:30:36 +00:00
Scott Taylor
95795c1301 More bonkers comment cache cleanup: toggle wp_defer_comment_counting() in wp_insert_post() and wp_insert_attachment(). Move the cache deletion in wp_update_comment_count_now() to before the get_post() call, so that the caches get deleted even if the post has already been deleted and the function returns early. 
See #33875.


git-svn-id: https://develop.svn.wordpress.org/trunk@34158 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 00:57:48 +00:00
Scott Taylor
8cb6843170 Ensure that the count cache for all is in sync with comment-{$post_id} values. These are the values most often relied-upon by the list table for comments. 
Adds unit tests.

See #33875.


git-svn-id: https://develop.svn.wordpress.org/trunk@34136 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-14 22:38:02 +00:00
Dominik Schilling (ocean90)
354000b5ca XMLRPC: Don't allow private posts to be sticky. 
See #20662.

git-svn-id: https://develop.svn.wordpress.org/trunk@34135 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-14 22:37:21 +00:00
Nikolay Bachiyski
c430a82236 Shortcodes: don't allow unclosed HTML elements in attributes 
git-svn-id: https://develop.svn.wordpress.org/trunk@34134 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-14 22:35:22 +00:00
Nikolay Bachiyski
1541d43033 List tables: escape user e-mails 
Better safe than sorry.


git-svn-id: https://develop.svn.wordpress.org/trunk@34133 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-14 22:32:52 +00:00
Scott Taylor
a9e1f79323 In the edit-comments.php admin handler, toggle wp_defer_comment_counting() so that only unique post IDs have their comment count updated. Currently, if you delete 50 comments from the same post, the count would get reset 50 times. Not joking. 
See #33875.


git-svn-id: https://develop.svn.wordpress.org/trunk@34132 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-14 22:23:43 +00:00
Scott Taylor
545da32217 The "counts" cache for comments by post id is never invalidated. Neither wp_update_comment_count() nor wp_update_comment_count_now() touch the cache. 
Adds unit test.
See #33875.


git-svn-id: https://develop.svn.wordpress.org/trunk@34131 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-14 22:03:23 +00:00
Scott Taylor
b42a906512 wp_unspam_comment() can accept a full object instead of comment_ID to reduce cache/db lookups.. 
See #33638.


git-svn-id: https://develop.svn.wordpress.org/trunk@34130 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-14 21:46:40 +00:00
Scott Taylor
166ee8674b More comment functions can accept a full object instead of comment_ID to reduce cache/db lookups. 
See ##33638.



git-svn-id: https://develop.svn.wordpress.org/trunk@34129 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-14 21:39:46 +00:00
Scott Taylor
ab7ca361dd In WP_List_Table, make a new public method, ->get_primary_column(), and revert [34101] due to BC issues. 
Fixes #33854.


git-svn-id: https://develop.svn.wordpress.org/trunk@34128 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-14 20:28:29 +00:00
Scott Taylor
ea610e66d4 In WP_Media_List_Table, fetch all pending comment counts at once, instead of for each row in the loop. 
See #11381.


git-svn-id: https://develop.svn.wordpress.org/trunk@34127 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-14 19:24:59 +00:00
Boone Gorges
974517d2bc Accept 'ID' as a valid $field in get_user_by(). 
We already accept 'id'. `ID` more closely matches the database and
`WP_User` schemas.

Props Shelob9.
Fixes #33869.

git-svn-id: https://develop.svn.wordpress.org/trunk@34125 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-14 18:57:15 +00:00
John Blackbourn
9700eb511e Add the site icon meta tags to wp-login.php. 
See #33597
Props iworks


git-svn-id: https://develop.svn.wordpress.org/trunk@34124 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-14 18:01:22 +00:00
Scott Taylor
2c91a4d1e0 Fix the case-sensitivity of some HTTP class usage. 
See #33413.


git-svn-id: https://develop.svn.wordpress.org/trunk@34123 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-14 17:36:37 +00:00
John Blackbourn
811e538325 Update links to the user profile editing screen in the admin toolbar when the current logged in user has no role on the current site. Covers single site and Multisite and introduces tests. 
Fixes #25162


git-svn-id: https://develop.svn.wordpress.org/trunk@34122 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-14 17:09:58 +00:00
Drew Jaynes
112a84fe93 Docs: Add missing parameter and return descriptions for Walker::get_number_of_root_elements(). 
Fixes #33662.


git-svn-id: https://develop.svn.wordpress.org/trunk@34121 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-14 15:32:46 +00:00
Sergey Biryukov
13382740b9 Escape class attribute in edit_post_link() after [34098]. 
Props Offereins.
See #30563.

git-svn-id: https://develop.svn.wordpress.org/trunk@34117 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-14 13:00:31 +00:00
Dominik Schilling (ocean90)
08098026ce Passwords: Deprecate second parameter of wp_new_user_notification(). 
The second parameter `$plaintext_pass` was removed in [33023] and restored as `$notify` in [33620] with a different behavior. If you have a plugin overriding `wp_new_user_notification()` which hasn't been updated you would get a notification with your username and the password "both".
To prevent this the second parameter is now deprecated and reintroduced as the third parameter.

Adds unit tests.

Props kraftbj, adamsilverstein, welcher, ocean90.
Fixes #33654.

(Don't ask for new pluggables kthxbye)

git-svn-id: https://develop.svn.wordpress.org/trunk@34116 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-14 12:42:34 +00:00
Sergey Biryukov
217c84e613 Docs: Add a changelog entry for the $class argument added to edit_post_link() in [34098]. 
Fixes #30563.

git-svn-id: https://develop.svn.wordpress.org/trunk@34115 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-14 12:19:55 +00:00
Dominik Schilling (ocean90)
0a77429937 Passwords: Trigger a wp-check-valid-field event when the password field is filled with a password by generatePassword(). 
Updates event handler in `wpAjax.invalidateForm()` to support `wp-check-valid-field`.

See #33406.

git-svn-id: https://develop.svn.wordpress.org/trunk@34114 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-14 10:38:32 +00:00
Scott Taylor
c16e8b5616 Add sanity checks in map_meta_cap(), return 'do_not_allow' when posts don't exist. 
Adds unit test.

Props ocean90, nerrad, filosofo.
Fixes #23162.


git-svn-id: https://develop.svn.wordpress.org/trunk@34113 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-14 04:43:48 +00:00
Boone Gorges
5a6f66faad Send multisite site/user signup emails via hooked functions. 
Site and user signup notifications are moved to the new actions
`'after_signup_site'` and `'after_signup_user'`. Site and user activation
notifications are moved to the existing actions `'wpmu_activate_blog'` and
`'wpmu_activate_user'`.

Props dshanske, thomaswm, jeremyfelt.
See #33587..

git-svn-id: https://develop.svn.wordpress.org/trunk@34112 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-14 03:27:47 +00:00
Scott Taylor
a6a03da7f5 Add an argument to parent_dropdown(), $post, to allow it to be called for an arbitrary post. 
Fixes #23162.


git-svn-id: https://develop.svn.wordpress.org/trunk@34111 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-14 03:19:59 +00:00
Scott Taylor
adfd136bee Move Walker_Category and Walker_CategoryDropdown into their own files via svn cp. Remove them from category-template.php. Load them in category.php. svn cp category.php over to category-functions.php, which also loads now in category.php. 
See #33413.


git-svn-id: https://develop.svn.wordpress.org/trunk@34110 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-14 03:09:37 +00:00
Scott Taylor
1ccae571d9 Move Walker_Page and Walker_PageDropdown into their own files via svn cp. Remove them from post-template.php. Load them in post.php. 
`post-template.php` loads after `post.php` in `wp-settings.php`. It could probably also be loaded in `post.php`, but avoiding that for the moment.

See #33413.


git-svn-id: https://develop.svn.wordpress.org/trunk@34109 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-14 02:58:40 +00:00
Scott Taylor
2d5945f0fc In wp_link_pages(), ensure that $prev is greater than 0. 
Props betzster.
Fixes #25273.


git-svn-id: https://develop.svn.wordpress.org/trunk@34108 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-14 02:45:33 +00:00
Boone Gorges
6064924c18 Send password-change email notifications via hook. 
`wp_password_change_notification()` is now called at the 'after_password_reset'
action, rather than being invoked directly from the `reset_password()` function.

In order to make it possible to call `wp_password_change_notification()` as a
`do_action()` callback, the function signature has to be changed so that the
`$user` parameter is expected to be a value rather than a reference. Since
PHP 5.0, objects are passed by reference, so `&$user` was unnecessary anyway.

Props dshanske, thomaswm.
See #33587.

git-svn-id: https://develop.svn.wordpress.org/trunk@34107 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-14 02:44:41 +00:00
boonebgorges
05d4233956 Send comment notification emails via a hooked function. 
Previously, `wp_notify_postauthor()` and `wp_notify_moderator()` were called
directly from `wp_new_comment()`, making it difficult to modify or suppress
default notification emails.

Props dshanske, thomaswm.
See #33587.

git-svn-id: https://develop.svn.wordpress.org/trunk@34106 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-14 02:16:02 +00:00
Scott Taylor
a620cd1e34 Turn off autocomplete for the new-post-slug field. 
Props johnbillion.
Fixes #32752.


git-svn-id: https://develop.svn.wordpress.org/trunk@34105 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-14 02:02:58 +00:00
Dion Hulse
9555882e90 When running on windows systems, normalise the capitalisation of the drive letter for more reliable string comparisons. 
Props tyxla
Fixes #33265


git-svn-id: https://develop.svn.wordpress.org/trunk@34104 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-14 01:58:03 +00:00
Scott Taylor
b52b5893c4 Pass $r and $pages to the 'wp_dropdown_pages' and 'wp_list_pages' filters. 
Props bigdawggi, SergeyBiryukov.
Fixes #23734.


git-svn-id: https://develop.svn.wordpress.org/trunk@34103 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-14 01:31:12 +00:00
Scott Taylor
184e058681 Objects are passed by-reference since PHP 5. In _get_custom_object_labels(), cast $object->labels back to object before returning. This function is weird. 
Adds unit test.

Props Toro_Unit.
Fixes #33023.


git-svn-id: https://develop.svn.wordpress.org/trunk@34102 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-14 01:22:23 +00:00
Scott Taylor
5a93988ca3 Make WP_List_Table::get_primary_column_name() public in list table classes that have it. 
Fixes #33854.


git-svn-id: https://develop.svn.wordpress.org/trunk@34101 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-14 01:11:44 +00:00
Scott Taylor
5d0bc76040 Check if the $post_type passed to get_post_type_object() is a scalar value. Non-scalars were producing PHP warnings. 
Adds unit tests.

Props Kloon.
Fixes #30013.


git-svn-id: https://develop.svn.wordpress.org/trunk@34100 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-14 00:02:05 +00:00
Jeremy Felt
13dd966554 Multisite: Implement the get_by_path method in WP_Network. 
Move the internals of `get_network_by_path()` to `WP_Network()` and allow network objects to be retrieved by passing a requested domain and path.

Props johnjamesjacoby, jeremyfelt, drewapicture, wonderboymusic.
See #31985.


git-svn-id: https://develop.svn.wordpress.org/trunk@34099 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-13 23:39:20 +00:00
Scott Taylor
f20622f394 In edit_post_link(), add an argument for the class attribute that defaults to post-edit-link. 
Props voldemortensen.
Fixes #30563.


git-svn-id: https://develop.svn.wordpress.org/trunk@34098 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-13 23:33:30 +00:00
Jeremy Felt
591a9aa73c Multisite: Introduce the WP_Network class. 
A `WP_Network` object initially matches a row from `wp_site` and is populated with additional properties used by WordPress core. The first iteration is used to retrieve an existing network based on data passed to the class.

* A network can be retrieved by its ID through `WP_Network::get_instance()`, following in the steps of `WP_Post` and `WP_Comment`.
* A network object can be created or completed by passing initial properties in as a standard object to `new WP_Network()`.

Using these methods, we are now able to populate the global `$current_site` during load via this class.

Props johnjamesjacoby, jeremyfelt, drewapicture, wonderboymusic.
See #31985.


git-svn-id: https://develop.svn.wordpress.org/trunk@34097 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-13 23:30:57 +00:00
Andrea Fercia
34c6893080 Bump H3 headings to H2 on the Writing Settings screen for better accessibility. 
Props mrahmadawais.
Fixes #33651.

git-svn-id: https://develop.svn.wordpress.org/trunk@34096 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-13 16:47:54 +00:00
Helen Hou-Sandi
379dd889c1 Comments: Fix inline edit/reply on small screens. 
props ocean90, SergeyBiryukov.
fixes #33596.


git-svn-id: https://develop.svn.wordpress.org/trunk@34094 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-13 12:46:03 +00:00
Weston Ruter
fd1dbfe003 Customize: Remove redundant aria-label attributes. 
Adds an `$options` array argument to `WP_Screen::render_screen_options()` to allow the `div#screen-options-wrap` element to be omitted when `wrap` value is `false`.

Props afercia, westonruter.
Fixes #33182.


git-svn-id: https://develop.svn.wordpress.org/trunk@34093 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-13 06:15:42 +00:00
Boone Gorges
829ae5f4ce Fail gracefully when checking mapped cap against unregistered post type. 
Post type objects are reponsible for mapping their capabilities to core caps.
As a result, when the post type is no longer registered, the caps are no
longer mapped. This causes problems when a post is left in the database after
the post type is no longer present, and WP does an 'edit_post' or other cap
check against it: a PHP notice is thrown, and the cap check always fails.

As a more graceful fallback, we map all post-type-dependent caps onto
'edit_others_posts', which allows highly privileged users to be able to
access orphaned content (such as comments belonging to disabled post types),
while minimizing the possibility of unintended privilege escalation.

We also add a `_doing_it_wrong()` notice, so that developers and site
administrators are aware that the cap mapping is failing in the absence of
the registered post type.

Props mitchoyoshitaka, DrewAPicture, imath, codeelite, boonebgorges, nofearinc, SergeyBiryukov, jorbin, dlh.
Fixes #16956.

git-svn-id: https://develop.svn.wordpress.org/trunk@34091 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-12 21:26:57 +00:00
Boone Gorges
4fdfdb6078 Use stricter sanitization for meta query clause keys. 
By forcing all clause keys to be strings, we make it possible to use strict
comparison when validating values of 'orderby' as passed to `WP_Query`. This
eliminates situations where the presence of numeric clause keys could result
in an improperly validated 'orderby' value.

Props nikolov.tmw.
Fixes #32937.

git-svn-id: https://develop.svn.wordpress.org/trunk@34090 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-12 21:05:14 +00:00
Boone Gorges
dcbd8c6c3d Allow setup_postdata() to accept a post ID. 
Previously, it accepted only a full post object.

Props sc0ttclark, mordauk, wonderboymusic.
Fixes #30970.

git-svn-id: https://develop.svn.wordpress.org/trunk@34089 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-12 20:57:06 +00:00
Boone Gorges
4ebab4dc16 Remove extraneous table join in get_adjacent_post(). 
Since [29248], a table join has not been necessary to process the
`$excluded_terms` parameter of `get_adjacent_post()`. Aside from adding extra
overhead, this join meant that post records that don't have any corresponding
rows in `wp_term_relationships` were erroneously excluded from results.

Fixes #32833.

git-svn-id: https://develop.svn.wordpress.org/trunk@34088 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-12 20:33:07 +00:00
Dominik Schilling (ocean90)
ed36c88b73 Revert [34013] and parts of [33970]. 
* `_WP_Editors::wp_mce_translation()` can't be changed without changing strings in TinyMCE and plugins.
* `\u2026` is escaped by `json_encode()` to `\\u2026`, makes `\u2026` visible in our UI.

See #32875.

git-svn-id: https://develop.svn.wordpress.org/trunk@34087 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-12 20:02:43 +00:00
Dominik Schilling (ocean90)
07ea6a2334 Themes: Don't use HTML entities for placeholders. 
See #32875.

git-svn-id: https://develop.svn.wordpress.org/trunk@34086 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-12 19:47:53 +00:00
Scott Taylor
db3a7133f2 In wp_insert_post(), when setting $post_author, use isset() instead of ! empty() to allow 0 to be passed as the value for $post_author. 
Adds unit tests.

Props ericdaams, wonderboymusic.
Fixes #32585.


git-svn-id: https://develop.svn.wordpress.org/trunk@34085 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-12 18:53:56 +00:00
Scott Taylor
ad20c3db4a WP_Posts_List_Table: there are a cadre of edit.php URLs that are generated by string-building instead of using our handy functions. Create a helper method, ->get_edit_link() that standardizes the generation and escaping of these URLs. 
Props BdN3504 for the initial patch on the ticket.
Fixes #32376.


git-svn-id: https://develop.svn.wordpress.org/trunk@34084 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-12 17:12:25 +00:00
Scott Taylor
2a72a1f959 Use table-layout: auto (instead of fixed) on table.fixed to ensure that things like date/time don't horrendously wrap on small screens. Before/After screenshots attached to the ticket. 
Props gaelan.
Fixes #32691.


git-svn-id: https://develop.svn.wordpress.org/trunk@34083 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-12 16:03:17 +00:00
Scott Taylor
9eb5abbccb wp_delete_post(): add a filter, 'pre_delete_post', to allow bailout from the function if the filter returns a non-null value. 
Props boonebgorges.
Fixes #32933.


git-svn-id: https://develop.svn.wordpress.org/trunk@34082 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-12 15:58:09 +00:00
Scott Taylor
8ef82f4792 sanitize_post(): the default value for $context is 'display'. The documentation says the default for sanitize_post_field() is 'display', but there is no default for the arg. Make the argument: $context = 'default'. 
Props morganestes.
Fixes #33117.


git-svn-id: https://develop.svn.wordpress.org/trunk@34081 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-12 15:45:15 +00:00
Scott Taylor
0b8101849e sanitize_post() is polymorphic, add an is_array() check for $post before operating on it as an array. 
Props morganestes.
Fixes #33118.


git-svn-id: https://develop.svn.wordpress.org/trunk@34080 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-12 15:37:50 +00:00
Dominik Schilling (ocean90)
250c8a0224 Bundled Themes: Update Tested up to. 
Props mercime.
Fixes #33794.

git-svn-id: https://develop.svn.wordpress.org/trunk@34079 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-12 12:46:26 +00:00
Scott Taylor
faf87c2ca6 After [34076], fix the logic for post_status in months dropdown. 
See #21015.


git-svn-id: https://develop.svn.wordpress.org/trunk@34077 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-12 08:18:18 +00:00
Scott Taylor
927ad00bab List Tables: don't render "extra tablenav" if there are no posts. This includes Bulk Actions, Dates Dropdown, Category Dropdowns, Pagination. 
Also ensure that the Months dropdown, when it is shown, shows months from the proper set of posts.

Props egower, CoenJacobs, MikeHansenMe, mehulkaklotar.
Fixes #33824, #21015, #21856.


git-svn-id: https://develop.svn.wordpress.org/trunk@34076 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-12 08:12:43 +00:00
Scott Taylor
b76864660c Comments: get_comments_link() should return a link with #respond as the hash instead of #comments if get_comments_number() returns 0. 
Props cgrymala, wonderboymusic.
Fixes #19893.


git-svn-id: https://develop.svn.wordpress.org/trunk@34075 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-12 07:35:05 +00:00
Scott Taylor
9831fa216c AJAX Reply to Comment: check the edit_comment cap when parent comment will be auto-approved. 
Props rachelbaker.
Fixes #23939.


git-svn-id: https://develop.svn.wordpress.org/trunk@34074 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-12 07:18:36 +00:00
Boone Gorges
b7c8dbf4a2 Better default values in WP_Query::get_queried_object(). 
Setting the default value of the `queried_object_id` property to `0` meant
that, when called early enough in the WP bootstrap, `get_queried_object()`
could short-circuit the normal query by fooling it into thinking that the
request was for a page with id 0. Setting the default value to `null` instead
avoids this problem.

Props gradyetc, jazbek.
Fixes #31355.

git-svn-id: https://develop.svn.wordpress.org/trunk@34073 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-12 03:36:12 +00:00
Scott Taylor
3cbec930bb Edit Comment screen: remove the "View Comment" button (actually a link) from the publish meta box. Mimic the "Edit URL/Permalink" UI from the Edit Post screen to show the comment link below the screen title, but make it an actual link, not a button. 
Props ocean90, DrewAPicture, wonderboymusic.
Fixes #19168.


git-svn-id: https://develop.svn.wordpress.org/trunk@34072 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-12 03:19:21 +00:00
Scott Taylor
dd55363884 Comments: comment_link() currently takes no arguments, yet get_comment_link() does. Allow comment_link() to optionally take the same arguments. 
See #33638.


git-svn-id: https://develop.svn.wordpress.org/trunk@34071 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-12 03:15:14 +00:00
Scott Taylor
6a262bd6ce Quick Edit: fix an ID attribute name collision by renaming one of the author fields author-name. 
Props afercia.
Fixes #33770.


git-svn-id: https://develop.svn.wordpress.org/trunk@34070 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-12 02:34:52 +00:00
Scott Taylor
0f2078bc9e When clicking "Show More Comments" in the Comments meta box on the Edit Post screen, change the click behavior to call a new class method on commentsBox, ->load(), that resets st (cool name) to the number of visible <tr>s before calling ->get(). This will account for spam'd and trash'd comments when returning comments at the proper offset. 
Props utkarshpatel.
Fixes #33829.


git-svn-id: https://develop.svn.wordpress.org/trunk@34069 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-12 02:27:50 +00:00
Andrew Ozz
f855ddb134 Settings, password field: fix placement of the error icon and removal of the error class. 
Props liljimmi, adamsilverstein.
Fixes #33406 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@34068 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-12 00:09:09 +00:00
Andrea Fercia
1a333bd537 Bump H3 headings to H2 on the Plugin Editor screen for better accessibility. 
Fixes #33839.

git-svn-id: https://develop.svn.wordpress.org/trunk@34067 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-12 00:07:23 +00:00
Andrea Fercia
41c74b9bf6 Bump H3 headings to H2 on the Theme Editor screen for better accessibility. 
Props mrahmadawais.
Fixes #33660.

git-svn-id: https://develop.svn.wordpress.org/trunk@34066 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-11 23:59:30 +00:00
Andrea Fercia
c492832e6a Nav Menus: fix the quick search spinner position on Operating Systems that show scrollbars. 
Fixes #33290.

git-svn-id: https://develop.svn.wordpress.org/trunk@34065 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-11 23:51:53 +00:00
Andrea Fercia
bc8e3599e6 Quick Edit: fix the Tags auto-suggest tooltip visibility. 
Be sure to hide the `jquery.suggest` Tags textarea tooltip also when using the keyboard to Save/Cancel.

Props rommelxcastro for the initial patch.
Fixes #32580.

git-svn-id: https://develop.svn.wordpress.org/trunk@34064 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-11 23:33:43 +00:00
Andrew Ozz
e5324c4c91 Settings: properly set the password field label on loading. 
See #33778.

git-svn-id: https://develop.svn.wordpress.org/trunk@34062 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-11 23:04:53 +00:00
Andrew Ozz
504d75e4c1 Settings: reassign the label when switching password fields so it always highlights the visible field. 
Props umesh.nevase.
Fixes #33778 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@34061 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-11 22:51:17 +00:00
Dominik Schilling (ocean90)
28c4ddae7c Passwords: Refresh password fields when content is pasted into fields. 
Use feature detection to determine whether password inputs should use the `keyup` or `input` event.

Props peterwilsoncc, adamsilverstein.
Fixes #33398.

git-svn-id: https://develop.svn.wordpress.org/trunk@34060 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-11 21:51:31 +00:00
Scott Taylor
33953cb392 Introduce wp_validate_action( $action = '' ), a helper function that checks $_REQUEST for action and returns it, or empty string if not present. If $action is passed, it checks to make sure they match before returning it, or an empty string. Strings are always returned to avoid returning multiple types. 
Implementing this removes 27 uses of direct superglobal access in the admin.

For more reading:
https://codeclimate.com/github/WordPress/WordPress/wp-admin/edit-comments.php

See #33837.


git-svn-id: https://develop.svn.wordpress.org/trunk@34059 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-11 21:07:45 +00:00