Commit Graph

20679 Commits

Author SHA1 Message Date
Daryl Koopersmith 223eb63b6f Media: Restore 3.4 editor behavior and remove TinyMCE views.
* Reactivates the `wpgallery` and `wpeditimage` TinyMCE plugins. Deactivates the `wpviews` TinyMCE plugin.
* Moves still-relevant logic from `mce-views.js` to `media-upload.js` and `shortcode.js`.
* No longer include `wp-includes/js/mce-views.js`. This code will not be used in 3.5, and should be considered unstable.
* Currently, this is the real 3.4 experience; as such, editing triggers the old modals. Changing this is the next major step.

When reassessing views, we should look over all of these tickets and anticipate these bugs accordingly.

fixes #21813, #22123, #22155, #22161, #22257, #22266, #22318, #22407, see #21390.


git-svn-id: https://develop.svn.wordpress.org/trunk@22567 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-14 07:17:22 +00:00
Andrew Nacin 92d7e9db15 Pass 'blank' to Gravatar rather than sending blank.gif for Gravatar to proxy. props miqrogroove, fixes #22354.
git-svn-id: https://develop.svn.wordpress.org/trunk@22566 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-14 05:29:56 +00:00
Andrew Nacin 5de1543fc4 Avoid notices with [22426]. props pross. fixes #22420.
git-svn-id: https://develop.svn.wordpress.org/trunk@22565 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-14 05:09:23 +00:00
Andrew Nacin 24e95b5bd9 Pass the post ID from the_shortlink() to wp_get_shortlink() to avoid a change in filters. props SergeyBiryukov, fixes #21309.
git-svn-id: https://develop.svn.wordpress.org/trunk@22564 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-14 05:05:34 +00:00
Andrew Nacin 3841bfba82 Revert accordion-delay code from [22400] that was causing problems. props lessbloat. fixes #21283.
git-svn-id: https://develop.svn.wordpress.org/trunk@22563 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-14 05:03:33 +00:00
Andrew Nacin a861d88597 Sharper HiDPI alignment icons for TinyMCE. props lessbloat. fixes #22431.
git-svn-id: https://develop.svn.wordpress.org/trunk@22562 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-14 03:41:47 +00:00
Daryl Koopersmith c77d7b96db Media: Activate the featured image toolbar when the media dialog is first opened. see #21390, #21776.
git-svn-id: https://develop.svn.wordpress.org/trunk@22561 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-14 02:39:54 +00:00
Mark Jaquith ebe8d3e08f Squash a PHP notice in the XML-RPC server.
git-svn-id: https://develop.svn.wordpress.org/trunk@22560 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-13 22:35:41 +00:00
Andrew Nacin f3fac2add3 3.5-beta3
git-svn-id: https://develop.svn.wordpress.org/trunk@22559 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-13 04:06:51 +00:00
Daryl Koopersmith b7395456eb Media: Better image detection in the embed from URL tab. see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22558 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-13 03:33:41 +00:00
Daryl Koopersmith 9fb6e29102 Media: Add support for applicable *-upload-ui hooks.
Supports pre-upload-ui, pre-plupload-upload-ui, post-plupload-upload-ui, post-upload-ui.

see #22186, #21390.


git-svn-id: https://develop.svn.wordpress.org/trunk@22557 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-13 01:50:08 +00:00
Daryl Koopersmith e0df0a74ca Media: Improve backwards compatibility for image_size_names_choose filter. see #22186, #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22556 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-13 01:23:18 +00:00
Andrew Nacin ec11387b66 SimplePie: Ensure the DOMNode::getLineNo() method exists. props rmccue. fixes #22425.
git-svn-id: https://develop.svn.wordpress.org/trunk@22555 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-13 00:49:15 +00:00
Daryl Koopersmith 630484f453 Media: Properly insert caption shortcodes for attachments.
git-svn-id: https://develop.svn.wordpress.org/trunk@22554 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-13 00:32:04 +00:00
Ryan Boren 55543163fe In wp_crop_image(), preserve both src_file and src. src_file must be preserved even when url fopen is used so that we don't try to save to a filename based on the url.
see #6821


git-svn-id: https://develop.svn.wordpress.org/trunk@22553 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-13 00:03:55 +00:00
Daryl Koopersmith 4ee51a98cb Media: Add an "upload more files" button to upload states. see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22552 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-12 23:52:17 +00:00
bumpbot b73b44b8db Compress scripts/styles: 3.5-beta2-22551. TinyMCE updated.
git-svn-id: https://develop.svn.wordpress.org/trunk@22551 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-12 22:58:31 +00:00
Andrew Ozz 7d5de0703a TinuMCE: update to 3.5.7, fixes #21173
git-svn-id: https://develop.svn.wordpress.org/trunk@22550 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-12 21:20:46 +00:00
Andrew Nacin 4bbe50bf7d Revert [22421]. see #6821. see #22308. see #22419.
git-svn-id: https://develop.svn.wordpress.org/trunk@22549 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-12 07:47:41 +00:00
Daryl Koopersmith c2bef6792f Media: Allow successive embed URLs. see [22547], #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22548 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-12 06:02:03 +00:00
Daryl Koopersmith f6a737ed34 Media: Add Embed from URL tab.
Note: There is a bug that currently blocks adding several successive embeds.

see #21390.


git-svn-id: https://develop.svn.wordpress.org/trunk@22547 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-12 05:57:12 +00:00
bumpbot ac3a589c8d Compress scripts/styles: 3.5-beta2-22546.
git-svn-id: https://develop.svn.wordpress.org/trunk@22546 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-11 22:58:32 +00:00
Andrew Nacin 0c23ef3cf0 In switch_theme(), make sure there are no residual template_root or stylesheet_root options remaining if there is only one theme root registered. see #22252.
git-svn-id: https://develop.svn.wordpress.org/trunk@22545 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-11 21:51:27 +00:00
Andrew Nacin 7216663b0b Ensure $_wp_default_headers is set before iterating over it in get_custom_header(). props jeffsebring. fixes #22221.
git-svn-id: https://develop.svn.wordpress.org/trunk@22544 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-11 19:11:27 +00:00
Daryl Koopersmith 9cd3c458c7 Media: Ensure variables in the attachment details template have defined defaults.
* Adds styling to the upload progress bar in the attachment details template.
* Defines the `filename` attribute when Plupload creates the client-side `Attachment` model.

fixes #22410, see #21390.


git-svn-id: https://develop.svn.wordpress.org/trunk@22543 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-11 05:16:41 +00:00
Daryl Koopersmith e672eb2166 Media in QuickPress: Ensure wpActiveEditor is set when the "Add Media" button is clicked. fixes #22021, see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22542 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-11 01:40:47 +00:00
Daryl Koopersmith 57b09463e6 Media: Add backwards compatibility for attachment_fields_to_edit and attachment_fields_to_save. see #22186.
git-svn-id: https://develop.svn.wordpress.org/trunk@22541 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-11 01:26:42 +00:00
bumpbot 9c7e947d79 Compress scripts/styles: 3.5-beta2-22540.
git-svn-id: https://develop.svn.wordpress.org/trunk@22540 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-10 22:58:34 +00:00
Daryl Koopersmith 747016b9d5 Media templates: Alter escaping regular expression to prevent it from aggresively consuming input meant for interpolation. see #22344, #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22539 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-10 21:38:14 +00:00
Ryan Boren 5f92c0e7f4 Pass an attachment ID, not a file path, to _load_image_to_edit_path() from wp_crop_image(). This fixes handling of attachments that require url fopen to access the image.
Allow passing urls instead of just file paths to WP_Image_Editor_Imagick::load() and WP_Image_Editor_GD::load() so that attachments requiring URL fopen can be handled.

see #6821


git-svn-id: https://develop.svn.wordpress.org/trunk@22538 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-10 20:42:27 +00:00
Daryl Koopersmith 5096f387d1 Media: Add custom URL as an option to attachment display properties. see #21390, #22206.
git-svn-id: https://develop.svn.wordpress.org/trunk@22537 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-10 20:36:46 +00:00
Andrew Ozz c2a28243f6 Admin menu: sync the .folded and @media .auto-fold styles, fixes #21998
git-svn-id: https://develop.svn.wordpress.org/trunk@22536 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-10 19:41:12 +00:00
Daryl Koopersmith 307427162b Media: Automatically strip any non-image items from the collection when creating a gallery.
Also changes the rules for when the "new gallery" button shows:
* More than two items must be selected.
* At least one of them must be an image.

see #21390.


git-svn-id: https://develop.svn.wordpress.org/trunk@22535 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-10 19:25:39 +00:00
Daryl Koopersmith 19488d75ce Media: Allow the modal sidebar to scroll. see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22534 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-10 19:10:04 +00:00
Daryl Koopersmith 2d3c2c4d84 Media: Watch additional search events. Properly captures clearing the search box. see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22533 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-10 18:56:11 +00:00
Daryl Koopersmith 62fe5ba600 Media: Add title, caption, and alt text, and attachment info to sidebar.
* Improve sidebar styles.
* Separate the hybrid title/caption field.
* Improve the sidebar image thumbnail.
* Remove filenames from inside the non-image icon thumbnail.
* Properly sync title/caption/alt.

see #21390.


git-svn-id: https://develop.svn.wordpress.org/trunk@22532 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-10 18:25:04 +00:00
Andrew Nacin ee5bc76549 Add comments to time intervals we cannot express with the constants. Fix a comment. props SergeyBiryukov. fixes #20987.
git-svn-id: https://develop.svn.wordpress.org/trunk@22531 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-10 18:13:09 +00:00
Daryl Koopersmith 8af2f4674f Media: Account for a race condition when deleting an edit gallery frame. see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22530 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-10 09:57:28 +00:00
Daryl Koopersmith fefaea2cf1 Media: Add instructions to drag and drop to reorder images on gallery and batch edit pages.
Removes search boxes from these pages as well.

see #21390.


git-svn-id: https://develop.svn.wordpress.org/trunk@22529 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-10 09:11:33 +00:00
Daryl Koopersmith 7bbd87b61d Media: Keep the selected featured image in the media modal in sync with the page. fixes #22404, see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22528 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-10 08:40:35 +00:00
potbot 3439b4f2f9 POT, generated from r22524
git-svn-id: https://develop.svn.wordpress.org/trunk@22527 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-10 08:18:55 +00:00
potbot c2ce705ec4 POT, generated from r22524
git-svn-id: https://develop.svn.wordpress.org/trunk@22526 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-10 08:18:50 +00:00
potbot 8d64f6c567 POT, generated from r22524
git-svn-id: https://develop.svn.wordpress.org/trunk@22525 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-10 08:18:43 +00:00
Andrew Nacin e6fcf3b013 Don't unnecessarily translate media upload tab strings. see #22186.
git-svn-id: https://develop.svn.wordpress.org/trunk@22524 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-10 07:56:17 +00:00
Daryl Koopersmith 847a00f84b Media: Backwards compatibility for media_upload_tabs.
* Adds `createIframeStates()` to the `MediaFrame` view. It creates states and bindings for the `media_upload_tabs` output, and is included on `MediaFrame.Post` by default.
* Hijacks `tb_remove()` when the media modal is open to ensure the modal closes correctly.
* Adds a `chromeless` parameter to thickbox media tab URLs to render the UI without the old row of tabs.

see #22186, #21390.


git-svn-id: https://develop.svn.wordpress.org/trunk@22523 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-10 07:51:37 +00:00
Andrew Nacin 331bcde9c2 Update the JS version of the shortcode regex to match [22382]. props SergeyBiryukov. fixes #17657.
git-svn-id: https://develop.svn.wordpress.org/trunk@22522 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-10 07:23:55 +00:00
Andrew Nacin ba1682a270 Don't allow non-image uploads for custom headers and backgrounds. props kovshenin. fixes #22149.
git-svn-id: https://develop.svn.wordpress.org/trunk@22521 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-10 05:36:37 +00:00
Andrew Nacin 86a132fe2b URLs should be esc_url(), not esc_attr().
git-svn-id: https://develop.svn.wordpress.org/trunk@22520 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-10 05:30:51 +00:00
Andrew Nacin 020e87658b Customizer uploader control: Pass arrays of extensions around instead. see #22149.
git-svn-id: https://develop.svn.wordpress.org/trunk@22519 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-10 04:59:46 +00:00
Andrew Nacin e655cbc2d1 Use event delegation for Add Media, allowing the event to bubble up to #wpbody. Keeps the Add Media button functional on a second use of QuickPress. fixes #22255.
git-svn-id: https://develop.svn.wordpress.org/trunk@22518 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-10 04:39:44 +00:00