Commit Graph

31407 Commits

Author SHA1 Message Date
Dominik Schilling (ocean90)
7f562dd69f Theme Editor: Change file descriptions of header.php and footer.php.
`header.php` is now "Theme Header" and `footer.php` is "Theme Footer". This prevents a clash with other "Header" strings in the context of "Custom Header".

Props ramiy.
Fixes #32975.

git-svn-id: https://develop.svn.wordpress.org/trunk@34290 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 16:02:24 +00:00
Sergey Biryukov
7851406626 Network Admin: Include IDs for users and sites on their respective views.
Props danielbachhuber, wonderboymusic.
Fixes #18661.

git-svn-id: https://develop.svn.wordpress.org/trunk@34289 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 15:57:47 +00:00
Drew Jaynes
a176e78b64 Docs: Clarify the significance of the $accepted_args parameter value in the documentation for add_filter().
Adds a couple of examples to illustrate callbacks accepting a variable number of arguments.

Fixes #33862.


git-svn-id: https://develop.svn.wordpress.org/trunk@34288 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 14:52:37 +00:00
Drew Jaynes
efc08d508e Docs: Fix some syntactical issues in the DocBlock for set_query_var().
Adds descriptions for the global `WP_Query` instance and the `$value` parameter.

See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34287 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 10:28:41 +00:00
Drew Jaynes
e889c2e647 Docs: Fix some syntactical issues in the documentation for get_queried_object_id().
Adds descriptions for the global `WP_Query` instance and the return.

See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34286 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 10:26:58 +00:00
Drew Jaynes
4706230535 Docs: Fix some syntactical isses in the DocBlock for get_queried_object().
Also add descriptions for the return and the `WP_Query` global.

See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34285 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 10:20:07 +00:00
Drew Jaynes
572e3ddafb Docs: Add documentation to get_query_var() and WP_Query::get() for the optional $default argument, introduced in 3.9 in [27304].
Props swissspidy.
Fixes #33856.


git-svn-id: https://develop.svn.wordpress.org/trunk@34284 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 09:40:51 +00:00
Dion Hulse
6e6d026524 HTTP: Update the Root Certificate bundle.
See #30434


git-svn-id: https://develop.svn.wordpress.org/trunk@34283 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 08:42:24 +00:00
Dion Hulse
09f373d582 Updates: FTP: Add a missing PCRE modifer in [34281].
See #16026, #33432x


git-svn-id: https://develop.svn.wordpress.org/trunk@34282 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 08:22:17 +00:00
Dion Hulse
b114866bbf Updates: FTP/PemFTP Library: Remove the usage of deprecated regular expression functions (ereg replaced by PCRE).
Props enshrined, aaroncampbell
Fixes #16026, #33432


git-svn-id: https://develop.svn.wordpress.org/trunk@34281 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 08:19:18 +00:00
Scott Taylor
30921dd396 Add an argument to wp_page_menu(), 'menu_tag', which defaults to div but can be overridden to allow HTML5 tags like nav.
Props paulwilde, stebbiv, wonderboymusic.
Fixes #10968.


git-svn-id: https://develop.svn.wordpress.org/trunk@34280 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 06:06:17 +00:00
Weston Ruter
d81ca65d4c Customize: Fix live previewing of menu changes on subdirectory installs.
Props adamsilverstein, westonruter.
Fixes #33916.


git-svn-id: https://develop.svn.wordpress.org/trunk@34278 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 05:46:53 +00:00
Scott Taylor
d5e5ca8e93 Comments: in wp_rel_nofollow_callback(), account for the fact that a link might already have a rel attribute. Currently, if a link already has a rel, it will result it duplicate attributes on the element with conflicting values.
Adds unit tests.

Props junsuijin, wonderboymusic.
Fixes #9959.


git-svn-id: https://develop.svn.wordpress.org/trunk@34277 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 04:35:37 +00:00
Scott Taylor
50419ff08d List Tables: ensure that sortable list table column headers have the same padding/line-height as non-sortable headers.
Props drozdz.
Fixes #27945.


git-svn-id: https://develop.svn.wordpress.org/trunk@34276 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 03:25:32 +00:00
Scott Taylor
ace6756081 Editor: add hide-if-no-js class to <td id="wp-word-count">. Word Count no worky with no JavaScript.
Props chriscct7.
Fixes #33379.


git-svn-id: https://develop.svn.wordpress.org/trunk@34275 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 02:31:23 +00:00
Scott Taylor
c5963b8760 In wp-comments-post.php, sanity check a few of the comment inputs that are expected to be a string beford calling string-only functions on them.
Props Kloon.
Fixes #23416.


git-svn-id: https://develop.svn.wordpress.org/trunk@34274 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-17 22:21:06 +00:00
Scott Taylor
bec1944e44 Widgets: don't show a dropdown if there is only 1 taxonomy or zero taxonomies available to the Tag Cloud widget form. Don't output the widget if there are no terms in the selected taxonomy.
Props GautamGupta, wonderboymusic.
Fixes #16125.


git-svn-id: https://develop.svn.wordpress.org/trunk@34273 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-17 22:10:46 +00:00
Scott Taylor
2a4eba2eb8 Canonical: redirect URLs that match an attachment masked on the wrong URL to the attachment link for the matched attachment.
Props solarissmoke.
Fixes #19918.


git-svn-id: https://develop.svn.wordpress.org/trunk@34272 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-17 21:31:21 +00:00
Scott Taylor
73c1ac8b26 Posts List Table: Use a more robust technique for calculating $total_items so that pagination still appears when items are removed on the last page of results and ->max_num_pages decreases.
Props A5hleyRich.
Fixes #29870.


git-svn-id: https://develop.svn.wordpress.org/trunk@34271 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-17 21:17:16 +00:00
Boone Gorges
504deb52fc Lazy-load comment meta on single post pages.
[34268] introduced cache priming for commentmeta, enabled by default. To
ensure performance on single post pages - where commentmeta is most likely
to cause performance issues - we disable up-front cache-priming. Instead, we
prime commentmeta caches for all comments in the loop the first time
`get_comment_meta()` is called on the page.

Props bradt, dd32, wonderboymusic, boonebgorges.
Fixes #16894.

git-svn-id: https://develop.svn.wordpress.org/trunk@34270 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-17 20:00:31 +00:00
Weston Ruter
5ea07785b3 Customize: Reduce peak memory usage by JSON-encoding settings and controls individually.
When there are hundreds of settings and controls (e.g. nav menu items and widget instances) the resulting object that is JSON-encoded can become very large, and `wp_json_encode()` can consume a lot of memory to serialize it. By breaking down the serialization into multiple calls the peak memory usage can be kept in line.

Moves logic out of `wp-admin/customize.php` into the `WP_Customize_Manager` class with new methods:

 * `is_ios()`
 * `get_document_title_template()`
 * `get_preview_url()`/`set_preview_url()`
 * `get_return_url()`/`set_return_url()`
 * `get_autofocus()`/`set_autofocus()`
 * `customize_pane_settings()`

Includes unit tests for these methods, for which the logic was formerly untestable in `customize.php`.

Fixes #33898.


git-svn-id: https://develop.svn.wordpress.org/trunk@34269 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-17 19:41:35 +00:00
Boone Gorges
12329f5ef8 Prime comment meta caches in WP_Comment_Query.
The new 'update_comment_meta_cache' parameter, which defaults to `true`, can
be used to disable this behavior.

`update_comment_cache()` has been updated to support an `$update_meta_cache`
parameter, which also updates to true; this matches the pattern we use for
priming post caches.

See #16894.

git-svn-id: https://develop.svn.wordpress.org/trunk@34268 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-17 19:29:46 +00:00
Boone Gorges
b08a176488 Tell the insert_user_meta filter whether user is being updated.
`insert_user_meta` was introduced in [33708]. This changeset passes the
`$update` parameter to it.

Props tharsheblows, geminorum.
Fixes #31549.

git-svn-id: https://develop.svn.wordpress.org/trunk@34266 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-17 14:34:49 +00:00
Helen Hou-Sandi
3531c0bc10 Superglobals: Revert [34059] until further notice.
see #33837.


git-svn-id: https://develop.svn.wordpress.org/trunk@34265 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-17 12:32:20 +00:00
Drew Jaynes
8c65cfc7f4 Docs: Add a reminder to the DocBlock description for add_query_arg() mentioning that the output is not escaped by default.
Props brentvr for the initial patch. (first props!)
See #33912. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34264 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-17 09:38:56 +00:00
Sergey Biryukov
f9ff998d01 Revert unintended change from [34262].
See #33910.

git-svn-id: https://develop.svn.wordpress.org/trunk@34263 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-17 09:08:14 +00:00
Sergey Biryukov
45610f9464 Docs: Expand the DocBlock for get_default_post_to_edit().
Props rabmalin.
Fixes #33910.

git-svn-id: https://develop.svn.wordpress.org/trunk@34262 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-17 09:05:44 +00:00
Scott Taylor
8861e38966 Media: Ensure that HTML5 captions apply the 'img_caption_shortcode_width'.
Props joemcgill.
Fixes #31053.


git-svn-id: https://develop.svn.wordpress.org/trunk@34261 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-17 06:03:11 +00:00
Scott Taylor
189bc9b5aa Media: In wp_ajax_send_attachment_to_editor(), the fallback logic for $html should be tucked into an else statement so it isn't run needlessly and overwritten.
Props tychay.
Fixes #32072.


git-svn-id: https://develop.svn.wordpress.org/trunk@34260 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-17 05:54:56 +00:00
Scott Taylor
337c87e7c7 Media: In get_image_send_to_editor(), allow a custom value for $rel.
Props tychay.
Fixes #32074.


git-svn-id: https://develop.svn.wordpress.org/trunk@34259 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-17 05:45:31 +00:00
Scott Taylor
2e7277b733 Media: In wp_prepare_attachment_for_js(), don't call file_exists() and filesize() to retrieve $bytes if the data is already present in $meta. This is how the same code in attachment_submitbox_metadata() already works.
Props polevaultweb.
Fixes #33214.


git-svn-id: https://develop.svn.wordpress.org/trunk@34258 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-17 05:02:52 +00:00
Scott Taylor
79656b5fdd Uploader: Fire 'wp_handle_upload' in wp_upload_bits(). Thusly, the filter in wp_xmlrpc_server::mw_newMediaObject() is redundant.
Props dllh.
Fixes #33539.


git-svn-id: https://develop.svn.wordpress.org/trunk@34257 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-17 04:46:00 +00:00
Scott Taylor
a1805ecada Media List Table: remove the counts from the "views" portion of the toolbar, which are inconsistent with grid view. Also reduces complexity and removes potentially expensive count query.
Related to the toolbar view, remove the `wp_admin_canonical_url()` action in grid mode. Grid views that result from links from the list table view are lenses into the library and need to be indicated as such vs being a full attachment query.

Fixes #29744.


git-svn-id: https://develop.svn.wordpress.org/trunk@34256 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-17 02:29:22 +00:00
Scott Taylor
25710ecc67 In wp_mime_type_icon(), the length of the $wilds array varies depending on what is passed as $mime. Loop over $wilds instead of arbitrarily checking $wilds[0].
Adds unit tests.

Fixes #33012.



git-svn-id: https://develop.svn.wordpress.org/trunk@34255 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-17 00:36:12 +00:00
Scott Taylor
45c606576c Media JS: ensure that wp.media.frame (a static reference to the "current" Frame) is reset when a cached frame is opened.
Fixes #33458.


git-svn-id: https://develop.svn.wordpress.org/trunk@34254 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-17 00:09:40 +00:00
Sergey Biryukov
54835433c5 Docs: Expand the $comment_approved argument description for 'comment_post' action.
Props cfinke.
Fixes #33903.

git-svn-id: https://develop.svn.wordpress.org/trunk@34253 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-16 22:29:15 +00:00
Boone Gorges
03ec7cc107 Improve consistency of comment notification callback signatures.
Both `wp_new_comment_notify_moderator()` and `wp_new_comment_notify_postauthor()`
now accept a single argument: `$comment_ID`.

Props SergeyBiryukov.
Fixes #33587.

git-svn-id: https://develop.svn.wordpress.org/trunk@34252 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-16 22:25:07 +00:00
Boone Gorges
de7c9b6015 Move new user notification emails to add_action() callbacks.
When a new user is created in various places throughout the interface,
notifications are sent to the site admin and the new user. Previously, these
notifications were fired through direct calls to `wp_new_user_notification()`,
making it difficult to stop or modify the messages.

This changeset introduces a number of new action hooks in place of direct calls
to `wp_new_user_notification()`, and hooks the new wrapper function
`wp_send_new_user_notifications()` to these hooks.

Props dshanske, thomaswm, boonebgorges.
Fixes #33587.

git-svn-id: https://develop.svn.wordpress.org/trunk@34251 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-16 22:18:33 +00:00
Boone Gorges
d26b868870 Don't notify post authors about spam comments.
[34106] moved post author notification to a hook, and in the process, missed
the 'spam' check. This changeset restores that check.

To make unit testing easier, the notification callbacks have been refactored
to return values: false when various conditions aren't met (eg, approved
comments should not trigger moderation emails), and the return value of the
`wp_notify_*()` function otherwise.

Props cfinke, kraftbj.
See #33587.

git-svn-id: https://develop.svn.wordpress.org/trunk@34250 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-16 21:59:16 +00:00
Sergey Biryukov
7c9c635a04 Add a missing Oxford comma on Export screen.
Props juhise.
Fixes #33906.

git-svn-id: https://develop.svn.wordpress.org/trunk@34249 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-16 21:33:29 +00:00
Boone Gorges
c5f34cb4d0 Throw a notice when an invalid tax is passed to wp_insert_post().
Props jdgrimes.
Fixes #25477.

git-svn-id: https://develop.svn.wordpress.org/trunk@34248 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-16 19:24:51 +00:00
Boone Gorges
302e3d1116 Allow taxonomies to be non-public.
[13216] introduced the 'public' argument for `register_taxonomy()`. This param
was used to set defaults for 'show_ui' and a number of other params, but it
never did anything itself.

With this changeset, taxonomies registered with `public=false` will no longer
be queryable on the front end, ie via taxonomy archive queries.

Props wpsmith, ocean90, nacin, ericlewis, boonebgorges.
Fixes #21949.

git-svn-id: https://develop.svn.wordpress.org/trunk@34247 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-16 19:04:57 +00:00
Boone Gorges
1b016b6dc6 Failed get_term_by() lookups should always return false.
Previously, we sometimes returned `null`.

Props charlestonsw, tyxla.
Fixes #33281.

git-svn-id: https://develop.svn.wordpress.org/trunk@34246 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-16 18:49:28 +00:00
Scott Taylor
3ca5bbb585 Revert [33925], by-reference array manipulation is breaking comments in some themes.
This implementation is losing its shine.

See #16894.


git-svn-id: https://develop.svn.wordpress.org/trunk@34245 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-16 18:13:19 +00:00
Scott Taylor
2d11d6cd90 After [34160], also upgrade objects passed to get_avatar().
See #32619.



git-svn-id: https://develop.svn.wordpress.org/trunk@34244 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-16 17:33:34 +00:00
Sergey Biryukov
45c6094dce Docs: Update the DocBlock for wp_page_menu() to include 'before', 'after', and 'walker' arguments added in [34200].
Align the `$defaults` array and include the default value for `'show_home'`.

Props stevegrunwell.
Fixes #11095.

git-svn-id: https://develop.svn.wordpress.org/trunk@34243 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-16 16:46:08 +00:00
Sergey Biryukov
10bc44d8fc Add register_post_type_args filter for changing register_post_type() arguments before further processing.
Does not apply to built-in post types.

Props MikeSchinkel, nickciske, engelen, swissspidy.
Fixes #17447.

git-svn-id: https://develop.svn.wordpress.org/trunk@34242 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-16 15:46:14 +00:00
Scott Taylor
d2bb55ee92 wp-admin/includes/template.php is now a loader for 3 files made via svn cp:
* `Walker_Category_Checklist` class
* `WP_Internal_Pointers` class
* `template-functions.php`

This is BC for plugins that are loading `wp-admin/includes/template.php` for fun.

See #33413.


git-svn-id: https://develop.svn.wordpress.org/trunk@34241 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-16 15:34:17 +00:00
Sergey Biryukov
d262ebca0a Docs: Synchronize the $timezone parameter description between get_lastpostdate(), get_lastpostmodified(), and _get_last_post_time().
See #17455.

git-svn-id: https://develop.svn.wordpress.org/trunk@34240 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-16 15:28:12 +00:00
Sergey Biryukov
9ab1dfd03e Docs: Fix some syntactical issues with the DocBlock for wp_mail_failed action, introduced in [34221].
Fixes #18926.

git-svn-id: https://develop.svn.wordpress.org/trunk@34239 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-16 15:12:42 +00:00