Commit Graph

32271 Commits

Author SHA1 Message Date
Helen Hou-Sandi
3a8bd20594 Circular focus styling for widgets and menus in the customizer.
see #33808.


git-svn-id: https://develop.svn.wordpress.org/trunk@35207 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 18:52:24 +00:00
Boone Gorges
1b6a8019c3 Fix incorrect variable name introduced in [35197].
See #30017, #33968.

git-svn-id: https://develop.svn.wordpress.org/trunk@35206 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 18:47:11 +00:00
Sergey Biryukov
acce286d34 In WP::parse_request() and url_to_postid(), don't skip objects that have a post status with 'exclude_from_search' => false, e.g. inherit.
This fixes pretty permalinks for attachments, broken in [35195].

Fixes #21970.

git-svn-id: https://develop.svn.wordpress.org/trunk@35205 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 17:52:36 +00:00
Helen Hou-Sandi
0ff0b0e606 Make the database update button primary.
see #23738.


git-svn-id: https://develop.svn.wordpress.org/trunk@35204 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 17:34:30 +00:00
Sergey Biryukov
5b6257083d Twenty Sixteen: Update Gruntfile.js to ignore the html5 shiv for JSHint.
See #34306, #34315.

git-svn-id: https://develop.svn.wordpress.org/trunk@35203 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 17:26:44 +00:00
Drew Jaynes
ebd20119ec Docs: Walker_Nav_Menu_Checklist and Walker_Nav_Menu_Edit are part of the Navigation Menu API, but intended for use in the scope of administration.
See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@35202 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 17:25:11 +00:00
Helen Hou-Sandi
b023eef6ca Box shadows still need -webkit-, turns out.
see #33808, [35200].


git-svn-id: https://develop.svn.wordpress.org/trunk@35201 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 17:09:00 +00:00
Helen Hou-Sandi
19bb379a17 Circular focus styling for expand/collapse arrows.
Affects postboxes, widgets, and nav menus, all in the admin.

props grvrulz for the initial patch.
see #33808.


git-svn-id: https://develop.svn.wordpress.org/trunk@35200 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 16:45:14 +00:00
Ella Iseulde Van Dorpe
017daba3d8 TinyMCE: make captioned images draggable
See #28003.


git-svn-id: https://develop.svn.wordpress.org/trunk@35199 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 15:19:04 +00:00
Ella Iseulde Van Dorpe
604fb7511c Fix close button plugin modal after [18590]
See #18590.



git-svn-id: https://develop.svn.wordpress.org/trunk@35198 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 14:51:01 +00:00
Scott Taylor
43d18b25b0 Unit Tests: add/upgrade the fixtures in Tests_User_Query.
See #30017, #33968.


git-svn-id: https://develop.svn.wordpress.org/trunk@35197 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 07:28:40 +00:00
Scott Taylor
32719bf251 Unit Tests: create fewer terms in Tests_Term_getTerms::test_get_terms_parent_zero()
See #30017, #33968.


git-svn-id: https://develop.svn.wordpress.org/trunk@35196 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 06:52:19 +00:00
Sergey Biryukov
65390cd9cf In WP::parse_request() and url_to_postid(), if a post slug clashes with a trashed page, return the post instead of the page.
Props kovshenin, SergeyBiryukov, igmoweb.
Fixes #21970.

git-svn-id: https://develop.svn.wordpress.org/trunk@35195 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 06:48:22 +00:00
Scott Taylor
0cf7a91d3a Unit Tests: upgrade the fixtures in Tests_Post_Thumbnail_Template.
See #30017, #33968.


git-svn-id: https://develop.svn.wordpress.org/trunk@35194 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 06:39:43 +00:00
Scott Taylor
a65f390db6 Unit Tests: upgrade the fixtures in Tests_Post_Revisions.
See #30017, #33968.


git-svn-id: https://develop.svn.wordpress.org/trunk@35193 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 06:31:16 +00:00
Scott Taylor
5fc726c222 Unit Tests: in Tests_Comment_Query::test_get_comments_for_post(), create fewer comments (5, instead of 10).
See #30017, #33968.


git-svn-id: https://develop.svn.wordpress.org/trunk@35192 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 05:56:47 +00:00
Scott Taylor
d424f690d2 Unit Tests: after [35186], "upgrade" the Canonical fixtures.
See #30017, #33968.


git-svn-id: https://develop.svn.wordpress.org/trunk@35191 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 05:50:40 +00:00
Sergey Biryukov
3d7aa47df8 Remove a one-time variable from edit_user() added in [35189].
See #27317.

git-svn-id: https://develop.svn.wordpress.org/trunk@35190 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 05:45:50 +00:00
Sergey Biryukov
e675e2ccf0 Users: Add 'illegal_user_logins' filter to allow certain usernames to be blacklisted.
Props danielbachhuber, chriscct7, crazycoolcam, SergeyBiryukov.
Fixes #27317.

git-svn-id: https://develop.svn.wordpress.org/trunk@35189 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 05:42:05 +00:00
Scott Taylor
742082c042 Unit Tests: create more fixtures for Tests_User. When using a factory to create ad hoc users, use the inherited static prop $static_factory instead of the instance prop, $factory. If 2 factories are used out of sync, the generator sequences diverge and dupes can be created, causing an untold number of unforeseen errors. Yay.
See #30017, #33968.


git-svn-id: https://develop.svn.wordpress.org/trunk@35188 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 05:29:40 +00:00
Sergey Biryukov
80178d8dc8 Themes: Add Install Parent Theme button for child themes that are missing a parent theme.
Props rabmalin for initial patch.
Fixes #32668.

git-svn-id: https://develop.svn.wordpress.org/trunk@35187 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 05:10:32 +00:00
Scott Taylor
16d98ebf73 Unit Tests: implement setUpBeforeClass() and tearDownAfterClass() on WP_UnitTestCase. Use late static binding (plus a gross fallback for PHP 5.2) to check if wpSetUpBeforeClass() or wpTearDownAfterClass() exist on the called class, and then call it and pass a static WP_UnitTest_Factory instance via Dependency Injection, if it exists.
This makes it way easier to add fixtures, and tear them down, without needing to instantiate `WP_UnitTest_Factory` in every class - removes the need to call `commit_transaction()` in each individual class.

See #30017, #33968.


git-svn-id: https://develop.svn.wordpress.org/trunk@35186 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 04:43:37 +00:00
Scott Taylor
e1a09eff54 Unit Tests: in Tests_Term, create fixtures for posts.
See #30017, #33968.


git-svn-id: https://develop.svn.wordpress.org/trunk@35185 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 03:47:36 +00:00
Sergey Biryukov
9fdd5ae513 Acessibility: Add back-compat styles for plugins that use h3 inside the .metabox-holder container.
Props afercia.
Fixes #33557.

git-svn-id: https://develop.svn.wordpress.org/trunk@35184 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 03:37:03 +00:00
Scott Taylor
8cc22363db Unit Tests: in Tests_Post, create fixtures for users.
See #30017, #33968.


git-svn-id: https://develop.svn.wordpress.org/trunk@35183 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 03:30:09 +00:00
Helen Hou-Sandi
61ef1ff96f Make some primary action buttons look primary.
* User deletion/removal
* Site status change (multisite)
* Network upgrade
* Import file upload
* Media browser upload

props Dezzy for the initial patch.
fixes #23738.


git-svn-id: https://develop.svn.wordpress.org/trunk@35182 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 03:07:48 +00:00
Scott Taylor
3cc9adb890 Unit Tests: in Tests_Media::test_wp_get_attachment_image_srcset_array_no_width(), just toggle metadata, instead of creating a new attachment. Shaves 75ms off the test.
See #30017, #33968.


git-svn-id: https://develop.svn.wordpress.org/trunk@35181 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 02:54:20 +00:00
Sergey Biryukov
0f944bb515 Theme Editor: Repurpose the 'wp_theme_editor_filetypes' filter added in [35134] to actually filter file types instead of files.
Default types include 'php' and 'css' and cannot be removed, only new types can be added.

Props DrewAPicture, SergeyBiryukov.
Fixes #22924.

git-svn-id: https://develop.svn.wordpress.org/trunk@35180 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 02:19:45 +00:00
Scott Taylor
011c1a2e2c Unit Tests: make a fixture in Tests_Media to represent the large image, instead of creating it 10 times.
See #30017, #33968.


git-svn-id: https://develop.svn.wordpress.org/trunk@35179 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 01:42:27 +00:00
Scott Taylor
75e4de9671 Unit Tests: move some oEmbed tests that can trigger HTTP calls to Tests_External_HTTP_OEmbed.
See #30017, #33968.


git-svn-id: https://develop.svn.wordpress.org/trunk@35178 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 01:28:05 +00:00
Scott Taylor
fc7efaf9b1 Unit Tests: Tests_Canonical doesn't need to call wp_set_current_user() or implement tearDown because its grandparent calls wp_set_current_user( 0 ) in tearDown().
See #30017, #33968.


git-svn-id: https://develop.svn.wordpress.org/trunk@35177 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 01:17:22 +00:00
Scott Taylor
a270d619ad Unit Tests: Tests_Comment needs a tearDownAfterClass impl to avoid spillage.
See #30017, #33968.


git-svn-id: https://develop.svn.wordpress.org/trunk@35176 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 01:05:50 +00:00
Scott Taylor
9d5c7055e6 Unit Tests: Tests_Auth needs a tearDownAfterClass impl to avoid spillage.
See #30017, #33968.


git-svn-id: https://develop.svn.wordpress.org/trunk@35175 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 01:03:16 +00:00
Scott Taylor
5fc04e0e26 Unit Tests: call commit_transaction() in Tests_Auth set up.
See #30017, #33968.


git-svn-id: https://develop.svn.wordpress.org/trunk@35174 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 00:48:22 +00:00
Scott Taylor
5d91776307 Unit Tests: reuse fixtures in Tests_Comment.
See #30017, #33968.


git-svn-id: https://develop.svn.wordpress.org/trunk@35173 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 00:38:26 +00:00
Scott Taylor
6f80581b80 Unit Tests: move ->test_readme() out of Tests_Basic and into Tests_External_HTTP_Basic in tests/external-http/.
I intend to move other `wp_remote_get()` tests into similar classes.

See #30017, #33968.


git-svn-id: https://develop.svn.wordpress.org/trunk@35172 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 00:22:50 +00:00
Scott Taylor
c1b2a034d3 Unit Tests: wrestle performance out of Tests_Auth by cloning the same user for a majority of the tests.
See #30017, #33968.


git-svn-id: https://develop.svn.wordpress.org/trunk@35171 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 00:10:45 +00:00
Drew Jaynes
0cb7c0bd9f Docs: Add missing descriptions for the $wpdb global in DocBlocks all the places.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35170 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-14 23:43:10 +00:00
Drew Jaynes
68a3c0cc73 Docs: Fix third-person singular verbs for summaries in wp-admin/includes/bookmarks.php.
Also adds some missing parameter, return, and global descriptions, and one missing summary.

See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35169 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-14 23:24:46 +00:00
Drew Jaynes
c163beb1db Docs: Standardize file header summary for wp-admin/includes/ajax-actions.php.
See #33701.

[ci skip]


git-svn-id: https://develop.svn.wordpress.org/trunk@35168 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-14 22:48:24 +00:00
Drew Jaynes
e8a1b5dcdb Docs: wp-admin/includes/admin-filters.php is part of the Administration subpackage, update the summary.
See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@35167 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-14 22:34:55 +00:00
Drew Jaynes
a845610bc6 Docs: Add a version and standardize the file header summary for wp-admin/includes/admin.php.
See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@35166 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-14 22:31:55 +00:00
Boone Gorges
734d3794ac Fix incorrect variable names from [35164].
Cool story - the tests appeared to pass with the typos.

See #30017, #33968.

git-svn-id: https://develop.svn.wordpress.org/trunk@35165 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-14 21:59:14 +00:00
Boone Gorges
8c7dc25bed Share fixtures in Tests_Admin_includesListTable tests.
See #30017, #33968.

git-svn-id: https://develop.svn.wordpress.org/trunk@35164 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-14 21:40:44 +00:00
Boone Gorges
9f7bfa9805 Share fixtures in Tests_Get_Archives.
See #30017, #33968.

git-svn-id: https://develop.svn.wordpress.org/trunk@35163 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-14 21:29:59 +00:00
Boone Gorges
6c28fe3853 Create fewer fixtures in some tests.
See #30017, #33968.

git-svn-id: https://develop.svn.wordpress.org/trunk@35162 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-14 21:23:03 +00:00
Helen Hou-Sandi
c98ac461a9 Screen options: Improve the "Apply" button
Previously the button was output as a part of the per-page option rendering, inline with that input. While this was appropriate for core's usage, the `screen_settings` filter has allowed plugins to place additional items at the bottom of the panel, which a number take advantage of. This leads to confusing situations where plugins that don't save settings via Ajax either have to add their own button or piggyback onto the existing button, which doesn't make any sense in the flow of additional options. It also hinders core from adding any other options that need to be submitted.

Also, when the screen options panel is open, a submit button there is the primary action at that moment. The "Apply" button also does a full page load, which a primary button indicates better.

fixes #34295. see #22222, #23738.


git-svn-id: https://develop.svn.wordpress.org/trunk@35161 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-14 18:57:16 +00:00
Andrea Fercia
33a3d1bba8 Bump the "Status" H3 heading to H2 on the Edit Comment screen for better accessibility.
Fixes #34286.

git-svn-id: https://develop.svn.wordpress.org/trunk@35160 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-14 17:43:42 +00:00
Jeremy Felt
896b29c857 MS: Introduce action before_signup_header.
This aligns `wp-signup.php` a bit more `with `wp-activate.php` and, among other things, allows a plugin to redirect signup requests.

Props pbearne.
Fixes #17630.


git-svn-id: https://develop.svn.wordpress.org/trunk@35159 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-14 17:31:54 +00:00
Andrea Fercia
359b826e2c Bump H3 headings to H2 on the legacy Link Manager screen for better accessibility.
Fixes #34285.

git-svn-id: https://develop.svn.wordpress.org/trunk@35158 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-14 17:31:29 +00:00