sergiotarxz
/
Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
34,975 Commits 2 Branches 473 Tags 137 MiB
Commit Graph

34975 Commits

Author SHA1 Message Date
Scott Taylor 3aee745492 AJAX: add a new function, `wp_doing_ajax()`, which can replace... (wait for it...) `DOING_AJAX` checks via the constant. 
Props Mte90, sebastian.pisula, swissspidy.
Fixes #25669.


git-svn-id: https://develop.svn.wordpress.org/trunk@38334 602fd350-edb4-49c9-b593-d223f7449a82
 2016-08-23 14:32:18 +00:00
Scott Taylor b1de6df8b4 Media: remove `function_exists()` call for `ini_get()` in `_load_image_to_edit_path()`. 
Props dd32.
Fixes #37681.


git-svn-id: https://develop.svn.wordpress.org/trunk@38333 602fd350-edb4-49c9-b593-d223f7449a82
 2016-08-23 14:23:41 +00:00
Sergey Biryukov c913fc4c23 WP Mail: If post-by-email functionality is disabled, `wp-mail.php` should return a `403 Forbidden` status code instead if `500 Internal Server Error`. 
Props Presskopp, tomdxw.
Fixes #37572.

git-svn-id: https://develop.svn.wordpress.org/trunk@38332 602fd350-edb4-49c9-b593-d223f7449a82
 2016-08-23 14:01:16 +00:00
Boone Gorges 74b912705d Tests: Fix incorrect variable name from [38330]. 
See #37630.

git-svn-id: https://develop.svn.wordpress.org/trunk@38331 602fd350-edb4-49c9-b593-d223f7449a82
 2016-08-23 13:48:13 +00:00
Boone Gorges b93e0739a9 Tests: Attachment `create()` method should match signature of other `create()` methods. 
Legacy argument format continues to be accepted.

Props bcole808.
See #37630.

git-svn-id: https://develop.svn.wordpress.org/trunk@38330 602fd350-edb4-49c9-b593-d223f7449a82
 2016-08-23 13:42:36 +00:00
Sergey Biryukov 934ffcf5b1 I18N: Remove unnecessary context for two strings on "Add New User" screen. 
Props ramiy.
Fixes #37784.

git-svn-id: https://develop.svn.wordpress.org/trunk@38329 602fd350-edb4-49c9-b593-d223f7449a82
 2016-08-23 12:53:54 +00:00
Andrew Ozz d96cb127ee TinyMCE: make sure the temporary id is removed when using the default image dialog and inserting an external image. 
Props fomenkoandrey for reporting and testing.
Fixes #37467.

git-svn-id: https://develop.svn.wordpress.org/trunk@38328 602fd350-edb4-49c9-b593-d223f7449a82
 2016-08-23 04:42:58 +00:00
Sergey Biryukov 8d48e9a685 I18N: Remove unnecessary context in `wp_post_revision_title_expanded()`. 
Props ramiy.
Fixes #37781.

git-svn-id: https://develop.svn.wordpress.org/trunk@38327 602fd350-edb4-49c9-b593-d223f7449a82
 2016-08-23 01:45:04 +00:00
Sergey Biryukov 862b5a554f I18N: Use a consistent context for "Add New" submenu strings in admin bar (Toolbar). 
Props ramiy.
Fixes #37780.

git-svn-id: https://develop.svn.wordpress.org/trunk@38326 602fd350-edb4-49c9-b593-d223f7449a82
 2016-08-23 01:41:16 +00:00
Sergey Biryukov afd7e3b16d I18N: Allow for WordPress Plugin/Theme Directory URLs to be localized. 
Props ramiy.
Fixes #37501.

git-svn-id: https://develop.svn.wordpress.org/trunk@38325 602fd350-edb4-49c9-b593-d223f7449a82
 2016-08-23 01:18:53 +00:00
Sergey Biryukov 3a35ca8bd6 I18N: Replace unnecessary context with translator comments in `wp_post_revision_title()` and `wp_post_revision_title_expanded()`. 
Props ramiy.
Fixes #37778.

git-svn-id: https://develop.svn.wordpress.org/trunk@38324 602fd350-edb4-49c9-b593-d223f7449a82
 2016-08-23 00:34:31 +00:00
Sergey Biryukov e408cbe86d I18N: Replace unnecessary context with a translator comment for `%s Sites` string in `network_step1()`. 
Props ramiy.
Fixes #37777.

git-svn-id: https://develop.svn.wordpress.org/trunk@38323 602fd350-edb4-49c9-b593-d223f7449a82
 2016-08-23 00:16:43 +00:00
Sergey Biryukov aca32f8771 I18N: Replace unnecessary context with a translator comment for `%s KB` string on Network Settings screen. 
Props ramiy.
Fixes #37496.

git-svn-id: https://develop.svn.wordpress.org/trunk@38322 602fd350-edb4-49c9-b593-d223f7449a82
 2016-08-23 00:10:49 +00:00
Sergey Biryukov 03e402b2ec Embeds: In `get_oembed_endpoint_url()`, avoid inadvertent stomping of the `$format` parameter passed to `oembed_endpoint_url` filter. 
Props danhgilmore.
Fixes #37751.

git-svn-id: https://develop.svn.wordpress.org/trunk@38321 602fd350-edb4-49c9-b593-d223f7449a82
 2016-08-23 00:04:46 +00:00
Sergey Biryukov f2a91f6157 I18N: Add translator comments for `Edit Site: %s` string in network admin. 
Props ramiy.
Fixes #37776.

git-svn-id: https://develop.svn.wordpress.org/trunk@38320 602fd350-edb4-49c9-b593-d223f7449a82
 2016-08-22 23:52:56 +00:00
Scott Taylor 653fe9aaa1 Users: after [38317], use a `@property` annotation, instead of a `public` field. 
See #37771.


git-svn-id: https://develop.svn.wordpress.org/trunk@38319 602fd350-edb4-49c9-b593-d223f7449a82
 2016-08-22 22:14:03 +00:00
Scott Taylor e8ab847c74 Widgets: `$option_name` and `$alt_option_name` have been used as members ever since `WP_Widget` became an object in 2.8, but never declared. 
See #37771.


git-svn-id: https://develop.svn.wordpress.org/trunk@38318 602fd350-edb4-49c9-b593-d223f7449a82
 2016-08-22 21:50:44 +00:00
Scott Taylor 459f3aa9a3 Users: `$user_level` has been publicly-accessed on instances of `WP_User` since version 2.0, but is has never been declared. 
See #37771.


git-svn-id: https://develop.svn.wordpress.org/trunk@38317 602fd350-edb4-49c9-b593-d223f7449a82
 2016-08-22 21:40:35 +00:00
Scott Taylor 03aad23a01 Locale: declare the `$month_genitive` field on `WP_Locale`. 
See #37771.


git-svn-id: https://develop.svn.wordpress.org/trunk@38316 602fd350-edb4-49c9-b593-d223f7449a82
 2016-08-22 21:32:09 +00:00
Scott Taylor 6f19452077 HTTP: in `WP_HTTP_Response`, the `@param` declarations for `$status` and `$headers` were swapped. Let us correct this. 
See #37771.


git-svn-id: https://develop.svn.wordpress.org/trunk@38315 602fd350-edb4-49c9-b593-d223f7449a82
 2016-08-22 21:27:02 +00:00
Scott Taylor 670878cbaa Database: `WP_Network`, `WP_Network_Query`, and `WP_Site_Query` call `wpdb::_escape()`, thus requiring it to be `public`. It previously had no access modifier. `_` at the beginning of a method, believe it or not, does not enforce visibility constraints. 
See #37771.


git-svn-id: https://develop.svn.wordpress.org/trunk@38314 602fd350-edb4-49c9-b593-d223f7449a82
 2016-08-22 21:09:03 +00:00
Scott Taylor 6df9616ff6 Comments: in `wp_handle_comment_submission()`, `$_wp_unfiltered_html_comment` is passed as part of `$comment_data`, but is not used locally. 
See #37771.


git-svn-id: https://develop.svn.wordpress.org/trunk@38313 602fd350-edb4-49c9-b593-d223f7449a82
 2016-08-22 21:03:05 +00:00
Scott Taylor d46de8b22b Taxonomy: remove unnecessary `break` in `WP_Term::__get()`. 
See #37771.


git-svn-id: https://develop.svn.wordpress.org/trunk@38312 602fd350-edb4-49c9-b593-d223f7449a82
 2016-08-22 20:59:35 +00:00
Scott Taylor 46d7304d4a Nav Menus: remove unnecessary variable assignment in `wp_nav_menu_item_post_type_meta_box()`. 
See #37771.


git-svn-id: https://develop.svn.wordpress.org/trunk@38311 602fd350-edb4-49c9-b593-d223f7449a82
 2016-08-22 20:57:41 +00:00
Scott Taylor 368e28243f REST API: remove unnecessary variable assignments in `rest_handle_options_request()`. 
See #37771.


git-svn-id: https://develop.svn.wordpress.org/trunk@38310 602fd350-edb4-49c9-b593-d223f7449a82
 2016-08-22 20:55:29 +00:00
Scott Taylor 0dcc38a1ef Media: remove unnecessary variable assignment in `gallery_shortcode()`. 
See #37771.


git-svn-id: https://develop.svn.wordpress.org/trunk@38309 602fd350-edb4-49c9-b593-d223f7449a82
 2016-08-22 20:52:44 +00:00
Scott Taylor 0774c039f4 General: remove variable set needlessly in `wp_check_jsonp_callback()`. 
See #37771.


git-svn-id: https://develop.svn.wordpress.org/trunk@38308 602fd350-edb4-49c9-b593-d223f7449a82
 2016-08-22 20:50:31 +00:00
Drew Jaynes b4fca4a558 Hooks: Standardize naming of dynamic hooks to use interpolation vs concatenation. 
Benefits gained in discoverability and self-documentation throughout core trump the negligible performance hit in using interpolation in hook names.

Props ramiy.
See #37748.


git-svn-id: https://develop.svn.wordpress.org/trunk@38307 602fd350-edb4-49c9-b593-d223f7449a82
 2016-08-22 18:24:48 +00:00
Sergey Biryukov f9491ed8f6 Common CSS: Allow for `.nav-tab-wrapper` class to be used on elements other than `h3` to increase flexibility for custom settings pages. 
Props ramiy, afercia.
Fixes #37257.

git-svn-id: https://develop.svn.wordpress.org/trunk@38306 602fd350-edb4-49c9-b593-d223f7449a82
 2016-08-22 16:32:11 +00:00
Sergey Biryukov 8673ec7459 Multisite: Fix copy/paste issue in `id` attribute for a dismissible message on Sites screen. 
Props imath.
Fixes #37764.

git-svn-id: https://develop.svn.wordpress.org/trunk@38305 602fd350-edb4-49c9-b593-d223f7449a82
 2016-08-22 14:21:15 +00:00
Scott Taylor 92d8f4afdc Login: `retrieve_password()` does not need to import 2 globals that it does not use. 
See #37699.


git-svn-id: https://develop.svn.wordpress.org/trunk@38304 602fd350-edb4-49c9-b593-d223f7449a82
 2016-08-22 04:47:19 +00:00
Scott Taylor 45cd115bf6 Media: add a function, `wp_get_additional_image_sizes()`, that wraps the retrieval of the global `$_wp_additional_image_sizes`. Removes 6 global imports. 
See #37699.


git-svn-id: https://develop.svn.wordpress.org/trunk@38303 602fd350-edb4-49c9-b593-d223f7449a82
 2016-08-22 04:36:42 +00:00
Scott Taylor e878e8156b Media: fix unit test after [38296]. 
https://en.wikipedia.org/wiki/Coupling_(computer_programming)#Disadvantages

Fixes #36246.


git-svn-id: https://develop.svn.wordpress.org/trunk@38302 602fd350-edb4-49c9-b593-d223f7449a82
 2016-08-22 04:16:29 +00:00
Weston Ruter 4c137392c8 Customize: Ensure a newly-added custom link nav menu item has the appropriate CSS class names. 
For nav menu items of the `custom` type, their `object` should also be set to `custom`, so that the `menu-item-custom` class name will be added.

Props vishalkakadiya.
Fixes #37575.


git-svn-id: https://develop.svn.wordpress.org/trunk@38301 602fd350-edb4-49c9-b593-d223f7449a82
 2016-08-22 03:11:51 +00:00
Weston Ruter 99b6d24042 Docs: Update jsdoc in `customize-nav-menus.js` to remove references to Menu Customizer plugin. 
Also fix `@param` for `updateAssignedLocationsInSectionTitle`.

Props gma992, westonruter.
Fixes #37520.


git-svn-id: https://develop.svn.wordpress.org/trunk@38300 602fd350-edb4-49c9-b593-d223f7449a82
 2016-08-22 00:55:42 +00:00
Weston Ruter 3ffa745991 Docs: Update outdated phpdoc for `WP_Customize_Manager::validate_setting_values()` to reflect changes in [37942]. 
Props dlh.
See #37247.
Fixes #37759.


git-svn-id: https://develop.svn.wordpress.org/trunk@38299 602fd350-edb4-49c9-b593-d223f7449a82
 2016-08-22 00:40:15 +00:00
Scott Taylor 2e111412f9 Comments: in `WP_Comment_Query::fill_descendants()`, `continue` if there is an empty array in the loop. 
See #37416, [38297].


git-svn-id: https://develop.svn.wordpress.org/trunk@38298 602fd350-edb4-49c9-b593-d223f7449a82
 2016-08-21 06:42:44 +00:00
Scott Taylor f6fced867b Comments: in `WP_Comment_Query::fill_descendants()`, compute `count()` in the first `for` expression so that it does not run on each iteration. 
Props vishalkakadiya, deremohan.
Fixes #37416.


git-svn-id: https://develop.svn.wordpress.org/trunk@38297 602fd350-edb4-49c9-b593-d223f7449a82
 2016-08-21 06:24:18 +00:00
Scott Taylor 081e51d94b Media: use `wp_get_attachment_metadata()` instead of `get_post_meta()` where appropriate. 
Adds unit test.

Props JorritSchippers.
Fixes #36246.


git-svn-id: https://develop.svn.wordpress.org/trunk@38296 602fd350-edb4-49c9-b593-d223f7449a82
 2016-08-21 06:14:37 +00:00
Scott Taylor c593c6fa95 Media: `wp_get_attachment_link()` fails to output text for non-images if the attachment post doesn't have a title and `$text` (argument #5) was not passed to the func. In this case, use the filename. 
Props Jonnyauk, henry.wright.
Fixes #37343.


git-svn-id: https://develop.svn.wordpress.org/trunk@38295 602fd350-edb4-49c9-b593-d223f7449a82
 2016-08-20 23:44:07 +00:00
Scott Taylor d911ef44dc Media: when calling `pathinfo()`, also pass a `PATHINFO_*` constant to avoid array notices for unset keys. 
Props JaworskiMatt.
Fixes #37608.


git-svn-id: https://develop.svn.wordpress.org/trunk@38294 602fd350-edb4-49c9-b593-d223f7449a82
 2016-08-20 23:35:50 +00:00
Scott Taylor a26f7f7d28 Media: Add some docs to `media-gallery.js` RIP. 
Props jipmoors.
Fixes #37717.


git-svn-id: https://develop.svn.wordpress.org/trunk@38293 602fd350-edb4-49c9-b593-d223f7449a82
 2016-08-20 22:58:34 +00:00
Boone Gorges 29a5d46701 Allow attachment taxonomies to be fetched as objects. 
By adding the `$output` parameter to `get_attachment_taxonomies()`, the
function signature matches that of `get_object_taxonomies()`. The change
also allows for more consistent behavior when passing `output=objects`
to `get_object_taxonomies()` for the 'attachment' object type, since
the `$output` parameter is now passed through the function stack.

Props codemovement.pk.
See #37368.

git-svn-id: https://develop.svn.wordpress.org/trunk@38292 602fd350-edb4-49c9-b593-d223f7449a82
 2016-08-20 17:34:13 +00:00
Boone Gorges 773eb46bf8 Introduce tests for `get_attachment_taxonomies()`. 
See #37368.

git-svn-id: https://develop.svn.wordpress.org/trunk@38291 602fd350-edb4-49c9-b593-d223f7449a82
 2016-08-20 17:24:12 +00:00
Boone Gorges 86a2c06f6f Introduce tests for `get_object_taxonomies()`. 
See #37368.

git-svn-id: https://develop.svn.wordpress.org/trunk@38290 602fd350-edb4-49c9-b593-d223f7449a82
 2016-08-20 17:00:56 +00:00
Sergey Biryukov 4bf8693357 Docs: Correct usage examples for `wpdb::prepare()`, which should not be called statically. 
Props TJNowell.
Fixes #37744.

git-svn-id: https://develop.svn.wordpress.org/trunk@38289 602fd350-edb4-49c9-b593-d223f7449a82
 2016-08-20 13:16:33 +00:00
Boone Gorges f05beeba8c Query: Non-scalar and negative values for 'p' should always result in a 404. 
Previously, the 'p' query var was being run through `absint()`, which
caused unexpected results.

Props Akeif, kouratoras.
Fixes #33372.

git-svn-id: https://develop.svn.wordpress.org/trunk@38288 602fd350-edb4-49c9-b593-d223f7449a82
 2016-08-20 02:31:31 +00:00
Boone Gorges 54b51f1a26 Mail: Don't set Sender field when setting From. 
[38058] changed `wp_mail()` so that it used PHPMailer's `setFrom()`
method rather than setting the From and FromName headers directly. See
behavior of setting the `Sender` field. This causes `mail` to be
called with the `-f` flag, which causes outgoing email to fail on some
server environments.

Props Clorith, iandunn, DrewAPicture.
Fixes #37736.

git-svn-id: https://develop.svn.wordpress.org/trunk@38286 602fd350-edb4-49c9-b593-d223f7449a82
 2016-08-20 02:16:54 +00:00
Boone Gorges ba9eda1a9b Tests: Move some utility classes to their own files. 
Props Frank Klein.
Fixes #37523.


git-svn-id: https://develop.svn.wordpress.org/trunk@38285 602fd350-edb4-49c9-b593-d223f7449a82
 2016-08-19 15:44:37 +00:00
Sergey Biryukov f3425a50ac Docs: Fix typo in `load_plugin_textdomain()` parameter description. 
Props tivnet.
See #37318.

git-svn-id: https://develop.svn.wordpress.org/trunk@38284 602fd350-edb4-49c9-b593-d223f7449a82
 2016-08-19 14:28:42 +00:00