Weston Ruter
42687da29c
Widgets: Modify unit test assertion to be compatible with widget_nav_menu
option being filtered by plugin to return ArrayIterator
.
...
Modifies assertion added in [35100].
See #26876 .
See #32474 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35272 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-19 21:26:24 +00:00
Drew Jaynes
900810e508
Docs: Add a missing file header for wp-admin/includes/class-wp-site-icon.php.
...
See #33701 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35271 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-19 20:08:34 +00:00
Drew Jaynes
f03562b364
Tests: Add some more test coverage for get_term_field()
.
...
See #33968 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35270 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-19 03:28:49 +00:00
Boone Gorges
583b065e14
Don't store data
as a property on WP_Term
objects.
...
`wp_ajax_add_term()` fetches a term using `get_term()`, and passes the term to
`WP_Ajax_Response`, which expects each of the term's properties to be scalar.
Having `$data` as a `stdClass` (meant to mimic `WP_User::data`, populated by
a `get_row()` database query) violated this expectation, causing fatal string
conversion errors. As a workaround, `$term->data` is converted so that it is
no longer an actual property of the term object, but is assembled only when
requested in the magic `__get()` method.
Fixes #34348 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35269 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-19 03:11:30 +00:00
Boone Gorges
990eebf373
Bust object term cache in wp_remove_object_terms()
.
...
Props tszming.
Fixes #34338 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35268 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-19 01:52:22 +00:00
Dion Hulse
063d42a801
In insert_with_markers()
restore the 4.3 behaviour of creating the file if it doesn't exist.
...
This change also makes it bail early (without writing) if the markers content is the same as the existing, and uses `ftell()` rather than `$bytes` for the location to truncate the file to - based on the file pointer being at the end of the written stream.
Props willmot tigertech kevinatelement
See #31767
git-svn-id: https://develop.svn.wordpress.org/trunk@35267 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-19 00:52:08 +00:00
Drew Jaynes
10322a38bf
Docs: Fix a typo in the $blog_id
parameter name in the rest_url
filter doc.
...
Props rachelbaker.
Fixes #34351 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35266 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-18 23:11:49 +00:00
Andrea Fercia
ccb76a5af0
Multisite: Improve the Admin Bar parent menu items color on hover and focus.
...
Props Nikschavan for the initial patch.
Fixes #34040 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35265 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-18 16:21:42 +00:00
Drew Jaynes
0fb4304628
Taxonomy: Improve deprecated argument strings for the 'link' type in get_categories()
and wp_dropdown_categories()
.
...
Props swissspidy, gagan0123.
Fixes #34318 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35264 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-18 15:34:55 +00:00
Drew Jaynes
84d3e1f305
Administration: Introduce the manage_posts_extra_tablenav
action, which fires inside the tablenav for the posts list table, and just outside the "actions" container.
...
Props hlashbrooke, wonderboymusic.
Fixes #30341 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35263 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-18 14:55:52 +00:00
Drew Jaynes
cb2bc30252
Docs: Add a version to the file header for wp-admin/includes/comment.php.
...
See #33701 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35262 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-18 14:33:31 +00:00
Ella Iseulde Van Dorpe
67ff09cf33
TinyMCE: Drag and drop link with image
...
Make sure images don't loose their link after drag and drop.
Fixes #28272 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35261 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-18 11:04:33 +00:00
John Blackbourn
39c6a77617
Some cleanup that was missed in [35259].
...
See #33728 , #24853
git-svn-id: https://develop.svn.wordpress.org/trunk@35260 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-18 06:25:25 +00:00
John Blackbourn
219b56a6a4
Some rewrite endpoint tests in preparation for new endpoint masks. More to come.
...
See #33728 , #24853
git-svn-id: https://develop.svn.wordpress.org/trunk@35259 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-18 06:23:48 +00:00
John Blackbourn
a314c6c234
Preserve the public and private query var properties on the global WP
instance when using WP_UnitTestCase::go_to()
. These properties apply to the application state, not the current request.
...
See #34346
git-svn-id: https://develop.svn.wordpress.org/trunk@35258 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-18 05:00:40 +00:00
John Blackbourn
9fbff7f63a
Add is_embed()
to WP_UnitTestCase::assertQueryTrue()
and update the relevant embed tests.
...
See #32522
git-svn-id: https://develop.svn.wordpress.org/trunk@35257 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-18 04:50:15 +00:00
John Blackbourn
6845b3cd4a
Move the test_is_home_should_be_false_when_visiting_custom_endpoint_without_a_registered_query_var_and_page_on_front_is_set()
test into a more appropriate place.
...
See #25143
git-svn-id: https://develop.svn.wordpress.org/trunk@35256 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-18 01:34:29 +00:00
John Blackbourn
ab43e7362d
Correct a test after r35253.
...
See #34272
git-svn-id: https://develop.svn.wordpress.org/trunk@35255 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-18 00:55:16 +00:00
John Blackbourn
01a92d7908
Remove an IDE-specific rule in .gitignore
. These should be managed in the user's ~/.gitignore_global
file.
...
Fixes #34345
git-svn-id: https://develop.svn.wordpress.org/trunk@35254 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-18 00:15:23 +00:00
Sergey Biryukov
8c19030438
Embeds: After [35235], replace some missed oembed
references with embed
.
...
Props peterwilsoncc.
Fixes #34272 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35253 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-17 23:25:56 +00:00
John Blackbourn
d5b31e6ba2
Introduce map_deep()
, a utility function that recursively maps a callable function to every item in an array or object. Works like array_walk_recursive()
but works with objects too.
...
Updates `rawurlencode_deep()`, `urlencode_deep()`, and `stripslashes_deep()` to use `map_deep()`. Introduces `urldecode_deep()` for completeness.
Props wpmuguru, nbachiyski, boonebgorges, MikeHansenMe, chriscct7, realloc, johnbillion
Fixes #22300
git-svn-id: https://develop.svn.wordpress.org/trunk@35252 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-17 23:25:21 +00:00
Weston Ruter
f8e79c5bbc
Customizer: Fix margin-top
calculation for Themes section.
...
Ensure that the Themes section calculates its `margin-top` as a panel, since the section behaves as one. Fixes regression caused by [35231].
See #33567 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35251 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-17 22:40:10 +00:00
Scott Taylor
641e372432
Media: in wp_get_attachment_image_sizes()
, ensure that $img_width
exists when the image does not.
...
Props kraftbj.
See #33641 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35250 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-17 22:11:28 +00:00
Scott Taylor
768958f7a0
Unit Tests: better fixtures for Tests_Meta_Slashes
and Tests_WP_Customize_Section
.
...
See #30017 , #33968 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35249 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-17 21:28:43 +00:00
Scott Taylor
80b732819b
Unit Tests: better fixtures for Tests_User_WpSetCurrentUser
.
...
See #30017 , #33968 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35248 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-17 21:18:38 +00:00
Scott Taylor
721d4c5a77
Unit Tests: better fixtures for Tests_User
.
...
See #30017 , #33968 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35247 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-17 21:14:28 +00:00
Scott Taylor
c173dc5595
Unit Tests: better fixtures for Tests_AdminBar
. Don't force-delete some posts: some filter callbacks are no-ops on Multisite if the post is vanquished.
...
See #30017 , #33968 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35246 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-17 20:48:33 +00:00
Scott Taylor
8506f48d6b
Unit Tests: better fixtures for Tests_Admin_Includes_Post
.
...
See #30017 , #33968 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35245 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-17 19:47:07 +00:00
Scott Taylor
613e88fe86
Unit Tests: WP_UnitTest_Generator_Sequence
needs a static incrementer - otherwise, it assumes every test class is a reset, which it no longer is (it is now static).
...
While we're at it, remove unnecessary `tearDown()` code.
See #30017 , #33968 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35244 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-17 19:24:20 +00:00
Scott Taylor
ae226d66b6
Unit Tests: after [35242], declare some missing instance props on individual test classes.
...
See #30017 , #33968 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35243 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-17 18:29:32 +00:00
Scott Taylor
b757b37551
Unit Tests: after [35225], make factory
a method/getter on WP_UnitTestCase
and add magic methods for BC for every plugin that is extending WP_UnitTestCase
and accessing the $factory
instance prop.
...
Props nerrad, wonderboymusic.
See #30017 , #33968 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35242 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-17 18:02:16 +00:00
Drew Jaynes
5a0fd03f95
Docs: Add missing file headers to the list table classes and adjust class DocBlocks accordingly.
...
See #33701 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35241 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-17 15:12:48 +00:00
Drew Jaynes
0bb4a1bdd0
Docs: Improve the hook doc for the get_post_status
filter, introduced in [35233].
...
Also adds a missing parameter description for `$post`.
See #23458 . See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35240 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-17 14:23:05 +00:00
Ella Iseulde Van Dorpe
5b5b67ee31
JSHint after [35238]
...
git-svn-id: https://develop.svn.wordpress.org/trunk@35239 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-17 07:10:55 +00:00
Ella Iseulde Van Dorpe
112af0751f
Admin: fix repositioning notices
...
Fixes #34294 .
Props afercia.
git-svn-id: https://develop.svn.wordpress.org/trunk@35238 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-17 07:03:30 +00:00
Drew Jaynes
cba5390270
Docs: Add a missing file header for wp-admin/includes/class-wp-list-table.php.
...
See #33701 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35237 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-17 06:06:59 +00:00
Weston Ruter
0e81f51cac
Customizer: Add unit test for WP_Customize_Widgets::is_panel_active()
.
...
See #33052 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35236 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-17 04:43:27 +00:00
Sergey Biryukov
9b591d6b09
Embeds: Rename files, functions, and hooks added in [34903] to make it more clear what is oEmbed-specific and what isn't.
...
See https://core.trac.wordpress.org/ticket/34272#comment:7 for full list of renamed functions and hooks.
Props swissspidy.
Fixes #34272 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35235 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-17 01:20:19 +00:00
Sergey Biryukov
5c19a7a704
Replace Quick Edit and Bulk Edit headings with <legend>
elements.
...
Props afercia.
Fixes #34289 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35234 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-17 00:44:12 +00:00
Aaron Jorbin
7db19dcda2
Improve get_post_permalink
compatibility with non standard post status
...
This adds a new filter named `get_post_status` to the function named `get_post_status` which can be used to make additional post types behave like unpublished post status in `get_post_permalink`.
Props misterbisson, antpb, iamfriendly
Fixes #23458
git-svn-id: https://develop.svn.wordpress.org/trunk@35233 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-17 00:43:54 +00:00
Sergey Biryukov
fe72320f33
Merge two strings for expanding accordion and Customizer sections.
...
Props pavelevap.
Fixes #33939 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35232 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-17 00:27:44 +00:00
Weston Ruter
370057b5d7
Customizer: Always show Widgets panel initially if sidebars are registered; show notice to users in panel if no widget areas are in current preview.
...
Widgets panel will not wait to display until the preview loads.
Also fixes problems with `margin-top` in panels where other panels' `active` states change, as well as ensuring sections of deactivated panel collapse before panel is hidden to prevent the pane from becoming empty of controls.
Fixes #33052 .
Fixes #33567 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35231 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-16 23:47:56 +00:00
Sergey Biryukov
de182f7736
Merge two warning strings.
...
Props pavelevap.
Fixes #29740 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35230 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-16 23:30:29 +00:00
Sergey Biryukov
af36c261e3
Sample permalink: Improve accessibility of changing the permalink on Edit Post screen.
...
Props afercia.
Fixes #34255 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35229 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-16 23:01:58 +00:00
Sergey Biryukov
7b6454bf6b
Embeds: In print_oembed_embed_styles()
, load non-minified file if SCRIPT_DEBUG
is true.
...
This is consistent with `print_oembed_embed_scripts()`.
Props MikeHansenMe.
Fixes #34321 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35228 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-16 22:42:47 +00:00
Boone Gorges
f22ba848df
Return null
from get_term()
on taxonomy mismatch.
...
[34997] caused `get_term()` to return an error object in the case when
`$taxonomy` did not match the taxonomy of the located term. This was an
inadvertant change from the previous behavior, when `get_term()` would return
null in these cases.
Props dlh.
See #14162 . Fixes #34332 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35227 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-16 21:41:51 +00:00
Scott Taylor
61edcd5021
Unit Tests: PHP 5.2, I Hate You and You Are Bringing Me Down.
...
#YOLOFriday
See #30017 , #33968 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35226 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-16 21:14:52 +00:00
Scott Taylor
e70ebea219
Unit Tests: one $factory
to rule them all, and it shall be static
.
...
Using more than one instance of `WP_UnitTest_Factory` causes all kinds of craziness, due to out-of-sync internal generator sequences. Since we want to use `setUpBeforeClass`, we were creating ad hoc instances. To avoid that, we were injecting one `static` instance via Dependency Injection in `wpSetUpBeforeClass`. All tests should really use the `static` instance, so we will remove the instance prop `$factory`.
Replace `$this->factory` with `self::$factory` over 2000 times.
Rewrite all of the tests that were hard-coding dynamic values.
#YOLOFriday
git-svn-id: https://develop.svn.wordpress.org/trunk@35225 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-16 21:04:12 +00:00
Scott Taylor
84272ff8cd
Unit Tests: since [32953], we can just use self::delete_user()
instead of using if
logic for Multisite.
...
See #30017 , #33968 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35224 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-16 19:51:32 +00:00
Sergey Biryukov
0d4a7ee029
In WP_Posts_List_Table
, correct the type for $comment_pending_count
.
...
See #11381 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35223 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-16 18:24:25 +00:00