sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
27,356 Commits 2 Branches 473 Tags 137 MiB
44466b7627
Commit Graph

1789 Commits

Author SHA1 Message Date
azaozz
12ebd89657 Editor scrolling: also disable in IE < 9. See #28328. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29180 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-15 22:36:02 +00:00
Scott Taylor
9e573243cf Add a new AJAX action: parse-media-shortcode. This async call will replace JS rendering of audio/video/playlist shortcodes. 
See #28905.


git-svn-id: https://develop.svn.wordpress.org/trunk@29178 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-15 22:07:16 +00:00
Scott Taylor
bbfdf38a5b Make audio and video URLs/embed handlers work in <iframe>-sandbox'd MCE views. 
Introduce:
`get_editor_stylesheets()`
`wp_media_mce_styles()`.

See #28905.


git-svn-id: https://develop.svn.wordpress.org/trunk@29176 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-15 21:50:41 +00:00
Helen Hou-Sandi
0db107498a No-JS fallback for the Media Library grid view. props michalzuber. fixes #28830, see #24716. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29175 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-15 20:44:38 +00:00
Dominik Schilling (ocean90)
4d6759dcf5 Remove unused variable in WP_Theme_Install_List_Table::install_theme_info(). Unused since [26380]. 
props Corphi.
fixes #28749.

git-svn-id: https://develop.svn.wordpress.org/trunk@29173 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-14 20:27:37 +00:00
Dominik Schilling (ocean90)
cf673a6985 Fix wrong indentation in [29136]. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29172 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-14 20:08:38 +00:00
Dominik Schilling (ocean90)
1b2386e787 Remove plugin_install_details_link filter, which was added in [29047]. 
see #28785.

git-svn-id: https://develop.svn.wordpress.org/trunk@29171 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-14 19:49:15 +00:00
Dominik Schilling (ocean90)
60b1befd8e Customizer: Add meta capability customize which is mapped to edit_theme_options. 
You can now allow users to access the Customizer, say for any user who can `edit_posts`, via `map_meta_cap` or `user_has_cap` filter. See ticket for examples.

props westonruter, nacin.
fixes #28605.

git-svn-id: https://develop.svn.wordpress.org/trunk@29170 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-14 19:00:24 +00:00
Scott Taylor
e5a663297c Missed one: WP_MS_Sites_List_Table::display_rows() must be public. 
Props extendwings.
Fixes #28894.



git-svn-id: https://develop.svn.wordpress.org/trunk@29166 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-14 15:41:53 +00:00
Drew Jaynes (DrewAPicture)
7ad77d58ee Add periods to short descriptions for magic methods added in [28501], [28521], and [28524]. 
See #22234 and #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29165 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-14 01:11:55 +00:00
Drew Jaynes (DrewAPicture)
e58a2aae1d Inline documentation cleanup for 4.0 audit. 
* phpDoc tweaks for `wp_get_available_translations_from_api()`, `wp_install_download_language_pack()`, and `wp_install_load_language()`, added in [29018]
 
See #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29154 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-14 00:16:36 +00:00
Drew Jaynes (DrewAPicture)
f77584ea2c Inline documentation for the 'plugin_install_details_link' hook added in [29047] should use a 3-digit, x.x.x-style @since version. 
See #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29152 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-14 00:09:58 +00:00
Drew Jaynes (DrewAPicture)
08fd193850 Inline documentation cleanup for 4.0 audit. 
* Alignment for the 'term_search_min_chars' hook docs, added in [28892]
* Globals added for `wp_ajax_parse_embed()`, added [28580]

See #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29151 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-14 00:05:37 +00:00
Drew Jaynes (DrewAPicture)
49fdc296ba Fill out inline documentation for magic methods added to the Custom_Image_Header class in [28481], [28521], and [28524]. 
See #22234 and #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29150 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-13 23:58:27 +00:00
Drew Jaynes (DrewAPicture)
1db583af25 Fill out inline documentation for magic methods added to the Custom_Background class in [28481], [28521], and [28524]. 
See #22234 and #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29149 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-13 23:57:03 +00:00
Drew Jaynes (DrewAPicture)
1bf87b2c9e Fill out inline documentation for magic methods added to the WP_List_Table class in [28493], [28521], and [28524]. 
See #22234 and #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29148 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-13 23:54:15 +00:00
Drew Jaynes (DrewAPicture)
343c544f6b Fill out inline documentation for magic methods added to the WP_Filesystem_Base class in [28521]. 
See #22234 and #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29147 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-13 23:51:39 +00:00
Scott Taylor
510ad2e1e9 Fix mismatches in access modifiers for WP_List_Table + subclasses. 
Fixes #28843, #28879.


git-svn-id: https://develop.svn.wordpress.org/trunk@29137 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-13 22:08:22 +00:00
Dominik Schilling (ocean90)
1264558022 Media Grid improvements: 
* Remove fixed elements.
* Adjusts toolbar and search, fixes #28833.
* Add link to Add New button, fixes #28825.
* Add "Edit Metadata" tab to all items, "Edit Image" only for images
* Make strings translatable.
* First pass for help tab.

see #28850.

git-svn-id: https://develop.svn.wordpress.org/trunk@29136 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-13 16:15:36 +00:00
Dominik Schilling (ocean90)
cf0e666184 Customizer: Make panel title translatable too. 
props michalzuber.
see #27406.

git-svn-id: https://develop.svn.wordpress.org/trunk@29135 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-13 15:12:00 +00:00
Dominik Schilling (ocean90)
33db0d4ff2 Lists View Switcher: Replace blank image with screen reader text. 
props davidakennedy.
fixes #28871.

git-svn-id: https://develop.svn.wordpress.org/trunk@29133 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-13 11:04:21 +00:00
Dominik Schilling (ocean90)
d198c0bdd5 Remove unused variable in wp_dashboard_plugins_output(). Unused since [26144]. 
props michalzuber.
see #28872.

git-svn-id: https://develop.svn.wordpress.org/trunk@29130 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-13 10:30:53 +00:00
Dominik Schilling (ocean90)
1285d1450b Improvements to the plugin information modal: 
* Whitespace/braces cleanup for [29040].
* Reduce width of modal to 792px, which is the default banner size.
* Reduce banner height when screen height is smaller than 500px.
* Remove inline CSS.
* Re-use tab var in JS.
* Encode ampersands in links.

props avryl, michalzuber, ocean90.
see #27440.


git-svn-id: https://develop.svn.wordpress.org/trunk@29125 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-12 22:07:16 +00:00
Dominik Schilling (ocean90)
c7f2a54dc8 Themes: Don't set background color for the filter icon. 
fixes #28860.


git-svn-id: https://develop.svn.wordpress.org/trunk@29124 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-12 19:48:24 +00:00
Sergey Biryukov
c52f02cc3f Use correct ID for plugin search input label. 
Make the search button name and ID consistent with the ones in WP_List_Table::search_box().

props joedolson.
fixes #28856.

git-svn-id: https://develop.svn.wordpress.org/trunk@29123 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-12 17:44:51 +00:00
Dominik Schilling (ocean90)
7580577e82 Don't use box shadow focus styling for widget arrows, see #28267. 
fixes #28834.
props nvwd.

git-svn-id: https://develop.svn.wordpress.org/trunk@29122 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-12 15:46:27 +00:00
Dominik Schilling (ocean90)
911da56fe8 Improve styling of progress bar on wp-admin/media-new.php. 
props Ipstenu for initial patch.
fixes #28838.

git-svn-id: https://develop.svn.wordpress.org/trunk@29121 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-12 14:51:30 +00:00
Scott Taylor
63cb20cc5a Repent for our original OOP sins and doc blocks as pertains to access modifiers in List Table + subclasses. 
Props SergeyBiryukov.
See #28843 and [28583].


git-svn-id: https://develop.svn.wordpress.org/trunk@29118 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-12 03:26:40 +00:00
Andrew Ozz
dbb367bee8 Editor scrolling: disable on mobile devices and hide the resize handle. See #28328. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29117 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-12 00:53:08 +00:00
Scott Taylor
d1f4b3a800 Media Grid, for audio files: 
* Show `artist` and `album` fields in the Edit Attachment modal
* Sync their values on `change`

See #28839.


git-svn-id: https://develop.svn.wordpress.org/trunk@29104 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-11 20:54:13 +00:00
Sergey Biryukov
8a45aefe56 Escape taxonomy name when used in attributes in post_categories_meta_box(). 
props pbearne.
fixes #28836.

git-svn-id: https://develop.svn.wordpress.org/trunk@29099 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-11 18:55:48 +00:00
Scott Taylor
0f50df6cbd Media Grid, in the Edit Attachment modal: 
* Label the fields under the attachment a la the Edit Media page
* Move the audio and video previews above the info
* Remove the audio / video icon display. Unnecessary.
* Ensure that `width` and `max-width` are set for `.mejs-container`

See #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@29088 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-11 06:14:31 +00:00
Scott Taylor
ce01c5c760 Media Grid: 
* Move the grid down via CSS transition when the Screen Options slide open.
* Remove some unused CSS for grid options.

See #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@29086 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-11 05:33:29 +00:00
Sergey Biryukov
d2a246e82c Avoid inadvertently adding admin page titles as classes for admin menu submenu items. 
fixes #28817.

git-svn-id: https://develop.svn.wordpress.org/trunk@29083 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-11 01:09:32 +00:00
Scott Taylor
ee0e7ccbca Media Grid: make registering Screen Options for non-list tables more generic. 
See #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@29079 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-10 21:43:49 +00:00
Scott Taylor
d5cbf00457 Media Grid: Screen Options for grid have to play nice with Screen Options for list. This was fun. 
See #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@29078 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-10 21:25:49 +00:00
Scott Taylor
3ebde0c4d6 Media Grid: Move toggling of visible fields to Screen Options. This moves us in a better direction... but this will probably need to be massaged again. 
See #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@29077 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-10 20:59:12 +00:00
Helen Hou-Sandi
e4f0744b8e Editor scrolling: 
* Make sure the background color for tools is only applied to the main editor.
* Fix toolbar width for smaller screens.
* Ensure toolbar doesn't end up in a weird place when scrolling down too fast.
* Avoid JS errors for post types that don't support the editor.

props avryl. see #28328.


git-svn-id: https://develop.svn.wordpress.org/trunk@29075 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-10 19:35:32 +00:00
Andrew Nacin
0838b61b1d Unload the current default textdomain in wp_install_load_language(). 
see #28577.


git-svn-id: https://develop.svn.wordpress.org/trunk@29059 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-10 09:54:06 +00:00
Andrew Nacin
253e09f192 Install: Don't ask for the user's language a second time if they chose English originally. 
see #28577.


git-svn-id: https://develop.svn.wordpress.org/trunk@29058 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-10 09:24:55 +00:00
Helen Hou-Sandi
466659cee6 Media grid attachment modal: 
* Keyboard navigation.
* History and routes for single items and search results.

props adamsilverstein. see #24716.



git-svn-id: https://develop.svn.wordpress.org/trunk@29057 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-10 06:36:34 +00:00
Sergey Biryukov
c35bd6c927 Revisions: Properly position the spinner on Compare Revisions screen. 
props vinod dalvi for initial patch.
fixes #28590.

git-svn-id: https://develop.svn.wordpress.org/trunk@29054 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-10 01:43:59 +00:00
Sergey Biryukov
ca97e64c50 Revisions: Explicitly set the 'from' handle position when switching from two-handled mode back to single-handled mode. 
props adamsilverstein.
fixes #26793.

git-svn-id: https://develop.svn.wordpress.org/trunk@29052 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-10 00:59:13 +00:00
Sergey Biryukov
1477277b53 Customizer: Introduce WP_Customize_Control::active() method to determine whether the control is relevant to the current context (i.e. to the current URL being previewed). 
Control can indicate its active state by a subclass overriding the 'active_callback' method, by supplying a callable 'active_callback' argument into the control's constructor, or by filtering 'customize_control_active'.

props westonruter.
see #27993.

git-svn-id: https://develop.svn.wordpress.org/trunk@29051 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-09 23:57:29 +00:00
Andrew Ozz
ccef0ae5f0 Fix whitespace, quotes and double patch content in wpautoresize plugin, see #28328 
git-svn-id: https://develop.svn.wordpress.org/trunk@29050 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-09 22:42:28 +00:00
Andrew Ozz
14d1e57e99 Enhance the editor on the Add/Edit Post screens, first run. Props avril, see #28328. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29049 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-09 22:05:06 +00:00
Sergey Biryukov
f92dc5aa41 Customizer: Export Previewer instance to wp.customize.previewer, and utilize for Widget Customizer. 
props westonruter.
fixes #27666.

git-svn-id: https://develop.svn.wordpress.org/trunk@29048 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-09 20:57:58 +00:00
Helen Hou-Sandi
2a5fa0e4c5 Display plugin install results as "cards" rather than in a list table, first run. 
props stephdau, ryelle, tellyworth, melchoyce. see #28785, #28646.



git-svn-id: https://develop.svn.wordpress.org/trunk@29047 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-09 20:01:35 +00:00
Helen Hou-Sandi
194122cb84 Remove an unused JS variable after [29036]. see #27406. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29042 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-09 17:45:36 +00:00
Helen Hou-Sandi
70639f7b90 Autoprefixer for [29040]. see #27440. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29041 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-09 17:41:00 +00:00
Helen Hou-Sandi
56706c324d Improvements to the plugin information modal: 
* Show the banner image when available.
* Show contributors and ratings breakdown in the FYI box.
* Show reviews in a tab.

props stephdau, tellyworth, paulwilde, michalzuber. see #27440. fixes #19784, #22599, #26202.


git-svn-id: https://develop.svn.wordpress.org/trunk@29040 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-09 17:27:22 +00:00
Drew Jaynes (DrewAPicture)
854fa2b5d6 Add @see reference for set_post_thumbnail() in the phpDoc for wp_ajax_set_attachment_thumbnail(). 
See #27891.


git-svn-id: https://develop.svn.wordpress.org/trunk@29037 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-08 20:35:53 +00:00
Helen Hou-Sandi
4e8a1a1ab1 accordion.js: 
* Remove remnants from when some corners were rounded.
* Docs.

props celloexpressions. see #27406.


git-svn-id: https://develop.svn.wordpress.org/trunk@29036 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-08 20:21:47 +00:00
Helen Hou-Sandi
054e4b5e65 Customizer panels: 
* Close all accordion sections when going in and out of panels.
* Fix panel positioning when top-level Customizer controls are scrolled down.
* Keyboard accessibility: only focus on visible elements and transfer between them as needed when navigating around panels.

props celloexpressions. see #27406.


git-svn-id: https://develop.svn.wordpress.org/trunk@29035 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-08 20:18:30 +00:00
Helen Hou-Sandi
d1c4c6fd6e Customizer info section: 
* Only show the theme info when doing a live preview of another theme.
* Replace with helper text about what you are customizing and what the Customizer is for.
* Fix focus styling.

props celloexpressions, westonruter. fixes #28550.


git-svn-id: https://develop.svn.wordpress.org/trunk@29034 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-08 19:52:17 +00:00
John Blackbourn
d9ba81155e Remove autocomplete from the database password screen on setup-config.php. Props hebbet. Fixes #28585. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29032 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-08 18:31:21 +00:00
Helen Hou-Sandi
bfdd641013 More consistent icons in place of some buttons for the Customizer and theme install preview. 
* Use a single close icon instead of a context-changing cancel/close button in the Customizer. In user testing, this small distinction in language was overlooked, and we use an AYS now instead. This also makes it consistent with the back arrow in Customizer panels.
* Use the same close icon as well as the previous/next arrows from the theme details browser in the theme install preview.

props celloexpressions. fixes #28655.


git-svn-id: https://develop.svn.wordpress.org/trunk@29031 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-08 18:18:23 +00:00
John Blackbourn
0a4e8b2b7e Implement email and url input types where appropriate. Props Kau-Boy. Fixes #22183. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29030 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-08 17:51:58 +00:00
Scott Taylor
c6428ff1ba When setting the poster image for a video shortcode, set that image as the featured image for that attachment (if found) in the background. This AJAX functionality could be used for audio as well. 
Introduces `attachment_url_to_postid()` to attempt to turn URLs into post IDs.

Fixes #27891.


git-svn-id: https://develop.svn.wordpress.org/trunk@29029 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-08 17:47:53 +00:00
Helen Hou-Sandi
c722aca8e5 When accessing the Customizer from the admin menu, make sure the user is returned to the originating page upon close. We should still investigate the general usage of customize-loader.js moving forward, but this approach fixes the immediate issue. props westonruter. fixes #25457. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29026 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-08 17:14:20 +00:00
Helen Hou-Sandi
0298f71032 Prompt the user before leaving the Customizer if they have unsaved changes. props westonruter. fixes #25439. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29025 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-08 17:03:48 +00:00
John Blackbourn
b72068ba06 Narrower layout and loading spinner for the install screen language selector. See #28577 
git-svn-id: https://develop.svn.wordpress.org/trunk@29021 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-08 00:32:29 +00:00
John Blackbourn
02a22f7dd4 Focus and blur styling (via JS) for the install screen language selector. Props jorbin. See #28577 
git-svn-id: https://develop.svn.wordpress.org/trunk@29020 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-08 00:29:47 +00:00
Andrew Nacin
8f15bef515 Language on install: Docs and naming cleanups. see #28577. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29018 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-07 21:48:50 +00:00
John Blackbourn
1f51b720f0 Correct the usage of the variable passed to wp_install_download_language_pack() and kill an unused local variable. Props michalzuber. Also avoid using the $_REQUEST superglobal in this function. See #28577. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29016 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-07 18:05:13 +00:00
Drew Jaynes (DrewAPicture)
e862e3cf6d Inline docs syntax fixes following [28978]. 
See #28740.


git-svn-id: https://develop.svn.wordpress.org/trunk@29015 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-07 16:41:43 +00:00
Sergey Biryukov
c9f0cb6295 Clarify a string on Add New User screen. 
props vancoder, collinsinternet.
fixes #27398.

git-svn-id: https://develop.svn.wordpress.org/trunk@29009 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-07 00:53:54 +00:00
Andrew Nacin
a6ff9013be Introduce wp_dropdown_languages() and use it on general settings. 
Early rough cut. Obviously not fully implemented.

see #15677.


git-svn-id: https://develop.svn.wordpress.org/trunk@29007 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-05 06:18:50 +00:00
Andrew Nacin
277ada83d8 Bring the language chooser to setup-config.php. 
see #28577.


git-svn-id: https://develop.svn.wordpress.org/trunk@29006 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-05 05:13:05 +00:00
Andrew Nacin
f25c1e989b Don't include plugin.php twice in setup-config.php. 
fixes #28744. see #28740, [28978].


git-svn-id: https://develop.svn.wordpress.org/trunk@29005 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-05 02:12:47 +00:00
Sergey Biryukov
c1c0693cee Reinstate 'install_themes_tabs' filter. 
props ghost1227.
fixes #28578.

git-svn-id: https://develop.svn.wordpress.org/trunk@29002 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-04 23:57:39 +00:00
Helen Hou-Sandi
e14d866665 Media grid, round 2. Expect much more to come. 
* Instead of a sidebar for details, utilize a modal. The modal experience allows for a larger preview, editing images, audio/video previews, and previous/next navigation, like the theme browser. Think of it as an attachment browser.
* Show some details in the grid view to more easily distinguish items.

props ericlewis, wonderboymusic, JerrySarcastic. see #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@28993 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-04 03:38:33 +00:00
Scott Taylor
9c314d1d00 Make a new file: media-grid.js. This will be way more useful in later commits and help reduce churn and bloat in media-views.js. 
See #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@28992 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-04 02:17:22 +00:00
John Blackbourn
4e3b729b09 If we already have a value for WPLANG when installing, insert this language at the top of the language selector and pre-select it. See #28577 
git-svn-id: https://develop.svn.wordpress.org/trunk@28984 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-03 22:55:57 +00:00
John Blackbourn
db8b7380b2 First pass at switching to radio inputs for the install screen language selector. Needs some more work. See #28577. Props jorbin 
git-svn-id: https://develop.svn.wordpress.org/trunk@28983 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-03 22:53:01 +00:00
John Blackbourn
35578f8f9a Avoid a warning if the translations API call fails on step 1. Remove assignment inside an if statement. See #28577. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28982 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-03 22:30:27 +00:00
Drew Jaynes (DrewAPicture)
79dd39c19c Note in the hook docs for preview_post_link that the $post parameter was added. 
See #28729.


git-svn-id: https://develop.svn.wordpress.org/trunk@28979 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-03 20:04:56 +00:00
Andrew Nacin
a7c3b23f1c Simplify the setup-config.php UI flow and load process. 
When no configuration file is detected, we now redirect to setup-config.php. This process now uses the WordPress bootstrap, rather than a set of fragile hacks.

fixes #28740.


git-svn-id: https://develop.svn.wordpress.org/trunk@28978 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-03 19:56:37 +00:00
Drew Jaynes (DrewAPicture)
b1b454c7a0 Remove backticks on $post variables in some short parameter descriptions. 
See [28653], [28654].
See #28388.


git-svn-id: https://develop.svn.wordpress.org/trunk@28976 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-03 19:27:54 +00:00
Drew Jaynes (DrewAPicture)
7ffc91fdd6 Fix an incomplete docblock for wp_create_categories() as part of $post/$post_id cleanup. 
See #28388.


git-svn-id: https://develop.svn.wordpress.org/trunk@28975 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-03 19:21:34 +00:00
John Blackbourn
c18a28f792 Use the admin scheme for theme preview URLs when installing new themes. See #21919. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28974 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-03 18:47:33 +00:00
Helen Hou-Sandi
3adcda996b Improve oEmbed caching. Introduces the concept of a TTL for oEmbed caches and a filter for oembed_ttl. 
We will no longer replace previously valid oEmbed responses with an `{{unknown}}` cache value. When this happens due to reaching a rate limit or a service going down, it is data loss, and is not acceptable. This means that oEmbed caches for a post are no longer deleted indiscriminately every time that post is saved.

oEmbed continues to be cached in post meta, with the addition of a separate meta key containing the timestamp of the last retrieval, which is used to avoid re-requesting a recently cached oEmbed response. By default, we consider a valued cached in the past day to be fresh. This can greatly reduce the number of outbound requests, especially in cases where a post containing multiple embeds is saved frequently.

The TTL used to determine whether or not to request a response can be filtered using `oembed_ttl`, thus allowing for the possibility of respecting the optional oEmbed response parameter `cache_age` or altering the period of time a cached value is considered to be fresh.

Now that oEmbeds are previewed in the visual editor as well as the media modal, oEmbed caches are often populated before a post is saved or published. By pre-populating and avoiding having to re-request that response, we also greatly reduce the chances of a stampede happening when a published post is visible before oEmbed caching is complete.

As it previously stood, a stampede was extremely likely to happen, as the AJAX caching was only triggered when `$_GET['message']` was 1. The published message is 6. We now trigger the caching every time `$_GET['message']` is present on the edit screen, as we are able to avoid triggering so many HTTP requests overall.

props markjaquith. fixes #14759. see #17210.


git-svn-id: https://develop.svn.wordpress.org/trunk@28972 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-03 16:44:15 +00:00
Sergey Biryukov
8bf7ed77f3 Pass $post object to 'preview_post_link' filter. 
props danielbachhuber.
fixes #28729.

git-svn-id: https://develop.svn.wordpress.org/trunk@28969 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-03 14:41:06 +00:00
Sergey Biryukov
8ee9631bb4 Remove non-breaking spaces from auto update email text. 
props trepmal.
fixes #28715.

git-svn-id: https://develop.svn.wordpress.org/trunk@28956 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-02 12:45:31 +00:00
Sergey Biryukov
0d2817bf9e Simplify a condition in get_sample_permalink_html(). 
see #28350.

git-svn-id: https://develop.svn.wordpress.org/trunk@28948 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-02 00:10:13 +00:00
Sergey Biryukov
3fe0336a63 Simplify logic in get_sample_permalink_html(), remove duplicated code. 
see #28350.

git-svn-id: https://develop.svn.wordpress.org/trunk@28947 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-02 00:03:53 +00:00
Sergey Biryukov
7a8bedaf2a Display a correct preview link for drafts when permalinks are disabled. 
see #28350.

git-svn-id: https://develop.svn.wordpress.org/trunk@28946 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-01 23:55:58 +00:00
Helen Hou-Sandi
c6c89eed8a Only apply metabox handle styles and JS events to .postbox .hndle, as opposed to all h3s in a .postbox. 
Developers previously relying on the `h3` behavior may be affected. You may want to investigate `do_meta_boxes()` rather than recreating markup.

props SergeyBiryukov, nabil_kadimi.
fixes #28485.


git-svn-id: https://develop.svn.wordpress.org/trunk@28940 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-01 16:22:32 +00:00
Dominik Schilling (ocean90)
5aeaa14d9a Customizer: Reverse arrows in RTL. See #27406. 
props yoavf.
fixes #28669.

git-svn-id: https://develop.svn.wordpress.org/trunk@28931 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-30 19:59:51 +00:00
Dominik Schilling (ocean90)
6f51a5f972 Customizer: Support textarea and commonly-used input types as control type in WP_Customize_Control. 
Add `input_attrs` property to support custom input attributes.

(Demo plugin attached to ticket.)

props celloexpressions.
fixes #28477.

git-svn-id: https://develop.svn.wordpress.org/trunk@28930 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-30 19:47:56 +00:00
Helen Hou-Sandi
4f7bc0410f Support descriptions for individual customizer controls. 
* Control title (label) markup will also only be output if specified.
* Control section descriptions are no longer italicized for visual hierarchy / differentiation.

props celloexpressions. fixes #27981.


git-svn-id: https://develop.svn.wordpress.org/trunk@28927 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-30 15:54:04 +00:00
Sergey Biryukov
913392b9a9 Display consistent preview links for drafts. 
props mordauk.
fixes #28350.

git-svn-id: https://develop.svn.wordpress.org/trunk@28920 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-30 10:02:01 +00:00
Andrew Ozz
df6eb733eb Secure embeds in the editor (first run): 
- When the user pastes an embeddable http URL, try to get the https embed.
- If an embed provider doesn't support ssl embeds, show a placeholder/error message.
- Revise the way we return error messages.
See #28195, #28507.

git-svn-id: https://develop.svn.wordpress.org/trunk@28919 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-30 05:48:16 +00:00
Sergey Biryukov
29aabd08a9 Prevent bulk actions from being performed when Filter button is clicked. 
props jesin.
fixes #28555.

git-svn-id: https://develop.svn.wordpress.org/trunk@28916 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-30 01:09:25 +00:00
Scott Taylor
11da6abc57 Allow comments in the trash to marked as spam. 
Props mordauk.
Fixes #19256.


git-svn-id: https://develop.svn.wordpress.org/trunk@28913 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-29 23:18:24 +00:00
Scott Taylor
d204e4dea0 Admin screens should use the WPINC constant 
Props wojtek.szkutnik
See #14157.


git-svn-id: https://develop.svn.wordpress.org/trunk@28906 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-29 22:20:26 +00:00
Scott Taylor
48c145ee78 WP_Filesystem_Base->abspath() should use the WPINC constant 
Props wojtek.szkutnik
See #14157.


git-svn-id: https://develop.svn.wordpress.org/trunk@28904 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-29 22:15:10 +00:00
Sergey Biryukov
1e7b12978c Set date format before going into the loop to avoid a PHP notice if 'lastupdated' column is filtered out. 
props jeremyfelt.
fixes #27614.

git-svn-id: https://develop.svn.wordpress.org/trunk@28898 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-29 18:10:52 +00:00
Sergey Biryukov
107001213b Fix feature pointer positioning issues for both LTR and RTL. 
fixes #28062.

git-svn-id: https://develop.svn.wordpress.org/trunk@28897 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-29 16:05:53 +00:00
John Blackbourn
db4da6e488 Remove the WordPress logo from the focusable elements on the install/update screens. Fixes #28674. Props stompweb 
git-svn-id: https://develop.svn.wordpress.org/trunk@28896 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-29 14:09:39 +00:00
John Blackbourn
3426416dac Normalise the schemes used in get_home_path() so it returns the correct path for sites using SSL in the admin area but not the front end. Fixes #25767. Props GregLone for the initial patch. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28893 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-29 10:28:52 +00:00
John Blackbourn
075be3e54b Introduce a filter to control the minimum characters required for an AJAX term search. Fixes #13580. Props iamfriendly, brianlayman 
git-svn-id: https://develop.svn.wordpress.org/trunk@28892 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-29 10:04:05 +00:00
Sergey Biryukov
08969ece9e Show a "No themes found" message if the search for an installed theme doesn't produce any results. 
props gauravmittal1995 for initial patch.
fixes #28587.

git-svn-id: https://develop.svn.wordpress.org/trunk@28890 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-29 09:15:08 +00:00
Scott Taylor
2d56abdd2e Add new action 'delete_user_form' in wp-admin/users.php and wp-admin/network/users.php. 
Props SergeyBiryukov, usermrpapa.
Fixes #27230.


git-svn-id: https://develop.svn.wordpress.org/trunk@28885 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-28 04:42:24 +00:00
Helen Hou-Sandi
9becde117d Make the posts list table mode a sticky user setting. props garyc40, azaozz, ericmann. fixes #16774, #20335. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28876 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-28 02:16:59 +00:00
Scott Taylor
572e27c682 Remove remaining Heartbeat API experimental notices 
Props DH-Shredder.
Fixes #28626.


git-svn-id: https://develop.svn.wordpress.org/trunk@28872 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-28 02:05:54 +00:00
Scott Taylor
2371f75688 In deprecated media iframe code, attachment_fields_to_save filter should not be called twice after initial image upload in post. 
Props SergeyBiryukov.
Fixes #20720.


git-svn-id: https://develop.svn.wordpress.org/trunk@28871 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-27 21:31:28 +00:00
Helen Hou-Sandi
c27492cf26 Don't switch contextual help tabs when tabbing around. props neil_pie. see #28209. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28869 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-27 19:09:17 +00:00
Sergey Biryukov
d2d985ffeb Avoid duplication of callbacks in theme browser sidebar each time the Next or Previous button is clicked. 
This makes the collapse/expand button work as expected.

fixes #28581.

git-svn-id: https://develop.svn.wordpress.org/trunk@28868 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-27 16:05:07 +00:00
Dominik Schilling (ocean90)
7edd9edde4 Customizer: Introduce a "panel" API to organize multiple sections into a one section. 
Create a panel via `$GLOBALS['wp_customize']->add_panel( $panel_id, $args )` and use `$panel_id` for the `panel` argument in `$GLOBALS['wp_customize']->add_section( $section_id, $args )`. That's it.
As an example all widget area sections are now summarized into one panel. Feedback appreciated.

props celloexpressions.
see #27406.

git-svn-id: https://develop.svn.wordpress.org/trunk@28861 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-26 20:16:21 +00:00
Sergey Biryukov
3513f37623 Fix unexpected replacement of a previous tag when selecting a tag from autosuggest results. 
props camdensegal.
fixes #28471.

git-svn-id: https://develop.svn.wordpress.org/trunk@28851 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-26 16:07:36 +00:00
Helen Hou-Sandi
2187cc6f98 Slightly bump up the login logo size to avoid getting chopped off by Firefox's rounding problems. props SergeyBiryukov for the initial patch. fixes #28393. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28850 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-26 15:35:19 +00:00
Sergey Biryukov
7fa39e6839 Replace Y/m/d date format in general settings with a more popular one, Y-m-d. 
props gauravmittal1995.
fixes #28447.

git-svn-id: https://develop.svn.wordpress.org/trunk@28848 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-26 14:28:04 +00:00
Andrew Ozz
38debafe60 Uploader: enable selecting multiple files on mobile devices (still doesn't work on Android). See #28640. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28847 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-26 04:14:59 +00:00
Scott Taylor
cf15c523d3 Only apply a subtle semi-transparent border to attachments that are images in the media list table. 
See [28842], #15860.



git-svn-id: https://develop.svn.wordpress.org/trunk@28843 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-26 01:57:37 +00:00
Scott Taylor
f92d73310a Apply a subtle semi-transparent border to images in the media list table to avoid the "white on white (like a polar bear in Antarctica)" problem. 
Props ericlewis.
Fixes #15860.


git-svn-id: https://develop.svn.wordpress.org/trunk@28842 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-26 01:51:20 +00:00
Scott Taylor
95f3506532 In media_buttons(), add a static var $instance to increment the id attribute of insert-media-button-%d on each call. 
Props ericlewis.
Fixes #28090.


git-svn-id: https://develop.svn.wordpress.org/trunk@28837 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-26 01:04:32 +00:00
Drew Jaynes (DrewAPicture)
8130335b9d Add braces missed while adding docs for the option_page_capability_{$option_page} hook. 
See [25372]. See #25229.


git-svn-id: https://develop.svn.wordpress.org/trunk@28833 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-25 21:47:14 +00:00
Scott Taylor
1c947d9ef1 Bring the list of upload_filetypes for multisite into modernity based on .com upgrades and supported extensions for audio and video. 
Fixes #24434.


git-svn-id: https://develop.svn.wordpress.org/trunk@28832 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-25 17:59:54 +00:00
Scott Taylor
69101fe0f3 The "old iframe media modal" has some pretty busted styles. Although this is a "deprecated" feature, clean up some of the broken styles. 
Props erayalakese for the JS patch.
Fixes #28220.



git-svn-id: https://develop.svn.wordpress.org/trunk@28830 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-25 17:38:28 +00:00
Scott Taylor
6f220c7fc7 Make the list of gallery attachments in the "old iframe media modal" break less. The "columns" are not aligned with the headers, but this would require a markup rewrite of a deprecated feature. 
Fixes #28098.



git-svn-id: https://develop.svn.wordpress.org/trunk@28829 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-25 17:11:36 +00:00
Sergey Biryukov
b1fd1dbbcf Add ISO date standard YYYY-MM-DD format to general settings. 
props mattheweppelsheimer.
fixes #28447.

git-svn-id: https://develop.svn.wordpress.org/trunk@28820 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-24 09:49:37 +00:00
Scott Taylor
832bbb2821 Remove noscript from wpautop()'s list of block elements. 
Props mdawaffe.
Fixes #27268.


git-svn-id: https://develop.svn.wordpress.org/trunk@28817 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-24 00:53:41 +00:00
Scott Taylor
723927ca74 Adjust CSS for "Moved to the trash" message for a pingback in the dashboard. 
Props zoerooney, codenameEli.
Fixes #28286.


git-svn-id: https://develop.svn.wordpress.org/trunk@28811 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-24 00:02:17 +00:00
Scott Taylor
848034a190 Use unobtrusive JS for Comment list table row actions. 
Props aubreypwd.
Fixes #27533.


git-svn-id: https://develop.svn.wordpress.org/trunk@28810 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-23 23:54:28 +00:00
Sergey Biryukov
2120ede170 Remove mbstring_binary_safe_strlen(). Use mbstring_binary_safe_encoding() and reset_mbstring_encoding() directly. 
fixes #28162.

git-svn-id: https://develop.svn.wordpress.org/trunk@28808 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-23 22:20:23 +00:00
Sergey Biryukov
4fd715c937 Introduce a binary-safe wrapper for strlen() and use it in seems_utf8(), utf8_uri_encode(), and wp_read_image_metadata(). 
Use binary-safe POMO_Reader::strlen() in MO::export_to_file_handle().

fixes #28162.

git-svn-id: https://develop.svn.wordpress.org/trunk@28806 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-23 14:47:08 +00:00
Scott Taylor
76ccf2a956 Remove unused globals from link-parse-opml.php after [28743]. 
Props SergeyBiryukov.
Fixes #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28786 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-20 17:25:47 +00:00
Andrew Nacin
e27b672b22 Narrower screen when choosing a language. see #28577. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28780 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-19 04:46:40 +00:00
Andrew Nacin
aa6ef01298 Fix variable usage in new language install choices. see #28577. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28779 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-19 04:36:29 +00:00
Helen Hou-Sandi
ae2cce3f64 Restore the ability to pass classes to admin menu submenu items, important for the Customize link. Accidentally left out in [24048]. fixes #28583. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28778 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-19 02:17:08 +00:00
Sergey Biryukov
4bee2a9c4a Fix copy/paste error in a comment. 
see #28581.

git-svn-id: https://develop.svn.wordpress.org/trunk@28777 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-19 01:35:28 +00:00
Andrew Nacin
39cf46851b Allow a language to be chosen before installing WordPress. First pass. 
* Checks WordPress.org for available languages.
* In get_locale(), starts using the WPLANG option that has existed in multisite since the MU days.
* Adds new argument to wp_install() for setting WPLANG.

see #28577. 


git-svn-id: https://develop.svn.wordpress.org/trunk@28774 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-18 19:57:21 +00:00
Sergey Biryukov
6719d08d2d Revert [28766]. 
see #28555.

git-svn-id: https://develop.svn.wordpress.org/trunk@28772 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-18 02:22:45 +00:00
Sergey Biryukov
9561db4dee Don't add # to URL when clicking 'OK' without changing the permalink. 
props avryl.
fixes #27594.

git-svn-id: https://develop.svn.wordpress.org/trunk@28771 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-18 00:28:35 +00:00
Sergey Biryukov
63596d6868 Prevent bulk actions from being performed when Filter button is clicked. 
props layotte.
fixes #28555.

git-svn-id: https://develop.svn.wordpress.org/trunk@28766 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-17 22:16:11 +00:00
Sergey Biryukov
177d39a15b Fix labels on installation screen. 
props avryl.
fixes #28548.

git-svn-id: https://develop.svn.wordpress.org/trunk@28759 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-17 14:36:22 +00:00
Andrew Ozz
ed07c215dc wpView: improve handling of embed errors/error messages, see #28195 
git-svn-id: https://develop.svn.wordpress.org/trunk@28754 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-15 22:52:45 +00:00
Andrew Nacin
65803684f4 Add a new 'Beta Testing' tab on the plugin installer, for features as plugins such as Press This. 
fixes #28513.


git-svn-id: https://develop.svn.wordpress.org/trunk@28749 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-12 18:08:56 +00:00
Scott Taylor
e0a089d9d8 Don't use variable variables in touch_time(). 
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28747 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-11 21:04:56 +00:00
Scott Taylor
61c1da236c Don't use variable variables in wp_reset_vars(). Test by searching in list tables, etc. 
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28746 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-11 19:59:18 +00:00
Scott Taylor
eb23569835 Don't use variable variables in user-new.php. Test by causing errors when creating a new user. 
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28745 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-11 19:53:25 +00:00
Scott Taylor
6e159bb671 Don't use variable variables in setup-config.php (Step 2). 
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28744 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-11 19:40:27 +00:00
Scott Taylor
98f3cd0548 OPML: 
* Learn how OPML works, cry.
* Remove unused globals in `startElement()`
* Stop using variable variables in `startElement()`

Tested with the OPML importer plugin

See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28743 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-11 19:30:26 +00:00
Scott Taylor
4ccb011960 Don't use variable variables in wp_dashboard_plugins_output(). Variable variables aren't the worst thing about this function. 
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28742 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-11 18:55:00 +00:00
John Blackbourn
f02e878bb0 Only include relevant post authors in WXR exports. Fixes #20206. Props jeremyfelt. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28731 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-10 19:14:26 +00:00
John Blackbourn
827cf97b00 Add screen reader labels to the date inputs on the post editing screen. Fixes #25461. Props frank-klein. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28730 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-10 18:49:26 +00:00
Scott Taylor
121726df31 edit.php?post_type=attachment should redirect to upload.php. Without the redirect, the user is presented with an empty list table. There are probably other issues to address overall, but this accomplishes what the ticket wants. 
Props knutsp.
Fixes #27951.


git-svn-id: https://develop.svn.wordpress.org/trunk@28729 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-10 18:47:57 +00:00
Scott Taylor
84ad12b439 Replace all uses of like_escape() with $wpdb->esc_like(). 
Props miqrogroove.
See #10041.


git-svn-id: https://develop.svn.wordpress.org/trunk@28712 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-10 00:43:32 +00:00
Scott Taylor
faf208de38 Live update the menu item title when the user is editing the "Navigation Label" field. 
Props celloexpressions.
See #23076.


git-svn-id: https://develop.svn.wordpress.org/trunk@28707 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-09 18:38:29 +00:00
Helen Hou-Sandi
70390c48f5 Properly indicate with the cursor that the editor can be vertically resized using the entire info bar, not just the handle displayed in the corner. 
props torresga. fixes #28420.


git-svn-id: https://develop.svn.wordpress.org/trunk@28703 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-08 19:47:00 +00:00
Helen Hou-Sandi
3d9fc450b2 Grid view for the media library, first pass. This is alpha; expect imperfection. We will be iterating further. 
props ericlewis, shaunandrews, wonderboymusic.
see #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@28682 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-05 22:00:24 +00:00
Sergey Biryukov
c7c1a4a88a Remove one-time variable from add_settings_error(). 
props niallkennedy.
fixes #22228.

git-svn-id: https://develop.svn.wordpress.org/trunk@28681 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-05 18:28:15 +00:00
Sergey Biryukov
7f3b20c45d Remove redundant 'Visit author homepage' title attributes for plugins and themes. 
props joedolson.
fixes #26554.

git-svn-id: https://develop.svn.wordpress.org/trunk@28673 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-05 04:51:55 +00:00
Drew Jaynes (DrewAPicture)
24b3ed214e Make sure to use 3-digit x.x.x style for two 3.9.0 @since versions. 
Props netweb.
Fixes #28446.


git-svn-id: https://develop.svn.wordpress.org/trunk@28658 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-04 05:34:37 +00:00
Drew Jaynes (DrewAPicture)
9bb9177199 Make sure $post is properly documented as optional where applicable. 
See #28388.


git-svn-id: https://develop.svn.wordpress.org/trunk@28653 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-03 03:52:46 +00:00
Sergey Biryukov
e8e39d212b Plugin activation/deletion errors should be styled as such. 
props johnbillion.
fixes #28260.

git-svn-id: https://develop.svn.wordpress.org/trunk@28646 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-31 20:09:26 +00:00
Sergey Biryukov
c04daa1ade Avoid stomping of the $plugin variable in activate_plugin(). 
fixes #28102.

git-svn-id: https://develop.svn.wordpress.org/trunk@28644 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-30 22:07:43 +00:00
Sergey Biryukov
9120e6a9d7 Display the site scheme, not the current scheme on Edit Site screen in network admin. 
props johnbillion.
fixes #28406.

git-svn-id: https://develop.svn.wordpress.org/trunk@28643 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-30 22:00:45 +00:00
Sergey Biryukov
dbef7e2587 Add paragraph tags to 'Add Existing User' section on 'Add New User' screen in multisite. 
props jkudish, topher1kenobe.
fixes #20271.

git-svn-id: https://develop.svn.wordpress.org/trunk@28642 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-30 21:50:24 +00:00
Scott Taylor
804b82bd11 Make the image editor less jumpy when opening. 
Props eddiemoya, ericlewis.
Fixes #22793.



git-svn-id: https://develop.svn.wordpress.org/trunk@28639 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-30 19:52:35 +00:00
Scott Taylor
e996a74984 Restore $val in WP_Importer::bump_request_timeout() - even though the parent class and WP_Import ignore the parameter, it creates an incompatible interface notice in the plugin. 
See [28629].



git-svn-id: https://develop.svn.wordpress.org/trunk@28637 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-30 19:34:53 +00:00
Scott Taylor
2cd825a21b Cleanup for switch statements: 
* Move `default` to the bottom in `WP_Theme_Install_List_Table`
* `switch/endswitch` syntax is not supported in Hack. Switch to `switch (...) {  .... }` syntax. (A few template-type instances linger).

Fixes #28409.
See #27881.



git-svn-id: https://develop.svn.wordpress.org/trunk@28633 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-30 17:57:51 +00:00
Drew Jaynes (DrewAPicture)
dc96d99a70 Remove unnecessary "not used" notation for filter parameters in wp-admin/includes/media.php. 
Also add `@param` and `@return` descriptions.

See #28408.


git-svn-id: https://develop.svn.wordpress.org/trunk@28632 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-30 17:37:36 +00:00
Scott Taylor
7ab6b096e6 Remove some dead variable assignments. 
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28629 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-30 16:58:36 +00:00
Andrew Ozz
d87a482353 TinyMCE in iOS: 
- Fix placing the caret at the bottom of longer posts when the keyboard is open.
- Disable resizing on switching editors and on show/hide the kitchen sink row.
See #28242

git-svn-id: https://develop.svn.wordpress.org/trunk@28626 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-30 02:37:52 +00:00
Helen Hou-Sandi
220a45a32d Don't use the box shadow focus styling for the admin menu or toolbar. see #28267. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28616 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-29 14:22:39 +00:00
Helen Hou-Sandi
06c142a1a5 Better align link element focus with form focus styling, which also improves the visibility. props zamfeer. see #28267. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28608 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-29 03:57:44 +00:00
Sergey Biryukov
c73f5ef2de Fix displaying taxonomies in bulk edit if the post type does not support titles. 
props scribu.
fixes #16793.

git-svn-id: https://develop.svn.wordpress.org/trunk@28600 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-28 13:49:21 +00:00
Sergey Biryukov
7b133a336f Remove obsolete code from wp_dashboard_setup(). 
props kitchin.
fixes #26604.

git-svn-id: https://develop.svn.wordpress.org/trunk@28592 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-27 15:40:19 +00:00
Sergey Biryukov
2f1ad4ddbf Move 'Documentation on date and time formatting' link under the 'Time Format' block. 
props gauravmittal1995.
fixes #28348.

git-svn-id: https://develop.svn.wordpress.org/trunk@28591 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-27 14:49:51 +00:00
Sergey Biryukov
86b88bd2b7 Add BMP to the list of displayable image types. 
props ericlewis.
fixes #26808.

git-svn-id: https://develop.svn.wordpress.org/trunk@28589 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-27 13:24:39 +00:00
Sergey Biryukov
c2076859eb Remove redundant get_shortcode_regex() check. 
props kovshenin.
see #28195.

git-svn-id: https://develop.svn.wordpress.org/trunk@28587 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-27 11:29:11 +00:00
Scott Taylor
792fe23675 When adding a URL in the Insert from URL state in the media modal, attempt to show a preview of the content. Drop the unused width and height fields. 
This will probably be iterated upon.

Props helen, jtsternberg, wonderboymusic.
See #15490.


git-svn-id: https://develop.svn.wordpress.org/trunk@28581 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-26 23:56:27 +00:00
Scott Taylor
8567bba0bf Don't pass embeds through the_content() when trying to render MCE previews, leverage WP_Embed and do_shortcode() instead. 
Props kovshenin.
See #28195.



git-svn-id: https://develop.svn.wordpress.org/trunk@28580 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-26 23:42:08 +00:00
Scott Taylor
5c3f7d5392 In media_sideload_image(), check the returned value of download_url() earlier to avoid attempting to unlink() an instance of WP_Error. 
Props georgestephanis. 
Fixes #28204.


git-svn-id: https://develop.svn.wordpress.org/trunk@28567 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-23 21:32:12 +00:00
Scott Taylor
a2b0c8b2e4 In get_terms_to_edit(), call get_object_term_cache() before priming cache with wp_get_object_terms(). 
In `get_inline_data()`, do the same.

On list table screens with taxonomies in the admin, this dramatically reduces the number of database queries (3x less). Even more so with a persistent object cache (5x less).

Props johnbillion, jeffstieler, wonderboymusic.
Fixes #18968.



git-svn-id: https://develop.svn.wordpress.org/trunk@28561 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-23 19:28:45 +00:00
Scott Taylor
a4e1ec0b90 Fix parsing in wp_match_mime_types() to allow some mime-types with + in them to appear in the list of filter links shown above the list table on upload.php. 
Props _duck.
Fixes #20672.



git-svn-id: https://develop.svn.wordpress.org/trunk@28553 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-22 21:35:36 +00:00
Scott Taylor
e53cdbb8f0 In wp_dashboard_recent_posts(), $i is set and never used. 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28545 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-22 18:55:07 +00:00
Scott Taylor
70342f4a75 $theme_name is set but no longer used in wp_dashboard_right_now(). The theme name is displayed with the call to update_right_now_message(). 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28544 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-22 18:53:43 +00:00
Scott Taylor
312ef7b264 These functions import $wpdb but do not use it. 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28539 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-22 17:36:42 +00:00
Sergey Biryukov
15588188e8 Fix inconsistent header underlining and spacing in background update emails. 
fixes #28306.

git-svn-id: https://develop.svn.wordpress.org/trunk@28537 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-22 09:40:36 +00:00
Sergey Biryukov
9966795165 Use correct function name. 
props ericlewis.
fixes #28329.

git-svn-id: https://develop.svn.wordpress.org/trunk@28535 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-22 07:58:26 +00:00
Scott Taylor
dc1ada20c7 Upgrade _WP_List_Table_Compat to PHP5-style constructor. 
Add `public` to methods/members of `WP_Role`.
Add `public` to methods/members of `WP_User` where appropriate. Don't set `private` where indicated until more study has occurred and tests have been written for compatibiliy with existing magic methods.

See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28531 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 17:19:09 +00:00
Scott Taylor
be2e5f6fb5 hackificator doesn't like mixed single/double-quoted attributes. These were 2 lingering instances in the admin. 
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28530 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 17:09:42 +00:00
Scott Taylor
d261d0030a In WP_Filesystem_Base, the constructor is a noop, so it shouldn't even be declared. Setting it implies that parent::__construct() should be called by its subclasses. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28529 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 16:45:42 +00:00
Scott Taylor
daecbc9659 Classes that have __set() also need __isset() and __unset(). 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28524 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 06:51:35 +00:00
Scott Taylor
77c6420969 Some classes with __get() method also need __set(). 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28521 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 06:31:00 +00:00
Scott Taylor
f716ff94e4 Add missing access modifiers to methods/members in Walker and subclasses. Add a magic __get() method. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28514 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 05:59:07 +00:00
Scott Taylor
e43d2a73d8 Fix some hackificator odds and ends in wp-admin: 
* `wp-activate.php` and `wp-admin/themes.php` don't need the closing PHP tag
* Switch single quotes for HTML attribute values to double in a few places
* Convert `include_once file.php` syntax to `include_once( 'file.php' )`
* Add access modifiers to methods/members in: `_WP_List_Table_Compat`, `Walker_Nav_Menu_Edit`, `Walker_Nav_Menu_Checklist`, `WP_Screen`, `Walker_Category_Checklist`
* `edit_user()` doesn't need to import the `$wpdb` global
* `wp_list_widgets()` doesn't need to import the `$sidebars_widgets` global
* switch/endswitch syntax is not supported in Hack
* A `<ul>` in `wp-admin/users.php` is unclosed

See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28500 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 05:03:44 +00:00
Drew Jaynes (DrewAPicture)
7b2c87df9a Improve inline documentation of default arguments for post_format_meta_box(), post_tags_meta_box(), and post_categories_meta_box(). 
See #28298.


git-svn-id: https://develop.svn.wordpress.org/trunk@28499 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 03:22:21 +00:00
Scott Taylor
eef0d99ed8 hackificator doesn't like mixed quote styles in some generated HTML. The switch from single to double allows these files to be parsed. 
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28497 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 01:58:28 +00:00
Scott Taylor
afe33f0f68 Add access modifier (public) to methods and members of WP_Upgrader and its subclasses. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28496 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 01:28:10 +00:00
Scott Taylor
17cabb1d8e Add access modifier (public) to methods and members of WP_Upgrader_Skin and its subclasses. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28495 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 01:22:55 +00:00
Scott Taylor
b1a09cf65d Add access modifiers to methods and members of WP_Users_List_Table. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28494 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 01:18:46 +00:00
Scott Taylor
d6a3c2a0de Add access modifiers to methods and members of list table classes: 
* `WP_List_Table` is the base class that implements `__get()` and `__call()` for BC
* Adds unit tests to confirm that subclasses properly inherit magic methods
* Add modifiers to subclasses: `WP_Links_List_Table`, `WP_Media_List_Table`, `WP_MS_Sites_List_Table`, `WP_MS_Themes_List_Table`, `WP_MS_Users_List_Table`, `WP_Plugin_Install_List_Table`, `WP_Plugins_List_Table`, `WP_Posts_List_Table`, `WP_Terms_List_Table`, `WP_Theme_Install_List_Table`, `WP_Themes_List_Table`

See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28493 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 01:16:16 +00:00
Scott Taylor
99c99b77e3 Add access modifier (public) to methods in WP_Importer. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28492 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 00:19:00 +00:00
Scott Taylor
ae31b3795c Add access modifier (public) to members and methods in WP_Filesystem_SSH2. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28491 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 00:17:18 +00:00
Scott Taylor
fce8b1e0c3 Add access modifier (public) to members and methods in WP_Filesystem_ftpsockets. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28490 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 00:13:29 +00:00
Scott Taylor
434ce7f6d8 Add access modifier (public) to members and methods in WP_Filesystem_FTPext. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28489 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 00:11:21 +00:00
Scott Taylor
ec06d96ce6 Add access modifier (public) to methods in WP_Filesystem_Direct. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28488 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 00:08:38 +00:00
Scott Taylor
06672a6c5a Add access modifiers to members and methods in WP_Filesystem_Base. Add magic __get() method for backwards compatibility. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28487 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 00:05:06 +00:00
Scott Taylor
6e09b1f167 Add access modifier (public) to members and methods in WP_Comments_List_Table and WP_Post_Comments_List_Table. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28486 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-18 23:58:38 +00:00
Scott Taylor
8af8f5f8f2 In edit-link-form.php, hackificator bails because there is a </form> with no open <form>. It exists, but is needlessly constructed with PHP. It always returns a <form>, only the id and name are different. The dynamic piece just returns the ID now. 
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28485 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-18 22:06:22 +00:00
Scott Taylor
4f74ef5466 hackificator bails on this file because of mixed quote styles on some HTML attributes. 
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28484 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-18 21:47:01 +00:00
Scott Taylor
c6919845ca Remove public keyword from some JS functions. Sorry. 
Props ocean90.
See #22234.



git-svn-id: https://develop.svn.wordpress.org/trunk@28483 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-18 21:42:32 +00:00
Scott Taylor
01fa4c0c1e hackificator bails on this file because the <meta> isn't self-closing. 
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28482 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-18 21:35:03 +00:00
Scott Taylor
e509190fb3 Use proper access modifiers and add a magic __get() method to Custom_Background and Custom_Image_Header. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28481 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-18 21:30:43 +00:00
Scott Taylor
1b4e4e665a hackificator complains if you call include 'file.php' without the parens, needs to be include( 'file.php' ) 
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28479 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-18 20:51:44 +00:00
Scott Taylor
af0851cc0d Because the WP_ADMIN constant name can be bound in multiple files, all instances should check ! defined first. wp-admin/admin.php already has this check. 
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28478 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-18 20:41:28 +00:00
Scott Taylor
f083cc4e9b The About page has a <div> that doesn't close. Also, <hr>s should self-close. hackificator complains about these things. 
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28477 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-18 20:32:58 +00:00
Sergey Biryukov
0cc180b0a4 Fix wp_insert_link(), broken in [28406]/[28408]. 
see #22400.

git-svn-id: https://develop.svn.wordpress.org/trunk@28475 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-18 09:55:16 +00:00
Drew Jaynes (DrewAPicture)
9e81d2d692 Add inline documentation for default arguments in wp_insert_category(). 
See #28298.


git-svn-id: https://develop.svn.wordpress.org/trunk@28474 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-18 07:27:25 +00:00
Sergey Biryukov
d56f67b8e9 Update help text on Add Themes screen. 
props thomasvanderbeek.
fixes #28132.

git-svn-id: https://develop.svn.wordpress.org/trunk@28473 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-17 23:43:41 +00:00
Scott Taylor
40e6ec443f Add inline comment after fix in [28467]. 
Props jesin.
Fixes #28292.



git-svn-id: https://develop.svn.wordpress.org/trunk@28468 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-17 15:41:40 +00:00
Scott Taylor
14a7b47119 Restore $soucrce in WP_Upgrader::install_package(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28467 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-17 15:39:33 +00:00
Scott Taylor
ccc874514c Eliminate use of extract() in request_filesystem_credentials(). 
The only property that doesn't need to be set to a variable is `$password`.

See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28456 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-16 18:25:41 +00:00
Andrew Ozz
6fa89637e5 DFW: fix closing only the wpLink or media modal when pressing Esc. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28455 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-16 18:16:59 +00:00
Scott Taylor
ec17088ff6 Update inline docs for wp_handle_upload|sideload to reflect their non-use of extract(). 
See #22400.



git-svn-id: https://develop.svn.wordpress.org/trunk@28452 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-16 17:40:44 +00:00
Scott Taylor
8f8b12e6a6 Eliminate use of extract() in wp_handle_sideload(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28451 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-16 16:14:56 +00:00
Scott Taylor
176d361626 Eliminate use of extract() in wp_handle_upload(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28450 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-16 16:10:00 +00:00
Sergey Biryukov
6100833f0c DFW: Properly handle Esc key when the content is focused or when switching browser tabs. 
props avryl.
fixes #28279.

git-svn-id: https://develop.svn.wordpress.org/trunk@28443 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-16 10:42:03 +00:00
wonderboymusic
30dcd2c3e9 Eliminate the use of extract() in WP_Upgrader. 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28418 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 05:01:02 +00:00
Scott Taylor
650e0580e4 Eliminate one of the uses of extract() in wp_handle_upload(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28417 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 04:30:32 +00:00
Scott Taylor
219ad73200 Eliminate one of the uses of extract() in wp_handle_sideload(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28416 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 04:28:24 +00:00
Scott Taylor
c4b23f9fc3 Eliminate use of extract() in Walker_Category_Checklist::start_el(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28411 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 03:13:44 +00:00
Scott Taylor
85d6f8e54f Eliminate use of extract() in wp_terms_checklist(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28410 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 03:08:46 +00:00
Scott Taylor
98ca12ef2e Eliminate use of extract() in wp_star_rating(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28409 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 02:56:56 +00:00
Scott Taylor
5e046b92fd (REALLY) Eliminate use of extract() in wp_insert_link(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28408 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 02:54:27 +00:00
Scott Taylor
27ff2a1cd0 Eliminate use of extract() in get_media_item(). 
To test, fire open the old media in the console: `tb_show('Old Media is Weird', 'media-upload.php?type=image&TB_iframe=true&post_id=0');`	
	
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28407 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 02:45:01 +00:00
Scott Taylor
e0ddd2ebf0 Eliminate use of extract() in wp_insert_link(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28406 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 02:27:55 +00:00
Scott Taylor
46f15a84ab Eliminate use of extract() in display_setup_form(). Only needs to read password and password_message. 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28396 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-14 16:42:42 +00:00
Drew Jaynes (DrewAPicture)
cfc1b74ddb Properly split and document the admin_post* actions into the following four hooks: 
* `admin_post_nopriv` – for logged-out requests lacking a supplied action
* `admin_post_nopriv_$action – for logged-out requests with a supplied action
* `admin_post` – for logged-in requests lacking a supplied action
* `admin_post_$action` – for logged-in requests with a supplied action

See [28349], [28350], [28351].
See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28394 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 07:23:35 +00:00
Drew Jaynes (DrewAPicture)
1954f9b7d4 Clarify inline documentation for back-compat load-* action hooks. 
See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28393 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 06:27:11 +00:00
Scott Taylor
bc17731c23 Eliminate use of extract() in post_tags_meta_box() and post_categories_meta_box(). 
Both functions only need to read `taxonomy`, yet they extract every available variable from `$box['args']`. Even if those variables were useful, there is no attempt to pass them to anything, and scope in PHP does not allow them to be scooped up by inner functions without being passed directly.
	
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28391 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 05:47:03 +00:00
Scott Taylor
b72bd1c40f Eliminate use of extract() in WP_Terms_List_Table::display_rows_or_placeholder(): 
* Set variables for `$page` and `$number`
* `list(...) = $this->get_column_info()` can be removed, as none of the variables returned are used.
* `orderby` and `search` can be checked from `$args`, leaving no reason to extract		

See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28390 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 05:36:22 +00:00
Scott Taylor
7c0e12f5c6 Eliminate use of extract() in WP_List_Table::pagination(): 
* Set variables instead of extracting `$this->_pagination_args`
* Weird: `$infinite_scroll` is only presently set in subclasses of `WP_List_Table` and never initialized otherwise. 		

See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28389 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 05:26:34 +00:00
Scott Taylor
31e187faa3 Eliminate use of extract() in WP_Plugin_Install_List_Table::get_table_classes(). It only needs to read plural, no need to extract. 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28388 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 05:16:39 +00:00
Scott Taylor
fac2faee93 Eliminate use of extract() in WP_List_Table::ajax_response(): 
* Extracting `$this->_args` is unnecessary since none of the variables produced are present in the method.
* `total_items` and `total_pages` can be read directly from `$this->_pagination_args`

See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28387 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 05:13:09 +00:00
Scott Taylor
a2122e6f7b Eliminate use of extract() in WP_List_Table::display(). The method only needs to read singular from $this->_args. Extraction is unnecessary. 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28386 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 05:07:11 +00:00
Scott Taylor
878a974477 Eliminate use of extract() in WP_Post_Comments_List_Table::display(). The method only needs to read singular from $this->_args. Extraction is unnecessary. 
Eliminate use of `extract()` in `WP_Comments_List_Table::display()`. The method uses no variables. Extraction can be completely removed.

See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28385 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 05:03:26 +00:00
Scott Taylor
f57bdbd238 Eliminate use of extract() in Custom_Image_Header::step_2(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28384 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 04:53:13 +00:00
Drew Jaynes (DrewAPicture)
68f78b1dcc Clarify documentation for *what* gets "automatically fired" when the do_mu_upgrade filter evaluates to true in Multisite. 
See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28376 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 04:17:16 +00:00
Drew Jaynes (DrewAPicture)
d59c371180 Fix incomplete inline documentation for the wp_header_image_attachment_metadata filter. 
See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28375 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 04:12:02 +00:00
Scott Taylor
4e0809e3e4 Eliminate use of extract() in wp_insert_category(). Adds unit tests. All unit tests pass. 
Props MikeHansenMe.
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28374 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 03:26:51 +00:00
Scott Taylor
3f59b86ec5 In media_upload_gallery_form()'s inline JavaScript, remove unnecessary comment tags. 
Fixes #25637.



git-svn-id: https://develop.svn.wordpress.org/trunk@28368 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-11 06:11:08 +00:00
Scott Taylor
3a554b5249 In wp_read_image_metadata(), the values from exif_read_data() should only override values from iptcparse() that are empty. 
Props SergeyBiryukov.
Fixes #23706.


git-svn-id: https://develop.svn.wordpress.org/trunk@28367 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-11 05:53:27 +00:00
Scott Taylor
147eeb2147 Avoid a notice in wp_save_image() by checking $meta['sizes']['thumbnail'] for ! empty() before setting a variable to it. 
Props MikeHansenMe.
Fixes #17736.



git-svn-id: https://develop.svn.wordpress.org/trunk@28366 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-11 03:41:31 +00:00
Scott Taylor
d007994bf3 In WP_Terms_List_Table::single_row(), call sanitize_term() on the passed term ($tag). 
Props oso96_2000, c3mdigital, scribu. 
It takes a village.
Fixes #16864.


git-svn-id: https://develop.svn.wordpress.org/trunk@28360 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-11 00:04:38 +00:00
Scott Taylor
a398f38024 First pass at wpview logic for the [embed] shortcode. URLs on a their own line are parsed as well. The toolbar will appear with the "remove" button when the view is clicked. Edit has not been implemented yet. 
Props avryl, wonderboymusic.
See #28195.



git-svn-id: https://develop.svn.wordpress.org/trunk@28358 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-10 23:35:08 +00:00