sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
28,981 Commits 2 Branches 473 Tags 137 MiB
4958dd8998
Commit Graph

2294 Commits

Author SHA1 Message Date
Andrew Ozz
107d754683 Add default z-index to the admin menu, see #29806 
git-svn-id: https://develop.svn.wordpress.org/trunk@29841 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-06 01:59:46 +00:00
Sergey Biryukov
65a0f4933a Network Admin: Properly check if the theme is active on the main site to avoid deleting it via bulk actions. 
props ocean90.
fixes #29861.

git-svn-id: https://develop.svn.wordpress.org/trunk@29839 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-05 20:36:11 +00:00
Andrew Ozz
d2c8c72e7f Pin the admin menu on scrolling similarly to how the side metaboxes are pinned on the Edit Post screen, first run. See #29806. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29835 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-05 03:08:11 +00:00
Scott Taylor
11c914bca9 In the admin, give media list table icons auto for width and height. In the post thumbnail metabox, apply width: auto. 
If someone turns on support SVG files, this will allow them to show up.

Props arippberger for an initial patch.
Fixes #26256.


git-svn-id: https://develop.svn.wordpress.org/trunk@29832 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-03 19:07:17 +00:00
Dominik Schilling (ocean90)
f7a4e22bdb Plugin search: Wrap results in a form to fix pagination's paged input field. 
props jesin, ocean90.
see #18724, for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@29829 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-03 13:07:18 +00:00
Sergey Biryukov
7d2f7c6ceb Switch line-height added in [29790] to a unitless value. 
props janhenckens.
fixes #29451.

git-svn-id: https://develop.svn.wordpress.org/trunk@29828 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-03 09:41:24 +00:00
Sergey Biryukov
3d0f4d9656 Use correct links for filtering plugin reviews. 
props OriginalEXE.
fixes #29754.

git-svn-id: https://develop.svn.wordpress.org/trunk@29826 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-03 08:08:27 +00:00
Sergey Biryukov
990f01f81f Avoid a PHP notice in list_plugin_updates() if plugins_api() returned a WP_Error object. 
fixes #29583.

git-svn-id: https://develop.svn.wordpress.org/trunk@29825 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-03 00:01:51 +00:00
Sergey Biryukov
32dbb27701 * Use correct context for 'Name' and 'Parent' strings on taxonomy screens. 
* Remove unnecessary context for 'Slug' and 'Description' strings.

props andg.
fixes #29824.

git-svn-id: https://develop.svn.wordpress.org/trunk@29821 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-02 20:00:11 +00:00
Sergey Biryukov
c231361790 Use a more consistent markup on taxonomy and user screens. 
props paulwilde.
fixes #29842.

git-svn-id: https://develop.svn.wordpress.org/trunk@29820 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-02 19:39:14 +00:00
Scott Taylor
dcef5d4583 In activate_plugin(), do not re-run the activation routine for already-active network-wide plugins. 
Adds unit test.

Props jbrinley.
Fixes #28651.


git-svn-id: https://develop.svn.wordpress.org/trunk@29818 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-02 15:55:51 +00:00
Scott Taylor
46b4ea2a6c Network Admin Menu: 
* Don't display update count for Themes when the user doesn't have the 'update_themes' cap
* Don't display update count for Plugins when there aren't any/count is `0`

Props peterchester.
Fixes #29651.


git-svn-id: https://develop.svn.wordpress.org/trunk@29817 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-02 15:48:36 +00:00
Sergey Biryukov
f4c6eb964b When switching to the Text editor, make the textarea visible to screen readers. 
props afercia.
fixes #29815.

git-svn-id: https://develop.svn.wordpress.org/trunk@29815 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-02 12:45:42 +00:00
Scott Taylor
7711e9648c Media Grid/List Table parity: when MEDIA_TRASH is true and trash is the current filter for the grid, add a second bulk action button: "Delete Selected" 
Fixes #29742.


git-svn-id: https://develop.svn.wordpress.org/trunk@29811 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-02 04:12:01 +00:00
Scott Taylor
ec93f031b3 Media List Table: account for MEDIA_TRASH in the bulk action dropdown. 
See #29742.


git-svn-id: https://develop.svn.wordpress.org/trunk@29810 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-02 03:11:49 +00:00
Sergey Biryukov
c313878af2 Reorder placeholders for consistency. see [29806]. 
see #21089.

git-svn-id: https://develop.svn.wordpress.org/trunk@29807 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-02 01:37:05 +00:00
Scott Taylor
3a11531451 In the wp_new_blog_notification() email template, include the login url. 
Props obenland, georgestephanis.
Fixes #21089.


git-svn-id: https://develop.svn.wordpress.org/trunk@29806 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-02 01:27:57 +00:00
Sergey Biryukov
c4fcdf329e Add classes to form containers on Edit User screen. 
props jarednova.
fixes #29348.

git-svn-id: https://develop.svn.wordpress.org/trunk@29804 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-02 00:55:40 +00:00
Sergey Biryukov
d59e6696b3 Add classes to form containers on taxonomy screens. 
props jarednova.
fixes #28196.

git-svn-id: https://develop.svn.wordpress.org/trunk@29803 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-02 00:28:45 +00:00
Sergey Biryukov
f6753a316a Change the default orderby value in wp_get_nav_menus() to 'name'. 
props voldemortensen, igmoweb.
fixes #29460.

git-svn-id: https://develop.svn.wordpress.org/trunk@29792 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-29 15:44:26 +00:00
Sergey Biryukov
8cc322b073 Fix padding for parent theme link on Edit Themes screen. 
props kraftner.
fixes #27825.

git-svn-id: https://develop.svn.wordpress.org/trunk@29791 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-29 14:09:38 +00:00
Sergey Biryukov
dfc018ccf9 Account for longer translations of 'Customize Your Site' button label. 
props shooper.
fixes #29451.

git-svn-id: https://develop.svn.wordpress.org/trunk@29790 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-29 13:56:34 +00:00
Mark Jaquith
be8a0c6f89 Use HTTPS URLs for trac.wordpress.org (and use core.trac.wordpress.org) 
see #27115

git-svn-id: https://develop.svn.wordpress.org/trunk@29789 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-29 13:36:38 +00:00
Mark Jaquith
7063377539 Use HTTPS URLs for core.trac.wordpress.org 
see #27115

git-svn-id: https://develop.svn.wordpress.org/trunk@29788 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-29 13:27:55 +00:00
Mark Jaquith
4c22a5003b Use HTTPS links for planet.wordpress.org 
see #27115

git-svn-id: https://develop.svn.wordpress.org/trunk@29787 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-29 13:23:46 +00:00
Sergey Biryukov
029d1dbaa4 Use a more specific selector for the count displayed on Add Themes network admin screen. 
props mantismamita, nikolov.tmw.
fixes #29421.

git-svn-id: https://develop.svn.wordpress.org/trunk@29786 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-29 13:06:17 +00:00
Mark Jaquith
7402030670 Show the number of approved comments instead of all comments on 
the dashboard in the "At a glance" section.

fixes #26738. props benjmay

git-svn-id: https://develop.svn.wordpress.org/trunk@29785 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-29 12:41:49 +00:00
Scott Taylor
37da833fce In the form handler logic for edit-tags.php, don't redirect until $_REQUEST['paged'] has been checked. All switch cases (except edit) now use break instead of exit. 
Fixes #16162.


git-svn-id: https://develop.svn.wordpress.org/trunk@29782 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-29 04:53:07 +00:00
Andrew Ozz
3b757232d0 Media: disable multi-file uploading in iOS 7.x Safari as it prevents uploading of videos. Fixes #29602 for trunk. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29776 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-29 00:13:47 +00:00
Sergey Biryukov
2e58e91dcc Remove unnecessary CSS overriding on Add Plugins screen. 
props pavelevap.
fixes #29753.

git-svn-id: https://develop.svn.wordpress.org/trunk@29775 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-28 20:25:33 +00:00
Sergey Biryukov
9e5beefd72 Don't display an empty comment author IP link on Comments screen. 
props afercia.
fixes #29766.

git-svn-id: https://develop.svn.wordpress.org/trunk@29774 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-28 06:37:10 +00:00
Andrew Ozz
d34a54f1e4 Fix tapping on the menu in iOS and Android, fixes #29365 for trunk 
git-svn-id: https://develop.svn.wordpress.org/trunk@29770 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-26 23:01:52 +00:00
Sergey Biryukov
c993055800 Remove extra space from a string. 
props pavelevap.
fixes #29752.

git-svn-id: https://develop.svn.wordpress.org/trunk@29767 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-26 18:48:05 +00:00
Scott Taylor
22db82dff1 In wp_ajax_replyto_comment(), if $_POST['comment_type'] is set, use it for the value of $comment_type, which the compact() call has assumed is set since [8720]. It never was. 
`wp_comment_reply()`'s output can be complete overridden by the `wp_comment_reply` filter, so this check is justified and makes the AJAX callback more flexible.

Props nerrad.
Fixes #29704.


git-svn-id: https://develop.svn.wordpress.org/trunk@29758 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-23 03:28:51 +00:00
Scott Taylor
e97e5048c3 If the current user does not have the delete_posts cap on the current post type, don't list delete or trash as bulk actions for the relevant context of Post list table. 
Props mvd7793.
Fixes #20175.


git-svn-id: https://develop.svn.wordpress.org/trunk@29757 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-23 02:57:43 +00:00
Sergey Biryukov
994566bb17 Pass the attachment ID to the 'image_add_caption_text' filter. 
fixes #29607.

git-svn-id: https://develop.svn.wordpress.org/trunk@29754 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-21 10:10:19 +00:00
Sergey Biryukov
9e673c7eee Add 'image_add_caption_text' filter for changing the pre-parse caption text before output to the editor. 
props collinsinternet, DrewAPicture.
fixes #29607.

git-svn-id: https://develop.svn.wordpress.org/trunk@29753 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-21 09:55:08 +00:00
Andrew Nacin
9c751b268a Don't set ftp_credentials option when installling. see #29635. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29749 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-17 17:57:59 +00:00
wonderboymusic
578609d31e Make the URL output in _thickbox_path_admin_subfolder() use includes_url(). 
Props voldemortensen.
Fixes #14157.


git-svn-id: https://develop.svn.wordpress.org/trunk@29741 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-12 22:30:03 +00:00
Andrew Ozz
a9384b7a30 Editor expand: hide TinyMCE float panels and tooltips when scrolling, props avryl, fixes #29516 for trunk. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29738 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-12 01:20:09 +00:00
Scott Taylor
6ed8bab324 In media_handle_upload(), don't call wp_read_image_metadata() on things that aren't images (like videos). We never caught this error, because we are suppressing it by calling @wp_read_image_metadata(). 
Props jrf for the initial patch.
Fixes #28907.


git-svn-id: https://develop.svn.wordpress.org/trunk@29737 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-11 20:14:56 +00:00
Andrew Ozz
123fae73b5 Media: revert enabling of multi-file uploading for mobile devices. Currently only iOS Safari supports it but has a bug that prevents uploading of videos. Fixes #29602 
git-svn-id: https://develop.svn.wordpress.org/trunk@29729 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-10 22:39:39 +00:00
Scott Taylor
698f77735b Don't overwrite the length property unnecessarily when generating metadata for audio and video files. 
Props jrf, wonderboymusic.
Fixes #29176.


git-svn-id: https://develop.svn.wordpress.org/trunk@29728 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-10 21:56:24 +00:00
Sergey Biryukov
69b97690d5 Widgets: Toggle widget arrow when the widget is closed using Close link. 
props senff.
fixes #29617.

git-svn-id: https://develop.svn.wordpress.org/trunk@29726 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-10 17:35:38 +00:00
Sergey Biryukov
9c48d0f495 Make sure we're on the media grid page before calling wp.media(). 
props azaozz.
fixes #29520 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@29725 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-09 10:13:33 +00:00
Sergey Biryukov
8cfdbf1167 Use https for apps.wordpress.org links. 
props pento.
fixes #29595 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@29721 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-09 06:28:33 +00:00
Sergey Biryukov
d552ba29bc * Declare $site_mimes before using it in check_upload_mimes(). 
* Use the same default value for 'upload_filetypes' as on Network Settings screen.

props rmccue.
fixes #29512 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@29718 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-07 10:10:33 +00:00
Sergey Biryukov
12bffd9665 Use home URL instead of example.org on Permalink Settings screen. 
props voldemortensen, jesin.
fixes #29509.

git-svn-id: https://develop.svn.wordpress.org/trunk@29716 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-07 09:43:48 +00:00
Helen Hou-Sandi
5771e6e1d5 About: Make sure the images are properly responsive. 
props ocean90.
see #29494.


git-svn-id: https://develop.svn.wordpress.org/trunk@29708 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-04 15:23:51 +00:00
Andrew Nacin
ca32a2d410 Pinking shears. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29707 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-04 15:22:58 +00:00
helen
f07a9f28a8 Final about page for 4.0. Enjoy the videos! 
props ryelle, melchoyce, smashcut, wonderboymusic, helen.
fixes #29494.


git-svn-id: https://develop.svn.wordpress.org/trunk@29706 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-04 15:04:02 +00:00
Andrew Nacin
3d698699be i18n: Skip language chooser for localized packages. 
Also fixes the install.php welcome string, which was not bring printed.

fixes #29487.


git-svn-id: https://develop.svn.wordpress.org/trunk@29705 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-04 14:38:17 +00:00
Andrew Nacin
84681ddd39 Link to apps.wordpress.org instead of wordpress.org/mobile. 
props pento.
fixes #29496.


git-svn-id: https://develop.svn.wordpress.org/trunk@29703 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-04 14:21:13 +00:00
Helen Hou-Sandi
2d07fb1b59 Media: Swap in a new icon for the grid mode. 
props melchoyce.
fixes #29353.


git-svn-id: https://develop.svn.wordpress.org/trunk@29702 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-04 14:13:46 +00:00
Andrew Nacin
d53bee91c6 Add 'Release Lead' string to credits. see #29494. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29700 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-03 23:18:37 +00:00
Andrew Ozz
44466b7627 Editor expand: revert back to scrolling to the editor top when switching Visual to Text, fixes #29338 
git-svn-id: https://develop.svn.wordpress.org/trunk@29698 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-03 18:03:43 +00:00
Helen Hou-Sandi
f5e371608c Modals: Remove yet more cruft that was causing unwanted coloration of icons. 
props celloexpressions.
fixes #29147 (for real this time).


git-svn-id: https://develop.svn.wordpress.org/trunk@29697 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-03 17:05:38 +00:00
Sergey Biryukov
0df3044683 Restore the post type's view_item label for preview links that don't submit the changes. 
fixes #28350.

git-svn-id: https://develop.svn.wordpress.org/trunk@29695 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-03 11:32:52 +00:00
Dominik Schilling (ocean90)
350152b49e Language Pack Upgrader: Allow to disable asynchronously translation updates. 
* Don't touch VCS installs.
* Use the `async_update_translation` filter (which corresponds exactly to `auto_update_translation`) to entirely disable it, or based on the update offer. 

props nacin, ocean90.
fixes #28571.

git-svn-id: https://develop.svn.wordpress.org/trunk@29694 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-03 10:37:21 +00:00
Helen Hou-Sandi
c529b75886 Editor scrolling: Remember and restore scroll position for visual and text modes. 
This prevents the editor from jumping off screen when the rendered visual content is significantly taller than plain text, e.g. when there are views present.

This is also a close restoration of 3.9 behavior, some of which was browser-specific.

props avryl.
fixes #29338.


git-svn-id: https://develop.svn.wordpress.org/trunk@29693 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-03 09:57:56 +00:00
Andrew Nacin
7716dae9fa Editor scrolling: Avoid jumping to the cursor when modifier and scrolling keys are pressed. 
fixes #29485.


git-svn-id: https://develop.svn.wordpress.org/trunk@29692 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-03 09:37:01 +00:00
Andrew Nacin
de3b2ccf19 Allow language specified by the WPLANG constant (but not installed) to be chosen. 
fixes #29456.


git-svn-id: https://develop.svn.wordpress.org/trunk@29691 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-03 08:02:53 +00:00
Andrew Nacin
acbd7696ee Media Library: Fix media trash handling. 
props ocean90, obenland.
fixes #29469.


git-svn-id: https://develop.svn.wordpress.org/trunk@29690 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-03 06:46:34 +00:00
Helen Hou-Sandi
53f56ffb0f Media: Better padding for attachment items. 
props avryl.
fixes #29085.


git-svn-id: https://develop.svn.wordpress.org/trunk@29687 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-03 06:27:34 +00:00
Dion Hulse
a01096b872 Language Pack Upgrader: Remove ALL pre-existing filters before performing a translation update these filters may act in an unexpected way during the upgrade process. 
See #29230. Fixes #29425.


git-svn-id: https://develop.svn.wordpress.org/trunk@29685 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-03 05:37:33 +00:00
Andrew Nacin
609eb61a1c About page: Remove reference to not-yet-operational translated plugins/themes directories. 
props stephdau.
see #29391.


git-svn-id: https://develop.svn.wordpress.org/trunk@29684 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-03 02:36:23 +00:00
Andrew Nacin
0ab1df4243 Ensure oEmbed previews listen to [embed] width/height attributes. 
props azaozz.
fixes #29474.


git-svn-id: https://develop.svn.wordpress.org/trunk@29681 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-03 00:39:05 +00:00
Helen Hou-Sandi
2cb48c1039 Plugin install: Better styling to accommodate plugin icons. 
fixes #29466.


git-svn-id: https://develop.svn.wordpress.org/trunk@29679 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-02 19:46:19 +00:00
Helen Hou-Sandi
cb298d8341 Plugin install: Make sure h3's clear floats to avoid layout problems. 
props SergeyBiryukov.
fixes #29465.


git-svn-id: https://develop.svn.wordpress.org/trunk@29676 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-02 18:28:23 +00:00
Dominik Schilling (ocean90)
1c82a3bf80 Language Pack Upgrader: Check return value before accessing the first array key. 
Prevents a fatal error when Language_Pack_Upgrader::bulk_upgrade() returns a WP_Error object.

fixes #29470.

git-svn-id: https://develop.svn.wordpress.org/trunk@29675 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-02 18:27:12 +00:00
Helen Hou-Sandi
3ae3ae5ab2 Modals: Remove some remnant unnecessary blue glow focus styling. 
fixes #29147.


git-svn-id: https://develop.svn.wordpress.org/trunk@29674 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-02 18:26:18 +00:00
Dominik Schilling (ocean90)
c680af75e8 Install: Only show the language chooser when we have access to the filesystem without asking for credentials. 
fixes #29397.

git-svn-id: https://develop.svn.wordpress.org/trunk@29673 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-02 18:06:36 +00:00
Dominik Schilling (ocean90)
97921c9fa5 Menus: Improve performance for title live updating. Add change event for IE < 9. 
props helen, SergeyBiryukov.
fixes #23076.

git-svn-id: https://develop.svn.wordpress.org/trunk@29672 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-02 13:22:14 +00:00
Sergey Biryukov
bd07f41256 Restore 'insert-media-button' as an ID attribute for the first instance of media_buttons(). Remove IDs for subsequent instances. 
props nacin.
fixes #28090.

git-svn-id: https://develop.svn.wordpress.org/trunk@29671 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-02 09:07:08 +00:00
Sergey Biryukov
81d1c6d2c4 Use wp_admin_css() to enqueue stylesheets in setup-config.php. 
fixes #29464.

git-svn-id: https://develop.svn.wordpress.org/trunk@29670 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-02 08:53:23 +00:00
Sergey Biryukov
21aa7259c4 Re-initialize $wp_locale global after changing the default textdomain on installation screens. 
props ocean90.
fixes #29452.

git-svn-id: https://develop.svn.wordpress.org/trunk@29669 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-02 08:09:56 +00:00
Andrew Nacin
7bdd5a7a2e Plugin install: The sort callback doesn't need to be public. 
props helen.
fixes #28673.


git-svn-id: https://develop.svn.wordpress.org/trunk@29666 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-02 06:50:48 +00:00
Helen Hou-Sandi
2f71d7d8e4 Comments: Simplify JS for inline edit and reply. 
fixes #27533.


git-svn-id: https://develop.svn.wordpress.org/trunk@29662 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-02 03:56:05 +00:00
Helen Hou-Sandi
e12d2db484 Media: Translate a string for the search placeholder. 
props alex-ye.
fixes #29448.


git-svn-id: https://develop.svn.wordpress.org/trunk@29659 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-01 19:53:37 +00:00
Andrew Ozz
c3222171cd Editor expand: 
- Adjust calculation when comparing sidebar position to wpfooter top. Fixes an annoying jumping when the user scrolls off the bottom.
- Use a var for the 'bottom' distance of the sidebar.
- Fix sidebar pinning when it's height is nearly the same as the viewport height.
Fixes #29349

git-svn-id: https://develop.svn.wordpress.org/trunk@29656 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-01 18:48:07 +00:00
Andrew Ozz
1f2ff1d3f3 Editor expand: add docs for the wp_editor_expand filter, props DrewAPicture, fixes #29423 
git-svn-id: https://develop.svn.wordpress.org/trunk@29654 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-29 02:37:59 +00:00
Andrew Ozz
fcc188193f Editor expand: add a filter to turn it off from PHP, fixes #29423 
git-svn-id: https://develop.svn.wordpress.org/trunk@29653 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-29 02:27:06 +00:00
Helen Hou-Sandi
5d2038c8cd Sync tagline from about page with credits and freedoms. 
props rickalee.
fixes #29409.


git-svn-id: https://develop.svn.wordpress.org/trunk@29652 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-28 17:52:16 +00:00
Sergey Biryukov
368e2ba299 Fix typo in media help text. 
props tai.
fixes #29412.

git-svn-id: https://develop.svn.wordpress.org/trunk@29651 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-28 07:52:13 +00:00
Helen Hou-Sandi
1a1343dbd0 Correct a Sass typo that somehow slipped by in [29616]. 
see #28267.


git-svn-id: https://develop.svn.wordpress.org/trunk@29648 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-27 06:31:22 +00:00
Helen Hou-Sandi
2092bd3092 Help tabs: Update media help text to reflect 4.0. 
fixes #28654.


git-svn-id: https://develop.svn.wordpress.org/trunk@29646 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-27 06:11:28 +00:00
Helen Hou-Sandi
5c64d1f25b Media library: Ensure the header area is spaced consistently between view modes. 
see #28946.


git-svn-id: https://develop.svn.wordpress.org/trunk@29645 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-27 05:39:40 +00:00
Helen Hou-Sandi
2db9b4be18 About page, at last. 
All strings are available for translation. We anticipate few, if any, changes before release. Images and video will be moved to w.org soon.

props ryelle, melchoyce, nacin, MarkJaquith, helen, DrewAPicture, kpdesign.
fixes #29243.


git-svn-id: https://develop.svn.wordpress.org/trunk@29643 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-27 04:39:14 +00:00
Andrew Nacin
04da8db743 Help tabs: Update plugin install and media help text to reflect 4.0. 
see #28654.


git-svn-id: https://develop.svn.wordpress.org/trunk@29642 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-27 04:38:12 +00:00
Helen Hou-Sandi
f1f0eb61ff Media: views_upload filter expects an array, not a string. 
see #28946.


git-svn-id: https://develop.svn.wordpress.org/trunk@29641 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-27 03:06:00 +00:00
Andrew Nacin
61ce27e467 Adjust [29634] so the Upload Plugin button can be shown. see #29236. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29637 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-27 02:58:46 +00:00
Andrew Nacin
8564e3a491 Plugin installer: Minor adjustments to aid with discovery. 
fixes #29387.


git-svn-id: https://develop.svn.wordpress.org/trunk@29636 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-27 02:52:29 +00:00
Andrew Nacin
322991024f Plugin/Theme Uploads: New capabilities; unify UIs; ensure compatibility with old filters. 
Introduce upload_plugins and upload_themes capabilities to allow blocking of plugin and theme uploads, versus the old hacky (and not secure) ways of just hiding UI tabs. These are simply meta capabilities that map to install_plugins and install_themes.
 
Also:
 * Use the same nice design for the plugin upload screen as the theme upload screen.
 * Better compatibility for the old install_themes_tabs filter added in [29002]. see #28578.
 * Ensure using the install_plugins_tabs filter to remove the upload tab removes the new button.
 * Use 'Add Plugins' instead of 'Install Plugins' to match 'Add Themes'.

fixes #29236.


git-svn-id: https://develop.svn.wordpress.org/trunk@29634 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-27 01:31:05 +00:00
Dominik Schilling (ocean90)
8ee417d4f4 Language Form: The language option for $wp_local_package should get the same attributes as the other languages. 
see #15677.

git-svn-id: https://develop.svn.wordpress.org/trunk@29633 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-26 22:26:43 +00:00
Helen Hou-Sandi
07ba5160c3 Media modals: Better responsive views, especially the header. 
* Only show the "dropdown" when there is a menu. Note that this uses a `:not()` selector, but it is supported in browsers that support media queries so it is safe to use here.
* Make the header shorter when on particularly narrow screens, which also tend to be shorter.
* Don't restrict the height of images in the attachment details modal, to take advantage of all available space.

fixes #29339.


git-svn-id: https://develop.svn.wordpress.org/trunk@29632 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-26 21:49:39 +00:00
Dominik Schilling (ocean90)
1f793ea9b2 Language packs: No WPLANG anymore. 
* The WPLANG constant is no longer needed. Remove define('WPLANG', ''); from wp-config-sample.php. Populate WPLANG option based on the WPLANG constant. When get_option('WPLANG') is an empty string it will override WPLANG.
* Introduce translations_api() which is available to communicate with the translation API. Move translation install related functions to a new file.
* Replace mu_dropdown_languages() with wp_dropdown_languages(). wp_dropdown_languages() is now populated by the translation API.
* Remove wp_install_load_language() and allow load_default_textdomain() to switch a core translation.

fixes #13069, #15677, #19760, #28730, #29281. 

git-svn-id: https://develop.svn.wordpress.org/trunk@29630 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-26 19:58:33 +00:00
Helen Hou-Sandi
1121aad86e Editor scrolling: reduce the amount of height jumping on load. 
props avryl.
fixes #29307.


git-svn-id: https://develop.svn.wordpress.org/trunk@29628 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-26 18:38:26 +00:00
Helen Hou-Sandi
ad66613c02 Give pagination controls some breathing room on smaller screens. 
props stephdau.
fixes #29369.


git-svn-id: https://develop.svn.wordpress.org/trunk@29627 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-26 17:06:51 +00:00
Helen Hou-Sandi
ca1c677db5 Fix a CSS typo from [29625]. see #28946. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29626 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-26 17:03:52 +00:00
Helen Hou-Sandi
0c53a2d22d Media library: Unify headers between view modes. 
Includes back compat for `views_upload` links. These look a little awkward, but do not appear to be commonly used. Also prevents the view mode links from being dropped on smaller screens so a user doesn't get "stuck" in the list view.

This is different from other list tables, but aligns well with other uploaded content management screens (themes, plugins).

props pento, helen.
fixes #28946.


git-svn-id: https://develop.svn.wordpress.org/trunk@29625 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-26 15:57:20 +00:00
Helen Hou-Sandi
dfab26daf0 Plugin details: Fix review scrolling in some browsers (cough, Chrome). 
Remove some unnecessary CSS from [29619].

fixes #29321.


git-svn-id: https://develop.svn.wordpress.org/trunk@29624 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-26 13:45:23 +00:00
Dominik Schilling (ocean90)
6e8defd150 RTL: Fix modal alignments. 
* Prevent horizontal scrollbars in Chrome.
* URL fields should be always LTR.
* Force the plugin details to be LTR for all screens, see #19778.

fixes #29352.

git-svn-id: https://develop.svn.wordpress.org/trunk@29623 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-26 12:54:23 +00:00
Dominik Schilling (ocean90)
5109e1cacb Theme Upgrader: Set is_multi to true when doing bulk upgrades. 
fixes #29234.

git-svn-id: https://develop.svn.wordpress.org/trunk@29622 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-26 09:23:10 +00:00
Dominik Schilling (ocean90)
3a061c9743 Language Pack Upgrader: Remove any pre-existing package checks and then set the new one for translations. 
fixes #29230.

git-svn-id: https://develop.svn.wordpress.org/trunk@29621 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-26 09:19:17 +00:00
Helen Hou-Sandi
8f66ff570e Plugin details: better review styling. 
props Clorith, celloexpressions.
fixes #29321.


git-svn-id: https://develop.svn.wordpress.org/trunk@29619 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-26 05:49:00 +00:00
Helen Hou-Sandi
ee43238413 Restore spacing on the edit screen when a post type supports title but not editor. 
props avryl.
fixes #28893.


git-svn-id: https://develop.svn.wordpress.org/trunk@29618 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-26 05:24:55 +00:00
Helen Hou-Sandi
16e9426675 Focus styling: bring the blue glow to more places. 
Handles color picker, theme browser, help/screen options, TinyMCE dialog buttons, jQuery UI dialog buttons, and buttons in color schemes.

props avryl, celloexpressions. fixes #28267.


git-svn-id: https://develop.svn.wordpress.org/trunk@29616 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-26 05:16:14 +00:00
Scott Taylor
c88c4d4f21 MCE View sandboxes: 
* Use a `MutationObserver` to listen to the `body` class of the parent editor frame.
* In `wpview_media_sandbox_styles()`, only return the MEjs stylesheets.
* In `wp_ajax_parse_media_shortcode()` and `wp_ajax_parse_embed()`, return an object instead of an HTML blob to allow passing `body` and `head` separately	

Props avryl, azaozz.
Fixes #29048.


git-svn-id: https://develop.svn.wordpress.org/trunk@29615 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-26 04:45:54 +00:00
Helen Hou-Sandi
b2ee87b291 Media: Fix keying of selected attachments to color schemes. 
props celloexpressions. see #28822.


git-svn-id: https://develop.svn.wordpress.org/trunk@29614 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-26 04:36:53 +00:00
Helen Hou-Sandi
63205d3a43 Media Grid: Show upload errors above the grid rather than as a popup. 
props pento, stephdau, helen. fixes #29141.


git-svn-id: https://develop.svn.wordpress.org/trunk@29612 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-26 04:17:18 +00:00
Andrew Nacin
d49f1405fd Install: Remove reference to readme and add a hyphen missing since 2007. 
props ocean90.
fixes #29290.


git-svn-id: https://develop.svn.wordpress.org/trunk@29611 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-26 04:04:12 +00:00
Helen Hou-Sandi
bcba1996fe Customizer panels: use a single back button for all panels. 
This also ensures the back button is visible on iOS devices.

props celloexpressions.
fixes #29135.


git-svn-id: https://develop.svn.wordpress.org/trunk@29610 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-25 23:04:43 +00:00
Helen Hou-Sandi
7b6aabf795 Better visual focus syling in customizer, theme preview, and attachment details modals. 
props celloexpressions.
fixes #29147.


git-svn-id: https://develop.svn.wordpress.org/trunk@29608 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-25 21:57:55 +00:00
Helen Hou-Sandi
eb08fac4f7 Media: 
* Make attachment focus styles more obvious, particularly for already selected items.
* Fix styling for the selection set attachments.
* Remove some CSS cruft.

fixes #28822.


git-svn-id: https://develop.svn.wordpress.org/trunk@29607 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-25 21:25:13 +00:00
Helen Hou-Sandi
0566702a64 Plugin details: 
Prevent plugins with long names from looking bad and breaking layouts.

props stephdau. fixes #28883.


git-svn-id: https://develop.svn.wordpress.org/trunk@29605 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-25 20:19:56 +00:00
Helen Hou-Sandi
330ed83605 Correct cascade oversights in form CSS. fixes #28262. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29604 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-25 19:52:24 +00:00
Andrew Ozz
2f81be2bbc Media modal: when inserting content, prefer the editor id passed while opening the modal. wpActiveEditor can change in the background. (Includes some precommit prefixed selectors.) Fixes #28173 
git-svn-id: https://develop.svn.wordpress.org/trunk@29603 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-25 19:36:12 +00:00
Sergey Biryukov
feb1b12df1 Send nocache_headers() on installation screens and when redirecting to them. 
fixes #29248.

git-svn-id: https://develop.svn.wordpress.org/trunk@29599 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-25 17:39:46 +00:00
Helen Hou-Sandi
87bf7ef30c Media Grid: Move CSS into an admin-only file. 
`media-views.css` can be loaded on the front, which does not need this extra CSS.

fixes #29340.


git-svn-id: https://develop.svn.wordpress.org/trunk@29598 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-25 16:50:36 +00:00
Helen Hou-Sandi
9252fbec58 Only show one search form for the plugin installer. 
The field dropdown now appears in the filter bar only when doing a search.

see #28785.


git-svn-id: https://develop.svn.wordpress.org/trunk@29597 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-25 16:02:43 +00:00
Helen Hou-Sandi
f187cf1dec Make filter bar CSS less verbose and redundant. 
Also removes an unused handler in the theme feature filter.

see #28794.


git-svn-id: https://develop.svn.wordpress.org/trunk@29596 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-25 15:57:34 +00:00
Andrew Nacin
e8d8b21cec Plugins: Only show details link if user can install plugins. 
fixes #17902.


git-svn-id: https://develop.svn.wordpress.org/trunk@29595 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-25 15:27:45 +00:00
Sergey Biryukov
fae5c2de6f Install Plugins: Don't wp_die() if API can't be reached. 
props johnbillion.
fixes #29361.

git-svn-id: https://develop.svn.wordpress.org/trunk@29594 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-25 15:01:50 +00:00
Andrew Ozz
fa1b34ac78 Editor expand: add border to the Text editor resize helper, helps calculating the height in some cases. Fixes #29225 
git-svn-id: https://develop.svn.wordpress.org/trunk@29593 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-25 03:42:46 +00:00
azaozz
78b5ccd55c Editor scrolling: fix window height when switching Visual to Text and the editor is shorter. Props mackensen, fixes #29226. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29592 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-24 23:11:03 +00:00
Andrew Nacin
4820f78f66 Plugin details: Adjust plugin title when it does not have a banner. 
Smaller, bold, and Open Sans, like other modals. Only use Helvetica Neue when the plugin has a banner.

see [29040], see #27440.


git-svn-id: https://develop.svn.wordpress.org/trunk@29591 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-24 20:47:50 +00:00
Andrew Nacin
c0eabc9901 Plugin details: Correctly calculate the height of the right column for plugins without banners. 
Comment these magic numbers.

see #27440, [29474].


git-svn-id: https://develop.svn.wordpress.org/trunk@29590 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-24 20:44:27 +00:00
Andrew Nacin
50706e736d Screen: Move editor scrolling screen option to the proper place. 
see [29336], see #28328.


git-svn-id: https://develop.svn.wordpress.org/trunk@29588 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-24 17:56:25 +00:00
Andrew Nacin
42307f8194 Equal margins for plugin icons. see #28785. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29587 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-24 17:55:05 +00:00
Andrew Nacin
81b52e71e4 Plugin install: Add icons to compatible/incompatible. see #29313. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29586 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-24 17:25:35 +00:00
Dominik Schilling (ocean90)
e4717c19c1 Apply accessibility improvements to Plugins screen too. 
props SergeyBiryukov.
fixes #29342.

git-svn-id: https://develop.svn.wordpress.org/trunk@29583 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-24 16:21:20 +00:00
Dominik Schilling (ocean90)
19a0a5b64f Plugin compatibility is based on your version of WordPress, not your install. 
fixes #29313.

git-svn-id: https://develop.svn.wordpress.org/trunk@29581 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-24 16:13:54 +00:00
Dominik Schilling (ocean90)
7770a90d74 Add missing array keys for connection type in request_filesystem_credentials(). 
see [28456].
fixes #29347.


git-svn-id: https://develop.svn.wordpress.org/trunk@29580 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-24 16:04:01 +00:00
Andrew Ozz
46457ead23 Editor scrolling: 
- Pin the TinyMCE statusbar (elements path) to the bottom.
- Add support for pinning the menu when present.
- Add borders from CSS.
- Optimize getting most elements outerHeight.
Part props avryl, fixes #29293, see #28328.

git-svn-id: https://develop.svn.wordpress.org/trunk@29579 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-24 05:10:52 +00:00
Andrew Ozz
76020bd447 TinyMCE wpView: fix showing errors for non-embeddable URLs, no-ssl or no items. Props avryl, fixes #29114, see #29268. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29577 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-22 18:54:08 +00:00
Sergey Biryukov
e6a5a8a36b Fix unintended box-shadow in the opposite corner of thickbox Close icon. 
props ocean90.
fixes #29311.

git-svn-id: https://develop.svn.wordpress.org/trunk@29575 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-22 16:03:29 +00:00
Sergey Biryukov
91f11ca349 Plugin compatibility warnings should be red, not green. 
props avryl.
fixes #29309.

git-svn-id: https://develop.svn.wordpress.org/trunk@29574 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-22 03:56:51 +00:00
Andrew Nacin
d395f64117 Export: Add wxr_export_skip_commentmeta filter to match the _postmeta filter. 
props cfinke.
fixes #28745.


git-svn-id: https://develop.svn.wordpress.org/trunk@29573 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-22 01:47:59 +00:00
Andrew Ozz
0f83364811 Autosave: prevent setting multiple stale wp-saving-post-* cookies when the browser disregards "session cookies" expiration on quit: 
- Add expiration time of 24 hours for these cookies.
- Rename them to `wp-saving-post` (no post_id) so there is never more than one cookie per domain.
Fixes #29294.

git-svn-id: https://develop.svn.wordpress.org/trunk@29572 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-22 00:24:56 +00:00
Andrew Nacin
7a504df72a Introduce plugin icons in the installer. 
See http://wp.me/p2AvED-2P8 for the announcement and how to implement these.

props tellyworth.
see #28785.


git-svn-id: https://develop.svn.wordpress.org/trunk@29569 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-21 19:10:59 +00:00
Sergey Biryukov
eef49c7f45 Add missing box-shadow for pingbacks in Dashboard Activity widget. 
props chrisl27.
fixes #29198.

git-svn-id: https://develop.svn.wordpress.org/trunk@29561 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-21 02:36:40 +00:00
Scott Taylor
baf230c80f Media Grid/Modal Keyboard navigation improvements: 
* Add focus to arrows on Next/Previous in the grid's modal on left/right keypress, and add the necessary CSS for `:focus`
* When in a disabled input in the grid modal, allow the left/right keys to work
* Make the image editor return a `$.Deferred` so that there isn't a race condition with UI loading. 
* Assign focus when the edit image mode is rendered so that the modal can be closed on Esc press

Props wonderboymusic, adamsilverstein (for the initial patch).
See #23560.


git-svn-id: https://develop.svn.wordpress.org/trunk@29560 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-21 02:34:23 +00:00
Andrew Ozz
5e838e6f4a TinyMCE wpView: add a filter for the stylesheet URLs loaded in the sandbox iframes. See #29048. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29559 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-20 21:33:56 +00:00
Dominik Schilling (ocean90)
7d1d160251 Media: Remove scan for lost attachments. 
This hasn't been worked for 4 years.

fixes #29169.


git-svn-id: https://develop.svn.wordpress.org/trunk@29550 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-20 17:08:41 +00:00
Andrew Ozz
50ba21e179 TinyMCE wpView: show an error when no items are found while parsing a audio/video/playlist shortcode. Props avryl, fixes #29114. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29546 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-19 23:22:47 +00:00
Helen Hou-Sandi
9eaf6cda94 Align and unify (most) modal and customizer icons. fixes #29147. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29542 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-19 20:37:46 +00:00
Sergey Biryukov
2441202954 Prevent "Add" button in Tags meta box from wrapping to a new line in ru_RU. 
fixes #29265. see #26510.

git-svn-id: https://develop.svn.wordpress.org/trunk@29539 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-19 08:56:58 +00:00
Dominik Schilling (ocean90)
c6e4597bbf Plugin details: Accessibility improvements 
* Focus the close link to transfer focus into the plugin modal.
* Set title attribute on iframe for screereaders.

props jwenerd for initial patch and a11y team for testing.
fixes #28823.

git-svn-id: https://develop.svn.wordpress.org/trunk@29534 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-18 20:01:47 +00:00
Andrew Ozz
1e61bbb8f1 DFW: revert applying the Visual editor body color and background-color for now. Set the color to #333 and the background to transparent. Fixes #28330. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29533 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-18 18:22:54 +00:00
Andrew Ozz
27cd1b4f92 Editor scrolling: set max-width: 100% for the text editor clone instead of always resizing it. See #29246. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29524 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-18 01:12:31 +00:00
Andrew Ozz
dcba23a58e Editor scrolling: 
- Properly handle change of sidebar height when opening, closing or hiding postboxes.
- Add a flag when to start pinning. Set it to few pixels more than the initial editor height.
See #28328

git-svn-id: https://develop.svn.wordpress.org/trunk@29523 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-18 00:34:45 +00:00
Andrew Ozz
53488d1404 Editor scrolling: always resize the text editor clone so it doesn't "push" the parent's width over 100%, fixes #29246. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29522 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-17 21:32:10 +00:00
Dominik Schilling (ocean90)
a6da7fd8f2 Restore focus styles for checkboxes and radio buttons. Broken since [29465]. 
fixes #28262.

git-svn-id: https://develop.svn.wordpress.org/trunk@29519 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-17 14:18:05 +00:00
Dominik Schilling (ocean90)
7de002f960 Admin Menu: Auto fold the menu at 960px. 
This gives us some more room at the post edit screen.

props vinod dalvi for initial patch.
fixes #28592.

git-svn-id: https://develop.svn.wordpress.org/trunk@29518 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-17 14:14:09 +00:00
John Blackbourn
6dfb2d6ec5 Avoid a PHP notice if you manually navigate to /wp-admin/install.php?step=2. See #28577. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29516 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-17 13:59:10 +00:00
Dominik Schilling (ocean90)
663164eeca Add a label to site language setting. 
see #15677.

git-svn-id: https://develop.svn.wordpress.org/trunk@29514 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-17 09:44:18 +00:00
Dominik Schilling (ocean90)
3211b09ed4 Use correct form name for translation updates. 
props netweb.
fixes #28198.

git-svn-id: https://develop.svn.wordpress.org/trunk@29512 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-16 10:00:00 +00:00
Sergey Biryukov
de313ebf30 * Add span to the list of allowed tags in plugin sections in plugin details modal. 
* Don't strip class attribute from div/span tags in plugin sections.

props tellyworth.
see #28884.

git-svn-id: https://develop.svn.wordpress.org/trunk@29511 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-16 03:06:26 +00:00
Dominik Schilling (ocean90)
e22782e068 Plugin details: Use translation functions. 
props jesin.
fixes #29220.

git-svn-id: https://develop.svn.wordpress.org/trunk@29510 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-15 20:50:51 +00:00
Dominik Schilling (ocean90)
8314367632 Plugin details: Escape the donate link. 
see #27440.

git-svn-id: https://develop.svn.wordpress.org/trunk@29506 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-15 17:16:16 +00:00
Helen Hou-Sandi
b6f0d0c208 Use consistent margin and padding on #wpcontent and #wpfooter. props jesin, TJNowell, sumobi. fixes #28675. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29502 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-15 15:33:24 +00:00
Dominik Schilling (ocean90)
63ec249db9 Allow WebKit browsers to break strings in <code> tags. 
This prevents an overflow for example on Permalink Settings.

fixes #28161.

git-svn-id: https://develop.svn.wordpress.org/trunk@29501 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-15 13:18:52 +00:00
Dominik Schilling (ocean90)
ae4830351c Plugin install: Remove columns and screen options. 
fixes #28803.

git-svn-id: https://develop.svn.wordpress.org/trunk@29498 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-15 09:37:01 +00:00
Helen Hou-Sandi
ee20b5a45f Editor scrolling: 
* Reduce the starting height of the editor to better match the height at which the top toolbar unpins.
* Pin the side metaboxes so they do not get lost when the editor content is long.
* Turn magic numbers into variables.

props stephdau, azaozz. see #28328.



git-svn-id: https://develop.svn.wordpress.org/trunk@29495 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-15 03:16:07 +00:00
Andrew Ozz
22eca56a81 Some pre-commit cleanup of media-grid.js and media-views.js 
git-svn-id: https://develop.svn.wordpress.org/trunk@29494 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-15 01:12:32 +00:00
Scott Taylor
8661fcf0d9 Media Grid, support MEDIA_TRASH: 
* Add a setting to `_wpMediaViewsL10n.settings`: `mediaTrash`
* In the attachment edit modal, properly toggle between Trash/Untrash
* In `media.view.Attachment`, add a method for `untrashAttachment`
* When creating the grid toolbar, switch the setting order of subviews so that `media.view.DeleteSelectedButton` can listen to the instance of `media.view.AttachmentFilters.All` to update the text in its UI.
* Add a new filter to `media.view.AttachmentFilters.All`, `trash`, when `settings.mediaTrash` is true
* Allow the cached queries in `Query.get()` to be flushed when race conditions exist and collections need to be refreshed. This is currently only being used when `MEDIA_TRASH` is set, to refresh the filtered/mirrored collections related to `all`, `trash`, and any already queried filter.
* Cleanup the bootstrapping of `media.view.MediaFrame.Manage`
* Allow `wp_ajax_query_attachments()` to return items from the trash when `MEDIA_TRASH` is `true`
* Allow `wp_ajax_save_attachment()` to set `post_status` when `MEDIA_TRASH` is `true`. It allows `wp_delete_post()` to be called, which will trash the attachment instead of deleting when the flag is set.

Props koop for the knowledge sharing and thought partnership.
See #29145.


git-svn-id: https://develop.svn.wordpress.org/trunk@29490 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-14 18:30:49 +00:00
Andrew Nacin
bc582fc058 Customizer: Mixed priority sorting for panels and top-level sections. 
props celloexpressions.
fixes #28979.


git-svn-id: https://develop.svn.wordpress.org/trunk@29488 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-14 04:42:30 +00:00
Helen Hou-Sandi
4958fecdaf Plugin details: Remove some CSS rules that were unnecessary and causing issues in Firefox. see #27440. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29480 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-13 05:27:01 +00:00
Drew Jaynes (DrewAPicture)
ab6063cc88 Fix some documentation typos in various core files. 
Props vlajos.
Fixes #29199.


git-svn-id: https://develop.svn.wordpress.org/trunk@29479 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-13 03:55:10 +00:00
Sergey Biryukov
6d6bce429d Plugin install: Make plugin groups translatable. 
props ocean90 for initial patch.
fixes #29092.

git-svn-id: https://develop.svn.wordpress.org/trunk@29477 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-13 02:30:24 +00:00
Helen Hou-Sandi
f37a0e160d Plugin details modal: 
* Scroll all content, rather than the dual-pane scrolling awkwardness.
* Better align the header image and title overlay with the display on WordPress.org, at least at full-width.
* Move the close button outside of the modal itself, rather than overlay on top of colors we can't predict.

props stephdau, tellyworth, helen. fixes #27440.


git-svn-id: https://develop.svn.wordpress.org/trunk@29474 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-12 23:01:38 +00:00
Helen Hou-Sandi
fff4c473d3 Clearer visual differentiation between panels and sections in the customizer. props celloexpressions. see #28979. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29470 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-12 01:17:07 +00:00
Helen Hou-Sandi
18a8b40401 Add styling for various HTML5 input elements. props avryl. fixes #28262. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29465 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-11 16:41:35 +00:00
Drew Jaynes (DrewAPicture)
39ba840e04 Add @access tags to constructor docblocks in list table classes. 
See #28679. See [29459].


git-svn-id: https://develop.svn.wordpress.org/trunk@29460 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-10 02:21:56 +00:00
Drew Jaynes (DrewAPicture)
126147a877 Document default arguments for the WP_List_Table class. Also add referenced docblocks to extending class constructors. 
Props mikejolley for the initial patch.
Fixes #28679. See #28298.


git-svn-id: https://develop.svn.wordpress.org/trunk@29459 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-10 02:17:14 +00:00
Drew Jaynes (DrewAPicture)
8feaba4ca2 Clean up some missing @access tags and other tweaks for 4.0.0-functionality docs. 
See #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29455 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-09 19:31:35 +00:00
Drew Jaynes (DrewAPicture)
a84d50dfa3 Fix some words that aren't words. 
See #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29454 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-09 19:29:37 +00:00
Dominik Schilling (ocean90)
e8e0880851 WP_Plugins_List_Table::bulk_actions() method declaration should match WP_List_Table, see [29440]. 
props imath.
fixes #29148.

git-svn-id: https://develop.svn.wordpress.org/trunk@29453 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-09 14:45:20 +00:00
Scott Taylor
af851b9bda Add some docs to Customizer JS. 
Props ericlewis.
See #29157.


git-svn-id: https://develop.svn.wordpress.org/trunk@29451 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-08 23:30:30 +00:00
Andrew Ozz
78c928ad44 Editor: use the post_edit_form_tag action to add autocomplete="off" to the whole form on the Add/Edit Post screen in WebKit. Prevents editor problems when the browser's Back button is used. Fixes #28037. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29448 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-08 20:53:31 +00:00
Helen Hou-Sandi
d837ad9fa3 Revert [29287] based on design and core team feedback. see #29012. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29447 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-08 19:00:28 +00:00
wonderboymusic
fa6508e234 wp_dashboard_cached_rss_widget() contained some func_get_args() code that was indescribably weird. 
This keeps it weird, but makes sure that `$check_urls` gets passed to the callback.

Props michalzuber, ocean90.
Fixes #28872.


git-svn-id: https://develop.svn.wordpress.org/trunk@29442 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-07 21:46:02 +00:00
Scott Taylor
9b9b4a82da Mark WP_List_Table::bulk_actions()'s argument $which as optional for BC. 
Fixes #29026.


git-svn-id: https://develop.svn.wordpress.org/trunk@29440 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-07 21:30:01 +00:00
Scott Taylor
e0083f398b Add screen reader text to list table date dropdown. 
See #29026.


git-svn-id: https://develop.svn.wordpress.org/trunk@29433 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-07 19:43:17 +00:00
Scott Taylor
0653e60a5d Revert [29428] to avoid errors with Add Media for now. 
See #29026.


git-svn-id: https://develop.svn.wordpress.org/trunk@29432 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-07 19:39:10 +00:00
Scott Taylor
adff7dfb8e Media Grid: add screen reader labels with more context to filters and bulk actions. Ditto for list view. 
Props afercia.
Fixes #29026.


git-svn-id: https://develop.svn.wordpress.org/trunk@29428 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-07 05:19:14 +00:00
Scott Taylor
277d5a633e After [29201], use aria-label instead of aria-labelledby in WP_Plugin_Install_List_Table::display_rows(). 
Props nvwd, DrewAPicture.
Fixes #28853.


git-svn-id: https://develop.svn.wordpress.org/trunk@29424 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-07 02:55:18 +00:00
Scott Taylor
67ef6c5e18 WP_List_Table::items should be public, not protected. It is accessed in a subclass directly via wp_ajax_get_comments(). 
See [28493].
Fixes #29072.


git-svn-id: https://develop.svn.wordpress.org/trunk@29423 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-07 02:50:40 +00:00
Scott Taylor
99a0a62442 Don't show the Featured Image metabox for users with the contributor role. Do enqueue media so that TinyMCE previews work for YouTube embeds, etc. 
Props SergeyBiryukov.
Fixes #28327.


git-svn-id: https://develop.svn.wordpress.org/trunk@29402 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-06 17:16:45 +00:00
Andrew Nacin
587a0bc96d Language chooser: Adjust continue button alignment. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29374 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-04 21:22:57 +00:00
Andrew Nacin
42f2f27267 Language chooser imporvements. 
* Use a translated 'Continue' string.
 * Go back to using a select element.
 * Only show a spinner when we're installing a language. 

see #28577.


git-svn-id: https://develop.svn.wordpress.org/trunk@29372 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-04 20:46:42 +00:00
Andrew Nacin
be026764a3 Move plugin details link into the description area. 
fixes #17902.


git-svn-id: https://develop.svn.wordpress.org/trunk@29371 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-04 18:48:07 +00:00
Andrew Ozz
a1ce4931a1 Fix CSS for form elements for Firefox 30+, fixes #28500. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29366 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-03 00:33:31 +00:00
Dominik Schilling (ocean90)
2c320cc7f3 Standardize transition-animations on modal close/arrow buttons. 
props celloexpressions.
fixes #29021.

git-svn-id: https://develop.svn.wordpress.org/trunk@29365 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-02 22:01:49 +00:00
Dominik Schilling (ocean90)
eedb382924 Remove some unused dashboard-widget-* CSS classes. Unused since [9103]. 
props michalzuber.
fixes #28930.

git-svn-id: https://develop.svn.wordpress.org/trunk@29361 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-02 20:02:00 +00:00
Dominik Schilling (ocean90)
a2a3e10f66 Plugin install: Improve styling of the no results message. 
see #28753.

git-svn-id: https://develop.svn.wordpress.org/trunk@29359 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-02 15:23:17 +00:00
Dominik Schilling (ocean90)
bcb49d44ab Language Upgrader: Don't print a footer when translations are updated async. 
fixes #28947.

git-svn-id: https://develop.svn.wordpress.org/trunk@29358 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-02 15:15:27 +00:00
Dominik Schilling (ocean90)
c976db478f Upgrader: Use always window.postMessage for decrement of update count bubbles when IFRAME_REQUEST is defined. 
Fixes decrement of translation update count bubbles when updated through the bulk upgrader.

fixes #29054.

git-svn-id: https://develop.svn.wordpress.org/trunk@29357 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-02 14:36:31 +00:00
Dominik Schilling (ocean90)
ee91f3f94f Attach Media: Display the correct error message when search result is empty. 
fixes #29093.

git-svn-id: https://develop.svn.wordpress.org/trunk@29356 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-02 14:23:42 +00:00
Dominik Schilling (ocean90)
de7962c947 Media Upload: Improve styling of error messages. 
props afercia, michalzuber.
fixes #29047.

git-svn-id: https://develop.svn.wordpress.org/trunk@29355 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-02 14:13:06 +00:00
Dominik Schilling (ocean90)
54faec35e4 To improve troubleshooting use esc_html() for a failed embed. 
see #28195.

git-svn-id: https://develop.svn.wordpress.org/trunk@29354 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-01 22:33:55 +00:00
Dominik Schilling (ocean90)
6d656e7880 RTL: Fix media attach modal alignment. 
props SergeyBiryukov.
fixes #28010.

git-svn-id: https://develop.svn.wordpress.org/trunk@29353 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-01 21:58:48 +00:00
Andrew Ozz
96daabb134 Editor scrolling: run one more adjust() 200ms after scroll or resize in case the browser is slow to re-calculate the element heights and pin/unpin the toolbars. See #28328, fixes #29059. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29352 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-01 21:42:03 +00:00
Dominik Schilling (ocean90)
6489b16efc Add some braces to [29225]. 
see #28673.

git-svn-id: https://develop.svn.wordpress.org/trunk@29350 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-01 21:03:48 +00:00
Dominik Schilling (ocean90)
4c0ae9bc47 Plugin install: Add missing closing HTML tags. 
props jwenerd.
fixes #29090. see #28673.

git-svn-id: https://develop.svn.wordpress.org/trunk@29348 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-01 20:43:26 +00:00
Dominik Schilling (ocean90)
257a3ad0e3 Disable background page scrolling when modals are open. 
props celloexpressions.
fixes #29074.

git-svn-id: https://develop.svn.wordpress.org/trunk@29346 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-01 20:14:43 +00:00
Helen Hou-Sandi
8b45f96cba Use the word "Count" instead of the post type label in taxonomy list tables to prevent layout issues. It is also more accurate, as it represents a count of all post types, not just one. 
props philipjohn, GaVrA, seanchayes. fixes #17209.


git-svn-id: https://develop.svn.wordpress.org/trunk@29343 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-01 18:31:52 +00:00
Mark Jaquith
a46a981daa Match background color in DFW and adapt the dashed outline color. 
fixes #28330. props avryl, ipstenu.

git-svn-id: https://develop.svn.wordpress.org/trunk@29340 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-01 18:09:47 +00:00
Andrew Ozz
c94edd08bd Editor scrolling: 
- Add a Screen Option to turn it on/off, and on()/off() methods from JS. Store the user preference.
- Fix delayed calls to resize() in the TinyMCE autoresize plugin.
See #28328.

git-svn-id: https://develop.svn.wordpress.org/trunk@29336 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-01 02:42:30 +00:00
Andrew Ozz
c3f712ac63 PressThis: when the Text editor is the default, run the initial textarea content through pre_wpautop() to convert the paragraph tags. Fixes #29081. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29334 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-01 00:54:51 +00:00
Sergey Biryukov
09877657d4 Customizer: Don't hide controls the preview frame has no information about. 
props kovshenin.
see #27993.

git-svn-id: https://develop.svn.wordpress.org/trunk@29329 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-30 16:23:47 +00:00
Sergey Biryukov
502e9b675a In add_submenu_page(), avoid inadvertently copying classes of a menu item to the first submenu item. 
fixes #28936.

git-svn-id: https://develop.svn.wordpress.org/trunk@29326 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-29 16:07:59 +00:00
Helen Hou-Sandi
3c71a49abc Labels for the installation form should get the pointer cursor. props Ankit K Gupta. fixes #28818. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29325 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-29 16:04:44 +00:00
Sergey Biryukov
40d1133c6f Fix duplicate Customize button in theme details modal. 
props afercia.
fixes #28987.

git-svn-id: https://develop.svn.wordpress.org/trunk@29324 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-29 16:01:13 +00:00
Sergey Biryukov
e4c8f3a843 QuickPress: Disable autocomplete for content, enable "Save Draft" button on load. 
props morganestes, michalzuber.
fixes #27760.

git-svn-id: https://develop.svn.wordpress.org/trunk@29323 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-29 15:33:07 +00:00
Sergey Biryukov
e2d9939e57 Avoid PHP notices in Media Library if an attachment parent post type no longer exists. 
Synchronize the 'edit_post' capability check between the list table and the media grid.

fixes #27446.

git-svn-id: https://develop.svn.wordpress.org/trunk@29320 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-29 01:40:24 +00:00
Andrew Ozz
01051b4e2f Formatting: make the removal of white space around <option> greedy, see #28217. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29316 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-28 19:54:50 +00:00
Andrew Ozz
5fa36977a0 Formatting: no <p> or <br> around <option> tags in both flavours of wpautop, make "selects" easier to read in the Text editor. Fixes #28217. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29315 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-28 19:43:06 +00:00
Dominik Schilling (ocean90)
70a6b6390c IE8 doesn't support ::before and ::after pseudo-elements. Replace them with :before and :after. 
props andrezrv, DrewAPicture, ocean90.
fixes #28082.

git-svn-id: https://develop.svn.wordpress.org/trunk@29314 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-28 15:51:02 +00:00
Dominik Schilling (ocean90)
41360a0086 Remove parent::footer() in Language_Pack_Upgrader_Skin::bulk_footer() as it prints a closing div which is not needed. 
props michalzuber.
fixes #28947.

git-svn-id: https://develop.svn.wordpress.org/trunk@29313 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-28 09:05:33 +00:00
Dominik Schilling (ocean90)
0e42ce2dc0 Add missing screen-reader-text CSS class in [29294]. 
see #28867.

git-svn-id: https://develop.svn.wordpress.org/trunk@29308 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-27 13:42:49 +00:00
Andrew Ozz
42ac48d52a TinyMCE: 
- Fix complex character input in Japanese, Chinese, etc. Was broken in getCursorOffset() in editor-expand.js.
- Disable auto-scrolling in some edge cases when editor expanding is enabled.
See #28328.


git-svn-id: https://develop.svn.wordpress.org/trunk@29302 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-26 00:07:55 +00:00
Helen Hou-Sandi
59cec2e2ff When adding a post of a post type whose menu item is in a submenu, highlight the correct menu item. props mordauk, markjaquith. fixes #24137. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29300 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-25 15:25:20 +00:00
Scott Taylor
ced3f94927 Adds <label>s to current page selector and bulk actions <select> field so that screen readers have an explicit label. 
Props joedolson.
Fixes #28867.


git-svn-id: https://develop.svn.wordpress.org/trunk@29294 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-25 00:19:21 +00:00
Scott Taylor
6e74d46d94 Whitelist input types that are styled in the scope of .form-field. 
Props mauteri.
Fixes #28647.


git-svn-id: https://develop.svn.wordpress.org/trunk@29292 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-24 22:21:00 +00:00
Scott Taylor
66c8ad501f Add exif orientation to data extracted in wp_read_image_metadata(). 
Props shanebp.
Fixes 28916.


git-svn-id: https://develop.svn.wordpress.org/trunk@29291 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-24 22:13:19 +00:00
Scott Taylor
1cbe1cec12 In sanitize_file_name(), replace %20 and + with dashes. Remove unnecessary code from _wp_handle_upload(). 
Adds unit tests.

Props ericmann.
Fixes #16330.


git-svn-id: https://develop.svn.wordpress.org/trunk@29290 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-24 22:08:09 +00:00
Scott Taylor
1b01b92dc6 Media Grid CSS: Media modal close icon should be consistent with other modals. 
Props celloexpressions.
Fixes #29012.


git-svn-id: https://develop.svn.wordpress.org/trunk@29287 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-24 21:06:42 +00:00
Helen Hou-Sandi
5698a9dc7e Media Grid: Remove fields from showing in the grid itself. 
All details are still available within the modal, and less-distinguishable non-image files still show the filename along with the file type icon.

Reverts [29079], [29078], [29077], and [28995]. see #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@29280 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-24 05:25:28 +00:00
Andrew Ozz
0a73faec46 Editor scrolling: 
- Improve TinyMCE resizing when a floated block is at the end of the content.
- Improve setting the padding/margin under the toolbar on loading.
- Add custom event on TinyMCE resizing and use it to adjust the pinning (if needed).
Part props avryl, see #28328.

git-svn-id: https://develop.svn.wordpress.org/trunk@29279 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-24 01:32:29 +00:00
Dominik Schilling (ocean90)
cce3bdf920 Media Grid: Add a date filter. 
props ericlewis.
fixes #28895.

git-svn-id: https://develop.svn.wordpress.org/trunk@29271 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-22 20:46:22 +00:00
Dominik Schilling (ocean90)
f5c0cf95e0 Fix jshint errors introduced in [29259]. see #11325. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29269 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-22 20:02:34 +00:00
John Blackbourn
dfa33f92ff Add a lang attribute to each language listed on the language selector screen during installation. See #28858, #28577. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29260 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-21 21:50:12 +00:00
Sergey Biryukov
ac17007b10 Remove requirement for a minimum image size in the image editor. 
props ericlewis, solarissmoke.
fixes #11325.

git-svn-id: https://develop.svn.wordpress.org/trunk@29259 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-21 19:09:44 +00:00
Andrew Ozz
9c366c8f61 Fix admin menu open/close issues on some mobile devices, props adamsilverstein, fixes #27980. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29247 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-19 18:54:50 +00:00
Sergey Biryukov
d83dbfca17 Customizer: Remove "Add a Widget" button from tab order when reordering widgets. 
fixes #28890.

git-svn-id: https://develop.svn.wordpress.org/trunk@29243 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-19 03:31:49 +00:00
Sergey Biryukov
45ec949d58 Customizer: When widget reorder button is actioned, transfer focus to the first Move control within the section. 
fixes #28891.

git-svn-id: https://develop.svn.wordpress.org/trunk@29242 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-19 03:23:51 +00:00
Sergey Biryukov
123702b484 Add screen reader text to announce that menu item accordion sections are expandable. Remove redundant title attribute. 
props joedolson.
fixes #28866.

git-svn-id: https://develop.svn.wordpress.org/trunk@29239 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-19 02:20:58 +00:00
Sergey Biryukov
a740868552 Customizer: Add widget title to Move/Up/Down controls to provide context for screen readers when reordering or moving widgets. 
fixes #28889.

git-svn-id: https://develop.svn.wordpress.org/trunk@29238 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-19 01:57:05 +00:00
Sergey Biryukov
7a01c6af7b Customizer: Avoid losing focus when adding widgets via keyboard. 
props sathishn.
fixes #28835.

git-svn-id: https://develop.svn.wordpress.org/trunk@29237 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-19 01:18:39 +00:00
Sergey Biryukov
54f0c851d5 Reverse the order of roles in help text on Add New User screen to match [25695]. 
fixes #28914.

git-svn-id: https://develop.svn.wordpress.org/trunk@29233 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-18 23:47:54 +00:00
Sergey Biryukov
218cbba634 Add screen reader text for star ratings on Install Plugins screen. 
props joedolson.
fixes #28852.

git-svn-id: https://develop.svn.wordpress.org/trunk@29232 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-18 23:40:43 +00:00
Andrew Nacin
3bd777fba5 Plugin Install screens: Pass locale and installed plugins to the API, for context. 
props tellyworth.
see #17902.


git-svn-id: https://develop.svn.wordpress.org/trunk@29227 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-18 20:49:14 +00:00
Andrew Nacin
b00097b758 Add 'Details' links to installed plugins. 
Installed plugins that are up to date are now returned in the update-check API response.

props tellyworth.
see #17902.


git-svn-id: https://develop.svn.wordpress.org/trunk@29226 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-18 20:48:28 +00:00
Helen Hou-Sandi
446f78396a Plugin install: display cards in groups if the API returns them with the appropriate information. props tellyworth. fixes #28673. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29225 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-18 19:34:47 +00:00
Helen Hou-Sandi
1803c4c1e8 Plugin install cards: 
* Move author attribution to its own line.
* Use `esc_url()` where appropriate.
* Better i18n.
* min-height for cards for a more even appearance.
* Show more cards on wide screens.
* Tighten up spacing below the filter bar.

props ocean90, helen. see #28785.


git-svn-id: https://develop.svn.wordpress.org/trunk@29219 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-18 06:07:21 +00:00
Helen Hou-Sandi
b0b9655b12 Install Plugins screen: 
* Utilize the (currently-named) filter bar from the Add Themes screen.
* Move the upload link to the h2, also like the Add Themes screen.

see #28673.


git-svn-id: https://develop.svn.wordpress.org/trunk@29218 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-18 04:49:19 +00:00
Helen Hou-Sandi
021750b4f4 Use more generic, reusable CSS for the filter bar on Add Themes. This will allow us to reuse the UI in other places, such as the Media Library. props paulwilde. fixes #28794. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29217 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-18 03:39:04 +00:00
Sergey Biryukov
332a618271 Declare the variable before using it. 
props danielbachhuber.
fixes #28932.

git-svn-id: https://develop.svn.wordpress.org/trunk@29215 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-17 22:00:14 +00:00
Scott Taylor
f59a307e10 Merge wp_handle_upload() and wp_handle_sideload() by making them each wrap a new function: _wp_handle_upload(). 
Props DrewAPicture for docs.
Fixes #23686.


git-svn-id: https://develop.svn.wordpress.org/trunk@29209 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-17 18:57:26 +00:00
Drew Jaynes (DrewAPicture)
6ddc1e5f6d Fix syntax for single- and multi-line comments in wp-admin-directory files. 
See #28931.


git-svn-id: https://develop.svn.wordpress.org/trunk@29206 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-17 09:13:53 +00:00
Scott Taylor
283fa473e6 In Plugin Install List Table, remove title attribute for plugin action links; add screen-reader-text. 
Props joedolson.
Fixes #28853.


git-svn-id: https://develop.svn.wordpress.org/trunk@29201 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-16 22:49:53 +00:00
Drew Jaynes (DrewAPicture)
8a5d825fac Fix a typo in the @access tag for WP_List_Table::__get(). 
Props joehoyle.
Fixes #28925. See #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29199 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-16 22:12:11 +00:00
Andrew Nacin
9452f31220 DB schema change: Add comment_author_email(10) index. 
props tellyworth, pento.
fixes #21435.


git-svn-id: https://develop.svn.wordpress.org/trunk@29188 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-16 15:53:14 +00:00
Andrew Ozz
09f5183276 Editor scrolling: better "scroll into view" in the visual editor. Don't override MCE path focus style. Props avryl, see #28328. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29186 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-16 04:05:13 +00:00
azaozz
12ebd89657 Editor scrolling: also disable in IE < 9. See #28328. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29180 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-15 22:36:02 +00:00
Scott Taylor
9e573243cf Add a new AJAX action: parse-media-shortcode. This async call will replace JS rendering of audio/video/playlist shortcodes. 
See #28905.


git-svn-id: https://develop.svn.wordpress.org/trunk@29178 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-15 22:07:16 +00:00
Scott Taylor
bbfdf38a5b Make audio and video URLs/embed handlers work in <iframe>-sandbox'd MCE views. 
Introduce:
`get_editor_stylesheets()`
`wp_media_mce_styles()`.

See #28905.


git-svn-id: https://develop.svn.wordpress.org/trunk@29176 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-15 21:50:41 +00:00
Helen Hou-Sandi
0db107498a No-JS fallback for the Media Library grid view. props michalzuber. fixes #28830, see #24716. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29175 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-15 20:44:38 +00:00
Dominik Schilling (ocean90)
4d6759dcf5 Remove unused variable in WP_Theme_Install_List_Table::install_theme_info(). Unused since [26380]. 
props Corphi.
fixes #28749.

git-svn-id: https://develop.svn.wordpress.org/trunk@29173 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-14 20:27:37 +00:00
Dominik Schilling (ocean90)
cf673a6985 Fix wrong indentation in [29136]. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29172 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-14 20:08:38 +00:00
Dominik Schilling (ocean90)
1b2386e787 Remove plugin_install_details_link filter, which was added in [29047]. 
see #28785.

git-svn-id: https://develop.svn.wordpress.org/trunk@29171 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-14 19:49:15 +00:00
Dominik Schilling (ocean90)
60b1befd8e Customizer: Add meta capability customize which is mapped to edit_theme_options. 
You can now allow users to access the Customizer, say for any user who can `edit_posts`, via `map_meta_cap` or `user_has_cap` filter. See ticket for examples.

props westonruter, nacin.
fixes #28605.

git-svn-id: https://develop.svn.wordpress.org/trunk@29170 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-14 19:00:24 +00:00
Scott Taylor
e5a663297c Missed one: WP_MS_Sites_List_Table::display_rows() must be public. 
Props extendwings.
Fixes #28894.



git-svn-id: https://develop.svn.wordpress.org/trunk@29166 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-14 15:41:53 +00:00
Drew Jaynes (DrewAPicture)
7ad77d58ee Add periods to short descriptions for magic methods added in [28501], [28521], and [28524]. 
See #22234 and #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29165 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-14 01:11:55 +00:00
Drew Jaynes (DrewAPicture)
e58a2aae1d Inline documentation cleanup for 4.0 audit. 
* phpDoc tweaks for `wp_get_available_translations_from_api()`, `wp_install_download_language_pack()`, and `wp_install_load_language()`, added in [29018]
 
See #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29154 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-14 00:16:36 +00:00
Drew Jaynes (DrewAPicture)
f77584ea2c Inline documentation for the 'plugin_install_details_link' hook added in [29047] should use a 3-digit, x.x.x-style @since version. 
See #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29152 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-14 00:09:58 +00:00
Drew Jaynes (DrewAPicture)
08fd193850 Inline documentation cleanup for 4.0 audit. 
* Alignment for the 'term_search_min_chars' hook docs, added in [28892]
* Globals added for `wp_ajax_parse_embed()`, added [28580]

See #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29151 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-14 00:05:37 +00:00
Drew Jaynes (DrewAPicture)
49fdc296ba Fill out inline documentation for magic methods added to the Custom_Image_Header class in [28481], [28521], and [28524]. 
See #22234 and #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29150 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-13 23:58:27 +00:00
Drew Jaynes (DrewAPicture)
1db583af25 Fill out inline documentation for magic methods added to the Custom_Background class in [28481], [28521], and [28524]. 
See #22234 and #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29149 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-13 23:57:03 +00:00
Drew Jaynes (DrewAPicture)
1bf87b2c9e Fill out inline documentation for magic methods added to the WP_List_Table class in [28493], [28521], and [28524]. 
See #22234 and #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29148 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-13 23:54:15 +00:00
Drew Jaynes (DrewAPicture)
343c544f6b Fill out inline documentation for magic methods added to the WP_Filesystem_Base class in [28521]. 
See #22234 and #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29147 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-13 23:51:39 +00:00
Scott Taylor
510ad2e1e9 Fix mismatches in access modifiers for WP_List_Table + subclasses. 
Fixes #28843, #28879.


git-svn-id: https://develop.svn.wordpress.org/trunk@29137 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-13 22:08:22 +00:00
Dominik Schilling (ocean90)
1264558022 Media Grid improvements: 
* Remove fixed elements.
* Adjusts toolbar and search, fixes #28833.
* Add link to Add New button, fixes #28825.
* Add "Edit Metadata" tab to all items, "Edit Image" only for images
* Make strings translatable.
* First pass for help tab.

see #28850.

git-svn-id: https://develop.svn.wordpress.org/trunk@29136 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-13 16:15:36 +00:00
Dominik Schilling (ocean90)
cf0e666184 Customizer: Make panel title translatable too. 
props michalzuber.
see #27406.

git-svn-id: https://develop.svn.wordpress.org/trunk@29135 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-13 15:12:00 +00:00
Dominik Schilling (ocean90)
33db0d4ff2 Lists View Switcher: Replace blank image with screen reader text. 
props davidakennedy.
fixes #28871.

git-svn-id: https://develop.svn.wordpress.org/trunk@29133 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-13 11:04:21 +00:00
Dominik Schilling (ocean90)
d198c0bdd5 Remove unused variable in wp_dashboard_plugins_output(). Unused since [26144]. 
props michalzuber.
see #28872.

git-svn-id: https://develop.svn.wordpress.org/trunk@29130 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-13 10:30:53 +00:00
Dominik Schilling (ocean90)
1285d1450b Improvements to the plugin information modal: 
* Whitespace/braces cleanup for [29040].
* Reduce width of modal to 792px, which is the default banner size.
* Reduce banner height when screen height is smaller than 500px.
* Remove inline CSS.
* Re-use tab var in JS.
* Encode ampersands in links.

props avryl, michalzuber, ocean90.
see #27440.


git-svn-id: https://develop.svn.wordpress.org/trunk@29125 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-12 22:07:16 +00:00
Dominik Schilling (ocean90)
c7f2a54dc8 Themes: Don't set background color for the filter icon. 
fixes #28860.


git-svn-id: https://develop.svn.wordpress.org/trunk@29124 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-12 19:48:24 +00:00
Sergey Biryukov
c52f02cc3f Use correct ID for plugin search input label. 
Make the search button name and ID consistent with the ones in WP_List_Table::search_box().

props joedolson.
fixes #28856.

git-svn-id: https://develop.svn.wordpress.org/trunk@29123 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-12 17:44:51 +00:00
Dominik Schilling (ocean90)
7580577e82 Don't use box shadow focus styling for widget arrows, see #28267. 
fixes #28834.
props nvwd.

git-svn-id: https://develop.svn.wordpress.org/trunk@29122 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-12 15:46:27 +00:00
Dominik Schilling (ocean90)
911da56fe8 Improve styling of progress bar on wp-admin/media-new.php. 
props Ipstenu for initial patch.
fixes #28838.

git-svn-id: https://develop.svn.wordpress.org/trunk@29121 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-12 14:51:30 +00:00
Scott Taylor
63cb20cc5a Repent for our original OOP sins and doc blocks as pertains to access modifiers in List Table + subclasses. 
Props SergeyBiryukov.
See #28843 and [28583].


git-svn-id: https://develop.svn.wordpress.org/trunk@29118 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-12 03:26:40 +00:00
Andrew Ozz
dbb367bee8 Editor scrolling: disable on mobile devices and hide the resize handle. See #28328. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29117 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-12 00:53:08 +00:00
Scott Taylor
d1f4b3a800 Media Grid, for audio files: 
* Show `artist` and `album` fields in the Edit Attachment modal
* Sync their values on `change`

See #28839.


git-svn-id: https://develop.svn.wordpress.org/trunk@29104 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-11 20:54:13 +00:00
Sergey Biryukov
8a45aefe56 Escape taxonomy name when used in attributes in post_categories_meta_box(). 
props pbearne.
fixes #28836.

git-svn-id: https://develop.svn.wordpress.org/trunk@29099 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-11 18:55:48 +00:00
Scott Taylor
0f50df6cbd Media Grid, in the Edit Attachment modal: 
* Label the fields under the attachment a la the Edit Media page
* Move the audio and video previews above the info
* Remove the audio / video icon display. Unnecessary.
* Ensure that `width` and `max-width` are set for `.mejs-container`

See #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@29088 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-11 06:14:31 +00:00
Scott Taylor
ce01c5c760 Media Grid: 
* Move the grid down via CSS transition when the Screen Options slide open.
* Remove some unused CSS for grid options.

See #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@29086 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-11 05:33:29 +00:00
Sergey Biryukov
d2a246e82c Avoid inadvertently adding admin page titles as classes for admin menu submenu items. 
fixes #28817.

git-svn-id: https://develop.svn.wordpress.org/trunk@29083 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-11 01:09:32 +00:00
Scott Taylor
ee0e7ccbca Media Grid: make registering Screen Options for non-list tables more generic. 
See #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@29079 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-10 21:43:49 +00:00
Scott Taylor
d5cbf00457 Media Grid: Screen Options for grid have to play nice with Screen Options for list. This was fun. 
See #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@29078 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-10 21:25:49 +00:00
Scott Taylor
3ebde0c4d6 Media Grid: Move toggling of visible fields to Screen Options. This moves us in a better direction... but this will probably need to be massaged again. 
See #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@29077 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-10 20:59:12 +00:00
Helen Hou-Sandi
e4f0744b8e Editor scrolling: 
* Make sure the background color for tools is only applied to the main editor.
* Fix toolbar width for smaller screens.
* Ensure toolbar doesn't end up in a weird place when scrolling down too fast.
* Avoid JS errors for post types that don't support the editor.

props avryl. see #28328.


git-svn-id: https://develop.svn.wordpress.org/trunk@29075 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-10 19:35:32 +00:00
Andrew Nacin
0838b61b1d Unload the current default textdomain in wp_install_load_language(). 
see #28577.


git-svn-id: https://develop.svn.wordpress.org/trunk@29059 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-10 09:54:06 +00:00
Andrew Nacin
253e09f192 Install: Don't ask for the user's language a second time if they chose English originally. 
see #28577.


git-svn-id: https://develop.svn.wordpress.org/trunk@29058 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-10 09:24:55 +00:00
Helen Hou-Sandi
466659cee6 Media grid attachment modal: 
* Keyboard navigation.
* History and routes for single items and search results.

props adamsilverstein. see #24716.



git-svn-id: https://develop.svn.wordpress.org/trunk@29057 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-10 06:36:34 +00:00
Sergey Biryukov
c35bd6c927 Revisions: Properly position the spinner on Compare Revisions screen. 
props vinod dalvi for initial patch.
fixes #28590.

git-svn-id: https://develop.svn.wordpress.org/trunk@29054 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-10 01:43:59 +00:00
Sergey Biryukov
ca97e64c50 Revisions: Explicitly set the 'from' handle position when switching from two-handled mode back to single-handled mode. 
props adamsilverstein.
fixes #26793.

git-svn-id: https://develop.svn.wordpress.org/trunk@29052 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-10 00:59:13 +00:00
Sergey Biryukov
1477277b53 Customizer: Introduce WP_Customize_Control::active() method to determine whether the control is relevant to the current context (i.e. to the current URL being previewed). 
Control can indicate its active state by a subclass overriding the 'active_callback' method, by supplying a callable 'active_callback' argument into the control's constructor, or by filtering 'customize_control_active'.

props westonruter.
see #27993.

git-svn-id: https://develop.svn.wordpress.org/trunk@29051 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-09 23:57:29 +00:00
Andrew Ozz
ccef0ae5f0 Fix whitespace, quotes and double patch content in wpautoresize plugin, see #28328 
git-svn-id: https://develop.svn.wordpress.org/trunk@29050 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-09 22:42:28 +00:00
Andrew Ozz
14d1e57e99 Enhance the editor on the Add/Edit Post screens, first run. Props avril, see #28328. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29049 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-09 22:05:06 +00:00
Sergey Biryukov
f92dc5aa41 Customizer: Export Previewer instance to wp.customize.previewer, and utilize for Widget Customizer. 
props westonruter.
fixes #27666.

git-svn-id: https://develop.svn.wordpress.org/trunk@29048 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-09 20:57:58 +00:00
Helen Hou-Sandi
2a5fa0e4c5 Display plugin install results as "cards" rather than in a list table, first run. 
props stephdau, ryelle, tellyworth, melchoyce. see #28785, #28646.



git-svn-id: https://develop.svn.wordpress.org/trunk@29047 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-09 20:01:35 +00:00
Helen Hou-Sandi
194122cb84 Remove an unused JS variable after [29036]. see #27406. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29042 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-09 17:45:36 +00:00
Helen Hou-Sandi
70639f7b90 Autoprefixer for [29040]. see #27440. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29041 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-09 17:41:00 +00:00
Helen Hou-Sandi
56706c324d Improvements to the plugin information modal: 
* Show the banner image when available.
* Show contributors and ratings breakdown in the FYI box.
* Show reviews in a tab.

props stephdau, tellyworth, paulwilde, michalzuber. see #27440. fixes #19784, #22599, #26202.


git-svn-id: https://develop.svn.wordpress.org/trunk@29040 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-09 17:27:22 +00:00
Drew Jaynes (DrewAPicture)
854fa2b5d6 Add @see reference for set_post_thumbnail() in the phpDoc for wp_ajax_set_attachment_thumbnail(). 
See #27891.


git-svn-id: https://develop.svn.wordpress.org/trunk@29037 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-08 20:35:53 +00:00
Helen Hou-Sandi
4e8a1a1ab1 accordion.js: 
* Remove remnants from when some corners were rounded.
* Docs.

props celloexpressions. see #27406.


git-svn-id: https://develop.svn.wordpress.org/trunk@29036 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-08 20:21:47 +00:00
Helen Hou-Sandi
054e4b5e65 Customizer panels: 
* Close all accordion sections when going in and out of panels.
* Fix panel positioning when top-level Customizer controls are scrolled down.
* Keyboard accessibility: only focus on visible elements and transfer between them as needed when navigating around panels.

props celloexpressions. see #27406.


git-svn-id: https://develop.svn.wordpress.org/trunk@29035 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-08 20:18:30 +00:00
Helen Hou-Sandi
d1c4c6fd6e Customizer info section: 
* Only show the theme info when doing a live preview of another theme.
* Replace with helper text about what you are customizing and what the Customizer is for.
* Fix focus styling.

props celloexpressions, westonruter. fixes #28550.


git-svn-id: https://develop.svn.wordpress.org/trunk@29034 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-08 19:52:17 +00:00
John Blackbourn
d9ba81155e Remove autocomplete from the database password screen on setup-config.php. Props hebbet. Fixes #28585. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29032 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-08 18:31:21 +00:00
Helen Hou-Sandi
bfdd641013 More consistent icons in place of some buttons for the Customizer and theme install preview. 
* Use a single close icon instead of a context-changing cancel/close button in the Customizer. In user testing, this small distinction in language was overlooked, and we use an AYS now instead. This also makes it consistent with the back arrow in Customizer panels.
* Use the same close icon as well as the previous/next arrows from the theme details browser in the theme install preview.

props celloexpressions. fixes #28655.


git-svn-id: https://develop.svn.wordpress.org/trunk@29031 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-08 18:18:23 +00:00
John Blackbourn
0a4e8b2b7e Implement email and url input types where appropriate. Props Kau-Boy. Fixes #22183. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29030 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-08 17:51:58 +00:00
Scott Taylor
c6428ff1ba When setting the poster image for a video shortcode, set that image as the featured image for that attachment (if found) in the background. This AJAX functionality could be used for audio as well. 
Introduces `attachment_url_to_postid()` to attempt to turn URLs into post IDs.

Fixes #27891.


git-svn-id: https://develop.svn.wordpress.org/trunk@29029 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-08 17:47:53 +00:00
Helen Hou-Sandi
c722aca8e5 When accessing the Customizer from the admin menu, make sure the user is returned to the originating page upon close. We should still investigate the general usage of customize-loader.js moving forward, but this approach fixes the immediate issue. props westonruter. fixes #25457. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29026 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-08 17:14:20 +00:00
Helen Hou-Sandi
0298f71032 Prompt the user before leaving the Customizer if they have unsaved changes. props westonruter. fixes #25439. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29025 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-08 17:03:48 +00:00
John Blackbourn
b72068ba06 Narrower layout and loading spinner for the install screen language selector. See #28577 
git-svn-id: https://develop.svn.wordpress.org/trunk@29021 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-08 00:32:29 +00:00
John Blackbourn
02a22f7dd4 Focus and blur styling (via JS) for the install screen language selector. Props jorbin. See #28577 
git-svn-id: https://develop.svn.wordpress.org/trunk@29020 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-08 00:29:47 +00:00
Andrew Nacin
8f15bef515 Language on install: Docs and naming cleanups. see #28577. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29018 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-07 21:48:50 +00:00
John Blackbourn
1f51b720f0 Correct the usage of the variable passed to wp_install_download_language_pack() and kill an unused local variable. Props michalzuber. Also avoid using the $_REQUEST superglobal in this function. See #28577. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29016 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-07 18:05:13 +00:00
Drew Jaynes (DrewAPicture)
e862e3cf6d Inline docs syntax fixes following [28978]. 
See #28740.


git-svn-id: https://develop.svn.wordpress.org/trunk@29015 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-07 16:41:43 +00:00
Sergey Biryukov
c9f0cb6295 Clarify a string on Add New User screen. 
props vancoder, collinsinternet.
fixes #27398.

git-svn-id: https://develop.svn.wordpress.org/trunk@29009 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-07 00:53:54 +00:00
Andrew Nacin
a6ff9013be Introduce wp_dropdown_languages() and use it on general settings. 
Early rough cut. Obviously not fully implemented.

see #15677.


git-svn-id: https://develop.svn.wordpress.org/trunk@29007 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-05 06:18:50 +00:00
Andrew Nacin
277ada83d8 Bring the language chooser to setup-config.php. 
see #28577.


git-svn-id: https://develop.svn.wordpress.org/trunk@29006 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-05 05:13:05 +00:00
Andrew Nacin
f25c1e989b Don't include plugin.php twice in setup-config.php. 
fixes #28744. see #28740, [28978].


git-svn-id: https://develop.svn.wordpress.org/trunk@29005 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-05 02:12:47 +00:00
Sergey Biryukov
c1c0693cee Reinstate 'install_themes_tabs' filter. 
props ghost1227.
fixes #28578.

git-svn-id: https://develop.svn.wordpress.org/trunk@29002 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-04 23:57:39 +00:00
Helen Hou-Sandi
e14d866665 Media grid, round 2. Expect much more to come. 
* Instead of a sidebar for details, utilize a modal. The modal experience allows for a larger preview, editing images, audio/video previews, and previous/next navigation, like the theme browser. Think of it as an attachment browser.
* Show some details in the grid view to more easily distinguish items.

props ericlewis, wonderboymusic, JerrySarcastic. see #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@28993 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-04 03:38:33 +00:00
Scott Taylor
9c314d1d00 Make a new file: media-grid.js. This will be way more useful in later commits and help reduce churn and bloat in media-views.js. 
See #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@28992 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-04 02:17:22 +00:00
John Blackbourn
4e3b729b09 If we already have a value for WPLANG when installing, insert this language at the top of the language selector and pre-select it. See #28577 
git-svn-id: https://develop.svn.wordpress.org/trunk@28984 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-03 22:55:57 +00:00
John Blackbourn
db8b7380b2 First pass at switching to radio inputs for the install screen language selector. Needs some more work. See #28577. Props jorbin 
git-svn-id: https://develop.svn.wordpress.org/trunk@28983 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-03 22:53:01 +00:00
John Blackbourn
35578f8f9a Avoid a warning if the translations API call fails on step 1. Remove assignment inside an if statement. See #28577. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28982 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-03 22:30:27 +00:00
Drew Jaynes (DrewAPicture)
79dd39c19c Note in the hook docs for preview_post_link that the $post parameter was added. 
See #28729.


git-svn-id: https://develop.svn.wordpress.org/trunk@28979 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-03 20:04:56 +00:00
Andrew Nacin
a7c3b23f1c Simplify the setup-config.php UI flow and load process. 
When no configuration file is detected, we now redirect to setup-config.php. This process now uses the WordPress bootstrap, rather than a set of fragile hacks.

fixes #28740.


git-svn-id: https://develop.svn.wordpress.org/trunk@28978 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-03 19:56:37 +00:00
Drew Jaynes (DrewAPicture)
b1b454c7a0 Remove backticks on $post variables in some short parameter descriptions. 
See [28653], [28654].
See #28388.


git-svn-id: https://develop.svn.wordpress.org/trunk@28976 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-03 19:27:54 +00:00
Drew Jaynes (DrewAPicture)
7ffc91fdd6 Fix an incomplete docblock for wp_create_categories() as part of $post/$post_id cleanup. 
See #28388.


git-svn-id: https://develop.svn.wordpress.org/trunk@28975 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-03 19:21:34 +00:00
John Blackbourn
c18a28f792 Use the admin scheme for theme preview URLs when installing new themes. See #21919. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28974 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-03 18:47:33 +00:00
Helen Hou-Sandi
3adcda996b Improve oEmbed caching. Introduces the concept of a TTL for oEmbed caches and a filter for oembed_ttl. 
We will no longer replace previously valid oEmbed responses with an `{{unknown}}` cache value. When this happens due to reaching a rate limit or a service going down, it is data loss, and is not acceptable. This means that oEmbed caches for a post are no longer deleted indiscriminately every time that post is saved.

oEmbed continues to be cached in post meta, with the addition of a separate meta key containing the timestamp of the last retrieval, which is used to avoid re-requesting a recently cached oEmbed response. By default, we consider a valued cached in the past day to be fresh. This can greatly reduce the number of outbound requests, especially in cases where a post containing multiple embeds is saved frequently.

The TTL used to determine whether or not to request a response can be filtered using `oembed_ttl`, thus allowing for the possibility of respecting the optional oEmbed response parameter `cache_age` or altering the period of time a cached value is considered to be fresh.

Now that oEmbeds are previewed in the visual editor as well as the media modal, oEmbed caches are often populated before a post is saved or published. By pre-populating and avoiding having to re-request that response, we also greatly reduce the chances of a stampede happening when a published post is visible before oEmbed caching is complete.

As it previously stood, a stampede was extremely likely to happen, as the AJAX caching was only triggered when `$_GET['message']` was 1. The published message is 6. We now trigger the caching every time `$_GET['message']` is present on the edit screen, as we are able to avoid triggering so many HTTP requests overall.

props markjaquith. fixes #14759. see #17210.


git-svn-id: https://develop.svn.wordpress.org/trunk@28972 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-03 16:44:15 +00:00
Sergey Biryukov
8bf7ed77f3 Pass $post object to 'preview_post_link' filter. 
props danielbachhuber.
fixes #28729.

git-svn-id: https://develop.svn.wordpress.org/trunk@28969 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-03 14:41:06 +00:00
Sergey Biryukov
8ee9631bb4 Remove non-breaking spaces from auto update email text. 
props trepmal.
fixes #28715.

git-svn-id: https://develop.svn.wordpress.org/trunk@28956 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-02 12:45:31 +00:00
Sergey Biryukov
0d2817bf9e Simplify a condition in get_sample_permalink_html(). 
see #28350.

git-svn-id: https://develop.svn.wordpress.org/trunk@28948 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-02 00:10:13 +00:00
Sergey Biryukov
3fe0336a63 Simplify logic in get_sample_permalink_html(), remove duplicated code. 
see #28350.

git-svn-id: https://develop.svn.wordpress.org/trunk@28947 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-02 00:03:53 +00:00
Sergey Biryukov
7a8bedaf2a Display a correct preview link for drafts when permalinks are disabled. 
see #28350.

git-svn-id: https://develop.svn.wordpress.org/trunk@28946 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-01 23:55:58 +00:00
Helen Hou-Sandi
c6c89eed8a Only apply metabox handle styles and JS events to .postbox .hndle, as opposed to all h3s in a .postbox. 
Developers previously relying on the `h3` behavior may be affected. You may want to investigate `do_meta_boxes()` rather than recreating markup.

props SergeyBiryukov, nabil_kadimi.
fixes #28485.


git-svn-id: https://develop.svn.wordpress.org/trunk@28940 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-01 16:22:32 +00:00
Dominik Schilling (ocean90)
5aeaa14d9a Customizer: Reverse arrows in RTL. See #27406. 
props yoavf.
fixes #28669.

git-svn-id: https://develop.svn.wordpress.org/trunk@28931 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-30 19:59:51 +00:00
Dominik Schilling (ocean90)
6f51a5f972 Customizer: Support textarea and commonly-used input types as control type in WP_Customize_Control. 
Add `input_attrs` property to support custom input attributes.

(Demo plugin attached to ticket.)

props celloexpressions.
fixes #28477.

git-svn-id: https://develop.svn.wordpress.org/trunk@28930 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-30 19:47:56 +00:00
Helen Hou-Sandi
4f7bc0410f Support descriptions for individual customizer controls. 
* Control title (label) markup will also only be output if specified.
* Control section descriptions are no longer italicized for visual hierarchy / differentiation.

props celloexpressions. fixes #27981.


git-svn-id: https://develop.svn.wordpress.org/trunk@28927 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-30 15:54:04 +00:00
Sergey Biryukov
913392b9a9 Display consistent preview links for drafts. 
props mordauk.
fixes #28350.

git-svn-id: https://develop.svn.wordpress.org/trunk@28920 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-30 10:02:01 +00:00
Andrew Ozz
df6eb733eb Secure embeds in the editor (first run): 
- When the user pastes an embeddable http URL, try to get the https embed.
- If an embed provider doesn't support ssl embeds, show a placeholder/error message.
- Revise the way we return error messages.
See #28195, #28507.

git-svn-id: https://develop.svn.wordpress.org/trunk@28919 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-30 05:48:16 +00:00
Sergey Biryukov
29aabd08a9 Prevent bulk actions from being performed when Filter button is clicked. 
props jesin.
fixes #28555.

git-svn-id: https://develop.svn.wordpress.org/trunk@28916 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-30 01:09:25 +00:00
Scott Taylor
11da6abc57 Allow comments in the trash to marked as spam. 
Props mordauk.
Fixes #19256.


git-svn-id: https://develop.svn.wordpress.org/trunk@28913 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-29 23:18:24 +00:00
Scott Taylor
d204e4dea0 Admin screens should use the WPINC constant 
Props wojtek.szkutnik
See #14157.


git-svn-id: https://develop.svn.wordpress.org/trunk@28906 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-29 22:20:26 +00:00
Scott Taylor
48c145ee78 WP_Filesystem_Base->abspath() should use the WPINC constant 
Props wojtek.szkutnik
See #14157.


git-svn-id: https://develop.svn.wordpress.org/trunk@28904 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-29 22:15:10 +00:00
Sergey Biryukov
1e7b12978c Set date format before going into the loop to avoid a PHP notice if 'lastupdated' column is filtered out. 
props jeremyfelt.
fixes #27614.

git-svn-id: https://develop.svn.wordpress.org/trunk@28898 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-29 18:10:52 +00:00
Sergey Biryukov
107001213b Fix feature pointer positioning issues for both LTR and RTL. 
fixes #28062.

git-svn-id: https://develop.svn.wordpress.org/trunk@28897 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-29 16:05:53 +00:00
John Blackbourn
db4da6e488 Remove the WordPress logo from the focusable elements on the install/update screens. Fixes #28674. Props stompweb 
git-svn-id: https://develop.svn.wordpress.org/trunk@28896 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-29 14:09:39 +00:00
John Blackbourn
3426416dac Normalise the schemes used in get_home_path() so it returns the correct path for sites using SSL in the admin area but not the front end. Fixes #25767. Props GregLone for the initial patch. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28893 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-29 10:28:52 +00:00
John Blackbourn
075be3e54b Introduce a filter to control the minimum characters required for an AJAX term search. Fixes #13580. Props iamfriendly, brianlayman 
git-svn-id: https://develop.svn.wordpress.org/trunk@28892 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-29 10:04:05 +00:00
Sergey Biryukov
08969ece9e Show a "No themes found" message if the search for an installed theme doesn't produce any results. 
props gauravmittal1995 for initial patch.
fixes #28587.

git-svn-id: https://develop.svn.wordpress.org/trunk@28890 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-29 09:15:08 +00:00
Scott Taylor
2d56abdd2e Add new action 'delete_user_form' in wp-admin/users.php and wp-admin/network/users.php. 
Props SergeyBiryukov, usermrpapa.
Fixes #27230.


git-svn-id: https://develop.svn.wordpress.org/trunk@28885 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-28 04:42:24 +00:00
Helen Hou-Sandi
9becde117d Make the posts list table mode a sticky user setting. props garyc40, azaozz, ericmann. fixes #16774, #20335. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28876 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-28 02:16:59 +00:00
Scott Taylor
572e27c682 Remove remaining Heartbeat API experimental notices 
Props DH-Shredder.
Fixes #28626.


git-svn-id: https://develop.svn.wordpress.org/trunk@28872 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-28 02:05:54 +00:00
Scott Taylor
2371f75688 In deprecated media iframe code, attachment_fields_to_save filter should not be called twice after initial image upload in post. 
Props SergeyBiryukov.
Fixes #20720.


git-svn-id: https://develop.svn.wordpress.org/trunk@28871 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-27 21:31:28 +00:00
Helen Hou-Sandi
c27492cf26 Don't switch contextual help tabs when tabbing around. props neil_pie. see #28209. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28869 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-27 19:09:17 +00:00
Sergey Biryukov
d2d985ffeb Avoid duplication of callbacks in theme browser sidebar each time the Next or Previous button is clicked. 
This makes the collapse/expand button work as expected.

fixes #28581.

git-svn-id: https://develop.svn.wordpress.org/trunk@28868 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-27 16:05:07 +00:00
Dominik Schilling (ocean90)
7edd9edde4 Customizer: Introduce a "panel" API to organize multiple sections into a one section. 
Create a panel via `$GLOBALS['wp_customize']->add_panel( $panel_id, $args )` and use `$panel_id` for the `panel` argument in `$GLOBALS['wp_customize']->add_section( $section_id, $args )`. That's it.
As an example all widget area sections are now summarized into one panel. Feedback appreciated.

props celloexpressions.
see #27406.

git-svn-id: https://develop.svn.wordpress.org/trunk@28861 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-26 20:16:21 +00:00
Sergey Biryukov
3513f37623 Fix unexpected replacement of a previous tag when selecting a tag from autosuggest results. 
props camdensegal.
fixes #28471.

git-svn-id: https://develop.svn.wordpress.org/trunk@28851 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-26 16:07:36 +00:00
Helen Hou-Sandi
2187cc6f98 Slightly bump up the login logo size to avoid getting chopped off by Firefox's rounding problems. props SergeyBiryukov for the initial patch. fixes #28393. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28850 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-26 15:35:19 +00:00
Sergey Biryukov
7fa39e6839 Replace Y/m/d date format in general settings with a more popular one, Y-m-d. 
props gauravmittal1995.
fixes #28447.

git-svn-id: https://develop.svn.wordpress.org/trunk@28848 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-26 14:28:04 +00:00
Andrew Ozz
38debafe60 Uploader: enable selecting multiple files on mobile devices (still doesn't work on Android). See #28640. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28847 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-26 04:14:59 +00:00
Scott Taylor
cf15c523d3 Only apply a subtle semi-transparent border to attachments that are images in the media list table. 
See [28842], #15860.



git-svn-id: https://develop.svn.wordpress.org/trunk@28843 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-26 01:57:37 +00:00
Scott Taylor
f92d73310a Apply a subtle semi-transparent border to images in the media list table to avoid the "white on white (like a polar bear in Antarctica)" problem. 
Props ericlewis.
Fixes #15860.


git-svn-id: https://develop.svn.wordpress.org/trunk@28842 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-26 01:51:20 +00:00
Scott Taylor
95f3506532 In media_buttons(), add a static var $instance to increment the id attribute of insert-media-button-%d on each call. 
Props ericlewis.
Fixes #28090.


git-svn-id: https://develop.svn.wordpress.org/trunk@28837 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-26 01:04:32 +00:00
Drew Jaynes (DrewAPicture)
8130335b9d Add braces missed while adding docs for the option_page_capability_{$option_page} hook. 
See [25372]. See #25229.


git-svn-id: https://develop.svn.wordpress.org/trunk@28833 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-25 21:47:14 +00:00
Scott Taylor
1c947d9ef1 Bring the list of upload_filetypes for multisite into modernity based on .com upgrades and supported extensions for audio and video. 
Fixes #24434.


git-svn-id: https://develop.svn.wordpress.org/trunk@28832 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-25 17:59:54 +00:00
Scott Taylor
69101fe0f3 The "old iframe media modal" has some pretty busted styles. Although this is a "deprecated" feature, clean up some of the broken styles. 
Props erayalakese for the JS patch.
Fixes #28220.



git-svn-id: https://develop.svn.wordpress.org/trunk@28830 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-25 17:38:28 +00:00
Scott Taylor
6f220c7fc7 Make the list of gallery attachments in the "old iframe media modal" break less. The "columns" are not aligned with the headers, but this would require a markup rewrite of a deprecated feature. 
Fixes #28098.



git-svn-id: https://develop.svn.wordpress.org/trunk@28829 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-25 17:11:36 +00:00
Sergey Biryukov
b1fd1dbbcf Add ISO date standard YYYY-MM-DD format to general settings. 
props mattheweppelsheimer.
fixes #28447.

git-svn-id: https://develop.svn.wordpress.org/trunk@28820 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-24 09:49:37 +00:00
Scott Taylor
832bbb2821 Remove noscript from wpautop()'s list of block elements. 
Props mdawaffe.
Fixes #27268.


git-svn-id: https://develop.svn.wordpress.org/trunk@28817 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-24 00:53:41 +00:00
Scott Taylor
723927ca74 Adjust CSS for "Moved to the trash" message for a pingback in the dashboard. 
Props zoerooney, codenameEli.
Fixes #28286.


git-svn-id: https://develop.svn.wordpress.org/trunk@28811 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-24 00:02:17 +00:00
Scott Taylor
848034a190 Use unobtrusive JS for Comment list table row actions. 
Props aubreypwd.
Fixes #27533.


git-svn-id: https://develop.svn.wordpress.org/trunk@28810 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-23 23:54:28 +00:00
Sergey Biryukov
2120ede170 Remove mbstring_binary_safe_strlen(). Use mbstring_binary_safe_encoding() and reset_mbstring_encoding() directly. 
fixes #28162.

git-svn-id: https://develop.svn.wordpress.org/trunk@28808 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-23 22:20:23 +00:00
Sergey Biryukov
4fd715c937 Introduce a binary-safe wrapper for strlen() and use it in seems_utf8(), utf8_uri_encode(), and wp_read_image_metadata(). 
Use binary-safe POMO_Reader::strlen() in MO::export_to_file_handle().

fixes #28162.

git-svn-id: https://develop.svn.wordpress.org/trunk@28806 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-23 14:47:08 +00:00
Scott Taylor
76ccf2a956 Remove unused globals from link-parse-opml.php after [28743]. 
Props SergeyBiryukov.
Fixes #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28786 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-20 17:25:47 +00:00
Andrew Nacin
e27b672b22 Narrower screen when choosing a language. see #28577. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28780 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-19 04:46:40 +00:00
Andrew Nacin
aa6ef01298 Fix variable usage in new language install choices. see #28577. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28779 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-19 04:36:29 +00:00
Helen Hou-Sandi
ae2cce3f64 Restore the ability to pass classes to admin menu submenu items, important for the Customize link. Accidentally left out in [24048]. fixes #28583. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28778 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-19 02:17:08 +00:00
Sergey Biryukov
4bee2a9c4a Fix copy/paste error in a comment. 
see #28581.

git-svn-id: https://develop.svn.wordpress.org/trunk@28777 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-19 01:35:28 +00:00
Andrew Nacin
39cf46851b Allow a language to be chosen before installing WordPress. First pass. 
* Checks WordPress.org for available languages.
* In get_locale(), starts using the WPLANG option that has existed in multisite since the MU days.
* Adds new argument to wp_install() for setting WPLANG.

see #28577. 


git-svn-id: https://develop.svn.wordpress.org/trunk@28774 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-18 19:57:21 +00:00
Sergey Biryukov
6719d08d2d Revert [28766]. 
see #28555.

git-svn-id: https://develop.svn.wordpress.org/trunk@28772 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-18 02:22:45 +00:00
Sergey Biryukov
9561db4dee Don't add # to URL when clicking 'OK' without changing the permalink. 
props avryl.
fixes #27594.

git-svn-id: https://develop.svn.wordpress.org/trunk@28771 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-18 00:28:35 +00:00
Sergey Biryukov
63596d6868 Prevent bulk actions from being performed when Filter button is clicked. 
props layotte.
fixes #28555.

git-svn-id: https://develop.svn.wordpress.org/trunk@28766 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-17 22:16:11 +00:00
Sergey Biryukov
177d39a15b Fix labels on installation screen. 
props avryl.
fixes #28548.

git-svn-id: https://develop.svn.wordpress.org/trunk@28759 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-17 14:36:22 +00:00
Andrew Ozz
ed07c215dc wpView: improve handling of embed errors/error messages, see #28195 
git-svn-id: https://develop.svn.wordpress.org/trunk@28754 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-15 22:52:45 +00:00
Andrew Nacin
65803684f4 Add a new 'Beta Testing' tab on the plugin installer, for features as plugins such as Press This. 
fixes #28513.


git-svn-id: https://develop.svn.wordpress.org/trunk@28749 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-12 18:08:56 +00:00
Scott Taylor
e0a089d9d8 Don't use variable variables in touch_time(). 
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28747 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-11 21:04:56 +00:00
Scott Taylor
61c1da236c Don't use variable variables in wp_reset_vars(). Test by searching in list tables, etc. 
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28746 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-11 19:59:18 +00:00
Scott Taylor
eb23569835 Don't use variable variables in user-new.php. Test by causing errors when creating a new user. 
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28745 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-11 19:53:25 +00:00
Scott Taylor
6e159bb671 Don't use variable variables in setup-config.php (Step 2). 
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28744 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-11 19:40:27 +00:00
Scott Taylor
98f3cd0548 OPML: 
* Learn how OPML works, cry.
* Remove unused globals in `startElement()`
* Stop using variable variables in `startElement()`

Tested with the OPML importer plugin

See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28743 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-11 19:30:26 +00:00
Scott Taylor
4ccb011960 Don't use variable variables in wp_dashboard_plugins_output(). Variable variables aren't the worst thing about this function. 
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28742 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-11 18:55:00 +00:00
John Blackbourn
f02e878bb0 Only include relevant post authors in WXR exports. Fixes #20206. Props jeremyfelt. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28731 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-10 19:14:26 +00:00
John Blackbourn
827cf97b00 Add screen reader labels to the date inputs on the post editing screen. Fixes #25461. Props frank-klein. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28730 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-10 18:49:26 +00:00
Scott Taylor
121726df31 edit.php?post_type=attachment should redirect to upload.php. Without the redirect, the user is presented with an empty list table. There are probably other issues to address overall, but this accomplishes what the ticket wants. 
Props knutsp.
Fixes #27951.


git-svn-id: https://develop.svn.wordpress.org/trunk@28729 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-10 18:47:57 +00:00
Scott Taylor
84ad12b439 Replace all uses of like_escape() with $wpdb->esc_like(). 
Props miqrogroove.
See #10041.


git-svn-id: https://develop.svn.wordpress.org/trunk@28712 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-10 00:43:32 +00:00
Scott Taylor
faf208de38 Live update the menu item title when the user is editing the "Navigation Label" field. 
Props celloexpressions.
See #23076.


git-svn-id: https://develop.svn.wordpress.org/trunk@28707 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-09 18:38:29 +00:00
Helen Hou-Sandi
70390c48f5 Properly indicate with the cursor that the editor can be vertically resized using the entire info bar, not just the handle displayed in the corner. 
props torresga. fixes #28420.


git-svn-id: https://develop.svn.wordpress.org/trunk@28703 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-08 19:47:00 +00:00
Helen Hou-Sandi
3d9fc450b2 Grid view for the media library, first pass. This is alpha; expect imperfection. We will be iterating further. 
props ericlewis, shaunandrews, wonderboymusic.
see #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@28682 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-05 22:00:24 +00:00
Sergey Biryukov
c7c1a4a88a Remove one-time variable from add_settings_error(). 
props niallkennedy.
fixes #22228.

git-svn-id: https://develop.svn.wordpress.org/trunk@28681 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-05 18:28:15 +00:00
Sergey Biryukov
7f3b20c45d Remove redundant 'Visit author homepage' title attributes for plugins and themes. 
props joedolson.
fixes #26554.

git-svn-id: https://develop.svn.wordpress.org/trunk@28673 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-05 04:51:55 +00:00
Drew Jaynes (DrewAPicture)
24b3ed214e Make sure to use 3-digit x.x.x style for two 3.9.0 @since versions. 
Props netweb.
Fixes #28446.


git-svn-id: https://develop.svn.wordpress.org/trunk@28658 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-04 05:34:37 +00:00
Drew Jaynes (DrewAPicture)
9bb9177199 Make sure $post is properly documented as optional where applicable. 
See #28388.


git-svn-id: https://develop.svn.wordpress.org/trunk@28653 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-03 03:52:46 +00:00
Sergey Biryukov
e8e39d212b Plugin activation/deletion errors should be styled as such. 
props johnbillion.
fixes #28260.

git-svn-id: https://develop.svn.wordpress.org/trunk@28646 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-31 20:09:26 +00:00
Sergey Biryukov
c04daa1ade Avoid stomping of the $plugin variable in activate_plugin(). 
fixes #28102.

git-svn-id: https://develop.svn.wordpress.org/trunk@28644 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-30 22:07:43 +00:00
Sergey Biryukov
9120e6a9d7 Display the site scheme, not the current scheme on Edit Site screen in network admin. 
props johnbillion.
fixes #28406.

git-svn-id: https://develop.svn.wordpress.org/trunk@28643 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-30 22:00:45 +00:00
Sergey Biryukov
dbef7e2587 Add paragraph tags to 'Add Existing User' section on 'Add New User' screen in multisite. 
props jkudish, topher1kenobe.
fixes #20271.

git-svn-id: https://develop.svn.wordpress.org/trunk@28642 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-30 21:50:24 +00:00
Scott Taylor
804b82bd11 Make the image editor less jumpy when opening. 
Props eddiemoya, ericlewis.
Fixes #22793.



git-svn-id: https://develop.svn.wordpress.org/trunk@28639 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-30 19:52:35 +00:00
Scott Taylor
e996a74984 Restore $val in WP_Importer::bump_request_timeout() - even though the parent class and WP_Import ignore the parameter, it creates an incompatible interface notice in the plugin. 
See [28629].



git-svn-id: https://develop.svn.wordpress.org/trunk@28637 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-30 19:34:53 +00:00
Scott Taylor
2cd825a21b Cleanup for switch statements: 
* Move `default` to the bottom in `WP_Theme_Install_List_Table`
* `switch/endswitch` syntax is not supported in Hack. Switch to `switch (...) {  .... }` syntax. (A few template-type instances linger).

Fixes #28409.
See #27881.



git-svn-id: https://develop.svn.wordpress.org/trunk@28633 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-30 17:57:51 +00:00
Drew Jaynes (DrewAPicture)
dc96d99a70 Remove unnecessary "not used" notation for filter parameters in wp-admin/includes/media.php. 
Also add `@param` and `@return` descriptions.

See #28408.


git-svn-id: https://develop.svn.wordpress.org/trunk@28632 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-30 17:37:36 +00:00
Scott Taylor
7ab6b096e6 Remove some dead variable assignments. 
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28629 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-30 16:58:36 +00:00
Andrew Ozz
d87a482353 TinyMCE in iOS: 
- Fix placing the caret at the bottom of longer posts when the keyboard is open.
- Disable resizing on switching editors and on show/hide the kitchen sink row.
See #28242

git-svn-id: https://develop.svn.wordpress.org/trunk@28626 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-30 02:37:52 +00:00
Helen Hou-Sandi
220a45a32d Don't use the box shadow focus styling for the admin menu or toolbar. see #28267. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28616 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-29 14:22:39 +00:00
Helen Hou-Sandi
06c142a1a5 Better align link element focus with form focus styling, which also improves the visibility. props zamfeer. see #28267. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28608 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-29 03:57:44 +00:00
Sergey Biryukov
c73f5ef2de Fix displaying taxonomies in bulk edit if the post type does not support titles. 
props scribu.
fixes #16793.

git-svn-id: https://develop.svn.wordpress.org/trunk@28600 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-28 13:49:21 +00:00
Sergey Biryukov
7b133a336f Remove obsolete code from wp_dashboard_setup(). 
props kitchin.
fixes #26604.

git-svn-id: https://develop.svn.wordpress.org/trunk@28592 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-27 15:40:19 +00:00
Sergey Biryukov
2f1ad4ddbf Move 'Documentation on date and time formatting' link under the 'Time Format' block. 
props gauravmittal1995.
fixes #28348.

git-svn-id: https://develop.svn.wordpress.org/trunk@28591 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-27 14:49:51 +00:00
Sergey Biryukov
86b88bd2b7 Add BMP to the list of displayable image types. 
props ericlewis.
fixes #26808.

git-svn-id: https://develop.svn.wordpress.org/trunk@28589 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-27 13:24:39 +00:00
Sergey Biryukov
c2076859eb Remove redundant get_shortcode_regex() check. 
props kovshenin.
see #28195.

git-svn-id: https://develop.svn.wordpress.org/trunk@28587 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-27 11:29:11 +00:00
Scott Taylor
792fe23675 When adding a URL in the Insert from URL state in the media modal, attempt to show a preview of the content. Drop the unused width and height fields. 
This will probably be iterated upon.

Props helen, jtsternberg, wonderboymusic.
See #15490.


git-svn-id: https://develop.svn.wordpress.org/trunk@28581 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-26 23:56:27 +00:00
Scott Taylor
8567bba0bf Don't pass embeds through the_content() when trying to render MCE previews, leverage WP_Embed and do_shortcode() instead. 
Props kovshenin.
See #28195.



git-svn-id: https://develop.svn.wordpress.org/trunk@28580 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-26 23:42:08 +00:00
Scott Taylor
5c3f7d5392 In media_sideload_image(), check the returned value of download_url() earlier to avoid attempting to unlink() an instance of WP_Error. 
Props georgestephanis. 
Fixes #28204.


git-svn-id: https://develop.svn.wordpress.org/trunk@28567 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-23 21:32:12 +00:00
Scott Taylor
a2b0c8b2e4 In get_terms_to_edit(), call get_object_term_cache() before priming cache with wp_get_object_terms(). 
In `get_inline_data()`, do the same.

On list table screens with taxonomies in the admin, this dramatically reduces the number of database queries (3x less). Even more so with a persistent object cache (5x less).

Props johnbillion, jeffstieler, wonderboymusic.
Fixes #18968.



git-svn-id: https://develop.svn.wordpress.org/trunk@28561 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-23 19:28:45 +00:00
Scott Taylor
a4e1ec0b90 Fix parsing in wp_match_mime_types() to allow some mime-types with + in them to appear in the list of filter links shown above the list table on upload.php. 
Props _duck.
Fixes #20672.



git-svn-id: https://develop.svn.wordpress.org/trunk@28553 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-22 21:35:36 +00:00
Scott Taylor
e53cdbb8f0 In wp_dashboard_recent_posts(), $i is set and never used. 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28545 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-22 18:55:07 +00:00
Scott Taylor
70342f4a75 $theme_name is set but no longer used in wp_dashboard_right_now(). The theme name is displayed with the call to update_right_now_message(). 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28544 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-22 18:53:43 +00:00
Scott Taylor
312ef7b264 These functions import $wpdb but do not use it. 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28539 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-22 17:36:42 +00:00
Sergey Biryukov
15588188e8 Fix inconsistent header underlining and spacing in background update emails. 
fixes #28306.

git-svn-id: https://develop.svn.wordpress.org/trunk@28537 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-22 09:40:36 +00:00
Sergey Biryukov
9966795165 Use correct function name. 
props ericlewis.
fixes #28329.

git-svn-id: https://develop.svn.wordpress.org/trunk@28535 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-22 07:58:26 +00:00
Scott Taylor
dc1ada20c7 Upgrade _WP_List_Table_Compat to PHP5-style constructor. 
Add `public` to methods/members of `WP_Role`.
Add `public` to methods/members of `WP_User` where appropriate. Don't set `private` where indicated until more study has occurred and tests have been written for compatibiliy with existing magic methods.

See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28531 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 17:19:09 +00:00
Scott Taylor
be2e5f6fb5 hackificator doesn't like mixed single/double-quoted attributes. These were 2 lingering instances in the admin. 
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28530 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 17:09:42 +00:00
Scott Taylor
d261d0030a In WP_Filesystem_Base, the constructor is a noop, so it shouldn't even be declared. Setting it implies that parent::__construct() should be called by its subclasses. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28529 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 16:45:42 +00:00
Scott Taylor
daecbc9659 Classes that have __set() also need __isset() and __unset(). 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28524 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 06:51:35 +00:00
Scott Taylor
77c6420969 Some classes with __get() method also need __set(). 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28521 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 06:31:00 +00:00
Scott Taylor
f716ff94e4 Add missing access modifiers to methods/members in Walker and subclasses. Add a magic __get() method. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28514 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 05:59:07 +00:00
Scott Taylor
e43d2a73d8 Fix some hackificator odds and ends in wp-admin: 
* `wp-activate.php` and `wp-admin/themes.php` don't need the closing PHP tag
* Switch single quotes for HTML attribute values to double in a few places
* Convert `include_once file.php` syntax to `include_once( 'file.php' )`
* Add access modifiers to methods/members in: `_WP_List_Table_Compat`, `Walker_Nav_Menu_Edit`, `Walker_Nav_Menu_Checklist`, `WP_Screen`, `Walker_Category_Checklist`
* `edit_user()` doesn't need to import the `$wpdb` global
* `wp_list_widgets()` doesn't need to import the `$sidebars_widgets` global
* switch/endswitch syntax is not supported in Hack
* A `<ul>` in `wp-admin/users.php` is unclosed

See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28500 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 05:03:44 +00:00
Drew Jaynes (DrewAPicture)
7b2c87df9a Improve inline documentation of default arguments for post_format_meta_box(), post_tags_meta_box(), and post_categories_meta_box(). 
See #28298.


git-svn-id: https://develop.svn.wordpress.org/trunk@28499 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 03:22:21 +00:00
Scott Taylor
eef0d99ed8 hackificator doesn't like mixed quote styles in some generated HTML. The switch from single to double allows these files to be parsed. 
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28497 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 01:58:28 +00:00
Scott Taylor
afe33f0f68 Add access modifier (public) to methods and members of WP_Upgrader and its subclasses. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28496 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 01:28:10 +00:00
Scott Taylor
17cabb1d8e Add access modifier (public) to methods and members of WP_Upgrader_Skin and its subclasses. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28495 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 01:22:55 +00:00
Scott Taylor
b1a09cf65d Add access modifiers to methods and members of WP_Users_List_Table. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28494 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 01:18:46 +00:00
Scott Taylor
d6a3c2a0de Add access modifiers to methods and members of list table classes: 
* `WP_List_Table` is the base class that implements `__get()` and `__call()` for BC
* Adds unit tests to confirm that subclasses properly inherit magic methods
* Add modifiers to subclasses: `WP_Links_List_Table`, `WP_Media_List_Table`, `WP_MS_Sites_List_Table`, `WP_MS_Themes_List_Table`, `WP_MS_Users_List_Table`, `WP_Plugin_Install_List_Table`, `WP_Plugins_List_Table`, `WP_Posts_List_Table`, `WP_Terms_List_Table`, `WP_Theme_Install_List_Table`, `WP_Themes_List_Table`

See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28493 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 01:16:16 +00:00
Scott Taylor
99c99b77e3 Add access modifier (public) to methods in WP_Importer. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28492 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 00:19:00 +00:00
Scott Taylor
ae31b3795c Add access modifier (public) to members and methods in WP_Filesystem_SSH2. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28491 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 00:17:18 +00:00
Scott Taylor
fce8b1e0c3 Add access modifier (public) to members and methods in WP_Filesystem_ftpsockets. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28490 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 00:13:29 +00:00
Scott Taylor
434ce7f6d8 Add access modifier (public) to members and methods in WP_Filesystem_FTPext. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28489 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 00:11:21 +00:00
Scott Taylor
ec06d96ce6 Add access modifier (public) to methods in WP_Filesystem_Direct. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28488 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 00:08:38 +00:00
Scott Taylor
06672a6c5a Add access modifiers to members and methods in WP_Filesystem_Base. Add magic __get() method for backwards compatibility. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28487 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 00:05:06 +00:00
Scott Taylor
6e09b1f167 Add access modifier (public) to members and methods in WP_Comments_List_Table and WP_Post_Comments_List_Table. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28486 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-18 23:58:38 +00:00
Scott Taylor
8af8f5f8f2 In edit-link-form.php, hackificator bails because there is a </form> with no open <form>. It exists, but is needlessly constructed with PHP. It always returns a <form>, only the id and name are different. The dynamic piece just returns the ID now. 
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28485 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-18 22:06:22 +00:00
Scott Taylor
4f74ef5466 hackificator bails on this file because of mixed quote styles on some HTML attributes. 
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28484 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-18 21:47:01 +00:00
Scott Taylor
c6919845ca Remove public keyword from some JS functions. Sorry. 
Props ocean90.
See #22234.



git-svn-id: https://develop.svn.wordpress.org/trunk@28483 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-18 21:42:32 +00:00
Scott Taylor
01fa4c0c1e hackificator bails on this file because the <meta> isn't self-closing. 
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28482 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-18 21:35:03 +00:00
Scott Taylor
e509190fb3 Use proper access modifiers and add a magic __get() method to Custom_Background and Custom_Image_Header. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28481 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-18 21:30:43 +00:00
Scott Taylor
1b4e4e665a hackificator complains if you call include 'file.php' without the parens, needs to be include( 'file.php' ) 
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28479 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-18 20:51:44 +00:00
Scott Taylor
af0851cc0d Because the WP_ADMIN constant name can be bound in multiple files, all instances should check ! defined first. wp-admin/admin.php already has this check. 
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28478 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-18 20:41:28 +00:00
Scott Taylor
f083cc4e9b The About page has a <div> that doesn't close. Also, <hr>s should self-close. hackificator complains about these things. 
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28477 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-18 20:32:58 +00:00
Sergey Biryukov
0cc180b0a4 Fix wp_insert_link(), broken in [28406]/[28408]. 
see #22400.

git-svn-id: https://develop.svn.wordpress.org/trunk@28475 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-18 09:55:16 +00:00
Drew Jaynes (DrewAPicture)
9e81d2d692 Add inline documentation for default arguments in wp_insert_category(). 
See #28298.


git-svn-id: https://develop.svn.wordpress.org/trunk@28474 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-18 07:27:25 +00:00
Sergey Biryukov
d56f67b8e9 Update help text on Add Themes screen. 
props thomasvanderbeek.
fixes #28132.

git-svn-id: https://develop.svn.wordpress.org/trunk@28473 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-17 23:43:41 +00:00
Scott Taylor
40e6ec443f Add inline comment after fix in [28467]. 
Props jesin.
Fixes #28292.



git-svn-id: https://develop.svn.wordpress.org/trunk@28468 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-17 15:41:40 +00:00
Scott Taylor
14a7b47119 Restore $soucrce in WP_Upgrader::install_package(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28467 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-17 15:39:33 +00:00
Scott Taylor
ccc874514c Eliminate use of extract() in request_filesystem_credentials(). 
The only property that doesn't need to be set to a variable is `$password`.

See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28456 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-16 18:25:41 +00:00
Andrew Ozz
6fa89637e5 DFW: fix closing only the wpLink or media modal when pressing Esc. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28455 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-16 18:16:59 +00:00
Scott Taylor
ec17088ff6 Update inline docs for wp_handle_upload|sideload to reflect their non-use of extract(). 
See #22400.



git-svn-id: https://develop.svn.wordpress.org/trunk@28452 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-16 17:40:44 +00:00
Scott Taylor
8f8b12e6a6 Eliminate use of extract() in wp_handle_sideload(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28451 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-16 16:14:56 +00:00
Scott Taylor
176d361626 Eliminate use of extract() in wp_handle_upload(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28450 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-16 16:10:00 +00:00
Sergey Biryukov
6100833f0c DFW: Properly handle Esc key when the content is focused or when switching browser tabs. 
props avryl.
fixes #28279.

git-svn-id: https://develop.svn.wordpress.org/trunk@28443 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-16 10:42:03 +00:00
wonderboymusic
30dcd2c3e9 Eliminate the use of extract() in WP_Upgrader. 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28418 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 05:01:02 +00:00
Scott Taylor
650e0580e4 Eliminate one of the uses of extract() in wp_handle_upload(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28417 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 04:30:32 +00:00
Scott Taylor
219ad73200 Eliminate one of the uses of extract() in wp_handle_sideload(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28416 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 04:28:24 +00:00
Scott Taylor
c4b23f9fc3 Eliminate use of extract() in Walker_Category_Checklist::start_el(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28411 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 03:13:44 +00:00
Scott Taylor
85d6f8e54f Eliminate use of extract() in wp_terms_checklist(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28410 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 03:08:46 +00:00
Scott Taylor
98ca12ef2e Eliminate use of extract() in wp_star_rating(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28409 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 02:56:56 +00:00
Scott Taylor
5e046b92fd (REALLY) Eliminate use of extract() in wp_insert_link(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28408 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 02:54:27 +00:00
Scott Taylor
27ff2a1cd0 Eliminate use of extract() in get_media_item(). 
To test, fire open the old media in the console: `tb_show('Old Media is Weird', 'media-upload.php?type=image&TB_iframe=true&post_id=0');`	
	
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28407 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 02:45:01 +00:00
Scott Taylor
e0ddd2ebf0 Eliminate use of extract() in wp_insert_link(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28406 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 02:27:55 +00:00
Scott Taylor
46f15a84ab Eliminate use of extract() in display_setup_form(). Only needs to read password and password_message. 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28396 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-14 16:42:42 +00:00
Drew Jaynes (DrewAPicture)
cfc1b74ddb Properly split and document the admin_post* actions into the following four hooks: 
* `admin_post_nopriv` – for logged-out requests lacking a supplied action
* `admin_post_nopriv_$action – for logged-out requests with a supplied action
* `admin_post` – for logged-in requests lacking a supplied action
* `admin_post_$action` – for logged-in requests with a supplied action

See [28349], [28350], [28351].
See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28394 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 07:23:35 +00:00
Drew Jaynes (DrewAPicture)
1954f9b7d4 Clarify inline documentation for back-compat load-* action hooks. 
See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28393 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 06:27:11 +00:00
Scott Taylor
bc17731c23 Eliminate use of extract() in post_tags_meta_box() and post_categories_meta_box(). 
Both functions only need to read `taxonomy`, yet they extract every available variable from `$box['args']`. Even if those variables were useful, there is no attempt to pass them to anything, and scope in PHP does not allow them to be scooped up by inner functions without being passed directly.
	
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28391 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 05:47:03 +00:00
Scott Taylor
b72bd1c40f Eliminate use of extract() in WP_Terms_List_Table::display_rows_or_placeholder(): 
* Set variables for `$page` and `$number`
* `list(...) = $this->get_column_info()` can be removed, as none of the variables returned are used.
* `orderby` and `search` can be checked from `$args`, leaving no reason to extract		

See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28390 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 05:36:22 +00:00
Scott Taylor
7c0e12f5c6 Eliminate use of extract() in WP_List_Table::pagination(): 
* Set variables instead of extracting `$this->_pagination_args`
* Weird: `$infinite_scroll` is only presently set in subclasses of `WP_List_Table` and never initialized otherwise. 		

See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28389 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 05:26:34 +00:00
Scott Taylor
31e187faa3 Eliminate use of extract() in WP_Plugin_Install_List_Table::get_table_classes(). It only needs to read plural, no need to extract. 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28388 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 05:16:39 +00:00
Scott Taylor
fac2faee93 Eliminate use of extract() in WP_List_Table::ajax_response(): 
* Extracting `$this->_args` is unnecessary since none of the variables produced are present in the method.
* `total_items` and `total_pages` can be read directly from `$this->_pagination_args`

See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28387 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 05:13:09 +00:00
Scott Taylor
a2122e6f7b Eliminate use of extract() in WP_List_Table::display(). The method only needs to read singular from $this->_args. Extraction is unnecessary. 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28386 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 05:07:11 +00:00
Scott Taylor
878a974477 Eliminate use of extract() in WP_Post_Comments_List_Table::display(). The method only needs to read singular from $this->_args. Extraction is unnecessary. 
Eliminate use of `extract()` in `WP_Comments_List_Table::display()`. The method uses no variables. Extraction can be completely removed.

See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28385 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 05:03:26 +00:00
Scott Taylor
f57bdbd238 Eliminate use of extract() in Custom_Image_Header::step_2(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28384 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 04:53:13 +00:00
Drew Jaynes (DrewAPicture)
68f78b1dcc Clarify documentation for *what* gets "automatically fired" when the do_mu_upgrade filter evaluates to true in Multisite. 
See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28376 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 04:17:16 +00:00
Drew Jaynes (DrewAPicture)
d59c371180 Fix incomplete inline documentation for the wp_header_image_attachment_metadata filter. 
See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28375 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 04:12:02 +00:00
Scott Taylor
4e0809e3e4 Eliminate use of extract() in wp_insert_category(). Adds unit tests. All unit tests pass. 
Props MikeHansenMe.
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28374 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 03:26:51 +00:00