Commit Graph

33101 Commits

Author SHA1 Message Date
Konstantin Obenland
498fbb407c Menus: Bring back line break between menu items.
While removing line breaks was great for all use cases except justified menu
items, it broke menus with justified menu items.
Reverts [34321].

Props wp-architect.
Fixes #35107.



git-svn-id: https://develop.svn.wordpress.org/trunk@36081 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-24 00:20:24 +00:00
Konstantin Obenland
1d68393907 Taxonomy: Pass object ids to delete_* actions.
Allows for more targeted updates to affected posts in callbacks.
Disambiguates `$objects` variable and amends unit tests.

Fixes #35213.


git-svn-id: https://develop.svn.wordpress.org/trunk@36080 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-23 23:43:03 +00:00
Boone Gorges
9c2d3a7a4d Improve post-filter sanitization of excluded terms in get_adjacent_post().
See [36078], #35211.

git-svn-id: https://develop.svn.wordpress.org/trunk@36079 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-23 20:14:12 +00:00
Boone Gorges
fff6412f91 Move excluded_terms filter in get_adjacent_post().
The filter was added in 4.4 [34528] #9571, but in a place where it could not
affect the adjacent post query.

Fixes #35211.

git-svn-id: https://develop.svn.wordpress.org/trunk@36078 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-23 19:56:32 +00:00
Boone Gorges
7d03711fc8 Move get_adjacent_post() tests to their own file.
See #35211.


git-svn-id: https://develop.svn.wordpress.org/trunk@36077 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-23 19:38:29 +00:00
Boone Gorges
d7fccb6c01 Respect $_wp_suspend_cache_invalidation in clean_object_term_cache().
Props mwidmann.
Fixes #35208.

git-svn-id: https://develop.svn.wordpress.org/trunk@36076 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-23 19:28:06 +00:00
Sergey Biryukov
6bc8f2e24c Twenty Fifteen: Add left margin for lists inside blockquotes in editor-style.css.
Props diddledan.
Fixes #33380.

git-svn-id: https://develop.svn.wordpress.org/trunk@36075 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-23 13:09:38 +00:00
John Blackbourn
858cf7d215 Docs: Miscellaneous docblock code quality tweaks.
See #32246


git-svn-id: https://develop.svn.wordpress.org/trunk@36074 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-23 07:52:04 +00:00
johnbillion
ec46b01201 Docs: @see != @since.
See #32246


git-svn-id: https://develop.svn.wordpress.org/trunk@36073 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-23 07:12:02 +00:00
Drew Jaynes
857de6f1ba Docs: Properly mark the optional $redirect, $network_wide, and $silent parameters as such in the DocBlock for activate_plugin().
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36072 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-23 06:59:47 +00:00
Drew Jaynes
d4ea8d9f62 Docs: Add missing @since and properly mark the optional $type parameter as such in the DocBlock for the deprecated get_others_unpublished_posts() function.
Introduced in [5707].

See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36071 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-23 06:57:12 +00:00
Drew Jaynes
b489587419 Docs: Properly mark the $exclude_zeros parameter in the DocBlock for get_editable_user_ids() as optional.
Also fixes a couple of typos.

See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36070 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-23 06:52:15 +00:00
John Blackbourn
a6556195d8 Docs: Miscellaneous docblock corrections.
See #32246


git-svn-id: https://develop.svn.wordpress.org/trunk@36069 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-23 06:30:09 +00:00
Dion Hulse
ec7fa69ef4 Users: When determining whether to show the reassign content option during user delete, don't rely upon WP_Query as it doesn't return all forms of content wp_delete_user() operates on.
This restores the reassign form when a user has a non-public post type or links assigned to them.

Props swissspidy & tharsheblows for initial patches.
Fixes #34993 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@36068 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-23 04:45:42 +00:00
Andrew Ozz
83f93e5e70 Editor: remove the format_for_editor filter from the_editor_content after it runs as the next editor instance on the same page may not need it.
Props marcochiesi, azaozz.
Fixes #28403.

git-svn-id: https://develop.svn.wordpress.org/trunk@36062 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-22 22:39:01 +00:00
John Blackbourn
5ce7879548 Revert [35804]. This change has unintended side effects, notably that media URLs in the admin area now unexpectedly use the https scheme. A more comprehensive approach will be taken in 4.5.
See #13941, #35120


git-svn-id: https://develop.svn.wordpress.org/trunk@36061 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-22 13:01:31 +00:00
Gary Pendergast
0b9d32a614 Embeds: Don't show embed discovery link on a static front page.
There's currently no iframe content being generated for a static front page. Giving out a link to that isn't an ideal user experience.

Props peterwilsoncc.

Fixes #35194 for trunk.



git-svn-id: https://develop.svn.wordpress.org/trunk@36059 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-22 10:49:20 +00:00
Boone Gorges
1bf73525e8 Order terms by 'name' when populating object term cache.
[34217] removed the `ORDER BY` clause from `update_object_term_cache()`, for
improved performance. But this proved to cause problems in cases where users
were expecting the results of `get_the_terms()` to be ordered by 'name'. Let's
revert the change for the time being, and look into more disciplined ordering
in a future release.

Props afercia.
See #28922. Fixes #35180.

git-svn-id: https://develop.svn.wordpress.org/trunk@36056 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-22 01:50:08 +00:00
Gary Pendergast
d303221d08 Tests: Use the default_storage_engine MySQL option on newer MySQL versions.
In MySQL 5.5.3, `storage_engine` was deprecated in favour of `default_storage_engine`, and subsequently removed in MySQL 5.7. To avoid errors when running tests on MySQL 5.7, we need to switch between the options based on MySQL version.

Props skithund, jeremyfelt.

Fixes #34692.



git-svn-id: https://develop.svn.wordpress.org/trunk@36055 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-21 22:26:52 +00:00
Drew Jaynes
688916d200 Docs: Fix a typo in the 4.4.0 changlog entry in the intermediate_image_sizes_advanced hook doc.
Props morganestes.
Fixes #35190.


git-svn-id: https://develop.svn.wordpress.org/trunk@36054 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-21 22:23:11 +00:00
Andrea Fercia
9c8c6955a9 Accessibility: Remove the revisions limit title attribute from the Publish box.
The revisions limit warning is now always displayed in plain text even when the
limit is not reached yet. Removes the plus "+" from the revisions count number.

Fixes #35029.

git-svn-id: https://develop.svn.wordpress.org/trunk@36053 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-21 14:38:32 +00:00
John Blackbourn
ec143694f7 Tests: Prevent role capability pollution in Tests_Post_GetPostsByAuthorSql::test_user_has_access_only_to_private_posts_for_certain_post_types().
git-svn-id: https://develop.svn.wordpress.org/trunk@36050 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-21 07:15:33 +00:00
John Blackbourn
b637e77c5a Tests: Fix all the things.
See #30017, #32394


git-svn-id: https://develop.svn.wordpress.org/trunk@36049 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-21 07:09:43 +00:00
johnbillion
8b5747a108 Query: Re-initialise any dynamically-added public query vars before running the public query vars test.
See #35115


git-svn-id: https://develop.svn.wordpress.org/trunk@36048 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-21 06:59:05 +00:00
John Blackbourn
8567d80ade Tests: Shave a second off the user capability tests by reusing its user fixtures.
See #30017, #32394


git-svn-id: https://develop.svn.wordpress.org/trunk@36047 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-21 06:56:57 +00:00
John Blackbourn
da84910c8a Query: Introduce a unit test which will fail when new public query vars are introduced without also updating the test. This adds an extra layer of explicitness to introducing public query vars in order to avoid introducing unintentional clashes with URL query vars that are already in use.
See #35115 


git-svn-id: https://develop.svn.wordpress.org/trunk@36045 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-21 05:48:24 +00:00
John Blackbourn
da011967e7 Login: Revert [34213] and [35897]. It has become apparent that there is a need for a separate function (and corresponding filter) which allows for the login form action URL to differ from the URL used to access the login form, so that plugins or implementations which change the login URL do not need to worry about handling the form submission at the same URL.
For now, we'll revert to the pre-4.4 behaviour of hard-coding the login form action URL as `wp-login.php` and look at implementing a separate function and corresponding filter in 4.5.

Props KrissieV, salcode, JPry
Fixes #34925
See #35103


git-svn-id: https://develop.svn.wordpress.org/trunk@36042 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-21 03:22:32 +00:00
Boone Gorges
817013978d Respect approval status when determining comment page count in comments_template().
Since 4.4, when fetching the first page of comments and the 'newest' comments
are set to display first, `comments_template()` must perform arithmetic to
determine which comments to show. See #8071. This arithmetic requires the
total comment count for the current post, which is calculated with a separate
`WP_Comment_Query`. This secondary comment query did not properly account for
non-approved comment statuses; all unapproved comments should be part of the
comment count for admins, and individual users should have their own
unapproved comments included in the count. As a result, `comments_template()`
was, in some cases, being fooled into thinking that a post had fewer comments
available for pagination than it actually had, which resulted in empty pages
of comments.

We correct this problem by mirroring 'status' and 'include_unapproved' params
of the main comment query within the secondary query used to calculate
pagination.

Fixes #35068.

git-svn-id: https://develop.svn.wordpress.org/trunk@36040 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-21 03:06:41 +00:00
John Blackbourn
4024cb673a Comments: When a comment is submitted, ensure the user_ID element in the array that's passed to the preprocess_comment filter gets populated.
Fixes #34997


git-svn-id: https://develop.svn.wordpress.org/trunk@36038 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-21 02:46:44 +00:00
Gary Pendergast
59b8f0da7c Texturize: Transform & into & in tag attributes.
[35709] was overly broad, and stopped transforming `&` characters within tag attributes. So that sites aren't generating invalid HTML, we need to restore this functionality, while continuing to not transform `&` within blocked tags.

Fixes #35008 for trunk.



git-svn-id: https://develop.svn.wordpress.org/trunk@36036 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-21 02:42:30 +00:00
Gary Pendergast
d6bf586de3 Query: Remove title from the public query vars list.
[33706] added `title` as a public query var, but there's not really a practical need for this, and it interferes with any plugin that uses `title` as a query var for itself.

Props tyxla.

Fixes #35115 for trunk.



git-svn-id: https://develop.svn.wordpress.org/trunk@36034 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-21 00:42:43 +00:00
Drew Jaynes
2213bfba0c Docs: Add missing notations for the optional $tab_index and $extended parameters in the DocBlock for the deprecated the_editor() function.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36033 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-20 21:20:14 +00:00
Andrea Fercia
c8c1014a01 Accessibility: Remove title attributes from the updates links on the Plugin and Themes list tables.
Adds `aria-label` attributes on some links and on the "update nag" link. Adds translator comments.

Fixes #35167.

git-svn-id: https://develop.svn.wordpress.org/trunk@36032 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-20 16:08:38 +00:00
Andrew Ozz
58b7d3e136 Responsive images: fix calculations when determining whether to include particular image file in srcset.
Props joemcgill.
Fixes #34955 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@36031 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-20 02:38:34 +00:00
Drew Jaynes
c593ceb5e8 Docs: Add missing parameter and return notations to the DocBlock for the deprecated get_usernumposts() function.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36030 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-19 19:40:28 +00:00
Eric Andrew Lewis
07c62c3c5f Docs: Add documentation to wp-blog-header.php.
Fixes #35161.


git-svn-id: https://develop.svn.wordpress.org/trunk@36029 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-19 11:19:57 +00:00
Drew Jaynes
6e8b83cb65 Docs: Add missing parameter and return notations in the DocBlock for get_profile().
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36028 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-19 09:03:11 +00:00
Drew Jaynes
44fc67cc24 Docs: Properly mark the $classname parameter as optional.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36027 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-19 08:59:49 +00:00
Drew Jaynes
bb8067b666 Docs: Add missing parameter and return notations to the DocBlock for the deprecated wp_specialchars() function.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36026 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-19 08:57:49 +00:00
Drew Jaynes
a052a682a1 Docs: Add missing parameter notations and descriptions in the DocBlock for get_link().
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36025 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-19 08:53:55 +00:00
Drew Jaynes
e2be10ec2c Docs: Add missing parameter and return notations in the DocBlock for the deprecated _nc() function.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36024 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-19 08:47:12 +00:00
Drew Jaynes
62e657a2f0 Docs: Add a missing summary, parameter, and return descriptiosn to the DocBlock for the deprecated function, get_linkrating().
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36023 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-19 08:23:00 +00:00
Drew Jaynes
a2f5cdb5bb Docs: Add a missing notation for the $gmt_time parameter in the DocBlock for spawn_cron().
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36022 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-19 08:19:54 +00:00
Drew Jaynes
f8119eef50 Docs: Add missing DocBlocks for hash_hmac() and _hash_hmac().
Both will be ignored from parsing as and serve as compat functions for PHP's `hash_hmac()`.

Introduced in [18111].

See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36021 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-19 05:10:29 +00:00
Drew Jaynes
64592f8c0b Docs: Fix inline comment syntax in _mb_strlen(), an internal compat method for mb_strlen().
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36020 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-19 04:58:59 +00:00
Drew Jaynes
df9291938c Docs: Add missing DocBlocks for mb_strlen() and _mb_strlen().
Both will be ignored from parsing as and serve as compat functions for PHP's `mb_strlen()`, which is not enabled by default.

Introduced in [32114].

See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36019 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-19 04:55:50 +00:00
Drew Jaynes
73b701b030 Docs: Fix inline comment syntax in _mb_substr(), an internal compat method for mb_substr().
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36018 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-19 04:49:42 +00:00
Drew Jaynes
c848b5f670 Docs: Add missing DocBlocks for mb_substr() and _mb_substr().
Both will be ignored from parsing as and serve as compat functions for PHP's `mb_substr()`, which is not enabled by default.

Introduced in [17621].

See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36017 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-19 04:46:43 +00:00
Andrea Fercia
c69509b2ab Accessibility: Remove title attributes and improve accessibility on the "no-js" Menus screen.
When JavaScript is off, the reorder menu item and Edit menu item links now use `aria-label`
attributes instead of title attributes.

Fixes #35134.

git-svn-id: https://develop.svn.wordpress.org/trunk@36016 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-19 00:16:30 +00:00
Andrea Fercia
6295e19072 Accessibility: Remove title attributes from the Theme browser.
Also, adds translators comments and removes a no more used variable, see [27748].

Fixes #35140.

git-svn-id: https://develop.svn.wordpress.org/trunk@36015 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-18 23:59:07 +00:00