Commit Graph

41177 Commits

Author SHA1 Message Date
K. Adam White
4e18f78ced REST API: Fix namespace shadowing issue in route matching logic.
Following [47260] a namespace such as "test-ns" prevents any namespace such as "test-ns/v1" from being found when matching routes.
While not best practice, this was an unintentional back-compat break; this patch restores the original behavior.

Props david.binda, TimothyBlynJacobs.
Fixes #48530.



git-svn-id: https://develop.svn.wordpress.org/trunk@47351 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-24 18:05:12 +00:00
Sergey Biryukov
74baee2f19 Menus: Introduce wp_nav_menu_item_custom_fields_customize_template action that fires at the end of the form field template for nav menu items in the customizer.
This brings parity with the `wp_nav_menu_item_custom_fields` action added in [47190] for the Menus screen.

Props celloexpressions.
Fixes #47056.

git-svn-id: https://develop.svn.wordpress.org/trunk@47350 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-24 14:56:42 +00:00
Sergey Biryukov
c2316edc3a Coding Standards: Add missing braces to if conditions and use strict comparison in js/_enqueues/wp/media/editor.js.
Props ankitmaru.
Fixes #49317.

git-svn-id: https://develop.svn.wordpress.org/trunk@47349 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-23 08:56:44 +00:00
Sergey Biryukov
dd859e48f2 Built/Test Tools: Ignore the node_modules folder in Twenty Nineteen when running grunt jshint:themes.
Follow-up to [45060], [46352], [46450].

Fixes #49494. See #46706.

git-svn-id: https://develop.svn.wordpress.org/trunk@47348 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-23 08:26:15 +00:00
Sergey Biryukov
2f10289ffb Docs: Use third-person singular verbs for function descriptions in wp-includes/option.php, per the documentation standards.
See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@47347 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-23 01:05:28 +00:00
Sergey Biryukov
84764d4cee Docs: Add a @staticvar entry for $transports in WP_Http::_dispatch_request().
Props utsav72640.
Fixes #48774.

git-svn-id: https://develop.svn.wordpress.org/trunk@47346 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-22 19:10:47 +00:00
Sergey Biryukov
af57dcb03e I18N: Replace .htaccess with placeholders in the strings for Site Health custom rules check.
Props ramiy.
Fixes #48864.

git-svn-id: https://develop.svn.wordpress.org/trunk@47345 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-22 18:54:09 +00:00
Sergey Biryukov
74908c06bf I18N: Use a consistent wording for "Unable to write to file" strings.
Props ramiy.
Fixes #48862.

git-svn-id: https://develop.svn.wordpress.org/trunk@47344 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-22 18:31:39 +00:00
Jonathan Desrosiers
35ddd5c97d General: Introduce a pull request template.
This ensures that contributors opening a pull request on GitHub for code review have proper guidance.

See https://make.wordpress.org/core/2020/02/21/working-on-trac-tickets-using-github-pull-requests/ and https://meta.trac.wordpress.org/ticket/4903.

Props noisysocks, desrosj.
Fixes #49489.

git-svn-id: https://develop.svn.wordpress.org/trunk@47342 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-21 18:23:28 +00:00
Sergey Biryukov
8837ebd1f6 Build/Test Tools: Remove unused ::assertPostHasTerms() method from tests/term.php.
The associated test was removed in [30241].

See #49485.

git-svn-id: https://develop.svn.wordpress.org/trunk@47341 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-21 17:03:12 +00:00
Adam Silverstein
8793357dfa Comments: improve styling on mobile for comments marked as spam.
Correct an issue where comments marked as spam in a mobile view displayed incorrectly, filling a narrow and very tall column with the notice that a comment was marked as spam. 

Props jeremyfelt, lorenzof, mukesh27, razamalik, xkon.
Fixes #48814.



git-svn-id: https://develop.svn.wordpress.org/trunk@47340 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-21 17:02:18 +00:00
Ian Belanger
bb6b0cdaa5 Bundled Themes: Twenty Nineteen text color setting in pullquote block not applied.
Fixes the pullquote color setting by adding classes that are more specific to the color options.

Props ianbelanger.
Fixes #49410.

git-svn-id: https://develop.svn.wordpress.org/trunk@47339 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-21 14:57:12 +00:00
Sergey Biryukov
3ff0ef5030 I18N: Replace upload_max_filesize, php.ini, MAX_FILE_SIZE with placeholders in upload error strings.
Props ramiy.
Fixes #48869.

git-svn-id: https://develop.svn.wordpress.org/trunk@47330 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-20 17:16:21 +00:00
Timothy Jacobs
8a62f46beb REST API: Don't assume all item schemas have properties.
All schema types, not just objects, are permitted as the base type of a resource. A future patch could add validation support for those types, but this fix only prevents a PHP warning from being issued.

Props dhavalkasvala, johnwatkins0, birgire.
Fixes #48785.


git-svn-id: https://develop.svn.wordpress.org/trunk@47328 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-20 16:56:17 +00:00
Ian Belanger
6194b3c5d2 Bundled Themes: Twenty Nineteen Update margins in editor styles to address upcoming block editor margin changes.
Fixes the margins in the block editor to address recent changes in block margins.

Props Joen, SergeyBiryukov, kjellr, jffng, allancole.
Fixes #48526.

git-svn-id: https://develop.svn.wordpress.org/trunk@47327 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-20 16:38:38 +00:00
Timothy Jacobs
be371a7431 REST API: Fix links format in OPTIONS requests for non-variable routes.
Props nsundberg, johnwatkins0, birgire.
Fixes #49149.


git-svn-id: https://develop.svn.wordpress.org/trunk@47326 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-20 00:53:43 +00:00
Timothy Jacobs
727faabe98 REST API: Warn if registering array settings without an items schema.
The documentation for register_setting has also been clarified to include all of the supported types and the flexibility of the show_in_rest parameter.

Fixes #42875.
Props perrywagle, dshanske, kadamwhite.


git-svn-id: https://develop.svn.wordpress.org/trunk@47325 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-19 22:54:03 +00:00
Sergey Biryukov
5f26580730 Docs: Add missing quote to {@see 'comment_$old_status_to_$new_status'} hook reference in wp_transition_comment_status() DocBlock.
Props coffee2code.
Fixes #49474.

git-svn-id: https://develop.svn.wordpress.org/trunk@47324 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-19 13:43:16 +00:00
Sergey Biryukov
e4dda92bc5 Tests: Correct assertions in test_site_dates_are_gmt().
`assertSame()` doesn't have the `$delta` parameter, only `assertEquals()` does.

Follow-up to [47313].

See #40364.

git-svn-id: https://develop.svn.wordpress.org/trunk@47318 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-19 04:38:39 +00:00
Sergey Biryukov
2d73050eda Posts, Post Types: Discard tags_input parameter in wp_update_post() if it's the same as existing post tags.
This ensures that `wp_update_post()` does not unintentionally modify post tags if the post has several tags with the same name but different slugs.

Tags should only be modified if `tags_input` parameter was explicitly provided, and is different from the existing tags.

Props kaggdesign, SergeyBiryukov.
Fixes #45121.

git-svn-id: https://develop.svn.wordpress.org/trunk@47317 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-19 03:50:38 +00:00
Sergey Biryukov
8de22575cd Tests: Use delta comparison in test_site_dates_are_gmt() to avoid race conditions.
See #40364.

git-svn-id: https://develop.svn.wordpress.org/trunk@47313 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-19 02:41:53 +00:00
Sergey Biryukov
efde364e7c Build/Test Tools: Keep wp-config.php file in the build directory on rebuild, but still copy it over from src if it also exists there.
Follow-up to [47303].

Props afercia, isabel_brison, SergeyBiryukov.
Fixes #49460.

git-svn-id: https://develop.svn.wordpress.org/trunk@47312 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-19 01:48:15 +00:00
Sergey Biryukov
2213eb37c4 Tests: Remove an irrelevant tags_input property assertion from test_get_page_template_property().
This appears to be a copy/paste from the `test_get_tags_input_property()` test above.

See #45121.

git-svn-id: https://develop.svn.wordpress.org/trunk@47311 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-19 01:03:37 +00:00
Tammie Lister
6930542657 Bump version number to beta 2-47310
git-svn-id: https://develop.svn.wordpress.org/trunk@47310 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-18 21:27:31 +00:00
Tammie Lister
bc0847e8bd Bump version number to beta 2
git-svn-id: https://develop.svn.wordpress.org/trunk@47309 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-18 21:09:56 +00:00
Jonathan Desrosiers
9f87034879 Widgets: Revert [47307].
Even though the source URL for an attachment is stored in a variable, attachments should still be passed through the `wp_video_shortcode()` function.

Unprops desrosj, spacedmonkey.
See #46718.

git-svn-id: https://develop.svn.wordpress.org/trunk@47308 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-18 18:17:53 +00:00
Jonathan Desrosiers
0d7a5f949d Widgets: Remove unnecessary redundant conditional.
Props spacedmonkey.
Fixes #46718.

git-svn-id: https://develop.svn.wordpress.org/trunk@47307 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-18 17:50:54 +00:00
Jonathan Desrosiers
b797e91541 Site Health: Display the REST API test error codes correctly.
This change fixes an issue where the error codes associated with failed REST API tests are not being printed to the screen. In addition, the square brackets have been replaced with parentheses for consistency, and the error code (which is much less useful to end-users than the error message itself) has been moved to the end of the line.

This also clarifies the associated translator comments.

Props afercia, desrosj.
Fixes #49426.

git-svn-id: https://develop.svn.wordpress.org/trunk@47306 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-18 16:46:11 +00:00
Sergey Biryukov
6234fd90c2 Theme Editor: Disable CodeMirror CSS linting.
Being a good idea in theory, in practice it does not always work reliably, may not recognize newer CSS properties, and sometimes displays phantom errors with no particular error message.

A plugin can re-enable CSS linting via the `wp_code_editor_settings` filter.

Props skypressatx, ThemeZee, johnbillion, ianbelanger, ZanderZ, starvoters1, raoulunger, prashantvatsh, SergeyBiryukov.
Fixes #44471.

git-svn-id: https://develop.svn.wordpress.org/trunk@47305 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-18 15:49:08 +00:00
Andrea Fercia
5133f6b779 Accessibility: Improve readability by removing unnecessary italic font style.
Per Web Content Accessibility Guidelines 2.0, big chunks of italic text should be avoided.
Same applies to UI controls, since they're meant to be comfortably readable by the largest possible audience, e.g.: label elements.

Removes italic font style from:
- the Quick Edit / Bulk Edit forms
- the Recovery Mode plugin error details
- the Image Editor inline help

Props birgire, audrasjb, SergeyBiryukov, melchoyce, estelaris, sabernhardt, xkon, nrqsnchz, afercia.
See #47327.


git-svn-id: https://develop.svn.wordpress.org/trunk@47304 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-18 15:30:10 +00:00
Sergey Biryukov
82ddcbf707 Build/Test Tools: Keep wp-config.php file in the build directory on rebuild.
Props isabel_brison.
Fixes #49460.

git-svn-id: https://develop.svn.wordpress.org/trunk@47303 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-18 09:25:25 +00:00
Jorge Costa
bb110e3c0b Block Editor: Update WordPress Packages WordPress 5.4 beta 2.
The following package versions were changed:
@wordpress/block-directory: 1.5.0 -> 1.5.1
@wordpress/block-editor: 3.7.0 -> 3.7.1
@wordpress/block-library: 2.14.0 -> 2.14.1
@wordpress/components: 9.2.0 -> 9.2.1
@wordpress/edit-post: 3.13.0 -> 3.13.1
@wordpress/editor: 9.12.0 -> 9.12.1
@wordpress/format-library: 1.14.0 -> 1.14.1
@wordpress/list-reusable-blocks: 1.13.0 -> 1.13.1
@wordpress/media-utils: 1.7.0 -> 1.7.1
@wordpress/nux: 3.12.0 -> 3.12.1
@wordpress/server-side-render: 1.8.0 -> 1.8.1

Props gziolo, youknowriad, epiqueras, aduth.
Fixes #49458.

git-svn-id: https://develop.svn.wordpress.org/trunk@47302 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-17 23:00:07 +00:00
Jorge Costa
0ebe341284 Block Editor: Add missing package to the default export array.
Follow up on https://core.trac.wordpress.org/ticket/49358#comment:12.
We should add "warning" to the array of packages with default export to avoid the need for developers to use wp.warning.default.

Props gziolo, aduth.
Fixes #49436.

git-svn-id: https://develop.svn.wordpress.org/trunk@47301 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-17 12:30:54 +00:00
Sergey Biryukov
002bfea745 Site Health: Prevent the Site Health Status dashboard widget from loading on network admin screen for now.
Props Clorith, pbiron.
See #47606, #47085.

git-svn-id: https://develop.svn.wordpress.org/trunk@47300 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-17 09:58:00 +00:00
Sergey Biryukov
9ac7fca92b Users: Limit the scope of admin files required in WP_REST_Users_Controller.
This requires only `wp-admin/includes/user.php` for `get_editable_roles()`, instead of `wp-admin/includes/admin.php`.

Follow-up to [43589].

Props johnwatkins0.
Fixes #49450.

git-svn-id: https://develop.svn.wordpress.org/trunk@47299 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-17 05:31:18 +00:00
Sergey Biryukov
b8993b72bd Docs: Improve inline comments for require_once calls in WP_REST_Users_Controller per the documentation standards.
Follow-up to [47295].

See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@47298 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-17 03:54:11 +00:00
Sergey Biryukov
7d8b92ede9 Docs: Fix typo in a comment in WP_REST_Attachments_Controller::create_item().
See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@47297 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-17 03:28:05 +00:00
Sergey Biryukov
2d9f3a1330 REST API: Restore wp-admin/includes/image.php requirement in WP_REST_Attachments_Controller::create_item().
Although the file is already included via the `::insert_attachment()` method, this addresses an inconsistency and corrects a misleading comment.

It also reduces the possibility of a future error in case `::insert_attachment()` is no longer called earlier in `::create_item()` at some point.

Follow-up to [43850] and [44206].

Props luisrivera.
Fixes #49449.

git-svn-id: https://develop.svn.wordpress.org/trunk@47296 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-17 03:22:43 +00:00
Sergey Biryukov
f8d1664544 Docs: Improve inline comments for require_once() calls in WP_REST_Attachments_Controller.
See #49449, #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@47295 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-17 03:11:50 +00:00
Sergey Biryukov
96f845d1a7 Menus: Restore the title of the currently active/expanded menu item when clicking "Cancel" after editing.
Other inputs are already restored to their previous values in that case.

Props Girishpanchal, nilamacharya, JoshuaWold, welcher, SergeyBiryukov.
Fixes #43031.

git-svn-id: https://develop.svn.wordpress.org/trunk@47294 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-16 06:25:54 +00:00
Sergey Biryukov
0e52a4efc1 Themes: Correct the height of theme actions button container on various screen sizes.
Props aftabmuni, alexischenal, ideaboxcreations, audrasjb, SergeyBiryukov.
Fixes #49302.

git-svn-id: https://develop.svn.wordpress.org/trunk@47293 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-15 05:06:39 +00:00
Sergey Biryukov
45e02b9026 Widgets: Hide the "Align" legend in Image Widget display settings, since the associated controls are also hidden.
Props audrasjb, fotisps, marcelo2605.
Fixes #48931.

git-svn-id: https://develop.svn.wordpress.org/trunk@47292 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-15 02:48:28 +00:00
Sergey Biryukov
ae82bd40cc Administration: Allow wp_update_link() to update the link_owner field, for consistency with other link fields.
Props pbiron, valentinbora, nikhilgupte.
Fixes #41687.

git-svn-id: https://develop.svn.wordpress.org/trunk@47291 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-15 01:53:22 +00:00
Sergey Biryukov
1911d0db67 Administration: Correct alignment of form controls inside custom meta boxes.
Props audrasjb, dontdream, valentinbora.
Fixes #49013.

git-svn-id: https://develop.svn.wordpress.org/trunk@47289 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-14 00:50:42 +00:00
Sergey Biryukov
d4cc38581b Tests: Rename $d variable in some date/time tests to $format for clarity.
Follow-up to [47287].

See #49222.

git-svn-id: https://develop.svn.wordpress.org/trunk@47288 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-14 00:11:00 +00:00
Sergey Biryukov
543944257c Coding Standards: Rename $d parameter in various date/time functions to $format for clarity.
See #49222.

git-svn-id: https://develop.svn.wordpress.org/trunk@47287 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-14 00:05:43 +00:00
Sergey Biryukov
a41b2d93d3 Docs: Update @return tag for wp_allow_comment() with trash as a possible return value.
Props oakesjosh, jeremyfelt.
Fixes #49206.

git-svn-id: https://develop.svn.wordpress.org/trunk@47286 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-13 17:48:50 +00:00
Sergey Biryukov
3dd39ffece General: Update Michel Valdrighi's website in license.txt.
Props sebastienserre.
Fixes #49130.

git-svn-id: https://develop.svn.wordpress.org/trunk@47285 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-12 11:52:11 +00:00
Sergey Biryukov
58efcbdcd6 Privacy: Only show the Privacy Policy page notice when editing the page, not on drafts list.
Props chetan200891, xkon, garrett-eclipse.
Fixes #48431.

git-svn-id: https://develop.svn.wordpress.org/trunk@47284 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-12 11:42:23 +00:00
Sergey Biryukov
a6d078c228 Privacy: Improve the appearance of privacy request email inputs on mobile.
Props garrett-eclipse, xkon.
Fixes #48189.

git-svn-id: https://develop.svn.wordpress.org/trunk@47283 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-12 11:27:27 +00:00