Commit Graph

40189 Commits

Author SHA1 Message Date
Jonathan Desrosiers
53ec5e3fbf Correct the version number specified in [46102].
See #45361.

git-svn-id: https://develop.svn.wordpress.org/trunk@46104 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-13 18:54:06 +00:00
Adam Silverstein
96b4b1a70d Login and Registration: reset password - ensure submit button disabled when field empty.
Fix an issue where the submit button was enabled with an empty password when the user previously checked "Confirm use of weak password" for a weak password, then cleared the password field.

Props henry.wright.
Fixes #47924.



git-svn-id: https://develop.svn.wordpress.org/trunk@46103 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-13 18:29:29 +00:00
Jonathan Desrosiers
50a0d6c7a9 Menus: Nav menu locations should not be integers.
When nav menu location slugs are integers, some hard to debug results can occur. `register_nav_menus()` utilizes `array_merge()` which renumbers numeric indexes, starting from 0. Because of this, numeric menu locations will almost always be changed.

This change introduces a `_doing_it_wrong()` notice to inform developers that nav menu locations should always be strings.

Props audrasjb, desrosj, welcher.
Fixes #45361.

git-svn-id: https://develop.svn.wordpress.org/trunk@46102 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-13 17:57:57 +00:00
Sergey Biryukov
84f073cc52 REST API: Use correct parameter name in rest_validate_value_from_schema() error messages.
Props manzoorwanijk.
Fixes #47905.

git-svn-id: https://develop.svn.wordpress.org/trunk@46101 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-13 03:05:15 +00:00
Adam Silverstein
2b4cecf316 Multisite: improve sites_pre_query and networks_pre_query filters, avoiding db queries.
Improve the `pre_query` filters in multisite classes introduced in r44983. Return (non null) values immediately,
avoiding the database queries entirely, similar to other `pre_query` filters.

Props spacedmonkey, SergeyBiryukov, felipeelia.
Fixes #47599.



git-svn-id: https://develop.svn.wordpress.org/trunk@46100 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-12 22:16:08 +00:00
K. Adam White
b979a99355 REST API: Accept string path in rest_ensure_request.
Update `rest_ensure_request()` to accept a string path, permitting a string path to be passed to `rest_do_request()` as is indicated (previously inaccurately) in that method's PHPDoc.

Props TimothyBlynJacobs, kadamwhite.
Fixes #40614.


git-svn-id: https://develop.svn.wordpress.org/trunk@46099 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-12 21:46:41 +00:00
K. Adam White
ee69f54b8a REST API: Return term resources in "edit" context after PUT or POST request.
Props westonruter, dlh.
Fixes #41411.



git-svn-id: https://develop.svn.wordpress.org/trunk@46098 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-12 21:28:14 +00:00
Sergey Biryukov
1b7bba613d Mail: Update PHPMailer to 5.2.27.
The full list of changes is available here:
https://github.com/PHPMailer/PHPMailer/compare/v5.2.22...PHPMailer:v5.2.27

Props MattyRob, ayeshrajans, rogueresearch, bgermann, slaFFik, Presskopp, aaroncampbell.
Fixes #40472.

git-svn-id: https://develop.svn.wordpress.org/trunk@46097 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-12 14:36:42 +00:00
Sergey Biryukov
02e26b8f6d Text Changes: Correct "up-to-date" vs. "up to date" usage in a database update string and inline comments.
* "Up to date" is an adverb phrase that describes an action that brings something in line with the latest information.
* "Up-to-date" is an adjective phrase that is used as a synonym for "current".

Props socalchristina, hareesh-pillai, garrett-eclipse, desrosj, aprea.
Fixes #38998.

git-svn-id: https://develop.svn.wordpress.org/trunk@46096 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-12 13:05:35 +00:00
Sergey Biryukov
bc6f11decd External Libraries: Update jQuery Color plugin to 2.1.2.
Props desrosj, hareesh-pillai, lovememore.
Fixes #31511.

git-svn-id: https://develop.svn.wordpress.org/trunk@46095 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-12 12:40:38 +00:00
Sergey Biryukov
b5a53d7da7 HTTP: Update the Root Certificate bundle.
Keep 1024-bit legacy root certificates re-added in [35919], except for those already expired, for compatibility with older OpenSSL versions.

Props skithund, paragoninitiativeenterprises.
Fixes #45807.

git-svn-id: https://develop.svn.wordpress.org/trunk@46094 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-12 12:03:38 +00:00
Sergey Biryukov
6aade5b41c External Libraries: Revert [46092] pending test failure investigation.
See #45785.

git-svn-id: https://develop.svn.wordpress.org/trunk@46093 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-12 10:18:58 +00:00
Jonathan Desrosiers
0de88a64f1 External Libraries: Update Underscore to 1.9.1.
Changes: https://github.com/jashkenas/underscore/compare/1.8.3...1.9.1

Props mukesh27, hareesh-pillai.
Fixes #45785

git-svn-id: https://develop.svn.wordpress.org/trunk@46092 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-11 19:21:43 +00:00
Jonathan Desrosiers
bc052559e4 Editor: Add missing block data fields for blocks registered server side.
In [44122], the `styles` and `parent` block fields were omitted on accident. This change makes it possible to reuse them on the client.

Props gziolo.
Fixes #47017.

git-svn-id: https://develop.svn.wordpress.org/trunk@46091 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-11 14:51:30 +00:00
Sergey Biryukov
8005d291a3 Accessibility: Comments: In comment_form(), remove aria-describedby attribute from the email field if there's no associated description in the comment_notes_before argument.
The attribute is meant to communicate to user agents and assistive technologies that the element has a description. If the referenced description is missing, it will be flagged as failure by any automated accessibility checker tool and, most importantly, is potentially confusing for assistive technologies users.

Props afercia, joedolson, dinhtungdu, donmhico, SergeyBiryukov.
Fixes #47975.

git-svn-id: https://develop.svn.wordpress.org/trunk@46090 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-11 01:50:23 +00:00
Sergey Biryukov
26ae8b54d1 Coding Standards: Fix WPCS issue in [46088].
See #47110.

git-svn-id: https://develop.svn.wordpress.org/trunk@46089 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-10 20:00:36 +00:00
Sergey Biryukov
159c78c853 Docs: Fix placement of some duplicate hook references.
Hook documentation should be on the line directly above the line containing the `do_action()` or `apply_filters()` call. The CS auto-fixing, which changed some inconsistent function calls to multi-line function calls, is part of the reason why this was no longer the case for a select group of duplicate hook references.

Includes minor code layout fixes.

See #47110.

git-svn-id: https://develop.svn.wordpress.org/trunk@46088 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-10 19:22:07 +00:00
Sergey Biryukov
b3b64db570 Docs: Clarify the int return value in comments_pre_query filter DocBlock.
See #45800.

git-svn-id: https://develop.svn.wordpress.org/trunk@46087 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-10 19:03:04 +00:00
Adam Silverstein
4ba54c2104 Comments: add a new comments_pre_query filter to short circuit WP_Comment_Query 'get_comments' queries.
Return a non-null value to bypass WordPress's default comment queries.

Props felipeelia, spacedmonkey.
Fixes #45800.



git-svn-id: https://develop.svn.wordpress.org/trunk@46086 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-10 18:41:03 +00:00
Sergey Biryukov
23b6ca3bcb Accessibility: Media: Replace @ with at in the displayed date format.
The `@` symbol makes sense in the context of email addresses, but does not have a universal meaning in the context of dates.

Props audrasjb, afercia.
Fixes #47893.

git-svn-id: https://develop.svn.wordpress.org/trunk@46085 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-09 00:06:29 +00:00
Sergey Biryukov
8aa380cf54 Accessibility: Comments: Replace @ with at in the displayed date format.
The `@` symbol makes sense in the context of email addresses, but does not have a universal meaning in the context of dates.

Props birgire, afercia, audrasjb, SergeyBiryukov.
Fixes #47893.

git-svn-id: https://develop.svn.wordpress.org/trunk@46084 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-08 23:52:43 +00:00
Sergey Biryukov
acadc5cfdd Accessibility: Posts, Post Types: Replace @ with at in the displayed date format.
The `@` symbol makes sense in the context of email addresses, but does not have a universal meaning in the context of dates.

Props birgire, afercia, audrasjb, SergeyBiryukov.
Fixes #47832.

git-svn-id: https://develop.svn.wordpress.org/trunk@46083 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-08 23:23:26 +00:00
Sergey Biryukov
4bd76c15b5 Docs: Fix typo in WP_Hook::resort_active_iterations() description.
Props itowhid06.
Fixes #47999.

git-svn-id: https://develop.svn.wordpress.org/trunk@46082 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-08 13:15:19 +00:00
Andrew Ozz
275f9baeec Upload: Reset the temp upload reference in Plupload when the file is not an image.
See #47872.

git-svn-id: https://develop.svn.wordpress.org/trunk@46081 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-08 02:27:51 +00:00
Sergey Biryukov
d48d56e101 Posts, Post Types: Revert [46079] pending test failure investigation.
See #47824.

git-svn-id: https://develop.svn.wordpress.org/trunk@46080 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-07 19:32:42 +00:00
Sergey Biryukov
69054687be Posts, Post Types: Avoid a PHP warning when the_content() is called outside of the loop.
Fixes #47824.

git-svn-id: https://develop.svn.wordpress.org/trunk@46079 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-07 14:32:23 +00:00
Andrew Ozz
b545a56189 Fix "white spaces at end of line" in docblock (IDE) woes after [46077].
See #32437.

git-svn-id: https://develop.svn.wordpress.org/trunk@46078 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-07 02:11:50 +00:00
Andrew Ozz
ba033e4c6f Media: Improve handling of cases where an uploaded image matches exactly a defined intermediate size. In most of these cases the original image has been edited by the user and is "web ready", there is no need for an identical intermediate image.
Introduces the `wp_image_resize_identical_dimensions` filter so plugins and themes can determine whether a new image with identical dimensions should be created, defaults to false.

Props wpdennis, HKandulla, galbaras, azaozz.
See #32437.

git-svn-id: https://develop.svn.wordpress.org/trunk@46077 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-07 01:33:16 +00:00
Andrew Ozz
f6a89120ee Media: Add handling for "BIG" images. When the users upload a big image, typically a photo, scale it down to make it suitable for web use. Then use the scaled image as the "full" size, and keep the originally uploaded image for creating high quality sub-sizes in the future and in case the users want to download it later.
Introduces `wp_get_original_image_path()` that retrieves the path to the originally uploaded image in all cases, and `big_image_size_threshold` filter to set the pixel value above which images will be scaled. The same value is used as max-width and max-height when scaling.

See #47873.

git-svn-id: https://develop.svn.wordpress.org/trunk@46076 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-07 01:06:49 +00:00
Andrew Ozz
468629720c Uploads: Improve the error message shown when all attempts to create image sub-sizes fail.
Props afercia.
See #47872.

git-svn-id: https://develop.svn.wordpress.org/trunk@46075 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-06 23:47:05 +00:00
Jake Spurlock
e1665da922 Remove the extra call for wp-sanitize from the script loader.
Fixes #47986


git-svn-id: https://develop.svn.wordpress.org/trunk@46073 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-06 21:48:22 +00:00
Sergey Biryukov
c95616cb63 Upgrade/Install: Escape the % in width="100%" in a printf() call in Plugin_Upgrader_Skin::after().
Props afragen.
Fixes #47989.

git-svn-id: https://develop.svn.wordpress.org/trunk@46072 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-06 06:25:19 +00:00
Sergey Biryukov
8b17f6caee Docs: Improve documentation for do_meta_boxes action.
Props felipeelia, killua99, SergeyBiryukov.
Fixes #46542.

git-svn-id: https://develop.svn.wordpress.org/trunk@46071 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-06 00:05:10 +00:00
Sergey Biryukov
419bb36595 REST API: Mark WP_REST_Users_Controller::update_current_item() and ::delete_current_item() as public.
Props dkarfa.
Fixes #47967.

git-svn-id: https://develop.svn.wordpress.org/trunk@46070 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-05 23:17:19 +00:00
Sergey Biryukov
800b8cf5ec Docs: Remove extra spaces in various REST API DocBlocks.
See #47110.

git-svn-id: https://develop.svn.wordpress.org/trunk@46069 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-05 23:04:05 +00:00
Sergey Biryukov
32086d74fc Docs: Correct DocBlocks for WP_REST_Posts_Controller::get_available_actions() and WP_REST_Revisions_Controller::get_parent().
Props dkarfa.
Fixes #47966.

git-svn-id: https://develop.svn.wordpress.org/trunk@46068 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-05 22:58:50 +00:00
Andrew Ozz
58dd5e793f Fix (unrelated) test after [46066].
See #43524.

git-svn-id: https://develop.svn.wordpress.org/trunk@46067 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-05 22:52:29 +00:00
Andrew Ozz
a38ecee8c9 Media: Add two new intermediate image sizes, 1536px and 2048px. They are meant to enhance the way WordPress displays images on the front-end on larger, high-density devices. They make it possible to generate more suitable srcset and sizes attributes, and not use the original, often non-optimized image.
Also change the default `max_srcset_image_width` value to match the new max size.

Props pierlo, azaozz.
See #43524.

git-svn-id: https://develop.svn.wordpress.org/trunk@46066 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-05 22:26:50 +00:00
Andrea Fercia
a211ce8f99 Widgets: Fix "jumpiness" when reordering widgets by dragging them.
Props ketanumretiya030, mukesh27, andraganescu, audrasjb.
Fixes #46941.


git-svn-id: https://develop.svn.wordpress.org/trunk@46028 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-04 19:32:07 +00:00
Sergey Biryukov
bd299597d5 Coding Standards: Fix WPCS issue in [45990].
git-svn-id: https://develop.svn.wordpress.org/trunk@46019 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-04 18:40:13 +00:00
Jonathan Desrosiers
cda102f72f Fix for URL sanitization that can lead to cross-site scripting (XSS) attacks.
Props irsdl, sstoqnov, whyisjake.

git-svn-id: https://develop.svn.wordpress.org/trunk@45997 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-04 17:51:33 +00:00
Sergey Biryukov
b91c405069 Improve handling the existing rel attribute in wp_rel_nofollow_callback().
Props xknown, sstoqnov.

git-svn-id: https://develop.svn.wordpress.org/trunk@45990 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-04 17:36:46 +00:00
Jake Spurlock
c957e2573e Update wp.a11y.speak() to sanitize HTML before display.
Props iandunn, adamsilverstein, sstoqnov, peterwilsoncc


git-svn-id: https://develop.svn.wordpress.org/trunk@45979 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-04 17:11:22 +00:00
Sergey Biryukov
8552a9af15 Improve URL validation in wp_validate_redirect().
Props vortfu, whyisjake, peterwilsoncc.

git-svn-id: https://develop.svn.wordpress.org/trunk@45971 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-04 16:56:33 +00:00
Andrea Fercia
a1fd37e413 Bundled Theme: Twenty Nineteen: Use human-friendly color names.
For better accessibility, the Primary and Secondary theme colors have now more understandable names.
Changes the names "Primary" and "Secondary" to "Blue" and "Dark Blue". Fallbacks to the `hex` color codes when the theme is set to use a custom Primary color.

Props kjellr, aduth, audrasjb.
Fixes #46698.


git-svn-id: https://develop.svn.wordpress.org/trunk@45964 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-04 16:45:58 +00:00
Andrea Fercia
8aab6352f2 Bundled Theme: Twenty Nineteen: Fix the nesting of the main element.
The `main` element must not appear as a descendant of the `section` element. Correct markup is the first requirement to make user agents and assistive technologies work properly.

Changes the `<section>` element that was wrapping the `<main>` element to a `<div>`.

Props albertomake, ryelle, desrosj, ianbelanger, audrasjb.
Fixes #47066.


git-svn-id: https://develop.svn.wordpress.org/trunk@45942 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-04 16:26:50 +00:00
Sergey Biryukov
a04e391085 Escape the output in wp_ajax_upload_attachment().
Props whyisjake, sstoqnov.

git-svn-id: https://develop.svn.wordpress.org/trunk@45936 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-04 16:08:03 +00:00
Jake Spurlock
7f033deee5 Remove _convert_urlencoded_to_entities() from the get_the_content() callback.
Props vortfu, whyisjake, peterwilsoncc


git-svn-id: https://develop.svn.wordpress.org/trunk@45935 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-04 16:03:56 +00:00
Andrew Ozz
759ee944c6 Uploads: After an image is uploaded and PHP times out or runs out of memory during post-processing (the server response is HTTP 500 error), try to resize it three more times. Then, if all attempts fail, do a cleanup of any sub-sizes that may have been created and show an error message asking the user to scale the image and upload it again.
See #47872.

git-svn-id: https://develop.svn.wordpress.org/trunk@45934 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-04 01:10:57 +00:00
Sergey Biryukov
29ad3071a3 I18N: Fix typo in a function name in [45932].
See #44360.

git-svn-id: https://develop.svn.wordpress.org/trunk@45933 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-03 00:56:42 +00:00