Commit Graph

30163 Commits

Author SHA1 Message Date
Dominik Schilling (ocean90) 5f9ef8fed3 Customizer: Improve handling of posts with no title.
Use the `#%d (no title)` string as a fallback which is already used on the nav menus screen.
Add a translator comment to all occurrences of the `#%d (no title)` string.

see #32576.

git-svn-id: https://develop.svn.wordpress.org/trunk@32892 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-20 19:49:43 +00:00
Dominik Schilling (ocean90) 724b22938e Customizer: Accessibility improvements for menu item searches.
* Add a description and an `aria-describedby` attribute to inform users this is a "live" search.
* Announce the number of search results via `wp.a11y.speak`.
* Use `aria-busy` attribute to stop screen readers announcing content while the "loading more results" is running.
* Increase the search debounce wait interval to 500ms to be consistent with other live searches.
* If a search fails don't call `wp.a11y.speak` with an undefined variable.

props afercia.
see #32720.

git-svn-id: https://develop.svn.wordpress.org/trunk@32891 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-20 19:21:38 +00:00
Dominik Schilling (ocean90) 842347841e Customizer: Don't add a menu item twice when using the keyboard.
Buttons don't need keyboard events, they natively support keyboard interaction and they just need a click event.

fixes #32665.

git-svn-id: https://develop.svn.wordpress.org/trunk@32890 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-20 19:00:05 +00:00
Dominik Schilling (ocean90) 21d76509c4 Customizer: Use valid markup for menu items.
Replace `<d(l|t)>` with `<div>` for `.menu-item-bar` and `.menu-item-handle`.

see #32724, #32721, #31817.

git-svn-id: https://develop.svn.wordpress.org/trunk@32889 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-20 18:46:16 +00:00
Dominik Schilling (ocean90) 684d129a99 Customizer: Make labels of the menu item reorder buttons translatable.
see #32576.

git-svn-id: https://develop.svn.wordpress.org/trunk@32888 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-20 18:39:18 +00:00
Dominik Schilling (ocean90) d6127982be Customizer: Replace wrong usage of `_x()` with translator comments.
see #32576.

git-svn-id: https://develop.svn.wordpress.org/trunk@32887 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-20 18:32:04 +00:00
Dominik Schilling (ocean90) 52649618e2 Customizer: Rename label for custom links to "Custom Links", see [31748].
props paulwilde
fixes #32732.

git-svn-id: https://develop.svn.wordpress.org/trunk@32886 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-20 18:28:55 +00:00
Dominik Schilling (ocean90) 798ea970d3 Customizer: Decode HTML entities in the label property of `WP_Customize_Media_Control`.
fixes #31631.

git-svn-id: https://develop.svn.wordpress.org/trunk@32885 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-20 18:15:00 +00:00
Drew Jaynes 5b56ca5ab1 Update the DocBlock for `wp_insert_post()` to exclude now-defunct contact method arguments and clarify others.
Also clarifies information on available hooks and adds a changelog entry for when the contact method arguments were removed.

Props dlh, rachelbaker.
See #31588.


git-svn-id: https://develop.svn.wordpress.org/trunk@32884 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-20 02:52:47 +00:00
azaozz f366ccf053 Editor: add ARIA labels to the Quicktags buttons to improve accessibility.
Props afercia, azaozz. Fixes #31522.

git-svn-id: https://develop.svn.wordpress.org/trunk@32883 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-20 02:15:04 +00:00
Drew Jaynes 8dbc2ed36d Add a changelog entry to the DocBlock for `language_attributes()` noting that it was converted into a wrapper for `get_language_attributes()` in 4.3.
See [32868]. See #28180.


git-svn-id: https://develop.svn.wordpress.org/trunk@32882 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 23:00:21 +00:00
Scott Taylor 2231b5d1dc Correct inline doc for `$public` in `register_post_status()`.
Props ericlewis.
Fixes #32061.


git-svn-id: https://develop.svn.wordpress.org/trunk@32881 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 22:34:09 +00:00
Scott Taylor 33f416f35a Use `GPL-2.0+` for the value of `license` in `package.json`
Props netweb.
Fixes #32718.


git-svn-id: https://develop.svn.wordpress.org/trunk@32880 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 22:31:33 +00:00
Scott Taylor a968694338 Use valid markup in `Walker_Nav_Menu_Edit::start_el()` - replace `<d(l|t)>` with `<div>` for `.menu-item-bar` and `.menu-item-handle`.
Props sagarjadhav.
Fixes #31817.


git-svn-id: https://develop.svn.wordpress.org/trunk@32879 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 22:22:00 +00:00
Scott Taylor 8a7b906bee Add missing access modifiers in `class-wp-customize-setting.php`.
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32878 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 22:07:12 +00:00
Scott Taylor e3bf970f2a Add missing access modifier to `WP_Customize_Sidebar_Section::json()`.
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32877 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 22:05:08 +00:00
Scott Taylor 713a547aad Add missing access modifier to `WP_Customize_Nav_Menus_Panel::wp_nav_menu_manage_columns()`.
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32876 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 22:04:24 +00:00
Scott Taylor a38eefb475 Add missing access modifiers to `WP_Customize_Nav_Menus`.
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32875 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 22:03:13 +00:00
Scott Taylor 89328eb69f Customizer et al, use `elseif` in PHP, not `else if`.
This was corrected via brute force in [31090].

See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32874 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 22:00:33 +00:00
Scott Taylor fa99a8af6e Add access modifier to `WP_Customize_Nav_Menu_Item_Control::json()`
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32873 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 21:54:37 +00:00
Scott Taylor 47068b95f7 Add access modifier to `WP_Customize_Nav_Menu_Control::json()`
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32872 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 21:53:59 +00:00
Scott Taylor 6ffc540366 Add access modifier to `WP_Upgrader::clear_destination()`
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32871 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 21:52:44 +00:00
Scott Taylor 53a3137e1a Edit Post screen messages need to run preview URLs through the `preview_post_link` filter.
Props pareshradadiya.
Fixes #32191.


git-svn-id: https://develop.svn.wordpress.org/trunk@32870 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 21:48:11 +00:00
Scott Taylor c5f72c4ab7 Use `<button>` instead of `<a>` for non-link links in Quick Edit.
Props afercia.
Fixes #32213.


git-svn-id: https://develop.svn.wordpress.org/trunk@32869 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 21:41:07 +00:00
Scott Taylor a484b6a634 Add `get_language_attributes()`, which is then used by (...drum roll...) `language_attributes()`.
Props johnbillion, posykrat, PeterRKnight.
Fixes #28180.


git-svn-id: https://develop.svn.wordpress.org/trunk@32868 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 21:35:22 +00:00
Scott Taylor ee4e5c4b35 Check `is_callable()` in `do_shortcode_tag()`, not `add_shortcode()`.
Add a `_doing_it_wrong()` in `do_shortcode_tag()` when `is_callable()` is `false`.

Props aaroncampbell.
See #32445.


git-svn-id: https://develop.svn.wordpress.org/trunk@32867 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 21:32:31 +00:00
Scott Taylor 9123db3dcb Add a filter in `wp_get_attachment_image_src()` called `attachment_image_src`.
Props eclev91, MikeHansenMe.
Fixes #32363.


git-svn-id: https://develop.svn.wordpress.org/trunk@32866 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 21:26:30 +00:00
Scott Taylor bb292c74c1 Cleanup `(ms-)?admin-filters.php`
Props johnjamesjacoby.
Fixes #32529.


git-svn-id: https://develop.svn.wordpress.org/trunk@32865 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 21:17:20 +00:00
Scott Taylor 73fd2d1d81 Ugrade MediaElement to 2.17.0
Changelog: https://github.com/johndyer/mediaelement/compare/2.16.4...2.17.0

Fixes #32698.


git-svn-id: https://develop.svn.wordpress.org/trunk@32864 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 20:41:12 +00:00
Scott Taylor ed8b9a8d27 `wptexturize()` improvements:
* Make sure that strings ending with a number and quotation mark get the proper smart quotes
* Introduce `wptexturize_primes()`, a logic tree to determine whether or not "7'." represents seven feet, then converts the special char into either a prime char or a closing quote char.

Adds unit tests.

Props miqrogroove.
Fixes #29256.


git-svn-id: https://develop.svn.wordpress.org/trunk@32863 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 20:05:52 +00:00
Scott Taylor da826f59a5 Media Library `Bulk Select` button size should be smaller.
Props afercia.
Fixes #32325.


git-svn-id: https://develop.svn.wordpress.org/trunk@32862 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 18:55:52 +00:00
Scott Taylor 2da677b2f7 Improve focus when previewing an oEmbed from Add Media Panel
Props afercia.
Fixes #28820.


git-svn-id: https://develop.svn.wordpress.org/trunk@32861 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 18:48:06 +00:00
Scott Taylor a06f5f6d90 Don't strip `\0` (backslash+zero) from post content for users without "unfiltered_html"
Adds unit tests.

Props miqrogroove.
Fixes #28699.


git-svn-id: https://develop.svn.wordpress.org/trunk@32860 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 18:46:11 +00:00
Dominik Schilling (ocean90) bd272f3188 Customizer: Improve accessibility of the toggle button in the available menu items panel.
Prevents focus lost in Safari because the button was "invisible" until it got focused.

fixes #32709.

git-svn-id: https://develop.svn.wordpress.org/trunk@32859 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 17:23:46 +00:00
Konstantin Obenland 59a9592125 Remove allowed tags from comment form.
It can be confusing to users and for most it is not relevant.
Commenters comfortable with HTML will know which tags are likely
to be accepted.

Props krogsgard, rachelbaker.
Fixes #30157.



git-svn-id: https://develop.svn.wordpress.org/trunk@32858 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 14:14:41 +00:00
Konstantin Obenland 82a26045e5 Check that current changes can be lost before editing another comment.
When replying to or editing a comment, double-clicking another comment will
open it in quick edit and changes to the current comment are lost.

Props pareshradadiya, chriscct7.
Fixes #21845.



git-svn-id: https://develop.svn.wordpress.org/trunk@32857 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 13:47:35 +00:00
Ella Iseulde Van Dorpe fa5ec5077b Editor: restructure word count
* The WordCounter should only do one thing: count words. This makes it also easier to test.
* Add some really basic unit tests.
* Instead of only refreshing the count on enter and delete, refresh the count when the user stops typing. Also look at paste and content changes in TinyMCE.
* Use `match` instead of `replace` when it is appropriate.
* More readable code.

See #30966. Fixes #26620.



git-svn-id: https://develop.svn.wordpress.org/trunk@32856 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 10:34:59 +00:00
Konstantin Obenland bfb8734652 Keep `WP_Customize_Nav_Menus_Panel` with other panels rather than controls.
Accidentally merged into the wrong file in [32806].
H/t celloexpressions for noticing.

See https://wordpress.slack.com/archives/core-customize/p1434696254000258.
See #32576.



git-svn-id: https://develop.svn.wordpress.org/trunk@32855 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 08:36:37 +00:00
Dion Hulse 9c0750ac52 When updating plugins/themes verify that the files to be deleted can be modified before starting the deletion process.
This will avoid partially deleting an item during update which has inconsistent permissions.
This change only affects those using the direct & ssh transports as FTP's is_writable() currently always returns `true`.
Fixes #30921


git-svn-id: https://develop.svn.wordpress.org/trunk@32854 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 03:48:55 +00:00
Dion Hulse 4ff7f27c83 Remove a redundant index drop, it'll be dropped and re-created a few lines further down.
Fixes a warning during updating from 4.0 or earlier.
Fixes #31388 for trunk


git-svn-id: https://develop.svn.wordpress.org/trunk@32852 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 03:17:12 +00:00
Andrew Ozz 5cb9a4b019 Fix using `htmlspecialchars()` whit the `$double_encode` parameter. PHP < 5.4 doesn't validate the entities.
Props miqrogroove. Fixes #17780.

git-svn-id: https://develop.svn.wordpress.org/trunk@32851 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 01:52:48 +00:00
Scott Taylor 4d8c4295f3 Since PHP 5.2.3, the `htmlspecialchars()` function has an optional `$double_encode` parameter, which we can now use. This will save us a few expensive kses/html decoding calls.
Adds unit tests.

Props miqrogroove.
Fixes #17780.


git-svn-id: https://develop.svn.wordpress.org/trunk@32850 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-18 21:59:10 +00:00
John Blackbourn b8180d3d14 Correct the docs for the `post_type_labels_{$post_type}` filter.
Fixes #32707
Props dlh


git-svn-id: https://develop.svn.wordpress.org/trunk@32849 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-18 21:32:53 +00:00
Dominik Schilling (ocean90) 413d24c47f Customizer: Improve accessibility of Add Menu Items button and its panel.
props afercia, ocean90.
fixes #32682.

git-svn-id: https://develop.svn.wordpress.org/trunk@32848 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-18 20:51:48 +00:00
Dominik Schilling (ocean90) ee24335ba5 Autoprefixer for [32844].
git-svn-id: https://develop.svn.wordpress.org/trunk@32847 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-18 20:48:52 +00:00
Aaron Jorbin 301988d967 Add singular.php to template hierarchy
Singular is the only template context conditional that lacks a corresponding template. This allows some themes to simplify.

Fixes #22314.
Props chipbennett.



git-svn-id: https://develop.svn.wordpress.org/trunk@32846 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-18 19:00:09 +00:00
Scott Taylor 646c19accf Make sure that all Gravatars are generated by `get_avatar()` or at least run through `apply_filters( 'get_avatar', $avatar )` for the sake of extensibility.
Props miqrogroove, GlennM, SergeyBiryukov.
Fixes #22650.


git-svn-id: https://develop.svn.wordpress.org/trunk@32845 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-18 18:35:04 +00:00
Konstantin Obenland 9bf79ed862 Semanticize Help and Screen Options toggle.
Links used as UI controls that are not real links but act as buttons, should be buttons.

Props afercia.
Fixes #32494.



git-svn-id: https://develop.svn.wordpress.org/trunk@32844 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-18 16:35:12 +00:00
Konstantin Obenland 2ae17175b2 Use https for Google API external libraries.
Google recommends it and users are more likely to have the https version cached in their browser already.

Props rommelxcastro.
Fixes #32552.



git-svn-id: https://develop.svn.wordpress.org/trunk@32843 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-18 15:50:42 +00:00
Konstantin Obenland 771509a452 Show the posts meta box by default in Appearance > Menus.
Lessens user confusion and the likelyhood of misusing custom links
to add menu items for posts.

Props bcole808.
Fixes #32440.



git-svn-id: https://develop.svn.wordpress.org/trunk@32842 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-18 15:03:29 +00:00