Commit Graph

28297 Commits

Author SHA1 Message Date
Jeremy Felt 6213bb9689 Split tests for `get_blog_id_from_url()`
Breaks the many assertions for `get_blog_id_from_url()` into individual tests.

See #30080


git-svn-id: https://develop.svn.wordpress.org/trunk@30719 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-03 05:51:33 +00:00
Andrew Ozz 9adaec183e Update the description of the Screen Options checkbox for turning editor-expand on/off to include DFW v2. Props kpdesign, fixes #30557.
git-svn-id: https://develop.svn.wordpress.org/trunk@30718 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-02 23:22:52 +00:00
Andrew Ozz f8a478af9d Update the DFW v2 pointer text. Props kpdesign, DrewAPicture, johnbillion. Fixes #30458.
git-svn-id: https://develop.svn.wordpress.org/trunk@30717 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-02 23:10:52 +00:00
Dominik Schilling (ocean90) abe2a7ae21 Customizer: Move private helper functions to `wp.customize.utils` so they can be unit tested.
Includes unit tests.

props ryankienstra, westonruter.
see #28709.

git-svn-id: https://develop.svn.wordpress.org/trunk@30716 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-02 22:55:48 +00:00
Jeremy Felt a23c468ac8 Split and improve multisite tests for upload quota
Break a single test with many assertions into many tests with single assertions.

In the process, provide separate and comprehensive tests for `upload_is_user_over_quota()`, `is_upload_space_available()`, and `get_space_allowed()`.

Also removes a check for `BLOGSUPLOADDIR`, a constant that never existed. New tests will need to be introduced to handle the ms-files group.

See #30080


git-svn-id: https://develop.svn.wordpress.org/trunk@30715 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-02 22:55:30 +00:00
Dominik Schilling (ocean90) 104b31ae54 Customizer: Add panel/section type as CSS class to the HTML container.
see #28709.

git-svn-id: https://develop.svn.wordpress.org/trunk@30714 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-02 22:15:33 +00:00
Dominik Schilling (ocean90) c0b15e6b6d Toolbar: Make Customize support classes work on narrow viewports too.
fixes #30571.

git-svn-id: https://develop.svn.wordpress.org/trunk@30713 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-02 22:00:48 +00:00
Dominik Schilling (ocean90) 5158511ceb Customizer: Enhance Background Image/Upload controls.
* Adopt the Header Image layout to the Background Image/Upload control.
* Remove templates for interactive audio/video previews. They haven't worked yet.
* Don't show a "Remove" button when the default value is set.
* Avoid calculating of container/placeholder heights which are unrelated to custom headers.

see #21483.

git-svn-id: https://develop.svn.wordpress.org/trunk@30712 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-02 21:54:42 +00:00
Andrew Ozz 36dd60705f Editor: hide the DFW v2 button when editor-expand is off. Fixes #30568.
git-svn-id: https://develop.svn.wordpress.org/trunk@30711 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-02 20:39:13 +00:00
Andrew Ozz 9dba6cd0a7 Editor, DFW v2: use a 2D transform to force repaint of the admin toolbar, only on `#wp-toolbar`. Fixes calculating the position of the right sidebar on fade-in and removes any performance and stacking implications.
Props joemcgill, see #30516.

git-svn-id: https://develop.svn.wordpress.org/trunk@30710 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-02 20:24:07 +00:00
Ian Stewart f026b91515 Twenty Fifteen: removing unused styles inherited from Twenty Fourteen.
Props iamtakashi, fixes #30572.



git-svn-id: https://develop.svn.wordpress.org/trunk@30709 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-02 16:04:11 +00:00
John Blackbourn def41c61ee Apply a no-op CSS transformation to the admin toolbar (among other elements) in order to trigger hardware acceleration when focus/DFW deactivates. This helps prevent rendering issues seen in browsers on Retina devices.
See #30516
Props joemcgill


git-svn-id: https://develop.svn.wordpress.org/trunk@30708 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-02 14:17:59 +00:00
John Blackbourn a4db31f9a4 Prevent scrolling beneath modals on mobile devices by removing overflow from `#wpwrap` when a modal is open.
Fixes #29909
Props avryl


git-svn-id: https://develop.svn.wordpress.org/trunk@30707 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-02 08:08:25 +00:00
John Blackbourn f6a51e7ff3 Don't fix the position of the admin toolbar submenus when the viewport is below 600px. This avoids them becoming detached from the admin toolbar when scrolling.
Fixes #29905
Props avryl


git-svn-id: https://develop.svn.wordpress.org/trunk@30706 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-02 06:48:24 +00:00
John Blackbourn 3f2827c5be Admin help text changes for the General Settings screen, post editing screen, network settings screen, and user editing screen.
Fixes #30547
Props kpdesign


git-svn-id: https://develop.svn.wordpress.org/trunk@30705 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-02 05:14:38 +00:00
Gary Pendergast 9528294613 Unit Tests: The `test_set_allowed_incompatible_sql_mode()` test tries to set the `NO_ZERO_DATE` sql mode, which was removed in MySQL 5.7. This causes the test to incorrectly fail when run against MySQL 5.7.
git-svn-id: https://develop.svn.wordpress.org/trunk@30704 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-02 05:11:49 +00:00
Drew Jaynes (DrewAPicture) 18f101b4bf Using let's properly in inline comments lets us move on to more pressing matters of inline documentation.
Props trepmal.
Fixes #30570.


git-svn-id: https://develop.svn.wordpress.org/trunk@30703 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-02 04:42:17 +00:00
John Blackbourn 5cda7d6aed Update the tests for `get_metadata()` to reflect the revert in r30701.
See #15030


git-svn-id: https://develop.svn.wordpress.org/trunk@30702 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-02 03:43:17 +00:00
John Blackbourn 294b608879 Revert r30115 which was a breaking change for code which interacts with the return value of `get_metadata()` when no meta key is specified.
See #15030


git-svn-id: https://develop.svn.wordpress.org/trunk@30701 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-02 03:34:13 +00:00
John Blackbourn b510780a53 Correct the width of the background vignette in the plugin info modal.
Fixes #28229


git-svn-id: https://develop.svn.wordpress.org/trunk@30700 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-02 03:19:00 +00:00
Gary Pendergast 34f8e4d433 WPDB: When looking up the character set for a table or column, make sure we send the table name to MySQL in the correct case, as MySQL can be configured with case sensitive table names.
Fixes #30538.


git-svn-id: https://develop.svn.wordpress.org/trunk@30699 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-02 02:59:36 +00:00
Helen Hou-Sandi 5539cf7511 Don't over-target buttons in the publish meta box.
This selector caused breakage for any custom buttons added.

props ericlewis.
fixes #30035.


git-svn-id: https://develop.svn.wordpress.org/trunk@30698 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-02 02:34:32 +00:00
John Blackbourn 16ec77cd70 Prevent the deletion of a theme while it has an active child theme.
Fixes #29580
Props karpstrucking, jesin


git-svn-id: https://develop.svn.wordpress.org/trunk@30697 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-02 02:20:14 +00:00
John Blackbourn 0216b01a69 Ensure the theme and plugin update checks are always in sync with the current theme and plugin versions before fetching cached update data. This change only triggers a request to the update API when necessary.
Fixes #13071
Props bswatson


git-svn-id: https://develop.svn.wordpress.org/trunk@30696 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-02 01:51:10 +00:00
Drew Jaynes (DrewAPicture) 205a43ed05 Correctly capitalize JavaScript throughout core docs.
Fixes #30569.


git-svn-id: https://develop.svn.wordpress.org/trunk@30695 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-02 00:30:59 +00:00
Andrew Ozz 4eb3c5960f TinyMCE: update the wpView toolbar to look the same as the new image toolbar.
Fixes #30561.

git-svn-id: https://develop.svn.wordpress.org/trunk@30694 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-02 00:25:15 +00:00
Andrew Ozz eb2f29f1c3 Editor DFW v2: do not fade out on using keyboard shortcuts in TinyMCE (Alt+Shift+letter).
Fixes #30539.

git-svn-id: https://develop.svn.wordpress.org/trunk@30693 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-01 22:52:46 +00:00
Ian Stewart 4a3bceaea9 Twenty Fifteen: correct stylesheet dependencies.
Props ocean90, fixes #30532.



git-svn-id: https://develop.svn.wordpress.org/trunk@30692 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-01 19:40:12 +00:00
Drew Jaynes (DrewAPicture) 2f64100369 Improve inline documentation for four methods in `WP_Widget`: `get_field_id()`, `display_callback()`, `update_callback()`, and `form_callback()`.
Props jazzs3quence for the initial patch.
See #30315.


git-svn-id: https://develop.svn.wordpress.org/trunk@30691 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-01 19:34:25 +00:00
Ian Stewart e8ac9b21df Twenty Fifteen: broader selection of avatars that should catch any plugins adding avatars that use the avatar class.
Props iamtakashi, fixes #30541.



git-svn-id: https://develop.svn.wordpress.org/trunk@30690 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-01 19:33:19 +00:00
Ian Stewart 4598e80675 Twenty Fifteen: correct list indentation inside blockquotes.
Props iamtakashi, fixes #30543.



git-svn-id: https://develop.svn.wordpress.org/trunk@30689 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-01 19:30:56 +00:00
Boone Gorges 50386cafd5 Use `assertEqualSetsWithIndex()` as appropriate in `get_terms()` tests.
See #30522.

git-svn-id: https://develop.svn.wordpress.org/trunk@30688 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-01 14:24:43 +00:00
Gary Pendergast 897b1645bb Unit Tests: The `assertEqualSets()` helper was returning true for some sets that were not equal. `assertEqualSets()` now behaves correctly, and the new `assertEqualSetsWithIndex()` helper also checks that the array indexes are the same.
Fixes #30522.


git-svn-id: https://develop.svn.wordpress.org/trunk@30687 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-01 05:01:29 +00:00
John Blackbourn fe4b0c7f14 Remove the sortable functionality from the selection editing toolbar at the bottom of the media manager.
Fixes #29934
See #24352
Props jessepollak


git-svn-id: https://develop.svn.wordpress.org/trunk@30686 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-01 04:17:53 +00:00
John Blackbourn d8dd2e4a77 Clarify the text for the 'Edit Selection' link when multiple media items are selected in the media manager.
Props adamsilverstein
See #24325


git-svn-id: https://develop.svn.wordpress.org/trunk@30685 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-01 04:14:06 +00:00
John Blackbourn cedecf8033 Allow brackets in a URL when it's sanitised for a redirect. Brackets are valid in query parameters.
Fixes #30308
Props voldemortensen


git-svn-id: https://develop.svn.wordpress.org/trunk@30684 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-01 03:20:13 +00:00
John Blackbourn b57c4ae165 Allow square brackets in a URL when it's sanitised for a redirect. Square brackets are valid in query parameters and IPv6 addresses.
Fixes #17052
Props voldemortensen


git-svn-id: https://develop.svn.wordpress.org/trunk@30683 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-01 03:15:24 +00:00
Scott Taylor 095bfabfa9 Improve various `@param` docs.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30682 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-01 02:16:36 +00:00
Scott Taylor 4d46475b3d Improve various `@param` docs for `src/wp-includes/*`.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30681 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-01 01:33:34 +00:00
Scott Taylor 8a4fa5662b Improve various `@param` docs for `src/wp-admin/*`.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30680 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-01 00:59:43 +00:00
Scott Taylor c0045bda84 Improve various `@param` docs for List Tables.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30679 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-01 00:32:19 +00:00
Scott Taylor 7a7bb0d6b4 Improve various `@param` docs for `src/wp-admin/includes/class-wp-filesystem-*.php`.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30678 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-01 00:12:05 +00:00
Gary Pendergast 6eebbc5750 WPDB: Before fetching results, make sure we have a valid result resource to fetch them from.
Fixes #27982.


git-svn-id: https://develop.svn.wordpress.org/trunk@30677 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-01 00:02:55 +00:00
Scott Taylor 5817aa262d Improve various `@param` docs for `src/wp-includes/class-wp-customize*.php`.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30676 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 23:32:31 +00:00
Andrew Ozz 45f4403dd0 TinyMCE: update to 4.1.7, changelog: https://github.com/tinymce/tinymce/blob/master/changelog.txt. Fixes #30560.
git-svn-id: https://develop.svn.wordpress.org/trunk@30675 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 23:27:23 +00:00
Scott Taylor 0632a3de68 Improve various `@param` docs.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30674 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 23:23:37 +00:00
Scott Taylor ee388b9852 Improve various `@param` docs.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30673 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 22:55:08 +00:00
Scott Taylor 6bb2a4ce36 Improve the `@param` docs for `src/includes/theme.php` and `src/includes/update.php`.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30672 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 22:43:27 +00:00
Scott Taylor 4de850c8ff Improve the `@param` docs for `src/wp-includes/post*.php`.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30671 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 22:37:00 +00:00
Andrew Ozz 3c558b7436 TinyMCE: update translatable strings, see #30560.
git-svn-id: https://develop.svn.wordpress.org/trunk@30670 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 22:26:56 +00:00