Scott Taylor
d1d5bcf036
* Add isset()
checks all over WP_User_Query::prepare_query()
and WP_User_Query::query()
. When a WP_User_Query
instance is constructed without passing args, no query vars are filled in, thus $qv
doesn't contain most of the expected indices.
...
* Suppress an undefined index notice in `tests/user/query.php`
Fixes #25292 .
See #25282 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25392 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 06:24:09 +00:00
Scott Taylor
c5c88eb85b
Add sanity checks to get_*_template()
functions to ensure that the return value of get_queried_object()
is compatible with the assumed context.
...
Fixes #25291 .
See #25282 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25386 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 05:31:14 +00:00
Scott Taylor
f9877147f6
Use reset()
to access the first element of an array, don't assume there is an item at index 0
.
...
See #25282 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25384 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 05:08:33 +00:00
Helen Hou-Sandi
f1ef5c0e23
Indicate that the fall-through in is_serialized()
is deliberate. fixes #24023 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25371 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 03:40:25 +00:00
Scott Taylor
d091e1d0b7
Avoid a notice by casting $args['rewrite']
to array()
before adding a slug
property and running array_merge()
.
...
Fixes #23668 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25351 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 17:17:00 +00:00
Dion Hulse
23d3b372d7
Fix the action that set_site_transient()
fires so as not to include the private option prefix. This brings set_site_transient() back in line with it's documented behaviour, and the behaviour of all other transient functions. Fixes #25213
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25350 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 08:45:43 +00:00
Dion Hulse
7ebad3db1c
Switch WP_HTTP over to using the mbstring.func_overload helper functions. This change moves the check from within the Streaming-handling function to wrap the individual request, this fixes it for both cURL and Streams and any future changes to the transports which use strlen() on binary data. See #25259 See #16057
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25348 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 08:12:24 +00:00
Dion Hulse
052d276215
Add a set of helpers to turn the behaviour of mbstring.func_overload off when needed. Fixes #25259
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25346 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 07:22:05 +00:00
Andrew Nacin
a1470e6161
Avoid error in ms-files.php after [25317].
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25344 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 04:48:43 +00:00
Andrew Nacin
adf6fab55b
Bump version in trunk.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25343 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 04:19:36 +00:00
Andrew Nacin
1848709736
SimplePie: Fix use of DOMElement as array.
...
props MikeSchinkel.
fixes #25274 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25342 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 04:01:44 +00:00
Andrew Nacin
760e9e02d1
Avoid string offset notices in [25319].
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25340 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 03:57:00 +00:00
Andrew Nacin
3b314a0adf
Improve clarity and speed of [25320].
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25338 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 03:22:09 +00:00
Andrew Nacin
cedb15724a
Bump TinyMCE version for [25132]. See #25131 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25337 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 02:43:12 +00:00
Scott Taylor
3ee8135baa
Don't call sanitize_title_with_dashes( $taxonomy )
in register_taxonomy()
unless $args['rewrite']['slug']
is empty.
...
Props SergeyBiryukov.
Fixes #23668 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25335 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 00:08:04 +00:00
Scott Taylor
0c0c81d81c
Add term_taxonomy_id
to available fields in get_term_by()
. Adds unit test.
...
Props jchristopher.
Fixes #21651 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25334 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 00:01:19 +00:00
Scott Taylor
a963ab0852
Remove dead code in add_query_arg()
.
...
Props hakre, c3mdigital.
Fixes #16942 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25333 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 23:37:23 +00:00
Scott Taylor
1a46a76c18
Use wp_get_nav_menus()
instead of get_terms('nav_menu')
in WP_Nav_Menu_Widget
to preserve use of `wp_get_nav_menus' filter.
...
Props Frank Klein.
Fixes #25263 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25332 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 23:29:04 +00:00
Scott Taylor
d738f5e586
Support orderby => meta_value
in WP_User_Query
. Adds unit test.
...
Props wpsmith.
Fixes #21581 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25331 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 23:09:10 +00:00
Scott Taylor
c71a0422c0
Add an additional available param (the WP_User
instance) to the user_has_cap
filter.
...
Props Viper007Bond.
Fixes #24490 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25329 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 22:22:34 +00:00
Scott Taylor
4fccea305f
Add filter flush_rewrite_rules_hard
to give devs chance to prevent writing to file when hard-flushing rewrite rules.
...
Props jeremyfelt, nacin.
Fixes #23491 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25328 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 22:18:21 +00:00
Scott Taylor
a98660d517
Introduce get_previous_post_link()
, get_next_post_link()
, and get_adjacent_post_link()
. Allows developers to retrieve the value without echo
ing.
...
Props yoavf, markjaquith, SergeyBiryukov.
Fixes #17302 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25327 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 22:11:53 +00:00
Andrew Nacin
9d7689c4ba
Loose validation for is_serialized() in maybe_serialize().
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25320 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 18:09:36 +00:00
Andrew Nacin
0281fc61da
Better protocol validation in set_url_scheme().
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25319 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 18:07:19 +00:00
Andrew Nacin
ac3361e997
Validate referrers to prevent off-domain redirects.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25318 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 18:06:43 +00:00
Andrew Nacin
31482a7968
Tighten allowed upload file types.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25317 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 18:03:26 +00:00
Scott Taylor
d141191598
Consistently wrap author
and excerpt
nodes with CDATA
in feeds.
...
Fixes #18056 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25315 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 16:54:16 +00:00
Scott Taylor
5a75531f19
Replace the ancient phpfreaks.com
RegEx to extract urls to ping with a more robust matcher. URLs with commas and things like &
were not being pinged. The new matcher even works for most IDN URLs. Adds unit tests.
...
Fixes #9064 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25313 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 03:17:51 +00:00
Scott Taylor
e72ffa5d96
Move checks for post_type
being an array inline. See [25291], [25292], #18614 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25312 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 03:01:10 +00:00
Scott Taylor
9ece28e545
Add an action at the end of WP_Query::parse_tax_query()
called (wait for it...) parse_tax_query
which will enable developers to alter $this->tax_query->queries
before SQL is generated. pre_get_posts
is too early for many scenarios.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25311 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 02:35:26 +00:00
Scott Taylor
14e44dcd05
Make sure the queried object is non-null before accessing its properties.
...
Props markoheijnen, ryan.
Fixes #21394 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25310 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 02:27:24 +00:00
Dion Hulse
d0a189c6be
WP_HTTP: Correct the @since, and, @deprecated PHPDoc tags to reflect the class history. See #25007
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25309 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-09 08:09:20 +00:00
Dion Hulse
4a56e07c75
Switch to using HTTPS connections for Plugin and Theme API requests when SSL is available. See #18577
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25308 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-09 07:53:15 +00:00
Dion Hulse
d92f3ab536
WP_HTTP: When streaming to file, ensure that fwrite() suceeds and correctly writes the file to disk. Fixes #16057
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25303 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-09 01:17:17 +00:00
Sergey Biryukov
22aa493cfc
Inline documentation for hooks in http.php.
...
props tw2113.
see #25229 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25302 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-08 22:03:14 +00:00
Sergey Biryukov
6f6decc3f2
Document 'wp_link_query_args' and 'wp_link_query' filters. props DrewAPicture. fixes #18042 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25299 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-07 19:46:26 +00:00
Sergey Biryukov
8e4a6b31cd
Avoid PHP notices when configuring the Incoming Links dashboard widget. fixes #25250 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25298 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-07 18:16:09 +00:00
Sergey Biryukov
f6b4d33ae9
Add 'wp_link_query_args' and 'wp_link_query' filters to allow for customizing the internal linking dialog. props CoenJacobs, goldenapples. fixes #18042 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25293 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-07 12:20:57 +00:00
Scott Taylor
e688f070dc
Check the value passed to get_post_type_object()
. If it's an array, use the first item. get_query_var( 'post_type' )
can be an array if the query has been altered via filters/actions. There are several places in core that pass the query var. Adds unit tests.
...
In `template-loader.php`, move `is_post_type_archive()` and `is_tax()` directly below `is_home()`.
See #18614 , [25291].
git-svn-id: https://develop.svn.wordpress.org/trunk@25292 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-06 23:38:51 +00:00
Scott Taylor
48dc7e576b
Ensure that the post type object is the queried object when a post type has been registered with has_archive => true
. Ensure it is not stomped when decorated with tax_query
. Adds unit tests.
...
Props nacin.
Fixes #18614 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25291 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-06 22:06:40 +00:00
Scott Taylor
22278ec6a9
Introduce wp_using_ext_object_cache()
- mimic wp_suspend_cache_invalidation()
and discourage direct access to $_wp_using_ext_object_cache
, cleaning up importing of globals in functions and provides function to modify that global. Loads the packaged object cache when an external cache hasn't been loaded or doesn't contain wp_cache_init()
.
...
Fixes #21401 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25289 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-06 18:09:24 +00:00
Scott Taylor
0474a18863
Allow is_tag()
to accept term_id
, slug
, 'term_name or array of any. Many other
is_*()` funcs already do this. Adds unit tests.
...
Props ramiy.
Fixes #18746 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25287 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-06 17:26:04 +00:00
Andrew Nacin
c4068bc95b
Inline docs for hooks in MagPie.
...
props natejacobs.
see #25229 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25286 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-06 17:18:33 +00:00
Andrew Nacin
8a0ac73f60
Document the 'query' filter in wp-db.
...
props natejacobs.
see #25229 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25284 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-06 17:07:00 +00:00
Scott Taylor
09b9c44de9
Check bad dates and redirect, instead of 404ing, as necessary and appropriate.
...
Adds query, conditional, and canonical Unit Tests.
Props kovshenin, SergeyBiryukov, DrewAPicture.
Fixes #10935 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25280 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-06 16:35:22 +00:00
Sergey Biryukov
12647e132d
Deprecate get_blogaddress_by_domain(), unused since [25261]. props jeremyfelt. fixes #25235 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25276 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-06 11:40:58 +00:00
Andrew Nacin
37d92f4851
Short descriptions for inline docs should end with a period, per the vast majority of core. see #25229 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25273 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-06 01:37:59 +00:00
Dion Hulse
9095e4b866
Upgrader: Make clearing the Plugin and Theme update caches optional during install and upgrade proceedures. See #22704
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25272 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-06 01:32:09 +00:00
Andrew Nacin
760d5825ad
More adjustments and improvements for inline documentation for get_pages(). see #25186 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@25271 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-06 01:20:17 +00:00
Scott Taylor
bd610dd68a
Simplify the check for false-y child_of
arg.
...
Props SergeyBiryukov.
See #25230 , [25245].
git-svn-id: https://develop.svn.wordpress.org/trunk@25270 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-05 23:35:30 +00:00