Commit Graph

30723 Commits

Author SHA1 Message Date
Helen Hou-Sandi
e681cb8ba7 Image edit: Consistent whitespace for the side boxes.
props tyxla.
fixes #31845.


git-svn-id: https://develop.svn.wordpress.org/trunk@33002 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-30 15:18:29 +00:00
Konstantin Obenland
26c766c0a7 Use existing nomenclature pattern for Site Icon class.
Props kraftbj.
Fixes #32834.



git-svn-id: https://develop.svn.wordpress.org/trunk@33001 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-30 14:36:09 +00:00
Andrew Ozz
41c512a202 Add assertive capability to wp.a11y.speak().
Props afercia. See #32600.

git-svn-id: https://develop.svn.wordpress.org/trunk@33000 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-30 04:34:15 +00:00
azaozz
f27883ce42 Press This:
- Add support for the Text editor.
- Add auto-scrolling when the caret moves out of the viewport while the user is typing (similarly to editor-expand).
- Add auto-resize for the textarea.
See #32706.

git-svn-id: https://develop.svn.wordpress.org/trunk@32999 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-30 03:57:42 +00:00
Konstantin Obenland
6872d9122e Provide alt text for uploaded header images.
The custom header screen will use it rather then the description,
if an alt text is set.

Props francoeurdavid, voldemortensen, valendesigns.
Fixes #27959.



git-svn-id: https://develop.svn.wordpress.org/trunk@32998 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-29 21:31:21 +00:00
Boone Gorges
3a982b1590 Fix Tests_Post_GetPostClass::test_taxonomy_classes_hit_cache() after [32994].
[32994] results in an additional database query during automated testing, so
the query count being compared in this specific test must be incremented
manually.

See #16434.

git-svn-id: https://develop.svn.wordpress.org/trunk@32997 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-29 14:31:52 +00:00
Boone Gorges
10d81a3fe5 Introduce 'wp_generate_tag_cloud_data' filter.
This filter allows developers to modify the data that is used to create tag
clouds, without having to manipulate the tag cloud markup directly.

As part of the refactor, this changeset also adds a few unit tests for the way
`wp_generate_tag_cloud()` generates the 'title' attribute, as well as
improvements to output escaping.

Props flixos90, ysalame.
Fixes #24656.

git-svn-id: https://develop.svn.wordpress.org/trunk@32996 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-29 14:15:59 +00:00
Boone Gorges
85ce3f7eba Add some tests for wp_generate_tag_cloud().
Props welcher.
See #24656.

git-svn-id: https://develop.svn.wordpress.org/trunk@32995 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-29 13:18:48 +00:00
Konstantin Obenland
ffa682bee4 Introducing Site Icon, favicon management for WordPress.
This v1 marries Jetpack's Site Icon module with the Media Modal, reusing code
from the Custom Header admin. For now, the core-provided icons will be limited
to a favicon, an iOS app icon, and a Windows tile icon, leaving `.ico` support
and additional icons to plugins to add.

Props obenland, tyxla, flixos90, jancbeck, markjaquith, scruffian.
See #16434.



git-svn-id: https://develop.svn.wordpress.org/trunk@32994 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-29 12:57:35 +00:00
Dion Hulse
2959d58c91 XML-RPC: Only escape what we need to in wp.editPage, this allows for passwords with the special characters "' to work in a request.
Props redsweater for initial Patch.
Fixes #32703


git-svn-id: https://develop.svn.wordpress.org/trunk@32993 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-29 02:06:25 +00:00
Andrew Ozz
510aff0e2d wpLink: always attempt to correct the URL before getting the URL field value. Fixes an edge case where the URL was not corrected when the user submitted the form by pressing Enter.
Props andfinally. Fixes #32412.

git-svn-id: https://develop.svn.wordpress.org/trunk@32992 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-28 23:06:14 +00:00
Helen Hou-Sandi
74a2eb6790 List tables: Bring screen reader text for comments column title to media.
see #32152, [31513].


git-svn-id: https://develop.svn.wordpress.org/trunk@32991 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-28 15:43:32 +00:00
Aaron Jorbin
4a60647ab7 Deprecate php4 style constructors
PHP7 is deprecating PHP4 style constructors, so we need to modify our code to have _construct methods that fire before the named PHP4 style constructors.  The PHP4 style constructors will call the PHP5 style constructor in case it is being called directly (usually via parent::METHOD).

This modifies external libraries to add PHP5 style constructors, but doesn't add a notice for when they are used.  In WordPress core code, PHP4 style constructors are being given a call to _deprecated_constructor. To the PHP4 style constructor I say "I know that I can't take no more | It ain't no lie | I wanna see you out that door | Baby, bye, bye, bye..."

Upstream: https://wiki.php.net/rfc/remove_php4_constructors

Props jdgrimes, netweb, jorbin
See #31982



git-svn-id: https://develop.svn.wordpress.org/trunk@32990 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-28 15:26:41 +00:00
Aaron Jorbin
6c8944b6ea Add Deprecated Constructor Function
This function is one that can be called in core to indicate that a PHP4 style constructor is used. PHP4 style constructors are deprecated in PHP7.

Props jorbin, DrewAPicture for docs
See #31982



git-svn-id: https://develop.svn.wordpress.org/trunk@32989 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-28 14:55:33 +00:00
Aaron Jorbin
d928f81407 Update Grunt dev-dependencies
grunt-browserify : minor version update
grunt-contrib-cssmin : minor version update
grunt-contrib-imagemin : patch version update
grunt-contrib-jshint : patch version update
grunt-contrib-uglify : minor version update (causes some changes to minified JS)
grunt-includes : minor version update
grunt-sass : major version update ( underlying libsass update ).

Props wonderboymusic
See #31700



git-svn-id: https://develop.svn.wordpress.org/trunk@32988 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-28 14:49:08 +00:00
Konstantin Obenland
e43ee8d41d Customizer: Correct position for menu item delete icon in IE8.
Props valendesigns.
Fixes #32675.



git-svn-id: https://develop.svn.wordpress.org/trunk@32987 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-28 11:48:35 +00:00
Aaron Jorbin
6a83af6caa Add missing semicolon
Introduced in [32983].

see #32757.


git-svn-id: https://develop.svn.wordpress.org/trunk@32986 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-28 11:41:00 +00:00
Sergey Biryukov
893d02d469 Menus: Add a Manage in Customizer link, like we did for Widgets screen in [30459].
props celloexpressions.
fixes #32808.

git-svn-id: https://develop.svn.wordpress.org/trunk@32985 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-28 06:07:47 +00:00
Sergey Biryukov
0916133d43 List tables: Select All should not be a column header.
It sets a redundant relationship with all checkboxes in its column and also conveys wrong information for screen readers.

props afercia, valendesigns.
see #31654.

git-svn-id: https://develop.svn.wordpress.org/trunk@32984 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-28 05:45:49 +00:00
Andrew Ozz
c72d42d922 Press This:
- Save a draft before opening the standard editor window.
- While saving a post show Saving... instead of Publish for the main visible part of the split button (same as the Save Draft button before).
See #32757.

git-svn-id: https://develop.svn.wordpress.org/trunk@32983 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-28 04:58:56 +00:00
Sergey Biryukov
8baa10c377 Customizer: Increase color contrast ratio for menu locations text.
props celloexpressions.
fixes #32727.

git-svn-id: https://develop.svn.wordpress.org/trunk@32982 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-28 04:44:03 +00:00
Sergey Biryukov
5e3dcc772d Customizer: Add an aria-label attribute to the Add Items button to improve accessibility.
props afercia.
fixes #32713.

git-svn-id: https://develop.svn.wordpress.org/trunk@32981 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-28 04:27:24 +00:00
Scott Taylor
a796d187b3 When searching for users using the search arg in get_users()/WP_User_Query, also search the user's email, url, and display name.
Adds unit tests.

Props mordauk, wonderboymusic.
Fixes #27304.


git-svn-id: https://develop.svn.wordpress.org/trunk@32980 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-28 00:35:42 +00:00
Scott Taylor
cc762006c5 Update getID3 to 1.9.9
Changelog:
* https://github.com/JamesHeinrich/getID3/blob/master/changelog.txt
* https://github.com/JamesHeinrich/getID3/compare/v1.9.8...v1.9.9

Fixes #32806.


git-svn-id: https://develop.svn.wordpress.org/trunk@32979 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-28 00:16:17 +00:00
Scott Taylor
cb6867f374 Update jQuery to 1.11.3:
http://blog.jquery.com/2015/04/28/jquery-1-11-3-and-2-1-4-released-ios-fail-safe-edition/

Changelog:
* https://github.com/jquery/jquery/issues?q=milestone%3A1.11.3%2F2.1.4
* https://github.com/jquery/jquery/compare/1.11.2...1.11.3

Props peterwilsoncc.
Fixes #32794.


git-svn-id: https://develop.svn.wordpress.org/trunk@32978 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-27 23:39:16 +00:00
Scott Taylor
e4aa6ae703 After [32974], tweak some CSS for focus, etc.
See #31650.


git-svn-id: https://develop.svn.wordpress.org/trunk@32977 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-27 23:12:23 +00:00
Weston Ruter
556ec207f1 Customizer: Improve previewing setting changes for show_on_front, page_on_front, and page_for_posts.
When changing the `page_on_front` setting (with `show_on_front`), change the previewed URL to be the home URL so that the effect can be seen. When changing `page_for_posts`, change the previewed URL to be the selected page.

Props valendesigns, westonruter.
Fixes #30677.



git-svn-id: https://develop.svn.wordpress.org/trunk@32976 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-27 19:58:41 +00:00
Konstantin Obenland
a4fd22608f Additional style changes to accomodate <h1> headings.
See [32974], #31650.



git-svn-id: https://develop.svn.wordpress.org/trunk@32975 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-27 15:50:59 +00:00
Konstantin Obenland
e59592f87e Proper heading for admin screens.
First step towards restoring a good heading structure in wp-admin.
The previous `<h1>` contained the site title and a link to the front page and was removed with the toolbar refactoring in 3.2.

Props joedolson, afercia.
Fixes #31650.



git-svn-id: https://develop.svn.wordpress.org/trunk@32974 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-27 15:40:27 +00:00
Sergey Biryukov
1be584d477 Fix the dismissable notice button focus style, broken in [32475].
props afercia.
fixes #32797.

git-svn-id: https://develop.svn.wordpress.org/trunk@32973 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-27 15:06:22 +00:00
Sergey Biryukov
af60f4e874 Media modal: Use better descriptive text for "Remove" buttons.
props afercia.
fixes #32792.

git-svn-id: https://develop.svn.wordpress.org/trunk@32972 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-27 14:50:41 +00:00
Dominik Schilling (ocean90)
37837c88f1 Customizer: Add an aria-expanded attribute to the Add Menu button to improve accessibility.
props afercia.
fixes #32791.

git-svn-id: https://develop.svn.wordpress.org/trunk@32971 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-27 10:04:32 +00:00
Dominik Schilling (ocean90)
3dd7ca4ed6 Customizer: Remove top margin when dragging menu items.
The markup was changed in [32889].

props tywayne.
fixes #32745.

git-svn-id: https://develop.svn.wordpress.org/trunk@32970 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-27 09:46:10 +00:00
Sergey Biryukov
9a6c48790a Revert [32702]. The URL may not have an s parameter as there are filters in place so that a plugin can return a URL with a completely different structure.
see #32572.

git-svn-id: https://develop.svn.wordpress.org/trunk@32969 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-27 08:34:09 +00:00
Andrew Ozz
ce10a63e67 TinyMCE: prevent undefined error in toolbar.hide().
See #32604.

git-svn-id: https://develop.svn.wordpress.org/trunk@32968 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-27 02:23:18 +00:00
Andrew Ozz
b6eb753618 TinyMCE, inline link toolbar: tweak styling on small screens to fix wrapping in iOS.
See #32604.

git-svn-id: https://develop.svn.wordpress.org/trunk@32967 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-27 02:20:30 +00:00
Andrew Ozz
44eaf91b75 Press This: fix iOS bug that prevents closing of the split button when tapping outside of it.
See #32757.

git-svn-id: https://develop.svn.wordpress.org/trunk@32966 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-27 02:14:29 +00:00
Scott Taylor
550763988b ob_get_contents() followed by ob_end_clean() can be replaced by ob_get_clean().
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32965 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-27 01:11:45 +00:00
Scott Taylor
f162be6046 For doc block types, favor bool over the few remaining booleans
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32964 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-27 01:02:12 +00:00
Scott Taylor
2a5278e2dd Some doc blocks should use bool instead of true|false
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32963 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-27 00:44:21 +00:00
Scott Taylor
297b615b99 In WP_Filesystem_Base::chdir|chgrp|chmod() (all mock abstract methods), modify @return to include string so that subclass @returns match.
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32962 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-27 00:42:43 +00:00
Scott Taylor
fe617914d4 Declare visibility for WP_Locale methods.
See #32444.



git-svn-id: https://develop.svn.wordpress.org/trunk@32961 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-27 00:31:27 +00:00
Andrew Ozz
4affc95146 TinyMCE: prevent error in the wptextpattern plugin when the first child node in a paragraph is not a text node.
See #31441;

git-svn-id: https://develop.svn.wordpress.org/trunk@32960 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-26 23:18:16 +00:00
Andrew Ozz
a0ebf84f40 Update Twemoji to 1.4.1 including up to 3c0c13d3a5 (exclude SVG elements). Remove our hacks and adapt wp-emoji.js to use the new image attributes callback.
Fixes #32203.

git-svn-id: https://develop.svn.wordpress.org/trunk@32959 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-26 22:00:13 +00:00
Andrew Ozz
d688a2ddc2 TinyMCE, inline link toolbar: fix z-index bug in iOS Safari.
See #32604.

git-svn-id: https://develop.svn.wordpress.org/trunk@32958 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-26 20:28:59 +00:00
Andrew Ozz
8b77a613c1 TinyMCE: add the editor focusing help the Keyboard Shortcuts modal.
See #31913.

git-svn-id: https://develop.svn.wordpress.org/trunk@32957 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-26 18:48:02 +00:00
Andrew Ozz
82d937a96e TinyMCE, inline link toolbar: fix styling on small screens so the displayed URL is not needlessly truncated.
See #32604.

git-svn-id: https://develop.svn.wordpress.org/trunk@32956 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-26 17:54:57 +00:00
Dominik Schilling (ocean90)
d6ebee58c2 Customizer: Prevent dragging menu items above the main heading.
Improve targeting for the `sortableItems`, resolving an issue where the first `<li>` in the control became a sortable target, allowing the user to drag a single top level menu outside the intended sortable area.

props adamsilverstein.
fixes #32738.
#wceu

git-svn-id: https://develop.svn.wordpress.org/trunk@32955 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-26 17:10:12 +00:00
Boone Gorges
4f60683623 Improve error checking in get_edit_term_link().
The function should not throw notices when an improper term or taxonomy is
passed.

Props tmatsuur, MikeHansenMe.
Fixes #32786.

git-svn-id: https://develop.svn.wordpress.org/trunk@32954 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-26 14:12:27 +00:00
Boone Gorges
da5c716009 Introduce WP_UnitTestCase::delete_user().
This static method provides a multisite-agnostic way to delete users during
automated testing.

See #32796.

git-svn-id: https://develop.svn.wordpress.org/trunk@32953 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-26 12:58:29 +00:00