Commit Graph

30723 Commits

Author SHA1 Message Date
Helen Hou-Sandi
8f024536c1 List tables: Add a fallback for the primary column.
Without a primary column defined, nothing shows in the responsive view at all, which is bad.

props mordauk.
see #25408.


git-svn-id: https://develop.svn.wordpress.org/trunk@33104 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-07 15:11:54 +00:00
Dion Hulse
70ab756043 Ensure that Custom Links in menu's are marked as current regardless of their scheme.
Props McGuive7, marsjaninzmarsa.
Fixes #32221


git-svn-id: https://develop.svn.wordpress.org/trunk@33103 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-07 09:56:19 +00:00
Boone Gorges
8e6997b652 Use assertEqualSets() in WP_Query::parse_tax_query() tests.
Props ocean90.
See #32454.

git-svn-id: https://develop.svn.wordpress.org/trunk@33102 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-07 00:57:04 +00:00
Helen Hou-Sandi
6d8f6f8d11 List tables: Account for comments being reused on the post edit screen.
Adding the `.wp-list-table` class gets us a few responsive goodies for free. And now it won't show a strange button outline.

see #32395.


git-svn-id: https://develop.svn.wordpress.org/trunk@33101 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-07 00:08:46 +00:00
Jeremy Felt
dabe7ab9c3 Assign proper active class when showing plugin updates in network admin
Previously, a plugin would trigger an active class if it was active on the network's main site.

Fixes #32901.


git-svn-id: https://develop.svn.wordpress.org/trunk@33100 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-07 00:01:31 +00:00
Helen Hou-Sandi
9c1265181c List tables: Get rid of double borders for plugins and themes on narrow screens.
see #32395.


git-svn-id: https://develop.svn.wordpress.org/trunk@33099 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-06 23:48:16 +00:00
Helen Hou-Sandi
94cd2d47eb List tables: Ensure the no items message appears on narrow screens.
fixes #32900. see #32395.


git-svn-id: https://develop.svn.wordpress.org/trunk@33098 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-06 23:29:44 +00:00
Jeremy Felt
69239d86f9 Remove unused $current_site global in MS Sites list table
Found itself unused after [32719].

See #32434.


git-svn-id: https://develop.svn.wordpress.org/trunk@33097 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-06 22:50:59 +00:00
Konstantin Obenland
2cafc0d787 Check for all required caps before (un)sticking a post.
In cases where a user has the `edit_others_posts` capability but not
`publish_posts`, it was possible for that user to unstick a post after editing,
since the input field was never made available in that context.

Props ericmann, chriscct7.
Fixes #24153.



git-svn-id: https://develop.svn.wordpress.org/trunk@33096 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-06 22:40:59 +00:00
Boone Gorges
53021ef6fe In WP_Query::parse_tax_query(), allow taxonomy querystring to be formatted as an array.
Props Veraxus.
Fixes #32454.

git-svn-id: https://develop.svn.wordpress.org/trunk@33095 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-06 20:36:18 +00:00
Weston Ruter
17854c6464 Customizer: Register controls and settings for nav_menu_locations even when there are no menus yet.
This change ensures that the first menu created can be assigned to a location without first saving and reloading the Customizer.

Props markoheijnen.
Fixes #32858.


git-svn-id: https://develop.svn.wordpress.org/trunk@33094 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-06 19:12:48 +00:00
Lance Willett
63f025a07b Twenty Fifteen: don't hyphenate input elements. Fixes #32880.
git-svn-id: https://develop.svn.wordpress.org/trunk@33093 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-06 18:02:34 +00:00
obenland
4ba9e8a062 Twenty Fifteen: Display sidebar background color with Header Image.
If the header image has a transparent background, the sidebar background color
should be visible. With the `background` shorthand it could never be over set
on the front-end however.

Props valendesigns.
Fixes #31460.



git-svn-id: https://develop.svn.wordpress.org/trunk@33092 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-06 17:26:02 +00:00
Scott Taylor
3eaaa104b5 In wp.media.model.Attachments.filters.type(), return true earlier if type isn't set.
Props vivekbhusal.
Fixes #32746.


git-svn-id: https://develop.svn.wordpress.org/trunk@33091 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-06 15:33:53 +00:00
Sergey Biryukov
345521666e Merge two class attributes in WP_Customize_Media_Control::content_template() and wp_print_media_templates().
props nicholas_io.
fixes #32896.

git-svn-id: https://develop.svn.wordpress.org/trunk@33090 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-06 14:18:03 +00:00
Weston Ruter
1b02636793 Customizer: Ensure that a newly-added nav menu item gets the Original link populated in its control.
Props valendesigns.
Fixes #32858.



git-svn-id: https://develop.svn.wordpress.org/trunk@33089 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-06 05:52:59 +00:00
Andrew Ozz
0f7208a1ee Fix opening closed widget areas when dragging a widget over them.
Props polevaultweb. Fixes #13524.

git-svn-id: https://develop.svn.wordpress.org/trunk@33088 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-05 18:19:44 +00:00
Sergey Biryukov
ade1ffde80 Plugins list table: Add an aria-label attribute with the plugin name to plugin action links to provide context for screen reader users.
props bramd, rianrietveld, afercia.
fixes #26167.

git-svn-id: https://develop.svn.wordpress.org/trunk@33087 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-05 15:02:04 +00:00
Konstantin Obenland
c35f5f16b0 Remove deprecated constructor notice.
Since Twenty Eleven can be used with WordPress releases prior to 4.3, it can't
contain calls to functions that were introduced after its initial release.

Props ocean90.
Fixes #32881.



git-svn-id: https://develop.svn.wordpress.org/trunk@33086 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-04 20:42:43 +00:00
Konstantin Obenland
9b40a4f79f Deprecate PHP4 style contructor in Twenty Eleven's Ephemera widget.
See #31982.

Props Frank Klein.
Fixes #32881.



git-svn-id: https://develop.svn.wordpress.org/trunk@33085 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-04 20:28:17 +00:00
Konstantin Obenland
9d101ee78e Site Icon: Switch to using H1 headings.
See #31650.

Props afercia.
Fixes #32885.



git-svn-id: https://develop.svn.wordpress.org/trunk@33084 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-04 18:48:37 +00:00
Jeremy Felt
14f39faab1 Usernames in multisite should be restricted to 60 characters or fewer.
Only 60 characters can be stored in the database for a username, which could cause lookup issues when attempting to use similar usernames of extreme length.

Props @DJPaul.
See #17904, Fixes #26784.


git-svn-id: https://develop.svn.wordpress.org/trunk@33083 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-04 05:52:46 +00:00
Jeremy Felt
d8df19141a Don't autocapitalize or autocorrect domain or path when adding a new site in iOS.
Props @ohryan.
Fixes #32646.


git-svn-id: https://develop.svn.wordpress.org/trunk@33082 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-04 04:39:48 +00:00
Jeremy Felt
ea4baac6e8 Use the full site URL in choose_primary_blog() when a user is a member of only one site.
Aligns with the output used when a user is a member of multiple sites.

Fixes #32884.


git-svn-id: https://develop.svn.wordpress.org/trunk@33081 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-04 04:20:18 +00:00
Jeremy Felt
4a785cbeb0 Only output Save Changes in My Sites when a user is a member of more than one site.
The conditional also checks for the existence of filters that may otherwise alter the HTML in My Sites to include extra form inputs for these users. If a filter is in use, the Save Changes button will display.

Props @Oxymoron, @obenland.
Fixes #32645.


git-svn-id: https://develop.svn.wordpress.org/trunk@33080 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-04 04:00:48 +00:00
Sergey Biryukov
e03c9a769a Don't capitalize words in a sentence after comma.
props bjornjohansen, netweb.
fixes #31927.

git-svn-id: https://develop.svn.wordpress.org/trunk@33079 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-04 00:49:52 +00:00
Sergey Biryukov
313c416f6c Customizer: Remove HTML tags from two translatable strings.
props henrikakselsen.
fixes #32817.

git-svn-id: https://develop.svn.wordpress.org/trunk@33078 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 22:28:29 +00:00
Dominik Schilling (ocean90)
45e6228070 Customizer: Fix tabindex of reorder buttons for menu items with depth 1 and 10.
props celloexpressions.
fixes #32767.

git-svn-id: https://develop.svn.wordpress.org/trunk@33077 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 22:20:04 +00:00
Sergey Biryukov
056fcf6162 Plugins list table: Use case-insensitive sorting.
props GaryJ.
fixes #32735.

git-svn-id: https://develop.svn.wordpress.org/trunk@33076 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 21:52:46 +00:00
Konstantin Obenland
e7c286551f Site Icon: Remove date dropdown from media modal.
This also allows us to leverage the builtin `suggestedWidth` and
`suggestedHeight` parameters to convey the expected image size.

Props ocean90.
Fixes #32860.



git-svn-id: https://develop.svn.wordpress.org/trunk@33075 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 21:27:06 +00:00
Dominik Schilling (ocean90)
787016376a Customizer: Improve descriptive text and focus for menu items reorder button.
props afercia.
fixes #32725.

git-svn-id: https://develop.svn.wordpress.org/trunk@33074 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 21:23:12 +00:00
Konstantin Obenland
e33229a237 Synchronize star ratings of themes and plugins.
Makes themes ratings look like plugins ratings already do.

Props helen.
Fixes #32782.
 


git-svn-id: https://develop.svn.wordpress.org/trunk@33073 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 20:53:18 +00:00
Boone Gorges
02bd602dfe Improve the display of my-sites.php on small screens.
Props tryon.
Fixes #31685.

git-svn-id: https://develop.svn.wordpress.org/trunk@33072 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 20:46:54 +00:00
Weston Ruter
a21c6e76d6 Customizer: Fix saving menus with empty names or names that are already used.
Adds validation for initially-supplied nav menu name, blocking empty names from being supplied. If later an empty name is supplied and the nav menu is saved, the name "(unnamed)" will be supplied instead and supplied back to the client. If a name is supplied for the menu which is currently used by another menu, then the name conflict is resolved by adding a numerical counter similar to how `post_name` conflicts are resolved. Includes unit tests.

Fixes #32760.



git-svn-id: https://develop.svn.wordpress.org/trunk@33071 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 20:46:48 +00:00
Dominik Schilling (ocean90)
55d7ab3da5 Customizer: Remove some non-functional code.
props afercia.
fixes #32839.

git-svn-id: https://develop.svn.wordpress.org/trunk@33070 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 20:36:59 +00:00
Dominik Schilling (ocean90)
e430245d00 Customizer: Accessibility enhancements.
* Move tabindex/focus code into `onChangeExpanded` so that it works for cases where `expand()` is called directly.
* Use `visibility: hidden` to hide hidden elements from keyboard focus and screen readers.

props celloexpressions.
fixes #31336.

git-svn-id: https://develop.svn.wordpress.org/trunk@33069 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 20:18:17 +00:00
Konstantin Obenland
1757c3f4d4 Don't let wp-pointers cover the theme detail modal.
Fixes #31544.


git-svn-id: https://develop.svn.wordpress.org/trunk@33068 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 17:04:33 +00:00
Konstantin Obenland
8d40cdcb1b Use a less element-specific class name for links within page titles.
After [32974] these links are no longer within an `h2`, making the class name
inaccurate. `add-new-h1` has the potential to expose the same problem for in a
possible future change.

Fixes #31650.



git-svn-id: https://develop.svn.wordpress.org/trunk@33067 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 16:41:18 +00:00
Konstantin Obenland
04a01d7354 Check if commentReply exists before trying to work with it.
Fixes a bug that caused the save/publish flow to be interrupted by an AYS.

Introduced in [33024].
See #29457.



git-svn-id: https://develop.svn.wordpress.org/trunk@33066 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 15:31:38 +00:00
Aaron Jorbin
3baf370b28 Remove accidental change to embed
Reverts about.php change from [33064]




git-svn-id: https://develop.svn.wordpress.org/trunk@33065 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 14:29:37 +00:00
Aaron Jorbin
a547d6fed1 Don't strip newline in esc_url() when protocol is mailto:
The mailto protocol is a bit different than the other protocols in that new lines are something you might realistically want to include. Includes tests to make sure that http protocol urls that contain mailto: aren't affected. Tests for stripping newlines in general already exist.

Fixes #31632
Props danielbachhuber



git-svn-id: https://develop.svn.wordpress.org/trunk@33064 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 14:27:11 +00:00
Dion Hulse
12168b78d5 Press This: Rewrite WP_Press_This::fetch_source_html() to utilise the HTTP API better without the need for a local temporary file.
This reverts [33061] but keeps it's custom UA string.

See #32864


git-svn-id: https://develop.svn.wordpress.org/trunk@33062 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 12:00:10 +00:00
Sergey Biryukov
9cfb72615c Press This: Set explicit user agent.
props kraftbj.
fixes #32864.

git-svn-id: https://develop.svn.wordpress.org/trunk@33061 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 11:16:08 +00:00
Ella Iseulde Van Dorpe
220121249a Editor: refresh word count quicker
2 seconds is a bit slow. Debouncing with 1 second means it can only run maximum once per second. In reality it won't run us much. Even people who type slow will usually type faster than 1 character per second.

See #30966.



git-svn-id: https://develop.svn.wordpress.org/trunk@33060 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 09:14:08 +00:00
Dion Hulse
2fbb13be21 Don't upgrade global tables to utf8mb4 when wp_should_upgrade_global_tables() says not to.
Additionally fixes an incorrect conditional in [33057] which would result in the usermeta index being altered twice on Multisite updates.

See #32154


git-svn-id: https://develop.svn.wordpress.org/trunk@33058 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 05:43:28 +00:00
Dion Hulse
947825f326 Introduce wp_should_upgrade_global_tables() to determine if global tables should be upgraded automatically. Use it throughout the existing upgrade routines.
Props johnjamesjacoby for initial patch
Fixes #32154 for trunk


git-svn-id: https://develop.svn.wordpress.org/trunk@33057 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 04:33:14 +00:00
Helen Hou-Sandi
e7a184a832 Toolbar: Allow submenus to be closed with a second tap on touch devices.
Also closes submenus when the admin menu is toggled open, as it opens below and thus can be obscured.

props stephdau, seanchayes.
see #29906.


git-svn-id: https://develop.svn.wordpress.org/trunk@33056 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 03:28:15 +00:00
Dion Hulse
e709e91218 Enable utf8mb4 for MySQL extension users. Previously utf8mb4 was limited to MySQLi users only unintentionally.
This change does the following things
 * Allows utf8mb4 for the MySQL extension
 * Re-runs the utf8->utf8mb4 conversion for single sites, this will do nothing for tables already converted
 * Re-runs the utf8->utf8mb4 conversion for global tables in multisite when the environment supports utf8mb4
 * Removes upgrade_420() calling as upgrade_430() will perform those changes now instead

The index shortenings should have still taken place on utf8 sites previously, so there's no need to run those again. 

Props kovshenin, pento, dd32
Fixes #32127 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@33055 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 03:25:07 +00:00
Konstantin Obenland
bfbdb6f0b2 Use get_default_comment_status() globally.
Also makes the filter name static and passes the post type for context.

Props valendesigns.
Fixes #31168.



git-svn-id: https://develop.svn.wordpress.org/trunk@33054 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-02 22:31:58 +00:00
Konstantin Obenland
9532df3c9f Site Icon: Improve responsiveness for small screen devices.
Using Jcrop's `trueSize` argument also allows us to get rid of all that behind
the scenes temp image creating and back and forth calculating of image sizes.

Props tyxla for initial patch.
See #16434.



git-svn-id: https://develop.svn.wordpress.org/trunk@33053 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-02 21:15:52 +00:00