Commit Graph

38110 Commits

Author SHA1 Message Date
John Blackbourn
b7c2dfb9ae Build/Test Tools: Allow code coverage reports to be generated.
This corrects the attribute needed to allow PHPUnit to generate coverage reports, and also adds a blacklist of files and directories that are excluded from coverage reports.

Props schlessera, jipmoors

Fixes #43067, #43240


git-svn-id: https://develop.svn.wordpress.org/trunk@42665 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-07 22:20:25 +00:00
John Blackbourn
37a1552e39 Docs: Copy a helpful inline doc into the function header for visibility.
See #42505


git-svn-id: https://develop.svn.wordpress.org/trunk@42664 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-07 22:12:50 +00:00
Aaron Jorbin
2c6f1b18f4 Options: Use most appropriate language in the test suite.
The test suite's opinion of cancer should be clear.

Reverts r42659.

See #43207, #38176




git-svn-id: https://develop.svn.wordpress.org/trunk@42663 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-07 20:58:21 +00:00
Boone Gorges
fa266b4724 Improve parameter description for 'allow_empty_comments'.
Introduced in [42661].

Props swissspidy.
See #16979.

git-svn-id: https://develop.svn.wordpress.org/trunk@42662 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-07 20:49:26 +00:00
Boone Gorges
4f22e04244 Comments: Introduce 'allow_empty_comment' filter.
This filter allows plugin authors to allow empty comments on a selective
basis during comment submission.

Props jpurdy647.
Fixes #16979.

git-svn-id: https://develop.svn.wordpress.org/trunk@42661 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-07 20:08:47 +00:00
Drew Jaynes
602117f2b9 Docs: Fix a typo in the DocBlock description for get_bloginfo() illustrating the URL structure for RDF feeds.
Props ibachal.
See #42505.


git-svn-id: https://develop.svn.wordpress.org/trunk@42660 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-07 19:41:29 +00:00
John Blackbourn
9b46512501 Options: Use more appropriate language in the test suite.
See #43207, #38176


git-svn-id: https://develop.svn.wordpress.org/trunk@42659 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-07 18:51:55 +00:00
Drew Jaynes
79a06efdb8 Docs: Document default arguments for wp_tag_cloud() in a hash notation, noting that full lists of additionally-supported arguments are already documented in get_terms() and wp_generate_tag_cloud().
Props birgire, johnbillion.
Fixes #42019.


git-svn-id: https://develop.svn.wordpress.org/trunk@42658 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-07 15:21:25 +00:00
Felix Arntz
ea13c56d7f Options: Unhook default option filter when setting is unregistered.
Fixes #43207.


git-svn-id: https://develop.svn.wordpress.org/trunk@42655 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-06 14:48:46 +00:00
Dion Hulse
e04b4d47b4 Updates: Partially revert [42584], as this branch of code should always be run after a core update check.
This code branch is responsible for running all autoupdates, including plugins and themes - which should run regardless of if there's a core autoupdate available.

This revert does not revert the `$timeout` changes, as these should still use cached data if it's available.
Ideally this should be decoupled from the core update check to allow background updates to operate even when the core update check is disabled or running more often than twice daily.

See #43103.


git-svn-id: https://develop.svn.wordpress.org/trunk@42653 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-06 11:03:55 +00:00
Dion Hulse
5789855ed1 XML-RPC: Add default values to IXR_Message for PHP 7.2 compatibility to avoid PHP Warnings.
Fixes #43216 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@42652 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-06 02:55:38 +00:00
Peter Wilson
5c378e02dd Taxonomy: Stop warming term meta cache unnecessarily.
Prevent several core function calls to `get_terms()` from warming the term meta cache.

Props peterwilsoncc, boonebgorges, jrf.
Fixes #43142.



git-svn-id: https://develop.svn.wordpress.org/trunk@42649 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-05 04:09:27 +00:00
Peter Wilson
f317869c7f General: Replace Cheatin’ uh? with friendlier error messages.
While intended as a playful error message, `Cheatin’ uh?` can be interpreted as insulting or accusatory in an already stressful situation. This replaces Cheatin’ with more meaningful error messages, depending on the error that occurs.

Props ElectricFeet, EricMeyer, karmatosed, dd32, BandonRandon, melchoyce for language; dmsnell for original patch; peterwilsoncc.
Fixes #38332.



git-svn-id: https://develop.svn.wordpress.org/trunk@42648 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-05 02:29:53 +00:00
John Blackbourn
d512973c84 Canonical: Add $x_redirect_by parameter to wp_safe_redirect().
See [42633] and [42408].

Fixes #42313.


git-svn-id: https://develop.svn.wordpress.org/trunk@42647 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-04 16:04:10 +00:00
Drew Jaynes
311531a964 Tests: Simplify @covers annotations for WP_Error test coverage. Also fix a typo in a test method name.
See #42742.


git-svn-id: https://develop.svn.wordpress.org/trunk@42646 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-03 17:37:51 +00:00
Drew Jaynes
86d486d67d Tests: Fix two typos introduced for a get_term_field() test in [35270].
See #33968.


git-svn-id: https://develop.svn.wordpress.org/trunk@42645 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-03 17:10:51 +00:00
Andrea Fercia
a6888ef843 Administration: Make the Screen Options available on small screens.
Previously, the Screen Options toggle and the related panel content 
were hidden on small screens, preventing access to important settings,
including the ability to toggle the meta boxes visibility.

Props chetan200891.
Fixes #40985.


git-svn-id: https://develop.svn.wordpress.org/trunk@42644 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-03 16:57:24 +00:00
Sergey Biryukov
bc982475fc Help/About: Correct outdated media icons reference in help text on Edit Post screen.
Props thrijith, transl8or.
Fixes #42378.

git-svn-id: https://develop.svn.wordpress.org/trunk@42643 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-03 13:57:33 +00:00
Sergey Biryukov
1b0695780f Media: Remove checkered background for icons in Attachment Details.
Props BandonRandon.
Fixes #42535. See #41948.

git-svn-id: https://develop.svn.wordpress.org/trunk@42642 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-03 13:53:44 +00:00
Andrea Fercia
ce61a7f676 Administration: CSS coding standards: use double quotes for values that require quotes.
As per the WordPress CSS coding standards, CSS properties with values that require quotes must use double quotes.
Also fixes some indentation and spacing.

Fixes #43220.


git-svn-id: https://develop.svn.wordpress.org/trunk@42641 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-03 13:18:40 +00:00
Sergey Biryukov
3bbe18ee1c Docs: Convert $args array description for wp_get_themes() to a hash notation.
Props milana_cap.
Fixes #43213.

git-svn-id: https://develop.svn.wordpress.org/trunk@42640 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-02 09:37:47 +00:00
Sergey Biryukov
579f04fb06 Media: Avoid a PHP warning in wp_calculate_image_srcset() if a plugin returns a non-array value via wp_calculate_image_srcset filter.
Props mrmadhat, codegrau.
Fixes #43201.

git-svn-id: https://develop.svn.wordpress.org/trunk@42639 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-02 07:47:03 +00:00
Sergey Biryukov
6d379c6f0f Posts, Post Types: Don't count pending comments in WP_Posts_List_Table::_display_rows() if the post type does not support comments.
Props seanchayes.
Fixes #43212.

git-svn-id: https://develop.svn.wordpress.org/trunk@42638 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-02 07:37:10 +00:00
Sergey Biryukov
6073df2b45 Build Tools: Update SPDX License in package.json to adhere to SPDX v3.0 specification.
Props netweb.
Fixes #43032.

git-svn-id: https://develop.svn.wordpress.org/trunk@42637 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-01 16:38:48 +00:00
Sergey Biryukov
59e1b7318d Tests: Correct erroneous @covers and @use tags.
Props jipmoors.
Fixes #43203.

git-svn-id: https://develop.svn.wordpress.org/trunk@42636 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-01 16:08:04 +00:00
Sergey Biryukov
07bff5d8bd Tests: Improve tests for wp_get_post_parent_id() added in [42397].
Props frank-klein.
Fixes #42797.

git-svn-id: https://develop.svn.wordpress.org/trunk@42635 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-01 16:02:26 +00:00
Sergey Biryukov
534f096302 Menus: Remove $_menu_item_sort_prop global reference from wp_get_nav_menu_items(), unused since [38928].
Props PieWP, welcher.
Fixes #40947.

git-svn-id: https://develop.svn.wordpress.org/trunk@42634 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-01 15:41:55 +00:00
Sergey Biryukov
40f76ae917 Canonical: Add $x_redirect_by parameter to wp_redirect() that allows applications doing the redirect to identify themselves.
This complements the `x_redirect_by` filter added in [42408].

Props NathanAtmoz, johnbillion.
Fixes #42313.

git-svn-id: https://develop.svn.wordpress.org/trunk@42633 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-01 15:05:50 +00:00
Dion Hulse
212c880d71 Themes: Use api.wordpress.org/themes/info/1.2/ to query theme information.
See #43192.


git-svn-id: https://develop.svn.wordpress.org/trunk@42632 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-01 05:18:54 +00:00
Dion Hulse
e0d5a8ac54 Plugins: Use api.wordpress.org/plugins/info/1.2/ for querying plugins & plugin information.
See #43192.
Fixes #29274.


git-svn-id: https://develop.svn.wordpress.org/trunk@42631 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-01 05:16:15 +00:00
Sergey Biryukov
cc9a5641a6 Docs: Correct erroneous class references in @see tags.
Props coffee2code.
Fixes #43158.

git-svn-id: https://develop.svn.wordpress.org/trunk@42630 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-01 01:19:50 +00:00
Sergey Biryukov
1c0257d340 Code Editor: Add Ctrl/Cmd+F as aliases for persistent search for more intuitive behaviour.
Keep Alt+F as well for users who already expect that.

Props Desertsnowman.
See #42586.

git-svn-id: https://develop.svn.wordpress.org/trunk@42625 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-31 22:21:53 +00:00
Andrea Fercia
37e81feb9f Media: avoid page scrolling when opening the media modal.
Moves focus to a proper element within the media modal to avoid the underlying
page to scroll to the bottom. Removes the media modal `freeze` option.

Props andreiglingeanu, adamsilverstein.
Fixes 39859.


git-svn-id: https://develop.svn.wordpress.org/trunk@42624 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-31 17:02:27 +00:00
Adam Silverstein
1c4f57f425 Remove unit tests for deprecated ajax tag search function.
Fixes unit tests failing since r42614.

Ammends [42614].
See #38922.


git-svn-id: https://develop.svn.wordpress.org/trunk@42619 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-30 02:28:14 +00:00
Adam Silverstein
3f04c10fea Remove unused var after r42614, fixing a jshint error.
git-svn-id: https://develop.svn.wordpress.org/trunk@42618 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-30 00:33:18 +00:00
Weston Ruter
bba8d65216 Widgets: Fix Text widget unit test which broke due to global scope not being cleaned.
Amends [42613].
See #42495.


git-svn-id: https://develop.svn.wordpress.org/trunk@42617 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-30 00:33:03 +00:00
Adam Silverstein
d6788fec51 Correct the version term_search_min_chars changed. Ammends r42614.
git-svn-id: https://develop.svn.wordpress.org/trunk@42616 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-30 00:29:29 +00:00
Weston Ruter
0e818c7aee Customize: Ensure customize_autosaved requests only use revision of logged-in user.
Props dlh, westonruter.
See #42433, #39896.
Fixes #42450.


git-svn-id: https://develop.svn.wordpress.org/trunk@42615 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-30 00:20:37 +00:00
Adam Silverstein
04b0a0f77c Taxonomy: Use REST API for ajax tag search.
Deprecate wp_ajax_ajax_tag_search and switch to using the REST API when searching tags in the tags meta box.

Props nacin, chriscct7, afercia, swissspidy, jnylen0, rmccue, ryelle.
Fixes #38922.



git-svn-id: https://develop.svn.wordpress.org/trunk@42614 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-30 00:16:37 +00:00
Weston Ruter
07e4b7565e Customize: Ensure media playlists get initialized after selective refresh; expose new wp.playlist.initialize() API.
In particular allows audio and video playlists to be added to the Text widget and previewed.

Props bpayton, westonruter.
See #40854.
Fixes #42495.


git-svn-id: https://develop.svn.wordpress.org/trunk@42613 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-29 23:55:44 +00:00
Weston Ruter
8561f22f4d Customize: Ensure heartbeat keeps changeset locked when in branching mode.
Props dlh.
See #42024.
Fixes #42658.


git-svn-id: https://develop.svn.wordpress.org/trunk@42612 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-29 23:04:22 +00:00
Weston Ruter
b31563e561 Customize: Include nav menu item for Home custom link in search results for "Home".
Props audrasjb, westonruter.
Fixes #42991.


git-svn-id: https://develop.svn.wordpress.org/trunk@42611 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-29 22:09:55 +00:00
Gary Pendergast
afb4f45e62 Emoji: Tweak the generated emoji arrays to not cause coding standards errors.
Props netweb, jrf.
Fixes #43150.



git-svn-id: https://develop.svn.wordpress.org/trunk@42610 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-25 01:05:01 +00:00
Sergey Biryukov
5bc3564249 Role/Capability: Make install_languages capability check less restrictive.
A user should still be able to have the capability, even when language packs cannot be automatically installed. The automatic installation part is separate from that now.

Props flixos90.
Fixes #42697.

git-svn-id: https://develop.svn.wordpress.org/trunk@42606 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-24 22:41:58 +00:00
Sergey Biryukov
9feedd0b0d Upgrade/Install: In postMessage events handler, check for message object existence before checking its action property.
Props manikmist09.
Fixes #43005.

git-svn-id: https://develop.svn.wordpress.org/trunk@42604 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-24 22:30:12 +00:00
Peter Wilson
fdb0551c5a Emoji: Update Emoji browser support tests for Twemoji v2.4.0
Really, following [42598].

Fixes #42862 for trunk, really.


git-svn-id: https://develop.svn.wordpress.org/trunk@42602 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-24 22:01:42 +00:00
Sergey Biryukov
c03e730085 Media: Fix JSHint error after [42595].
See #42646.

git-svn-id: https://develop.svn.wordpress.org/trunk@42599 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-24 21:50:32 +00:00
Peter Wilson
22f98e3e6e Emoji: Update Emoji browser support tests for Twemoji v2.4.0
Replaces the fairy (male) browser support test with a woman in business suit levitating. While the things that make people different sometimes become less obvious this isn't always a problem, because the things that make you strange are the things that make you powerful.

Fixes #42862 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@42598 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-24 21:46:46 +00:00
Sergey Biryukov
4dec1ad477 Media: Store and reuse image cropper ratio settings if available, instead of overwriting.
Props adamsilverstein.
Fixes #42646.

git-svn-id: https://develop.svn.wordpress.org/trunk@42595 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-24 21:35:10 +00:00
Aaron Jorbin
47f6031fbd Query: Improve tests for set_found_posts dealing with non arrays
Use a data provider and include tests for `false` and `''`.

Previous: [42581] [42585]

See #42860



git-svn-id: https://develop.svn.wordpress.org/trunk@42594 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-24 20:51:06 +00:00