When existing scripts or styles are updated in default themes, the version numbers in the enqueues should also be bumped to make sure the old files don't cache. This update bumps version numbers for changes since version 5.0, for themes Twenty Eleven through Twenty Nineteen.
Fixes#45679.
git-svn-id: https://develop.svn.wordpress.org/trunk@44382 602fd350-edb4-49c9-b593-d223f7449a82
When the original block editor styles were added to the existing default themes, the button blocks were styled to match how each theme styled the `button` tag.
However, the styles should respect the block editor's default style, "Rounded", and allow switching to the other styles, like "Outlined" and "Square".
Fixes#45541.
git-svn-id: https://develop.svn.wordpress.org/trunk@44381 602fd350-edb4-49c9-b593-d223f7449a82
A change to the MediaElement.js caused Twenty Fourteen's custom video play button to display in the top corner, rather than centered. This update returns it to its correct position.
Props mmaumio, celloexpressions.
Fixes#44664.
git-svn-id: https://develop.svn.wordpress.org/trunk@44380 602fd350-edb4-49c9-b593-d223f7449a82
The button block in Twenty Fourteen was incorrectly inheriting a text underline from the theme's link styles.
Props bobbingwide.
Fixes#45732.
git-svn-id: https://develop.svn.wordpress.org/trunk@44378 602fd350-edb4-49c9-b593-d223f7449a82
The original theme description in Twenty Nineteen was intended as a placeholder; this update replaces it with a proper description, and removes the unnecessary `theme-options` tag.
Props jobthomas, kjellr.
Fixes#45693.
git-svn-id: https://develop.svn.wordpress.org/trunk@44377 602fd350-edb4-49c9-b593-d223f7449a82
The menu's original markup included some non-semantic tags and an unnecessary `tabindex` attribute that made it difficult to navigate via keyboard.
Props allancole, anevins, kjellr.
Fixes#45713.
git-svn-id: https://develop.svn.wordpress.org/trunk@44376 602fd350-edb4-49c9-b593-d223f7449a82
[43540] introduced changes to allow hijacking the cron implementation.
These changes were slated for 5.0, but have since been moved to the 5.1 release.
See #43540.
git-svn-id: https://develop.svn.wordpress.org/trunk@44375 602fd350-edb4-49c9-b593-d223f7449a82
Add a new filter `users_pre_query` - filters the users array before the query takes place. Return a non-null value to bypass WordPress's default user queries. Similar to the `posts_pre_query` filter for WP_Query added in #36687. This filter lets you short circuit the WP_User_Query MySQL query to return your own results.
Developers should note that filtering functions that require pagination information are encouraged to set the `total_users` property of the WP_User_Query object, passed to the filter by reference. If WP_User_Query does not perform a database query, it will not have enough information to generate these values itself.
Props tlovett1, birgire, boonebgorges, spacedmonkey.
Fixes#44169.
git-svn-id: https://develop.svn.wordpress.org/trunk@44373 602fd350-edb4-49c9-b593-d223f7449a82
Update right-aligned image block styles to push them outside of the text column on the front end, to match the original design and how the block looks in the editor.
Props kjellr, joen, allancole.
Fixes#45716.
git-svn-id: https://develop.svn.wordpress.org/trunk@44371 602fd350-edb4-49c9-b593-d223f7449a82
The outlined button block style was displaying white text on a white background on hover. This update makes sure the text remains legible on hover when this button style is applied.
Props rickalee, kjellr.
Fixes#45726.
git-svn-id: https://develop.svn.wordpress.org/trunk@44370 602fd350-edb4-49c9-b593-d223f7449a82
The "Continue Reading" link that's generated by the More block is styled to include an arrow next to the text; that arrow shouldn't inherit the text underline style. This update removes it.
Props littlebigthing, kjellr.
Fixes#45715.
git-svn-id: https://develop.svn.wordpress.org/trunk@44369 602fd350-edb4-49c9-b593-d223f7449a82
On pages and posts with featured images, the top level menu items have a slight transparency on hover, which was being inherited by their submenus. This update removes that inheritance, improving readability and consistency in the menu's appearance.
Props kjellr.
Fixes#45689.
git-svn-id: https://develop.svn.wordpress.org/trunk@44368 602fd350-edb4-49c9-b593-d223f7449a82
When the entry for `wp-cli.local.yml` was added in r30057, it included a trailing whitespace. Presumably, that doesn't cause any problems with some combinations of OS/SVN client/EOL markers/etc, but in some cases it will prevent the entry from being ignored. After removing the whitespace, the file is ignored as expected.
See #30134.
git-svn-id: https://develop.svn.wordpress.org/trunk@44362 602fd350-edb4-49c9-b593-d223f7449a82
After [44359] it is impossible to not use ES6 syntax for some logic in the `Gruntfile.js`, so adjust the `esversion` setting for the `Gruntfile.js` to 6. Because the previous setting in `.jshintrc` was not compatible with setting `esversion`, set the `esversion` in the `.jshintrc` explicitly.
See #44492.
git-svn-id: https://develop.svn.wordpress.org/trunk@44361 602fd350-edb4-49c9-b593-d223f7449a82
Re-add variable that was removed on accident by [44359]. Also run `grunt format:php` to adjust the code style.
.--This line, and those below, will be ignored--
M Gruntfile.js
M src/index.php
M src/wp-admin/index.php
M src/wp-includes/class-wp-block-parser.php
git-svn-id: https://develop.svn.wordpress.org/trunk@44360 602fd350-edb4-49c9-b593-d223f7449a82
After the JavaScript reorganization in [43309], it was no longer possible to test WordPress from the `src` folder. That meant a build step was required to test PHP modifications. That is suboptimal as even a simple copy is slower than a web server just serving the new file.
We achieve building to `src` by setting a `WORKING_DIR` constant in the Gruntfile that is `build` by default, but changes to `src` when the `--dev` flag is present on any Grunt command. We provide sensible defaults so some commands, such as copying `version.php`, always build to `build`.
Because testing from `build` is no longer required, we change the messages present in `index.php` and `wp-admin/index.php` to be more broadly about building WordPress.
We also change the webpack config to have more straightforward behavior based on the `buildTarget` argument. It only determines the build target now and has no implicit behavior anymore. `grunt build` still works as it worked before, to make sure that the build server produces the same `wordpress.zip` we are used to.
We do all this instead of a symlink setup because symlinks don't work on every platform.
Props omarreiss, netweb, flixos90, SergeyBiryukov.
Fixes#44492.
git-svn-id: https://develop.svn.wordpress.org/trunk@44359 602fd350-edb4-49c9-b593-d223f7449a82
The theme's original navigation JavaScript was making it so all links on a site were immediately followed on touchstart when using a touch-enabled device. This update makes sure links are followed at touchend, to improve usability and menu behavior.
Already committed to the 5.0 branch in [44357].
Props anevins, panchen, kjellr.
Fixes#45510.
git-svn-id: https://develop.svn.wordpress.org/trunk@44358 602fd350-edb4-49c9-b593-d223f7449a82
This reverts [44354] for more investigation into inconsistent password strength values that passed locally prior to commit.
Unprops omarreiss, netweb, desrosj.
See #43749.
git-svn-id: https://develop.svn.wordpress.org/trunk@44356 602fd350-edb4-49c9-b593-d223f7449a82
Version 4.2.2 of the zxcvbn password strength library has several bug fixes. A full list of changes can be seen here: https://github.com/dropbox/zxcvbn/compare/v4.4.1...v4.4.2.
This commit also adds the library as a project dependency, making it easier to update in the future. Because the dictionary within the library contains non-PG language, a `rot13:zxcvbn` task has been added to Grunt to perform a ROT-13 cipher on the library. This task has been added to `grunt build` and `grunt build:js`.
Props omarreiss, netweb, desrosj.
Fixes#43749.
git-svn-id: https://develop.svn.wordpress.org/trunk@44354 602fd350-edb4-49c9-b593-d223f7449a82
Currently, when an SVG is used as a menu icon, the color is inconsistent with the other, default dashicons and the contrast ratio does not meet the minimum requirement for accessibility.
This updates the base color for the default `fresh` color scheme to ensure consistency and proper contrast.
Props swift, dschalk.
Fixes#44209.
git-svn-id: https://develop.svn.wordpress.org/trunk@44353 602fd350-edb4-49c9-b593-d223f7449a82
The `! is_null()` portion of the condition is unnecessary, because `isset()` checks whether a variable is set *and* is not null.
Props JPry.
Fixes#44927.
git-svn-id: https://develop.svn.wordpress.org/trunk@44351 602fd350-edb4-49c9-b593-d223f7449a82
* `plugin_loaded`: Fires once a single activated plugin has loaded.
* `mu_plugin_loaded`: Fires once a single must-use plugin has loaded.
* `network_plugin_loaded`: Fires once a single network-activated plugin has loaded.
Props Rarst, schlessera.
Fixes#41346.
git-svn-id: https://develop.svn.wordpress.org/trunk@44344 602fd350-edb4-49c9-b593-d223f7449a82
In [44185], a bug was introduced where hierarchical post types would not display in the correct default order (hierarchically).
This was caused by a `! isset()` check, which returned `false` after [44185], causing the correct default value to not be applied. This switches that conditional to use an `empty()` check, ignoring the new empty string assignment that was added to prevent a PHP notice when `compact()` is called.
Props davidbinda.
Fixes#45711.
git-svn-id: https://develop.svn.wordpress.org/trunk@44338 602fd350-edb4-49c9-b593-d223f7449a82
Also adds a note to the description explaining that it can be used in place of `add_post_meta()`.
See #42505.
git-svn-id: https://develop.svn.wordpress.org/trunk@44334 602fd350-edb4-49c9-b593-d223f7449a82
Jonathan Desrosiers
laurelfulford
Aaron Jorbin
Peter Wilson
Adam Silverstein
Boone Gorges
Sergey Biryukov
Pascal Birchler
Ian Dunn
Anton Timmermans
Drew Jaynes