Commit Graph

33082 Commits

Author SHA1 Message Date
Drew Jaynes 688916d200 Docs: Fix a typo in the 4.4.0 changlog entry in the `intermediate_image_sizes_advanced` hook doc.
Props morganestes.
Fixes #35190.


git-svn-id: https://develop.svn.wordpress.org/trunk@36054 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-21 22:23:11 +00:00
Andrea Fercia 9c8c6955a9 Accessibility: Remove the revisions limit title attribute from the Publish box.
The revisions limit warning is now always displayed in plain text even when the
limit is not reached yet. Removes the plus "+" from the revisions count number.

Fixes #35029.

git-svn-id: https://develop.svn.wordpress.org/trunk@36053 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-21 14:38:32 +00:00
John Blackbourn ec143694f7 Tests: Prevent role capability pollution in `Tests_Post_GetPostsByAuthorSql::test_user_has_access_only_to_private_posts_for_certain_post_types()`.
git-svn-id: https://develop.svn.wordpress.org/trunk@36050 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-21 07:15:33 +00:00
John Blackbourn b637e77c5a Tests: Fix all the things.
See #30017, #32394


git-svn-id: https://develop.svn.wordpress.org/trunk@36049 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-21 07:09:43 +00:00
johnbillion 8b5747a108 Query: Re-initialise any dynamically-added public query vars before running the public query vars test.
See #35115


git-svn-id: https://develop.svn.wordpress.org/trunk@36048 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-21 06:59:05 +00:00
John Blackbourn 8567d80ade Tests: Shave a second off the user capability tests by reusing its user fixtures.
See #30017, #32394


git-svn-id: https://develop.svn.wordpress.org/trunk@36047 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-21 06:56:57 +00:00
John Blackbourn da84910c8a Query: Introduce a unit test which will fail when new public query vars are introduced without also updating the test. This adds an extra layer of explicitness to introducing public query vars in order to avoid introducing unintentional clashes with URL query vars that are already in use.
See #35115 


git-svn-id: https://develop.svn.wordpress.org/trunk@36045 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-21 05:48:24 +00:00
John Blackbourn da011967e7 Login: Revert [34213] and [35897]. It has become apparent that there is a need for a separate function (and corresponding filter) which allows for the login form action URL to differ from the URL used to access the login form, so that plugins or implementations which change the login URL do not need to worry about handling the form submission at the same URL.
For now, we'll revert to the pre-4.4 behaviour of hard-coding the login form action URL as `wp-login.php` and look at implementing a separate function and corresponding filter in 4.5.

Props KrissieV, salcode, JPry
Fixes #34925
See #35103


git-svn-id: https://develop.svn.wordpress.org/trunk@36042 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-21 03:22:32 +00:00
Boone Gorges 817013978d Respect approval status when determining comment page count in `comments_template()`.
Since 4.4, when fetching the first page of comments and the 'newest' comments
are set to display first, `comments_template()` must perform arithmetic to
determine which comments to show. See #8071. This arithmetic requires the
total comment count for the current post, which is calculated with a separate
`WP_Comment_Query`. This secondary comment query did not properly account for
non-approved comment statuses; all unapproved comments should be part of the
comment count for admins, and individual users should have their own
unapproved comments included in the count. As a result, `comments_template()`
was, in some cases, being fooled into thinking that a post had fewer comments
available for pagination than it actually had, which resulted in empty pages
of comments.

We correct this problem by mirroring 'status' and 'include_unapproved' params
of the main comment query within the secondary query used to calculate
pagination.

Fixes #35068.

git-svn-id: https://develop.svn.wordpress.org/trunk@36040 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-21 03:06:41 +00:00
John Blackbourn 4024cb673a Comments: When a comment is submitted, ensure the `user_ID` element in the array that's passed to the `preprocess_comment` filter gets populated.
Fixes #34997


git-svn-id: https://develop.svn.wordpress.org/trunk@36038 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-21 02:46:44 +00:00
Gary Pendergast 59b8f0da7c Texturize: Transform `&` into `&` in tag attributes.
[35709] was overly broad, and stopped transforming `&` characters within tag attributes. So that sites aren't generating invalid HTML, we need to restore this functionality, while continuing to not transform `&` within blocked tags.

Fixes #35008 for trunk.



git-svn-id: https://develop.svn.wordpress.org/trunk@36036 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-21 02:42:30 +00:00
Gary Pendergast d6bf586de3 Query: Remove `title` from the public query vars list.
[33706] added `title` as a public query var, but there's not really a practical need for this, and it interferes with any plugin that uses `title` as a query var for itself.

Props tyxla.

Fixes #35115 for trunk.



git-svn-id: https://develop.svn.wordpress.org/trunk@36034 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-21 00:42:43 +00:00
Drew Jaynes 2213bfba0c Docs: Add missing notations for the optional `$tab_index` and `$extended` parameters in the DocBlock for the deprecated `the_editor()` function.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36033 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-20 21:20:14 +00:00
Andrea Fercia c8c1014a01 Accessibility: Remove title attributes from the updates links on the Plugin and Themes list tables.
Adds `aria-label` attributes on some links and on the "update nag" link. Adds translator comments.

Fixes #35167.

git-svn-id: https://develop.svn.wordpress.org/trunk@36032 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-20 16:08:38 +00:00
Andrew Ozz 58b7d3e136 Responsive images: fix calculations when determining whether to include particular image file in `srcset`.
Props joemcgill.
Fixes #34955 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@36031 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-20 02:38:34 +00:00
Drew Jaynes c593ceb5e8 Docs: Add missing parameter and return notations to the DocBlock for the deprecated `get_usernumposts()` function.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36030 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-19 19:40:28 +00:00
Eric Andrew Lewis 07c62c3c5f Docs: Add documentation to wp-blog-header.php.
Fixes #35161.


git-svn-id: https://develop.svn.wordpress.org/trunk@36029 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-19 11:19:57 +00:00
Drew Jaynes 6e8b83cb65 Docs: Add missing parameter and return notations in the DocBlock for `get_profile()`.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36028 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-19 09:03:11 +00:00
Drew Jaynes 44fc67cc24 Docs: Properly mark the `$classname` parameter as optional.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36027 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-19 08:59:49 +00:00
Drew Jaynes bb8067b666 Docs: Add missing parameter and return notations to the DocBlock for the deprecated `wp_specialchars()` function.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36026 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-19 08:57:49 +00:00
Drew Jaynes a052a682a1 Docs: Add missing parameter notations and descriptions in the DocBlock for `get_link()`.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36025 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-19 08:53:55 +00:00
Drew Jaynes e2be10ec2c Docs: Add missing parameter and return notations in the DocBlock for the deprecated `_nc()` function.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36024 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-19 08:47:12 +00:00
Drew Jaynes 62e657a2f0 Docs: Add a missing summary, parameter, and return descriptiosn to the DocBlock for the deprecated function, `get_linkrating()`.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36023 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-19 08:23:00 +00:00
Drew Jaynes a2f5cdb5bb Docs: Add a missing notation for the `$gmt_time` parameter in the DocBlock for `spawn_cron()`.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36022 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-19 08:19:54 +00:00
Drew Jaynes f8119eef50 Docs: Add missing DocBlocks for `hash_hmac()` and `_hash_hmac()`.
Both will be ignored from parsing as and serve as compat functions for PHP's `hash_hmac()`.

Introduced in [18111].

See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36021 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-19 05:10:29 +00:00
Drew Jaynes 64592f8c0b Docs: Fix inline comment syntax in `_mb_strlen()`, an internal compat method for `mb_strlen()`.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36020 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-19 04:58:59 +00:00
Drew Jaynes df9291938c Docs: Add missing DocBlocks for `mb_strlen()` and `_mb_strlen()`.
Both will be ignored from parsing as and serve as compat functions for PHP's `mb_strlen()`, which is not enabled by default.

Introduced in [32114].

See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36019 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-19 04:55:50 +00:00
Drew Jaynes 73b701b030 Docs: Fix inline comment syntax in `_mb_substr()`, an internal compat method for `mb_substr()`.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36018 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-19 04:49:42 +00:00
Drew Jaynes c848b5f670 Docs: Add missing DocBlocks for `mb_substr()` and `_mb_substr()`.
Both will be ignored from parsing as and serve as compat functions for PHP's `mb_substr()`, which is not enabled by default.

Introduced in [17621].

See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36017 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-19 04:46:43 +00:00
Andrea Fercia c69509b2ab Accessibility: Remove title attributes and improve accessibility on the "no-js" Menus screen.
When JavaScript is off, the reorder menu item and Edit menu item links now use `aria-label`
attributes instead of title attributes.

Fixes #35134.

git-svn-id: https://develop.svn.wordpress.org/trunk@36016 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-19 00:16:30 +00:00
Andrea Fercia 6295e19072 Accessibility: Remove title attributes from the Theme browser.
Also, adds translators comments and removes a no more used variable, see [27748].

Fixes #35140.

git-svn-id: https://develop.svn.wordpress.org/trunk@36015 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-18 23:59:07 +00:00
Andrea Fercia 82e5450328 Accessibility: Improvements for the Authentication Check modal dialog "Close X".
Removes the title attribute and uses a `<button>` element instead of a `<div>`.
Also simplifies the CSS and takes care of the hover/focus style.

Fixes #35142.

git-svn-id: https://develop.svn.wordpress.org/trunk@36014 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-18 23:50:13 +00:00
Drew Jaynes fe89f7620f Docs: Add missing parameter and return descriptions to the DocBlocks for `_wp_object_name_sort_cb()` and `_wp_object_count_sort_cb()`, both `uasort()` callbacks.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36013 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-18 23:37:58 +00:00
Drew Jaynes 96c5ced339 Docs: Add a missing notation for the `$context` parameter in the DocBlock for `_nx_noop()`.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36012 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-18 23:15:50 +00:00
Drew Jaynes f8fc65acb3 Docs: Fix the syntax for the `get_previous_post_link()` DocBlock to ensure it's read and parsed as such instead of as a multi-line comment.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36011 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-18 23:13:03 +00:00
Drew Jaynes df5f99d5e3 Docs: Add a missing summary, description, and `@since` version to the DocBlock for `wp_redirect_admin_locations()`.
Introduced in [19880].

See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36010 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-18 23:07:53 +00:00
Drew Jaynes cb6348b7ce Docs: Add a missing notation for the `$bookmark_id` parameter in the DocBlock for `clean_bookmark_cache()`.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36009 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-18 23:00:07 +00:00
Boone Gorges aa38888d60 Add `current-cat-ancestor` class to ancestor items in `wp_list_categories()`.
Pairs nicely with `current-cat-parent`.

Props jrchamp, swisssipdy, ardathksheyna, wonderboymusic.
Fixes #10676.

git-svn-id: https://develop.svn.wordpress.org/trunk@36008 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-18 18:37:41 +00:00
Aaron Jorbin 3969f2968f Remove RDIO from oEmbed providers
RDIO is shutting down. https://www.rdio.com/farewell/

Props swissspidy
Fixes #35152



git-svn-id: https://develop.svn.wordpress.org/trunk@36007 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-18 18:15:28 +00:00
Boone Gorges 6d9f50febd Ensure that `wp_list_categories()` supports comma-separated lists for 'exclude' and 'exclude_tree'.
[34696] introduced a regression whereby comma-separated values for 'exclude'
and 'exclude_tree' would be handled improperly when merging the two parameters,
resulting in category IDs being incorrectly dropped from the combined array.

Props gblsm, hnle.
Fixes #35156.

git-svn-id: https://develop.svn.wordpress.org/trunk@36005 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-18 18:11:44 +00:00
Boone Gorges fdeed90e77 Ensure `get_terms()` results are unique when using 'meta_query'.
The introduction of 'meta_query' to `get_terms()` in 4.4 made it possible for
`get_terms()` to erroneously return duplicate results. To address the issue,
we add the `DISTINCT` keyword to the SQL query when a 'meta_query' parameter
has been provided.

Props @jadpm.
Fixes #35137.

git-svn-id: https://develop.svn.wordpress.org/trunk@36003 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-18 17:43:46 +00:00
Sergey Biryukov cca910fcbd Docs: Fix copy/paste error in `wp_remote_retrieve_cookies()` description.
Props mark8barnes.
Fixes #35157.

git-svn-id: https://develop.svn.wordpress.org/trunk@36002 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-18 17:22:52 +00:00
Sergey Biryukov 6c95087f20 Widgets: Add missing closing tag for spinner after [35317].
Props rabmalin.
Fixes #35150.

git-svn-id: https://develop.svn.wordpress.org/trunk@36001 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-18 12:01:56 +00:00
Andrea Fercia 398a2996ae Accessibility: Remove the title attribute from the Featured Image postbox thumbnail.
The title attribute is now replaced with plain text in a `howto` paragraph, as done for example in the Tags postbox.
Adds an `aria-describedby` attribute on the thumbnail link to target the description.
Also, fixes the focus style on the featured image thumbnail.

Fixes #35076.

git-svn-id: https://develop.svn.wordpress.org/trunk@36000 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-17 23:43:57 +00:00
Pascal Birchler e7417c56ce Editor: Correctly indent definition lists when switching from the visual to the text editor.
Props ocean90, katieburch.
Fixes #23299.

git-svn-id: https://develop.svn.wordpress.org/trunk@35999 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-17 23:05:09 +00:00
Andrea Fercia 7998e04c48 Accessibility: Remove title attributes from the Link Manager screen.
Title attributes are now replaced with `aria-label` where appropriate.
Also fixes some typos in the DocBlocks.

Fixes #35135.

git-svn-id: https://develop.svn.wordpress.org/trunk@35998 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-17 22:52:27 +00:00
Pascal Birchler 0162f5534a Remove unused variables after [35995] and [35996].
See #34439.

git-svn-id: https://develop.svn.wordpress.org/trunk@35997 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-17 18:40:39 +00:00
Pascal Birchler a072ac113b Network Admin: Remove the list of files which will be deleted when deleting a theme.
Fixes #34439.

git-svn-id: https://develop.svn.wordpress.org/trunk@35996 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-17 18:34:21 +00:00
Pascal Birchler 6d6eb08d8d Plugins: Remove the list of files which will be deleted when uninstalling a plugin.
See #34439.

git-svn-id: https://develop.svn.wordpress.org/trunk@35995 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-17 18:30:55 +00:00
Pascal Birchler ab8cff7827 In `WP::handle_404()`, make sure `$wp_query->post` is a `WP_Post` object before cloning it.
Props igmoweb for initial patch.
See #35013.

git-svn-id: https://develop.svn.wordpress.org/trunk@35994 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-17 18:12:50 +00:00