Commit Graph

424 Commits

Author SHA1 Message Date
Andrew Nacin
40623f1c68 Use sanitize_key() instead of esc_sql() when 'escaping' variable DB field names. see #21767.
git-svn-id: https://develop.svn.wordpress.org/trunk@24714 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-16 14:21:05 +00:00
Ryan Boren
687d1a2ce9 Pinking shears
git-svn-id: https://develop.svn.wordpress.org/trunk@24303 602fd350-edb4-49c9-b593-d223f7449a82
2013-05-20 12:10:58 +00:00
Sergey Biryukov
b168677133 Correct inline docs for wp_delete_term(). fixes #24343.
git-svn-id: https://develop.svn.wordpress.org/trunk@24261 602fd350-edb4-49c9-b593-d223f7449a82
2013-05-15 08:10:52 +00:00
Sergey Biryukov
1df0c7277c Remove unnecessary error suppression from get_terms(). fixes #21887.
git-svn-id: https://develop.svn.wordpress.org/trunk@23599 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-04 02:52:43 +00:00
Sergey Biryukov
2158fa203b Fix array formatting. props WraithKenny. fixes #21210.
git-svn-id: https://develop.svn.wordpress.org/trunk@23598 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-04 02:48:20 +00:00
Ryan Boren
6d2a8d2ef0 Use wp_unslash() instead of stripslashes() and stripslashes_deep(). Use wp_slash() instead of add_magic_quotes().
see #21767


git-svn-id: https://develop.svn.wordpress.org/trunk@23594 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-03 21:11:40 +00:00
Ryan Boren
c363aea627 Revert 23416, 23419, 23445 except for wp_reset_vars() changes. We are going a different direction with the slashing cleanup, so resetting to a clean slate. see #21767
git-svn-id: https://develop.svn.wordpress.org/trunk@23554 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-01 16:28:40 +00:00
Sergey Biryukov
da77df683e Make wp_remove_object_terms() return false if nothing has been deleted. props kovshenin. fixes #15475.
git-svn-id: https://develop.svn.wordpress.org/trunk@23552 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-01 16:22:07 +00:00
Sergey Biryukov
6a59a28f12 Rename 'no_tagcloud' taxonomy label to 'not_found', for consistency with the post type label of the same key. fixes #23597.
git-svn-id: https://develop.svn.wordpress.org/trunk@23484 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-25 19:39:38 +00:00
Sergey Biryukov
41919e97fb Move 'no_tagcloud' argument to the taxonomy labels object. props DrewAPicture for initial patch. fixes #23597.
git-svn-id: https://develop.svn.wordpress.org/trunk@23483 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-25 18:35:05 +00:00
Ryan Boren
a6c8efadb9 Change all core API to expect unslashed rather than slashed arguments.
The exceptions to this are update_post_meta() and add_post_meta() which are often used by plugins in POST handlers and will continue accepting slashed data for now.

Introduce wp_upate_post_meta() and wp_add_post_meta() as unslashed alternatives to update_post_meta() and add_post_meta(). These functions could become methods in WP_Post so don't use them too heavily yet.

Remove all escape() calls from wp_xmlrpc_server. Now that core expects unslashed data this is no longer needed.

Remove addslashes(), addslashes_gpc(), add_magic_quotes() calls on data being prepared for handoff to core functions that until now expected slashed data. Adding slashes in no longer necessary.

Introduce wp_unslash() and use to it remove slashes from GPCS data before using it in core API. Almost every instance of stripslashes() in core should now be wp_unslash(). In the future (a release or three) when GPCS is no longer slashed, wp_unslash() will stop stripping slashes and simply return what is passed. At this point wp_unslash() calls can be removed from core.

Introduce wp_slash() for slashing GPCS data. This will also turn into a noop once GPCS is no longer slashed. wp_slash() should almost never be used. It is mainly of use in unit tests.

Plugins should use wp_unslash() on data being passed to core API.

Plugins should no longer slash data being passed to core. So when you get_post() and then wp_insert_post() the post data from get_post() no longer needs addslashes(). Most plugins were not bothering with this. They will magically start doing the right thing. Unfortunately, those few souls who did it properly will now have to avoid calling addslashes() for 3.6 and newer.

Use wp_kses_post() and wp_kses_data(), which expect unslashed data, instead of wp_filter_post_kses() and wp_filter_kses(), which expect slashed data. Filters are no longer passed slashed data.

Remove many no longer necessary calls to $wpdb->escape() and esc_sql().

In wp_get_referer() and wp_get_original_referer(), return unslashed data.

Remove old stripslashes() calls from WP_Widget::update() handlers. These haven't been necessary since WP_Widget.

Switch several queries over to prepare().

Expect something to break.

Props alexkingorg
see #21767


git-svn-id: https://develop.svn.wordpress.org/trunk@23416 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-14 22:51:06 +00:00
Ryan Boren
77e5536195 Use microtime() instead of incrementors for last_changed to to avoid race conditions with cache evictions.
Props westi
fixes #23448


git-svn-id: https://develop.svn.wordpress.org/trunk@23401 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-11 18:08:14 +00:00
Mark Jaquith
9f02654b0d Introduce wp_remove_object_terms() and wp_add_object_terms(). No more fetch-alter-update nonsense. Use wp_remove_object_terms() in a few places internally.
props simonwheatley, scribu, ericmann, maxcutler. fixes #15475

git-svn-id: https://develop.svn.wordpress.org/trunk@23398 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-08 18:45:34 +00:00
Ryan Boren
8b07ad9884 Use incrementors for cache invalidation in get_terms().
fixes #23326
see #23173


git-svn-id: https://develop.svn.wordpress.org/trunk@23384 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-04 13:48:46 +00:00
Ryan Boren
bf812ac283 Clear the object term relationships cache in wp_set_object_terms() rather than wp_set_post_terms(). This should be done lower in the stack than wp_set_post_terms().
Props batmoo
fixes #22560


git-svn-id: https://develop.svn.wordpress.org/trunk@22878 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-27 19:42:38 +00:00
Ryan Boren
6d8bce688f Pinking shears
git-svn-id: https://develop.svn.wordpress.org/trunk@22634 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-17 15:11:29 +00:00
Andrew Nacin
fb1ce7ae11 Use correct variable. props picklewagon. fixes #22394.
git-svn-id: https://develop.svn.wordpress.org/trunk@22476 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-09 00:16:30 +00:00
Andrew Nacin
51f16233ac Only call wp_get_object_terms() if get_object_term_cache() says there is no cache (false), which is different than no terms. props wonderboymusic, fixes #16505.
git-svn-id: https://develop.svn.wordpress.org/trunk@22433 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-07 20:00:51 +00:00
Andrew Nacin
e23582cd09 Treat a single taxonomy passed as an array the same as when passed as a string in get_terms(). props wonderboymusic, fixes #17955.
git-svn-id: https://develop.svn.wordpress.org/trunk@22417 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-07 09:03:40 +00:00
Jon Cave
c8c4a683c1 Fix documentation typo: s/WP_Erorr/WP_Error/. See #21593.
git-svn-id: https://develop.svn.wordpress.org/trunk@22309 602fd350-edb4-49c9-b593-d223f7449a82
2012-10-25 22:29:37 +00:00
Ryan Boren
f27a713d56 Return WP_Error when registering a taxonomy that exceeds 32 characters.
Props ocean90.
fixes #21593


git-svn-id: https://develop.svn.wordpress.org/trunk@22307 602fd350-edb4-49c9-b593-d223f7449a82
2012-10-25 22:12:02 +00:00
Ryan Boren
7ba5099795 Objects no longer need to be explicitly passed by ref to call_user_func*() to be callable. Props wonderboymusic. fixes #21865
git-svn-id: https://develop.svn.wordpress.org/trunk@22118 602fd350-edb4-49c9-b593-d223f7449a82
2012-10-04 20:00:16 +00:00
Ryan Boren
e22b981706 Avoid 'Only variables should be assigned by reference' warning. Props wonderboymusic. see #21865
git-svn-id: https://develop.svn.wordpress.org/trunk@22114 602fd350-edb4-49c9-b593-d223f7449a82
2012-10-04 18:21:47 +00:00
Ryan Boren
ca14391917 An empty taxonomy query should return no results rather than all posts. Props wonderboymusic. fixes #20604
git-svn-id: https://develop.svn.wordpress.org/trunk@22109 602fd350-edb4-49c9-b593-d223f7449a82
2012-10-04 13:16:47 +00:00
Andrew Nacin
774a12be83 Introduce constants to allow for easier expression of time periods in seconds. Adds MINUTE_IN_SECONDS, HOUR_IN_SECONDS, DAY_IN_SECONDS, WEEK_IN_SECONDS, YEAR_IN_SECONDS. props nbachiyski, SergeyBiryukov. fixes #20987.
git-svn-id: https://develop.svn.wordpress.org/trunk@21996 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-25 05:26:19 +00:00
Andrew Nacin
6c3655ce31 Don't repeatedly call get_object_taxonomies() in clean_object_term_cache(). see #11399.
git-svn-id: https://develop.svn.wordpress.org/trunk@21951 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-22 15:21:30 +00:00
Ryan Boren
2c8fd31155 Pass a term object to the delete_term actions. Props bigdawggi. fixes #20645
git-svn-id: https://develop.svn.wordpress.org/trunk@21939 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-21 13:27:56 +00:00
Andrew Nacin
2815798357 Make WP_Tax_Query::transform_query() public. props scribu. fixes #21684.
git-svn-id: https://develop.svn.wordpress.org/trunk@21863 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-15 20:17:03 +00:00
Andrew Nacin
c1d96d72b4 Update docs to reflect that wp_count_terms() can return WP_Error when the taxonomy does not exist. props SergeyBiryukov, fixes #21888.
git-svn-id: https://develop.svn.wordpress.org/trunk@21843 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-14 16:11:30 +00:00
Ryan Boren
879cb8231b Remove unnecessary return by refs. Props wonderboymusic. fixes #21839
git-svn-id: https://develop.svn.wordpress.org/trunk@21792 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-10 17:00:11 +00:00
Andrew Nacin
bcf58b34c4 Allow easy registration of taxonomy columns on post (and custom post type) list table screens.
To register a column for a list table, use the new manage_taxonomies_for_{$post_type}_columns
filter. Introduces show_admin_column => true for register_taxonomy(), which automatically
displays that column on all associated post types.

props jtsternberg, SergeyBiryukov for initial patches.
fixes #21240.



git-svn-id: https://develop.svn.wordpress.org/trunk@21788 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-08 03:18:36 +00:00
Ryan Boren
2bebcee04f Return WP_Error if the db insert in wp_set_object_terms() fails. Props jndetlefsen. fixes #21800
git-svn-id: https://develop.svn.wordpress.org/trunk@21766 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-05 17:57:53 +00:00
Andrew Nacin
f8b0fb06fe Validate $order in wp_get_object_terms(). props duck_.
git-svn-id: https://develop.svn.wordpress.org/trunk@21758 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-05 01:23:53 +00:00
Ryan Boren
de06b81360 Remove return ref from all calls to get_post()
Return WP_Post from get_default_post_to_edit()
Replace all calls to get_page() with get_post()
see #21309


git-svn-id: https://develop.svn.wordpress.org/trunk@21597 602fd350-edb4-49c9-b593-d223f7449a82
2012-08-23 20:01:10 +00:00
Ryan Boren
30218d5ea5 Introduce WP_Post class. Clean up ancestors handling. Props scribu, toppa. fixes #10381 see #21309
git-svn-id: https://develop.svn.wordpress.org/trunk@21559 602fd350-edb4-49c9-b593-d223f7449a82
2012-08-20 19:47:52 +00:00
Ryan Boren
962a3ff664 Reduce calls to sanitize_title_with_dashes in register_(post_type|taxonomy). Props ocean90. fixes #21600
git-svn-id: https://develop.svn.wordpress.org/trunk@21553 602fd350-edb4-49c9-b593-d223f7449a82
2012-08-20 17:25:06 +00:00
Andrew Nacin
56dd6e86a3 Add term_taxonomy_id field handling to WP_Tax_Query::transform_query(), allowing the transformation to be bypassed when tt ids are passed.
props wonderboymusic.
fixes #21228.



git-svn-id: https://develop.svn.wordpress.org/trunk@21552 602fd350-edb4-49c9-b593-d223f7449a82
2012-08-20 16:49:21 +00:00
Andrew Nacin
9931c1a45d Hide the link manager from the UI on upgrade, if the site has no links. New DB option, link_manager_enabled.
Enforce this by denying the 'manage_links' capability, which hides the All Links, Add New Link, and Link Categories screens. Hide WP_Widget_Links and the UI for the default_link_category as well.

Convert all references to 'posts and links' when handling reassignment on user deletion to just 'posts'.

see #21307.



git-svn-id: https://develop.svn.wordpress.org/trunk@21501 602fd350-edb4-49c9-b593-d223f7449a82
2012-08-13 16:18:42 +00:00
Ryan Boren
585d42c273 Consolodate some strings. Props pavelevap. fixes #20809
git-svn-id: https://develop.svn.wordpress.org/trunk@20972 602fd350-edb4-49c9-b593-d223f7449a82
2012-06-01 19:05:30 +00:00
Andrew Nacin
beac0e2e0f Add view_item to the phpdoc for get_taxonomy_labels(). props Caspie. fixes #20406.
git-svn-id: https://develop.svn.wordpress.org/trunk@20436 602fd350-edb4-49c9-b593-d223f7449a82
2012-04-11 20:08:30 +00:00
Andrew Nacin
54a6a40533 Introduce $wpdb->delete(). props justindgivens, scribu. fixes #18948.
git-svn-id: https://develop.svn.wordpress.org/trunk@20287 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-24 15:24:31 +00:00
Jon Cave
cafa8dab24 Reduce references to the $wp_rewrite global because it's no longer used or a wrapper function can be used instead. Fixes #14546.#14546.
git-svn-id: https://develop.svn.wordpress.org/trunk@20023 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-28 20:29:33 +00:00
Jon Cave
5fcb582c25 Stop invalid SQL syntax by bailing from wp_get_object_terms() if $object_ids or $taxonomies is empty. Props batmoo. Fixes #19952.
git-svn-id: https://develop.svn.wordpress.org/trunk@19975 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-21 20:20:50 +00:00
Jon Cave
35eae452e8 Taxonomy rewrite generation when turning on permalinks, r18443 for taxonomies. Props SergeyBiryukov. Fixes #19794.
git-svn-id: https://develop.svn.wordpress.org/trunk@19930 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-15 17:30:37 +00:00
Jon Cave
a60932bf66 Post formats should show_in_nav_menus when the current theme supports them. Props filosofo, nacin. Fixes #16390.
git-svn-id: https://develop.svn.wordpress.org/trunk@19876 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-08 17:12:02 +00:00
Jon Cave
6a7fe5b25c Use new $args parameter for (WP_Rewrite::)add_permastruct(). Fixes #16092.
Use array_intersect_key() to keep WP_Rewrite::$extra_permastructs free of unnecessary/unknown keys + values.


git-svn-id: https://develop.svn.wordpress.org/trunk@19779 602fd350-edb4-49c9-b593-d223f7449a82
2012-01-28 21:00:59 +00:00
Andrew Nacin
28cfc3cd49 Correct logic inversion. #19275.
git-svn-id: https://develop.svn.wordpress.org/trunk@19742 602fd350-edb4-49c9-b593-d223f7449a82
2012-01-23 20:10:01 +00:00
Andrew Nacin
7140ded1cc Clean up and better document create_initial_taxonomies(). see #19275.
git-svn-id: https://develop.svn.wordpress.org/trunk@19741 602fd350-edb4-49c9-b593-d223f7449a82
2012-01-23 19:58:26 +00:00
Andrew Nacin
8900888567 Add 'ep_mask' as an argument to the 'rewrite' array for register_post_type() and register_taxonomy(). Keeps 'permalink_epmask' compatible as an argument for post type registrations. Fixes endpoints for category and tag pages. fixes #19275.
git-svn-id: https://develop.svn.wordpress.org/trunk@19738 602fd350-edb4-49c9-b593-d223f7449a82
2012-01-23 19:12:04 +00:00
Ryan Boren
77958da0d2 Update register_taxonomy_for_object_type() phpdoc to reflect that the post_type must be a string only, no arrays allowed. Props transom. fixes #19795
git-svn-id: https://develop.svn.wordpress.org/trunk@19730 602fd350-edb4-49c9-b593-d223f7449a82
2012-01-11 21:39:01 +00:00